[{"id":1775606,"web_url":"http://patchwork.ozlabs.org/comment/1775606/","msgid":"","list_archive_url":null,"date":"2017-09-26T14:58:40","subject":"Re: [PATCH 05/10] clk: bcm: Add Broadcom Hurricane 2 clock support","submitter":{"id":69381,"url":"http://patchwork.ozlabs.org/api/people/69381/","name":"Jon Mason","email":"jon.mason@broadcom.com"},"content":"On Mon, Sep 25, 2017 at 8:09 PM, Florian Fainelli wrote:\n> Add support for the Broadcom Hurricane 2 SoC clock controller. We can\n> re-use the existing iProc clock library since the SoC's architecture is\n> largely the same as its predecessors.\n>\n> Signed-off-by: Florian Fainelli \n> ---\n> drivers/clk/bcm/Kconfig | 9 +++++++++\n> drivers/clk/bcm/Makefile | 1 +\n> drivers/clk/bcm/clk-hr2.c | 27 +++++++++++++++++++++++++++\n> 3 files changed, 37 insertions(+)\n> create mode 100644 drivers/clk/bcm/clk-hr2.c\n>\n> diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig\n> index 1d9187df167b..4c4bd85f707c 100644\n> --- a/drivers/clk/bcm/Kconfig\n> +++ b/drivers/clk/bcm/Kconfig\n> @@ -30,6 +30,15 @@ config CLK_BCM_CYGNUS\n> help\n> Enable common clock framework support for the Broadcom Cygnus SoC\n>\n> +config CLK_BCM_HR2\n> + bool \"Broadcom Hurricane 2 clock support\"\n> + depends on ARCH_BCM_HR2 || COMPILE_TEST\n> + select COMMON_CLK_IPROC\n> + default ARCH_BCM_HR2\n> + help\n> + Enable common clock framework support for the Broadcom Hurricane 2\n> + SoC\n> +\n> config CLK_BCM_NSP\n> bool \"Broadcom Northstar/Northstar Plus clock support\"\n> depends on ARCH_BCM_5301X || ARCH_BCM_NSP || COMPILE_TEST\n> diff --git a/drivers/clk/bcm/Makefile b/drivers/clk/bcm/Makefile\n> index a0c14fa4aa1e..755144195541 100644\n> --- a/drivers/clk/bcm/Makefile\n> +++ b/drivers/clk/bcm/Makefile\n> @@ -8,6 +8,7 @@ obj-$(CONFIG_ARCH_BCM2835) += clk-bcm2835.o\n> obj-$(CONFIG_ARCH_BCM2835) += clk-bcm2835-aux.o\n> obj-$(CONFIG_ARCH_BCM_53573) += clk-bcm53573-ilp.o\n> obj-$(CONFIG_CLK_BCM_CYGNUS) += clk-cygnus.o\n> +obj-$(CONFIG_CLK_BCM_HR2) += clk-hr2.o\n> obj-$(CONFIG_CLK_BCM_NSP) += clk-nsp.o\n> obj-$(CONFIG_CLK_BCM_NS2) += clk-ns2.o\n> obj-$(CONFIG_CLK_BCM_SR) += clk-sr.o\n> diff --git a/drivers/clk/bcm/clk-hr2.c b/drivers/clk/bcm/clk-hr2.c\n> new file mode 100644\n> index 000000000000..f7c5b7379475\n> --- /dev/null\n> +++ b/drivers/clk/bcm/clk-hr2.c\n> @@ -0,0 +1,27 @@\n> +/*\n> + * Copyright (C) 2017 Broadcom\n> + *\n> + * This program is free software; you can redistribute it and/or\n> + * modify it under the terms of the GNU General Public License as\n> + * published by the Free Software Foundation version 2.\n> + *\n> + * This program is distributed \"as is\" WITHOUT ANY WARRANTY of any\n> + * kind, whether express or implied; without even the implied warranty\n> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> + * GNU General Public License for more details.\n> + */\n> +\n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> +#include \"clk-iproc.h\"\n> +\n> +static void __init hr2_armpll_init(struct device_node *node)\n> +{\n> + iproc_armpll_setup(node);\n> +}\n> +CLK_OF_DECLARE(hr2_armpll, \"brcm,hr2-armpll\", hr2_armpll_init);\n> --\n> 2.14.1\n\nPer our offline conversation, the LCPLL in HR2 looks to be completely\ndifferent than anything on NS/NSP/NS2 product line. So, that will\nneed a new driver. Given that this is sufficient to get the HR2 board\nworking, then it is acceptable to me.\n\nThanks,\nJon\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"H5TknMk6\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1kc72rkTz9t1G\n\tfor ;\n\tWed, 27 Sep 2017 00:58:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1031142AbdIZO6p (ORCPT\n\t);\n\tTue, 26 Sep 2017 10:58:45 -0400","from mail-it0-f54.google.com ([209.85.214.54]:52666 \"EHLO\n\tmail-it0-f54.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1031122AbdIZO6l (ORCPT\n\t); Tue, 26 Sep 2017 10:58:41 -0400","by mail-it0-f54.google.com with SMTP id c195so3204812itb.1\n\tfor ;\n\tTue, 26 Sep 2017 07:58:41 -0700 (PDT)","by 10.107.12.208 with HTTP; Tue, 26 Sep 2017 07:58:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=AwRXaR0QWOXQ6f55wHwfr6sV+tgsC5rqQGbsSkP3NlE=;\n\tb=H5TknMk6U+XJWR/cOOI+h6vNQ99ab4p3GDGo1QE93Hn0z5phzDN/CFRqqw4EjBf+5m\n\tBThhtiZgmKyc+UG0VhfWIaWNFz3wAi39fTYrAvFVzRXULUW/Uq6L9nDVh3feKqL4UcNc\n\tx1fuFhI+P6HxDAkdwnDCV+ihjK/T1QpYKknKI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=AwRXaR0QWOXQ6f55wHwfr6sV+tgsC5rqQGbsSkP3NlE=;\n\tb=ps5QywKbflDMUNy+i1byjNcVLaEWlCP0Wh9wtlRgM1P0mbAYNviHJsNAe0W+wfztVh\n\tpz9nycbOK11UdN6UyJaOjBGqZbbJQ9z+uPCpyxOYV2HrZmvioOqwY46OghUAzSiQ2UAA\n\tRP+26BLc7hVQMuVyuuP5uQnG5ITk7ZGmZb2mXXb72YJ1M5+DSRrm3ruCt0QHnRzd9X91\n\tFKGj12H7/kZU1pdB8lPAWlReysYA1djYWcALNuOhHhbtrKSe8bH1ByokES86k/r+tdLe\n\twBVkrhVAtGxlsq2pEd+cw94bKjHMhR9HvPPbLT3OJ2sjDjkLHRX31NNCushMmbtgrjz8\n\tj8nA==","X-Gm-Message-State":"AHPjjUjSynlPex8nNMk9+P8Xl8mKIShY5irfTrWCZm6KPpckPVgq1jk/\n\tFOlHfWOiJLyg/X2ylO3pQFSpDP8sA9hHhbWMX1LxEg==","X-Google-Smtp-Source":"AOwi7QC7gQUrYjNbUpAIF32/w2NmSFkcLxQH9+vVMlrc9pn33ecWQeHBNXR8FGfIZC3FJkQ/cc5JtMubQMadZ38nEQU=","X-Received":"by 10.36.161.15 with SMTP id y15mr6112555ite.34.1506437920965;\n\tTue, 26 Sep 2017 07:58:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170926000931.670-6-f.fainelli@gmail.com>","References":"<20170926000931.670-1-f.fainelli@gmail.com>\n\t<20170926000931.670-6-f.fainelli@gmail.com>","From":"Jon Mason ","Date":"Tue, 26 Sep 2017 10:58:40 -0400","Message-ID":"","Subject":"Re: [PATCH 05/10] clk: bcm: Add Broadcom Hurricane 2 clock support","To":"Florian Fainelli ","Cc":"linux-arm-kernel ,\n\tRob Herring , Mark Rutland ,\n\tRay Jui , Scott Branden ,\n\tJon Mason ,\n\t\"maintainer:BROADCOM IPROC ARM ARCHITECTURE\" \n\t,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tRussell King , \n\tArnd Bergmann , Olof Johansson ,\n\t\"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS\" \n\t, open list ,\n\t\"open list:COMMON CLK FRAMEWORK\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1775608,"web_url":"http://patchwork.ozlabs.org/comment/1775608/","msgid":"","list_archive_url":null,"date":"2017-09-26T15:00:59","subject":"Re: [PATCH 00/10] ARM: bcm: Add support for Broadcom Hurricane 2 SoC","submitter":{"id":69381,"url":"http://patchwork.ozlabs.org/api/people/69381/","name":"Jon Mason","email":"jon.mason@broadcom.com"},"content":"On Mon, Sep 25, 2017 at 8:09 PM, Florian Fainelli wrote:\n> Hi all,\n>\n> This patch series adds basic (boot to prompt with essential peripherals\n> working) support for Broadcom's Hurricane 2 SoC which is found in switching\n> applications.\n>\n> This is also an iProc-family chip with a number of variations, including\n> some in the clock controller that I have not been able to identify yet.\n>\n> Florian Fainelli (10):\n> MAINTAINERS: Update Broadcom iProc regexp with Hurricane 2\n> dt-bindings: Add documentation for Broadcom Hurricane 2 SoCs\n> ARM: bcm: Add support for Broadcom Hurricane 2 SoC\n> dt-bindings: Document Broadcom Hurricane 2 clocks\n> clk: bcm: Add Broadcom Hurricane 2 clock support\n> ARM: dts: Add Broadcom Hurricane 2 DTS include file\n> ARM: debug: Add Hurricane 2 UART2 debug addresses\n> dt-bindings: Add Ubiquiti Networks vendor prefix\n> ARM: dts: Hurricane 2: Add basic support for Ubiquiti UniFi Switch 8\n> ARM: multi_v7_defconfig: Enable CONFIG_ARCH_BCM_HR2\n>\n> .../devicetree/bindings/arm/bcm/brcm,hr2.txt | 14 +\n> .../bindings/clock/brcm,iproc-clocks.txt | 14 +\n> .../devicetree/bindings/vendor-prefixes.txt | 1 +\n> MAINTAINERS | 1 +\n> arch/arm/Kconfig.debug | 10 +-\n> arch/arm/boot/dts/Makefile | 2 +\n> arch/arm/boot/dts/bcm-hr2.dtsi | 368 +++++++++++++++++++++\n> arch/arm/boot/dts/bcm53340-ubnt-unifi-switch8.dts | 85 +++++\n> arch/arm/configs/multi_v7_defconfig | 1 +\n> arch/arm/mach-bcm/Kconfig | 9 +\n> arch/arm/mach-bcm/Makefile | 3 +\n> arch/arm/mach-bcm/bcm_hr2.c | 25 ++\n> drivers/clk/bcm/Kconfig | 9 +\n> drivers/clk/bcm/Makefile | 1 +\n> drivers/clk/bcm/clk-hr2.c | 27 ++\n> 15 files changed, 569 insertions(+), 1 deletion(-)\n> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,hr2.txt\n> create mode 100644 arch/arm/boot/dts/bcm-hr2.dtsi\n> create mode 100644 arch/arm/boot/dts/bcm53340-ubnt-unifi-switch8.dts\n> create mode 100644 arch/arm/mach-bcm/bcm_hr2.c\n> create mode 100644 drivers/clk/bcm/clk-hr2.c\n\nThe series looks good to me. Please feel free to add\nAcked-by: Jon Mason \n\nThanks,\nJon\n\n\n> --\n> 2.14.1\n>\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=broadcom.com header.i=@broadcom.com\n\theader.b=\"dfpxfurW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1kfl3qfpz9t1G\n\tfor ;\n\tWed, 27 Sep 2017 01:01:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S967054AbdIZPBB (ORCPT );\n\tTue, 26 Sep 2017 11:01:01 -0400","from mail-io0-f176.google.com ([209.85.223.176]:44921 \"EHLO\n\tmail-io0-f176.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S965319AbdIZPBA (ORCPT\n\t); Tue, 26 Sep 2017 11:01:00 -0400","by mail-io0-f176.google.com with SMTP id v36so13054712ioi.1\n\tfor ;\n\tTue, 26 Sep 2017 08:01:00 -0700 (PDT)","by 10.107.12.208 with HTTP; Tue, 26 Sep 2017 08:00:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n\ts=google; \n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ZH3xebG35oSylo4NaGQhjAjBklhkr/bp6D5V/j+D9O0=;\n\tb=dfpxfurWT2u12U/1gy3bID0Q3a0l0o0xqEQ7WeAphwiBplc+Zuc7G/BfJFyeTwj3rV\n\tV2RtPHbSKm3ob25n1TwU8OvO8NbQ3H5SK0NR7IESRGunLOWowC5K3eK7OPddREnv1dH9\n\tvVs3G7B+TIxr6Qp1ahlYGyZg9+2SiWeE4fyJc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZH3xebG35oSylo4NaGQhjAjBklhkr/bp6D5V/j+D9O0=;\n\tb=YvAXETIiQkLxloUrhR5iIGNdbg1yL0IkxTCuyEO98ozPoe5R0C8hIr3yHLWFVTsCPg\n\t7FAHhLIVwty4xUWPouNxYAPSvi+jHDvYCQG0CUIp+y1JeBYJ6fcbjQaOMiCO+QSR2z62\n\tr+XAqNWBzSuS9fz7LohHwMiKTikzJc1qUtNgfJTi0w/oZ7CxGptliSG04oWWrC3fBTyl\n\tqQfHn1GAGHNzypMJsccpKtZQbzzOqyLtQy+1AhT1gxmGU1igwTTInfW3QV6aPlDfOPgS\n\ttXy6bFNctgcbzfN03cgmYwVqRxVGPwE3elO3d/9LoW4YCSi72hj3dM5KR4mOmvulKlDx\n\tPnqQ==","X-Gm-Message-State":"AHPjjUiO1XClF4iq5iBevQvO4Buv0+XENnMcmPLmvOI1/ZKbBFCMDVnG\n\t76ZHJnBYKRiy+4DrNpYU83bgaJapiIwZZXcWIPdaqw==","X-Google-Smtp-Source":"AOwi7QC2XqBMNG8pc+P6WKPPOeAYyblLKXc1VkK4AD3s4MhTzHQscfV5M4JaKAiHoEuzqEJn4Tb7+au17fp+q3Io4T0=","X-Received":"by 10.107.173.34 with SMTP id w34mr15233994ioe.14.1506438059906; \n\tTue, 26 Sep 2017 08:00:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170926000931.670-1-f.fainelli@gmail.com>","References":"<20170926000931.670-1-f.fainelli@gmail.com>","From":"Jon Mason ","Date":"Tue, 26 Sep 2017 11:00:59 -0400","Message-ID":"","Subject":"Re: [PATCH 00/10] ARM: bcm: Add support for Broadcom Hurricane 2 SoC","To":"Florian Fainelli ","Cc":"linux-arm-kernel ,\n\tRob Herring , Mark Rutland ,\n\tRay Jui , Scott Branden ,\n\tJon Mason ,\n\t\"maintainer:BROADCOM IPROC ARM ARCHITECTURE\" \n\t,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tRussell King , \n\tArnd Bergmann , Olof Johansson ,\n\t\"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS\" \n\t, open list ,\n\t\"open list:COMMON CLK FRAMEWORK\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]