[{"id":1774780,"web_url":"http://patchwork.ozlabs.org/comment/1774780/","msgid":"<874lrqkebi.fsf@free-electrons.com>","list_archive_url":null,"date":"2017-09-25T15:06:41","subject":"Re: [PATCH 3/3] arm64: dts: marvell: add NAND support on the 7040-DB\n\tboard","submitter":{"id":15771,"url":"http://patchwork.ozlabs.org/api/people/15771/","name":"Gregory CLEMENT","email":"gregory.clement@free-electrons.com"},"content":"Hi Miquel,\n \n On lun., sept. 25 2017, Miquel Raynal <miquel.raynal@free-electrons.com> wrote:\n\n> From: Gregory CLEMENT <gregory.clement@free-electrons.com>\n>\n> The NAND controller used in A7K/A8K is present on the CP110 master part.\n> It is compatible with the pxa3xx_nand driver but requires the use of the\n> marvell,armada-8k-nand compatible string due to the need to first enable\n> the NAND controller.\n>\n> Add properties to the NAND node to fit the bindings constraints of the\n> pxa3xx_nand driver and enable the NAND controller.\n>\n> Add the 'marvell,system-controller' property to the cp110 master NAND\n> node with a reference to the syscon node. This is new compared to other\n> boards using the pxa3xx_nand driver and it is needed to be bootloader\n> independent and enable the NAND controller from the NAND controller\n> driver itself by writing in these syscon registers.\n>\n> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>\n> [miquel.raynal@free-electrons.com: add NAND ready/busy MPP subnode,\n> change compatible string to fit the needs of the A7k/A8k SoCs and add\n> the system controller property]\n> Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>\n> ---\n>  arch/arm64/boot/dts/marvell/armada-7040-db.dts     | 24 ++++++++++++++++++++++\n>  arch/arm64/boot/dts/marvell/armada-70x0.dtsi       | 14 +++++++++++++\n>  .../boot/dts/marvell/armada-cp110-master.dtsi      |  3 ++-\n>  3 files changed, 40 insertions(+), 1 deletion(-)\n>\n> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts\n> index 9c3bdf87e543..b98cf265bae5 100644\n> --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts\n> +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts\n> @@ -144,6 +144,30 @@\n>  \t};\n>  };\n>  \n> +&cpm_nand {\n> +\tstatus = \"okay\";\n> +\tnum-cs = <1>;\n> +\tpinctrl-0 = <&nand_pins>, <&nand_rb>;\n> +\tpinctrl-names = \"default\";\n> +\tnand-ecc-strength = <4>;\n> +\tnand-ecc-step-size = <512>;\n> +\tmarvell,nand-enable-arbiter;\n> +\tnand-on-flash-bbt;\n> +\n> +\tpartition@0 {\n> +\t\tlabel = \"U-Boot\";\n> +\t\treg = <0 0x200000>;\n> +\t};\n> +\tpartition@200000 {\n> +\t\tlabel = \"Linux\";\n> +\t\treg = <0x200000 0xe00000>;\n> +\t};\n> +\tpartition@1000000 {\n> +\t\tlabel = \"Filesystem\";\n> +\t\treg = <0x1000000 0x3f000000>;\n> +\t};\n> +};\n> +\n>  &cpm_spi1 {\n>  \tstatus = \"okay\";\n>  \n> diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi\n> index 860b6ae9dcc5..0e1a1e5be399 100644\n> --- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi\n> +++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi\n> @@ -64,5 +64,19 @@\n>  &cpm_syscon0 {\n>  \tcpm_pinctrl: pinctrl {\n>  \t\tcompatible = \"marvell,armada-7k-pinctrl\";\n> +\n> +\t\tnand_pins: nand-pins {\n> +\t\t\tmarvell,pins =\n> +\t\t\t\"mpp15\", \"mpp16\", \"mpp17\", \"mpp18\",\n> +\t\t\t\"mpp19\", \"mpp20\", \"mpp21\", \"mpp22\",\n> +\t\t\t\"mpp23\", \"mpp24\", \"mpp25\", \"mpp26\",\n> +\t\t\t\"mpp27\";\n> +\t\t\tmarvell,function = \"dev\";\n> +\t\t};\n> +\n> +\t\tnand_rb: nand-rb {\n> +\t\t\tmarvell,pins = \"mpp13\";\n> +\t\t\tmarvell,function = \"nf\";\n> +\t\t};\n>  \t};\n>  };\n> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi\n> index 8263a8a504a8..d41b41b613ec 100644\n> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi\n> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi\n> @@ -274,12 +274,13 @@\n>  \t\t\t\t * this controller is only usable on the CPM\n>  \t\t\t\t * for A7K and on the CPS for A8K.\n>  \t\t\t\t */\n> -\t\t\t\tcompatible = \"marvell,armada370-nand\";\n> +\t\t\t\tcompatible = \"marvell,armada-8k-nand\";\n\nthe controller on cp110 remains compatible with the one on Armada 370\n(even if it needs more initialization steps), so we should keep it also\nand having instead the following line:\n\ncompatible = \"marvell,armada-8k-nand\", \"marvell,armada370-nand\";\n\nYou don't have to send a new version, unless someone is against it, I\nwill amend it when applying on the mvebu branches.\n\nThanks,\n\nGregory\n\n\n>  \t\t\t\treg = <0x720000 0x54>;\n>  \t\t\t\t#address-cells = <1>;\n>  \t\t\t\t#size-cells = <1>;\n>  \t\t\t\tinterrupts = <ICU_GRP_NSR 115 IRQ_TYPE_LEVEL_HIGH>;\n>  \t\t\t\tclocks = <&cpm_clk 1 2>;\n> +\t\t\t\tmarvell,system-controller = <&cpm_syscon0>;\n>  \t\t\t\tstatus = \"disabled\";\n>  \t\t\t};\n>  \n> -- \n> 2.11.0\n>\n>\n> _______________________________________________\n> linux-arm-kernel mailing list\n> linux-arm-kernel@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"dIKOEVJo\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y16rc14Jkz9t67\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 01:07:28 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwUyf-0004Hv-3O; Mon, 25 Sep 2017 15:07:21 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwUya-0004EC-6H; Mon, 25 Sep 2017 15:07:18 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 8409F20957; Mon, 25 Sep 2017 17:06:50 +0200 (CEST)","from localhost (242.171.71.37.rev.sfr.net [37.71.171.242])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 541B920915;\n\tMon, 25 Sep 2017 17:06:40 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:\n\tDate:References:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=POSYkT1EZ/FY6gk5q9W1K//6DsNNHnsnVo7J4TnIrAQ=;\n\tb=dIKOEVJok+PXa6\n\tMCDIKgNL6Ryyu4Iwb9sqgYfYsy+B2CAbdX3wYnphX8RxF8U1P5/s53G1KvTQBhUc79391kN0sOouc\n\t7HYXKAd0qPtOOSq1biqdRMcjmJ8Jkpn5hs+aMd2mos5Q7C7JK3138ZnTbh5nCE43eneq8uBB9d/Mj\n\tkkp2F5jdX0RSJJwRwUcltFYZVWQG08EXFFTZ8uv53hLzSAZv+azUh/C6MY6XR9Lm27mSQnU+BdenM\n\tAhATKjYtCANxfjJ906QBGqaLs/dt9xQkCX4DquEx8JR1LNk4fprbkCOX4CK7niJN1xC+p86oIKXR9\n\tJiCw8iDb/oDhTbMbonSA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Gregory CLEMENT <gregory.clement@free-electrons.com>","To":"Miquel Raynal <miquel.raynal@free-electrons.com>","Subject":"Re: [PATCH 3/3] arm64: dts: marvell: add NAND support on the 7040-DB\n\tboard","References":"<20170925145352.13145-1-miquel.raynal@free-electrons.com>\n\t<20170925145352.13145-4-miquel.raynal@free-electrons.com>","Date":"Mon, 25 Sep 2017 17:06:41 +0200","In-Reply-To":"<20170925145352.13145-4-miquel.raynal@free-electrons.com>\n\t(Miquel Raynal's message of \"Mon, 25 Sep 2017 16:53:52 +0200\")","Message-ID":"<874lrqkebi.fsf@free-electrons.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170925_080716_553350_D55D7C23 ","X-CRM114-Status":"GOOD (  22.09  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tJason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,\n\tRichard Weinberger <richard@nod.at>,\n\tAntoine Tenart <antoine.tenart@free-electrons.com>,\n\tNadav Haklai <nadavh@marvell.com>, Marek Vasut <marek.vasut@gmail.com>,\n\tdevicetree@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tEzequiel Garcia <ezequiel.garcia@free-electrons.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tlinux-arm-kernel@lists.infradead.org, \n\tSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1780589,"web_url":"http://patchwork.ozlabs.org/comment/1780589/","msgid":"<20171005145343.1ba59fb7@bbrezillon>","list_archive_url":null,"date":"2017-10-05T12:53:43","subject":"Re: [PATCH 0/3] Enable NAND on Armada-7040-DB board","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"On Mon, 25 Sep 2017 16:53:49 +0200\nMiquel Raynal <miquel.raynal@free-electrons.com> wrote:\n\n> Hi,\n> \n> This series adds support for NAND on Armada-7040-DB board.\n> \n> Besides standard NAND node addition, it also introduces a new compatible\n> string for the pxa3xx_nand driver to support the subitilities of A7k/A8k\n> SoCs, as well as a new property used by the pxa3xx_nand driver to grab a\n> phandle on the system control node in order to enable the NAND\n> controller itself.\n> \n> Regards,\n> Miquel\n> \n> \n> Gregory CLEMENT (1):\n>   arm64: dts: marvell: add NAND support on the 7040-DB board\n> \n> Miquel Raynal (2):\n>   Documentation: devicetree: add pxa3xx compatible and syscon property\n>   mtd: nand: pxa3xx: enable NAND controller if the SoC needs it\n\nApplied patch 1 and 2.\n\nThanks,\n\nBoris\n\n> \n>  .../devicetree/bindings/mtd/pxa3xx-nand.txt        |  4 +++\n>  arch/arm64/boot/dts/marvell/armada-7040-db.dts     | 24 +++++++++++++\n>  arch/arm64/boot/dts/marvell/armada-70x0.dtsi       | 14 ++++++++\n>  .../boot/dts/marvell/armada-cp110-master.dtsi      |  3 +-\n>  drivers/mtd/nand/pxa3xx_nand.c                     | 41 +++++++++++++++++++---\n>  5 files changed, 81 insertions(+), 5 deletions(-)\n>","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"dHV7BtiI\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7CQJ0fl5z9s7M\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu,  5 Oct 2017 23:54:16 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e05fG-00082R-E1; Thu, 05 Oct 2017 12:54:10 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e05fB-00080d-Sl; Thu, 05 Oct 2017 12:54:07 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid D2C39208E2; Thu,  5 Oct 2017 14:53:43 +0200 (CEST)","from bbrezillon (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 70F7320848;\n\tThu,  5 Oct 2017 14:53:43 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=P+UDP/DGxSalrCzk57oBr5BRfiLXMs6/GabCGeoqtYs=;\n\tb=dHV7BtiIvRM+v/\n\td6cMsCJ1IDYOGJS1yoSDmYL3EaFe1/myZmkDb6vx2IKheEU9Dv+bP2e/PehaBsSUHakTZXH4JV4xh\n\tk415vrj+o7P4SyIIpVXKOGYwSYKgsVvQNprIWV1eqdsgTujW3MfNxOemml4mcFPmvAHoW/MwoNuxS\n\tn7DVeupzogeqNjpLBh6XUltIB/123zqHl81lT1U/MnZajLnSTjHza4K9rxtmJPKx1Qo8eyPQTc8zz\n\tDLHWkSilYS1eZYpEIPjigULFwEfjD8Ta5TeQwg6mfo+bKYhm1OxYjJHfRnnaIzMFhW6wa1wBmosyB\n\tFGnqwJes0bXAdvuxGzIQ==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Thu, 5 Oct 2017 14:53:43 +0200","From":"Boris Brezillon <boris.brezillon@free-electrons.com>","To":"Miquel Raynal <miquel.raynal@free-electrons.com>","Subject":"Re: [PATCH 0/3] Enable NAND on Armada-7040-DB board","Message-ID":"<20171005145343.1ba59fb7@bbrezillon>","In-Reply-To":"<20170925145352.13145-1-miquel.raynal@free-electrons.com>","References":"<20170925145352.13145-1-miquel.raynal@free-electrons.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171005_055406_080275_20CE868F ","X-CRM114-Status":"GOOD (  14.86  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tAndrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,\n\tdevicetree@vger.kernel.org, Richard Weinberger <richard@nod.at>,\n\tAntoine Tenart <antoine.tenart@free-electrons.com>,\n\tNadav Haklai <nadavh@marvell.com>, Marek Vasut <marek.vasut@gmail.com>,\n\tlinux-mtd@lists.infradead.org,\n\tEzequiel Garcia <ezequiel.garcia@free-electrons.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tGregory Clement <gregory.clement@free-electrons.com>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tlinux-arm-kernel@lists.infradead.org, \n\tSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1785517,"web_url":"http://patchwork.ozlabs.org/comment/1785517/","msgid":"<87sheoa16s.fsf@free-electrons.com>","list_archive_url":null,"date":"2017-10-12T14:30:19","subject":"Re: [PATCH 3/3] arm64: dts: marvell: add NAND support on the 7040-DB\n\tboard","submitter":{"id":15771,"url":"http://patchwork.ozlabs.org/api/people/15771/","name":"Gregory CLEMENT","email":"gregory.clement@free-electrons.com"},"content":"Hi Miquel,\n \n On lun., sept. 25 2017, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:\n\n> Hi Miquel,\n>  \n>  On lun., sept. 25 2017, Miquel Raynal <miquel.raynal@free-electrons.com> wrote:\n>\n>> From: Gregory CLEMENT <gregory.clement@free-electrons.com>\n>>\n>> The NAND controller used in A7K/A8K is present on the CP110 master part.\n>> It is compatible with the pxa3xx_nand driver but requires the use of the\n>> marvell,armada-8k-nand compatible string due to the need to first enable\n>> the NAND controller.\n>>\n>> Add properties to the NAND node to fit the bindings constraints of the\n>> pxa3xx_nand driver and enable the NAND controller.\n>>\n>> Add the 'marvell,system-controller' property to the cp110 master NAND\n>> node with a reference to the syscon node. This is new compared to other\n>> boards using the pxa3xx_nand driver and it is needed to be bootloader\n>> independent and enable the NAND controller from the NAND controller\n>> driver itself by writing in these syscon registers.\n>>\n>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>\n>> [miquel.raynal@free-electrons.com: add NAND ready/busy MPP subnode,\n>> change compatible string to fit the needs of the A7k/A8k SoCs and add\n>> the system controller property]\n>> Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>\n>> ---\n>>  arch/arm64/boot/dts/marvell/armada-7040-db.dts     | 24 ++++++++++++++++++++++\n>>  arch/arm64/boot/dts/marvell/armada-70x0.dtsi       | 14 +++++++++++++\n>>  .../boot/dts/marvell/armada-cp110-master.dtsi      |  3 ++-\n>>  3 files changed, 40 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/boot/dts/marvell/armada-7040-db.dts\n>> index 9c3bdf87e543..b98cf265bae5 100644\n>> --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts\n>> +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts\n>> @@ -144,6 +144,30 @@\n>>  \t};\n>>  };\n>>  \n>> +&cpm_nand {\n>> +\tstatus = \"okay\";\n>> +\tnum-cs = <1>;\n>> +\tpinctrl-0 = <&nand_pins>, <&nand_rb>;\n>> +\tpinctrl-names = \"default\";\n>> +\tnand-ecc-strength = <4>;\n>> +\tnand-ecc-step-size = <512>;\n>> +\tmarvell,nand-enable-arbiter;\n>> +\tnand-on-flash-bbt;\n>> +\n>> +\tpartition@0 {\n>> +\t\tlabel = \"U-Boot\";\n>> +\t\treg = <0 0x200000>;\n>> +\t};\n>> +\tpartition@200000 {\n>> +\t\tlabel = \"Linux\";\n>> +\t\treg = <0x200000 0xe00000>;\n>> +\t};\n>> +\tpartition@1000000 {\n>> +\t\tlabel = \"Filesystem\";\n>> +\t\treg = <0x1000000 0x3f000000>;\n>> +\t};\n>> +};\n>> +\n>>  &cpm_spi1 {\n>>  \tstatus = \"okay\";\n>>  \n>> diff --git a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi\n>> index 860b6ae9dcc5..0e1a1e5be399 100644\n>> --- a/arch/arm64/boot/dts/marvell/armada-70x0.dtsi\n>> +++ b/arch/arm64/boot/dts/marvell/armada-70x0.dtsi\n>> @@ -64,5 +64,19 @@\n>>  &cpm_syscon0 {\n>>  \tcpm_pinctrl: pinctrl {\n>>  \t\tcompatible = \"marvell,armada-7k-pinctrl\";\n>> +\n>> +\t\tnand_pins: nand-pins {\n>> +\t\t\tmarvell,pins =\n>> +\t\t\t\"mpp15\", \"mpp16\", \"mpp17\", \"mpp18\",\n>> +\t\t\t\"mpp19\", \"mpp20\", \"mpp21\", \"mpp22\",\n>> +\t\t\t\"mpp23\", \"mpp24\", \"mpp25\", \"mpp26\",\n>> +\t\t\t\"mpp27\";\n>> +\t\t\tmarvell,function = \"dev\";\n>> +\t\t};\n>> +\n>> +\t\tnand_rb: nand-rb {\n>> +\t\t\tmarvell,pins = \"mpp13\";\n>> +\t\t\tmarvell,function = \"nf\";\n>> +\t\t};\n>>  \t};\n>>  };\n>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi\n>> index 8263a8a504a8..d41b41b613ec 100644\n>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi\n>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi\n>> @@ -274,12 +274,13 @@\n>>  \t\t\t\t * this controller is only usable on the CPM\n>>  \t\t\t\t * for A7K and on the CPS for A8K.\n>>  \t\t\t\t */\n>> -\t\t\t\tcompatible = \"marvell,armada370-nand\";\n>> +\t\t\t\tcompatible = \"marvell,armada-8k-nand\";\n>\n> the controller on cp110 remains compatible with the one on Armada 370\n> (even if it needs more initialization steps), so we should keep it also\n> and having instead the following line:\n>\n> compatible = \"marvell,armada-8k-nand\", \"marvell,armada370-nand\";\n>\n> You don't have to send a new version, unless someone is against it, I\n> will amend it when applying on the mvebu branches.\n\n\nNow applied on mvebu/dt64 with the changes I mentioned,\n\nThanks,\n\nGregory\n\n\n>\n> Thanks,\n>\n> Gregory\n>\n>\n>>  \t\t\t\treg = <0x720000 0x54>;\n>>  \t\t\t\t#address-cells = <1>;\n>>  \t\t\t\t#size-cells = <1>;\n>>  \t\t\t\tinterrupts = <ICU_GRP_NSR 115 IRQ_TYPE_LEVEL_HIGH>;\n>>  \t\t\t\tclocks = <&cpm_clk 1 2>;\n>> +\t\t\t\tmarvell,system-controller = <&cpm_syscon0>;\n>>  \t\t\t\tstatus = \"disabled\";\n>>  \t\t\t};\n>>  \n>> -- \n>> 2.11.0\n>>\n>>\n>> _______________________________________________\n>> linux-arm-kernel mailing list\n>> linux-arm-kernel@lists.infradead.org\n>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel\n>\n> -- \n> Gregory Clement, Free Electrons\n> Kernel, drivers, real-time and embedded Linux\n> development, consulting, training and support.\n> http://free-electrons.com\n>\n> _______________________________________________\n> linux-arm-kernel mailing list\n> linux-arm-kernel@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"gJWwTUf4\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCYDf70tcz9sRq\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tFri, 13 Oct 2017 01:30:58 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2eVj-0004sU-1C; Thu, 12 Oct 2017 14:30:55 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2eVe-0004ld-Nc; Thu, 12 Oct 2017 14:30:53 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid EBF1520438; Thu, 12 Oct 2017 16:30:28 +0200 (CEST)","from localhost (unknown [37.71.171.242])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id AE5A4203B4;\n\tThu, 12 Oct 2017 16:30:18 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:\n\tDate:References:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=GijvGdcMPXIomU/wkJsv9CLWuW9Be9FQQz4wPVtvO4U=;\n\tb=gJWwTUf4imDV7N\n\t2Lzh5oOOv414R/a8YpDUtyJL1oAmV+JGBvcuPXJ74cwSAI6H0C64Qq2YGAgQjJ+cTL+cH2WhTKJKo\n\thl6LOJGZZV9hwRO07G7FYMAKnbEaDyq1FVE3qvd336g3gpXs6i4jP4/lO4UkRTg0afxPBDQ31SJFo\n\tWmsKjtkX+AZo/TeBcJCWthZ7Actv7nEEXVw340W5jPUPTLAhJ1Ug1R42lrraD4akcVBMLq0wZb4s8\n\tcUGHTyXap1AKYQVXWUSHy43ALo7KFSjmRfiaFBwhICbquV89zJAdye+2y1YURpv1A7EgEfB/O0GBf\n\tw2EI3cOcy1kA6XbzoJbw==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","From":"Gregory CLEMENT <gregory.clement@free-electrons.com>","To":"Miquel Raynal <miquel.raynal@free-electrons.com>","Subject":"Re: [PATCH 3/3] arm64: dts: marvell: add NAND support on the 7040-DB\n\tboard","References":"<20170925145352.13145-1-miquel.raynal@free-electrons.com>\n\t<20170925145352.13145-4-miquel.raynal@free-electrons.com>\n\t<874lrqkebi.fsf@free-electrons.com>","Date":"Thu, 12 Oct 2017 16:30:19 +0200","In-Reply-To":"<874lrqkebi.fsf@free-electrons.com> (Gregory CLEMENT's message\n\tof \"Mon, 25 Sep 2017 17:06:41 +0200\")","Message-ID":"<87sheoa16s.fsf@free-electrons.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171012_073051_065615_E4611706 ","X-CRM114-Status":"GOOD (  21.55  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tJason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,\n\tRichard Weinberger <richard@nod.at>,\n\tAntoine Tenart <antoine.tenart@free-electrons.com>,\n\tNadav Haklai <nadavh@marvell.com>, Marek Vasut <marek.vasut@gmail.com>,\n\tdevicetree@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tEzequiel Garcia <ezequiel.garcia@free-electrons.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tlinux-arm-kernel@lists.infradead.org, \n\tSebastian Hesselbarth <sebastian.hesselbarth@gmail.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]