[{"id":1776441,"web_url":"http://patchwork.ozlabs.org/comment/1776441/","msgid":"<20170927154803.imsz77pitsste6b5@pd.tnic>","list_archive_url":null,"date":"2017-09-27T15:48:03","subject":"Re: [PATCH v10 1/7] edac: thunderx: Remove suspend/resume support","submitter":{"id":4449,"url":"http://patchwork.ozlabs.org/api/people/4449/","name":"Borislav Petkov","email":"bp@alien8.de"},"content":"On Mon, Sep 25, 2017 at 02:34:56PM +0200, Jan Glauber wrote:\n> The memory controller on ThunderX/OcteonTX systems does not\n> support power management. Therefore remove the suspend/resume\n> callbacks.\n> \n> Signed-off-by: Jan Glauber <jglauber@cavium.com>\n> ---\n>  drivers/edac/thunderx_edac.c | 25 -------------------------\n>  1 file changed, 25 deletions(-)\n\nApplied, thanks.","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"Gf2ogA5v\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2MgL6J7sz9tXb\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 01:48:46 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxEZn-00019S-DV; Wed, 27 Sep 2017 15:48:43 +0000","from mail.skyhub.de ([5.9.137.197])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxEZi-0000hc-GV for linux-arm-kernel@lists.infradead.org;\n\tWed, 27 Sep 2017 15:48:40 +0000","from mail.skyhub.de ([127.0.0.1])\n\tby localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026)\n\twith ESMTP id dPUuH6nnY7Or; Wed, 27 Sep 2017 17:48:13 +0200 (CEST)","from pd.tnic (p2003008C2F23BA0061419DEC4CB49784.dip0.t-ipconnect.de\n\t[IPv6:2003:8c:2f23:ba00:6141:9dec:4cb4:9784])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id\n\t4A0B11EC04A6; Wed, 27 Sep 2017 17:48:13 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=5xEE/NDB0W5Ho+htFZoWRpDjGyh/qsH7cLVbHHoq6Lc=;\n\tb=Gf2ogA5vP+lqi0\n\tKFz5LXLE7Crknl1wjQlsPJZW+OsZ9vmyBvQNRkIlP/pCZ4vg2QkeXy7P1jFJl1u2BJisq21yGoo8p\n\tH0EznNf9Pxc4ovfnsGExzr6yK3YNKhFrGCz0QsmWErdB3rymGt/JOPmt5mxYMPnWmaacjSTTfwG3R\n\tQ1ujER5Yn8+WoTZrAiCconNbGpFQhEpvHFgLsDZ0FOzh2xzbNVA916mmQAnivsoajpvFbZovXLXBp\n\tt2/AtlOHqnzdvF/cmPqMOL3Dnoc1yz5ce9UypxGLvTu+iMA4kIC6B+/UzmtGPjSgfWolFN4qOOdnV\n\tt8G+c0C0HQBTQMCXNfDw==;","X-Virus-Scanned":"Nedap ESD1 at mail.skyhub.de","Date":"Wed, 27 Sep 2017 17:48:03 +0200","From":"Borislav Petkov <bp@alien8.de>","To":"Jan Glauber <jglauber@cavium.com>","Subject":"Re: [PATCH v10 1/7] edac: thunderx: Remove suspend/resume support","Message-ID":"<20170927154803.imsz77pitsste6b5@pd.tnic>","References":"<20170925123502.17289-1-jglauber@cavium.com>\n\t<20170925123502.17289-2-jglauber@cavium.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170925123502.17289-2-jglauber@cavium.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170927_084838_729653_3D0350D7 ","X-CRM114-Status":"UNSURE (   8.19  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>, David Daney <david.daney@cavium.com>,\n\tSuzuki K Poulose <Suzuki.Poulose@arm.com>,\n\tWill Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org,\n\tZhangshaokun <zhangshaokun@hisilicon.com>, \n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1776460,"web_url":"http://patchwork.ozlabs.org/comment/1776460/","msgid":"<20170927161901.4hto7mrc2s4yuugn@pd.tnic>","list_archive_url":null,"date":"2017-09-27T16:19:01","subject":"Re: [PATCH v10 3/7] edac,\n\tsoc: thunderx: Add wrapper for EDAC LMC PCI device","submitter":{"id":4449,"url":"http://patchwork.ozlabs.org/api/people/4449/","name":"Borislav Petkov","email":"bp@alien8.de"},"content":"On Mon, Sep 25, 2017 at 02:34:58PM +0200, Jan Glauber wrote:\n> Cavium SOCs contain a memory controller that is presented as a\n> PCI device. This PCI device will be used by an EDAC driver and\n> by a PMU driver.\n> \n> To allow both subsystems to access the device a small wrapper is\n> introduced that multi-plexes PCI probe and removal calls of the\n> device to the EDAC driver.\n> \n> The same mechanism will be used later to call the PMU driver.\n> \n> The ThunderX EDAC driver is limited to only build as module\n> with this patch. The reason is that with multiple users of the\n> multi-plexer all users must be either builtin or modules.\n> \n> Signed-off-by: Jan Glauber <jglauber@cavium.com>\n> ---\n\n...\n\n> diff --git a/drivers/soc/cavium/cavium_lmc.c b/drivers/soc/cavium/cavium_lmc.c\n> new file mode 100644\n> index 000000000000..87248e83c55b\n> --- /dev/null\n> +++ b/drivers/soc/cavium/cavium_lmc.c\n> @@ -0,0 +1,49 @@\n> +/*\n> + * These PCI devices contain RAS functionality and PMU counters. To allow\n> + * independent RAS and PMU drivers this driver registers for the PCI devices\n> + * and multi-plexes probe and removal.\n> + *\n> + * This file is subject to the terms and conditions of the GNU General Public\n> + * License.  See the file \"COPYING\" in the main directory of this archive\n> + * for more details.\n> + *\n> + * Copyright: Cavium, Inc. (C) 2017\n> + *\n> + */\n> +#include <linux/module.h>\n> +#include <linux/pci.h>\n> +#include <linux/soc/cavium/lmc.h>\n> +\n> +static int cvm_lmc_probe(struct pci_dev *pdev,\n> +\t\t\t const struct pci_device_id *ent)\n> +{\n> +\tif (IS_ENABLED(CONFIG_EDAC_THUNDERX))\n> +\t\tthunderx_edac_lmc_probe(pdev, ent);\n\nYou could save yourself the if (IS_ENABLED()) here by adding stubs in\nthe lmc.h header for those functions for the !CONFIG_EDAC_THUNDERX case.\n\nOne thing I'm not clear on though, is the design of the whole thing:\ncvm_lmc_probe() probes the EDAC driver during its own probe, which\nmeans, thunderx_edac needs to be loaded first. And the other things that\nget loaded, do the same.\n\nWhat I was expecting is those small cavium_lmc.c and cavium_ocx.c\nwrappers to probe and register the respective PCI device and then its\n*users* - EDAC and PMU drivers to go and request the PCI device from\nthem:\n\ncavium_lmc_get_pci_dev()\ncavium_ocx_get_pci_dev()\n\nand so on. Those will be exported to modules. And the small stubs can\nalso be built-in too.\n\nThis way you can do reference counting and whatever else.\n\nIf the above calls fail, neither EDAC nor PMU will load properly but you\nsolve the multiplexing issue by having those wrappers arbitrate access\nto the PCI devices.\n\nBecause right now the wrappers are simply weakly hiding the calls into\nEDAC and that's exactly what I was opposing to.\n\nHmmm?\n\n> +\treturn 0;\n> +}\n> +\n> +static void cvm_lmc_remove(struct pci_dev *pdev)\n> +{\n> +\tif (IS_ENABLED(CONFIG_EDAC_THUNDERX))\n> +\t\tthunderx_edac_lmc_remove(pdev);\n> +}\n> +\n> +static const struct pci_device_id cvm_lmc_pci_table[] = {\n> +\t{ PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, 0xa022) },\n\n        { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVICE_ID_THUNDER_LMC) },\n\nYou already have that PCI device id define.","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"mlt0B0vC\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2NM22Vvdz9t5l\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 02:19:42 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxF3i-0001i1-LJ; Wed, 27 Sep 2017 16:19:38 +0000","from mail.skyhub.de ([5.9.137.197])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxF3e-0000Un-T7 for linux-arm-kernel@lists.infradead.org;\n\tWed, 27 Sep 2017 16:19:36 +0000","from mail.skyhub.de ([127.0.0.1])\n\tby localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026)\n\twith ESMTP id qmdle_P8lEWs; Wed, 27 Sep 2017 18:19:11 +0200 (CEST)","from pd.tnic (p2003008C2F23BA0061419DEC4CB49784.dip0.t-ipconnect.de\n\t[IPv6:2003:8c:2f23:ba00:6141:9dec:4cb4:9784])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id\n\t8963A1EC04B9; Wed, 27 Sep 2017 18:19:11 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=A2U94vmLkL5eWtuOs/UWbw5ndpkFcY6wCY9pw+AJGdY=;\n\tb=mlt0B0vCakIaKu\n\tsnHf2gNSO6w6YXH8V7/v8U3TMiZpEjURbzKzYm2QuNHFlqBv0xefFbtMDAnuk5BaUcbsdlx+Hm2Xb\n\tJ9wrAIqpqY1TmmaafnM7B/MZA0X+7Yx0QyIZHlaVuo7rBobOHOGxqB2VAqakarKYEq2ebWNzSha1E\n\tMQgscux5BItkpuLY2np/VtWbXugZuOUDefIw+1G0cjoslTi8Yh5Mv5ZNH/1OBxZPoVYdgPUUenZ0W\n\tGdXFUKrmVt/C8RNtCRU5EikvhS8146hwXwahJZkYfWg3LkI7RLigyOLhaJXimYchNGAxIoFvJC0uV\n\tn3nk4XJnP6CSwwawuqjw==;","X-Virus-Scanned":"Nedap ESD1 at mail.skyhub.de","Date":"Wed, 27 Sep 2017 18:19:01 +0200","From":"Borislav Petkov <bp@alien8.de>","To":"Jan Glauber <jglauber@cavium.com>","Subject":"Re: [PATCH v10 3/7] edac,\n\tsoc: thunderx: Add wrapper for EDAC LMC PCI device","Message-ID":"<20170927161901.4hto7mrc2s4yuugn@pd.tnic>","References":"<20170925123502.17289-1-jglauber@cavium.com>\n\t<20170925123502.17289-4-jglauber@cavium.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170925123502.17289-4-jglauber@cavium.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170927_091935_145307_F8204396 ","X-CRM114-Status":"GOOD (  22.19  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>, David Daney <david.daney@cavium.com>,\n\tSuzuki K Poulose <Suzuki.Poulose@arm.com>,\n\tWill Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org,\n\tZhangshaokun <zhangshaokun@hisilicon.com>, \n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1776465,"web_url":"http://patchwork.ozlabs.org/comment/1776465/","msgid":"<20170927164846.00001cbe@huawei.com>","list_archive_url":null,"date":"2017-09-27T15:48:46","subject":"Re: [PATCH v10 6/7] perf: cavium: Support transmit-link PMU counters","submitter":{"id":71988,"url":"http://patchwork.ozlabs.org/api/people/71988/","name":"Jonathan Cameron","email":"Jonathan.Cameron@huawei.com"},"content":"On Mon, 25 Sep 2017 14:35:01 +0200\nJan Glauber <jglauber@cavium.com> wrote:\n\n> Add support for the transmit-link (OCX TLK) PMU counters found\n> on Caviums SOCs with a processor interconnect.\n> \n> Properties of the OCX TLK counters:\n> - per-unit control\n> - fixed purpose\n> - writable\n> - one PCI device with multiple TLK units\n> \n> Signed-off-by: Jan Glauber <jglauber@cavium.com>\n\nSomething odd happened in\ndrivers/soc/cavium/Kconfig...\n\nOtherwise whole series looks sensible to me.\n\nJonathan\n\n> ---\n>  drivers/perf/Kconfig            |   7 ++\n>  drivers/perf/cavium_pmu.c       | 230 ++++++++++++++++++++++++++++++++++++++++\n>  drivers/soc/cavium/Kconfig      |   4 +\n>  drivers/soc/cavium/cavium_ocx.c |   4 +\n>  include/linux/soc/cavium/ocx.h  |   3 +\n>  5 files changed, 248 insertions(+)\n> \n\n<snip>\n\n>  static int __init cvm_pmu_init(void)\n>  {\n>  \tINIT_LIST_HEAD(&cvm_pmu_lmcs);\n> diff --git a/drivers/soc/cavium/Kconfig b/drivers/soc/cavium/Kconfig\n> index fe56503d20f4..2c7406872b18 100644\n> --- a/drivers/soc/cavium/Kconfig\n> +++ b/drivers/soc/cavium/Kconfig\n> @@ -8,3 +8,7 @@ config CAVIUM_LMC\n>  config CAVIUM_OCX\n>  \tdepends on ARCH_THUNDER\n>  \tdef_tristate m\n> +\n> +config CAVIUM_OCX\n> +        depends on ARCH_THUNDER\n> +\tdef_tristate m\n\nSomething odd going on here...\n\n> diff --git a/drivers/soc/cavium/cavium_ocx.c b/drivers/soc/cavium/cavium_ocx.c\n> index fa3341b0744f..de1ad146c0dd 100644\n> --- a/drivers/soc/cavium/cavium_ocx.c\n> +++ b/drivers/soc/cavium/cavium_ocx.c\n> @@ -13,6 +13,8 @@\n>  static int cvm_ocx_probe(struct pci_dev *pdev,\n>  \t\t\t const struct pci_device_id *ent)\n>  {\n> +\tif (IS_ENABLED(CONFIG_CAVIUM_PMU_OCX_TLK))\n> +\t\tcvm_ocx_tlk_pmu_probe(pdev, ent);\n>  \tif (IS_ENABLED(CONFIG_EDAC_THUNDERX))\n>  \t\tthunderx_edac_ocx_probe(pdev, ent);\n>  \treturn 0;\n> @@ -20,6 +22,8 @@ static int cvm_ocx_probe(struct pci_dev *pdev,\n>  \n>  static void cvm_ocx_remove(struct pci_dev *pdev)\n>  {\n> +\tif (IS_ENABLED(CONFIG_CAVIUM_PMU_OCX_TLK))\n> +\t\tcvm_ocx_tlk_pmu_remove(pdev);\n>  \tif (IS_ENABLED(CONFIG_EDAC_THUNDERX))\n>  \t\tthunderx_edac_ocx_remove(pdev);\n>  }\n> diff --git a/include/linux/soc/cavium/ocx.h b/include/linux/soc/cavium/ocx.h\n> index 29f55b3d3171..f7b2caada671 100644\n> --- a/include/linux/soc/cavium/ocx.h\n> +++ b/include/linux/soc/cavium/ocx.h\n> @@ -3,6 +3,9 @@\n>  \n>  #include <linux/pci.h>\n>  \n> +int cvm_ocx_tlk_pmu_probe(struct pci_dev *pdev, const struct pci_device_id *ent);\n> +void cvm_ocx_tlk_pmu_remove(struct pci_dev *pdev);\n> +\n>  int thunderx_edac_ocx_probe(struct pci_dev *pdev, const struct pci_device_id *ent);\n>  void thunderx_edac_ocx_remove(struct pci_dev *pdev);\n>","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"B27mYlti\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"jmPtI7pY\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2NNZ4KVNz9t5l\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 02:21:02 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxF4z-00056S-8S; Wed, 27 Sep 2017 16:20:57 +0000","from casper.infradead.org ([2001:8b0:10b:1236::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxF4w-0003Jc-Rk for linux-arm-kernel@bombadil.infradead.org;\n\tWed, 27 Sep 2017 16:20:55 +0000","from szxga05-in.huawei.com ([45.249.212.191])\n\tby casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxEbO-0001lf-6g for linux-arm-kernel@lists.infradead.org;\n\tWed, 27 Sep 2017 15:50:25 +0000","from 172.30.72.59 (EHLO DGGEMS409-HUB.china.huawei.com)\n\t([172.30.72.59])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DID35116; Wed, 27 Sep 2017 23:49:05 +0800 (CST)","from localhost (10.206.48.115) by DGGEMS409-HUB.china.huawei.com\n\t(10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.301.0;\n\tWed, 27 Sep 2017 23:48:58 +0800"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=5aK2rk/EHS8/knAQpeoW55vnt61zXRqld/W9yWsnbH0=;\n\tb=B27mYltiKsuctm\n\tR5f+pypsmUANWFXWPALS9fYu293JwB9NX+10Obq7+iFWhp2V/5rBZHkq04SH3URfuQAB4efqh3JFZ\n\tB2JTo7LgeBvWaq85hyANpYWfS4ckRZ7xEZHpjmMZ+w9k9ohCx0vJy6cKvWc1L3Lb9iIEd6lBi8g0v\n\tLmzvG6EKzCkWv9afsQwZ3tc6WZxg5G45mF/pDkJtTZx/m3GmFBGAxbBRlZzuWerUtih7oImLU7PwS\n\tjfp/lBPyPPhnyN5gm91dIzvaJlWEFKYD6adNPOf7apP3rz9z6V4qdtdHWYaNz0P8MNonQ+BwHfh/4\n\t0wXQeXcXts2IJaT47jJA==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=casper.20170209;\n\th=Content-Transfer-Encoding:Content-Type:\n\tMIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To:From:Date:Sender\n\t:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:\n\tList-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=ME9oinAcuZloFp9w4izpzz07Warbh3z0ifnveBdEYYA=;\n\tb=jmPtI7pYtlma5VdlGD1XMDY2Yg\n\t2jvztmFssm2aOzYTA3y1mnD/m5VDnWr7oVcgsNEhOkdk/ACVpVnUHiZnIeEC1RzznAjKA58TmbEMX\n\tCwbhhVdSj4LIe5G+VaN/NjpuW+eKbD7Zlha3ZCDUP8TGUpQhOcHvGziZvHfrlotcfLZcP+G9ZKBzl\n\tv+1ucj0qb42ElcSXSONgmdzPv6cAxYhVJlpK0SblwXVdrElxmTPW2vKnO2KQjJsZHtkH483cwyZGr\n\thZurIhlaRE1BgLnLyzkWEUZswkrXAgP81k5TjKaD/TuGI0Mo4SOzVo75L7GFzrcfpdJeAYmRuSOmW\n\tXy99ZMjg==;"],"Date":"Wed, 27 Sep 2017 16:48:46 +0100","From":"Jonathan Cameron <Jonathan.Cameron@huawei.com>","To":"Jan Glauber <jglauber@cavium.com>","Subject":"Re: [PATCH v10 6/7] perf: cavium: Support transmit-link PMU counters","Message-ID":"<20170927164846.00001cbe@huawei.com>","In-Reply-To":"<20170925123502.17289-7-jglauber@cavium.com>","References":"<20170925123502.17289-1-jglauber@cavium.com>\n\t<20170925123502.17289-7-jglauber@cavium.com>","Organization":"Huawei","X-Mailer":"Claws Mail 3.15.0 (GTK+ 2.24.31; x86_64-w64-mingw32)","MIME-Version":"1.0","X-Originating-IP":"[10.206.48.115]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A010201.59CBC871.012E, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"14f98d66873382c769df4efb75aae9a9","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170927_165023_133777_069E5C6F ","X-CRM114-Status":"GOOD (  15.46  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on casper.infradead.org summary:\n\tContent analysis details:   (-1.9 points, 5.0 required)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tSuzuki K Poulose <Suzuki.Poulose@arm.com>,\n\tDavid Daney <david.daney@cavium.com>, Will Deacon <will.deacon@arm.com>, \n\tlinux-kernel@vger.kernel.org, Zhangshaokun <zhangshaokun@hisilicon.com>, \n\tBorislav Petkov <bp@alien8.de>, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778411,"web_url":"http://patchwork.ozlabs.org/comment/1778411/","msgid":"<20171002151756.GA11514@hc>","list_archive_url":null,"date":"2017-10-02T15:17:56","subject":"Re: [PATCH v10 3/7] edac,\n\tsoc: thunderx: Add wrapper for EDAC LMC PCI device","submitter":{"id":68474,"url":"http://patchwork.ozlabs.org/api/people/68474/","name":"Jan Glauber","email":"jan.glauber@caviumnetworks.com"},"content":"On Wed, Sep 27, 2017 at 06:19:01PM +0200, Borislav Petkov wrote:\n> On Mon, Sep 25, 2017 at 02:34:58PM +0200, Jan Glauber wrote:\n> > Cavium SOCs contain a memory controller that is presented as a\n> > PCI device. This PCI device will be used by an EDAC driver and\n> > by a PMU driver.\n> > \n> > To allow both subsystems to access the device a small wrapper is\n> > introduced that multi-plexes PCI probe and removal calls of the\n> > device to the EDAC driver.\n> > \n> > The same mechanism will be used later to call the PMU driver.\n> > \n> > The ThunderX EDAC driver is limited to only build as module\n> > with this patch. The reason is that with multiple users of the\n> > multi-plexer all users must be either builtin or modules.\n> > \n> > Signed-off-by: Jan Glauber <jglauber@cavium.com>\n> > ---\n> \n> ...\n> \n> > diff --git a/drivers/soc/cavium/cavium_lmc.c b/drivers/soc/cavium/cavium_lmc.c\n> > new file mode 100644\n> > index 000000000000..87248e83c55b\n> > --- /dev/null\n> > +++ b/drivers/soc/cavium/cavium_lmc.c\n> > @@ -0,0 +1,49 @@\n> > +/*\n> > + * These PCI devices contain RAS functionality and PMU counters. To allow\n> > + * independent RAS and PMU drivers this driver registers for the PCI devices\n> > + * and multi-plexes probe and removal.\n> > + *\n> > + * This file is subject to the terms and conditions of the GNU General Public\n> > + * License.  See the file \"COPYING\" in the main directory of this archive\n> > + * for more details.\n> > + *\n> > + * Copyright: Cavium, Inc. (C) 2017\n> > + *\n> > + */\n> > +#include <linux/module.h>\n> > +#include <linux/pci.h>\n> > +#include <linux/soc/cavium/lmc.h>\n> > +\n> > +static int cvm_lmc_probe(struct pci_dev *pdev,\n> > +\t\t\t const struct pci_device_id *ent)\n> > +{\n> > +\tif (IS_ENABLED(CONFIG_EDAC_THUNDERX))\n> > +\t\tthunderx_edac_lmc_probe(pdev, ent);\n> \n> You could save yourself the if (IS_ENABLED()) here by adding stubs in\n> the lmc.h header for those functions for the !CONFIG_EDAC_THUNDERX case.\n\nOK.\n\n> One thing I'm not clear on though, is the design of the whole thing:\n> cvm_lmc_probe() probes the EDAC driver during its own probe, which\n> means, thunderx_edac needs to be loaded first. And the other things that\n> get loaded, do the same.\n\nYes. That seems to work fine with the limitation of not being\nable to have mixed build options, everything needs to be modular or\nbuilt-in. So I forced all parts to be buildable only as modules.\n\nI went for this as the simplest solution, the probing is completely\nsynchronous and no state needs to be stored in the wrapper.\n\n> What I was expecting is those small cavium_lmc.c and cavium_ocx.c\n> wrappers to probe and register the respective PCI device and then its\n> *users* - EDAC and PMU drivers to go and request the PCI device from\n> them:\n> \n> cavium_lmc_get_pci_dev()\n> cavium_ocx_get_pci_dev()\n> \n> and so on. Those will be exported to modules. And the small stubs can\n> also be built-in too.\n\nSo this is the opposite approach which would be asynchronous. What I\ndon't understand with that approach:\n\n1. What will trigger probing the edac (or perf) driver part?\n   Right now the trigger is the PCI device ID. If the wrapper\n   does not call into edac how should we load the ThunderX edac/perf drivers?\n   The only option I see is a initcall in edac/perf to look for their devices.\n\n2. The probe & register is _very_ specific to perf/edac and very different.\n   The only part that would fit in the wrapper is pci_enable_device().\n   So is that what you have in mind?\n\n> This way you can do reference counting and whatever else.\n> \n> If the above calls fail, neither EDAC nor PMU will load properly but you\n> solve the multiplexing issue by having those wrappers arbitrate access\n> to the PCI devices.\n> \n> Because right now the wrappers are simply weakly hiding the calls into\n> EDAC and that's exactly what I was opposing to.\n> \n> Hmmm?\n\n> > +\treturn 0;\n> > +}\n> > +\n> > +static void cvm_lmc_remove(struct pci_dev *pdev)\n> > +{\n> > +\tif (IS_ENABLED(CONFIG_EDAC_THUNDERX))\n> > +\t\tthunderx_edac_lmc_remove(pdev);\n> > +}\n> > +\n> > +static const struct pci_device_id cvm_lmc_pci_table[] = {\n> > +\t{ PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, 0xa022) },\n> \n>         { PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVICE_ID_THUNDER_LMC) },\n> \n> You already have that PCI device id define.\n\nTrue, will use it.\n\nThanks for looking at this!\n\n--Jan\n\n> -- \n> Regards/Gruss,\n>     Boris.\n> \n> Good mailing practices for 400: avoid top-posting and trim the reply.","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"LSQ6Opuh\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"C/tuS+1b\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=Jan.Glauber@cavium.com; "],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5QmF26vwz9t6m\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tTue,  3 Oct 2017 02:18:37 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz2UM-0003Sk-Ag; Mon, 02 Oct 2017 15:18:34 +0000","from mail-cys01nam02on0062.outbound.protection.outlook.com\n\t([104.47.37.62] helo=NAM02-CY1-obe.outbound.protection.outlook.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz2UH-0003Nz-Vn for linux-arm-kernel@lists.infradead.org;\n\tMon, 02 Oct 2017 15:18:32 +0000","from hc (46.223.156.58) by SN2PR07MB2590.namprd07.prod.outlook.com\n\t(2603:10b6:804:7::20) with Microsoft SMTP Server (version=TLS1_2, \n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tMon, 2 Oct 2017 15:18:05 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=xCPO4ZVtk+uV98E6B1d15QUWhGC/vEvj7Wx4e3RUwsI=;\n\tb=LSQ6OpuhppR9r7\n\tK29YUlWh7OaVEz7BUkLIVyMXVTJmDKgZvtk89BQt0jgfCKt8mpGclqlOyic+pS45N3209EhIM8+Su\n\tDVCn5zIMQ160L+rfuE2x33viZ5wcAgIU4Yl4O8Wa7ZJHCByG9SJqEYjtVQCI3gjEtw0U7Xqxcfbv5\n\tR4Hp1PdJkAwDgJwWyBgE1Mor6nC/e31UQNw37a8wzEBx2RM3YKsBJVxyyM/ukMyWN7yhIWiuqN9n7\n\tiloMWXCGk3xOxuF3gOrDvfbnxNt/ZwsHrsDuPWGWVZybpezxzkpfsZ+dObL204yQXrQB0pb+RPV65\n\tCAt5HEWI4qHSgegoQwXQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=RBY3wvdsLQDjCiIGnqzUJmycfovgs4hcOmyg3XK22SA=;\n\tb=C/tuS+1bBQ1gaH82Ya3ID+6U2b0bsrb7o9K+Q6mK7nS0rhuiLVhXjyN6WcU4U92lNsuB3sH7aLqTfthZZ3/UuLzzsiYSGaUWWsg46INyuM9KOE7oflRxV0lEgqTQ/BL+0MHx6ZbB7cA0mw8ZZ01JUr9GRBtXehtPbPGjglOvwb0="],"Date":"Mon, 2 Oct 2017 17:17:56 +0200","From":"Jan Glauber <jan.glauber@caviumnetworks.com>","To":"Borislav Petkov <bp@alien8.de>","Subject":"Re: [PATCH v10 3/7] edac,\n\tsoc: thunderx: Add wrapper for EDAC LMC PCI device","Message-ID":"<20171002151756.GA11514@hc>","References":"<20170925123502.17289-1-jglauber@cavium.com>\n\t<20170925123502.17289-4-jglauber@cavium.com>\n\t<20170927161901.4hto7mrc2s4yuugn@pd.tnic>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170927161901.4hto7mrc2s4yuugn@pd.tnic>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-Originating-IP":"[46.223.156.58]","X-ClientProxiedBy":"AM4PR0501CA0051.eurprd05.prod.outlook.com\n\t(2603:10a6:200:68::19) To SN2PR07MB2590.namprd07.prod.outlook.com\n\t(2603:10b6:804:7::20)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"4171cbc3-3455-4972-16fe-08d509a8c8ca","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:SN2PR07MB2590; ","X-Microsoft-Exchange-Diagnostics":["1; SN2PR07MB2590;\n\t3:8E8iHkPX+swT7QkgMG63s3h8OmZNE4A96ErD4uSfVgAtxsdXL3lSVG+f+37JnYPtP4P11SFkKwh/HFZdzcyBBV0PR9HEqyflK71LSWCp+3/xbdAohTJvL/XFoi3yQ7ggcJu+exqmJv5ctaaqigzrUPv0YwV2VUy+vgVPZbUczyHezUOVms/gwPzC22L9HtCWuaDXfeggTfMpp1v6+vqR8gMc2S13KpvljbRFxJqwDvzVFrOipkaJtn7pDyjT2Bye;\n\t25:RCDit3DNPpJEl+M58PNvogPGgrpdmMtdHZ2gxTqu7oN4PDWKITUmJyVBAMD+GfMnhk6a32d+5aPigss4Y9ToNW/ssZtJuPSJztXa8Aueg7blFTfAtamDnTCJSsi8Ft/voaQYYay41LtVxhsJuQP4sTth90QHfqfrAHuq9LM+ihH1DVJM75Y/AImaKWmBqn4N++Gkp3wWH8IccEyoJWT5yzbGcMlw9lkfNa1PbeUCS2uBjleiG31wHj2O8gHzDAKcNuj/X3HExmENDJHs8vTyfm4AJ9MKpjqitqlwZSCFt4zeDJeqoE7W1FZkG24eT/NvwnjXt8Q5JYG6cppXQhT/0A==;\n\t31:HodUiZl42QlBOg8oQTyL53M9Ny3bTUjufTmtNvf1K3RxNUI7KJpmMd+stc+qW8VvV0qdXkCWpIwQicbtpCZ+6yrkcVOabsAt4dPr9gFpjc2MYsdYqxZckyV6KWTyB/7/Ei1MUAMnDMFp4WczIg6/KXmY+7DjOZXYFBXR/kJhyd1VeOQ9OSHGVBsc/5+D1BkhQTDu5aOVDX+qN9FNtnVwdutomLMW0Cod/5QZQIof9Jk=","1; SN2PR07MB2590;\n\t20:OLWZVhDjVN934M++iSI1eO/uQbXi89w7+0jg0h/pHh9QNt1tPSNiYArl1dPFYlAUMbdZPB2/sZFvPVsxIToQtmAsNtSpFArCkWumVYE+y98QtEfZETAtgGABhm1/la5tUP6RJFeN+uj+coBr8K+cj6Hr8K2rHAWYMtyXHdwNJ5mMfoxFk/VC/TuagrRjZPwICCZR90ayfY+96NAPiaS8TFUHdP+xE3FIG9baqDLNRvq9LVtK3k6rhEO/bAv/vLPpciuHY7GPO2VPiBEDbTHT6xSNufF/fPCj/mHG4oMEz18i9HcyVcIOIxKgxmyir5yo5Ey2fgm30IFSMptoaPFb2DQsABPiz9Nxi4OKeMz4+BWvGl/DbjjJ+hwrs5SzL/iIcecxhOXWNOOVpiAyinhPuI/rJUB2Ui+Ef/m8+SDkvupNM0Nhi8H0J3OQqfI7UWvB/nptynk7KY36k43A2eik8naSnpEkRvDuZj2BmAzCc+sFUW6E6VB1nZzuQXAdHloooABdLkGvanavTtoUyTcO07EtpSsnonXB6E9FXUQVuvZ6E4Ap/gldmCXYGru3eW1WKvCxm8HvsH67FzI1t/sa2ng4bw2Paim5agab303lqmk=;\n\t4:QxTbPWP20M0q8s/TEQopu8ynr4sCDTRAQe+9WDK+mFH1pyQcqBf27nz3uYVsuNsWjERWH2Yv5sslqeBW7aBXsPMnnaeQ/f/tjh0cplAJrpA5HneDK1S4Pr/KFuuZT85gijw59Rc7C+YvRRv7xxn4rXDVyltETHSXr/k+O3k/qAWm+TmocZsxDM/SuiyRycyvNv/jl5oI8RDzZdGUA6UmPUt/T3jWLa89UDLq+x7Dkt88EwOmB3UxS5akhRD2bupU","=?us-ascii?Q?1; SN2PR07MB2590;\n\t23:kUE7CBybTUG8DOTlWuERMeTN6BZVRBWasOEkd+2aG?=\n\thgLtBZuqKUAN1uSna3jsVuu23IrgM4rdIw/oHWUyI0X/NRvHEP74MhH4zNiFJYBtcxmeytuRODXB0F3txdc9PbpaM4gykWRH0ql5P3qfK1bCk/hjkowzvZFpV9ChITEzUsDy9acQqmHn0n3jH9vMhet37BZPb04pPPCslCr3LsdryclFeG9YP5iNMXZjqAHsMTfeVFy98mEwBU+wD8rCITZyZbFXodf+MECVmhozYFxjFLmAWn60Sqf3Q9ZNyTiuWWU2Xxo0xBVctYfM6wdLXnkmWdIz6Vj0ZaOIFQmsfXvERE8vVIG8xFg3yKcJsDqklCV2M34cA1iSkAaJ6MJiycjTOr/P6EA/vpEIA2xIQ1JVP1k9b17s10dkKc9/2V6+9S7qK+k1oDpmqEhQjrnLkRD4CDN3Usts21lwgABkb8l06vacmk8DTnav15XjiUJFvBEZRW+MbP2SUg4uKU9Jc7BeiEXZCRGlkrcN2ChdM3V7opLs4ch/5jHYuyf40hebjXab++hWgKj6LT4M+cz6PAHbP/AQlMmrSl56jPHpNqrVvjkCxFgkJ0teMk+QrVOlgu8N5msHqyUM+Ti7CtpSRxT4a91SuT98v1TpBkl0bXtLBO3eaUf2NKP7MJSsz1hMbNKF7Q6bxKQT7b2gfuXI3BLh1aDQXsL57XqcdOQF0Z1ju689TXOYhoOl4wLAh/J6qsaay/JHy8DCK6gtT9XnLFxxAMLHMC2546m7l/5DIQOkYX26TPh8+q0cu3nmvK1XARb/kZKOe24t1Hfvp4mzE9EydkaeVstijap22ZNR5RRULMOnBJm9T1Ufkdf9rWj+QAbpNqvIVT7TDHo8c1BKz7yTI1D1gdCMsmz0One7l+6+a3L3ezfBD2dEI4/BfoQJaF3242Gb82LS2ORpy2KYTOsRTE299WFB63hcwILtvFmKY8L9EpDQ8TcXhs5lAE5kGn9kYjcL2fXoUtyTcYBlplpCdB3l3CzaUpZH2SuKGFieOKBWeegAz2Tzbz21UvFqxTNRQvDW5PdzMexyAIkL/H7eT9yj4Nh56UMz7LFAr0POy0DW2bp2K3Bgt+DL5pBr8GKtp83wb1bInmsxfeurV3LKPVNjZHVa0gagqRMAVeY8ABiMY9cLxSmJMDRX4ZW42Cy1UUtTvaH05+ItHhuXcOpPWnbXRA+qaTXc6P6q9Ev5B0ktqlw83e1h3+Cit3lnIAXM6+oENlLN/yhAYoX6KhZ","1; SN2PR07MB2590;\n\t6:jSJ3WSKT6M4DvfbalFtlCXPnZn8XleGVNm89Lj/ng/CX+9gFBe3CfnFRa/dF+/Bx6ToqDOkjhK6mjvJASQHXwAeZzhzftlbXWhJWJ0qh0g7K5b0TD7Q9/jCTWhu2mQSwwKfZlt3M03MK+BxneDZtNVBxh7a7k3dcytju1uaFu9vu9H7eQf2mNUjLjOhDGp/SCDYjS5jAXgqroRts45lqy60hsbHg9Jc63RG5A6mCvoA3CLD7Y9y5f4C3iVRGLuVTIcz4uzhterLnR68uJNvTbXCQXI+aaUmjFFPDKxdSu6LOY3LanGeccdlBa7TWROSlAd4VMF8HzESQInkSdOInmg==;\n\t5:E3NfKl6IzYRbEigIjCllGF3gbywwmc0ZIzeAwQ/MTPBm0pREfkyyRAD5SVQcU2lMkdx0pZsX3StsV7m/JNlOIDmt1xiNgeQZXa9qYgg5O9tKBpVy4eQ+rMyXqHBgTSqtJMO7R1A4Yxqc6CRg0i7vEw==;\n\t24:0/rZVddxSiNe9drXu7JmibYbVAvIJhrUAptF7cPNXiGvV8ESOJtchCT0pzajsj+rxciLvE9y+fV0FyKvV2ybxHpy1DZCR+jncI6G4Y2ADKA=;\n\t7:f1aRVqp/KCpOm7q1/mYTpytci6hqHVCFa+hCKCgI5Mo+uw/Z0fH+thsUHZgGy0+fk+8F5GI9HrCquYwCrbV4rtJW3W4A2oRUgJpUiI9IoqA8S5+BuZBsj6re/6ssl2+1/i/cHnT7kStnjOVSRBu0Lrn09BQzS4ElcNz0pOuaPnx9fE8o71ehBtj3aTNYJ7+jWbD3L0b3M6OUrz1akGJtOBTM3crQA1RWegWDF45o9MY="],"X-MS-TrafficTypeDiagnostic":"SN2PR07MB2590:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<SN2PR07MB2590950439878267CDF69C0E917D0@SN2PR07MB2590.namprd07.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:SN2PR07MB2590; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:SN2PR07MB2590; ","X-Forefront-PRVS":"0448A97BF2","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(199003)(24454002)(189002)(6116002)(97736004)(6246003)(7736002)(6496005)(189998001)(305945005)(9686003)(5660300001)(33716001)(6666003)(105586002)(58126008)(54906003)(8936002)(81166006)(316002)(72206003)(47776003)(33656002)(53936002)(55016002)(66066001)(1076002)(478600001)(8676002)(81156014)(4326008)(16586007)(16526017)(101416001)(50466002)(229853002)(54356999)(76176999)(106356001)(50986999)(23726003)(68736007)(3846002)(83506001)(42882006)(25786009)(2906002)(6916009)(2950100002)(18370500001)(142933001)(217873001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2590; H:hc; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"caviumnetworks.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"02 Oct 2017 15:18:05.5948\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SN2PR07MB2590","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171002_081830_275472_3AAD4235 ","X-CRM114-Status":"GOOD (  31.67  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [104.47.37.62 listed in list.dnswl.org]\n\t-0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)\n\t[104.47.37.62 listed in wl.mailspike.net]\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-0.0 SPF_HELO_PASS          SPF: HELO matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>, David Daney <david.daney@cavium.com>,\n\tSuzuki K Poulose <Suzuki.Poulose@arm.com>,\n\tWill Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org,\n\tZhangshaokun <zhangshaokun@hisilicon.com>, \n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1779645,"web_url":"http://patchwork.ozlabs.org/comment/1779645/","msgid":"<20171004103426.g6ivm6w7dfhcoluh@pd.tnic>","list_archive_url":null,"date":"2017-10-04T10:34:26","subject":"Re: [PATCH v10 3/7] edac,\n\tsoc: thunderx: Add wrapper for EDAC LMC PCI device","submitter":{"id":4449,"url":"http://patchwork.ozlabs.org/api/people/4449/","name":"Borislav Petkov","email":"bp@alien8.de"},"content":"On Mon, Oct 02, 2017 at 05:17:56PM +0200, Jan Glauber wrote:\n> I went for this as the simplest solution, the probing is completely\n> synchronous and no state needs to be stored in the wrapper.\n\nWhat state would you need to store? The wrapper simply gives out the\nstruct pci_dev * to the callers or NULL if not present.\n\n> 1. What will trigger probing the edac (or perf) driver part?\n>    Right now the trigger is the PCI device ID. If the wrapper\n>    does not call into edac how should we load the ThunderX edac/perf drivers?\n>    The only option I see is a initcall in edac/perf to look for their devices.\n\nThe wrapper loads on the PCI dev ID. EDAC loads later and calls the\nwrapper function to get the struct pci_dev *. Simple.\n\n> 2. The probe & register is _very_ specific to perf/edac and very different.\n>    The only part that would fit in the wrapper is pci_enable_device().\n>    So is that what you have in mind?\n\nNo, see above. Instead of getting the PCI device IDs from the PCI core,\nyou use the wrapper, which gets those from the PCI core. Thus it is\ncalled a \"wrapper\". :)","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"ow/xjhGU\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6XNR4C7xz9sRm\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed,  4 Oct 2017 21:35:19 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dzh1I-0000Ig-41; Wed, 04 Oct 2017 10:35:16 +0000","from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dzh1E-0007Om-9x for linux-arm-kernel@lists.infradead.org;\n\tWed, 04 Oct 2017 10:35:14 +0000","from mail.skyhub.de ([127.0.0.1])\n\tby localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026)\n\twith ESMTP id J0eHmviLxBIJ; Wed,  4 Oct 2017 12:34:46 +0200 (CEST)","from pd.tnic (p2003008C2F22CC0021CE6FB10A279C5D.dip0.t-ipconnect.de\n\t[IPv6:2003:8c:2f22:cc00:21ce:6fb1:a27:9c5d])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id\n\t1D20F1EC00EE; Wed,  4 Oct 2017 12:34:46 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=rsWh+kCVN+KLemBv4+0sNxZV8BzkCdNP0fN6DIpbGuw=;\n\tb=ow/xjhGUroHxBG\n\t2k4/R7WdDeLUs8elq0ZbgxgLxPO6KShN+6WqZLemJXOu6MKeza9QgWYZUXUBeulFY9uaarbVxfc/M\n\tEy9o4JZo0A9sOIYnaiw/rY/2K88MhkyIGuibS1e2pXtd0OWfCGDhRV7JfQViRS14YDgMoFbI9/7VD\n\tDqWTSt1ry6u4cKgyaLNQVfLh7rS+pMpShF04JcPQqsKDFHKwq4MYZgVOWc/U5AnSnjSVtILBR/xIJ\n\thT129eQPFOGBtrSfyT8Uy80URil9ZKt1yv6OowXPUvZCwKsBccOe2sUgfzFW/V0drcFvMYK4VsKj3\n\tOY7RBsWZA0hu/jmzuMIA==;","X-Virus-Scanned":"Nedap ESD1 at mail.skyhub.de","Date":"Wed, 4 Oct 2017 12:34:26 +0200","From":"Borislav Petkov <bp@alien8.de>","To":"Jan Glauber <jan.glauber@caviumnetworks.com>","Subject":"Re: [PATCH v10 3/7] edac,\n\tsoc: thunderx: Add wrapper for EDAC LMC PCI device","Message-ID":"<20171004103426.g6ivm6w7dfhcoluh@pd.tnic>","References":"<20170925123502.17289-1-jglauber@cavium.com>\n\t<20170925123502.17289-4-jglauber@cavium.com>\n\t<20170927161901.4hto7mrc2s4yuugn@pd.tnic>\n\t<20171002151756.GA11514@hc>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20171002151756.GA11514@hc>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171004_033512_546660_1196595F ","X-CRM114-Status":"GOOD (  13.04  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>, David Daney <david.daney@cavium.com>,\n\tSuzuki K Poulose <Suzuki.Poulose@arm.com>,\n\tWill Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org,\n\tZhangshaokun <zhangshaokun@hisilicon.com>, \n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1802040,"web_url":"http://patchwork.ozlabs.org/comment/1802040/","msgid":"<6ff478bb-ebaf-da43-3ee8-2889209278ca@arm.com>","list_archive_url":null,"date":"2017-11-09T10:07:02","subject":"Re: [PATCH v10 5/7] perf: cavium: Support memory controller PMU\n\tcounters","submitter":{"id":65822,"url":"http://patchwork.ozlabs.org/api/people/65822/","name":"Suzuki K Poulose","email":"suzuki.poulose@arm.com"},"content":"On 25/09/17 13:35, Jan Glauber wrote:\n> Add support for the PMU counters on Cavium SOC memory controllers.\n> \n> This patch also adds generic functions to allow supporting more\n> devices with PMU counters.\n> \n> Properties of the LMC PMU counters:\n> - not stoppable\n> - fixed purpose\n> - read-only\n> - one PCI device per memory controller\n> \n> Signed-off-by: Jan Glauber <jglauber@cavium.com>\n> ---\n>   drivers/perf/Kconfig            |   8 +\n>   drivers/perf/Makefile           |   1 +\n>   drivers/perf/cavium_pmu.c       | 430 ++++++++++++++++++++++++++++++++++++++++\n>   drivers/soc/cavium/cavium_lmc.c |   4 +\n>   include/linux/cpuhotplug.h      |   1 +\n>   include/linux/soc/cavium/lmc.h  |   3 +\n>   6 files changed, 447 insertions(+)\n>   create mode 100644 drivers/perf/cavium_pmu.c\n\n> +int cvm_lmc_pmu_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n> +{\n> +\tstruct cvm_pmu_dev *next, *lmc;\n> +\tint nr = 0, ret = -ENOMEM;\n> +\tchar *name;\n> +\n> +\tlmc = devm_kzalloc(&pdev->dev, sizeof(*lmc), GFP_KERNEL);\n> +\tif (!lmc)\n> +\t\treturn -ENOMEM;\n> +\n> +\tlmc->map = devm_ioremap(&pdev->dev, pci_resource_start(pdev, 0),\n> +\t\t\t\tpci_resource_len(pdev, 0));\n> +\tif (!lmc->map)\n> +\t\treturn -EINVAL;\n> +\n> +\tlist_for_each_entry(next, &cvm_pmu_lmcs, entry)\n> +\t\tnr++;\n> +\tname = devm_kasprintf(&pdev->dev, GFP_KERNEL, \"lmc%d\", nr);\n> +\tif (!name)\n> +\t\treturn -ENOMEM;\n> +\n> +\tlmc->pdev = pdev;\n> +\tlmc->num_counters = ARRAY_SIZE(cvm_pmu_lmc_events_attr) - 1;\n> +\tlmc->pmu = (struct pmu) {\n> +\t\t.task_ctx_nr    = perf_invalid_context,\n> +\t\t.name\t\t= name,\n> +\t\t.event_init\t= cvm_pmu_event_init,\n> +\t\t.add\t\t= cvm_pmu_lmc_add,\n> +\t\t.del\t\t= cvm_pmu_del,\n> +\t\t.start\t\t= cvm_pmu_start,\n> +\t\t.stop\t\t= cvm_pmu_stop,\n> +\t\t.read\t\t= cvm_pmu_read,\n> +\t\t.attr_groups\t= cvm_pmu_lmc_attr_groups,\n> +\t};\n> +\n\nYou need to fill in the \"module\" field of the PMU to prevent the module from\nbeing unloaded while the PMU is active.\n\nSee :\n\nhttp://lists.infradead.org/pipermail/linux-arm-kernel/2017-November/540647.html\n\nSuzuki","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"RsqiHX2I\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yXf48019fz9t6K\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu,  9 Nov 2017 21:07:52 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eCjkT-0006c0-Qb; Thu, 09 Nov 2017 10:07:49 +0000","from foss.arm.com ([217.140.101.70])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1eCjkO-0006LX-TH for linux-arm-kernel@lists.infradead.org;\n\tThu, 09 Nov 2017 10:07:47 +0000","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A20A414;\n\tThu,  9 Nov 2017 02:07:23 -0800 (PST)","from [10.1.206.28] (e107814-lin.cambridge.arm.com [10.1.206.28])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t384883F246; Thu,  9 Nov 2017 02:07:22 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=VNEHAw+PCuYmMbufjEOUU1thCjpm8JZfspcnjzZ4nsA=;\n\tb=RsqiHX2IEoXEbj8831HjImjLy\n\tarlMU4ZCNVU4zr9zmVveeCU4zkiG18wO78TeBI2AT6KdYBPfjTTZ8Ei+rnq3mzfjkILdZ5Pzi/u82\n\tRhB+SlwOGTR6JWOZiTMOKIhfBARXpu2TdPj1QgXZADGsDYZrfHudZnXGv4pcwYn/zpEqVrGbnSLmZ\n\tRqLrxyCoxHHxSneJfSUd3bLvyh9B3saQROYujUBpUOCD/SV4f+nWbtvIiaBqG3VzK+qE0yuIJelXo\n\tGxEy0z1wwtgZqlZXwTftzW4J+vppu91r0KgVU3jDY9p80W9xvD6rp7FVB8G0IMSJnT3h49JwVBggc\n\ta+gVPNWuA==;","Subject":"Re: [PATCH v10 5/7] perf: cavium: Support memory controller PMU\n\tcounters","To":"Jan Glauber <jglauber@cavium.com>, Mark Rutland <mark.rutland@arm.com>, \n\tWill Deacon <will.deacon@arm.com>","References":"<20170925123502.17289-1-jglauber@cavium.com>\n\t<20170925123502.17289-6-jglauber@cavium.com>","From":"Suzuki K Poulose <Suzuki.Poulose@arm.com>","Message-ID":"<6ff478bb-ebaf-da43-3ee8-2889209278ca@arm.com>","Date":"Thu, 9 Nov 2017 10:07:02 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170925123502.17289-6-jglauber@cavium.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171109_020745_059792_9B49A04D ","X-CRM114-Status":"GOOD (  15.61  )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-6.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [217.140.101.70 listed in list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Zhangshaokun <zhangshaokun@hisilicon.com>, Borislav Petkov <bp@alien8.de>,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tDavid Daney <david.daney@cavium.com>","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]