[{"id":1774954,"web_url":"http://patchwork.ozlabs.org/comment/1774954/","msgid":"","list_archive_url":null,"date":"2017-09-25T20:02:43","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple\n\troots above top node","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/25/2017 08:28 AM, Kevin Wolf wrote:\n> This is a step towards making the commit job flexible enough that it can\n> work with any kind of block graph. Currently, it requires that not only\n> the top and base node of the commit operation are specified, but also\n> the active layer of the backing file chain. Of course, the assumption\n> that a single active layer exists is invalid.\n> \n> This series makes the commit job consider other roots as well so that\n> all parent nodes of the top node get their backing file updated and stay\n> valid after the commit job completes.\n> \n> With this, we should have all of the prerequisites for a follow-up\n> series that adds a new and clean blockdev-commit QMP command which\n> doesn't require an option for the active layer and which accepts node\n> names instead of file names for base and top.\n> \n> Kevin Wolf (5):\n> block: Introduce BdrvChildRole.update_filename\n> commit: Support multiple roots above top node\n> qemu-iotests: Allow QMP pretty printing in common.qemu\n> qemu-iotests: Test commit block job where top has two parents\n> commit: Remove overlay_bs\n> \n> include/block/block.h | 3 +-\n> include/block/block_int.h | 6 +\n> block.c | 91 +++--\n> block/commit.c | 64 +---\n> tests/qemu-iotests/030 | 4 -\n> tests/qemu-iotests/191 | 152 ++++++++\n> tests/qemu-iotests/191.out | 827 +++++++++++++++++++++++++++++++++++++++++\n> tests/qemu-iotests/common.qemu | 14 +-\n> tests/qemu-iotests/group | 1 +\n> 9 files changed, 1078 insertions(+), 84 deletions(-)\n> create mode 100755 tests/qemu-iotests/191\n> create mode 100644 tests/qemu-iotests/191.out\n> \n\nDoes this depend on another series?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1FQ00jzWz9s7M\n\tfor ;\n\tTue, 26 Sep 2017 06:03:17 +1000 (AEST)","from localhost ([::1]:44059 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwZb0-00025c-9M\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 16:03:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52875)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwZad-00023w-MK\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:02:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwZac-0005XA-Pt\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:02:51 -0400","from mx1.redhat.com ([209.132.183.28]:32934)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwZaY-0005Tc-FP; Mon, 25 Sep 2017 16:02:46 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9D5BF7E421;\n\tMon, 25 Sep 2017 20:02:44 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E1E6A69541;\n\tMon, 25 Sep 2017 20:02:43 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9D5BF7E421","To":"Kevin Wolf , qemu-block@nongnu.org","References":"<20170925122808.14561-1-kwolf@redhat.com>","From":"John Snow ","Message-ID":"","Date":"Mon, 25 Sep 2017 16:02:43 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170925122808.14561-1-kwolf@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 25 Sep 2017 20:02:44 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple\n\troots above top node","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775223,"web_url":"http://patchwork.ozlabs.org/comment/1775223/","msgid":"<20170926075916.GA3399@localhost.localdomain>","list_archive_url":null,"date":"2017-09-26T07:59:16","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple\n\troots above top node","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 25.09.2017 um 22:02 hat John Snow geschrieben:\n> On 09/25/2017 08:28 AM, Kevin Wolf wrote:\n> > This is a step towards making the commit job flexible enough that it can\n> > work with any kind of block graph. Currently, it requires that not only\n> > the top and base node of the commit operation are specified, but also\n> > the active layer of the backing file chain. Of course, the assumption\n> > that a single active layer exists is invalid.\n> > \n> > This series makes the commit job consider other roots as well so that\n> > all parent nodes of the top node get their backing file updated and stay\n> > valid after the commit job completes.\n> > \n> > With this, we should have all of the prerequisites for a follow-up\n> > series that adds a new and clean blockdev-commit QMP command which\n> > doesn't require an option for the active layer and which accepts node\n> > names instead of file names for base and top.\n> > \n> > Kevin Wolf (5):\n> > block: Introduce BdrvChildRole.update_filename\n> > commit: Support multiple roots above top node\n> > qemu-iotests: Allow QMP pretty printing in common.qemu\n> > qemu-iotests: Test commit block job where top has two parents\n> > commit: Remove overlay_bs\n> \n> Does this depend on another series?\n\nIt is based on my block branch. I think specifically the series \"block:\nFix permissions after ro/rw reopen\" might be needed for the patches to\nwork correctly.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1YJp1DD1z9t2S\n\tfor ;\n\tTue, 26 Sep 2017 17:59:53 +1000 (AEST)","from localhost ([::1]:46074 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwkmT-0000Tk-Rv\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 03:59:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34038)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwkm8-0000SV-BU\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 03:59:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwkm7-0000jP-Hq\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 03:59:28 -0400","from mx1.redhat.com ([209.132.183.28]:43118)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwkm3-0000i8-0t; Tue, 26 Sep 2017 03:59:23 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E5644806B8;\n\tTue, 26 Sep 2017 07:59:21 +0000 (UTC)","from localhost.localdomain (ovpn-117-39.ams2.redhat.com\n\t[10.36.117.39])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 93F2058860;\n\tTue, 26 Sep 2017 07:59:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E5644806B8","Date":"Tue, 26 Sep 2017 09:59:16 +0200","From":"Kevin Wolf ","To":"John Snow ","Message-ID":"<20170926075916.GA3399@localhost.localdomain>","References":"<20170925122808.14561-1-kwolf@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 26 Sep 2017 07:59:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple\n\troots above top node","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]