[{"id":1774658,"web_url":"http://patchwork.ozlabs.org/comment/1774658/","msgid":"","list_archive_url":null,"date":"2017-09-25T11:21:34","subject":"Re: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35]","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Fabrizio,\n\nOn Mon, Sep 25, 2017 at 10:54 AM, Fabrizio Castro\n wrote:\n> Signed-off-by: Fabrizio Castro \n\nThis patch is not needed...\n\n> ---\n> drivers/spi/spi-sh-msiof.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c\n> index 0eb1e95..0080844 100644\n> --- a/drivers/spi/spi-sh-msiof.c\n> +++ b/drivers/spi/spi-sh-msiof.c\n> @@ -1021,6 +1021,8 @@ static const struct sh_msiof_chipdata rcar_gen3_data = {\n>\n> static const struct of_device_id sh_msiof_match[] = {\n> { .compatible = \"renesas,sh-mobile-msiof\", .data = &sh_data },\n> + { .compatible = \"renesas,msiof-r8a7743\", .data = &rcar_gen2_data },\n> + { .compatible = \"renesas,msiof-r8a7745\", .data = &rcar_gen2_data },\n> { .compatible = \"renesas,msiof-r8a7790\", .data = &rcar_gen2_data },\n> { .compatible = \"renesas,msiof-r8a7791\", .data = &rcar_gen2_data },\n> { .compatible = \"renesas,msiof-r8a7792\", .data = &rcar_gen2_data },\n\n... as the driver already matches against the family-specific compatible value\nbelow:\n\n { .compatible = \"renesas,rcar-gen2-msiof\", .data = &rcar_gen2_data },\n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"S2AtTc2i\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y11r60gxYz9t67\n\tfor ;\n\tMon, 25 Sep 2017 21:21:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932987AbdIYLVj (ORCPT );\n\tMon, 25 Sep 2017 07:21:39 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:34955 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S935154AbdIYLVg (ORCPT\n\t); Mon, 25 Sep 2017 07:21:36 -0400","by mail-wm0-f65.google.com with SMTP id e64so6939700wmi.2;\n\tMon, 25 Sep 2017 04:21:35 -0700 (PDT)","by 10.223.129.226 with HTTP; Mon, 25 Sep 2017 04:21:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=izl7bkK6YxqvgcMRo2HA0iohsIE2YXQZFUBJfMxTRRs=;\n\tb=S2AtTc2iHRn/hkMnJ8YS/tVNF1xkcgs8XjrpG64u7dvUSfmpki3iIxzLGGgcne8L/L\n\tlkOfqxbxlwpyyfltkVpL/P9zqKjrNDASDw85h3L72qU5sEDaj4/j9zWS7F8CJhOAR1ZV\n\tO/inT0G808FQONJDW4ZY4nihe1IyPzmRK569Qp93GytgS05169wa3BwLSyul3X2Hk3IM\n\tai98dNMkf1B1hI+VmF2hDCHggzQr7kvIaWoCgCqEp8fKHYfEGUxUTq0KoO3PANaHl3D2\n\t+pDBWNHy0GSvrDbK7wbVQ7EnGsN5UOOVmIxE0AHG81lkEwXHZHJeTDlbznDvUf3QKoZ7\n\tZU+g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=izl7bkK6YxqvgcMRo2HA0iohsIE2YXQZFUBJfMxTRRs=;\n\tb=LV6tCHkFzO8T0MyCGCLI/09kzI6lPBvUrqtdYH9bb7Ltn6X+jLCH79ml2F9+WRAQdR\n\tVfDHRvjtvBgJIRVtAZY9YEkVEN6V1UmWOKNYHIPhxPJMv9ddwkv0AefCO57/JXPitx9B\n\tFqymxjujZUxkdmStSBHe7BIxfLm7KAhVJS4jz9YB/UO1VriZXi3uap2ftDusfpOSXrun\n\tBCo59epcS8O9oyioMVY60arasoN5AoDUwfF7Ri9WuSsDhKC5t4qQvAA1kvGFvz8t+WsW\n\t+VAmtgnKe3+xU/0ZOaSwxiRQoCRi2/UpfJZOvi8GHpCo1vAmRI9OQqXfVDl1tmBbPCIa\n\tnIPg==","X-Gm-Message-State":"AHPjjUjBiMpkKDJqYgjdTaC9HEMtWnqjRisoVmg6FvYqauFjdLMQFiJv\n\t9Dk0e1ug2uaI+QGRzIFlHqgUoEFBD26EK/rFiH8Jtg==","X-Google-Smtp-Source":"AOwi7QBARhh7WYtIKvaLJbR3HNDH93zXD4NwVOC8hoAFDApSFSd6BzOL3ax8XpoRBUZlmSVci51c4sGxRaND8ZsnH3o=","X-Received":"by 10.28.203.4 with SMTP id b4mr105109wmg.17.1506338494738; Mon,\n\t25 Sep 2017 04:21:34 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506329660-4064-2-git-send-email-fabrizio.castro@bp.renesas.com>","References":"<1506329660-4064-1-git-send-email-fabrizio.castro@bp.renesas.com>\n\t<1506329660-4064-2-git-send-email-fabrizio.castro@bp.renesas.com>","From":"Geert Uytterhoeven ","Date":"Mon, 25 Sep 2017 13:21:34 +0200","X-Google-Sender-Auth":"b8SXw3DBy6v7N_SG4OUzNPvIhzw","Message-ID":"","Subject":"Re: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35]","To":"Fabrizio Castro ","Cc":"Mark Brown , Rob Herring ,\n\tMark Rutland ,\n\tlinux-spi , \n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ,\n\tChris Paterson ,\n\tBiju Das ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1774680,"web_url":"http://patchwork.ozlabs.org/comment/1774680/","msgid":"","list_archive_url":null,"date":"2017-09-25T12:01:28","subject":"RE: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35]","submitter":{"id":72129,"url":"http://patchwork.ozlabs.org/api/people/72129/","name":"Fabrizio Castro","email":"fabrizio.castro@bp.renesas.com"},"content":"Hello Geert,\r\n\r\nThank you for getting back to me.\r\n\r\n> -----Original Message-----\r\n> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven\r\n> Sent: 25 September 2017 12:22\r\n> To: Fabrizio Castro \r\n> Cc: Mark Brown ; Rob Herring ; Mark Rutland ; linux-spi\r\n> ; devicetree@vger.kernel.org; Linux-Renesas ; Chris Paterson\r\n> ; Biju Das \r\n> Subject: Re: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35]\r\n>\r\n> Hi Fabrizio,\r\n>\r\n> On Mon, Sep 25, 2017 at 10:54 AM, Fabrizio Castro\r\n> wrote:\r\n> > Signed-off-by: Fabrizio Castro \r\n>\r\n> This patch is not needed...\r\n>\r\n> > ---\r\n> > drivers/spi/spi-sh-msiof.c | 2 ++\r\n> > 1 file changed, 2 insertions(+)\r\n> >\r\n> > diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c\r\n> > index 0eb1e95..0080844 100644\r\n> > --- a/drivers/spi/spi-sh-msiof.c\r\n> > +++ b/drivers/spi/spi-sh-msiof.c\r\n> > @@ -1021,6 +1021,8 @@ static const struct sh_msiof_chipdata rcar_gen3_data = {\r\n> >\r\n> > static const struct of_device_id sh_msiof_match[] = {\r\n> > { .compatible = \"renesas,sh-mobile-msiof\", .data = &sh_data },\r\n> > + { .compatible = \"renesas,msiof-r8a7743\", .data = &rcar_gen2_data },\r\n> > + { .compatible = \"renesas,msiof-r8a7745\", .data = &rcar_gen2_data },\r\n> > { .compatible = \"renesas,msiof-r8a7790\", .data = &rcar_gen2_data },\r\n> > { .compatible = \"renesas,msiof-r8a7791\", .data = &rcar_gen2_data },\r\n> > { .compatible = \"renesas,msiof-r8a7792\", .data = &rcar_gen2_data },\r\n>\r\n> ... as the driver already matches against the family-specific compatible value\r\n> below:\r\n>\r\n> { .compatible = \"renesas,rcar-gen2-msiof\", .data = &rcar_gen2_data },\r\n\r\nWe suspected this was the case, but we weren't sure.\r\nI apologize for wasting your time.\r\n\r\nCheers,\r\nFabrizio\r\n\r\n>\r\n> Gr{oetje,eeting}s,\r\n>\r\n> Geert\r\n>\r\n> --\r\n> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\r\n>\r\n> In personal conversations with technical people, I call myself a hacker. But\r\n> when I'm talking to journalists I just say \"programmer\" or something like that.\r\n> -- Linus Torvalds\r\n\r\n\r\n\r\nRenesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=renesasgroup.onmicrosoft.com\n\theader.i=@renesasgroup.onmicrosoft.com header.b=\"BPww/cyv\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=fabrizio.castro@bp.renesas.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y12k86Ydpz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 22:01:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934751AbdIYMBf (ORCPT );\n\tMon, 25 Sep 2017 08:01:35 -0400","from relmlor3.renesas.com ([210.160.252.173]:21699 \"EHLO\n\trelmlie2.idc.renesas.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S933685AbdIYMBe (ORCPT\n\t); Mon, 25 Sep 2017 08:01:34 -0400","from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152])\n\tby relmlie2.idc.renesas.com with ESMTP; 25 Sep 2017 21:01:32 +0900","from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com\n\t[10.200.68.65])\n\tby relmlir2.idc.renesas.com (Postfix) with ESMTP id 1D84B71A6B;\n\tMon, 25 Sep 2017 21:01:32 +0900 (JST)","from mail-os2jpn01lp0148.outbound.protection.outlook.com (HELO\n\tJPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.148])\n\tby relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256;\n\t25 Sep 2017 21:01:31 +0900","from TY1PR06MB0895.apcprd06.prod.outlook.com (10.164.99.146) by\n\tTY1PR06MB0702.apcprd06.prod.outlook.com (10.163.245.12) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Mon, 25 Sep 2017 12:01:29 +0000","from TY1PR06MB0895.apcprd06.prod.outlook.com ([10.164.99.146]) by\n\tTY1PR06MB0895.apcprd06.prod.outlook.com ([10.164.99.146]) with\n\tmapi id 15.20.0077.011; Mon, 25 Sep 2017 12:01:29 +0000"],"X-IronPort-AV":"E=Sophos;i=\"5.42,436,1500908400\"; d=\"scan'208\";a=\"257669617\"","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=renesasgroup.onmicrosoft.com; s=selector1-bp-renesas-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=klhv9cpoW2evPs7vaoFitbxG8lXs1+7DINVZtcKxYGU=;\n\tb=BPww/cyv4xnxk8svlz7smKnXFudoK2pLcailpq69ZpvdbSBwEyufunaoJw0rmZY5XvtYR9SS8kP7ROpOKajlJRlHyQK8ec1/awI5hFxbDfuzBKGTJpHu43e59+CpJAjAxMvhUYqn6EMAX09QAFbuHe/LPHpz3L73enZ6zFYpQp4=","From":"Fabrizio Castro ","To":"Geert Uytterhoeven ","CC":"Mark Brown , Rob Herring ,\n\t\"Mark Rutland\" ,\n\tlinux-spi ,\n\t\"devicetree@vger.kernel.org\" ,\n\tLinux-Renesas ,\n\tChris Paterson ,\n\tBiju Das ","Subject":"RE: [PATCH 1/2] spi: sh-msiof: Add compatible strings for r8a774[35]","Thread-Topic":"[PATCH 1/2] spi: sh-msiof: Add compatible strings for\n\tr8a774[35]","Thread-Index":"AQHTNdvx9nleDSQTxEWkkpRETVZ5X6LFdSsAgAAKSNA=","Date":"Mon, 25 Sep 2017 12:01:28 +0000","Message-ID":"","References":"<1506329660-4064-1-git-send-email-fabrizio.castro@bp.renesas.com>\n\t<1506329660-4064-2-git-send-email-fabrizio.castro@bp.renesas.com>\n\t","In-Reply-To":"","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=renesasgroup.onmicrosoft.com\n\theader.i=@renesasgroup.onmicrosoft.com header.b=\"BPww/cyv\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=fabrizio.castro@bp.renesas.com; "],"x-originating-ip":"[193.141.220.21]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; TY1PR06MB0702;\n\t20:Ek82vlgir4g3l1908HY5Bhru2O1pPXD+Gs8DJiue3Pl6ooNsbwZnFLsk6pGVc8+OucmBWsQLdc/xuFlZEw5iYbGwUcOPpKBDXQsnKp0/GPnOiNnRSxLalu4adKRzueegpCCLT/QAWTWf4YOjMFmSzah7ycGPT+QMOcdcf0pv3pM=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-ms-office365-filtering-correlation-id":"fe75eff4-36ec-45b7-e5c5-08d5040d27c5","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:TY1PR06MB0702; ","x-ms-traffictypediagnostic":"TY1PR06MB0702:","x-exchange-antispam-report-test":"UriScan:(180628864354917)(9452136761055);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:TY1PR06MB0702; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:TY1PR06MB0702; ","x-forefront-prvs":"04410E544A","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(346002)(376002)(39860400002)(24454002)(13464003)(377454003)(189002)(199003)(105586002)(106356001)(2900100001)(86362001)(7696004)(101416001)(53546010)(189998001)(305945005)(2906002)(50986999)(76176999)(54356999)(74316002)(6436002)(5660300001)(345774005)(8936002)(77096006)(3660700001)(4326008)(68736007)(7736002)(81156014)(6116002)(33656002)(3280700002)(102836003)(6506006)(3846002)(53936002)(66066001)(25786009)(6916009)(42882006)(316002)(2950100002)(97736004)(9686003)(99286003)(54906003)(6246003)(55016002)(14454004)(478600001)(81166006)(8676002)(107886003)(229853002);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0702;\n\tH:TY1PR06MB0895.apcprd06.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:0; LANG:en; ","received-spf":"None (protection.outlook.com: bp.renesas.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-OriginatorOrg":"bp.renesas.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"25 Sep 2017 12:01:28.8503\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"53d82571-da19-47e4-9cb4-625a166a4a2a","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"TY1PR06MB0702","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]