[{"id":1776567,"web_url":"http://patchwork.ozlabs.org/comment/1776567/","msgid":"<20170927193616.32gxszmk4cjjoqmo@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-27T19:36:16","subject":"Re: [RFC v2 0/2] Add support for Meson MX \"SDIO\" MMC controller","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sun, Sep 24, 2017 at 09:05:26PM +0200, Martin Blumenstingl wrote:\n> This is the successor to Carlo Caione's \"Add support for Amlogic Meson\n> MMC driver\" series (v5) from [0].\n> This new driver is for the \"SDIO\" controller found in Amlogic Meson6,\n> Meson8 and Meson8b SoCs and supports an internal mux to allow connecting\n> three cards to it.\n> \n> \n> changes since RFC v1 at [1]:\n> - added COMMON_CLK dependency as reported by the kbuild test robot\n> - use of_platform_device_{create,destroy} instead of open-coding it's\n>   logic\n> - moved struct device (which was an array) from meson_mx_mmc_host to\n>   the corresponding meson_mx_mmc_slot\n> - use struct mmc_command's busy_timeout instead of hard-coding the\n>   timeout values in meson_mx_mmc_start_cmd()\n> - don't use arrays with only one element for the clock parents in\n>   meson_mx_mmc_register_clks()\n> - removed the wrapper functions meson_mx_mmc_readl() meson_mx_mmc_writel()\n> - allow setting the MMC clock to 0 for UHS speed mode (the actual\n>   hardware clock cannot be gated as far as I know, so instead the\n>   lowest supported rate is chosen)\n> - remove unused #include <linux/init.h>\n> - add MMC_CAP_ERASE\n> - removed multiple slot support after discussing this with Ulf\n>   (this is a feature that needs to be part of the MMC core before drivers\n>   can use it)\n> - removed SDIO interrupt support (as I currently don't have a way to\n>   test it)\n> - merge meson_mx_mmc_apply_ios into meson_mx_mmc_set_ios (as that's\n>   the only place where it's needed after removing multiple slot support)\n> - updated the commit message of the driver patch to indicate the\n>   difference between the meson-mx-sdio.c and meson-gx.c (and the \"still\n>   missing SDHC\") driver\n> - NOTE: I did not add Rob's ACK on the dt-bindings patch because I\n>   introduced the \"mmc-slot\" compatible for the child nodes as suggested\n>   by Ulf (and I want confirmation from the DT maintainers that I did this\n>   correctly)\n\nDidn't slot support get removed as no h/w really uses that feature?\n\nRob","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"btAkg4Yz\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2SkR134Qz9t6C\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 05:36:47 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxI8R-0000bo-Kq; Wed, 27 Sep 2017 19:36:43 +0000","from mail-pg0-f43.google.com ([74.125.83.43])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxI8N-0008D9-Vr; Wed, 27 Sep 2017 19:36:41 +0000","by mail-pg0-f43.google.com with SMTP id j16so8328608pga.1;\n\tWed, 27 Sep 2017 12:36:19 -0700 (PDT)","from localhost ([70.35.39.2]) by smtp.gmail.com with ESMTPSA id\n\te2sm17598227pfc.176.2017.09.27.12.36.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Sep 2017 12:36:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=URVjIgLIaycseEswN0b6mJrM0pPJc7tQlbm5aIz0ZZs=;\n\tb=btAkg4Yz8uF5hI\n\titettQe1SQfITDNWbI+r4LXdf3jJc4VfVtAru21dCXjfVUjJQRd+hqKCZ2ly2xwCScdXUAwteivH6\n\t9kfCzplVlEndjryJWaozGTILkm22541jmbxAI0vgjIF07GOxVpFkZ+OpBQl7ImLe07p09nHCEKlDJ\n\t2M1YTxp8rNp3gnJbgGE04AOGTIXn5B2XyICUsZemVJt8yrm2TG4jcpZ0zhRwQ7XaRbk7/CPiQRA2L\n\tbbtagemAdSUQjzNREfQ+/lZI9xQrGGek75LkcRsCEXapg2X7MkgVQTqmWW9LsnaI/NZ60NPEVXxm9\n\tacBCFyu0eo5bPlTSbqxg==;","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=OIohogJCan4BVRKfgFsOntxXM4RZGKWo8NeAKow5GLk=;\n\tb=AkpvxtL/RRhP5wv0wvErQtQzZLzIA3n27w/lqzJUwSTctVM3/2nQS7J0cTev+Cd+Py\n\tZ1CRnvVl5FpYnivWrXXWeIcX/v7qiIFHlY34FBzDrZMHqkhK0xWjpCadBDNbWxThaq3k\n\tLXoG7gqs+bn8b3SSdHO3OTqhAD1LqikW6nk7u5dh7gwHzK74FWFMZ4iXF7es+C5sBb/V\n\t/6nAIeGL+lii3iH6bQd14xLloYtTeSRR8pftCCEhTjgzf+OjFffEw1zQZ5wCrCs6zgsf\n\tTNh6Ls89bGjSdwwQmGjPy2MrDUX8dqfPPlb2dxtfpLx3dGcxibFmkbaZN/C4Nkg+EGWo\n\t6dWg==","X-Gm-Message-State":"AHPjjUjngL52Rb1RffE3NJ3aU1Wvf5z9TcyqRdLnOc3imQNHxB9Wa7zY\n\tt+57tDS0ExgZqPsuffi5NA==","X-Google-Smtp-Source":"AOwi7QDGN0mCzPK5trLU7nFyyYLIKeWrVaFsQBp6pYDMqQccevL59Oz2bAqu9uVEs6hcBWU2SKCbHg==","X-Received":"by 10.98.147.4 with SMTP id b4mr2209259pfe.347.1506540978647;\n\tWed, 27 Sep 2017 12:36:18 -0700 (PDT)","Date":"Wed, 27 Sep 2017 14:36:16 -0500","From":"Rob Herring <robh@kernel.org>","To":"Martin Blumenstingl <martin.blumenstingl@googlemail.com>","Subject":"Re: [RFC v2 0/2] Add support for Meson MX \"SDIO\" MMC controller","Message-ID":"<20170927193616.32gxszmk4cjjoqmo@rob-hp-laptop>","References":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170927_123640_155206_A27118FC ","X-CRM114-Status":"GOOD (  15.45  )","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-4.2 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (robherring2[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (robherring2[at]gmail.com)\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-2.8 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)\n\t[74.125.83.43 listed in wl.mailspike.net]\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [74.125.83.43 listed in list.dnswl.org]\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org, ulf.hansson@linaro.org,\n\tkhilman@baylibre.com, linux-mmc@vger.kernel.org, carlo@caione.org,\n\tlinux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1776569,"web_url":"http://patchwork.ozlabs.org/comment/1776569/","msgid":"<20170927193716.bxqihkm7f3omrnd6@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-27T19:37:16","subject":"Re: [RFC v2 1/2] dt-bindings: mmc: Document the Amlogic Meson8 and\n\tMeson8b SDIO bindings","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sun, Sep 24, 2017 at 09:05:27PM +0200, Martin Blumenstingl wrote:\n> From: Carlo Caione <carlo@endlessm.com>\n> \n> This documents the devicetree bindings for the SDIO/MMC host found in\n> Amlogic Meson8 and Meson8b SoCs. It supports the SD specification v2.0\n> and the eMMC specification v4.41.\n> It has an internal \"mux\" which allows connecting up to three MMC devices\n> to it. The maximum supported bus-width is 4-bits.\n> \n> Amlogic's GPL kernel sources call it \"SDIO\" to differentiate it from the\n> other MMC controller in (at least the Meson8 and Meson8b) the SoCs (they\n> call the other one \"SDHC\", which supports a bus-width of up to 8-bits).\n> \n> Signed-off-by: Carlo Caione <carlo@endlessm.com>\n> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>\n> ---\n>  .../bindings/mmc/amlogic,meson-mx-sdio.txt         | 52 ++++++++++++++++++++++\n>  1 file changed, 52 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt\n\nAcked-by: Rob Herring <robh@kernel.org>","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"JfW+M29j\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Slc4zh9z9t6C\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 28 Sep 2017 05:37:48 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxI9N-0001kk-Li; Wed, 27 Sep 2017 19:37:41 +0000","from mail-pg0-f68.google.com ([74.125.83.68])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxI9K-0001Wn-8v; Wed, 27 Sep 2017 19:37:40 +0000","by mail-pg0-f68.google.com with SMTP id m30so10181372pgn.5;\n\tWed, 27 Sep 2017 12:37:18 -0700 (PDT)","from localhost ([70.35.39.2]) by smtp.gmail.com with ESMTPSA id\n\th90sm24623401pfj.32.2017.09.27.12.37.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Sep 2017 12:37:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=LWoTvD3W4ddVnDyFwumi6R0qsFD5N+jhCsBD69pS3Qk=;\n\tb=JfW+M29jhlqJjh\n\tIs86VqJmkPMA0PpALob3frlA1UPSiitjjj1ucCdSzbRULvY1zOjqrHyWfUYxtQj1K2KJzPu/2cKpn\n\t1n1BtyQ+ivqyp2mzf/TjcPMBb5/LXvXp5yxGTNUM4IJG34zLNPZZWBz4LAf8exTyIWxJupU7QxpfX\n\tiFjIP9J2lqaFTDVAbJDGnDJse4AziVwHnjYOTsE4coW0eUd/zZRqKE4AIgZ7KyHijVapDVmQWHcRJ\n\tut96u+YBS1Cz9w+Z5qP0tyY0pO8RTJk88/WrNJdAfQMr0ihlahGkZQZ9wL2Bb96fGenSY3C0eR3Et\n\ttEmGQOXd7eNIiPDTabxQ==;","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=S+3gjpYy0XVgKB8nXcygnE9NbBDx29mrUwHu6ypxA3Q=;\n\tb=XbmlaNpu8BJ4a6bukYcnvX1cVv0mgeBgWWUeng0yJXJUQ4ZUYzWbJOh0oEOGSlPCLK\n\tosvT7mNeu+Ny6CjbF8bQCbzjo8RpjV1b95EVfQhpuFRZNYsmm2eYOuHCUDKFKc+biBxs\n\t6GovHSSqw7pWBPT8m20FXszIu4GoPhnsRAdc6BoNGXEY59WRGL3wgPJR4Mxvbn6eW4FF\n\tH1j+zKiVVxs5pS7frcJw0h4Zm1nGu3rfWx0U0SNAOHPwg1TIIk21wYMFwtnX4KyRFGqP\n\t2N3wibzGn6ZQrmSF0lZFWVwGNuqpmCMtrQ8UN+1LlFgCCNnLQKZ8EsvVZclg41R+lMW8\n\tiP9Q==","X-Gm-Message-State":"AHPjjUix25Vulbto4y1XEqwr16aqUNwpeDUPf6tl2vA2/G+i1Pa2wjht\n\tU8IacTOtAfyZJ6mGv0Gn6w==","X-Google-Smtp-Source":"AOwi7QAzW0pNgK3M/Mkb2EaPAh/lB7e3+FBIDY02qebtsB8+FTNJd/iaW603wmV52wng7x0porO0QQ==","X-Received":"by 10.84.235.137 with SMTP id p9mr2034351plk.263.1506541037660; \n\tWed, 27 Sep 2017 12:37:17 -0700 (PDT)","Date":"Wed, 27 Sep 2017 14:37:16 -0500","From":"Rob Herring <robh@kernel.org>","To":"Martin Blumenstingl <martin.blumenstingl@googlemail.com>","Subject":"Re: [RFC v2 1/2] dt-bindings: mmc: Document the Amlogic Meson8 and\n\tMeson8b SDIO bindings","Message-ID":"<20170927193716.bxqihkm7f3omrnd6@rob-hp-laptop>","References":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>\n\t<20170924190528.21841-2-martin.blumenstingl@googlemail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170924190528.21841-2-martin.blumenstingl@googlemail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170927_123738_410922_BFE5930C ","X-CRM114-Status":"GOOD (  11.21  )","X-Spam-Score":"-1.0 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [74.125.83.68 listed in list.dnswl.org]\n\t0.5 RCVD_IN_SORBS_SPAM     RBL: SORBS: sender is a spam source\n\t[74.125.83.68 listed in dnsbl.sorbs.net]\n\t-0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)\n\t[74.125.83.68 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (robherring2[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (robherring2[at]gmail.com)\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org, ulf.hansson@linaro.org,\n\tkhilman@baylibre.com, linux-mmc@vger.kernel.org,\n\tCarlo Caione <carlo@endlessm.com>, carlo@caione.org,\n\tlinux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778195,"web_url":"http://patchwork.ozlabs.org/comment/1778195/","msgid":"<CAPDyKFohh0_aONKyoc2deN+L8TCzY8tdEs5-fja3t5oVL2Gs7w@mail.gmail.com>","list_archive_url":null,"date":"2017-10-02T07:55:32","subject":"Re: [RFC v2 1/2] dt-bindings: mmc: Document the Amlogic Meson8 and\n\tMeson8b SDIO bindings","submitter":{"id":21036,"url":"http://patchwork.ozlabs.org/api/people/21036/","name":"Ulf Hansson","email":"ulf.hansson@linaro.org"},"content":"On 24 September 2017 at 21:05, Martin Blumenstingl\n<martin.blumenstingl@googlemail.com> wrote:\n> From: Carlo Caione <carlo@endlessm.com>\n>\n> This documents the devicetree bindings for the SDIO/MMC host found in\n> Amlogic Meson8 and Meson8b SoCs. It supports the SD specification v2.0\n> and the eMMC specification v4.41.\n> It has an internal \"mux\" which allows connecting up to three MMC devices\n> to it. The maximum supported bus-width is 4-bits.\n>\n> Amlogic's GPL kernel sources call it \"SDIO\" to differentiate it from the\n> other MMC controller in (at least the Meson8 and Meson8b) the SoCs (they\n> call the other one \"SDHC\", which supports a bus-width of up to 8-bits).\n>\n> Signed-off-by: Carlo Caione <carlo@endlessm.com>\n> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>\n> ---\n>  .../bindings/mmc/amlogic,meson-mx-sdio.txt         | 52 ++++++++++++++++++++++\n>  1 file changed, 52 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt\n>\n> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt\n> new file mode 100644\n> index 000000000000..124ea362eec9\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt\n> @@ -0,0 +1,52 @@\n> +* Amlogic Meson6, Meson8 and Meson8b SDIO/MMC controller\n> +\n> +The highspeed MMC host controller on Amlogic SoCs provides an interface\n> +for MMC, SD, SDIO and SDHC types of memory cards.\n> +\n> +Supported maximum speeds are the ones of the eMMC standard 4.41 as well\n> +as the speed of SD standard 2.0.\n> +\n> +The hardware provides an internal \"mux\" which allows up to three slots\n> +to be controlled. Only one slot can be accessed at a time.\n\nThis is good information, however as the driver won't support multiple\nslots, at least short term, I think we need to mention that. Otherwise\npeople may think that three slots is actually supported, while in fact\nit isn't.\n\n> +\n> +Required properties:\n> + - compatible : must be one of\n> +       - \"amlogic,meson8-sdio\"\n> +       - \"amlogic,meson8b-sdio\"\n> +       along with the generic \"amlogic,meson-mx-sdio\"\n> + - reg : mmc controller base registers\n> + - interrupts : mmc controller interrupt\n> + - #address-cells : must be 1\n> + - size-cells : must be 0\n> + - clocks : phandle to clock providers\n> + - clock-names : must contain \"core\" and \"clkin\"\n> +\n> +Required child nodes:\n> +A node for each slot provided by the MMC controller is required.\n> +\n> +Required properties on each child node (= slot):\n> + - compatible : must be \"mmc-slot\" (see mmc.txt within this directory)\n> + - reg : the slot (or \"port\") ID\n> +\n> +Optional properties on each child node (= slot):\n> + - bus-width : must be 1 or 4 (8-bit bus is not supported)\n> + - for cd and all other additional generic mmc parameters\n> +   please refer to mmc.txt within this directory\n> +\n> +Examples:\n> +       mmc@c1108c20 {\n> +               compatible = \"amlogic,meson8-sdio\", \"amlogic,meson-mx-sdio\";\n> +               reg = <0xc1108c20 0x20>;\n> +               interrupts = <0 28 1>;\n> +               #address-cells = <1>;\n> +               #size-cells = <0>;\n> +               clocks = <&clkc CLKID_SDIO>, <&clkc CLKID_CLK81>;\n> +               clock-names = \"core\", \"clkin\";\n> +\n> +               slot@1 {\n> +                       compatible = \"mmc-slot\";\n> +                       reg = <1>;\n> +\n> +                       bus-width = <4>;\n> +               };\n> +       };\n> --\n> 2.14.1\n>\n\nKind regards\nUffe","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"G+yjKUOf\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Xl+6dQZl\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5Dxb3MVKz9t2V\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tMon,  2 Oct 2017 18:56:03 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dyva3-0000Q6-QI; Mon, 02 Oct 2017 07:55:59 +0000","from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dyvZz-0000EF-4G for linux-arm-kernel@lists.infradead.org;\n\tMon, 02 Oct 2017 07:55:57 +0000","by mail-io0-x231.google.com with SMTP id e189so4095627ioa.4\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tMon, 02 Oct 2017 00:55:33 -0700 (PDT)","by 10.2.65.137 with HTTP; Mon, 2 Oct 2017 00:55:32 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=+piLZOlmtmaxzVjgmaBwt8dLapMUQJMIjZhmENDq2hI=;\n\tb=G+yjKUOfV71Puh\n\t9dRQCyO01bIVzuq//Uu/6hmXrbsBFAJs7z8pdTniw3CtT3Y0vrHXVyJp54DnKrxyHUTSzYBoEwGGH\n\tyYF8oqznxykswT1nK7lp0t/Rm02Ou3OvRCkqqu+Imej8E+Z5kpJrMyxv42eJlyXYn6s7xYwp7+6pt\n\t7XXuCpbCAz2AtoxPufcrn5waCBm5T1SKiPOw9w9bGbvQsbGmMoNjGJC/Spf7FQzn6GCk5IkU86ZzF\n\tJSA7+dct50KglSOLlnaO7mhiXVSG8tpBPlhmwP9qFZ0BYx30GcxwvkY0oUtHaFM+CqY0KWpFsN6qA\n\tT1B+CZO24R12DANtXOsA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=oKt/hpLsW7jC92W+ILT8FK3+qvSYf94RI90j05qQ7wY=;\n\tb=Xl+6dQZlFjf29sjYE/VbhQGLVbfhQN1EOk+KQUOY4prrt81EgTNNlcwy5xyzUfbKT+\n\t9o5ZHfmPVmQcBolHr2Pc4nK3daQ3wdxgugOWjPKdOKXQsXrW6grEK/Xhiv32KpD/cupc\n\te4m12sthFbUBBzdhvjo7NHLpdKpxxjG/l8kXc="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=oKt/hpLsW7jC92W+ILT8FK3+qvSYf94RI90j05qQ7wY=;\n\tb=XqBA8LmccgKA4byU03/2z3tYb4JVaESX3PYQjRO0sG2YIHk6jKBQVfwdQqnDDI0D5w\n\tiHKs5yG5IqSJTFXBSiH44JsY6+Ahvbs9kGFZ1U+2PfDGNnkxHmuvSKQPgwT2IrHtbEHn\n\tutuJMy+ifSFK4lr5roHWh7cu3jTmnms5lR9ep4s2tik0sSbmis9eo7+Fmcjzypy9SuQI\n\tD4reLfvCO2m+vbgMGYbVsQrGKVyZw5N3gMr3qltoUzOGMgijDdpdWy2mzV6y9Sm+nVAm\n\tCnYAFLNldnFBq3E1hV3VobCD22XStuy20eabQyhAONfqBCF7zhpFns2rshNl/8qD/OLF\n\tPxHw==","X-Gm-Message-State":"AMCzsaWfI5jUJyyr87LzmnyRiojMP6jQqaw03ChNzaCTIpRabMIAMZQe\n\tW13d2bMlMKm3XzVRBodqIzwel0SashuoooENXksHJg==","X-Google-Smtp-Source":"AOwi7QDOd5iCDhc2IHN5tl2m5aTfJc89FQ9k11I8LPYeRqSYa01YoMibh7A85NoFH0/0v/zCIhK9hUyTSR0CdYCOcCo=","X-Received":"by 10.107.19.139 with SMTP id 11mr22884073iot.286.1506930933011; \n\tMon, 02 Oct 2017 00:55:33 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170924190528.21841-2-martin.blumenstingl@googlemail.com>","References":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>\n\t<20170924190528.21841-2-martin.blumenstingl@googlemail.com>","From":"Ulf Hansson <ulf.hansson@linaro.org>","Date":"Mon, 2 Oct 2017 09:55:32 +0200","Message-ID":"<CAPDyKFohh0_aONKyoc2deN+L8TCzY8tdEs5-fja3t5oVL2Gs7w@mail.gmail.com>","Subject":"Re: [RFC v2 1/2] dt-bindings: mmc: Document the Amlogic Meson8 and\n\tMeson8b SDIO bindings","To":"Martin Blumenstingl <martin.blumenstingl@googlemail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171002_005555_250483_71007973 ","X-CRM114-Status":"GOOD (  21.11  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tKevin Hilman <khilman@baylibre.com>,\n\t\"linux-mmc@vger.kernel.org\" <linux-mmc@vger.kernel.org>,\n\tRob Herring <robh+dt@kernel.org>, Carlo Caione <carlo@endlessm.com>, \n\tCarlo Caione <carlo@caione.org>,\n\t\"open list:ARM/Amlogic Meson...\" <linux-amlogic@lists.infradead.org>, \n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778197,"web_url":"http://patchwork.ozlabs.org/comment/1778197/","msgid":"<CAPDyKFqj1CkhHO4SvUySEV4OnKcTeHRu6YAfBPSN4hvkQpHKfA@mail.gmail.com>","list_archive_url":null,"date":"2017-10-02T08:08:09","subject":"Re: [RFC v2 2/2] mmc: meson-mx-sdio: Add a driver for the Amlogic\n\tMeson8 and Meson8b SoCs","submitter":{"id":21036,"url":"http://patchwork.ozlabs.org/api/people/21036/","name":"Ulf Hansson","email":"ulf.hansson@linaro.org"},"content":"[...]\n\n> +#define MESON_MX_SDIO_MAX_SLOTS                                        3\n> +\n> +struct meson_mx_mmc_slot {\n> +       struct device                   *dev;\n> +       struct mmc_host                 *mmc;\n> +       struct meson_mx_mmc_host        *host;\n> +\n> +       struct mmc_request              *mrq;\n> +       struct mmc_command              *cmd;\n> +       int                             error;\n> +\n> +       unsigned int                    id;\n> +};\n\nIf I recall correctly, we agreed on postponing the multiple slot\nsupport for now as to start simple.\nTherefore, can you please remove all that code, and instead only use\nthe struct meson_mx_mmc_host for the data needed.\n\nJust to be clear, I am fine having using the mmc slot bindings, as we\nagreed. However as only one slot is supported in this stage, we don't\nneed a separate struct for that.\n\n> +\n> +struct meson_mx_mmc_host {\n> +       struct device                   *dev;\n> +\n> +       struct clk                      *parent_clk;\n> +       struct clk                      *core_clk;\n> +       struct clk_divider              cfg_div;\n> +       struct clk                      *cfg_div_clk;\n> +       struct clk_fixed_factor         fixed_factor;\n> +       struct clk                      *fixed_factor_clk;\n> +\n> +       void __iomem                    *base;\n> +       int                             irq;\n> +       spinlock_t                      irq_lock;\n> +\n> +       struct timer_list               cmd_timeout;\n> +\n> +       struct meson_mx_mmc_slot        *slot;\n> +};\n> +\n\n[...]\n\n> +static int meson_mx_mmc_slot_probe(struct device *slot_dev,\n> +                                  struct meson_mx_mmc_host *host)\n> +{\n> +       struct meson_mx_mmc_slot *slot;\n> +       struct mmc_host *mmc;\n> +       unsigned int id;\n> +       int ret;\n> +\n> +       if (of_property_read_u32(slot_dev->of_node, \"reg\", &id)) {\n> +               dev_err(slot_dev, \"missing 'reg' property\\n\");\n> +               return -EINVAL;\n> +       }\n> +\n> +       if (id >= MESON_MX_SDIO_MAX_SLOTS) {\n> +               dev_err(slot_dev, \"invalid 'reg' property value %d\\n\", id);\n> +               return -EINVAL;\n> +       }\n> +\n> +       mmc = mmc_alloc_host(sizeof(*slot), slot_dev);\n> +       if (!mmc)\n> +               return -ENOMEM;\n> +\n> +       slot = mmc_priv(mmc);\n> +       slot->dev = slot_dev;\n> +       slot->mmc = mmc;\n> +       slot->id = id;\n> +       slot->host = host;\n> +\n> +       host->slot = slot;\n> +\n> +       /* Get regulators and the supported OCR mask */\n> +       ret = mmc_regulator_get_supply(mmc);\n> +       if (ret == -EPROBE_DEFER)\n> +               goto error_free_host;\n> +\n> +       mmc->max_req_size = MESON_MX_SDIO_BOUNCE_REQ_SIZE;\n> +       mmc->max_seg_size = mmc->max_req_size;\n> +       mmc->max_blk_count =\n> +               FIELD_GET(MESON_MX_SDIO_SEND_REPEAT_PACKAGE_TIMES_MASK,\n> +                         0xffffffff);\n> +       mmc->max_blk_size = FIELD_GET(MESON_MX_SDIO_EXT_DATA_RW_NUMBER_MASK,\n> +                                     0xffffffff);\n> +       mmc->max_blk_size -= (4 * MESON_MX_SDIO_RESPONSE_CRC16_BITS);\n> +       mmc->max_blk_size /= BITS_PER_BYTE;\n> +\n> +       /* Get the min and max supported clock rates */\n> +       mmc->f_min = clk_round_rate(host->cfg_div_clk, 1);\n> +       mmc->f_max = clk_round_rate(host->cfg_div_clk,\n> +                                   clk_get_rate(host->parent_clk));\n> +\n> +       mmc->caps |= MMC_CAP_ERASE | MMC_CAP_CMD23;\n> +       mmc->ops = &meson_mx_mmc_ops;\n> +\n> +       ret = mmc_of_parse(mmc);\n> +       if (ret)\n> +               goto error_free_host;\n> +\n> +       ret = mmc_add_host(mmc);\n> +       if (ret)\n> +               goto error_free_host;\n> +\n> +       return 0;\n> +\n> +error_free_host:\n> +       mmc_free_host(mmc);\n> +       return ret;\n> +}\n> +\n> +static int meson_mx_mmc_probe_slots(struct meson_mx_mmc_host *host)\n> +{\n> +       struct device_node *slot_node;\n> +       struct platform_device *slot_pdev;\n> +       int ret;\n> +\n> +       for_each_child_of_node(host->dev->of_node, slot_node) {\n> +               if (!of_device_is_compatible(slot_node, \"mmc-slot\"))\n> +                       continue;\n> +\n> +               /*\n> +                * TODO: the MMC core framework currently does not support\n> +                * controllers with multiple slots properly.\n> +                */\n> +               if (host->slot) {\n> +                       dev_warn(host->dev,\n> +                                \"skipping slot other than the first\\n\");\n> +                       continue;\n> +               }\n> +\n> +               slot_pdev = of_platform_device_create(slot_node, NULL,\n> +                                                     host->dev);\n> +               if (!slot_pdev)\n> +                       continue;\n> +\n> +               ret = meson_mx_mmc_slot_probe(&slot_pdev->dev, host);\n> +               if (ret) {\n> +                       of_platform_device_destroy(&slot_pdev->dev, NULL);\n> +                       return ret;\n> +               }\n> +       }\n> +\n> +       return 0;\n> +}\n\nFor the above two functions, please simplify the code by limiting them\nto deal with only one valid mmc-slot.\n\n[...]\n\nBesides the comments on the multiple slot support, this looks good to me.\n\nKind regards\nUffe","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"k8xU3XMY\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"GYLkDQMO\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5FDB42pNz9t42\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tMon,  2 Oct 2017 19:08:42 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dyvmI-0005sd-C5; Mon, 02 Oct 2017 08:08:38 +0000","from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dyvmC-0005ns-4R for linux-arm-kernel@lists.infradead.org;\n\tMon, 02 Oct 2017 08:08:34 +0000","by mail-it0-x230.google.com with SMTP id g18so6368895itg.5\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tMon, 02 Oct 2017 01:08:10 -0700 (PDT)","by 10.2.65.137 with HTTP; Mon, 2 Oct 2017 01:08:09 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=oabbbcJ6NYWiKTeGJtL4pkMvK2QhiDtZApn8bOHnnjI=;\n\tb=k8xU3XMY+5NSc9\n\tGY151Gw2ftgKdp9LhXqXRCpi8pmsu2wk+5l0pu0ZPEueTVnY/ayqpeu0eIamBTUdgwwfUfyCyVTRf\n\tg5fIeVkzjPsChAr/ofjJV2mTSjLzpBDCe9COiF0hM6NLn6QffBS+CPmXEETLXj7OkZtBWHcXqcYt4\n\tAzmijvcg7p3z8Fli5NzCU+DAhY721Xno3LOEvEs2nhsbuJfPu+3U8zMUofVSu3lMcStBNk5S5Xxcj\n\t2d8c1DiO0CFWnn8ezevPyhLJX1mItKjvojVC73ZqJzLFU/USwVU+UoUSTxWeD0v+/eecrXcG+RsGT\n\toXsnht6z6/wkJ3jpeFQg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=73JuqEshfID44QQIDPlsx6Qc41wPPPFo810SkPX6whY=;\n\tb=GYLkDQMO9ABaMURaDVgESj5+2Edqo9YG0kJ2u7SLc5L1UjbQcIZ/xIkR28DzGk3O90\n\tiX5wQ0Ou4hTgkHyI6Al2UxTS0KPZjeVDKgLmKX66NMlQmUs5tn/ObrAG6G9Hi0DWOsmF\n\tOG5WLJ4dkcTwHYAWetcWiq/tXhEQvTVQowbRs="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=73JuqEshfID44QQIDPlsx6Qc41wPPPFo810SkPX6whY=;\n\tb=d9FHVHj8q0a+xu4FHs5D7vyiWZbyIPCsb9eIqvQucFxeQMyw/sWL/vw7rSbN7+Eb7V\n\tR4yUwxkYJN/H83h2ZUae265WuzbizF7YtbbrfYGBv1/kqwdyLs2ghF1mD/yZm7KVY2/f\n\tWl3Ku5aRt4YJLVd9Jo+2S0n4KGamAJkTCNymGVyoHVeYQFyh8f6xh1S1A3l2i89QIEXV\n\t2ZIuJB5BYoDTF9vSC7QfSAkwK0KC7jgmJrNdkHip50F7zP0VZGwrhow6/Jae9j+bcDHZ\n\tn6deNGDw05vNMbFuXI/sMsFeSzDH3zg5gptvefN8EUh/3xPEzCIGUb6xelcnoGGSm46e\n\tomag==","X-Gm-Message-State":"AHPjjUg7Wr34Mv+qBjc3MqBXETbmqTW7RPcpRG31ySPLFHirAyG6WQNc\n\tje3w0eNtpHCVbisPk7qNID6N8FEaJbz2Ro6chKVJPw==","X-Google-Smtp-Source":"AOwi7QAzuHdgAHmigoYS8v9KuyABjmCWOW3LR02h/rrzRxB5ldB90sClnAxdDgSzUXrXSKnuq/cK80v4iIOETTWRS7o=","X-Received":"by 10.36.26.87 with SMTP id 84mr18436344iti.38.1506931689600;\n\tMon, 02 Oct 2017 01:08:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170924190528.21841-3-martin.blumenstingl@googlemail.com>","References":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>\n\t<20170924190528.21841-3-martin.blumenstingl@googlemail.com>","From":"Ulf Hansson <ulf.hansson@linaro.org>","Date":"Mon, 2 Oct 2017 10:08:09 +0200","Message-ID":"<CAPDyKFqj1CkhHO4SvUySEV4OnKcTeHRu6YAfBPSN4hvkQpHKfA@mail.gmail.com>","Subject":"Re: [RFC v2 2/2] mmc: meson-mx-sdio: Add a driver for the Amlogic\n\tMeson8 and Meson8b SoCs","To":"Martin Blumenstingl <martin.blumenstingl@googlemail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171002_010832_229216_3CEDC00D ","X-CRM114-Status":"GOOD (  17.06  )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.7 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:4001:c0b:0:0:0:230 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tKevin Hilman <khilman@baylibre.com>,\n\t\"linux-mmc@vger.kernel.org\" <linux-mmc@vger.kernel.org>,\n\tRob Herring <robh+dt@kernel.org>, Carlo Caione <carlo@endlessm.com>, \n\tCarlo Caione <carlo@caione.org>,\n\t\"open list:ARM/Amlogic Meson...\" <linux-amlogic@lists.infradead.org>, \n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778519,"web_url":"http://patchwork.ozlabs.org/comment/1778519/","msgid":"<CAFBinCCW5r=DFLyBgSrQzDkqHr6uN7Opvi6Tdmb8k+ikw+qnPA@mail.gmail.com>","list_archive_url":null,"date":"2017-10-02T18:45:39","subject":"Re: [RFC v2 2/2] mmc: meson-mx-sdio: Add a driver for the Amlogic\n\tMeson8 and Meson8b SoCs","submitter":{"id":66366,"url":"http://patchwork.ozlabs.org/api/people/66366/","name":"Martin Blumenstingl","email":"martin.blumenstingl@googlemail.com"},"content":"Hi Ulf,\n\nOn Mon, Oct 2, 2017 at 10:08 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:\n> [...]\n>\n>> +#define MESON_MX_SDIO_MAX_SLOTS                                        3\n>> +\n>> +struct meson_mx_mmc_slot {\n>> +       struct device                   *dev;\n>> +       struct mmc_host                 *mmc;\n>> +       struct meson_mx_mmc_host        *host;\n>> +\n>> +       struct mmc_request              *mrq;\n>> +       struct mmc_command              *cmd;\n>> +       int                             error;\n>> +\n>> +       unsigned int                    id;\n>> +};\n>\n> If I recall correctly, we agreed on postponing the multiple slot\n> support for now as to start simple.\nyes, indeed\n\n> Therefore, can you please remove all that code, and instead only use\n> the struct meson_mx_mmc_host for the data needed.\nI initially wanted to keep these structs separated to make it easier\nto spot which part of the logic might have to be changed to support\nmultiple slots\nlooking back at it: currently meson_mx_mmc_slot only contains very\ngeneric stuff, so it'll (hopefully) be easy to spot the relevant parts\nanyways\nI'll remove it, which will even fix a warning found by the \"kbuild\ntest robot\" (where I didn't initialize but use the \"slot\" variable in\nmeson_mx_mmc_timeout)\n\n> Just to be clear, I am fine having using the mmc slot bindings, as we\n> agreed. However as only one slot is supported in this stage, we don't\n> need a separate struct for that.\nACK\n\n>> +\n>> +struct meson_mx_mmc_host {\n>> +       struct device                   *dev;\n>> +\n>> +       struct clk                      *parent_clk;\n>> +       struct clk                      *core_clk;\n>> +       struct clk_divider              cfg_div;\n>> +       struct clk                      *cfg_div_clk;\n>> +       struct clk_fixed_factor         fixed_factor;\n>> +       struct clk                      *fixed_factor_clk;\n>> +\n>> +       void __iomem                    *base;\n>> +       int                             irq;\n>> +       spinlock_t                      irq_lock;\n>> +\n>> +       struct timer_list               cmd_timeout;\n>> +\n>> +       struct meson_mx_mmc_slot        *slot;\n>> +};\n>> +\n>\n> [...]\n>\n>> +static int meson_mx_mmc_slot_probe(struct device *slot_dev,\n>> +                                  struct meson_mx_mmc_host *host)\n>> +{\n>> +       struct meson_mx_mmc_slot *slot;\n>> +       struct mmc_host *mmc;\n>> +       unsigned int id;\n>> +       int ret;\n>> +\n>> +       if (of_property_read_u32(slot_dev->of_node, \"reg\", &id)) {\n>> +               dev_err(slot_dev, \"missing 'reg' property\\n\");\n>> +               return -EINVAL;\n>> +       }\n>> +\n>> +       if (id >= MESON_MX_SDIO_MAX_SLOTS) {\n>> +               dev_err(slot_dev, \"invalid 'reg' property value %d\\n\", id);\n>> +               return -EINVAL;\n>> +       }\n>> +\n>> +       mmc = mmc_alloc_host(sizeof(*slot), slot_dev);\n>> +       if (!mmc)\n>> +               return -ENOMEM;\n>> +\n>> +       slot = mmc_priv(mmc);\n>> +       slot->dev = slot_dev;\n>> +       slot->mmc = mmc;\n>> +       slot->id = id;\n>> +       slot->host = host;\n>> +\n>> +       host->slot = slot;\n>> +\n>> +       /* Get regulators and the supported OCR mask */\n>> +       ret = mmc_regulator_get_supply(mmc);\n>> +       if (ret == -EPROBE_DEFER)\n>> +               goto error_free_host;\n>> +\n>> +       mmc->max_req_size = MESON_MX_SDIO_BOUNCE_REQ_SIZE;\n>> +       mmc->max_seg_size = mmc->max_req_size;\n>> +       mmc->max_blk_count =\n>> +               FIELD_GET(MESON_MX_SDIO_SEND_REPEAT_PACKAGE_TIMES_MASK,\n>> +                         0xffffffff);\n>> +       mmc->max_blk_size = FIELD_GET(MESON_MX_SDIO_EXT_DATA_RW_NUMBER_MASK,\n>> +                                     0xffffffff);\n>> +       mmc->max_blk_size -= (4 * MESON_MX_SDIO_RESPONSE_CRC16_BITS);\n>> +       mmc->max_blk_size /= BITS_PER_BYTE;\n>> +\n>> +       /* Get the min and max supported clock rates */\n>> +       mmc->f_min = clk_round_rate(host->cfg_div_clk, 1);\n>> +       mmc->f_max = clk_round_rate(host->cfg_div_clk,\n>> +                                   clk_get_rate(host->parent_clk));\n>> +\n>> +       mmc->caps |= MMC_CAP_ERASE | MMC_CAP_CMD23;\n>> +       mmc->ops = &meson_mx_mmc_ops;\n>> +\n>> +       ret = mmc_of_parse(mmc);\n>> +       if (ret)\n>> +               goto error_free_host;\n>> +\n>> +       ret = mmc_add_host(mmc);\n>> +       if (ret)\n>> +               goto error_free_host;\n>> +\n>> +       return 0;\n>> +\n>> +error_free_host:\n>> +       mmc_free_host(mmc);\n>> +       return ret;\n>> +}\n>> +\n>> +static int meson_mx_mmc_probe_slots(struct meson_mx_mmc_host *host)\n>> +{\n>> +       struct device_node *slot_node;\n>> +       struct platform_device *slot_pdev;\n>> +       int ret;\n>> +\n>> +       for_each_child_of_node(host->dev->of_node, slot_node) {\n>> +               if (!of_device_is_compatible(slot_node, \"mmc-slot\"))\n>> +                       continue;\n>> +\n>> +               /*\n>> +                * TODO: the MMC core framework currently does not support\n>> +                * controllers with multiple slots properly.\n>> +                */\n>> +               if (host->slot) {\n>> +                       dev_warn(host->dev,\n>> +                                \"skipping slot other than the first\\n\");\n>> +                       continue;\n>> +               }\n>> +\n>> +               slot_pdev = of_platform_device_create(slot_node, NULL,\n>> +                                                     host->dev);\n>> +               if (!slot_pdev)\n>> +                       continue;\n>> +\n>> +               ret = meson_mx_mmc_slot_probe(&slot_pdev->dev, host);\n>> +               if (ret) {\n>> +                       of_platform_device_destroy(&slot_pdev->dev, NULL);\n>> +                       return ret;\n>> +               }\n>> +       }\n>> +\n>> +       return 0;\n>> +}\n>\n> For the above two functions, please simplify the code by limiting them\n> to deal with only one valid mmc-slot.\nOK, I'll do that - however I'll leave that TODO comment in the code so\npeople know that this is on purpose\n\n> [...]\n>\n> Besides the comments on the multiple slot support, this looks good to me.\nawesome, thanks for reviewing!\nI'll send an updated version as soon as I have time\n\n\nRegards,\nMartin","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"UTV0RApl\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"OE+O+Hb5\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5WN40nZ5z9t6B\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tTue,  3 Oct 2017 05:46:28 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz5jU-00080l-PY; Mon, 02 Oct 2017 18:46:24 +0000","from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz5jQ-0007y6-Uv; Mon, 02 Oct 2017 18:46:22 +0000","by mail-io0-x242.google.com with SMTP id j26so3575689iod.0;\n\tMon, 02 Oct 2017 11:46:00 -0700 (PDT)","by 10.2.51.84 with HTTP; Mon, 2 Oct 2017 11:45:39 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Tj3QHfm54+tMxHwRDTNbzw8erg6q0mU+EmK1oHZ8Xc4=;\n\tb=UTV0RApleO/iRw\n\t62nQQTiBt56+0YmfHpuDZS8aCoBXSlZXKmuDU7JpuAPbPAHMmfA1zVqYpY/QOA7RRPV3n6nqw1J1a\n\tLeUg7pkDReolXctcLbjicHx7NBlNdp6IPAzlWI3nFdMgm9tHButWsEffJzlO2q+D+VEqCXinSBXNd\n\ttpReVUV68zoBJ8zvM6K5F3aEBp9/3u+FKR9iIZ+WvM46JmDOruToxHRikre3WfDhGBH2t+LSKpmSM\n\tbVFCT6NfeejO1jW1JEOJOI+bBdgoszkcvlh0AjJPjpvuGtE3g9yBeQth1qcNHs7jvafaPqhfxo2yN\n\tMM/Wz7vLCmTpbsFWGZtw==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Dzg2oeh5UARctE5AE5skqMaXDPiYwOsZxR6AFdDzfH8=;\n\tb=OE+O+Hb5KwSL85KdN5oTEKRtpS3vCpYbrmoLv1/jRCFuDKYvwp5ye/bErgxxdo8JYR\n\ttWI7tJdQ1FXNhzdsahOKAlIdZj2dOCh1qtlvMid+8LMmJpWEzDQTelxvpTXsDQ+n09C9\n\t+/8jczM4JlYICv31SSxH7zL/ZfSwGfqaO2FRvSsJwScuYXW0qbetBiDTXeT4Ohtw1TuP\n\t03iKztvHbUMb3VzIMqwq6mxfnYe9BW0bzoWWTmgqKHIwdWw4jtZKCXB7r3G27xHmO1en\n\tca/8J8g+vJ9NXRqizwvogJKAPEP+ZhQGBM1+xdKuY2NC4bVVvYMpZ7YHga0nc8n4MDda\n\t9OcQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Dzg2oeh5UARctE5AE5skqMaXDPiYwOsZxR6AFdDzfH8=;\n\tb=r77kCHAYOYEOvq6s8ATo//XdGHoV1BY+bIi/HHQCC/K+/syh2sy2Tk42EvTeWz2H+z\n\ttyV8NkL2fmnqyBGO2LrndP/1TJrXNp71ElFesRaGlaQO2T1g7EPJnMvXCfwmSiZ0h2F/\n\tfizbjGd8lI53csqxUhqbgmHbzYlWzKCR1XEAfjJAwh1OJU8pXO96ciYQ1/lgfV26+v+c\n\tC1zg4OzMdMxXA1j25RtYe3D6ihJTqrEVA1hbfNu54doHcoHDOTze5/fWE4VIxtUr0mM3\n\tA8EsreePE9jCBnZ5bV60T5sVJDxGBj3J7BXMgcbs5/x/GsZd/8F/qkLb5SBSQ7oksGiJ\n\th/ow==","X-Gm-Message-State":"AMCzsaVxWqfTJoAujk0+lnQ7XJ+W5BYY2U137bDkirIOsYcM48bbx26R\n\tzTIfsbTuMErU2cDHJJhO6+8iqCzyELG+ZmUgvm8=","X-Google-Smtp-Source":"AOwi7QBIT9uP6T/e0uoKx2NLpleK+OFaTygEcwLFyZjqMUU0uvVQjjDhWIEhbihzVYDb3fYKY8s7D9XA/LxEHyogxI8=","X-Received":"by 10.107.81.1 with SMTP id f1mr25418277iob.17.1506969959975;\n\tMon, 02 Oct 2017 11:45:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAPDyKFqj1CkhHO4SvUySEV4OnKcTeHRu6YAfBPSN4hvkQpHKfA@mail.gmail.com>","References":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>\n\t<20170924190528.21841-3-martin.blumenstingl@googlemail.com>\n\t<CAPDyKFqj1CkhHO4SvUySEV4OnKcTeHRu6YAfBPSN4hvkQpHKfA@mail.gmail.com>","From":"Martin Blumenstingl <martin.blumenstingl@googlemail.com>","Date":"Mon, 2 Oct 2017 20:45:39 +0200","Message-ID":"<CAFBinCCW5r=DFLyBgSrQzDkqHr6uN7Opvi6Tdmb8k+ikw+qnPA@mail.gmail.com>","Subject":"Re: [RFC v2 2/2] mmc: meson-mx-sdio: Add a driver for the Amlogic\n\tMeson8 and Meson8b SoCs","To":"Ulf Hansson <ulf.hansson@linaro.org>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171002_114621_043905_37A7236A ","X-CRM114-Status":"GOOD (  19.31  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:4001:c06:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (martin.blumenstingl[at]googlemail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tKevin Hilman <khilman@baylibre.com>,\n\t\"linux-mmc@vger.kernel.org\" <linux-mmc@vger.kernel.org>,\n\tRob Herring <robh+dt@kernel.org>, Carlo Caione <carlo@endlessm.com>, \n\tCarlo Caione <carlo@caione.org>,\n\t\"open list:ARM/Amlogic Meson...\" <linux-amlogic@lists.infradead.org>, \n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778521,"web_url":"http://patchwork.ozlabs.org/comment/1778521/","msgid":"<CAFBinCA6HfKTNSLczx=V3dtfsrUSMKJw-nLAp6s9m55dJ9nQxA@mail.gmail.com>","list_archive_url":null,"date":"2017-10-02T18:47:48","subject":"Re: [RFC v2 1/2] dt-bindings: mmc: Document the Amlogic Meson8 and\n\tMeson8b SDIO bindings","submitter":{"id":66366,"url":"http://patchwork.ozlabs.org/api/people/66366/","name":"Martin Blumenstingl","email":"martin.blumenstingl@googlemail.com"},"content":"On Mon, Oct 2, 2017 at 9:55 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:\n> On 24 September 2017 at 21:05, Martin Blumenstingl\n> <martin.blumenstingl@googlemail.com> wrote:\n>> From: Carlo Caione <carlo@endlessm.com>\n>>\n>> This documents the devicetree bindings for the SDIO/MMC host found in\n>> Amlogic Meson8 and Meson8b SoCs. It supports the SD specification v2.0\n>> and the eMMC specification v4.41.\n>> It has an internal \"mux\" which allows connecting up to three MMC devices\n>> to it. The maximum supported bus-width is 4-bits.\n>>\n>> Amlogic's GPL kernel sources call it \"SDIO\" to differentiate it from the\n>> other MMC controller in (at least the Meson8 and Meson8b) the SoCs (they\n>> call the other one \"SDHC\", which supports a bus-width of up to 8-bits).\n>>\n>> Signed-off-by: Carlo Caione <carlo@endlessm.com>\n>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>\n>> ---\n>>  .../bindings/mmc/amlogic,meson-mx-sdio.txt         | 52 ++++++++++++++++++++++\n>>  1 file changed, 52 insertions(+)\n>>  create mode 100644 Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt\n>>\n>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt\n>> new file mode 100644\n>> index 000000000000..124ea362eec9\n>> --- /dev/null\n>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdio.txt\n>> @@ -0,0 +1,52 @@\n>> +* Amlogic Meson6, Meson8 and Meson8b SDIO/MMC controller\n>> +\n>> +The highspeed MMC host controller on Amlogic SoCs provides an interface\n>> +for MMC, SD, SDIO and SDHC types of memory cards.\n>> +\n>> +Supported maximum speeds are the ones of the eMMC standard 4.41 as well\n>> +as the speed of SD standard 2.0.\n>> +\n>> +The hardware provides an internal \"mux\" which allows up to three slots\n>> +to be controlled. Only one slot can be accessed at a time.\n>\n> This is good information, however as the driver won't support multiple\n> slots, at least short term, I think we need to mention that. Otherwise\n> people may think that three slots is actually supported, while in fact\n> it isn't.\nOK, I'll add a note when I re-spin this series\n\n>> +\n>> +Required properties:\n>> + - compatible : must be one of\n>> +       - \"amlogic,meson8-sdio\"\n>> +       - \"amlogic,meson8b-sdio\"\n>> +       along with the generic \"amlogic,meson-mx-sdio\"\n>> + - reg : mmc controller base registers\n>> + - interrupts : mmc controller interrupt\n>> + - #address-cells : must be 1\n>> + - size-cells : must be 0\n>> + - clocks : phandle to clock providers\n>> + - clock-names : must contain \"core\" and \"clkin\"\n>> +\n>> +Required child nodes:\n>> +A node for each slot provided by the MMC controller is required.\n>> +\n>> +Required properties on each child node (= slot):\n>> + - compatible : must be \"mmc-slot\" (see mmc.txt within this directory)\n>> + - reg : the slot (or \"port\") ID\n>> +\n>> +Optional properties on each child node (= slot):\n>> + - bus-width : must be 1 or 4 (8-bit bus is not supported)\n>> + - for cd and all other additional generic mmc parameters\n>> +   please refer to mmc.txt within this directory\n>> +\n>> +Examples:\n>> +       mmc@c1108c20 {\n>> +               compatible = \"amlogic,meson8-sdio\", \"amlogic,meson-mx-sdio\";\n>> +               reg = <0xc1108c20 0x20>;\n>> +               interrupts = <0 28 1>;\n>> +               #address-cells = <1>;\n>> +               #size-cells = <0>;\n>> +               clocks = <&clkc CLKID_SDIO>, <&clkc CLKID_CLK81>;\n>> +               clock-names = \"core\", \"clkin\";\n>> +\n>> +               slot@1 {\n>> +                       compatible = \"mmc-slot\";\n>> +                       reg = <1>;\n>> +\n>> +                       bus-width = <4>;\n>> +               };\n>> +       };\n>> --\n>> 2.14.1\n>>\n>\n> Kind regards\n> Uffe\n\n\nRegards,\nMartin","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"PSDkNaKk\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"iCpRmoKU\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5WQX5ykkz9t64\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tTue,  3 Oct 2017 05:48:36 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz5lZ-0008To-PD; Mon, 02 Oct 2017 18:48:33 +0000","from mail-it0-x241.google.com ([2607:f8b0:4001:c0b::241])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz5lW-0008SB-1U; Mon, 02 Oct 2017 18:48:31 +0000","by mail-it0-x241.google.com with SMTP id c195so8518759itb.1;\n\tMon, 02 Oct 2017 11:48:09 -0700 (PDT)","by 10.2.51.84 with HTTP; Mon, 2 Oct 2017 11:47:48 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=EH9Ao99nqpFnLWGU5FwDf/NR6u5KIUx+09lPzETvjSs=;\n\tb=PSDkNaKknRI7mN\n\tVxRBSkNp9AjnBztLhTgwQmcoWnFKf7dRsXt5EncFLyCOUHoNoCDj2J1M4NiaRSNrDD67kcaJA95Gq\n\tyQ0M8wlQ3Y+o+df32BZPBpybPKq0HhRw+EEMSbnsRmXowbML9eSHDMUk/zl1FzMpiuBjlWoPn4VPx\n\tlnRensctk6SIe2k1vQWzZHQgIQRM2qViz8dBFiBDkamAD87VEb5h9tboA8Yn20d5KVWUV8AYPCpmv\n\tIq+AuKnW70zZlKXQ1zFbfz1Y0qhNAkWh/KinWlgb0z0o8xDpLchPsAQZfpABjYxQDc7peULVkw2RI\n\tMn7X1Z1+qsd9u6gwscVw==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=O0mETxwaBW+SFJYOo6T0YqYQVuFejhtDXkhZg09o1dM=;\n\tb=iCpRmoKUr4KT6DkBIcmuz1qECbI5ljlVcCaftanvIdY1BptMcw51+8gh2Y0y6WFCQg\n\tOrPUZeYQtjx29VHhlBKkTNmQwFkfAlG9dE9S90h285r3m9IgagmJaAcob/FjEfAgfC84\n\tlP+PnmvmfR1rAF476JfuIKWOHDnjXAahVuzakBrWO7lgKq/PcH3GnNWs/7BVowQzpfT5\n\t/9zbcIpX7mWGtyjyqQsUixzeT4tcC1cvVh0IslJEEZdal2NFeMJD4tB9WpRwlt5+8q+V\n\te7/PB6GhOQ5uCBal1K9FhJeJtnT3D8Y59g/vQ/WtMSzJb+teH2B6kQc1xApljWezknMM\n\tK1ew=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=O0mETxwaBW+SFJYOo6T0YqYQVuFejhtDXkhZg09o1dM=;\n\tb=rAlyl7SiTrACPw/7poL4SFujQ772NBab0VKlX0XCGSf4+wW7utQEI4Ek2fg2DHGNTo\n\tz1Z9qJf/AKmFmjbb1NHs7DpQg4oidT7ysuRXIHk6zhUhfcsc5eDp4j7WqGdhC3TU8ADJ\n\tFwHhNuHcuFjlZsRHTOYmOSUzWH4xV2LE+i4U2P5tGnulDrk+ZvJZDCe4KEqVFX2/gzRa\n\tQ3bnt5VUC0FJu/eoCmU+SuDtzp3BG7dgIuQeMGiF1gMRFVxfhBm7VpMqYPj0s4hcAXIb\n\tFK4ausOIxd/TTQEhgwfA0V4qo/r/eeH3AwPqksL0Ny60izyMNcvsKu+M/9jakuTjl6qA\n\tAzpw==","X-Gm-Message-State":"AMCzsaW+fopTDTgZgYN/NQjFLMZO+wOBJ/uL6KZQEil1HU5VQ5+pbmHK\n\tJW8Sb39h3ZLsRWyPlM/eR2y5m3Xsf1p0ssVErw8=","X-Google-Smtp-Source":"AOwi7QB9d0DsgGb73UMl6XnjOOhWj9phxi+icU3t51o3L1XXxpVvuMMLrenH10EfHKcT/ilUHeAWF6FvmuVXHmtXNQE=","X-Received":"by 10.36.205.67 with SMTP id l64mr5456403itg.101.1506970088803; \n\tMon, 02 Oct 2017 11:48:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAPDyKFohh0_aONKyoc2deN+L8TCzY8tdEs5-fja3t5oVL2Gs7w@mail.gmail.com>","References":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>\n\t<20170924190528.21841-2-martin.blumenstingl@googlemail.com>\n\t<CAPDyKFohh0_aONKyoc2deN+L8TCzY8tdEs5-fja3t5oVL2Gs7w@mail.gmail.com>","From":"Martin Blumenstingl <martin.blumenstingl@googlemail.com>","Date":"Mon, 2 Oct 2017 20:47:48 +0200","Message-ID":"<CAFBinCA6HfKTNSLczx=V3dtfsrUSMKJw-nLAp6s9m55dJ9nQxA@mail.gmail.com>","Subject":"Re: [RFC v2 1/2] dt-bindings: mmc: Document the Amlogic Meson8 and\n\tMeson8b SDIO bindings","To":"Ulf Hansson <ulf.hansson@linaro.org>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171002_114830_127430_7D99B4B4 ","X-CRM114-Status":"GOOD (  17.11  )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.7 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:4001:c0b:0:0:0:241 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (martin.blumenstingl[at]googlemail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tKevin Hilman <khilman@baylibre.com>,\n\t\"linux-mmc@vger.kernel.org\" <linux-mmc@vger.kernel.org>,\n\tRob Herring <robh+dt@kernel.org>, Carlo Caione <carlo@endlessm.com>, \n\tCarlo Caione <carlo@caione.org>,\n\t\"open list:ARM/Amlogic Meson...\" <linux-amlogic@lists.infradead.org>, \n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778846,"web_url":"http://patchwork.ozlabs.org/comment/1778846/","msgid":"<CAFBinCDrEmj27ewWQ4+rNXtFSWR3dUoF5H2qZmn2=bpP6OXSZw@mail.gmail.com>","list_archive_url":null,"date":"2017-10-03T11:19:08","subject":"Re: [RFC v2 0/2] Add support for Meson MX \"SDIO\" MMC controller","submitter":{"id":66366,"url":"http://patchwork.ozlabs.org/api/people/66366/","name":"Martin Blumenstingl","email":"martin.blumenstingl@googlemail.com"},"content":"Hi Rob,\n\nOn Wed, Sep 27, 2017 at 9:36 PM, Rob Herring <robh@kernel.org> wrote:\n> On Sun, Sep 24, 2017 at 09:05:26PM +0200, Martin Blumenstingl wrote:\n>> This is the successor to Carlo Caione's \"Add support for Amlogic Meson\n>> MMC driver\" series (v5) from [0].\n>> This new driver is for the \"SDIO\" controller found in Amlogic Meson6,\n>> Meson8 and Meson8b SoCs and supports an internal mux to allow connecting\n>> three cards to it.\n>>\n>>\n>> changes since RFC v1 at [1]:\n>> - added COMMON_CLK dependency as reported by the kbuild test robot\n>> - use of_platform_device_{create,destroy} instead of open-coding it's\n>>   logic\n>> - moved struct device (which was an array) from meson_mx_mmc_host to\n>>   the corresponding meson_mx_mmc_slot\n>> - use struct mmc_command's busy_timeout instead of hard-coding the\n>>   timeout values in meson_mx_mmc_start_cmd()\n>> - don't use arrays with only one element for the clock parents in\n>>   meson_mx_mmc_register_clks()\n>> - removed the wrapper functions meson_mx_mmc_readl() meson_mx_mmc_writel()\n>> - allow setting the MMC clock to 0 for UHS speed mode (the actual\n>>   hardware clock cannot be gated as far as I know, so instead the\n>>   lowest supported rate is chosen)\n>> - remove unused #include <linux/init.h>\n>> - add MMC_CAP_ERASE\n>> - removed multiple slot support after discussing this with Ulf\n>>   (this is a feature that needs to be part of the MMC core before drivers\n>>   can use it)\n>> - removed SDIO interrupt support (as I currently don't have a way to\n>>   test it)\n>> - merge meson_mx_mmc_apply_ios into meson_mx_mmc_set_ios (as that's\n>>   the only place where it's needed after removing multiple slot support)\n>> - updated the commit message of the driver patch to indicate the\n>>   difference between the meson-mx-sdio.c and meson-gx.c (and the \"still\n>>   missing SDHC\") driver\n>> - NOTE: I did not add Rob's ACK on the dt-bindings patch because I\n>>   introduced the \"mmc-slot\" compatible for the child nodes as suggested\n>>   by Ulf (and I want confirmation from the DT maintainers that I did this\n>>   correctly)\n>\n> Didn't slot support get removed as no h/w really uses that feature?\nI have at least one boards which uses it: Endless Mini (EC-100)\nthe SoC itself has two MMC controllers, but that board has:\n- an eMMC module (connected to a yet unsupported MMC controller)\n- an internal SD card (connected to the SDIO controller from this patch)\n- a RTL8723BS wifi SDIO card (also connected to the SDIO controller\nfrom this patch)\n\nso it's pretty rare - but such hardware exists.\n\n\nRegards,\nMartin","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"KtCyhkN1\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"X9zaT6jK\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5xQR3gRTz9s83\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tTue,  3 Oct 2017 22:19:59 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dzLEx-0000ix-6n; Tue, 03 Oct 2017 11:19:55 +0000","from mail-io0-x242.google.com ([2607:f8b0:4001:c06::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dzLEu-0000ed-Bq; Tue, 03 Oct 2017 11:19:54 +0000","by mail-io0-x242.google.com with SMTP id e9so4637561iod.5;\n\tTue, 03 Oct 2017 04:19:29 -0700 (PDT)","by 10.2.51.84 with HTTP; Tue, 3 Oct 2017 04:19:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ZODeuq6TmI/WXdR1zkXCWM1kla3cwBqCPhFK5DbQCLQ=;\n\tb=KtCyhkN1TKdjkr\n\thQiyPpTmvaCV/WUhJ1wuOcpSCEZmy6KdpJMKj9nNvKquoA9ir1gS5EYM/dV3jMwAW+iZUjEHRkUen\n\tRS/D8k/7ekRoRYf0fN3cSrYG4O+2W8z5JFNfPXnZ1j7IjPlU14qOZIYNSntztXZf7MEVw5sf4ViPr\n\t7QCtxg4+sANUK9/vEo6/VODbVzksiGJpDsCbGrwezjo/3TGlWKabmbRa2mPqf5B4JXB8Vo5PvBkZW\n\tHMikFXl0wxoyeo24boBGChQuopgEnPQq7cDKQl7SA6jsKuuHTuirgi1oKqQGd3dJUXFjazqgyKrr7\n\tHc/Gto2xSpGeoSfm94qA==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=e47n7zePQdO2zgF07lPQFWmGqTDUISUuYBfvFkFRygY=;\n\tb=X9zaT6jK8UJQwSvOj4cAqvYTV/c1esnfn8KhDeBs7A126MaPXVcVgIayDGrGJrR5js\n\t/mVcCu3zHj2oFI+VD5GibroiisCBaLFw1F+rF1bkVdKzQEszZk5DYQOZ7LE/lmji1fuz\n\tJvhfbScE/nlf/cdQFH3/mfB+cbL+SHxWHfHZlB9MSXbykk009IJUH3fFS96k2AUlywkD\n\tjCpwhbOqEBesB2v5Z3m/sw5UeKQ9vPWIb8eFA5KitbNt4lLaE1rx0hi4P8sKK3BoND8n\n\tATazSkGqXu9Ed3kO9hBpB9LrHRVHhYJ91kwmrUmsdaTXJZBJ5VRxA75hRMYz9d2R2mku\n\teT3g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=e47n7zePQdO2zgF07lPQFWmGqTDUISUuYBfvFkFRygY=;\n\tb=NcLVrQj6p6c4wOT20tdEsWYBFX1uyVeOFkb5KagPB9UEFpytjOnQCnV3Rsw95g2803\n\tZmK7T10RRS2ixgYpynXqlZGbuQY/XdPc+G2Z7KT6fyj/fGMsnfBNVkVMAUtG/MA1VbCg\n\tJSicFYB9vHVL83OF6MSrux2YROrD+4LW9zPBDHYt+e9PyK1f6lOZ/SAFSveOxWlmQjS2\n\tZIyvFU26FXmS8qzliLtusiIBvSEzLUGsufp+bnicGYeCcEBglefONUv5kPMwE++k5kLL\n\tEWNZd3PcM9680nYoJjMjq7uBm2Z/XLX54/q8hf4ge4OIgPIbPm6qmqpUN+qtkX7xFG/I\n\tbQ7A==","X-Gm-Message-State":"AMCzsaXmIy1CwTPwUNF48X5TzOt8EQmOF/P52S/X5+X4h148jpx7R0Pe\n\tTTmVOOFllf6Qv/Z4vfjuuQsRJhizIWg9lEKv3VQ=","X-Google-Smtp-Source":"AOwi7QA8QOGdYxq2KO3cdYD4L4SAddTLNnrd59AxreuAXluosPc0ohzi9YzPwns+s/sIbpwpBUj9BX/GsS/Ki7B0Wq8=","X-Received":"by 10.107.7.161 with SMTP id g33mr26912836ioi.169.1507029568681; \n\tTue, 03 Oct 2017 04:19:28 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170927193616.32gxszmk4cjjoqmo@rob-hp-laptop>","References":"<20170924190528.21841-1-martin.blumenstingl@googlemail.com>\n\t<20170927193616.32gxszmk4cjjoqmo@rob-hp-laptop>","From":"Martin Blumenstingl <martin.blumenstingl@googlemail.com>","Date":"Tue, 3 Oct 2017 13:19:08 +0200","Message-ID":"<CAFBinCDrEmj27ewWQ4+rNXtFSWR3dUoF5H2qZmn2=bpP6OXSZw@mail.gmail.com>","Subject":"Re: [RFC v2 0/2] Add support for Meson MX \"SDIO\" MMC controller","To":"Rob Herring <robh@kernel.org>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171003_041952_480387_07564FA0 ","X-CRM114-Status":"GOOD (  14.23  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:4001:c06:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (martin.blumenstingl[at]googlemail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org, ulf.hansson@linaro.org,\n\tkhilman@baylibre.com, linux-mmc@vger.kernel.org, carlo@caione.org,\n\tlinux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]