[{"id":1775052,"web_url":"http://patchwork.ozlabs.org/comment/1775052/","msgid":"<20170925234925.GE12504@umbus>","list_archive_url":null,"date":"2017-09-25T23:49:25","subject":"Re: [Qemu-devel] [PATCH 0/7] mac_dbdma: tidy-up and QOMify","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Sun, Sep 24, 2017 at 03:47:39PM +0100, Mark Cave-Ayland wrote:\n> Whilst looking at implementing another DBDMA device for the Mac machines\n> I noticed a couple of things: firstly there were some unused fields still\n> in DBDMAState, and secondly the existing code still used global functions\n> to register DMA channels and handle the relationship between macio IDE and\n> DBDMA.\n> \n> This patchset removes the now-unused fields from DBDMA state, QOMifys the\n> DBDMA device, uses a QOM object link to allow the macio IDE object to\n> reference the DBDMA device, and then finally removes the global DBDMA_*\n> functions substituting them instead for QOM methods.\n> \n> Note: this patchset does not apply to master but on top of David's\n> ppc-for-2.11 branch since there are merge conflicts with my previous\n> patchset. Hopefully the Based-On line below is enough to keep patchew\n> happy, even though it wasn't the final version applied to the ppc-for-2.11\n> branch.\n> \n> Signed-off-by: Mark Cave-Ayland \n> Based-on: 1505668548-16616-1-git-send-email-mark.cave-ayland@ilande.co.uk (ppc: more Mac-related fixups)\n\nI've applied 1-5/7. There are a couple of details I'm not 100%\nconvinced on, but it's still better than what was there before. 6 & 7\nI'm still thinking about.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"dHfSW0zt\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1LRw6GPjz9t3t\n\tfor ;\n\tTue, 26 Sep 2017 09:50:20 +1000 (AEST)","from localhost ([::1]:44836 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwd8k-0005LZ-Ng\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 19:50:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51190)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwd86-0005K0-E3\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:49:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwd83-00051j-Bp\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:49:38 -0400","from ozlabs.org ([103.22.144.67]:44831)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwd82-00051K-WF; Mon, 25 Sep 2017 19:49:35 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3y1LQz2c2yz9t3Z; Tue, 26 Sep 2017 09:49:31 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1506383371;\n\tbh=g3zmfTVAZJPOoD9vsp1nOt+HmAe5G6hGkG2gRIFCsyI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dHfSW0ztZ39xy2+kzyf3epnTAeiB11n6IzzBOopbLwUa8CKtGZ9F1DobYIyU2HJZ2\n\tXwiV8C8m7UCXnV4CQDaKEtQGDEt0ye0KqXE+cwvlz1YR7eO+xFT/wN6Kxg4B3APmys\n\tjPNGYQ96zbpXOVCEei6y3G6iIqC7v80oR1qU/a8c=","Date":"Tue, 26 Sep 2017 09:49:25 +1000","From":"David Gibson ","To":"Mark Cave-Ayland ","Message-ID":"<20170925234925.GE12504@umbus>","References":"<1506264466-28252-1-git-send-email-mark.cave-ayland@ilande.co.uk>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"6e7ZaeXHKrTJCxdu\"","Content-Disposition":"inline","In-Reply-To":"<1506264466-28252-1-git-send-email-mark.cave-ayland@ilande.co.uk>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH 0/7] mac_dbdma: tidy-up and QOMify","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]