[{"id":1774152,"web_url":"http://patchwork.ozlabs.org/comment/1774152/","msgid":"<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>","list_archive_url":null,"date":"2017-09-24T12:01:03","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":1124,"url":"http://patchwork.ozlabs.org/api/people/1124/","name":"Marek Vasut","email":"marek.vasut@gmail.com"},"content":"On 09/24/2017 12:59 PM, Vignesh R wrote:\n> Add pm_runtime* calls to cadence-quadspi driver. This is required to\n> switch on QSPI power domain on TI 66AK2G SoC during probe.\n> \n> Signed-off-by: Vignesh R \n\nAre you planning to add some more fine-grained PM control later?\n\n> ---\n> drivers/mtd/spi-nor/cadence-quadspi.c | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n> index d9629e8f4798..2c8e6226d267 100644\n> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n> @@ -31,6 +31,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -1224,6 +1225,13 @@ static int cqspi_probe(struct platform_device *pdev)\n> \t\treturn -ENXIO;\n> \t}\n> \n> +\tpm_runtime_enable(&pdev->dev);\n> +\tret = pm_runtime_get_sync(&pdev->dev);\n> +\tif (ret < 0) {\n> +\t\tpm_runtime_put_noidle(&pdev->dev);\n> +\t\treturn ret;\n> +\t}\n> +\n> \tret = clk_prepare_enable(cqspi->clk);\n> \tif (ret) {\n> \t\tdev_err(dev, \"Cannot enable QSPI clock.\\n\");\n> @@ -1275,6 +1283,9 @@ static int cqspi_remove(struct platform_device *pdev)\n> \n> \tclk_disable_unprepare(cqspi->clk);\n> \n> +\tpm_runtime_put_sync(&pdev->dev);\n> +\tpm_runtime_disable(&pdev->dev);\n> +\n> \treturn 0;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"QTQky0y5\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"FJg2JAuK\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0R1S6dc7z9sRW\n\tfor ;\n\tSun, 24 Sep 2017 22:12:44 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw5m4-0004aZ-QF; Sun, 24 Sep 2017 12:12:40 +0000","from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw5lh-0004Ah-NS; Sun, 24 Sep 2017 12:12:24 +0000","by mail-wr0-x242.google.com with SMTP id k20so2910454wre.1;\n\tSun, 24 Sep 2017 05:11:56 -0700 (PDT)","from [192.168.1.4] (ip-86-49-107-50.net.upcbroadband.cz.\n\t[86.49.107.50]) by smtp.gmail.com with ESMTPSA id\n\tr73sm3309912wmg.19.2017.09.24.05.11.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Sep 2017 05:11:54 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=uJU8dZoJEoANjYKNCxM1bwYZXq6y+TLDp0xyfgxISVA=;\n\tb=QTQky0y5bnfp//\n\tuYvkIoHveQgvgunPwMcr3Zj8AUK8NDdzPcMbmye5Vvun+bfUduWP5tKvF8E302UkzMdA2mNDCKdwx\n\tyaEyQqGhK+u2FvKQ+a1zQdBfAxE39kujvnL2m2hInW2zZ5AuyJguBvTbzdOGkILNQAXfGXnHfPtY0\n\tKsQFfIEk4RuASZfmFtF+WSSrp6q/AdaTDc4ZaurLT6zDcxskfT8BLEsbhACT95SuCL2Er9G2imgzV\n\thFOZEcZb77gctW4zovlm2QMHZxnpdkQUXc3VnJLmCWTZYnAsN/fVKMBYLGLp5ukdeq0WhNOGLww8d\n\tGErOCN+mCAZ84wp/NsQA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=uooae0hFGXjq0bKLM5WInyyryMVM56r8ySShsuoocm8=;\n\tb=FJg2JAuKxFd/SCahTIA3cA3KAFYR+GRnYeqqAkSjtAjQO2WGpGGXCmS+G6VjXC4k54\n\tfHElvu/m0G3nfTdYVcCIaCKCvpWOegtVSTR+zcyJWQ6qQrkDRR6ZXU4R4gMq20Lq3sCA\n\tNUzBLH1BQlmU3A+jwkYPy97sPCTKSejwLDApvMKWywgcBLM49C4pw3ciKEQh8q/chBxr\n\tHI29IknLgd/24QK+3fTshJeWao6wb3lNk/YbKYVbeJojyYklyFR1ygYsT50HWsILwfTz\n\t2mbqbFn1U5L11vXn6gqRUCzC+BqdL8hoE8bUWyESDMD6kUyp+tHMqt0reWjpyvMf+hWQ\n\tfQEA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=uooae0hFGXjq0bKLM5WInyyryMVM56r8ySShsuoocm8=;\n\tb=J1Numscb9+jRxz4TXt7leCnRoC5K/F2zLyI9yhW82OmboBAgLFviJ1SWvvuPttj2hN\n\tQ2F7MfPWSOmpWmx4BO9qRnnXxTrJIc4wIlVA9L/HdnAq7JkUIhXVbyNHhZ09Pi8vDkxi\n\t5VhO7mV21yDHkR19ZvrGKITuXv+fwlfGmVQCo/RjJ0knpIyyCDd7OUIfnjE6EdljN+xd\n\tHZ+YYWTaVqL62YD9imh3ezigkm2wgdE4UBPMKkfIRgldjvRavlR8+q3q0yF2eLeA/Ti7\n\tz1R/Mr4VlqIFZUfmRzuJi2NKVhDB/uyHp8F73ltNl7Nv0ytYjlsZk/CivwICP8JEZAT9\n\tjiVA==","X-Gm-Message-State":"AHPjjUiHAdHCMIIAw1yPGMV6D23gqGMCS2RVXPsEP9BsS2YKOFghV+T3\n\txGnJPxjVao1SMmh9tMlTd44q28Q5","X-Google-Smtp-Source":"AOwi7QDiZ7fJE8gGZLIOq0q5GJDZIqnb8l5PFKuA+why498HSAGbk3TRmfgu5wvXZisFLlFZ1WMK4g==","X-Received":"by 10.223.175.230 with SMTP id y38mr3327959wrd.213.1506255115171;\n\tSun, 24 Sep 2017 05:11:55 -0700 (PDT)","Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"Vignesh R , Cyrille Pitchen ","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>","From":"Marek Vasut ","Message-ID":"<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>","Date":"Sun, 24 Sep 2017 14:01:03 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170924105924.23923-6-vigneshr@ti.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_051218_670488_39A88A4C ","X-CRM114-Status":"GOOD ( 15.03 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (marek.vasut[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774153,"web_url":"http://patchwork.ozlabs.org/comment/1774153/","msgid":"<94313cae-4805-0b13-a469-72aa7556b685@gmail.com>","list_archive_url":null,"date":"2017-09-24T11:59:45","subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","submitter":{"id":1124,"url":"http://patchwork.ozlabs.org/api/people/1124/","name":"Marek Vasut","email":"marek.vasut@gmail.com"},"content":"On 09/24/2017 12:59 PM, Vignesh R wrote:\n> As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access\n> Controller programming sequence, a delay equal to couple of QSPI master\n> clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and\n> writing data to the flash. Introduce a quirk flag CQSPI_NEEDS_WR_DELAY\n> to handle this and set this flag for TI 66AK2G SoC.\n> \n> [1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf\n> \n> Signed-off-by: Vignesh R \n\nIs this TI specific or is this controller property ? I wouldn't be\nsurprised of the later ...\n\n> ---\n> \n> v3:\n> Fix build warnings reported by kbuild test bot.\n> \n> drivers/mtd/spi-nor/cadence-quadspi.c | 27 ++++++++++++++++++++++++++-\n> 1 file changed, 26 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n> index 53c7d8e0327a..5cd5d6f7303f 100644\n> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n> @@ -38,6 +38,9 @@\n> #define CQSPI_NAME\t\t\t\"cadence-qspi\"\n> #define CQSPI_MAX_CHIPSELECT\t\t16\n> \n> +/* Quirks */\n> +#define CQSPI_NEEDS_WR_DELAY\t\tBIT(0)\n> +\n> struct cqspi_st;\n> \n> struct cqspi_flash_pdata {\n> @@ -76,6 +79,7 @@ struct cqspi_st {\n> \tu32\t\t\tfifo_depth;\n> \tu32\t\t\tfifo_width;\n> \tu32\t\t\ttrigger_address;\n> +\tu32\t\t\twr_delay;\n> \tstruct cqspi_flash_pdata f_pdata[CQSPI_MAX_CHIPSELECT];\n> };\n> \n> @@ -608,6 +612,15 @@ static int cqspi_indirect_write_execute(struct spi_nor *nor,\n> \treinit_completion(&cqspi->transfer_complete);\n> \twritel(CQSPI_REG_INDIRECTWR_START_MASK,\n> \t reg_base + CQSPI_REG_INDIRECTWR);\n> +\t/*\n> +\t * As per 66AK2G02 TRM SPRUHY8F section 11.15.5.3 Indirect Access\n> +\t * Controller programming sequence, couple of cycles of\n> +\t * QSPI_REF_CLK delay is required for the above bit to\n> +\t * be internally synchronized by the QSPI module. Provide 5\n> +\t * cycles of delay.\n> +\t */\n> +\tif (cqspi->wr_delay)\n> +\t\tndelay(cqspi->wr_delay);\n> \n> \twhile (remaining > 0) {\n> \t\twrite_bytes = remaining > page_size ? page_size : remaining;\n> @@ -1156,6 +1169,7 @@ static int cqspi_probe(struct platform_device *pdev)\n> \tstruct cqspi_st *cqspi;\n> \tstruct resource *res;\n> \tstruct resource *res_ahb;\n> +\tunsigned long data;\n> \tint ret;\n> \tint irq;\n> \n> @@ -1213,6 +1227,10 @@ static int cqspi_probe(struct platform_device *pdev)\n> \t}\n> \n> \tcqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);\n> +\tdata = (unsigned long)of_device_get_match_data(dev);\n> +\tif (data & CQSPI_NEEDS_WR_DELAY)\n> +\t\tcqspi->wr_delay = 5 * DIV_ROUND_UP(NSEC_PER_SEC,\n> +\t\t\t\t\t\t cqspi->master_ref_clk_hz);\n> \n> \tret = devm_request_irq(dev, irq, cqspi_irq_handler, 0,\n> \t\t\t pdev->name, cqspi);\n> @@ -1284,7 +1302,14 @@ static const struct dev_pm_ops cqspi__dev_pm_ops = {\n> #endif\n> \n> static const struct of_device_id cqspi_dt_ids[] = {\n> -\t{.compatible = \"cdns,qspi-nor\",},\n> +\t{\n> +\t\t.compatible = \"cdns,qspi-nor\",\n> +\t\t.data = (void *)0,\n> +\t},\n> +\t{\n> +\t\t.compatible = \"ti,k2g-qspi\",\n> +\t\t.data = (void *)CQSPI_NEEDS_WR_DELAY,\n> +\t},\n> \t{ /* end of table */ }\n> };\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"uKrpUH4G\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kepphnSI\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0R2946mcz9sRW\n\tfor ;\n\tSun, 24 Sep 2017 22:13:21 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw5mb-0004ux-7l; Sun, 24 Sep 2017 12:13:14 +0000","from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw5lg-0004AV-0T; Sun, 24 Sep 2017 12:12:24 +0000","by mail-wm0-x243.google.com with SMTP id r136so4897610wmf.3;\n\tSun, 24 Sep 2017 05:11:55 -0700 (PDT)","from [192.168.1.4] (ip-86-49-107-50.net.upcbroadband.cz.\n\t[86.49.107.50]) by smtp.gmail.com with ESMTPSA id\n\t56sm2800145wrx.2.2017.09.24.05.11.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Sep 2017 05:11:53 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ljQ4CGBoaiyueZiI4iLFoJuQc9LTsiFu90TJ1U6Z5RI=;\n\tb=uKrpUH4G8NHiHp\n\tPFOJrD8PYfIPIx970SLX3BWEIADqwS8xJWojjoXAD1IIhG1ug2RjRgCSNlfe0iI5bFKt10aJ+RH1j\n\txxaFH3uPDShbEBv0jPqzy13KsbdsKMe/Pl1Q2bI/qhBaN0nRg26mnipMwDefiepmfZTZ8Gr4WYnTY\n\twO6fDW0TUfCDx5FGanyfXPjDpQELYPaRND87U6dpkKYoG7B9N/15wXH6q9Or+iPzqwnfzCHOAtN6j\n\tHY5V5O4joaD/V8GOdxWh3g/GqDPXESw5mukWnrJo35hzkZUj2vR8TZcPKmIaXIFoVErBMvLT//R97\n\t/gWs13aSuiy5DHGHc/pw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=g4v+zAPisbynwaZ/CIr7BX8KOi5X5/AUgrrh68sfAng=;\n\tb=kepphnSIOy+EsP2qLa3itH/dufiZfrtgzuSRhTEt2K02EFvHxwSIdese8M8kM1w2r8\n\ttLHAcgukfCOLOM9yF3tN+iAOv3I5pOGri430vWbEd7zuLX+aQ/3dz2eXfDwzLXO7Gabu\n\taAh3xmtIdNx3Rvg9ieiwUTRFYPihwPIcDw0nY2xrNZZCGL81CbqUwYduU0nFaiBvQuC5\n\tGqDoRzF9GOWgyoUDtZ2a/ndjqyTnGV4S7g/a6hTPXnXvdJ4ABc/kg9Gxyzwl1UgaYnav\n\t7T3Rwobv6PUchWpJdIpi1A7na0IrayBm8lf4ZQ6A+d22YUjBz+42iV/+QTS7kAUqsu0D\n\tYgNw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=g4v+zAPisbynwaZ/CIr7BX8KOi5X5/AUgrrh68sfAng=;\n\tb=hyjDPXiNDQfV9hXdV9vrk9uNig3vf3hAGz8D3AK+PyBtRv2HuXw6JSSuqV9pjovVqE\n\tgATo3rQPx4wi3VrEw2QF3goaYFMT2S5KxGq6O5MOXqxDniA2bZZyi7O5L8pnrgW5aLfA\n\t9oN0089XBheostZTYWk+3vHIh27KGZkRJIojvIYd+WAvB2EecrP1YXu+7XB9uCMr4Ci6\n\tJZBUlsGCwgt3/imU0ObjzYOYgDA2kUiLmO06mbnN/LDg8caJv5qD8n0pJgQnkPHo/vCi\n\tU5oWffCfY7Z065MnaPRO38UJWH0wJfQRkMGMEMjgFWtnomdrgAfuQIeFcchSZjKcbihu\n\t234Q==","X-Gm-Message-State":"AHPjjUiBL0ctMkpTvGCuGIu3vcCTKuN2ktJnm8Vwz8WxPeg201g7Vn9Z\n\tGlSv5kRzEVVSwCQ53viRiy6KfWww","X-Google-Smtp-Source":"AOwi7QAe4B5rOYCPQmR5fofos+9va0Rn644oDO8XxkPppX3Z0fR7z4yig/Ov2J/1BPvnOkudPNLXug==","X-Received":"by 10.28.139.208 with SMTP id n199mr1868800wmd.29.1506255113693; \n\tSun, 24 Sep 2017 05:11:53 -0700 (PDT)","Subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","To":"Vignesh R , Cyrille Pitchen ","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-3-vigneshr@ti.com>","From":"Marek Vasut ","Message-ID":"<94313cae-4805-0b13-a469-72aa7556b685@gmail.com>","Date":"Sun, 24 Sep 2017 13:59:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170924105924.23923-3-vigneshr@ti.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_051216_715150_60AD11BD ","X-CRM114-Status":"GOOD ( 19.23 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (marek.vasut[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774160,"web_url":"http://patchwork.ozlabs.org/comment/1774160/","msgid":"<8990b971-91d5-747f-905b-5e24743e090d@ti.com>","list_archive_url":null,"date":"2017-09-24T12:33:51","subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","submitter":{"id":65039,"url":"http://patchwork.ozlabs.org/api/people/65039/","name":"Raghavendra, Vignesh","email":"vigneshr@ti.com"},"content":"On 9/24/2017 5:29 PM, Marek Vasut wrote:\n> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>> As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access\n>> Controller programming sequence, a delay equal to couple of QSPI master\n>> clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and\n>> writing data to the flash. Introduce a quirk flag CQSPI_NEEDS_WR_DELAY\n>> to handle this and set this flag for TI 66AK2G SoC.\n>>\n>> [1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf\n>>\n>> Signed-off-by: Vignesh R \n> \n> Is this TI specific or is this controller property ? I wouldn't be\n> surprised of the later ...\n\nI am not sure, there is no generic public documentation by cadence for\nthis IP. TI TRM clearly states this delay is required and I have\nverified it practically that this delay is indeed needed.\nBut current user of this IP, socfpga does not seem to mention anything\nabout it. So, I guess its TI specific quirk.\n\n> \n>> ---\n>>\n>> v3:\n>> Fix build warnings reported by kbuild test bot.\n>>\n>> drivers/mtd/spi-nor/cadence-quadspi.c | 27 ++++++++++++++++++++++++++-\n>> 1 file changed, 26 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n>> index 53c7d8e0327a..5cd5d6f7303f 100644\n>> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n>> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n>> @@ -38,6 +38,9 @@\n>> #define CQSPI_NAME\t\t\t\"cadence-qspi\"\n>> #define CQSPI_MAX_CHIPSELECT\t\t16\n>> \n>> +/* Quirks */\n>> +#define CQSPI_NEEDS_WR_DELAY\t\tBIT(0)\n>> +\n>> struct cqspi_st;\n>> \n>> struct cqspi_flash_pdata {\n>> @@ -76,6 +79,7 @@ struct cqspi_st {\n>> \tu32\t\t\tfifo_depth;\n>> \tu32\t\t\tfifo_width;\n>> \tu32\t\t\ttrigger_address;\n>> +\tu32\t\t\twr_delay;\n>> \tstruct cqspi_flash_pdata f_pdata[CQSPI_MAX_CHIPSELECT];\n>> };\n>> \n>> @@ -608,6 +612,15 @@ static int cqspi_indirect_write_execute(struct spi_nor *nor,\n>> \treinit_completion(&cqspi->transfer_complete);\n>> \twritel(CQSPI_REG_INDIRECTWR_START_MASK,\n>> \t reg_base + CQSPI_REG_INDIRECTWR);\n>> +\t/*\n>> +\t * As per 66AK2G02 TRM SPRUHY8F section 11.15.5.3 Indirect Access\n>> +\t * Controller programming sequence, couple of cycles of\n>> +\t * QSPI_REF_CLK delay is required for the above bit to\n>> +\t * be internally synchronized by the QSPI module. Provide 5\n>> +\t * cycles of delay.\n>> +\t */\n>> +\tif (cqspi->wr_delay)\n>> +\t\tndelay(cqspi->wr_delay);\n>> \n>> \twhile (remaining > 0) {\n>> \t\twrite_bytes = remaining > page_size ? page_size : remaining;\n>> @@ -1156,6 +1169,7 @@ static int cqspi_probe(struct platform_device *pdev)\n>> \tstruct cqspi_st *cqspi;\n>> \tstruct resource *res;\n>> \tstruct resource *res_ahb;\n>> +\tunsigned long data;\n>> \tint ret;\n>> \tint irq;\n>> \n>> @@ -1213,6 +1227,10 @@ static int cqspi_probe(struct platform_device *pdev)\n>> \t}\n>> \n>> \tcqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);\n>> +\tdata = (unsigned long)of_device_get_match_data(dev);\n>> +\tif (data & CQSPI_NEEDS_WR_DELAY)\n>> +\t\tcqspi->wr_delay = 5 * DIV_ROUND_UP(NSEC_PER_SEC,\n>> +\t\t\t\t\t\t cqspi->master_ref_clk_hz);\n>> \n>> \tret = devm_request_irq(dev, irq, cqspi_irq_handler, 0,\n>> \t\t\t pdev->name, cqspi);\n>> @@ -1284,7 +1302,14 @@ static const struct dev_pm_ops cqspi__dev_pm_ops = {\n>> #endif\n>> \n>> static const struct of_device_id cqspi_dt_ids[] = {\n>> -\t{.compatible = \"cdns,qspi-nor\",},\n>> +\t{\n>> +\t\t.compatible = \"cdns,qspi-nor\",\n>> +\t\t.data = (void *)0,\n>> +\t},\n>> +\t{\n>> +\t\t.compatible = \"ti,k2g-qspi\",\n>> +\t\t.data = (void *)CQSPI_NEEDS_WR_DELAY,\n>> +\t},\n>> \t{ /* end of table */ }\n>> };\n>> \n>>\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"tvMVd0Wx\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"VZwIaZcC\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0RXd46DCz9sRW\n\tfor ;\n\tSun, 24 Sep 2017 22:36:17 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw68r-0002ND-Fs; Sun, 24 Sep 2017 12:36:13 +0000","from fllnx209.ext.ti.com ([198.47.19.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw68S-0001yN-G3; Sun, 24 Sep 2017 12:35:51 +0000","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8OCY2JI030858; \n\tSun, 24 Sep 2017 07:34:02 -0500","from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8OCXv3U002604;\n\tSun, 24 Sep 2017 07:33:57 -0500","from DLEE110.ent.ti.com (157.170.170.21) by DLEE107.ent.ti.com\n\t(157.170.170.37) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tSun, 24 Sep 2017 07:33:56 -0500","from dlep32.itg.ti.com (157.170.170.100) by DLEE110.ent.ti.com\n\t(157.170.170.21) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Sun, 24 Sep 2017 07:33:56 -0500","from [172.22.218.57] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8OCXpje000382;\n\tSun, 24 Sep 2017 07:33:52 -0500"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=l54ZRBvTQtYZAxIcRXE8jnR8jw+9KxrQd2Fw3ZprhB8=;\n\tb=tvMVd0Wxd7cHE1\n\t6Q67x4GL6oSaqMyIjoaAuAKGSBv9MVvVnYfYfplGB/++S1XoSOdzFX7iwgByAlYHXGwZXaXoPxMQ5\n\t+uoZSBEKBgNgWHECcOuuBFoGmpwTO0BtwxKzqpztc51hXa8EqrpMaCRpHBOkl1pF3Iy1FsNEg3DQv\n\teJcClxRkdtlqBoFaCRueito0gyJLxECikA+OLNK2Xxtukj/RKNe1pfbVtaGbHeZYCpHX3CCWRT9KO\n\t2T27Eaqp0c8k207uLaNOFRjTIwIpU4Izw9fZ6oTd1IiyZeO7xAGu9f79NyBJDOeE/cFscDTxia3Qa\n\t9GunpeNLiTXhKTjnsl7Q==;","v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506256442;\n\tbh=U4AJTVEHOBpMZFR+ml9l0XP4eWgkIYe3SIRgeYPWSug=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=VZwIaZcCdXBQKS0WQgHPqM0p/F0cotEwq5Mu0Zx2ulhMf6A2ZaNWbmrQPyxY3W3E6\n\tgkmkAeG/0leKwpDpE3M3kwHDYiYYGxsOxOZe/Pb4MSpifj56vCZH3Br0eMstnKBC9d\n\tcrtf3fGJB1ktIGI+Pkki74gpaVwSSr0pv/1OM9dI="],"Subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","To":"Marek Vasut , Cyrille Pitchen\n\t","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-3-vigneshr@ti.com>\n\t<94313cae-4805-0b13-a469-72aa7556b685@gmail.com>","From":"Vignesh R ","Message-ID":"<8990b971-91d5-747f-905b-5e24743e090d@ti.com>","Date":"Sun, 24 Sep 2017 18:03:51 +0530","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<94313cae-4805-0b13-a469-72aa7556b685@gmail.com>","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_053548_664101_D8CE196C ","X-CRM114-Status":"GOOD ( 13.58 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.19.16 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774179,"web_url":"http://patchwork.ozlabs.org/comment/1774179/","msgid":"<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>","list_archive_url":null,"date":"2017-09-24T13:08:23","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":65039,"url":"http://patchwork.ozlabs.org/api/people/65039/","name":"Raghavendra, Vignesh","email":"vigneshr@ti.com"},"content":"On 9/24/2017 5:31 PM, Marek Vasut wrote:\n> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>> Add pm_runtime* calls to cadence-quadspi driver. This is required to\n>> switch on QSPI power domain on TI 66AK2G SoC during probe.\n>>\n>> Signed-off-by: Vignesh R \n> \n> Are you planning to add some more fine-grained PM control later?\n\nYes, I will need to add fine-grained PM control at some point. But, for\nnow SoC does not really support low power mode or runtime power saving\noption.\nThe fact that driver still uses clk_prepare_*() calls to enable/disable\nclocks instead of pm_*() calls makes it a bit tricky though.\n\nJust figured out I forgot to add cleanup code in error handling path of\nprobe(). Will fix that and send a v4.\n\n> \n>> ---\n>> drivers/mtd/spi-nor/cadence-quadspi.c | 11 +++++++++++\n>> 1 file changed, 11 insertions(+)\n>>\n>> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n>> index d9629e8f4798..2c8e6226d267 100644\n>> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n>> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n>> @@ -31,6 +31,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n>> #include \n>> #include \n>> #include \n>> @@ -1224,6 +1225,13 @@ static int cqspi_probe(struct platform_device *pdev)\n>> \t\treturn -ENXIO;\n>> \t}\n>> \n>> +\tpm_runtime_enable(&pdev->dev);\n>> +\tret = pm_runtime_get_sync(&pdev->dev);\n>> +\tif (ret < 0) {\n>> +\t\tpm_runtime_put_noidle(&pdev->dev);\n>> +\t\treturn ret;\n>> +\t}\n>> +\n>> \tret = clk_prepare_enable(cqspi->clk);\n>> \tif (ret) {\n>> \t\tdev_err(dev, \"Cannot enable QSPI clock.\\n\");\n>> @@ -1275,6 +1283,9 @@ static int cqspi_remove(struct platform_device *pdev)\n>> \n>> \tclk_disable_unprepare(cqspi->clk);\n>> \n>> +\tpm_runtime_put_sync(&pdev->dev);\n>> +\tpm_runtime_disable(&pdev->dev);\n>> +\n>> \treturn 0;\n>> }\n>> \n>>\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"GRpg81r9\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"FrtUls4n\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0SJg38LQz9sPs\n\tfor ;\n\tSun, 24 Sep 2017 23:10:59 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6gQ-0005mS-IQ; Sun, 24 Sep 2017 13:10:54 +0000","from fllnx209.ext.ti.com ([198.47.19.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6fs-00047I-T1; Sun, 24 Sep 2017 13:10:23 +0000","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8OD8ZqD000873; \n\tSun, 24 Sep 2017 08:08:35 -0500","from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8OD8Uf4008266; \n\tSun, 24 Sep 2017 08:08:30 -0500","from DLEE106.ent.ti.com (157.170.170.36) by DLEE100.ent.ti.com\n\t(157.170.170.30) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tSun, 24 Sep 2017 08:08:30 -0500","from dlep33.itg.ti.com (157.170.170.75) by DLEE106.ent.ti.com\n\t(157.170.170.36) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Sun, 24 Sep 2017 08:08:30 -0500","from [172.22.218.57] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8OD8Op7018225;\n\tSun, 24 Sep 2017 08:08:25 -0500"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=QpL5AVrff/DDYF1Cgq1LAnscLkpTrYqTb5BGU9JO/6M=;\n\tb=GRpg81r9XgtUVc\n\tjxcLoxbHA88VDoscBpIXi172h0JPxEJEEUID6KCCUYbu+UQNUpRFgBCfKOq4UOQl7Qjm1lfHJG+c0\n\tyIo++Vv6nES8FICdDcVsPJXCaW6zDZmBw37zc00Q0MVKAj5cBsYLYQ8h76qj05PvHrhNaBqsaL576\n\tM7Mp6mmXKTMXIPaVacDV3vu8ZX6/wuPdm57epx79yIPXc7IthE0KFzq0MpoSqa4cFjoWCz5b2xF7I\n\t36gLjPm0mHF8+WmxkOH6skTguufjdPOhR9Qp+6H1F+Cx7+gMUx8EMco9I6RND4BtUtsvRhfa2WquU\n\tan/uluTADFFjlnirr31g==;","v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506258515;\n\tbh=awk7ZFFBUO7M3Pfur1niddfdlV1zeWFvGhfus+VnrE8=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=FrtUls4nGw1YlkIX+6wd7sPLvmJLpZ+nBboG3IsT9yeFmKbNEISUTOHTv+LvnphZz\n\tkvHopk8XomIk/oyCp7jMeQkpElYo1d1D0SXaNtxYuz9beUnBrFXrt2OVZ4NKn+U3F4\n\tG9GSIlGXy6KuJEA0pPSior/89umzZZkdkh/DonCE="],"Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"Marek Vasut , Cyrille Pitchen\n\t","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>","From":"Vignesh R ","Message-ID":"<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>","Date":"Sun, 24 Sep 2017 18:38:23 +0530","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_061021_419390_0A0DF451 ","X-CRM114-Status":"GOOD ( 10.63 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.19.16 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774181,"web_url":"http://patchwork.ozlabs.org/comment/1774181/","msgid":"","list_archive_url":null,"date":"2017-09-24T13:12:37","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":1124,"url":"http://patchwork.ozlabs.org/api/people/1124/","name":"Marek Vasut","email":"marek.vasut@gmail.com"},"content":"On 09/24/2017 03:08 PM, Vignesh R wrote:\n> \n> \n> On 9/24/2017 5:31 PM, Marek Vasut wrote:\n>> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>>> Add pm_runtime* calls to cadence-quadspi driver. This is required to\n>>> switch on QSPI power domain on TI 66AK2G SoC during probe.\n>>>\n>>> Signed-off-by: Vignesh R \n>>\n>> Are you planning to add some more fine-grained PM control later?\n> \n> Yes, I will need to add fine-grained PM control at some point. But, for\n> now SoC does not really support low power mode or runtime power saving\n> option.\n> The fact that driver still uses clk_prepare_*() calls to enable/disable\n> clocks instead of pm_*() calls makes it a bit tricky though.\n> \n> Just figured out I forgot to add cleanup code in error handling path of\n> probe(). Will fix that and send a v4.\n\nOK, fine. Cleanups are welcome. The SoCFPGA doesn't do much runtime PM\neither, so it's fine for now.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"HhdV4p24\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fz6ka5JW\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0SMB5ncLz9sPs\n\tfor ;\n\tSun, 24 Sep 2017 23:13:10 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6iZ-0006mo-Fp; Sun, 24 Sep 2017 13:13:07 +0000","from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6iT-0006a1-BN; Sun, 24 Sep 2017 13:13:03 +0000","by mail-wr0-x243.google.com with SMTP id k20so2988412wre.1;\n\tSun, 24 Sep 2017 06:12:40 -0700 (PDT)","from [192.168.1.4] (ip-86-49-107-50.net.upcbroadband.cz.\n\t[86.49.107.50]) by smtp.gmail.com with ESMTPSA id\n\tf43sm9404003wra.79.2017.09.24.06.12.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Sep 2017 06:12:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=az6RDUwpuvufd2nq96C+gW9PuvXgPyuABce9uR01PVo=;\n\tb=HhdV4p248UV9I0\n\tSc4SpSrKA5UplkNHRj6mHgGl55so1D67LQOSmV1yKp4qs4lXXfOgkAo5+8G2zHvDT+zDxgBpg9Ivd\n\tZaI6qxoj6F4nGm+YxmIGwaRjbZzq9hz4/ZubMnUYc3Potlkur/OBS4SjGIScirh4yoeodQq4Kqzwp\n\tDag0EdITpN25+dBiqf479e7aWHOeioa5PyRiq6/tdfiJ0q4BoKTJ04D25DR2sQUJTkTwy1EW0L1G+\n\tiftSLLQewz/JFQM2mR0Ze9/Ds9hpXnQr6VBRVAHWnar7UPVlhDY6TpR8xEFXwP0fDnPs5LzB8xDNx\n\tTzgLKw4Z0xpduCkOdprw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=kmll9l4eAvYUwnIen3TWbsYuSMORrldpFD+hfGSzAsY=;\n\tb=fz6ka5JW4WCJWvkTaVSR+bjIZTuqfgozYRHQjZzx+yfgr2Rrk+Sybqpj+BiwQpT0ix\n\tHKA6KLrZg058l9+s2lSd8+PdJzwKUhpqh8CtWmJxIZuzlMgUPcLocniAC5dZ2MgLyCpu\n\tJhboloG7GBRrFTCRNgPxU75eUKDMpTMwALcuY+tRPzD4TXWn7y8iWubwhtdo5cJucuyl\n\tW0hI5/oS9tqU3Md0uCdHFjK8RKleL+d5FRYzmfkDIRm6jxh3Ui3JSxcz/VsVWXR/0y9c\n\truwwyPPg/mm136/LFaf4pF3PP92YWTuJ06ko7AG39QGKWg+HcEQqjQSRjZa5c4wK0lpM\n\tM36g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=kmll9l4eAvYUwnIen3TWbsYuSMORrldpFD+hfGSzAsY=;\n\tb=i0/AkJKxCHIaxRxhqSsT4pKMQVuMP4NivZo6Nas7PqGmyBZSHHiPG14QZrUOAiCJCf\n\t0Uw8NWxDgVxUnTfMr+81XI7Fmca2NzcGyspYhtTP0MH8i/hNhhag8V1b+pkGJUsQPQql\n\tmZ8sGnpM+0H5Wupj4SeZkHJ2cHcWwiE4FrTvj9gWl9rWRg7MY13TKa8dNNIJ9+TOaaeN\n\tirY14M/aAfLV0j0s5wFL7hS/PFcheEyGb1WjV/F4PHBz2Oco6/RAQMbu18KPk+wSzbTx\n\tlp9dI6Fn/zR9mqb6BMAuwgN5A6NyzD4xLbBXGpWYkFOAtzxRbOGopnZTDSnhOUwLshdz\n\t+ssw==","X-Gm-Message-State":"AHPjjUiK8n0vCwQyq18PlXyePxK9LKw6OAiXpRJxzSgvJ1PqbqCVV7iR\n\tS3pkmPZ11PA17i7ezedS0MhNe2w7","X-Google-Smtp-Source":"AOwi7QCUd5yPWnj1p6AjLk702on1A1wVgLzyK6hnqT1u0dESyQWhvmWxF2/hSoRlQ5HfXHN/f+y6hw==","X-Received":"by 10.223.195.108 with SMTP id e41mr3539544wrg.51.1506258758775; \n\tSun, 24 Sep 2017 06:12:38 -0700 (PDT)","Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"Vignesh R , Cyrille Pitchen ","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>","From":"Marek Vasut ","Message-ID":"","Date":"Sun, 24 Sep 2017 15:12:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_061301_646090_BE2C10D2 ","X-CRM114-Status":"GOOD ( 13.02 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (marek.vasut[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774184,"web_url":"http://patchwork.ozlabs.org/comment/1774184/","msgid":"","list_archive_url":null,"date":"2017-09-24T13:13:56","subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","submitter":{"id":1124,"url":"http://patchwork.ozlabs.org/api/people/1124/","name":"Marek Vasut","email":"marek.vasut@gmail.com"},"content":"On 09/24/2017 02:33 PM, Vignesh R wrote:\n> \n> \n> On 9/24/2017 5:29 PM, Marek Vasut wrote:\n>> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>>> As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access\n>>> Controller programming sequence, a delay equal to couple of QSPI master\n>>> clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and\n>>> writing data to the flash. Introduce a quirk flag CQSPI_NEEDS_WR_DELAY\n>>> to handle this and set this flag for TI 66AK2G SoC.\n>>>\n>>> [1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf\n>>>\n>>> Signed-off-by: Vignesh R \n>>\n>> Is this TI specific or is this controller property ? I wouldn't be\n>> surprised of the later ...\n> \n> I am not sure, there is no generic public documentation by cadence for\n> this IP. TI TRM clearly states this delay is required and I have\n> verified it practically that this delay is indeed needed.\n> But current user of this IP, socfpga does not seem to mention anything\n> about it. So, I guess its TI specific quirk.\n\nOK, let's go with that then. I didn't observe any stability issues with\nSoCFPGA, but I didn't run the flash at 100s of MHz either. At what kind\nof frequencies does the quirk become relevant ?\n\n>>\n>>> ---\n>>>\n>>> v3:\n>>> Fix build warnings reported by kbuild test bot.\n>>>\n>>> drivers/mtd/spi-nor/cadence-quadspi.c | 27 ++++++++++++++++++++++++++-\n>>> 1 file changed, 26 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n>>> index 53c7d8e0327a..5cd5d6f7303f 100644\n>>> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n>>> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n>>> @@ -38,6 +38,9 @@\n>>> #define CQSPI_NAME\t\t\t\"cadence-qspi\"\n>>> #define CQSPI_MAX_CHIPSELECT\t\t16\n>>> \n>>> +/* Quirks */\n>>> +#define CQSPI_NEEDS_WR_DELAY\t\tBIT(0)\n>>> +\n>>> struct cqspi_st;\n>>> \n>>> struct cqspi_flash_pdata {\n>>> @@ -76,6 +79,7 @@ struct cqspi_st {\n>>> \tu32\t\t\tfifo_depth;\n>>> \tu32\t\t\tfifo_width;\n>>> \tu32\t\t\ttrigger_address;\n>>> +\tu32\t\t\twr_delay;\n>>> \tstruct cqspi_flash_pdata f_pdata[CQSPI_MAX_CHIPSELECT];\n>>> };\n>>> \n>>> @@ -608,6 +612,15 @@ static int cqspi_indirect_write_execute(struct spi_nor *nor,\n>>> \treinit_completion(&cqspi->transfer_complete);\n>>> \twritel(CQSPI_REG_INDIRECTWR_START_MASK,\n>>> \t reg_base + CQSPI_REG_INDIRECTWR);\n>>> +\t/*\n>>> +\t * As per 66AK2G02 TRM SPRUHY8F section 11.15.5.3 Indirect Access\n>>> +\t * Controller programming sequence, couple of cycles of\n>>> +\t * QSPI_REF_CLK delay is required for the above bit to\n>>> +\t * be internally synchronized by the QSPI module. Provide 5\n>>> +\t * cycles of delay.\n>>> +\t */\n>>> +\tif (cqspi->wr_delay)\n>>> +\t\tndelay(cqspi->wr_delay);\n>>> \n>>> \twhile (remaining > 0) {\n>>> \t\twrite_bytes = remaining > page_size ? page_size : remaining;\n>>> @@ -1156,6 +1169,7 @@ static int cqspi_probe(struct platform_device *pdev)\n>>> \tstruct cqspi_st *cqspi;\n>>> \tstruct resource *res;\n>>> \tstruct resource *res_ahb;\n>>> +\tunsigned long data;\n>>> \tint ret;\n>>> \tint irq;\n>>> \n>>> @@ -1213,6 +1227,10 @@ static int cqspi_probe(struct platform_device *pdev)\n>>> \t}\n>>> \n>>> \tcqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);\n>>> +\tdata = (unsigned long)of_device_get_match_data(dev);\n>>> +\tif (data & CQSPI_NEEDS_WR_DELAY)\n>>> +\t\tcqspi->wr_delay = 5 * DIV_ROUND_UP(NSEC_PER_SEC,\n>>> +\t\t\t\t\t\t cqspi->master_ref_clk_hz);\n>>> \n>>> \tret = devm_request_irq(dev, irq, cqspi_irq_handler, 0,\n>>> \t\t\t pdev->name, cqspi);\n>>> @@ -1284,7 +1302,14 @@ static const struct dev_pm_ops cqspi__dev_pm_ops = {\n>>> #endif\n>>> \n>>> static const struct of_device_id cqspi_dt_ids[] = {\n>>> -\t{.compatible = \"cdns,qspi-nor\",},\n>>> +\t{\n>>> +\t\t.compatible = \"cdns,qspi-nor\",\n>>> +\t\t.data = (void *)0,\n>>> +\t},\n>>> +\t{\n>>> +\t\t.compatible = \"ti,k2g-qspi\",\n>>> +\t\t.data = (void *)CQSPI_NEEDS_WR_DELAY,\n>>> +\t},\n>>> \t{ /* end of table */ }\n>>> };\n>>> \n>>>\n>>\n>>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"FtUbon7Z\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DY+4UlnT\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0SP12pssz9sRV\n\tfor ;\n\tSun, 24 Sep 2017 23:14:45 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6k5-0007dZ-5e; Sun, 24 Sep 2017 13:14:41 +0000","from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6jk-0007No-5w; Sun, 24 Sep 2017 13:14:35 +0000","by mail-wm0-x244.google.com with SMTP id r136so4976152wmf.3;\n\tSun, 24 Sep 2017 06:13:59 -0700 (PDT)","from [192.168.1.4] (ip-86-49-107-50.net.upcbroadband.cz.\n\t[86.49.107.50]) by smtp.gmail.com with ESMTPSA id\n\t110sm2051204wra.39.2017.09.24.06.13.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Sep 2017 06:13:57 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=6YFC0hNSkWY24qc8P+FLNLihmTNdRAn6CNUbnpicOt4=;\n\tb=FtUbon7ZXDbavE\n\tJ/8JJtTaZe1qBmG7KSeeeKiaczHEqlXqehh6d0/uyZYsUqblb6/kQaRM6xwQMN/JpmgTrd1IGwnQz\n\tOxNmfyidDf/4gerwMikDW4MJBHf0auxD46uarl92LGYB5jktUczwFJevLhB7iDTU0+Wi1msxrRmJw\n\t2zzAgLTdSwrqnJfUpgooVP3VfjlIWjboW3k1gHG0v9p2mSO5PMXmlooRgNOGzaK9bqzXlyunVDxaA\n\tP+q/uKn2vkj29f5eVO6agDZS9ZE5couyn56Lx3K3tJW8D4AG7WSDEh7HSyvvSvEgTisJkv0DcpV0p\n\t1ZreKRY7Byd013MrQzQg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=/tF8OYxwbrn+JBs7FiSnF7t/PANt196Fhl1ETym3L1Q=;\n\tb=DY+4UlnTmZ3MpfLyptnfUkkAtvw62jQfFcsaeOHbGyICc1XaG+6ctRj++5uYKWuLut\n\tAI0jBQdUjKZxcmnEBbGcQn5v/lEpizofxp7za8Mma/BQ9roRoC7MWgsygF3KozB6XuDv\n\tHrvWxdBweMVaeU1PmtM+ALxOpBXw2/eFMIp1r/it9XKwdSvRd7VZApKwzgFPrf+aiv8V\n\tacCA5LGbpdbtxeTmxwAx0v1l/euXXnWCMpW/ZHaXpjQkG+KaTi7hxtcmonrOfoeSVhc9\n\tTxSfVU4UjWVhinxg0F1mjctEpw0V+V7SsGQu5eyZVJrD6qWqOyXLiIT6p0RSkTY1USB0\n\tnuzQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=/tF8OYxwbrn+JBs7FiSnF7t/PANt196Fhl1ETym3L1Q=;\n\tb=TtuV+xDP0f1c7aJ57EU0nwKUNCPbH60s0RShJWZRZuSzycs3rHSuQ6Rdnr9zSKw+k1\n\tjyWdrZWfP+ycrDJc4vRBtkIzPpzg3zNAAOkQ2oA4dJVroOWrLcHdSyaQyTEV1OKqPyEr\n\tR39NnOzry2enaFa2lKsMm5SJLXsy5QHtDqKekQu9jODpr/Zzvc/FoqzPymCZhm0uUJyv\n\t79d9oOCb64M1PIVHo4K0NASphe76jKgXqCQx5klKObLmTExkq7L2dyYDPj9JJpnaWTSu\n\toUzNqCHEU/aaT9vDE7ZnJX4cNMcaoQTqlNs7WORrYt9m6Ftba4lNIccioUyaCqPK8hlf\n\tQtjw==","X-Gm-Message-State":"AHPjjUgAzVxx624E35uNbU0nvaIHFaNfAnFn3xtbUbPgxa5We3TSiNRC\n\tPe8CWpBUqJbzrRpHVMfryLFrocIf","X-Google-Smtp-Source":"AOwi7QB1jBcv+PoFv8BHllzmk1Xm3wcnc0YnOVJoMd5z4MEUx3uCZwvkOM+/qUTVn/EUq/4F8TS3IQ==","X-Received":"by 10.28.135.209 with SMTP id j200mr7458074wmd.40.1506258837725; \n\tSun, 24 Sep 2017 06:13:57 -0700 (PDT)","Subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","To":"Vignesh R , Cyrille Pitchen ","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-3-vigneshr@ti.com>\n\t<94313cae-4805-0b13-a469-72aa7556b685@gmail.com>\n\t<8990b971-91d5-747f-905b-5e24743e090d@ti.com>","From":"Marek Vasut ","Message-ID":"","Date":"Sun, 24 Sep 2017 15:13:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<8990b971-91d5-747f-905b-5e24743e090d@ti.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_061420_677765_F192154E ","X-CRM114-Status":"GOOD ( 18.85 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (marek.vasut[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774189,"web_url":"http://patchwork.ozlabs.org/comment/1774189/","msgid":"<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>","list_archive_url":null,"date":"2017-09-24T13:27:30","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":65039,"url":"http://patchwork.ozlabs.org/api/people/65039/","name":"Raghavendra, Vignesh","email":"vigneshr@ti.com"},"content":"On 9/24/2017 6:42 PM, Marek Vasut wrote:\n> On 09/24/2017 03:08 PM, Vignesh R wrote:\n>>\n>>\n>> On 9/24/2017 5:31 PM, Marek Vasut wrote:\n>>> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>>>> Add pm_runtime* calls to cadence-quadspi driver. This is required to\n>>>> switch on QSPI power domain on TI 66AK2G SoC during probe.\n>>>>\n>>>> Signed-off-by: Vignesh R \n>>>\n>>> Are you planning to add some more fine-grained PM control later?\n>>\n>> Yes, I will need to add fine-grained PM control at some point. But, for\n>> now SoC does not really support low power mode or runtime power saving\n>> option.\n>> The fact that driver still uses clk_prepare_*() calls to enable/disable\n>> clocks instead of pm_*() calls makes it a bit tricky though.\n>>\n>> Just figured out I forgot to add cleanup code in error handling path of\n>> probe(). Will fix that and send a v4.\n> \n> OK, fine. Cleanups are welcome. The SoCFPGA doesn't do much runtime PM\n> either, so it's fine for now.\n> \n\nOk thanks! Do you know if pm_runtime_get_sync() can enable clocks for\nQSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see\nif its possible to get rid of clk_*() calls in favor of pm_*() calls.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"aJqgLDw2\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"wCnYb//M\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0Sjs3NfKz9sBd\n\tfor ;\n\tSun, 24 Sep 2017 23:29:21 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6yC-0001PT-Od; Sun, 24 Sep 2017 13:29:16 +0000","from lelnx194.ext.ti.com ([198.47.27.80])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw6xO-0000wP-0m; Sun, 24 Sep 2017 13:28:28 +0000","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8ODRakU004576; \n\tSun, 24 Sep 2017 08:27:36 -0500","from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8ODRaw3015498;\n\tSun, 24 Sep 2017 08:27:36 -0500","from DFLE102.ent.ti.com (10.64.6.23) by DFLE112.ent.ti.com\n\t(10.64.6.33) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tSun, 24 Sep 2017 08:27:36 -0500","from dlep32.itg.ti.com (157.170.170.100) by DFLE102.ent.ti.com\n\t(10.64.6.23) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Sun, 24 Sep 2017 08:27:36 -0500","from [172.22.218.57] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8ODRVCm018249;\n\tSun, 24 Sep 2017 08:27:32 -0500"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=zu0IdyrQMf/th7Jx2qh4qSwh8LFxh5VLnYd8zk5xlAk=;\n\tb=aJqgLDw2/ToWa3\n\t1P3JMPaiyxWMW8hFIqMThKCbNpjqN4WkYTnbiKjqQii1+S1h3zjWTyhecE57bEs9UIZlTycFFgrm5\n\tL5msJ6FrDKy4IHEfZsyYjQTaoGM5cFLkWLRLi+hm2r3Otw1uKVoTy8nAScmFi6YoZrxXjWs9jx0QZ\n\tPIxxj/RYxHP9VNZUwzEEsuhOGELP0wEYjGq0kQp4X3UKV2pzj7vI534FofIgpsKpue4PviGp+PLgL\n\tpwEu/ABnkl1BzFXgAruimW8RhHEvQg97saNiz88tEQA6URnRtdvpyhb9fDtQkXPsRvaneFKdCV/Xz\n\tW17ITJsvD0tM+Fi8AY8w==;","v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506259656;\n\tbh=6cTk15AFBdDOnLJfVCJvqBics3ytgMCy13z2Zyqs0oI=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=wCnYb//MdN4kROW8vPg+m/Id/6/vx3iXfYZQfdmNpM7bPnjqaPLxUfKUHqZzcnXCi\n\t//72kbwQLTQycWuXZIUGykvTO9h34LQxN30gbp8yA3LQPWVcnQn53UKz+MKbEJZRGP\n\tx8gS3LEFoNcP+FIqhUxR5nImTz2VdGaxNglBLd0o="],"Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"Marek Vasut , Cyrille Pitchen\n\t","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>\n\t","From":"Vignesh R ","Message-ID":"<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>","Date":"Sun, 24 Sep 2017 18:57:30 +0530","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_062826_265955_1181F96B ","X-CRM114-Status":"UNSURE ( 8.29 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.27.80 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774197,"web_url":"http://patchwork.ozlabs.org/comment/1774197/","msgid":"","list_archive_url":null,"date":"2017-09-24T13:51:55","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":1124,"url":"http://patchwork.ozlabs.org/api/people/1124/","name":"Marek Vasut","email":"marek.vasut@gmail.com"},"content":"On 09/24/2017 03:27 PM, Vignesh R wrote:\n> \n> \n> On 9/24/2017 6:42 PM, Marek Vasut wrote:\n>> On 09/24/2017 03:08 PM, Vignesh R wrote:\n>>>\n>>>\n>>> On 9/24/2017 5:31 PM, Marek Vasut wrote:\n>>>> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>>>>> Add pm_runtime* calls to cadence-quadspi driver. This is required to\n>>>>> switch on QSPI power domain on TI 66AK2G SoC during probe.\n>>>>>\n>>>>> Signed-off-by: Vignesh R \n>>>>\n>>>> Are you planning to add some more fine-grained PM control later?\n>>>\n>>> Yes, I will need to add fine-grained PM control at some point. But, for\n>>> now SoC does not really support low power mode or runtime power saving\n>>> option.\n>>> The fact that driver still uses clk_prepare_*() calls to enable/disable\n>>> clocks instead of pm_*() calls makes it a bit tricky though.\n>>>\n>>> Just figured out I forgot to add cleanup code in error handling path of\n>>> probe(). Will fix that and send a v4.\n>>\n>> OK, fine. Cleanups are welcome. The SoCFPGA doesn't do much runtime PM\n>> either, so it's fine for now.\n>>\n> \n> Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for\n> QSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see\n> if its possible to get rid of clk_*() calls in favor of pm_*() calls.\n\nNot of the top of my head, sorry. +CC Matthew, he should know.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"GeOl+z5T\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"pqU7tp/g\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0TDb5Bldz9sNV\n\tfor ;\n\tSun, 24 Sep 2017 23:52:31 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw7Kb-0007Xo-J9; Sun, 24 Sep 2017 13:52:25 +0000","from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw7KU-0007Lg-Kx; Sun, 24 Sep 2017 13:52:20 +0000","by mail-wm0-x242.google.com with SMTP id x17so5015429wmd.5;\n\tSun, 24 Sep 2017 06:51:57 -0700 (PDT)","from [192.168.1.4] (ip-86-49-107-50.net.upcbroadband.cz.\n\t[86.49.107.50]) by smtp.gmail.com with ESMTPSA id\n\tj37sm2746950ede.12.2017.09.24.06.51.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Sep 2017 06:51:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=M1Z30xv/KmgzVQ+DVV+qfl1iKm+FsxzZndX4ARJnMMI=;\n\tb=GeOl+z5TXQb3Q4\n\tiYGkMMk8ySyWUSYAVQBmtnaumSGktYPD2+Ap2G++HC6K7PaXl4RiD8uI+Zc/PMuUDiYlBa7ZBe9B+\n\tEN2lFIWLaIE5+wl743d4fi8eKyT46ipM8GZKuBSqM8sx3gYmjLrUAZGY9LVN8WTOUchgIEziCRfHS\n\tQn2YHInu0RjqU7Iw6YEiRToColyTtFlENRAa7zlMhNaLDR2ebUNUfthSQ8x4hywzoYn6bISnkHtZB\n\tAseqDGk4tiJmmwQkbiarVRbehcE1FdsVrg3ikdSRIRYUPqrOAI0TZQJ2k3LUGt9rWXkU21Y3YZGbs\n\tOmGKr5D1vDUEVFIBl0cQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=bWB7h9iiqY0o4SKohwuBxDQXlhVkJMxQbYSEXhkUv/8=;\n\tb=pqU7tp/g/P8NADUkdvTWkxGt2ztldyxQK3aO8TfCUGC08gFD1gW1MMi0mG0LkHNc3s\n\tZKzJ2irpQeO9zktupPhbpVAmKhllCbJ4DxYe97Rx2tmlWboUwk4sWPzcCvVBdr5ubXmK\n\tYu1HsMLRLtzbSJmq5jC3eMqFl07JOJ8ozG3zdezGKuCN8e3MqlIP/y/rHg5COzdMe4DL\n\ttvSQUFuDNsf+V2bTLH6jXeEAx1YrSQpxzoEufRdnOD4N9+Jcu+aysXbgJbaOdhmzyiB2\n\t12fj/Zc/QBuo06ZV6UwFTD57Nx+MAiXP43rNmPXG+HN1XwN0hu/BaKPtpapP3M4Nk2zg\n\tS4Ag=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=bWB7h9iiqY0o4SKohwuBxDQXlhVkJMxQbYSEXhkUv/8=;\n\tb=jD9BZ1KnbC3eWMSGewaAahERLCOgqb9I0uDFUqs+cWHRCLDFdIUEbrMmcJ+9rqJnDa\n\tFo596b9rDSdslFEn6ZBOf5Zgff5y1xGhbq1wRjSby6OxW8WDppjiJy3ndy3rvBFmv9Tg\n\tMTloCNtreoxiKpvpczJtTzgCA1rCu5LK5T8d8JuK4yAvH7kpzaku+47or8bLxAE8tF9M\n\t9u5LL/eF3cpX1Hl6tOzmisGD8n37zhDAz69AX2W/fJrULRiL2vDTg9uBelwRmK7j4wzV\n\tG6LEyn+p+j9+wFsb6EtP3BbF0MCBA8dm2TQD+h5RCOQLOeVQBWBPfUbbUCVk2D8r0OFa\n\t7Eog==","X-Gm-Message-State":"AHPjjUiQv9TbgbV0T7V1qT5NkJ5N62S9K3yA2vtY7n8BIynRRhyI+C/G\n\tczhwkYmRRcFduZC8ECDIDcQ=","X-Google-Smtp-Source":"AOwi7QDjPxvB79rccrzjuCMm0oUu8ygeHFPRb6dPt5T2qzIACbGrqJb4+Ap6mr07r1uErUZczBkzmw==","X-Received":"by 10.80.162.70 with SMTP id 64mr11361317edl.179.1506261116497; \n\tSun, 24 Sep 2017 06:51:56 -0700 (PDT)","Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"Vignesh R , Cyrille Pitchen ","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>\n\t\n\t<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>","From":"Marek Vasut ","Message-ID":"","Date":"Sun, 24 Sep 2017 15:51:55 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_065218_946625_18A0B9FE ","X-CRM114-Status":"GOOD ( 13.05 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (marek.vasut[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tmatthew.gerlach@linux.intel.com,\n\tBrian Norris , \n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1775007,"web_url":"http://patchwork.ozlabs.org/comment/1775007/","msgid":"","list_archive_url":null,"date":"2017-09-25T22:41:40","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":70992,"url":"http://patchwork.ozlabs.org/api/people/70992/","name":"Matthew Gerlach","email":"matthew.gerlach@linux.intel.com"},"content":"On Sun, 24 Sep 2017, Marek Vasut wrote:\n\n> On 09/24/2017 03:27 PM, Vignesh R wrote:\n>>\n>>\n>> On 9/24/2017 6:42 PM, Marek Vasut wrote:\n>>> On 09/24/2017 03:08 PM, Vignesh R wrote:\n>>>>\n>>>>\n>>>> On 9/24/2017 5:31 PM, Marek Vasut wrote:\n>>>>> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>>>>>> Add pm_runtime* calls to cadence-quadspi driver. This is required to\n>>>>>> switch on QSPI power domain on TI 66AK2G SoC during probe.\n>>>>>>\n>>>>>> Signed-off-by: Vignesh R \n>>>>>\n>>>>> Are you planning to add some more fine-grained PM control later?\n>>>>\n>>>> Yes, I will need to add fine-grained PM control at some point. But, for\n>>>> now SoC does not really support low power mode or runtime power saving\n>>>> option.\n>>>> The fact that driver still uses clk_prepare_*() calls to enable/disable\n>>>> clocks instead of pm_*() calls makes it a bit tricky though.\n>>>>\n>>>> Just figured out I forgot to add cleanup code in error handling path of\n>>>> probe(). Will fix that and send a v4.\n>>>\n>>> OK, fine. Cleanups are welcome. The SoCFPGA doesn't do much runtime PM\n>>> either, so it's fine for now.\n>>>\n>>\n>> Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for\n>> QSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see\n>> if its possible to get rid of clk_*() calls in favor of pm_*() calls.\n>\n> Not of the top of my head, sorry. +CC Matthew, he should know.\n\nI am not an expert at the clock framework nor the power management, but I\ndid ask around a bit. No one I asked was planning to change the clk_*()\ncalls to pm_*() call, but the feedback was that it would be a good idea.\n\nMatthew Gerlach\n\n\n>\n> -- \n> Best regards,\n> Marek Vasut\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"nmQp5BlC\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Jxk1dgcz9t3F\n\tfor ;\n\tTue, 26 Sep 2017 08:42:34 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwc58-0007p2-IP; Mon, 25 Sep 2017 22:42:30 +0000","from mga03.intel.com ([134.134.136.65])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwc4o-0007WM-1r; Mon, 25 Sep 2017 22:42:11 +0000","from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Sep 2017 15:41:43 -0700","from mgerlach-mobl.amr.corp.intel.com (HELO [10.0.2.15])\n\t([10.255.79.44])\n\tby orsmga005.jf.intel.com with ESMTP; 25 Sep 2017 15:41:42 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To:\n\tSubject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=8C6LN9npwlcIh+iFW+/ZzDhfaPYHcW1wiRdzwDxchws=;\n\tb=nmQp5BlCofAB1ZBoyw2zF0MWY\n\teA1GJXVmBnI3nSODTI6CT2N2iRIhS2TCNeBJUyGkBfElnApe0wmvoURHRHxz4+M1p3OWCvUQTxxUk\n\thz+DNlWlEHDEfAMShvcMSEHBSS3HALvD7+kHlyqP6OGfKzawKx4EaGeNUtNrFyskOzhI79m//BJCN\n\tstxZFecMVye+pPFh8EiRaGcG4UDREbp+jNYoYJLpKI53SxpnBRDDkZRjluix6MysRRCnZ0K4h+kF+\n\teJtQckSY4q74mFjbdZ1G+z/OtI13fWYjP3HAsisvjXW9cnQQtRdf3NXfZX47oh6ft39HFKiP+D4oA\n\tfN68tV62Q==;","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,437,1500966000\"; d=\"scan'208\";a=\"153240557\"","Date":"Mon, 25 Sep 2017 15:41:40 -0700 (PDT)","From":"matthew.gerlach@linux.intel.com","X-X-Sender":"mgerlach@mgerlach-VirtualBox","To":"Marek Vasut ","Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","In-Reply-To":"","Message-ID":"","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>\n\t\n\t<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>\n\t","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170925_154210_192151_37372B3C ","X-CRM114-Status":"GOOD ( 13.04 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [134.134.136.65 listed in list.dnswl.org]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tVignesh R , devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Rob Herring ,\n\tlinux-mtd@lists.infradead.org,\n\tCyrille Pitchen , \n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1775051,"web_url":"http://patchwork.ozlabs.org/comment/1775051/","msgid":"","list_archive_url":null,"date":"2017-09-25T23:49:46","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":1124,"url":"http://patchwork.ozlabs.org/api/people/1124/","name":"Marek Vasut","email":"marek.vasut@gmail.com"},"content":"On 09/26/2017 12:41 AM, matthew.gerlach@linux.intel.com wrote:\n> \n> \n> On Sun, 24 Sep 2017, Marek Vasut wrote:\n> \n>> On 09/24/2017 03:27 PM, Vignesh R wrote:\n>>>\n>>>\n>>> On 9/24/2017 6:42 PM, Marek Vasut wrote:\n>>>> On 09/24/2017 03:08 PM, Vignesh R wrote:\n>>>>>\n>>>>>\n>>>>> On 9/24/2017 5:31 PM, Marek Vasut wrote:\n>>>>>> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>>>>>>> Add pm_runtime* calls to cadence-quadspi driver. This is required to\n>>>>>>> switch on QSPI power domain on TI 66AK2G SoC during probe.\n>>>>>>>\n>>>>>>> Signed-off-by: Vignesh R \n>>>>>>\n>>>>>> Are you planning to add some more fine-grained PM control later?\n>>>>>\n>>>>> Yes, I will need to add fine-grained PM control at some point. But,\n>>>>> for\n>>>>> now SoC does not really support low power mode or runtime power saving\n>>>>> option.\n>>>>> The fact that driver still uses clk_prepare_*() calls to\n>>>>> enable/disable\n>>>>> clocks instead of pm_*() calls makes it a bit tricky though.\n>>>>>\n>>>>> Just figured out I forgot to add cleanup code in error handling\n>>>>> path of\n>>>>> probe(). Will fix that and send a v4.\n>>>>\n>>>> OK, fine. Cleanups are welcome. The SoCFPGA doesn't do much runtime PM\n>>>> either, so it's fine for now.\n>>>>\n>>>\n>>> Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for\n>>> QSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see\n>>> if its possible to get rid of clk_*() calls in favor of pm_*() calls.\n>>\n>> Not of the top of my head, sorry. +CC Matthew, he should know.\n> \n> I am not an expert at the clock framework nor the power management, but I\n> did ask around a bit.  No one I asked was planning to change the clk_*()\n> calls to pm_*() call, but the feedback was that it would be a good idea.\n\nThe question is, if we do the replacement, will it break on socfpga ?\nA quick test might be useful.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"HkgxtyVs\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"a21DzvEi\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1LRv5XXCz9t2S\n\tfor ;\n\tTue, 26 Sep 2017 09:50:19 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwd8h-0003jp-UJ; Mon, 25 Sep 2017 23:50:15 +0000","from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwd8c-0002KD-Jg; Mon, 25 Sep 2017 23:50:13 +0000","by mail-wm0-x244.google.com with SMTP id i131so8115023wma.1;\n\tMon, 25 Sep 2017 16:49:49 -0700 (PDT)","from [192.168.1.4] (ip-86-49-107-50.net.upcbroadband.cz.\n\t[86.49.107.50]) by smtp.gmail.com with ESMTPSA id\n\tf84sm408781wme.44.2017.09.25.16.49.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 16:49:47 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=9bMCQ6ORl0rWREiUtwb8M/f/OfIxM85bAAdfhfKjki4=;\n\tb=HkgxtyVsehcmur\n\tqyNSy/idXusmc5fUirhEazi8izAU4uc1d66poy86me4wcmdn1xcP1RLXaaVX0FCbIQMoHvMNApZI6\n\tDrEzPJIgnRVNv+pbdDawJrrAJLUW9CuLdyWl3K7FA7G7MoEa44z6NPFLzr9ZqkgOg0ZPCcZtG1p4b\n\tIJG46f4y6nArcsiGmqxwQya6eK4HxYmkXnTKaR43Ci6pyTgtsDHWArchkw5+U7V4ws8XsPiKaIuKm\n\tLy/NdmjF+KMQUGsx2HhtJp7HshXIMflS/Ph4p43aPiwK0yY1Zc7qLcH3IBYXsGLgzNfp+KP5P2xdx\n\t35cF8OfYMWp0/rnBvKIw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=fD4zY70KX9+5mozmVRAg78XUXN+YPTiO9FdZDSjX1ys=;\n\tb=a21DzvEiL/PPjtPM1jjZtyuWKh8CKN+2MX4TP946WxayvOMCf6Atw5f+hpsn4pp7Ia\n\t/ou49E2aFgY5Q4kFdLAjHF14dz2nT9lnAupLjtJ2d2uqwERQenZpRniCoJFFXM9Bchbx\n\tyhEnIMw1Cax8fsye52deES4Fuv7iHxuyFDZZCzJEW5jQsfuQhLdtUeK+AvHw8bygq9aF\n\tvvPfquYsdRaaEefsE9u2WKSMkS3uXI5MJ0AE2gH2ad5TkfANnDfw/Zl4E2eVDxdz6ndO\n\toBiw0wgG4HjS8uWSQZc504IWUkyREkx2KWoe9kAadrStAY23ZE+ujhxaYfDx1Kgoug+g\n\t3MJw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=fD4zY70KX9+5mozmVRAg78XUXN+YPTiO9FdZDSjX1ys=;\n\tb=DJfY/Np4ZSCUleB56u+SE5YbcFu17HaWa26WNENd9e5VZFrSaVL8YgSjelKRkmw3YT\n\tgIcDZez5NnTUj8mxjkZu+yW6ZmNWw9pFUBGM238Mtp0V87Ket+/OsGyw6qGkjpZdQb8N\n\t84CxYzfE9bqyAnMCAyLj3jwgM3c6wevJmkbHWLUzio4YANDqbtkIehFIrbvy7D17gtzB\n\tBEVF3oZwFZeUB2xeVcYFDnMHFEElvND7v0amOXjJJV651ASRYQ4E8zrr1urDuLF92BLl\n\t60PqGHFjN2JulMjswET0WCODBUohG8jV77mTpS0FnaGIwRTMW0if79YN4LWYsj6+/oLk\n\t5Geg==","X-Gm-Message-State":"AHPjjUhYAoujEzYAOJcbSFXgEX2tdu3mO/hJiYLJ2ZXe9alo3Za24URe\n\tseQM60f2ocfTGoOwW8PHvdL15H5Q","X-Google-Smtp-Source":"AOwi7QAY4K0fnwdEzCNtEbunxIUGo+3ct5X7Bc9e4QkYR5prflXQ00/qNtITRrTl7J3b1foRA1LOvg==","X-Received":"by 10.28.215.132 with SMTP id o126mr1573921wmg.50.1506383388054; \n\tMon, 25 Sep 2017 16:49:48 -0700 (PDT)","Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"matthew.gerlach@linux.intel.com","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>\n\t\n\t<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>\n\t\n\t","From":"Marek Vasut ","Message-ID":"","Date":"Tue, 26 Sep 2017 01:49:46 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170925_165010_909654_BA0E0A58 ","X-CRM114-Status":"GOOD ( 15.42 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c09:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (marek.vasut[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tVignesh R , devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Rob Herring ,\n\tlinux-mtd@lists.infradead.org,\n\tCyrille Pitchen , \n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1776242,"web_url":"http://patchwork.ozlabs.org/comment/1776242/","msgid":"<7237fa9e-4d3a-8a82-10c6-76737c23ed6f@ti.com>","list_archive_url":null,"date":"2017-09-27T10:48:49","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":65039,"url":"http://patchwork.ozlabs.org/api/people/65039/","name":"Raghavendra, Vignesh","email":"vigneshr@ti.com"},"content":"Hi Matthew,\n\nOn Tuesday 26 September 2017 05:19 AM, Marek Vasut wrote:\n[...]\n>>>> Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for\n>>>> QSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see\n>>>> if its possible to get rid of clk_*() calls in favor of pm_*() calls.\n>>>\n>>> Not of the top of my head, sorry. +CC Matthew, he should know.\n>>\n>> I am not an expert at the clock framework nor the power management, but I\n>> did ask around a bit.  No one I asked was planning to change the clk_*()\n>> calls to pm_*() call, but the feedback was that it would be a good idea.\n> \n> The question is, if we do the replacement, will it break on socfpga ?\n> A quick test might be useful.\n> \n\nyes, a quick qspi test with clk_prepare_enable() replaced by pm_*() calls\nlike below patch would be helpful:\n\n\ndiff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\nindex 53c7d8e0327a..7ad3e176cc88 100644\n--- a/drivers/mtd/spi-nor/cadence-quadspi.c\n+++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n@@ -34,6 +34,7 @@\n #include \n #include \n #include \n+#include \n \n #define CQSPI_NAME \"cadence-qspi\"\n #define CQSPI_MAX_CHIPSELECT 16\n@@ -1206,11 +1207,8 @@ static int cqspi_probe(struct platform_device *pdev)\n return -ENXIO;\n }\n \n- ret = clk_prepare_enable(cqspi->clk);\n- if (ret) {\n- dev_err(dev, \"Cannot enable QSPI clock.\\n\");\n- return ret;\n- }\n+ pm_runtime_enable(dev);\n+ pm_runtime_get_sync(dev);\n \n cqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"NtTrE/Ok\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"Y8YmvFqr\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"EIl/unEa\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2F2r5bnlz9tXT\n\tfor ;\n\tWed, 27 Sep 2017 20:50:12 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx9ur-0006tJ-EB; Wed, 27 Sep 2017 10:50:09 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx9uW-0006GB-Mc; Wed, 27 Sep 2017 10:49:48 +0000","from lelnx193.ext.ti.com ([198.47.27.77])\n\tby merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx9uT-00039d-3Z; Wed, 27 Sep 2017 10:49:46 +0000","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8RAmX3d023885; \n\tWed, 27 Sep 2017 05:48:33 -0500","from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8RAmXfa018150;\n\tWed, 27 Sep 2017 05:48:33 -0500","from DFLE112.ent.ti.com (10.64.6.33) by DFLE115.ent.ti.com\n\t(10.64.6.36) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tWed, 27 Sep 2017 05:48:32 -0500","from dflp33.itg.ti.com (10.64.6.16) by DFLE112.ent.ti.com\n\t(10.64.6.33) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Wed, 27 Sep 2017 05:48:32 -0500","from [172.24.190.89] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8RAmTn6029842;\n\tWed, 27 Sep 2017 05:48:29 -0500"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=94yhRh9wmZVUrY2x1xr8z0cQBNTFiLpGtszqO80VtBs=;\n\tb=NtTrE/OkhHCu4O\n\t3XAJ7V5kW9g4XpYxwnaLa42I+HsswGDDd2XxQ8PKCgo7xctn4gKWk3f9mWdL13s5xA8KCcOr2d6vJ\n\tSwSCNTx2AfyLXZOJpgJ6jpvSbv6WlvFuLBgN5naQxi7nkrovSuwoTycUEglwb0849C1Kq3vZEZprS\n\tpZlwm09lTfenHvMARScfDxLCQ5iMhUjU0YvIxoFrR8hIU1QBD8v9BFV0BLrEVThi2ALgFkplLfzIY\n\tUohwoZWLzTaOgf9kUzicfua025Vgr0qBe3yjN0iQZNHifrYmeGterEQV6FaffEkxzZbnX63PkbbEi\n\tbPTPJr5E1IAqQjTBJR7A==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209;\n\th=Content-Transfer-Encoding:Content-Type:\n\tIn-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender\n\t:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:\n\tList-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=6czuppOalM+RmDGK5nc82693U7siJQzTDan7Q6oQt90=;\n\tb=Y8YmvFqrtM3XkB0Rig45UdRr/s\n\taNvNcBxoeKBPxkrd5jIj2iCbZZ1HyxqvtVEJgvDPJ6qSMwBG91l+pMe6ZAFP2HVncJ9u8py+tyYaE\n\tQlEa2OyHM7g2Bd9KeLI3YTtvnZSyEg7PqPzuug8ebYaq0oB9Q8RNjOj+jhikuqF7KNPdT0+eP+p8w\n\tNTJQDWkjFimTB2SxW4QREvRdlVpTeYAay9KHw3RTf2NQNDGU0p6wbZHJUp/1qPyovtGkoHyr2rPN3\n\tleypoKziDCuD0SHmZRo0LcXq5AREMJgyoNT8y2k4CLAHtefJ8VxVNL/9/R4T7eZbZ9xesh5xyh2TI\n\tRFs5y8Eg==;","v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506509313;\n\tbh=B+9nrdr8qCu+lcyG/nMaLsmUpq7Bovm1cYhNOSEG39A=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=EIl/unEaK9839aquQ8jqRfua1tcTPybK7mnDXqTCpxAqgkuvBh31i8OnWvOAAxBWH\n\tVn8fjVnEueYz2xBG+FbV/E8zup0fFK+Gfz/z9rewF6PxFcF6f/INVF/M8V9CgsFj/J\n\tRXztoBU7IaHOBcrQ74D2d2bhZEnxp+npmZDRoCvk="],"Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>\n\t\n\t<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>\n\t\n\t\n\t","From":"Vignesh R ","Message-ID":"<7237fa9e-4d3a-8a82-10c6-76737c23ed6f@ti.com>","Date":"Wed, 27 Sep 2017 16:18:49 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.27.77 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tMarek Vasut , Rob Herring ,\n\tlinux-mtd@lists.infradead.org,\n\tCyrille Pitchen , \n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1777087,"web_url":"http://patchwork.ozlabs.org/comment/1777087/","msgid":"","list_archive_url":null,"date":"2017-09-28T15:01:36","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":70992,"url":"http://patchwork.ozlabs.org/api/people/70992/","name":"Matthew Gerlach","email":"matthew.gerlach@linux.intel.com"},"content":"Hi Vignesh,\n\nI tried this patch on an Arria10 SOCFPGA devkit against the 4.1.33-ltsi \nkernel, and it did not go well. Commands to the flash chip timedout \nresulting in the probe function failing. I ran into other problems, not \nrelated to cadence-quadspi, that prevented me from testing against 4.9 and \n4.12 kernels, but I suspect similar behavior.\n\nMatthew Gerlach\n\nOn Wed, 27 Sep 2017, Vignesh R wrote:\n\n> Hi Matthew,\n>\n> On Tuesday 26 September 2017 05:19 AM, Marek Vasut wrote:\n> [...]\n>>>>> Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for\n>>>>> QSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see\n>>>>> if its possible to get rid of clk_*() calls in favor of pm_*() calls.\n>>>>\n>>>> Not of the top of my head, sorry. +CC Matthew, he should know.\n>>>\n>>> I am not an expert at the clock framework nor the power management, but I\n>>> did ask around a bit.  No one I asked was planning to change the clk_*()\n>>> calls to pm_*() call, but the feedback was that it would be a good idea.\n>>\n>> The question is, if we do the replacement, will it break on socfpga ?\n>> A quick test might be useful.\n>>\n>\n> yes, a quick qspi test with clk_prepare_enable() replaced by pm_*() calls\n> like below patch would be helpful:\n>\n>\n> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n> index 53c7d8e0327a..7ad3e176cc88 100644\n> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n> @@ -34,6 +34,7 @@\n> #include \n> #include \n> #include \n> +#include \n>\n> #define CQSPI_NAME \"cadence-qspi\"\n> #define CQSPI_MAX_CHIPSELECT 16\n> @@ -1206,11 +1207,8 @@ static int cqspi_probe(struct platform_device *pdev)\n> return -ENXIO;\n> }\n>\n> - ret = clk_prepare_enable(cqspi->clk);\n> - if (ret) {\n> - dev_err(dev, \"Cannot enable QSPI clock.\\n\");\n> - return ret;\n> - }\n> + pm_runtime_enable(dev);\n> + pm_runtime_get_sync(dev);\n>\n> cqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);\n>\n>\n>\n>\n>\n> -- \n> Regards\n> Vignesh\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"nlHbPE13\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2ybP5qKhz9t66\n\tfor ;\n\tFri, 29 Sep 2017 01:02:25 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxaKT-0000q3-Ue; Thu, 28 Sep 2017 15:02:21 +0000","from mga06.intel.com ([134.134.136.31])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dxaK9-0000aL-8F; Thu, 28 Sep 2017 15:02:06 +0000","from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP; 28 Sep 2017 08:01:39 -0700","from mgerlach-mobl.amr.corp.intel.com (HELO [10.0.2.15])\n\t([10.252.139.46])\n\tby fmsmga005.fm.intel.com with ESMTP; 28 Sep 2017 08:01:38 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209;\n\th=Sender:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:\n\tMIME-Version:References:Message-ID:In-Reply-To:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=wO5EdRkGmV54q8gv75itppWGCwafNncPviV0fJKo35w=;\n\tb=nlHbPE13+7n49orZec8nUVMoo\n\tf/Qk31zbhYFD4AnCJ3S+fgEi7He8gD4xM35aoGbz+nRxR68sckCzxed3i9lJAixFNRsJ8d8W2L9OA\n\tkazZKiUJ11rL05ddEAsVq7h2JdDth2Z4M0W8Pa5H/I7+LqyuOZxBORg/cvXRLP14PaXMAOdgZS+D8\n\th0K4GDgG/+6HHbvsSAdTqh8NKAr3piW23iW2qRfoSA6EpiND1+yWQLVUZB+PCqoUXNyeISM+FTnt2\n\tz317404nxvAgfrT0eTNfh3hs3ZjlcmCPuxMrfnn2+0SaeG9ggbSJHORq+Ye2NkYEV4xL2wiyG/1Ma\n\tpHVc58RYA==;","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,450,1500966000\"; d=\"scan'208\";a=\"156599517\"","Date":"Thu, 28 Sep 2017 08:01:36 -0700 (PDT)","From":"matthew.gerlach@linux.intel.com","X-X-Sender":"mgerlach@mgerlach-VirtualBox","To":"Vignesh R ","Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","In-Reply-To":"<7237fa9e-4d3a-8a82-10c6-76737c23ed6f@ti.com>","Message-ID":"","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>\n\t\n\t<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>\n\t\n\t\n\t\n\t<7237fa9e-4d3a-8a82-10c6-76737c23ed6f@ti.com>","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"multipart/mixed; BOUNDARY=\"8323329-1557128041-1506610898=:2488\"","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170928_080201_396552_49A2E8EC ","X-CRM114-Status":"GOOD ( 17.23 )","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [134.134.136.31 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tMarek Vasut , Rob Herring ,\n\tlinux-mtd@lists.infradead.org,\n\tCyrille Pitchen , \n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778290,"web_url":"http://patchwork.ozlabs.org/comment/1778290/","msgid":"<5bc42364-21e1-56b6-788c-2848b8faa50f@ti.com>","list_archive_url":null,"date":"2017-10-02T12:28:55","subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","submitter":{"id":65039,"url":"http://patchwork.ozlabs.org/api/people/65039/","name":"Raghavendra, Vignesh","email":"vigneshr@ti.com"},"content":"Hi,\n\nOn 9/28/2017 8:31 PM, matthew.gerlach@linux.intel.com wrote:\n> \n> Hi Vignesh,\n> \n> I tried this patch on an Arria10 SOCFPGA devkit against the 4.1.33-ltsi \n> kernel, and it did not go well. Commands to the flash chip timedout \n> resulting in the probe function failing. I ran into other problems, not \n> related to cadence-quadspi, that prevented me from testing against 4.9 and \n> 4.12 kernels, but I suspect similar behavior.\n> \n\nOk, thanks! I will keep the clk_*() calls for now.\n\nRegards\nVignesh\n> Matthew Gerlach\n> \n> On Wed, 27 Sep 2017, Vignesh R wrote:\n> \n>> Hi Matthew,\n>>\n>> On Tuesday 26 September 2017 05:19 AM, Marek Vasut wrote:\n>> [...]\n>>>>>> Ok thanks! Do you know if pm_runtime_get_sync() can enable clocks for\n>>>>>> QSPI on SoCFPGA or if clk_prepare_enable() is needed? Just trying to see\n>>>>>> if its possible to get rid of clk_*() calls in favor of pm_*() calls.\n>>>>>\n>>>>> Not of the top of my head, sorry. +CC Matthew, he should know.\n>>>>\n>>>> I am not an expert at the clock framework nor the power management, but I\n>>>> did ask around a bit.  No one I asked was planning to change the clk_*()\n>>>> calls to pm_*() call, but the feedback was that it would be a good idea.\n>>>\n>>> The question is, if we do the replacement, will it break on socfpga ?\n>>> A quick test might be useful.\n>>>\n>>\n>> yes, a quick qspi test with clk_prepare_enable() replaced by pm_*() calls\n>> like below patch would be helpful:\n>>\n>>\n>> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n>> index 53c7d8e0327a..7ad3e176cc88 100644\n>> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n>> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n>> @@ -34,6 +34,7 @@\n>> #include \n>> #include \n>> #include \n>> +#include \n>>\n>> #define CQSPI_NAME \"cadence-qspi\"\n>> #define CQSPI_MAX_CHIPSELECT 16\n>> @@ -1206,11 +1207,8 @@ static int cqspi_probe(struct platform_device *pdev)\n>> return -ENXIO;\n>> }\n>>\n>> - ret = clk_prepare_enable(cqspi->clk);\n>> - if (ret) {\n>> - dev_err(dev, \"Cannot enable QSPI clock.\\n\");\n>> - return ret;\n>> - }\n>> + pm_runtime_enable(dev);\n>> + pm_runtime_get_sync(dev);\n>>\n>> cqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);\n>>\n>>\n>>\n>>\n>>\n>> -- \n>> Regards\n>> Vignesh\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Pkhkac85\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"ddKb7Rmh\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5M2V6ZRFz9t4c\n\tfor ;\n\tMon, 2 Oct 2017 23:30:42 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dyzrq-0003MI-H3; Mon, 02 Oct 2017 12:30:38 +0000","from lelnx194.ext.ti.com ([198.47.27.80])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dyzrA-0001de-96; Mon, 02 Oct 2017 12:30:00 +0000","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v92CT0Qv014407; \n\tMon, 2 Oct 2017 07:29:00 -0500","from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v92CT0qs032621;\n\tMon, 2 Oct 2017 07:29:00 -0500","from DLEE101.ent.ti.com (157.170.170.31) by DLEE104.ent.ti.com\n\t(157.170.170.34) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tMon, 2 Oct 2017 07:28:59 -0500","from dlep33.itg.ti.com (157.170.170.75) by DLEE101.ent.ti.com\n\t(157.170.170.31) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Mon, 2 Oct 2017 07:29:00 -0500","from [172.22.217.158] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v92CStG9031830;\n\tMon, 2 Oct 2017 07:28:56 -0500"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=qg44vBPH0e4b8lkrTFkj7BmA63iikOQHj2FZs2t1Bgo=;\n\tb=Pkhkac85xJUCII\n\tbyiAejT0OgL86mmmjXaxJVxZzCeaRH+MRQfsVtNVkE553ypq8D1K/owmkGKRL4eP/rBTCtrDs9ems\n\tKFbta9/7trCLXhAAbKuxbSC9bi/H6CXKcN7BLjZ96H3Jvg9HaDi+5TZwjl9WKKaWwxGHshMILh/O6\n\tWcHRh7GJMFBOYQnpiTdHlf1NBDBwfTHe79obFk1+QU2dg86sU4Xudo7M8LCF/r9M39LowY3a/waBy\n\t6HZioFxiVIWattM2Srwht61kkbZY0aEWmy6NjCoLSkYZPDvdTgWefYMAZvffx5XcZof8xDUcZlZNA\n\tFqSFMkr+YU0TT3DLdA6A==;","v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506947340;\n\tbh=w6bZDGs8nZtmZIJLRM+aNeYg43MFvjUnu1eZEo0SNVE=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=ddKb7Rmh0KqhZfw9N8igCk1R+/dFSnEhqXXVyciGVZJRlsrIn6LCMOqGMNprR5eoM\n\tpvt1I+rW1YYshcTZu4YL424e/q0qzGQm24eNp6+NQUpWsS46MDQkiFWFOTcMGv9wXp\n\tvVfMDsgUn+WPnW9m55115yx0o78KvDjZVA2S1uNI="],"Subject":"Re: [PATCH v3 5/5] mtd: spi-nor: cadence-quadspi: Add runtime PM\n\tsupport","To":"\"matthew.gerlach@linux.intel.com\" ","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-6-vigneshr@ti.com>\n\t<3a1160f9-a0ae-c84c-d209-af97c3c3b0f6@gmail.com>\n\t<4ee69ea4-14cc-4305-bf3f-8fe76d43bf6b@ti.com>\n\t\n\t<038919d3-ff32-d0a7-4c0a-3be16436052d@ti.com>\n\t\n\t\n\t\n\t<7237fa9e-4d3a-8a82-10c6-76737c23ed6f@ti.com>\n\t","From":"Vignesh R ","Message-ID":"<5bc42364-21e1-56b6-788c-2848b8faa50f@ti.com>","Date":"Mon, 2 Oct 2017 17:58:55 +0530","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171002_052956_532042_E244E9CC ","X-CRM114-Status":"GOOD ( 14.11 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.27.80 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tMarek Vasut , Rob Herring ,\n\t\"linux-mtd@lists.infradead.org\" ,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1778302,"web_url":"http://patchwork.ozlabs.org/comment/1778302/","msgid":"<07137a92-244b-e009-54ae-71f733860f28@ti.com>","list_archive_url":null,"date":"2017-10-02T12:46:40","subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","submitter":{"id":65039,"url":"http://patchwork.ozlabs.org/api/people/65039/","name":"Raghavendra, Vignesh","email":"vigneshr@ti.com"},"content":"On 9/24/2017 6:43 PM, Marek Vasut wrote:\n> On 09/24/2017 02:33 PM, Vignesh R wrote:\n>>\n>>\n>> On 9/24/2017 5:29 PM, Marek Vasut wrote:\n>>> On 09/24/2017 12:59 PM, Vignesh R wrote:\n>>>> As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access\n>>>> Controller programming sequence, a delay equal to couple of QSPI master\n>>>> clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and\n>>>> writing data to the flash. Introduce a quirk flag CQSPI_NEEDS_WR_DELAY\n>>>> to handle this and set this flag for TI 66AK2G SoC.\n>>>>\n>>>> [1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf\n>>>>\n>>>> Signed-off-by: Vignesh R \n>>>\n>>> Is this TI specific or is this controller property ? I wouldn't be\n>>> surprised of the later ...\n>>\n>> I am not sure, there is no generic public documentation by cadence for\n>> this IP. TI TRM clearly states this delay is required and I have\n>> verified it practically that this delay is indeed needed.\n>> But current user of this IP, socfpga does not seem to mention anything\n>> about it. So, I guess its TI specific quirk.\n> \n> OK, let's go with that then. I didn't observe any stability issues with\n> SoCFPGA, but I didn't run the flash at 100s of MHz either. At what kind\n> of frequencies does the quirk become relevant ?\n> \n\nActually, delay is tied to QSPI master clk rate(not SPI bus clk rate).\nIt runs at 384MHz. Changing SPI bus rate has no effect.\n\nRegards\nVignesh\n\n>>>\n>>>> ---\n>>>>\n>>>> v3:\n>>>> Fix build warnings reported by kbuild test bot.\n>>>>\n>>>> drivers/mtd/spi-nor/cadence-quadspi.c | 27 ++++++++++++++++++++++++++-\n>>>> 1 file changed, 26 insertions(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c\n>>>> index 53c7d8e0327a..5cd5d6f7303f 100644\n>>>> --- a/drivers/mtd/spi-nor/cadence-quadspi.c\n>>>> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c\n>>>> @@ -38,6 +38,9 @@\n>>>> #define CQSPI_NAME\t\t\t\"cadence-qspi\"\n>>>> #define CQSPI_MAX_CHIPSELECT\t\t16\n>>>> \n>>>> +/* Quirks */\n>>>> +#define CQSPI_NEEDS_WR_DELAY\t\tBIT(0)\n>>>> +\n>>>> struct cqspi_st;\n>>>> \n>>>> struct cqspi_flash_pdata {\n>>>> @@ -76,6 +79,7 @@ struct cqspi_st {\n>>>> \tu32\t\t\tfifo_depth;\n>>>> \tu32\t\t\tfifo_width;\n>>>> \tu32\t\t\ttrigger_address;\n>>>> +\tu32\t\t\twr_delay;\n>>>> \tstruct cqspi_flash_pdata f_pdata[CQSPI_MAX_CHIPSELECT];\n>>>> };\n>>>> \n>>>> @@ -608,6 +612,15 @@ static int cqspi_indirect_write_execute(struct spi_nor *nor,\n>>>> \treinit_completion(&cqspi->transfer_complete);\n>>>> \twritel(CQSPI_REG_INDIRECTWR_START_MASK,\n>>>> \t reg_base + CQSPI_REG_INDIRECTWR);\n>>>> +\t/*\n>>>> +\t * As per 66AK2G02 TRM SPRUHY8F section 11.15.5.3 Indirect Access\n>>>> +\t * Controller programming sequence, couple of cycles of\n>>>> +\t * QSPI_REF_CLK delay is required for the above bit to\n>>>> +\t * be internally synchronized by the QSPI module. Provide 5\n>>>> +\t * cycles of delay.\n>>>> +\t */\n>>>> +\tif (cqspi->wr_delay)\n>>>> +\t\tndelay(cqspi->wr_delay);\n>>>> \n>>>> \twhile (remaining > 0) {\n>>>> \t\twrite_bytes = remaining > page_size ? page_size : remaining;\n>>>> @@ -1156,6 +1169,7 @@ static int cqspi_probe(struct platform_device *pdev)\n>>>> \tstruct cqspi_st *cqspi;\n>>>> \tstruct resource *res;\n>>>> \tstruct resource *res_ahb;\n>>>> +\tunsigned long data;\n>>>> \tint ret;\n>>>> \tint irq;\n>>>> \n>>>> @@ -1213,6 +1227,10 @@ static int cqspi_probe(struct platform_device *pdev)\n>>>> \t}\n>>>> \n>>>> \tcqspi->master_ref_clk_hz = clk_get_rate(cqspi->clk);\n>>>> +\tdata = (unsigned long)of_device_get_match_data(dev);\n>>>> +\tif (data & CQSPI_NEEDS_WR_DELAY)\n>>>> +\t\tcqspi->wr_delay = 5 * DIV_ROUND_UP(NSEC_PER_SEC,\n>>>> +\t\t\t\t\t\t cqspi->master_ref_clk_hz);\n>>>> \n>>>> \tret = devm_request_irq(dev, irq, cqspi_irq_handler, 0,\n>>>> \t\t\t pdev->name, cqspi);\n>>>> @@ -1284,7 +1302,14 @@ static const struct dev_pm_ops cqspi__dev_pm_ops = {\n>>>> #endif\n>>>> \n>>>> static const struct of_device_id cqspi_dt_ids[] = {\n>>>> -\t{.compatible = \"cdns,qspi-nor\",},\n>>>> +\t{\n>>>> +\t\t.compatible = \"cdns,qspi-nor\",\n>>>> +\t\t.data = (void *)0,\n>>>> +\t},\n>>>> +\t{\n>>>> +\t\t.compatible = \"ti,k2g-qspi\",\n>>>> +\t\t.data = (void *)CQSPI_NEEDS_WR_DELAY,\n>>>> +\t},\n>>>> \t{ /* end of table */ }\n>>>> };\n>>>> \n>>>>\n>>>\n>>>\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"e/DlsKCY\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"AAPB58NZ\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5MQs4R53z9sMN\n\tfor ;\n\tMon, 2 Oct 2017 23:48:21 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz08v-00084n-RD; Mon, 02 Oct 2017 12:48:17 +0000","from lelnx194.ext.ti.com ([198.47.27.80])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dz08G-0007hd-TF; Mon, 02 Oct 2017 12:47:40 +0000","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v92CkkHJ016745; \n\tMon, 2 Oct 2017 07:46:46 -0500","from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v92CkkNJ030849;\n\tMon, 2 Oct 2017 07:46:46 -0500","from DLEE107.ent.ti.com (157.170.170.37) by DLEE104.ent.ti.com\n\t(157.170.170.34) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tMon, 2 Oct 2017 07:46:46 -0500","from dflp33.itg.ti.com (10.64.6.16) by DLEE107.ent.ti.com\n\t(157.170.170.37) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Mon, 2 Oct 2017 07:46:46 -0500","from [172.22.217.158] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v92Cke3b030547;\n\tMon, 2 Oct 2017 07:46:41 -0500"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=+0gI726A94dCcN57dmMXPsiDcD/8vQfwFQsQ5T8iomE=;\n\tb=e/DlsKCYurBmDu\n\tgp4szEr29UG9HdKZ2XqHwMtWh/wq1+zx/H25faJoadd1codP1Y5VNsWhEPmuz4WO8z8aVRE5kWlHS\n\tiwlJWXKAXo5JQ/Zr4SWcoJuEG8ZhRwWkwZeMYLQ4IwM8NJE6Ujqx7uGPSuFUw4+gBM6bThjLDe8Ba\n\tK/AUfGW7v7r0YJsrLgulCQJrzBUixPwyZOa35X2ShdzR7rAyKTihD5bpj57MDtpMbaliYnHR6gWRf\n\thrnAZPiuPtS9H4Y6SredIfFgM/j77RqaYVh9Y7o5DY4QSssxQaiZzC4R5fpHkA9xHHoc0YWZU/V1D\n\tSp8do9mew8QBfVvuxlDw==;","v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506948406;\n\tbh=H3RjL1kLx1KII/o+Hf+Lj5y45ctD3ttPK2l2O8fUDyg=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=AAPB58NZpVErvHLm8IQ6eDKd6KWUA12F6br2Ed3BbIH4SnKzHKxko1WcYnyJRZV0U\n\t15fJKX1b+4K1u5m5ad0R5lg6axwVQUvC0MOtcudBxJRWNq9Z2WR+XsgMRrzNURZkTw\n\tcUGoFd8dDFpl/EshQ57/YskQikfxRur6zZOFbbDM="],"Subject":"Re: [PATCH v3 2/5] mtd: spi-nor: cadence-quadspi: add a delay in\n\twrite sequence","To":"Marek Vasut , Cyrille Pitchen\n\t","References":"<20170924105924.23923-1-vigneshr@ti.com>\n\t<20170924105924.23923-3-vigneshr@ti.com>\n\t<94313cae-4805-0b13-a469-72aa7556b685@gmail.com>\n\t<8990b971-91d5-747f-905b-5e24743e090d@ti.com>\n\t","From":"Vignesh R ","Message-ID":"<07137a92-244b-e009-54ae-71f733860f28@ti.com>","Date":"Mon, 2 Oct 2017 18:16:40 +0530","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171002_054737_052695_FF73DA73 ","X-CRM114-Status":"GOOD ( 13.93 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.27.80 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tRob Herring , linux-mtd@lists.infradead.org,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]