[{"id":1775326,"web_url":"http://patchwork.ozlabs.org/comment/1775326/","msgid":"<20170926100236.GG16834@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-26T10:02:36","subject":"Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Sat, Sep 23, 2017 at 02:14:08PM +0300, Manos Pitsidianakis wrote:\n> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new \n> bdrv_co_drain_end callback to match bdrv_drained_begin/end and \n> drained_begin/end of BdrvChild. This is needed because the throttle driver \n> (block/throttle.c) needs a way to mark the end of the drain in order to toggle \n> io_limits_disabled correctly.\n> \n> Based-on: <20170918202529.28379-1-el13635@mail.ntua.gr>\n>     \"block/throttle-groups.c: allocate RestartData on the heap\"\n>     Which fixes a coroutine crash in block/throttle-groups.c\n> \n> v3:\n>   fixed commit message typo in first patch [Fam]\n>   rephrased doc comment based on mailing discussion\n> v2: \n>   add doc for callbacks and change order of request polling for completion \n>   [Stefan]\n> \n> Manos Pitsidianakis (3):\n>   block: add bdrv_co_drain_end callback\n>   block: rename bdrv_co_drain to bdrv_co_drain_begin\n>   block/throttle.c: add bdrv_co_drain_begin/end callbacks\n> \n>  include/block/block_int.h | 13 ++++++++++---\n>  block/io.c                | 48 +++++++++++++++++++++++++++++++++--------------\n>  block/qed.c               |  6 +++---\n>  block/throttle.c          | 18 ++++++++++++++++++\n>  4 files changed, 65 insertions(+), 20 deletions(-)\n> \n> -- \n> 2.11.0\n> \n\nThanks, applied to my block tree:\nhttps://github.com/stefanha/qemu/commits/block\n\nStefan","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1c3L5SLmz9tXb\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 20:03:25 +1000 (AEST)","from localhost ([::1]:46437 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwmi3-0006TX-8s\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 06:03:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39836)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <stefanha@redhat.com>) id 1dwmhX-0006R2-P6\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:02:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <stefanha@redhat.com>) id 1dwmhW-0001xx-R1\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:02:51 -0400","from mx1.redhat.com ([209.132.183.28]:35694)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <stefanha@redhat.com>)\n\tid 1dwmhN-0001vu-NF; Tue, 26 Sep 2017 06:02:41 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D1073356DB;\n\tTue, 26 Sep 2017 10:02:39 +0000 (UTC)","from localhost (ovpn-117-168.ams2.redhat.com [10.36.117.168])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 265996F935;\n\tTue, 26 Sep 2017 10:02:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D1073356DB","Date":"Tue, 26 Sep 2017 11:02:36 +0100","From":"Stefan Hajnoczi <stefanha@redhat.com>","To":"Manos Pitsidianakis <el13635@mail.ntua.gr>","Message-ID":"<20170926100236.GG16834@stefanha-x1.localdomain>","References":"<20170923111411.18626-1-el13635@mail.ntua.gr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170923111411.18626-1-el13635@mail.ntua.gr>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 26 Sep 2017 10:02:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,\n\tqemu-devel <qemu-devel@nongnu.org>, qemu-block <qemu-block@nongnu.org>,\n\tMax Reitz <mreitz@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775364,"web_url":"http://patchwork.ozlabs.org/comment/1775364/","msgid":"<20170926110024.GA13332@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-26T11:00:24","subject":"Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","submitter":{"id":17227,"url":"http://patchwork.ozlabs.org/api/people/17227/","name":"Stefan Hajnoczi","email":"stefanha@redhat.com"},"content":"On Sat, Sep 23, 2017 at 02:14:08PM +0300, Manos Pitsidianakis wrote:\n> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new \n> bdrv_co_drain_end callback to match bdrv_drained_begin/end and \n> drained_begin/end of BdrvChild. This is needed because the throttle driver \n> (block/throttle.c) needs a way to mark the end of the drain in order to toggle \n> io_limits_disabled correctly.\n> \n> Based-on: <20170918202529.28379-1-el13635@mail.ntua.gr>\n>     \"block/throttle-groups.c: allocate RestartData on the heap\"\n>     Which fixes a coroutine crash in block/throttle-groups.c\n> \n> v3:\n>   fixed commit message typo in first patch [Fam]\n>   rephrased doc comment based on mailing discussion\n> v2: \n>   add doc for callbacks and change order of request polling for completion \n>   [Stefan]\n> \n> Manos Pitsidianakis (3):\n>   block: add bdrv_co_drain_end callback\n>   block: rename bdrv_co_drain to bdrv_co_drain_begin\n>   block/throttle.c: add bdrv_co_drain_begin/end callbacks\n> \n>  include/block/block_int.h | 13 ++++++++++---\n>  block/io.c                | 48 +++++++++++++++++++++++++++++++++--------------\n>  block/qed.c               |  6 +++---\n>  block/throttle.c          | 18 ++++++++++++++++++\n>  4 files changed, 65 insertions(+), 20 deletions(-)\n\nOops, this seems to cause a qemu-iotests failure.  Please take a look:\n\n$ ./check -qcow2 184\n184 0s ... - output mismatch (see 184.out.bad)\n--- /home/stefanha/qemu/tests/qemu-iotests/184.out\t2017-09-19 14:51:46.673854437 +0100\n+++ 184.out.bad\t2017-09-26 11:13:06.946610239 +0100\n@@ -142,6 +142,9 @@\n         \"guest\": false\n     }\n }\n+./common.config: line 118:  9196 Segmentation fault      (core dumped) ( if [ -n \"${QEMU_NEED_PID}\" ]; then\n+    echo $BASHPID > \"${QEMU_TEST_DIR}/qemu-${_QEMU_HANDLE}.pid\";\n+fi; exec \"$QEMU_PROG\" $QEMU_OPTIONS \"$@\" )","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=stefanha@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1dL65Ndwz9tXH\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 21:01:18 +1000 (AEST)","from localhost ([::1]:46678 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwnc4-0001PV-Sz\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 07:01:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57660)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <stefanha@redhat.com>) id 1dwnba-0001Ny-4j\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:00:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <stefanha@redhat.com>) id 1dwnbW-0006f1-Bb\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:00:46 -0400","from mx1.redhat.com ([209.132.183.28]:9044)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <stefanha@redhat.com>)\n\tid 1dwnbK-0006Tn-8r; Tue, 26 Sep 2017 07:00:30 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3518B81DF8;\n\tTue, 26 Sep 2017 11:00:29 +0000 (UTC)","from localhost (ovpn-117-168.ams2.redhat.com [10.36.117.168])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DAA46600C6;\n\tTue, 26 Sep 2017 11:00:25 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3518B81DF8","Date":"Tue, 26 Sep 2017 12:00:24 +0100","From":"Stefan Hajnoczi <stefanha@redhat.com>","To":"Manos Pitsidianakis <el13635@mail.ntua.gr>","Message-ID":"<20170926110024.GA13332@stefanha-x1.localdomain>","References":"<20170923111411.18626-1-el13635@mail.ntua.gr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170923111411.18626-1-el13635@mail.ntua.gr>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 26 Sep 2017 11:00:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,\n\tqemu-devel <qemu-devel@nongnu.org>, qemu-block <qemu-block@nongnu.org>,\n\tMax Reitz <mreitz@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775438,"web_url":"http://patchwork.ozlabs.org/comment/1775438/","msgid":"<20170926124425.ubuecf6haepcqeec@postretch>","list_archive_url":null,"date":"2017-09-26T12:44:25","subject":"Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","submitter":{"id":71571,"url":"http://patchwork.ozlabs.org/api/people/71571/","name":"Manos Pitsidianakis","email":"el13635@mail.ntua.gr"},"content":"On Tue, Sep 26, 2017 at 12:00:24PM +0100, Stefan Hajnoczi wrote:\n>On Sat, Sep 23, 2017 at 02:14:08PM +0300, Manos Pitsidianakis wrote:\n>> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new\n>> bdrv_co_drain_end callback to match bdrv_drained_begin/end and\n>> drained_begin/end of BdrvChild. This is needed because the throttle driver\n>> (block/throttle.c) needs a way to mark the end of the drain in order to toggle\n>> io_limits_disabled correctly.\n>>\n>> Based-on: <20170918202529.28379-1-el13635@mail.ntua.gr>\n>>     \"block/throttle-groups.c: allocate RestartData on the heap\"\n>>     Which fixes a coroutine crash in block/throttle-groups.c\n>>\n>> v3:\n>>   fixed commit message typo in first patch [Fam]\n>>   rephrased doc comment based on mailing discussion\n>> v2:\n>>   add doc for callbacks and change order of request polling for completion\n>>   [Stefan]\n>>\n>> Manos Pitsidianakis (3):\n>>   block: add bdrv_co_drain_end callback\n>>   block: rename bdrv_co_drain to bdrv_co_drain_begin\n>>   block/throttle.c: add bdrv_co_drain_begin/end callbacks\n>>\n>>  include/block/block_int.h | 13 ++++++++++---\n>>  block/io.c                | 48 +++++++++++++++++++++++++++++++++--------------\n>>  block/qed.c               |  6 +++---\n>>  block/throttle.c          | 18 ++++++++++++++++++\n>>  4 files changed, 65 insertions(+), 20 deletions(-)\n>\n>Oops, this seems to cause a qemu-iotests failure.  Please take a look:\n>\n>$ ./check -qcow2 184\n>184 0s ... - output mismatch (see 184.out.bad)\n>--- /home/stefanha/qemu/tests/qemu-iotests/184.out\t2017-09-19 14:51:46.673854437 +0100\n>+++ 184.out.bad\t2017-09-26 11:13:06.946610239 +0100\n>@@ -142,6 +142,9 @@\n>         \"guest\": false\n>     }\n> }\n>+./common.config: line 118:  9196 Segmentation fault      (core dumped) ( if [ -n \"${QEMU_NEED_PID}\" ]; then\n>+    echo $BASHPID > \"${QEMU_TEST_DIR}/qemu-${_QEMU_HANDLE}.pid\";\n>+fi; exec \"$QEMU_PROG\" $QEMU_OPTIONS \"$@\" )\n>\n\nHey Stefan,\n\nThis is fixed in \n>> Based-on: <20170918202529.28379-1-el13635@mail.ntua.gr>\n>>     \"block/throttle-groups.c: allocate RestartData on the heap\"\n>>     Which fixes a coroutine crash in block/throttle-groups.c\n\nWhich I sent before this series and is in Kevin's branch.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1gf06tscz9tXP\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 22:45:12 +1000 (AEST)","from localhost ([::1]:47398 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwpEd-0004JV-4r\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 08:45:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59520)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <el13635@mail.ntua.gr>) id 1dwpEE-0004HB-7I\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:44:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <el13635@mail.ntua.gr>) id 1dwpED-0004Yg-G3\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:44:46 -0400","from smtp1.ntua.gr ([2001:648:2000:de::183]:17755)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <el13635@mail.ntua.gr>)\n\tid 1dwpE5-0004L4-LA; Tue, 26 Sep 2017 08:44:37 -0400","from mail.ntua.gr (carp0.noc.ntua.gr [147.102.222.60])\n\t(authenticated bits=0)\n\tby smtp1.ntua.gr (8.15.2/8.15.2) with ESMTPSA id v8QCiUdi021578\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Tue, 26 Sep 2017 15:44:30 +0300 (EEST)\n\t(envelope-from el13635@mail.ntua.gr)"],"X-Authentication-Warning":"smtp1.ntua.gr: Host carp0.noc.ntua.gr\n\t[147.102.222.60] claimed to be mail.ntua.gr","Date":"Tue, 26 Sep 2017 15:44:25 +0300","From":"Manos Pitsidianakis <el13635@mail.ntua.gr>","To":"Stefan Hajnoczi <stefanha@redhat.com>","Message-ID":"<20170926124425.ubuecf6haepcqeec@postretch>","Mail-Followup-To":"Manos Pitsidianakis <el13635@mail.ntua.gr>,\n\tStefan Hajnoczi <stefanha@redhat.com>,\n\tqemu-devel <qemu-devel@nongnu.org>,\n\tqemu-block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,\n\tFam Zheng <famz@redhat.com>, Max Reitz <mreitz@redhat.com>","References":"<20170923111411.18626-1-el13635@mail.ntua.gr>\n\t<20170926110024.GA13332@stefanha-x1.localdomain>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"tacsfwwxlqzjpgbe\"","Content-Disposition":"inline","In-Reply-To":"<20170926110024.GA13332@stefanha-x1.localdomain>","User-Agent":"NeoMutt/20170609-57-1e93be (1.8.3)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:648:2000:de::183","Subject":"Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,\n\tqemu-devel <qemu-devel@nongnu.org>, qemu-block <qemu-block@nongnu.org>,\n\tMax Reitz <mreitz@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1786234,"web_url":"http://patchwork.ozlabs.org/comment/1786234/","msgid":"<20171013122725.GG27308@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-10-13T12:27:25","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/3] add\n\tbdrv_co_drain_begin/end BlockDriver callbacks","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Sat, Sep 23, 2017 at 02:14:08PM +0300, Manos Pitsidianakis wrote:\n> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new \n> bdrv_co_drain_end callback to match bdrv_drained_begin/end and \n> drained_begin/end of BdrvChild. This is needed because the throttle driver \n> (block/throttle.c) needs a way to mark the end of the drain in order to toggle \n> io_limits_disabled correctly.\n> \n> Based-on: <20170918202529.28379-1-el13635@mail.ntua.gr>\n>     \"block/throttle-groups.c: allocate RestartData on the heap\"\n>     Which fixes a coroutine crash in block/throttle-groups.c\n> \n> v3:\n>   fixed commit message typo in first patch [Fam]\n>   rephrased doc comment based on mailing discussion\n> v2: \n>   add doc for callbacks and change order of request polling for completion \n>   [Stefan]\n> \n> Manos Pitsidianakis (3):\n>   block: add bdrv_co_drain_end callback\n>   block: rename bdrv_co_drain to bdrv_co_drain_begin\n>   block/throttle.c: add bdrv_co_drain_begin/end callbacks\n> \n>  include/block/block_int.h | 13 ++++++++++---\n>  block/io.c                | 48 +++++++++++++++++++++++++++++++++--------------\n>  block/qed.c               |  6 +++---\n>  block/throttle.c          | 18 ++++++++++++++++++\n>  4 files changed, 65 insertions(+), 20 deletions(-)\n> \n> -- \n> 2.11.0\n> \n> \n\nThanks, applied to my block tree:\nhttps://github.com/stefanha/qemu/commits/block\n\nStefan","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"o74SwCqe\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yD6SG6ngCz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 Oct 2017 23:27:57 +1100 (AEDT)","from localhost ([::1]:50074 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e2z4F-0004GS-5a\n\tfor incoming@patchwork.ozlabs.org; Fri, 13 Oct 2017 08:27:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34635)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <stefanha@gmail.com>) id 1e2z3t-0004G8-1D\n\tfor qemu-devel@nongnu.org; Fri, 13 Oct 2017 08:27:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <stefanha@gmail.com>) id 1e2z3o-00017V-W6\n\tfor qemu-devel@nongnu.org; Fri, 13 Oct 2017 08:27:33 -0400","from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:56423)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <stefanha@gmail.com>)\n\tid 1e2z3o-00017M-PC; Fri, 13 Oct 2017 08:27:28 -0400","by mail-wm0-x243.google.com with SMTP id l68so21356502wmd.5;\n\tFri, 13 Oct 2017 05:27:28 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tq16sm1182457wrg.96.2017.10.13.05.27.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 13 Oct 2017 05:27:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=byDIK8+T0n8u+knsE/7Ph0rfUYSc1D8Ej06wy17Lh+0=;\n\tb=o74SwCqeHMmvMuaeGG8ZIJHbCmp0b6OJtxPMG5Mc3yjLAMR5P8WFKYb/6FjEaUB0d4\n\tG+4cWwBx+CD6Gu0t1JVY4Mw8M276u8ls4z2PFse8a+HRx0yBoYe0vpzcWJZ2EPlhJYp2\n\tjn5ea+WgwCsm5uzbZtCWbR9+9lFUnbOqkvYHTsQROOHLLxajb/xYzOU+M8k1JVF7T2ia\n\tQv3Hga4Vu8M1k7D3Q4p5laFEaMxzXr3yhgBU7f2/YevKI9E+Rgx0xE0upYKQY4qDIrNn\n\tBJYMWbMsU6tnWsewcuYdkfzf43is63hsyCXpKNxw1KeBCl2bzHBPDgXZzdfKD6c2/qk7\n\tAs7A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=byDIK8+T0n8u+knsE/7Ph0rfUYSc1D8Ej06wy17Lh+0=;\n\tb=NC2rIP5QTTvaXgAB8WKomJDve5dg/Tw0oiD2R2Ngk2TDMpiu5yrRwcS5DfmryhpTNB\n\tbmnPFb6nwhLy4C9K1TDeF3CVa99RWph4jXVOYkZGEfrteUpqrrytoouwyuqPynDQ3C6N\n\tBySzYS9pNQf86lRs+fQZZZRVtdwRyrTovPlpiJMm7/xAedUlri495EztaHsOIsS6EUAk\n\tLE2nKfr9qSxiQk0xL8ARYsINfAg+JOkUBzaQWAi6SXONHT3GVm/uJ7yoeIxA0ey9mauO\n\t15guc1lI6xST0HOsr8MZphve7mqCv3B38uovM0ZjVR9XLUocJcEhUnWdWVFXiGSjt0dd\n\tlsnw==","X-Gm-Message-State":"AMCzsaWxP1slTz+c6W7d6jsatXmrH4D3AQU6B8EaiqLOUvKzyTuZLQDU\n\tq083MjgLGag4DtJ/xCoTVjI=","X-Google-Smtp-Source":"ABhQp+TK7iFEDfOQJIIXYl3St8PHLKLM743VOeFHwCC4yTh75NkHuum6KXFBMChKzZrdypp+hqEtLQ==","X-Received":"by 10.28.142.3 with SMTP id q3mr1285716wmd.46.1507897647695;\n\tFri, 13 Oct 2017 05:27:27 -0700 (PDT)","Date":"Fri, 13 Oct 2017 13:27:25 +0100","From":"Stefan Hajnoczi <stefanha@gmail.com>","To":"Manos Pitsidianakis <el13635@mail.ntua.gr>","Message-ID":"<20171013122725.GG27308@stefanha-x1.localdomain>","References":"<20170923111411.18626-1-el13635@mail.ntua.gr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170923111411.18626-1-el13635@mail.ntua.gr>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::243","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/3] add\n\tbdrv_co_drain_begin/end BlockDriver callbacks","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,\n\tqemu-block <qemu-block@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>,\n\tMax Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]