[{"id":1777784,"web_url":"http://patchwork.ozlabs.org/comment/1777784/","msgid":"<1506717436.3240277.1122909192.402C1E9C@webmail.messagingengine.com>","list_archive_url":null,"date":"2017-09-29T20:37:16","subject":"Re: [PATCH v3 2/6] drivers: fsi: Add SBEFIFO FSI client device\n\tdriver","submitter":{"id":68332,"url":"http://patchwork.ozlabs.org/api/people/68332/","name":"Andrew Jeffery","email":"andrew@aj.id.au"},"content":"Hi Eddie,\n\nOn Sat, 23 Sep 2017, at 06:35, Eddie James wrote:\n> From: \"Edward A. James\" \n> \n> IBM POWER9 processors contain some embedded hardware and software bits\n> collectively referred to as the self boot engine (SBE). One role of\n> the SBE is to act as a proxy that provides access to the registers of\n> the POWER chip from other (embedded) systems.\n> \n> The POWER9 chip contains a hardware frontend for communicating with\n> the SBE from remote systems called the SBEFIFO. The SBEFIFO logic\n> is contained within an FSI CFAM and as such the driver implements an\n> FSI bus device.\n> \n> The SBE expects to communicate using a defined wire protocol; however,\n> the driver knows nothing of the protocol and only provides raw access\n> to the fifo device to userspace applications wishing to communicate with\n> the SBE using the wire protocol.\n> \n> The SBEFIFO consists of two hardware fifos. The upstream fifo is used\n> by the driver to transfer data to the SBE on the POWER chip, from the\n> system hosting the driver. The downstream fifo is used by the driver to\n> transfer data from the SBE on the power chip to the system hosting the\n> driver.\n> \n> Signed-off-by: Brad Bishop \n> Signed-off-by: Edward A. James \n> ---\n> drivers/fsi/Kconfig | 7 +\n> drivers/fsi/Makefile | 1 +\n> drivers/fsi/fsi-sbefifo.c | 861\n> ++++++++++++++++++++++++++++++++++++++++++++++\n> 3 files changed, 869 insertions(+)\n> create mode 100644 drivers/fsi/fsi-sbefifo.c\n\nMy general feeling is the implementation is too complex by half for what\nis required. I may be wrong and the solution genuinely needs the\ncomplexity, but to test that I'll cook up a counter-proposal patch and\nwe can debate that. I'm away for the next few days, but I hope to send\nsomething by the end of next week.\n\nCheers,\n\nAndrew\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=aj.id.au header.i=@aj.id.au header.b=\"V664bt3G\";\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"JAXo939O\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y3jzN5tqrz9t2Q\n\tfor ;\n\tSat, 30 Sep 2017 06:37:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752203AbdI2UhS (ORCPT\n\t);\n\tFri, 29 Sep 2017 16:37:18 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:38799 \"EHLO\n\tout1-smtp.messagingengine.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752003AbdI2UhR (ORCPT\n\t); Fri, 29 Sep 2017 16:37:17 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 142C12147C;\n\tFri, 29 Sep 2017 16:37:17 -0400 (EDT)","from web2 ([10.202.2.212])\n\tby compute4.internal (MEProxy); Fri, 29 Sep 2017 16:37:17 -0400","by mailuser.nyi.internal (Postfix, from userid 99)\n\tid E1C036269A; Fri, 29 Sep 2017 16:37:16 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc; s=fm1; bh=oQGH4udVikSn4mAsjPpW9SZF3JTHu\n\tqKdS3nPcWkvnzY=; b=V664bt3GsLEEjdP1ziY5q4XsjCTNJnzsH0yLZT/mqP3JF\n\tN720jZC17xuQMcO0U620b+JJQbFSSi/1wr1gUSE1Yw2qVCW07wLI+MpOJIJVQsmL\n\t9JhKT6rUzBQLvwxS0QD47CArTOT+u+9uqo6Z/FjBS8cC9Tm83xGTnEFk4BZkTOop\n\t+ysKPWWpnBG+PC3HUXm3Ke6RfLfo6FgbO44nON2HHMxldzdmyiIai9Oc1gCyoez8\n\tWjNJtLmweijGWHn055MFrnB3+R+gy9frt6WE8QjbSJGy00f1cBwwPgfL/vMfxbVm\n\te7ArEqPE1azUavYBb4XjH5CqezxLpnvZRizmgvIEg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oQGH4u\n\tdVikSn4mAsjPpW9SZF3JTHuqKdS3nPcWkvnzY=; b=JAXo939ODMHNssjnjyJDcu\n\tG9s9J99TCM7qezxlqwO7vRz/xc2KNl+7r9xIHh+CnMPaRKcqcRACzcUbn7udOAXJ\n\tGf/VLDaa2nx04wOxztfQxspceE36eJi2Rr9q3ulHWFrHZbAsvx3ZlB48H9wA6EmE\n\twH3IGsEWbs6KN+0rExP+NA+S7FvlVoyfChpl45XzY/lUzqHob2mwu7PKNkPspBzB\n\t4TbgdbXfFwdzymoMRW1Dh6J7uim1dzFWLxKA4EcMBjSrlDOjTANUQcjHzdohVfgF\n\t9lbfb5QhXBdnJqIEZw8PQtuNqlHcirhjzekl+u6b+DOUGrNt2Rtsw5ANWDFrym8A\n\t=="],"X-ME-Sender":"","Message-Id":"<1506717436.3240277.1122909192.402C1E9C@webmail.messagingengine.com>","From":"Andrew Jeffery ","To":"Eddie James , linux-kernel@vger.kernel.org","Cc":"gregkh@linuxfoundation.org, devicetree@vger.kernel.org,\n\trobh+dt@kernel.org, mark.rutland@arm.com,\n\tbradleyb@fuzziesquirrel.com, jk@ozlabs.org,\n\tcbostic@linux.vnet.ibm.com, joel@jms.id.au,\n\t\"Edward A. James\" ","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"utf-8\"","X-Mailer":"MessagingEngine.com Webmail Interface - ajax-6cb49228","References":"<1506114362-492-1-git-send-email-eajames@linux.vnet.ibm.com>\n\t<1506114362-492-3-git-send-email-eajames@linux.vnet.ibm.com>","In-Reply-To":"<1506114362-492-3-git-send-email-eajames@linux.vnet.ibm.com>","Date":"Sat, 30 Sep 2017 06:07:16 +0930","Subject":"Re: [PATCH v3 2/6] drivers: fsi: Add SBEFIFO FSI client device\n\tdriver","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]