[{"id":1773955,"web_url":"http://patchwork.ozlabs.org/comment/1773955/","msgid":"","list_archive_url":null,"date":"2017-09-23T01:50:47","subject":"Re: [PATCH v2 03/12] ARM: dts: sunxi: h3/h5: Fix node with unit name\n\tand no reg property","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe\n wrote:\n> This patch fix the warning \"xxx has a unit name, but no reg property\" by\n> removing \"@0\" from such node.\n>\n> Signed-off-by: Corentin Labbe \n> Acked-by: Maxime Ripard \n> ---\n> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> index 289f2cd06dfe..2e4bae988acd 100644\n> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> @@ -322,7 +322,7 @@\n> function = \"i2c2\";\n> };\n>\n> - mmc0_pins_a: mmc0@0 {\n> + mmc0_pins_a: mmc0 {\n\nAll pinmux nodes should have the suffix \"_pins\" or \"_pin\".\n\nIn the case where there are multiple choices, the node name should convey\nwhat or which pingroup the choice is. In this case the name should be\n\"mmc0_pf_pins\".\n\n> pins = \"PF0\", \"PF1\", \"PF2\", \"PF3\",\n> \"PF4\", \"PF5\";\n> function = \"mmc0\";\n> @@ -330,13 +330,13 @@\n> bias-pull-up;\n> };\n>\n> - mmc0_cd_pin: mmc0_cd_pin@0 {\n> + mmc0_cd_pin: mmc0_cd_pin {\n> pins = \"PF6\";\n> function = \"gpio_in\";\n> bias-pull-up;\n> };\n>\n> - mmc1_pins_a: mmc1@0 {\n> + mmc1_pins_a: mmc1 {\n\nmmc1_pins\n\n> pins = \"PG0\", \"PG1\", \"PG2\", \"PG3\",\n> \"PG4\", \"PG5\";\n> function = \"mmc1\";\n> @@ -354,7 +354,7 @@\n> bias-pull-up;\n> };\n>\n> - spdif_tx_pins_a: spdif@0 {\n> + spdif_tx_pins_a: spdif {\n\nspdif_pin\n\n> pins = \"PA17\";\n> function = \"spdif\";\n> };\n> @@ -369,7 +369,7 @@\n> function = \"spi1\";\n> };\n>\n> - uart0_pins_a: uart0@0 {\n> + uart0_pins_a: uart0 {\n\nuart0_pb_pins\n\n> pins = \"PA4\", \"PA5\";\n> function = \"uart0\";\n> };\n> @@ -697,7 +697,7 @@\n> interrupt-controller;\n> #interrupt-cells = <3>;\n>\n> - ir_pins_a: ir@0 {\n> + ir_pins_a: ir {\n\nir_pin\n\nChenYu\n\n> pins = \"PL11\";\n> function = \"s_cir_rx\";\n> };\n> --\n> 2.13.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"QuFRvmci\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzYHX2xsqz9sxR\n\tfor ;\n\tSat, 23 Sep 2017 11:51:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvZbd-0006e2-W3; Sat, 23 Sep 2017 01:51:46 +0000","from smtp.csie.ntu.edu.tw ([140.112.30.61])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvZbZ-0006VB-V3 for linux-arm-kernel@lists.infradead.org;\n\tSat, 23 Sep 2017 01:51:44 +0000","from mail-wm0-f42.google.com (mail-wm0-f42.google.com\n\t[74.125.82.42])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id E919E2054E\n\tfor ;\n\tSat, 23 Sep 2017 09:51:11 +0800 (CST)","by mail-wm0-f42.google.com with SMTP id q124so7769291wmb.0\n\tfor ;\n\tFri, 22 Sep 2017 18:51:11 -0700 (PDT)","by 10.223.196.226 with HTTP; Fri, 22 Sep 2017 18:50:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=RfNx4aTuxUsX3mZFU3DbndBeYEzV/ZdObJEh5e2tSSc=;\n\tb=QuFRvmciXFSgM9\n\tOZQCdlWk3j/DIjzfqI8qvYreTjV0AyJ6HNt9dQAJk/Q6FHoqOLbXUHT5hdhUNt/fO8eINT/ERzPv7\n\tIQEPUfuclZVKlMfYtVc2XPzBzUsqpgWKWjIYnIFRxVRSP0aA9MbWuTA3znUq3q3M2b7yC7YhTzaDK\n\tyFMKWBoDdmOFXmJBl+moj20qnMC5nl91h0SGKh8AIPLAelsru6HPFOTePzrLCu1rEr05xFLeDvExk\n\t5Y5UDVu13xfUL/ob4kWzFq1e7NuZLvSScpcVFyhV3g5S1JCO2ia/qz43h0TKEg2BJ0zcxoVXoL8iS\n\tymdtfCOmOtCBJNx/c2Sg==;","X-Gm-Message-State":"AHPjjUiTXmk7rTOntOtG134ZYMUSLtDBscMpgAnpWTVwzvEDDMAbO6T3\n\tN7AXyVKM7MKL4fm/+JZJSLeaUSMbjOkpXRWq9CY=","X-Google-Smtp-Source":"AOwi7QDo0HVlH8B7KOvwXAAlMltIy04au5k0qJRZkyv+CZWcOwyFVB3IwIqQ+7WSjsOmPpc87jO4oyJi/WkH2fq2mO8=","X-Received":"by 10.28.29.77 with SMTP id d74mr4686949wmd.106.1506131468534;\n\tFri, 22 Sep 2017 18:51:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170922184045.6498-4-clabbe.montjoie@gmail.com>","References":"<20170922184045.6498-1-clabbe.montjoie@gmail.com>\n\t<20170922184045.6498-4-clabbe.montjoie@gmail.com>","From":"Chen-Yu Tsai ","Date":"Sat, 23 Sep 2017 09:50:47 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v2 03/12] ARM: dts: sunxi: h3/h5: Fix node with unit name\n\tand no reg property","To":"Corentin Labbe ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_185142_337251_E1737F2F ","X-CRM114-Status":"GOOD ( 13.01 )","X-Spam-Score":"-2.8 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [140.112.30.61 listed in list.dnswl.org]\n\t1.4 RCVD_IN_BRBL_LASTEXT RBL: No description available.\n\t[140.112.30.61 listed in bb.barracudacentral.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland ,\n\tdevicetree ,\n\tCatalin Marinas ,\n\tWill Deacon , Russell King ,\n\tlinux-kernel ,\n\tChen-Yu Tsai , Rob Herring ,\n\tMaxime Ripard ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773959,"web_url":"http://patchwork.ozlabs.org/comment/1773959/","msgid":"","list_archive_url":null,"date":"2017-09-23T02:29:28","subject":"Re: [PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name\n\tand no reg property","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe\n wrote:\n> This patch fix the warning \"xxx has a unit name, but no reg property\" by\n> removing \"@0\" from such node\n>\n> Signed-off-by: Corentin Labbe \n> Acked-by: Maxime Ripard \n> ---\n> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi\n> index 662e8b7981b5..b02a8476b0c8 100644\n> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi\n> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi\n> @@ -347,7 +347,7 @@\n> function = \"spi1\";\n> };\n>\n> - uart0_pins_a: uart0@0 {\n> + uart0_pins_a: uart0 {\n\nSame here. This should be uart0_pb_pins.\n\n> pins = \"PB8\", \"PB9\";\n> function = \"uart0\";\n> };\n> @@ -571,7 +571,7 @@\n> interrupt-controller;\n> #interrupt-cells = <3>;\n>\n> - r_rsb_pins: rsb@0 {\n> + r_rsb_pins: rsb {\n\nAnd this rsb_pins.\n\nChenYu\n\n> pins = \"PL0\", \"PL1\";\n> function = \"s_rsb\";\n> };\n> --\n> 2.13.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"LhryCY18\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzZ8357qMz9t3w\n\tfor ;\n\tSat, 23 Sep 2017 12:30:27 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvaD2-0007OI-Bs; Sat, 23 Sep 2017 02:30:24 +0000","from smtp.csie.ntu.edu.tw ([140.112.30.61])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvaCy-00065Z-1M for linux-arm-kernel@lists.infradead.org;\n\tSat, 23 Sep 2017 02:30:21 +0000","from mail-wr0-f174.google.com (mail-wr0-f174.google.com\n\t[209.85.128.174])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id B87B621074\n\tfor ;\n\tSat, 23 Sep 2017 10:29:51 +0800 (CST)","by mail-wr0-f174.google.com with SMTP id r74so2023420wrb.13\n\tfor ;\n\tFri, 22 Sep 2017 19:29:51 -0700 (PDT)","by 10.223.196.226 with HTTP; Fri, 22 Sep 2017 19:29:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=tlMKtkTFl+PZOlpFAs8p32iBXfLSebM9WUC9SyORaL8=;\n\tb=LhryCY18aMDuT2\n\teD0V/pwJatrtzLPYCEty4ds7IM0y1bw4QHIgpggEZPRumtIV38XoUA+iIiY26rd4KLcBX6/P+VPKB\n\tTZkEnw2Wym7m2tlY+tK38YmnHEEPjGjNVmUFI8HTpUk91G1/KpzfkVLSIJ+LhdWhbXW/xpqpo1y/b\n\t5sxk6d7grq+SczhFvgphWCqFyK/La8hW4LlIGyZdGMUhWUVA40QRFl3oL9BjMEjObBeGwh13ppGIL\n\tOlzMTmWAl0jN7d5uYhqxqEs1MKuv7OSVtCc87sIeBQNLwq4t6y1bjdPKbJBBpRR7OMcMxOJ04N48s\n\thrAkQEIBV3y1OZqgQWRQ==;","X-Gm-Message-State":"AHPjjUillwMeVMrO4IZRKEBGVsCIgKgewDD4IOHDNv1+c/3HosK+Ck3F\n\taiKCHAjnLSZ+7dpnTNqu8EBeMlHW3KP1eucVX3c=","X-Google-Smtp-Source":"AOwi7QD4Mnnx1J+zM0PZNyfGANyAVimuqbOtOrH+0r8Lm9zcAxHaZAzhh+F3ROnfHtEJQ/U0KTce6TEDG7rEfxZFkd8=","X-Received":"by 10.223.182.166 with SMTP id j38mr767291wre.55.1506133788607; \n\tFri, 22 Sep 2017 19:29:48 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170922184045.6498-12-clabbe.montjoie@gmail.com>","References":"<20170922184045.6498-1-clabbe.montjoie@gmail.com>\n\t<20170922184045.6498-12-clabbe.montjoie@gmail.com>","From":"Chen-Yu Tsai ","Date":"Sat, 23 Sep 2017 10:29:28 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name\n\tand no reg property","To":"Corentin Labbe ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_193020_273319_0359D184 ","X-CRM114-Status":"GOOD ( 12.06 )","X-Spam-Score":"-2.8 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [140.112.30.61 listed in list.dnswl.org]\n\t1.4 RCVD_IN_BRBL_LASTEXT RBL: No description available.\n\t[140.112.30.61 listed in bb.barracudacentral.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland ,\n\tdevicetree ,\n\tCatalin Marinas ,\n\tWill Deacon , Russell King ,\n\tlinux-kernel ,\n\tChen-Yu Tsai , Rob Herring ,\n\tMaxime Ripard ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]