[{"id":1773954,"web_url":"http://patchwork.ozlabs.org/comment/1773954/","msgid":"","list_archive_url":null,"date":"2017-09-23T01:50:47","subject":"Re: [PATCH v2 03/12] ARM: dts: sunxi: h3/h5: Fix node with unit name\n\tand no reg property","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe\n wrote:\n> This patch fix the warning \"xxx has a unit name, but no reg property\" by\n> removing \"@0\" from such node.\n>\n> Signed-off-by: Corentin Labbe \n> Acked-by: Maxime Ripard \n> ---\n> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> index 289f2cd06dfe..2e4bae988acd 100644\n> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> @@ -322,7 +322,7 @@\n> function = \"i2c2\";\n> };\n>\n> - mmc0_pins_a: mmc0@0 {\n> + mmc0_pins_a: mmc0 {\n\nAll pinmux nodes should have the suffix \"_pins\" or \"_pin\".\n\nIn the case where there are multiple choices, the node name should convey\nwhat or which pingroup the choice is. In this case the name should be\n\"mmc0_pf_pins\".\n\n> pins = \"PF0\", \"PF1\", \"PF2\", \"PF3\",\n> \"PF4\", \"PF5\";\n> function = \"mmc0\";\n> @@ -330,13 +330,13 @@\n> bias-pull-up;\n> };\n>\n> - mmc0_cd_pin: mmc0_cd_pin@0 {\n> + mmc0_cd_pin: mmc0_cd_pin {\n> pins = \"PF6\";\n> function = \"gpio_in\";\n> bias-pull-up;\n> };\n>\n> - mmc1_pins_a: mmc1@0 {\n> + mmc1_pins_a: mmc1 {\n\nmmc1_pins\n\n> pins = \"PG0\", \"PG1\", \"PG2\", \"PG3\",\n> \"PG4\", \"PG5\";\n> function = \"mmc1\";\n> @@ -354,7 +354,7 @@\n> bias-pull-up;\n> };\n>\n> - spdif_tx_pins_a: spdif@0 {\n> + spdif_tx_pins_a: spdif {\n\nspdif_pin\n\n> pins = \"PA17\";\n> function = \"spdif\";\n> };\n> @@ -369,7 +369,7 @@\n> function = \"spi1\";\n> };\n>\n> - uart0_pins_a: uart0@0 {\n> + uart0_pins_a: uart0 {\n\nuart0_pb_pins\n\n> pins = \"PA4\", \"PA5\";\n> function = \"uart0\";\n> };\n> @@ -697,7 +697,7 @@\n> interrupt-controller;\n> #interrupt-cells = <3>;\n>\n> - ir_pins_a: ir@0 {\n> + ir_pins_a: ir {\n\nir_pin\n\nChenYu\n\n> pins = \"PL11\";\n> function = \"s_cir_rx\";\n> };\n> --\n> 2.13.5\n>\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzYGy0S66z9t32\n\tfor ;\n\tSat, 23 Sep 2017 11:51:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752015AbdIWBvU (ORCPT\n\t);\n\tFri, 22 Sep 2017 21:51:20 -0400","from smtp.csie.ntu.edu.tw ([140.112.30.61]:50014 \"EHLO\n\tsmtp.csie.ntu.edu.tw\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751845AbdIWBvT (ORCPT\n\t); Fri, 22 Sep 2017 21:51:19 -0400","from mail-wm0-f43.google.com (mail-wm0-f43.google.com\n\t[74.125.82.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id 00FB22061A;\n\tSat, 23 Sep 2017 09:51:11 +0800 (CST)","by mail-wm0-f43.google.com with SMTP id q124so7769292wmb.0;\n\tFri, 22 Sep 2017 18:51:11 -0700 (PDT)","by 10.223.196.226 with HTTP; Fri, 22 Sep 2017 18:50:47 -0700 (PDT)"],"X-Gm-Message-State":"AHPjjUgR3Tl2Kr0RZ4EotPQqFBLhIKBMrtgLgkgqKF8m/ap6JKEtCxW/\n\tYj7TWJMROcNFQF8KcTUH6cXLg6vojIRW2c5SGjU=","X-Google-Smtp-Source":"AOwi7QDo0HVlH8B7KOvwXAAlMltIy04au5k0qJRZkyv+CZWcOwyFVB3IwIqQ+7WSjsOmPpc87jO4oyJi/WkH2fq2mO8=","X-Received":"by 10.28.29.77 with SMTP id d74mr4686949wmd.106.1506131468534;\n\tFri, 22 Sep 2017 18:51:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170922184045.6498-4-clabbe.montjoie@gmail.com>","References":"<20170922184045.6498-1-clabbe.montjoie@gmail.com>\n\t<20170922184045.6498-4-clabbe.montjoie@gmail.com>","From":"Chen-Yu Tsai ","Date":"Sat, 23 Sep 2017 09:50:47 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v2 03/12] ARM: dts: sunxi: h3/h5: Fix node with unit name\n\tand no reg property","To":"Corentin Labbe ","Cc":"Rob Herring , Mark Rutland ,\n\tRussell King ,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Catalin Marinas , \n\tWill Deacon ,\n\tdevicetree , \n\tlinux-arm-kernel ,\n\tlinux-kernel ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773958,"web_url":"http://patchwork.ozlabs.org/comment/1773958/","msgid":"","list_archive_url":null,"date":"2017-09-23T02:29:28","subject":"Re: [PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name\n\tand no reg property","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Sat, Sep 23, 2017 at 2:40 AM, Corentin Labbe\n wrote:\n> This patch fix the warning \"xxx has a unit name, but no reg property\" by\n> removing \"@0\" from such node\n>\n> Signed-off-by: Corentin Labbe \n> Acked-by: Maxime Ripard \n> ---\n> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi\n> index 662e8b7981b5..b02a8476b0c8 100644\n> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi\n> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi\n> @@ -347,7 +347,7 @@\n> function = \"spi1\";\n> };\n>\n> - uart0_pins_a: uart0@0 {\n> + uart0_pins_a: uart0 {\n\nSame here. This should be uart0_pb_pins.\n\n> pins = \"PB8\", \"PB9\";\n> function = \"uart0\";\n> };\n> @@ -571,7 +571,7 @@\n> interrupt-controller;\n> #interrupt-cells = <3>;\n>\n> - r_rsb_pins: rsb@0 {\n> + r_rsb_pins: rsb {\n\nAnd this rsb_pins.\n\nChenYu\n\n> pins = \"PL0\", \"PL1\";\n> function = \"s_rsb\";\n> };\n> --\n> 2.13.5\n>\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzZ7S1lK3z9t42\n\tfor ;\n\tSat, 23 Sep 2017 12:29:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751900AbdIWC3y (ORCPT\n\t);\n\tFri, 22 Sep 2017 22:29:54 -0400","from smtp.csie.ntu.edu.tw ([140.112.30.61]:50080 \"EHLO\n\tsmtp.csie.ntu.edu.tw\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751897AbdIWC3x (ORCPT\n\t); Fri, 22 Sep 2017 22:29:53 -0400","from mail-wr0-f171.google.com (mail-wr0-f171.google.com\n\t[209.85.128.171])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id B1065206DA;\n\tSat, 23 Sep 2017 10:29:51 +0800 (CST)","by mail-wr0-f171.google.com with SMTP id l22so2041108wrc.10;\n\tFri, 22 Sep 2017 19:29:51 -0700 (PDT)","by 10.223.196.226 with HTTP; Fri, 22 Sep 2017 19:29:28 -0700 (PDT)"],"X-Gm-Message-State":"AHPjjUiYPTFZUSoGZE420gkvrdmbUf2PjVGodOwqGzOcRWSCQIUaA2RK\n\tytGY9NxhRzcdrkLWxi13BV0FHOjlHeIZKnxyyys=","X-Google-Smtp-Source":"AOwi7QD4Mnnx1J+zM0PZNyfGANyAVimuqbOtOrH+0r8Lm9zcAxHaZAzhh+F3ROnfHtEJQ/U0KTce6TEDG7rEfxZFkd8=","X-Received":"by 10.223.182.166 with SMTP id j38mr767291wre.55.1506133788607; \n\tFri, 22 Sep 2017 19:29:48 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170922184045.6498-12-clabbe.montjoie@gmail.com>","References":"<20170922184045.6498-1-clabbe.montjoie@gmail.com>\n\t<20170922184045.6498-12-clabbe.montjoie@gmail.com>","From":"Chen-Yu Tsai ","Date":"Sat, 23 Sep 2017 10:29:28 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v2 11/12] arm64: allwinner: a64: Fix node with unit name\n\tand no reg property","To":"Corentin Labbe ","Cc":"Rob Herring , Mark Rutland ,\n\tRussell King ,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Catalin Marinas , \n\tWill Deacon ,\n\tdevicetree , \n\tlinux-arm-kernel ,\n\tlinux-kernel ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]