[{"id":1776536,"web_url":"http://patchwork.ozlabs.org/comment/1776536/","msgid":"<20170927184704.jbilalgfjevhqyvn@calabresa>","list_archive_url":null,"date":"2017-09-27T18:47:04","subject":"NACK: [Xenial SRU][PATCH 0/3] Fix CVE-2015-8952","submitter":{"id":70574,"url":"http://patchwork.ozlabs.org/api/people/70574/","name":"Thadeu Lima de Souza Cascardo","email":"cascardo@canonical.com"},"content":"On Fri, Sep 22, 2017 at 05:11:27PM +0800, Shrirang Bagul wrote:\n> This set of patches fixes CVE-2015-8952. The mbcache2 implementation and\n> ext2 patches are a clean cherry-pick from upstream. The ext4 patch however\n> is a backport to accomodate changes from patch:\n> ext4: lock the xattr block before checksuming it\n> (c6d5612f80923170dad06c04736984cc9bcc8568)\n> merged to fix LP:1658633\n> \n> Jan Kara (3):\n> mbcache2: reimplement mbcache\n> ext2: convert to mbcache2\n> ext4: convert to mbcache2\n> \n> fs/Makefile | 2 +-\n> fs/ext2/ext2.h | 3 +\n> fs/ext2/super.c | 25 ++--\n> fs/ext2/xattr.c | 143 +++++++++----------\n> fs/ext2/xattr.h | 21 +--\n> fs/ext4/ext4.h | 2 +-\n> fs/ext4/super.c | 7 +-\n> fs/ext4/xattr.c | 136 +++++++++---------\n> fs/ext4/xattr.h | 5 +-\n> fs/mbcache2.c | 359 +++++++++++++++++++++++++++++++++++++++++++++++\n> include/linux/mbcache2.h | 50 +++++++\n> 11 files changed, 577 insertions(+), 176 deletions(-)\n> create mode 100644 fs/mbcache2.c\n> create mode 100644 include/linux/mbcache2.h\n> \n> -- \n> 2.11.0\n\nHi, Shrirang.\n\nThanks for that work. But I have already started it. Look at\nhttps://lists.ubuntu.com/archives/kernel-team/2017-September/086949.html.\n\nNext time, take a look at the list, or reach us out on IRC, so we don't\nduplicate work.\n\nIt would be nice, though, if you could review my version and verify if\nwe did backport the ext4 change the same way.\n\nThanks.\nCascardo.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2RdD7410z9tXQ;\n\tThu, 28 Sep 2017 04:47:12 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dxHMT-0005uQ-D9; Wed, 27 Sep 2017 18:47:09 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dxHMR-0005sr-5B\n\tfor kernel-team@lists.ubuntu.com; Wed, 27 Sep 2017 18:47:07 +0000","from 1.general.cascardo.us.vpn ([10.172.70.58] helo=calabresa)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from )\n\tid 1dxHMQ-0000Qm-Pc; Wed, 27 Sep 2017 18:47:06 +0000"],"Date":"Wed, 27 Sep 2017 15:47:04 -0300","From":"Thadeu Lima de Souza Cascardo ","To":"Shrirang Bagul ","Subject":"NACK: [Xenial SRU][PATCH 0/3] Fix CVE-2015-8952","Message-ID":"<20170927184704.jbilalgfjevhqyvn@calabresa>","References":"<20170922091130.15674-1-shrirang.bagul@canonical.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170922091130.15674-1-shrirang.bagul@canonical.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1776726,"web_url":"http://patchwork.ozlabs.org/comment/1776726/","msgid":"<1506566737.4847.1.camel@canonical.com>","list_archive_url":null,"date":"2017-09-28T02:45:37","subject":"Re: NACK: [Xenial SRU][PATCH 0/3] Fix CVE-2015-8952","submitter":{"id":69376,"url":"http://patchwork.ozlabs.org/api/people/69376/","name":"Shrirang Bagul","email":"shrirang.bagul@canonical.com"},"content":"On Wed, 2017-09-27 at 15:47 -0300, Thadeu Lima de Souza Cascardo wrote:\n> On Fri, Sep 22, 2017 at 05:11:27PM +0800, Shrirang Bagul wrote:\n> > This set of patches fixes CVE-2015-8952. The mbcache2 implementation and\n> > ext2 patches are a clean cherry-pick from upstream. The ext4 patch however\n> > is a backport to accomodate changes from patch:\n> >   ext4: lock the xattr block before checksuming it\n> >   (c6d5612f80923170dad06c04736984cc9bcc8568)\n> > merged to fix LP:1658633\n> > \n> > Jan Kara (3):\n> >   mbcache2: reimplement mbcache\n> >   ext2: convert to mbcache2\n> >   ext4: convert to mbcache2\n> > \n> >  fs/Makefile              |   2 +-\n> >  fs/ext2/ext2.h           |   3 +\n> >  fs/ext2/super.c          |  25 ++--\n> >  fs/ext2/xattr.c          | 143 +++++++++----------\n> >  fs/ext2/xattr.h          |  21 +--\n> >  fs/ext4/ext4.h           |   2 +-\n> >  fs/ext4/super.c          |   7 +-\n> >  fs/ext4/xattr.c          | 136 +++++++++---------\n> >  fs/ext4/xattr.h          |   5 +-\n> >  fs/mbcache2.c            | 359 +++++++++++++++++++++++++++++++++++++++++++++++\n> >  include/linux/mbcache2.h |  50 +++++++\n> >  11 files changed, 577 insertions(+), 176 deletions(-)\n> >  create mode 100644 fs/mbcache2.c\n> >  create mode 100644 include/linux/mbcache2.h\n> > \n> > -- \n> > 2.11.0\n> \n> Hi, Shrirang.\n> \n> Thanks for that work. But I have already started it. Look at\n> https://lists.ubuntu.com/archives/kernel-team/2017-September/086949.html.\nMust have slipped through the mailbox filters, missed this one.\n> \n> Next time, take a look at the list, or reach us out on IRC, so we don't\n> duplicate work.\nGot it.\n> It would be nice, though, if you could review my version and verify if\n> we did backport the ext4 change the same way.\nYour work on this CVE is exactly the same as my attempt. However, I saw comments from\nStefan, he has some reservations about this fix. Any updates?\n\n-Shrirang\n> \n> Thanks.\n> Cascardo.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2fFX4DLyz9t5C;\n\tThu, 28 Sep 2017 12:45:52 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dxOpe-0003Bu-0o; Thu, 28 Sep 2017 02:45:46 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dxOpb-0003BP-OU\n\tfor kernel-team@lists.ubuntu.com; Thu, 28 Sep 2017 02:45:43 +0000","from mail-pg0-f70.google.com ([74.125.83.70])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dxOpb-0005K8-Cm\n\tfor kernel-team@lists.ubuntu.com; Thu, 28 Sep 2017 02:45:43 +0000","by mail-pg0-f70.google.com with SMTP id p5so565051pgn.7\n\tfor ;\n\tWed, 27 Sep 2017 19:45:43 -0700 (PDT)","from snb-ubuntu (122-116-76-153.HINET-IP.hinet.net.\n\t[122.116.76.153]) by smtp.googlemail.com with ESMTPSA id\n\ti189sm434878pfg.159.2017.09.27.19.45.39\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Sep 2017 19:45:40 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QtQYGxXZ1pv5gmnN1D+hKe9DzMc5G3frrD92olibOdM=;\n\tb=LSNNhbbsQhrXnZexsdDCSOPoc2cyi6wjKAQXn76QLZVZXArRg824eGEXdoLOvkpMEc\n\teeZIgB9sA2wAAmE51kMtSew0J+utiE0iYtasocQNXPxS5GPBeNsKokgIzri0CKvn/hwe\n\t9wafn+s3GEhn4Acz8+WL+Y7syeb1+9AiSYPuKh+WwoMlsh/nIya7a4YHJSx/qtnLe3G/\n\t+wXeQ8UYUPdokFuAzzxkCS3MX0VueVF9hd59qSrwnLNV+0ncSBrdbTS8uKkJ4yOU6ssQ\n\tb6hKuti+5IoPVzay3fevtT0VhyX6groNqYxb3E1EaPGS7BtZewJ//eHAZ2Ddpb1oUgX+\n\tJqGA==","X-Gm-Message-State":"AHPjjUgR3kMQ1amdnGsT/MYPskyyriI8X4Rtnvy/72/RTh85O1Jba+Ga\n\tKGfRiqUn5s6Teg4awhBB9Zfr5hfgwo2AsWiHepsM/rgu/Z5+DvbppqCgMVGqwqf65UG4x/WX6Hm\n\tqzRBkTve/H6HIpcDZp9zPsxHYxn+hB4+sY4qns629+g==","X-Received":["by 10.98.18.215 with SMTP id 84mr3049155pfs.42.1506566742010;\n\tWed, 27 Sep 2017 19:45:42 -0700 (PDT)","by 10.98.18.215 with SMTP id 84mr3049146pfs.42.1506566741773;\n\tWed, 27 Sep 2017 19:45:41 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QCtqUqKp3M715s3dhDzZ35qkhP5rbEFpHV9MfjETaYY4bqRh75j1M3eEDCSmTswLZMlJxJGKA==","Message-ID":"<1506566737.4847.1.camel@canonical.com>","Subject":"Re: NACK: [Xenial SRU][PATCH 0/3] Fix CVE-2015-8952","From":"Shrirang Bagul ","To":"Thadeu Lima de Souza Cascardo ","Date":"Thu, 28 Sep 2017 10:45:37 +0800","In-Reply-To":"<20170927184704.jbilalgfjevhqyvn@calabresa>","References":"<20170922091130.15674-1-shrirang.bagul@canonical.com>\n\t<20170927184704.jbilalgfjevhqyvn@calabresa>","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]