[{"id":1778516,"web_url":"http://patchwork.ozlabs.org/comment/1778516/","msgid":"","list_archive_url":null,"date":"2017-10-02T18:42:09","subject":"Re: [Qemu-devel] [RFC v2 0/2] Add a valid_cpu_types property","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Thu, Sep 21, 2017 at 4:41 PM, Alistair Francis\n wrote:\n> There are numorous QEMU machines that only have a single or a handful of\n> valid CPU options. To simplyfy the management of specificying which CPU\n> is/isn't valid let's create a property that can be set in the machine\n> init. We can then check to see if the user supplied CPU is in that list\n> or not.\n>\n> Here is what specifying the CPUs looks like now:\n>\n> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-m3\" -S\n> QEMU 2.10.50 monitor - type 'help' for more information\n> (qemu) info cpus\n> * CPU #0: thread_id=24175\n> (qemu) q\n>\n> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-m4\" -S\n> QEMU 2.10.50 monitor - type 'help' for more information\n> (qemu) q\n>\n> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-m5\" -S\n> qemu-system-aarch64: unable to find CPU model 'cortex-m5'\n>\n> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-a9\" -S\n> qemu-system-aarch64: Invalid CPU: cortex-a9-arm-cpu\n> The valid options are: cortex-m3-arm-cpu, cortex-m4-arm-cpu\n>\n\nAny comments on this?\n\nOtherwise I'll prepare a patch series and start adding support for\nmore machines.\n\nThanks,\nAlistair\n\n> RFC v2:\n> - Rebase on Igor's work\n> - Use more QEMUisms inside the code\n> - List the supported machines in a NULL terminated array\n>\n> Alistair Francis (2):\n> machine: Add a valid_cpu_types property\n> netduino2: Specify the valid CPUs\n>\n> hw/arm/netduino2.c | 10 +++++++++-\n> hw/core/machine.c | 35 +++++++++++++++++++++++++++++++++++\n> include/hw/boards.h | 1 +\n> 3 files changed, 45 insertions(+), 1 deletion(-)\n>\n> --\n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fRBJszGu\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5WJD6wcRz9rxl\n\tfor ;\n\tTue, 3 Oct 2017 05:43:08 +1100 (AEDT)","from localhost ([::1]:53716 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dz5gJ-0002Fy-4W\n\tfor incoming@patchwork.ozlabs.org; Mon, 02 Oct 2017 14:43:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35888)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dz5fu-0002Fl-DO\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 14:42:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dz5ft-0004nO-JK\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 14:42:42 -0400","from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:37292)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dz5ft-0004mS-CK\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 14:42:41 -0400","by mail-wr0-x243.google.com with SMTP id v38so1399178wrc.4\n\tfor ; Mon, 02 Oct 2017 11:42:41 -0700 (PDT)","by 10.28.167.88 with HTTP; Mon, 2 Oct 2017 11:42:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=+1tfWkOXvOrV3marhQ/21PY61xu2DVssCZZEWeEnIhM=;\n\tb=fRBJszGuQwUIq+T1DqfDoBUiW215QJ6ImDUkVNxJW5MasujqiNaenCl9Svuhy/fS9f\n\tAuMxws97NpomY0h6nOTijHbdG84G4QaIwU2zdd3C5TBAq70NyoxD3F6NzqDq5xlzctlP\n\t+/B9uSkmxTNbsbqK3I6wvcPbxLoLZkdGEbhFGHOZMwPlYIzaMwiSE8ufo6qr4HOxkxPQ\n\tFJvLceN9l2c0QCGH2UiLqQbMdljKzWInktqIfqH+F5LJGMmRvl8wFTUa+KvZYYjsSnMM\n\trkIp3o1yS9ujfQZ/sHUFxleZev7nlAHO7/6VHT5sAX+C4N9zEJhD3ManQhstr6u97jcH\n\taR3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=+1tfWkOXvOrV3marhQ/21PY61xu2DVssCZZEWeEnIhM=;\n\tb=uPLJxSySqOPCmErocarDSK/UR3yzsNdDOxqgRwsvAylvAKKOyLuLLffK8qvf1GLYfX\n\tQWYp2HD5Cy7OkzOAQpGnSxsntmv61vrBqWj6I8RDx1di08gHVliLTYwbWgbxzgLT60eE\n\t5FCTmTN+BZ/jFA/xsS5hl32WmubGApn1mc3Byjw8MEJ2XzvZtYA9gtJrR2Nbm4U5Ld67\n\ti6jIqc1lwBm/69O5NTTJzLidSmaplSpdXA2gpeaYrJFBkdqU5p7q/pQNIyqfuGZ3C7A0\n\tFcQzmA/KbLzXHqUKdxQsreZlFbohNi6ywje3PedaI6XlZ9rOJoYqsfX4Rjd2i+sNrq+A\n\tVuww==","X-Gm-Message-State":"AHPjjUibU7lp7ldRuBuQN9XyclRDmSrHah78XvEkspg+IYsgh4myk8pj\n\tDKaT6VELS1n9svzxWPLCiiQJbWLsYCJ7wNrhYY0=","X-Google-Smtp-Source":"AOwi7QCUj6aZs4AgJ6ZkM/3PEz11P7j4KqudAQNllpocReHDM2dXT3I8bVtM7cAWQBRfLR4298kmo2JyFBEpZ/EDtCc=","X-Received":"by 10.223.169.143 with SMTP id\n\tb15mr16885101wrd.127.1506969760274; \n\tMon, 02 Oct 2017 11:42:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"Alistair Francis ","Date":"Mon, 2 Oct 2017 11:42:09 -0700","Message-ID":"","To":"Alistair Francis ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::243","Subject":"Re: [Qemu-devel] [RFC v2 0/2] Add a valid_cpu_types property","X-BeenThere":"qemu-devel@gnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Marcel Apfelbaum , Igor Mammedov ,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tEduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1778552,"web_url":"http://patchwork.ozlabs.org/comment/1778552/","msgid":"<1aef9623-b4ee-867b-e495-4a3ebdd4064a@amsat.org>","list_archive_url":null,"date":"2017-10-02T19:41:11","subject":"Re: [Qemu-devel] [RFC v2 0/2] Add a valid_cpu_types property","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Alistair,\n\nOn 10/02/2017 03:42 PM, Alistair Francis wrote:\n> On Thu, Sep 21, 2017 at 4:41 PM, Alistair Francis\n> wrote:\n>> There are numorous QEMU machines that only have a single or a handful of\n>> valid CPU options. To simplyfy the management of specificying which CPU\n>> is/isn't valid let's create a property that can be set in the machine\n>> init. We can then check to see if the user supplied CPU is in that list\n>> or not.\n>>\n>> Here is what specifying the CPUs looks like now:\n>>\n>> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-m3\" -S\n>> QEMU 2.10.50 monitor - type 'help' for more information\n>> (qemu) info cpus\n>> * CPU #0: thread_id=24175\n>> (qemu) q\n>>\n>> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-m4\" -S\n>> QEMU 2.10.50 monitor - type 'help' for more information\n>> (qemu) q\n>>\n>> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-m5\" -S\n>> qemu-system-aarch64: unable to find CPU model 'cortex-m5'\n>>\n>> $ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu \"cortex-a9\" -S\n>> qemu-system-aarch64: Invalid CPU: cortex-a9-arm-cpu\n>> The valid options are: cortex-m3-arm-cpu, cortex-m4-arm-cpu\n>>\n> \n> Any comments on this?\n\nNo negative comment, so far so good!\n\n> \n> Otherwise I'll prepare a patch series and start adding support for\n> more machines.\n\nYes please, I'm waiting your work get merged to continue some SoC \ncleanups/improvements.\n\n> \n> Thanks,\n> Alistair\n> \n>> RFC v2:\n>> - Rebase on Igor's work\n>> - Use more QEMUisms inside the code\n>> - List the supported machines in a NULL terminated array\n>>\n>> Alistair Francis (2):\n>> machine: Add a valid_cpu_types property\n>> netduino2: Specify the valid CPUs\n>>\n>> hw/arm/netduino2.c | 10 +++++++++-\n>> hw/core/machine.c | 35 +++++++++++++++++++++++++++++++++++\n>> include/hw/boards.h | 1 +\n>> 3 files changed, 45 insertions(+), 1 deletion(-)\n>>\n>> --\n>> 2.11.0\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bXNzRhEP\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5Xc10qDYz9t2Q\n\tfor ;\n\tTue, 3 Oct 2017 06:41:51 +1100 (AEDT)","from localhost ([::1]:53902 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dz6b7-0001Ek-Ux\n\tfor incoming@patchwork.ozlabs.org; Mon, 02 Oct 2017 15:41:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60611)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dz6af-0001DY-0o\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 15:41:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dz6aa-0000bM-Ma\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 15:41:21 -0400","from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:33060)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dz6aa-0000aa-GK\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 15:41:16 -0400","by mail-qk0-x244.google.com with SMTP id z12so1380573qkb.0\n\tfor ; Mon, 02 Oct 2017 12:41:16 -0700 (PDT)","from [192.168.1.240] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tt184sm7125152qkc.74.2017.10.02.12.41.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 02 Oct 2017 12:41:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=BGlieH+CqIOsQJOP9LECSmglkQV22509Dj0ozZ+sWBo=;\n\tb=bXNzRhEP/bKJ6Fr1mbUCnNHOt8xFkuQWRhDUanJDnW/n3ImLJneFCmxi0XSVcBFQ1n\n\tFav4CJzfxqC39KvuY60pjteYvmrixuIC6C6CWnzJ/oJMXRZWSKyKZYVf57B2S5ETT+XG\n\tlJl0/rqUVynKQ65v9qWWiWyWAzaCcZnCvx9nkVGw0yoJ7HBYm+6xDzHWT3c3b9eWMB4t\n\tLKz12aaFNT6EAnSuc65ju01USpVbnp/3hIqndo8mWhyn8jNBaVMcX1b4r2KZoeOClIwl\n\ty0XkHoqHqXEwuC90kkppgoUaZtNJvH3RuNhESRSOOoLaO9LWRerCNdsCjJlx3sz/QLWO\n\ty7sw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=BGlieH+CqIOsQJOP9LECSmglkQV22509Dj0ozZ+sWBo=;\n\tb=f7vaD7DldVeiRj0h5a1spJkHfY9eDyOLaEo54IJjCIKBD0/y+fkGXJdwfuwivAuID/\n\td/xDerAI/Kebwr10bIP9vF+suer8Z2rQf8HkEd69DCQS4h2B9nW6apkUG1/DA3wHDtcs\n\tnvgo7W7SYaHfzYAIcz19d5q+b+1Txj2HvzvqD6C/ozZMkBNeLR/M9SNSt3Cxuh58sgKS\n\t5wquC7zjoQky19D50qjm5hryVOMTVTWoBgzcb7cX22N+VvQUT2rAVvfMRCRPNavz9rhD\n\tKDhbfpfm8sO6oeerY8gTLQZQ8pBJlu4RxRYHYLHnitkEcwz677alyptg23WlqKgNYAEL\n\tg0Bg==","X-Gm-Message-State":"AMCzsaXSBoDfRgbG0ZmIwF6wtjhZHlcwxA1+mxr3oc8itnBFUObsAeO9\n\tuZFJ/5eHVdXqh9mwZx/DPfw=","X-Google-Smtp-Source":"AOwi7QC5ulZ/zzA6+qxQB4Xdi73Mugwf8/mV2c0ekHBFVGBXPeJvqc9ApwDrAFO/jdPVKIJ15DbnpA==","X-Received":"by 10.55.161.200 with SMTP id k191mr9390958qke.158.1506973275336;\n\tMon, 02 Oct 2017 12:41:15 -0700 (PDT)","To":"Alistair Francis ,\n\tAlistair Francis ","References":"\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<1aef9623-b4ee-867b-e495-4a3ebdd4064a@amsat.org>","Date":"Mon, 2 Oct 2017 16:41:11 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::244","Subject":"Re: [Qemu-devel] [RFC v2 0/2] Add a valid_cpu_types property","X-BeenThere":"qemu-devel@gnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Marcel Apfelbaum , Igor Mammedov ,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tEduardo Habkost ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org","Sender":"\"Qemu-devel\"\n\t"}}]