[{"id":1773704,"web_url":"http://patchwork.ozlabs.org/comment/1773704/","msgid":"<7e694ed6-7b40-c895-9542-e445489cda18@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-22T15:39:35","subject":"Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream","submitter":{"id":66825,"url":"http://patchwork.ozlabs.org/api/people/66825/","name":"Pierre Morel","email":"pmorel@linux.vnet.ibm.com"},"content":"On 21/09/2017 20:08, Halil Pasic wrote:\n> Replace direct access which implicitly assumes no IDA\n> or MIDA with the new ccw data stream interface which should\n> cope with these transparently in the future.\n> \n> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>\n> Reviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>\n> Reviewed-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\n> ---\n>   hw/s390x/virtio-ccw.c | 155 +++++++++++++++-----------------------------------\n>   1 file changed, 46 insertions(+), 109 deletions(-)\n> \n> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c\n> index ff1bb1534c..e6fc25ebf4 100644\n> --- a/hw/s390x/virtio-ccw.c\n> +++ b/hw/s390x/virtio-ccw.c\n> @@ -287,49 +287,19 @@ static int virtio_ccw_handle_set_vq(SubchDev *sch, CCW1 ccw, bool check_len,\n>           return -EFAULT;\n>       }\n>       if (is_legacy) {\n> -        linfo.queue = address_space_ldq_be(&address_space_memory, ccw.cda,\n> -                                           MEMTXATTRS_UNSPECIFIED, NULL);\n> -        linfo.align = address_space_ldl_be(&address_space_memory,\n> -                                           ccw.cda + sizeof(linfo.queue),\n> -                                           MEMTXATTRS_UNSPECIFIED,\n> -                                           NULL);\n> -        linfo.index = address_space_lduw_be(&address_space_memory,\n> -                                            ccw.cda + sizeof(linfo.queue)\n> -                                            + sizeof(linfo.align),\n> -                                            MEMTXATTRS_UNSPECIFIED,\n> -                                            NULL);\n> -        linfo.num = address_space_lduw_be(&address_space_memory,\n> -                                          ccw.cda + sizeof(linfo.queue)\n> -                                          + sizeof(linfo.align)\n> -                                          + sizeof(linfo.index),\n> -                                          MEMTXATTRS_UNSPECIFIED,\n> -                                          NULL);\n> +        ccw_dstream_read(&sch->cds, linfo);\n> +        be64_to_cpus(&linfo.queue);\n> +        be32_to_cpus(&linfo.align);\n> +        be16_to_cpus(&linfo.index);\n> +        be16_to_cpus(&linfo.num);\n>           ret = virtio_ccw_set_vqs(sch, NULL, &linfo);\n>       } else {\n> -        info.desc = address_space_ldq_be(&address_space_memory, ccw.cda,\n> -                                           MEMTXATTRS_UNSPECIFIED, NULL);\n> -        info.index = address_space_lduw_be(&address_space_memory,\n> -                                           ccw.cda + sizeof(info.desc)\n> -                                           + sizeof(info.res0),\n> -                                           MEMTXATTRS_UNSPECIFIED, NULL);\n> -        info.num = address_space_lduw_be(&address_space_memory,\n> -                                         ccw.cda + sizeof(info.desc)\n> -                                         + sizeof(info.res0)\n> -                                         + sizeof(info.index),\n> -                                         MEMTXATTRS_UNSPECIFIED, NULL);\n> -        info.avail = address_space_ldq_be(&address_space_memory,\n> -                                          ccw.cda + sizeof(info.desc)\n> -                                          + sizeof(info.res0)\n> -                                          + sizeof(info.index)\n> -                                          + sizeof(info.num),\n> -                                          MEMTXATTRS_UNSPECIFIED, NULL);\n> -        info.used = address_space_ldq_be(&address_space_memory,\n> -                                         ccw.cda + sizeof(info.desc)\n> -                                         + sizeof(info.res0)\n> -                                         + sizeof(info.index)\n> -                                         + sizeof(info.num)\n> -                                         + sizeof(info.avail),\n> -                                         MEMTXATTRS_UNSPECIFIED, NULL);\n> +        ccw_dstream_read(&sch->cds, info);\n> +        be64_to_cpus(&info.desc);\n> +        be16_to_cpus(&info.index);\n> +        be16_to_cpus(&info.num);\n> +        be64_to_cpus(&info.avail);\n> +        be64_to_cpus(&info.used);\n>           ret = virtio_ccw_set_vqs(sch, &info, NULL);\n>       }\n>       sch->curr_status.scsw.count = 0;\n> @@ -342,15 +312,13 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>       VirtioRevInfo revinfo;\n>       uint8_t status;\n>       VirtioFeatDesc features;\n> -    void *config;\n>       hwaddr indicators;\n>       VqConfigBlock vq_config;\n>       VirtioCcwDevice *dev = sch->driver_data;\n>       VirtIODevice *vdev = virtio_ccw_get_vdev(sch);\n>       bool check_len;\n>       int len;\n> -    hwaddr hw_len;\n> -    VirtioThinintInfo *thinint;\n> +    VirtioThinintInfo thinint;\n> \n>       if (!dev) {\n>           return -EINVAL;\n> @@ -394,11 +362,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>           } else {\n>               VirtioDeviceClass *vdc = VIRTIO_DEVICE_GET_CLASS(vdev);\n> \n> -            features.index = address_space_ldub(&address_space_memory,\n> -                                                ccw.cda\n> -                                                + sizeof(features.features),\n> -                                                MEMTXATTRS_UNSPECIFIED,\n> -                                                NULL);\n> +            ccw_dstream_advance(&sch->cds, sizeof(features.features));\n> +            ccw_dstream_read(&sch->cds, features.index);\n>               if (features.index == 0) {\n>                   if (dev->revision >= 1) {\n>                       /* Don't offer legacy features for modern devices. */\n> @@ -417,9 +382,9 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>                   /* Return zeroes if the guest supports more feature bits. */\n>                   features.features = 0;\n>               }\n> -            address_space_stl_le(&address_space_memory, ccw.cda,\n> -                                 features.features, MEMTXATTRS_UNSPECIFIED,\n> -                                 NULL);\n> +            ccw_dstream_rewind(&sch->cds);\n> +            cpu_to_le32s(&features.features);\n> +            ccw_dstream_write(&sch->cds, features.features);\n>               sch->curr_status.scsw.count = ccw.count - sizeof(features);\n>               ret = 0;\n>           }\n> @@ -438,15 +403,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>           if (!ccw.cda) {\n>               ret = -EFAULT;\n>           } else {\n> -            features.index = address_space_ldub(&address_space_memory,\n> -                                                ccw.cda\n> -                                                + sizeof(features.features),\n> -                                                MEMTXATTRS_UNSPECIFIED,\n> -                                                NULL);\n> -            features.features = address_space_ldl_le(&address_space_memory,\n> -                                                     ccw.cda,\n> -                                                     MEMTXATTRS_UNSPECIFIED,\n> -                                                     NULL);\n> +            ccw_dstream_read(&sch->cds, features);\n> +            le32_to_cpus(&features.features);\n>               if (features.index == 0) {\n>                   virtio_set_features(vdev,\n>                                       (vdev->guest_features & 0xffffffff00000000ULL) |\n> @@ -487,7 +445,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>               ret = -EFAULT;\n>           } else {\n>               virtio_bus_get_vdev_config(&dev->bus, vdev->config);\n> -            cpu_physical_memory_write(ccw.cda, vdev->config, len);\n> +            ccw_dstream_write_buf(&sch->cds, vdev->config, len);\n>               sch->curr_status.scsw.count = ccw.count - len;\n>               ret = 0;\n>           }\n> @@ -500,20 +458,13 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>               }\n>           }\n>           len = MIN(ccw.count, vdev->config_len);\n> -        hw_len = len;\n>           if (!ccw.cda) {\n>               ret = -EFAULT;\n>           } else {\n> -            config = cpu_physical_memory_map(ccw.cda, &hw_len, 0);\n> -            if (!config) {\n> -                ret = -EFAULT;\n> -            } else {\n> -                len = hw_len;\n> -                memcpy(vdev->config, config, len);\n> -                cpu_physical_memory_unmap(config, hw_len, 0, hw_len);\n> +            ret = ccw_dstream_read_buf(&sch->cds, vdev->config, len);\n> +            if (!ret) {\n>                   virtio_bus_set_vdev_config(&dev->bus, vdev->config);\n>                   sch->curr_status.scsw.count = ccw.count - len;\n> -                ret = 0;\n>               }\n>           }\n>           break;\n> @@ -551,8 +502,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>           if (!ccw.cda) {\n>               ret = -EFAULT;\n>           } else {\n> -            status = address_space_ldub(&address_space_memory, ccw.cda,\n> -                                        MEMTXATTRS_UNSPECIFIED, NULL);\n> +            ccw_dstream_read(&sch->cds, status);\n>               if (!(status & VIRTIO_CONFIG_S_DRIVER_OK)) {\n>                   virtio_ccw_stop_ioeventfd(dev);\n>               }\n> @@ -595,8 +545,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>           if (!ccw.cda) {\n>               ret = -EFAULT;\n>           } else {\n> -            indicators = address_space_ldq_be(&address_space_memory, ccw.cda,\n> -                                              MEMTXATTRS_UNSPECIFIED, NULL);\n> +            ccw_dstream_read(&sch->cds, indicators);\n> +            be64_to_cpus(&indicators);\n>               dev->indicators = get_indicator(indicators, sizeof(uint64_t));\n>               sch->curr_status.scsw.count = ccw.count - sizeof(indicators);\n>               ret = 0;\n> @@ -616,8 +566,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>           if (!ccw.cda) {\n>               ret = -EFAULT;\n>           } else {\n> -            indicators = address_space_ldq_be(&address_space_memory, ccw.cda,\n> -                                              MEMTXATTRS_UNSPECIFIED, NULL);\n> +            ccw_dstream_read(&sch->cds, indicators);\n> +            be64_to_cpus(&indicators);\n>               dev->indicators2 = get_indicator(indicators, sizeof(uint64_t));\n>               sch->curr_status.scsw.count = ccw.count - sizeof(indicators);\n>               ret = 0;\n> @@ -637,67 +587,58 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>           if (!ccw.cda) {\n>               ret = -EFAULT;\n>           } else {\n> -            vq_config.index = address_space_lduw_be(&address_space_memory,\n> -                                                    ccw.cda,\n> -                                                    MEMTXATTRS_UNSPECIFIED,\n> -                                                    NULL);\n> +            ccw_dstream_read(&sch->cds, vq_config.index);\n> +            be16_to_cpus(&vq_config.index);\n>               if (vq_config.index >= VIRTIO_QUEUE_MAX) {\n>                   ret = -EINVAL;\n>                   break;\n>               }\n>               vq_config.num_max = virtio_queue_get_num(vdev,\n>                                                        vq_config.index);\n> -            address_space_stw_be(&address_space_memory,\n> -                                 ccw.cda + sizeof(vq_config.index),\n> -                                 vq_config.num_max,\n> -                                 MEMTXATTRS_UNSPECIFIED,\n> -                                 NULL);\n> +            cpu_to_be16s(&vq_config.num_max);\n> +            ccw_dstream_write(&sch->cds, vq_config.num_max);\n>               sch->curr_status.scsw.count = ccw.count - sizeof(vq_config);\n>               ret = 0;\n>           }\n>           break;\n>       case CCW_CMD_SET_IND_ADAPTER:\n>           if (check_len) {\n> -            if (ccw.count != sizeof(*thinint)) {\n> +            if (ccw.count != sizeof(thinint)) {\n>                   ret = -EINVAL;\n>                   break;\n>               }\n> -        } else if (ccw.count < sizeof(*thinint)) {\n> +        } else if (ccw.count < sizeof(thinint)) {\n>               /* Can't execute command. */\n>               ret = -EINVAL;\n>               break;\n>           }\n> -        len = sizeof(*thinint);\n> -        hw_len = len;\n>           if (!ccw.cda) {\n>               ret = -EFAULT;\n>           } else if (dev->indicators && !sch->thinint_active) {\n>               /* Trigger a command reject. */\n>               ret = -ENOSYS;\n>           } else {\n> -            thinint = cpu_physical_memory_map(ccw.cda, &hw_len, 0);\n> -            if (!thinint) {\n> +            if (ccw_dstream_read(&sch->cds, thinint)) {\n>                   ret = -EFAULT;\n>               } else {\n> -                uint64_t ind_bit = ldq_be_p(&thinint->ind_bit);\n> +                be64_to_cpus(&thinint.ind_bit);\n> +                be64_to_cpus(&thinint.summary_indicator);\n> +                be64_to_cpus(&thinint.device_indicator);\n> \n> -                len = hw_len;\n>                   dev->summary_indicator =\n> -                    get_indicator(ldq_be_p(&thinint->summary_indicator),\n> -                                  sizeof(uint8_t));\n> +                    get_indicator(thinint.summary_indicator, sizeof(uint8_t));\n>                   dev->indicators =\n> -                    get_indicator(ldq_be_p(&thinint->device_indicator),\n> -                                  ind_bit / 8 + 1);\n> -                dev->thinint_isc = thinint->isc;\n> -                dev->routes.adapter.ind_offset = ind_bit;\n> +                    get_indicator(thinint.device_indicator,\n> +                                  thinint.ind_bit / 8 + 1);\n> +                dev->thinint_isc = thinint.isc;\n> +                dev->routes.adapter.ind_offset = thinint.ind_bit;\n>                   dev->routes.adapter.summary_offset = 7;\n> -                cpu_physical_memory_unmap(thinint, hw_len, 0, hw_len);\n>                   dev->routes.adapter.adapter_id = css_get_adapter_id(\n>                                                    CSS_IO_ADAPTER_VIRTIO,\n>                                                    dev->thinint_isc);\n>                   sch->thinint_active = ((dev->indicators != NULL) &&\n>                                          (dev->summary_indicator != NULL));\n> -                sch->curr_status.scsw.count = ccw.count - len;\n> +                sch->curr_status.scsw.count = ccw.count - sizeof(thinint);\n>                   ret = 0;\n>               }\n>           }\n> @@ -712,13 +653,9 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)\n>               ret = -EFAULT;\n>               break;\n>           }\n> -        revinfo.revision =\n> -            address_space_lduw_be(&address_space_memory, ccw.cda,\n> -                                  MEMTXATTRS_UNSPECIFIED, NULL);\n> -        revinfo.length =\n> -            address_space_lduw_be(&address_space_memory,\n> -                                  ccw.cda + sizeof(revinfo.revision),\n> -                                  MEMTXATTRS_UNSPECIFIED, NULL);\n> +        ccw_dstream_read_buf(&sch->cds, &revinfo, 4);\n> +        be16_to_cpus(&revinfo.revision);\n> +        be16_to_cpus(&revinfo.length);\n>           if (ccw.count < len + revinfo.length ||\n>               (check_len && ccw.count > len + revinfo.length)) {\n>               ret = -EINVAL;\n> \n\nLGTM.\nNot testing the return value for ccw_dstream_read/write_buf() bother me \nbut I can understand that you will modify this later.\nMay be a comment?\nNot a strong opinion.\n\nReviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzHjs3gT8z9t16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 01:40:17 +1000 (AEST)","from localhost ([::1]:59554 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dvQ3r-0003c7-JG\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 11:40:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39946)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pmorel@linux.vnet.ibm.com>) id 1dvQ3W-0003br-EA\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 11:39:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pmorel@linux.vnet.ibm.com>) id 1dvQ3T-0002AX-7l\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 11:39:54 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33974\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <pmorel@linux.vnet.ibm.com>)\n\tid 1dvQ3T-0002AH-1d\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 11:39:51 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8MFdji6065851\n\tfor <qemu-devel@nongnu.org>; Fri, 22 Sep 2017 11:39:46 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d505swn8c-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Fri, 22 Sep 2017 11:39:45 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <pmorel@linux.vnet.ibm.com>;\n\tFri, 22 Sep 2017 16:39:39 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 22 Sep 2017 16:39:36 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8MFdaW427525334; Fri, 22 Sep 2017 15:39:36 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 9AC6711C04C;\n\tFri, 22 Sep 2017 16:35:35 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 5DEC411C04A;\n\tFri, 22 Sep 2017 16:35:35 +0100 (BST)","from [9.145.23.132] (unknown [9.145.23.132])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 22 Sep 2017 16:35:35 +0100 (BST)"],"To":"Halil Pasic <pasic@linux.vnet.ibm.com>, Cornelia Huck <cohuck@redhat.com>","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>\n\t<20170921180841.24490-4-pasic@linux.vnet.ibm.com>","From":"Pierre Morel <pmorel@linux.vnet.ibm.com>","Date":"Fri, 22 Sep 2017 17:39:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170921180841.24490-4-pasic@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092215-0040-0000-0000-000003FC580E","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092215-0041-0000-0000-0000209D98B9","Message-Id":"<7e694ed6-7b40-c895-9542-e445489cda18@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-22_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709220221","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8MFdji6065851","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1774396,"web_url":"http://patchwork.ozlabs.org/comment/1774396/","msgid":"<20170925031400.GP11080@bjsdjshi@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-25T03:14:00","subject":"Re: [Qemu-devel] [PATCH v4 5/5] s390x/css: support ccw IDA","submitter":{"id":68897,"url":"http://patchwork.ozlabs.org/api/people/68897/","name":"Dong Jia Shi","email":"bjsdjshi@linux.vnet.ibm.com"},"content":"* Halil Pasic <pasic@linux.vnet.ibm.com> [2017-09-21 20:08:41 +0200]:\n\n> Let's add indirect data addressing support for our virtual channel\n> subsystem. This implementation does not bother with any kind of\n> prefetching. We simply step through the IDAL on demand.\n> \n> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>\n> ---\n>  hw/s390x/css.c | 114 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-\n>  1 file changed, 113 insertions(+), 1 deletion(-)\n> \n\nLGTM:\nReviewed-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\n\n[...]","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0q2933Vmz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 25 Sep 2017 13:14:40 +1000 (AEST)","from localhost ([::1]:40477 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwJqv-0008Ss-Mp\n\tfor incoming@patchwork.ozlabs.org; Sun, 24 Sep 2017 23:14:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50674)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <bjsdjshi@linux.vnet.ibm.com>) id 1dwJqZ-0008Sj-MW\n\tfor qemu-devel@nongnu.org; Sun, 24 Sep 2017 23:14:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <bjsdjshi@linux.vnet.ibm.com>) id 1dwJqU-0006pX-M6\n\tfor qemu-devel@nongnu.org; Sun, 24 Sep 2017 23:14:15 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51398\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <bjsdjshi@linux.vnet.ibm.com>)\n\tid 1dwJqU-0006oq-G9\n\tfor qemu-devel@nongnu.org; Sun, 24 Sep 2017 23:14:10 -0400","from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8P3DadT146357\n\tfor <qemu-devel@nongnu.org>; Sun, 24 Sep 2017 23:14:07 -0400","from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d6p5dfrbu-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Sun, 24 Sep 2017 23:14:06 -0400","from localhost\n\tby e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <bjsdjshi@linux.vnet.ibm.com>;\n\tSun, 24 Sep 2017 23:14:06 -0400","from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tSun, 24 Sep 2017 23:14:03 -0400","from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com\n\t[9.57.199.107])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8P3E3Of29032538; Mon, 25 Sep 2017 03:14:03 GMT","from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 51221124049;\n\tSun, 24 Sep 2017 23:11:18 -0400 (EDT)","from localhost (unknown [9.115.112.23])\n\tby b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP id 85999124047;\n\tSun, 24 Sep 2017 23:11:17 -0400 (EDT)"],"Date":"Mon, 25 Sep 2017 11:14:00 +0800","From":"Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>","To":"Halil Pasic <pasic@linux.vnet.ibm.com>","Mail-Followup-To":"Halil Pasic <pasic@linux.vnet.ibm.com>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tDong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,\n\tPierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>\n\t<20170921180841.24490-6-pasic@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921180841.24490-6-pasic@linux.vnet.ibm.com>","Organization":"(IBM CSL)","X-URL":"http://ibm.com/","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-TM-AS-GCONF":"00","x-cbid":"17092503-0052-0000-0000-00000266B83C","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007787; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000231; SDB=6.00921951; UDB=6.00463346;\n\tIPR=6.00702093; \n\tBA=6.00005602; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017261;\n\tXFM=3.00000015; UTC=2017-09-25 03:14:04","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092503-0053-0000-0000-0000521D2DE1","Message-Id":"<20170925031400.GP11080@bjsdjshi@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-24_07:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709250048","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v4 5/5] s390x/css: support ccw IDA","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,\n\tCornelia Huck <cohuck@redhat.com>,\n\tPierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775336,"web_url":"http://patchwork.ozlabs.org/comment/1775336/","msgid":"<20170926121027.735e5126.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-26T10:10:27","subject":"Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 22 Sep 2017 17:39:35 +0200\nPierre Morel <pmorel@linux.vnet.ibm.com> wrote:\n\n> On 21/09/2017 20:08, Halil Pasic wrote:\n> > Replace direct access which implicitly assumes no IDA\n> > or MIDA with the new ccw data stream interface which should\n> > cope with these transparently in the future.\n> > \n> > Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>\n> > Reviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>\n> > Reviewed-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\n> > ---\n> >   hw/s390x/virtio-ccw.c | 155 +++++++++++++++-----------------------------------\n> >   1 file changed, 46 insertions(+), 109 deletions(-)\n\n> LGTM.\n> Not testing the return value for ccw_dstream_read/write_buf() bother me \n> but I can understand that you will modify this later.\n> May be a comment?\n> Not a strong opinion.\n\nI can add \"Note that checking the return code for ccw_dstream_* will be\ndone in a follow-on patch.\"\n\n> \n> Reviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>\n> \n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1cD92HwYz9tXc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 20:11:04 +1000 (AEST)","from localhost ([::1]:46466 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwmpO-0000zx-M7\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 06:10:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42652)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwmp1-0000zM-Ia\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:10:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwmox-0006ms-EK\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:10:35 -0400","from mx1.redhat.com ([209.132.183.28]:54280)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dwmox-0006mL-8O\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:10:31 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3EADFA3B7C;\n\tTue, 26 Sep 2017 10:10:30 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5F24669AC2;\n\tTue, 26 Sep 2017 10:10:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3EADFA3B7C","Date":"Tue, 26 Sep 2017 12:10:27 +0200","From":"Cornelia Huck <cohuck@redhat.com>","To":"Pierre Morel <pmorel@linux.vnet.ibm.com>","Message-ID":"<20170926121027.735e5126.cohuck@redhat.com>","In-Reply-To":"<7e694ed6-7b40-c895-9542-e445489cda18@linux.vnet.ibm.com>","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>\n\t<20170921180841.24490-4-pasic@linux.vnet.ibm.com>\n\t<7e694ed6-7b40-c895-9542-e445489cda18@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 26 Sep 2017 10:10:30 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Halil Pasic <pasic@linux.vnet.ibm.com>,\n\tDong Jia Shi <bjsdjshi@linux.vnet.ibm.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775343,"web_url":"http://patchwork.ozlabs.org/comment/1775343/","msgid":"<d38de14e-c126-131a-f6d5-a9b0122149a2@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-26T10:14:47","subject":"Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 09/26/2017 12:10 PM, Cornelia Huck wrote:\n> On Fri, 22 Sep 2017 17:39:35 +0200\n> Pierre Morel <pmorel@linux.vnet.ibm.com> wrote:\n> \n>> On 21/09/2017 20:08, Halil Pasic wrote:\n>>> Replace direct access which implicitly assumes no IDA\n>>> or MIDA with the new ccw data stream interface which should\n>>> cope with these transparently in the future.\n>>>\n>>> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>\n>>> Reviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>\n>>> Reviewed-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\n>>> ---\n>>>   hw/s390x/virtio-ccw.c | 155 +++++++++++++++-----------------------------------\n>>>   1 file changed, 46 insertions(+), 109 deletions(-)\n> \n>> LGTM.\n>> Not testing the return value for ccw_dstream_read/write_buf() bother me \n>> but I can understand that you will modify this later.\n>> May be a comment?\n>> Not a strong opinion.\n> \n> I can add \"Note that checking the return code for ccw_dstream_* will be\n> done in a follow-on patch.\"\n> \n\nI'm fine with that.\n\n>>\n>> Reviewed-by: Pierre Morel<pmorel@linux.vnet.ibm.com>\n>>\n>>\n> \n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1cNM1Cffz9sPr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 20:18:11 +1000 (AEST)","from localhost ([::1]:46496 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwmwL-0004Wh-A1\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 06:18:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44416)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pasic@linux.vnet.ibm.com>) id 1dwmtI-0002oI-Gf\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:15:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pasic@linux.vnet.ibm.com>) id 1dwmtF-0000SJ-5L\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:15:00 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43580)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <pasic@linux.vnet.ibm.com>)\n\tid 1dwmtE-0000R1-Sr\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:14:57 -0400","from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QAETIs086204\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 06:14:53 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d7jajacma-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 06:14:52 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <pasic@linux.vnet.ibm.com>;\n\tTue, 26 Sep 2017 11:14:50 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 11:14:48 +0100","from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com\n\t[9.149.105.58])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8QAElme31981766; Tue, 26 Sep 2017 10:14:47 GMT","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 404994C040;\n\tTue, 26 Sep 2017 11:11:04 +0100 (BST)","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 184BB4C046;\n\tTue, 26 Sep 2017 11:11:04 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.207])\n\tby d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 26 Sep 2017 11:11:04 +0100 (BST)"],"To":"Cornelia Huck <cohuck@redhat.com>,\n\tPierre Morel <pmorel@linux.vnet.ibm.com>","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>\n\t<20170921180841.24490-4-pasic@linux.vnet.ibm.com>\n\t<7e694ed6-7b40-c895-9542-e445489cda18@linux.vnet.ibm.com>\n\t<20170926121027.735e5126.cohuck@redhat.com>","From":"Halil Pasic <pasic@linux.vnet.ibm.com>","Date":"Tue, 26 Sep 2017 12:14:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926121027.735e5126.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092610-0040-0000-0000-000003FD1FA5","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092610-0041-0000-0000-0000209E6973","Message-Id":"<d38de14e-c126-131a-f6d5-a9b0122149a2@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260154","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775345,"web_url":"http://patchwork.ozlabs.org/comment/1775345/","msgid":"<20170926121800.1e9e1ac1.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-26T10:18:00","subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 21 Sep 2017 20:08:36 +0200\nHalil Pasic <pasic@linux.vnet.ibm.com> wrote:\n\n> Abstract\n> --------\n> \n> The objective of this series is introducing CCW IDA (indirect data\n> access) support to our virtual channel subsystem implementation. Briefly\n> CCW IDA can be thought of as a kind of a scatter gather support for a\n> single CCW. If certain flags are set, the cda is to be interpreted as an\n> address to a list which in turn holds further addresses designating the\n> actual data.  Thus the scheme which we are currently using for accessing\n> CCW payload does not work in general case. Currently there is no\n> immediate need for proper IDA handling (no use case), but since it IDA is\n> a non-optional part of the architecture, the only way towards AR\n> compliance is actually implementing IDA.\n> \n> The focus of this patch set is introducing IDA support. There seems to be\n> a potential for further  improvements based on the introduced\n> infrastructure, but such improvements are intended to be discusses\n> separately and realized as patches on top of this series.\n\nHm, do you have a list of what you want to do as follow-on patches?\n(Checking return codes, ...)\n\nIt's easy to lose track of all this :)","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1cP21f3mz9sPr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 20:18:46 +1000 (AEST)","from localhost ([::1]:46497 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwmwu-0004jP-B2\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 06:18:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45805)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwmwL-0004fi-2B\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:18:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwmwH-000274-61\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:18:09 -0400","from mx1.redhat.com ([209.132.183.28]:33022)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dwmwG-00026n-W8\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:18:05 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DFDC07E42D;\n\tTue, 26 Sep 2017 10:18:03 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 261B760841;\n\tTue, 26 Sep 2017 10:18:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DFDC07E42D","Date":"Tue, 26 Sep 2017 12:18:00 +0200","From":"Cornelia Huck <cohuck@redhat.com>","To":"Halil Pasic <pasic@linux.vnet.ibm.com>","Message-ID":"<20170926121800.1e9e1ac1.cohuck@redhat.com>","In-Reply-To":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 26 Sep 2017 10:18:04 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,\n\tPierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775355,"web_url":"http://patchwork.ozlabs.org/comment/1775355/","msgid":"<bce18b05-2f0c-b032-36e4-23dd8558e826@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-26T10:45:11","subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","submitter":{"id":68297,"url":"http://patchwork.ozlabs.org/api/people/68297/","name":"Halil Pasic","email":"pasic@linux.vnet.ibm.com"},"content":"On 09/26/2017 12:18 PM, Cornelia Huck wrote:\n> On Thu, 21 Sep 2017 20:08:36 +0200\n> Halil Pasic <pasic@linux.vnet.ibm.com> wrote:\n> \n>> Abstract\n>> --------\n>>\n>> The objective of this series is introducing CCW IDA (indirect data\n>> access) support to our virtual channel subsystem implementation. Briefly\n>> CCW IDA can be thought of as a kind of a scatter gather support for a\n>> single CCW. If certain flags are set, the cda is to be interpreted as an\n>> address to a list which in turn holds further addresses designating the\n>> actual data.  Thus the scheme which we are currently using for accessing\n>> CCW payload does not work in general case. Currently there is no\n>> immediate need for proper IDA handling (no use case), but since it IDA is\n>> a non-optional part of the architecture, the only way towards AR\n>> compliance is actually implementing IDA.\n>>\n>> The focus of this patch set is introducing IDA support. There seems to be\n>> a potential for further  improvements based on the introduced\n>> infrastructure, but such improvements are intended to be discusses\n>> separately and realized as patches on top of this series.\n> \n> Hm, do you have a list of what you want to do as follow-on patches?\n> (Checking return codes, ...)\n> \n> It's easy to lose track of all this :)\n> \n\nThese are the stuff I had in mind:\n* handling errors (aka. checking error codes) in virtio-ccw\n* using residual count\n* converting 3270 (patches already sent)\n\nAnd then some related stuff is the error reporting and handling\nrework for the IO instruction handlers and for the ccw interpretation\nemulation (later affects CcwDataStream).\n\nThere is probably a lot of potential for making things prettier\nin virtio-ccw.c too -- I've done some experiments but ended up changing\ntoo many things at the same time.\n\nBtw, do we still have open issues with this series?\n\nRegards,\nHalil","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1d0X5Wrgz9tX4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 20:46:02 +1000 (AEST)","from localhost ([::1]:46637 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwnNI-0006LV-2f\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 06:46:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54290)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pasic@linux.vnet.ibm.com>) id 1dwnMo-0006KE-9E\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:45:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pasic@linux.vnet.ibm.com>) id 1dwnMl-0007Ms-0K\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:45:30 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56490)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <pasic@linux.vnet.ibm.com>)\n\tid 1dwnMk-0007L7-Ex\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 06:45:26 -0400","from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QAigDJ052540\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 06:45:22 -0400","from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d7jgx3h1t-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 06:45:21 -0400","from localhost\n\tby e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <pasic@linux.vnet.ibm.com>;\n\tTue, 26 Sep 2017 11:45:15 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 11:45:12 +0100","from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com\n\t[9.149.105.58])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8QAjCWh21299430\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 10:45:12 GMT","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id DFE4C4C04A\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 11:41:28 +0100 (BST)","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C64774C044\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 11:41:28 +0100 (BST)","from oc3836556865.ibm.com (unknown [9.152.224.207])\n\tby d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 11:41:28 +0100 (BST)"],"To":"qemu-devel@nongnu.org","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>\n\t<20170926121800.1e9e1ac1.cohuck@redhat.com>","From":"Halil Pasic <pasic@linux.vnet.ibm.com>","Date":"Tue, 26 Sep 2017 12:45:11 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926121800.1e9e1ac1.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","x-cbid":"17092610-0020-0000-0000-000003BB27EA","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092610-0021-0000-0000-0000424D0008","Message-Id":"<bce18b05-2f0c-b032-36e4-23dd8558e826@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260161","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775391,"web_url":"http://patchwork.ozlabs.org/comment/1775391/","msgid":"<20170926131957.2110cc1b.cornelia.huck@mailbox.org>","list_archive_url":null,"date":"2017-09-26T11:19:57","subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","submitter":{"id":72442,"url":"http://patchwork.ozlabs.org/api/people/72442/","name":"Cornelia Huck","email":"cornelia.huck@mailbox.org"},"content":"[Restored cc:s]\n\nOn Tue, 26 Sep 2017 12:45:11 +0200\nHalil Pasic <pasic@linux.vnet.ibm.com> wrote:\n\n> On 09/26/2017 12:18 PM, Cornelia Huck wrote:\n> > On Thu, 21 Sep 2017 20:08:36 +0200\n> > Halil Pasic <pasic@linux.vnet.ibm.com> wrote:\n> >   \n> >> Abstract\n> >> --------\n> >>\n> >> The objective of this series is introducing CCW IDA (indirect data\n> >> access) support to our virtual channel subsystem implementation. Briefly\n> >> CCW IDA can be thought of as a kind of a scatter gather support for a\n> >> single CCW. If certain flags are set, the cda is to be interpreted as an\n> >> address to a list which in turn holds further addresses designating the\n> >> actual data.  Thus the scheme which we are currently using for accessing\n> >> CCW payload does not work in general case. Currently there is no\n> >> immediate need for proper IDA handling (no use case), but since it IDA is\n> >> a non-optional part of the architecture, the only way towards AR\n> >> compliance is actually implementing IDA.\n> >>\n> >> The focus of this patch set is introducing IDA support. There seems to be\n> >> a potential for further  improvements based on the introduced\n> >> infrastructure, but such improvements are intended to be discusses\n> >> separately and realized as patches on top of this series.  \n> > \n> > Hm, do you have a list of what you want to do as follow-on patches?\n> > (Checking return codes, ...)\n> > \n> > It's easy to lose track of all this :)\n> >   \n> \n> These are the stuff I had in mind:\n> * handling errors (aka. checking error codes) in virtio-ccw\n> * using residual count\n> * converting 3270 (patches already sent)\n\nThe 3270 stuff is next in line for me.\n\n> \n> And then some related stuff is the error reporting and handling\n> rework for the IO instruction handlers and for the ccw interpretation\n> emulation (later affects CcwDataStream).\n> \n> There is probably a lot of potential for making things prettier\n> in virtio-ccw.c too -- I've done some experiments but ended up changing\n> too many things at the same time.\n\nThere's always potential for such things :) Let's get the previously\nidentified stuff out of the door first (it's not that I lack patches to\napply anyway...)\n\n> \n> Btw, do we still have open issues with this series?\n\nCurrently going through my acceptance testing.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1f7J1wP8z9sBZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 21:37:00 +1000 (AEST)","from localhost ([::1]:46847 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwoAb-00063O-2B\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 07:36:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38037)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cornelia.huck@mailbox.org>) id 1dwnuL-0000DT-Vn\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:20:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cornelia.huck@mailbox.org>) id 1dwnuG-0007b1-Ld\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:20:09 -0400","from mx1.mailbox.org ([80.241.60.212]:42527)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cornelia.huck@mailbox.org>)\n\tid 1dwnuG-0007Zq-BS\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 07:20:04 -0400","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.mailbox.org (Postfix) with ESMTPS id D80A845BCF;\n\tTue, 26 Sep 2017 13:20:00 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de\n\t[80.241.56.116]) (amavisd-new, port 10030)\n\twith ESMTP id mBWBma_dHyQ1; Tue, 26 Sep 2017 13:19:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h=\n\tcontent-transfer-encoding:content-type:content-type:mime-version\n\t:references:in-reply-to:message-id:subject:subject:from:from\n\t:date:date:received; s=mail20150812; t=1506424798; bh=4FkrUfcc/s\n\tmKjMFp/CEtXf2ztCqr+aFy+ehZD9fEpTM=; b=hEnaQyc+YhCOG886SB1U2Z6qDX\n\t+nsFwRhwM0taWn9MyzNkhJAjvzWOM3e7Wpp9eevQphLYfUyTo3eCiMfhqHgNox2A\n\tESJQ/2q70QWGbnbzLoQ8wh9K0nXgHlZK6RRibANFoeF2fpOYaXw2hDOcrhoQrvfI\n\tC0E6AU6zqgeIu280zz6KBV8c2COXaPA0gUI8/PBG7hZ2eKSI4mdNepBkuBOhY74l\n\tz3y/DdXVUiFnXT9rd76IxLZmxc1xZW+MGoygD5SyZcHyjx9ep5DADDilpPngndQh\n\t9AHrPBECNRBd5Q9kKisSJPnxIJli1I2IQxHef12QwVYcM2tGhgpXXBSCTexQ==","X-Virus-Scanned":"amavisd-new at heinlein-support.de","Date":"Tue, 26 Sep 2017 13:19:57 +0200","From":"Cornelia Huck <cornelia.huck@mailbox.org>","To":"Halil Pasic <pasic@linux.vnet.ibm.com>","Message-ID":"<20170926131957.2110cc1b.cornelia.huck@mailbox.org>","In-Reply-To":"<bce18b05-2f0c-b032-36e4-23dd8558e826@linux.vnet.ibm.com>","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>\n\t<20170926121800.1e9e1ac1.cohuck@redhat.com>\n\t<bce18b05-2f0c-b032-36e4-23dd8558e826@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"80.241.60.212","Subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,\n\tPierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775455,"web_url":"http://patchwork.ozlabs.org/comment/1775455/","msgid":"<20170926145958.05c8ef01.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-26T12:59:58","subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 21 Sep 2017 20:08:36 +0200\nHalil Pasic <pasic@linux.vnet.ibm.com> wrote:\n\n> Abstract\n> --------\n> \n> The objective of this series is introducing CCW IDA (indirect data\n> access) support to our virtual channel subsystem implementation. Briefly\n> CCW IDA can be thought of as a kind of a scatter gather support for a\n> single CCW. If certain flags are set, the cda is to be interpreted as an\n> address to a list which in turn holds further addresses designating the\n> actual data.  Thus the scheme which we are currently using for accessing\n> CCW payload does not work in general case. Currently there is no\n> immediate need for proper IDA handling (no use case), but since it IDA is\n> a non-optional part of the architecture, the only way towards AR\n> compliance is actually implementing IDA.\n> \n> The focus of this patch set is introducing IDA support. There seems to be\n> a potential for further  improvements based on the introduced\n> infrastructure, but such improvements are intended to be discusses\n> separately and realized as patches on top of this series.\n\nThanks, applied.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1h064Lkbz9tXj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 23:00:54 +1000 (AEST)","from localhost ([::1]:47450 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwpTo-0000V0-MB\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 09:00:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36131)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwpT5-0000NV-NJ\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:00:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwpSz-0003zx-Uu\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:00:07 -0400","from mx1.redhat.com ([209.132.183.28]:50310)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dwpSz-0003zD-Pv\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:00:01 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ABDC268B5;\n\tTue, 26 Sep 2017 13:00:00 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E7169757D4;\n\tTue, 26 Sep 2017 12:59:59 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ABDC268B5","Date":"Tue, 26 Sep 2017 14:59:58 +0200","From":"Cornelia Huck <cohuck@redhat.com>","To":"Halil Pasic <pasic@linux.vnet.ibm.com>","Message-ID":"<20170926145958.05c8ef01.cohuck@redhat.com>","In-Reply-To":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>","References":"<20170921180841.24490-1-pasic@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 26 Sep 2017 13:00:00 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/5] add CCW indirect data access support","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,\n\tPierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]