[{"id":1793706,"web_url":"http://patchwork.ozlabs.org/comment/1793706/","msgid":"<49c12500-db97-0133-e43d-72b8116ed0a0@linaro.org>","list_archive_url":null,"date":"2017-10-25T11:56:20","subject":"Re: [PATCH v9 0/7] Add support for Qualcomm A53 CPU clock","submitter":{"id":70295,"url":"http://patchwork.ozlabs.org/api/people/70295/","name":"Georgi Djakov","email":"georgi.djakov@linaro.org"},"content":"On 09/21/2017 07:49 PM, Georgi Djakov wrote:\n> This patchset adds support for the A53 CPU clock on MSM8916 platforms\n> and allows scaling of the CPU frequency on msm8916 based platforms.\n> \n> Changes since v8 (https://lkml.org/lkml/2017/6/23/476)\n> * Converted APCS mailbox driver to use regmap and to populate child\n> platform devices that will handle the rest of the functionality\n> provided by APCS block.\n> * Picked Rob's Ack for the PLL binding.\n> * Changed the APCS binding and put it into a separate patch.\n> * Addressed review comments.\n> * Minor changes.\n\nHi Stephen and Bjorn. A gentle ping on this..\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"JzHsFFzl\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMTBK3wqHz9t2l\n\tfor ;\n\tWed, 25 Oct 2017 22:56:25 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751637AbdJYL4X (ORCPT\n\t);\n\tWed, 25 Oct 2017 07:56:23 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:47331 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751589AbdJYL4V (ORCPT\n\t); Wed, 25 Oct 2017 07:56:21 -0400","by mail-wr0-f194.google.com with SMTP id y39so23762334wrd.4\n\tfor ;\n\tWed, 25 Oct 2017 04:56:21 -0700 (PDT)","from [10.44.66.8] ([212.45.67.2])\n\tby smtp.googlemail.com with ESMTPSA id\n\to197sm8649330wmg.3.2017.10.25.04.56.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 25 Oct 2017 04:56:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=MgPCvoxAerl3muS2KSSZFseiUpSZh8gk9oo5+Hu+PoM=;\n\tb=JzHsFFzl9J/wXQNaU5uD7nPAWdwLtRUaXjrN/+H0gUWghXiAHBQX6odoJy5425j0Vd\n\tjEQ1Yrle2fQo/3+TSXBsjBMWrb/3Q0DCdNfe75Xl+rOTkUZYAhjdklqUpCy3HC4P+W6k\n\tenxdeY3lM2AHuMZE6WC+/4+KjxU6TkJrnZFLs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=MgPCvoxAerl3muS2KSSZFseiUpSZh8gk9oo5+Hu+PoM=;\n\tb=EiDrVPAc5i81lm9PS+hMI2H7xENOwT0VoijHDuLKUayGjFZbwnjhHQe06PS7w3uZhb\n\t2HXgnnrH2+vN5STn5HkANYCqwStbii23T30m+c0ooQwGnTuSlwR5qqxXEbjyGUgSxU2Q\n\tabxqOZDMsskGl4O+L8Cg4WyIEAl6dwzPSWaS4th7v0VMzoe18d91FIeXI668XqxOEjKl\n\tJKRSSg6qEbtm9CPTQi9+GAaxEkh1X4v5N9lZBpgU9D2vfaRbQ5rw3wdqI9DNP/AXxY6d\n\tPRa3Q7Tv4b8H82ssLJeZ+lqcyd0ru/NfQG0kZD0Vw15oTIaqWrTZAvuyPIjzZQypw9oe\n\taP/A==","X-Gm-Message-State":"AMCzsaV1HxILvWSxiObVFyb9lfASXdKb0juNnoPkf+s8bwvyktqmB4uP\n\tgSOjN/PFzIqjwxerpAtbiPn66YTXQO0=","X-Google-Smtp-Source":"ABhQp+R1TNDN26KmVjbc2HncTdYVI6B6XP/E/SDvrxAk97nxMhsy6H98N2AOr/YqgjXisvVVDhcawQ==","X-Received":"by 10.223.133.242 with SMTP id 47mr2062835wru.170.1508932580423; \n\tWed, 25 Oct 2017 04:56:20 -0700 (PDT)","Subject":"Re: [PATCH v9 0/7] Add support for Qualcomm A53 CPU clock","To":"sboyd@codeaurora.org, jassisinghbrar@gmail.com,\n\tbjorn.andersson@linaro.org, robh+dt@kernel.org","Cc":"mturquette@baylibre.com, linux-clk@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>","From":"Georgi Djakov ","Message-ID":"<49c12500-db97-0133-e43d-72b8116ed0a0@linaro.org>","Date":"Wed, 25 Oct 2017 14:56:20 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20170921164940.20343-1-georgi.djakov@linaro.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794017,"web_url":"http://patchwork.ozlabs.org/comment/1794017/","msgid":"<20171026042811.GL1575@tuxbook>","list_archive_url":null,"date":"2017-10-26T04:28:11","subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","submitter":{"id":68398,"url":"http://patchwork.ozlabs.org/api/people/68398/","name":"Bjorn Andersson","email":"bjorn.andersson@linaro.org"},"content":"On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:\n\n> Move the structure shared by the APCS IPC device and its subdevices\n> into a separate header file.\n> \n\nAs you're creating the apcs regmap with devm_regmap_init_mmio() you can\njust call dev_get_regmap(dev->parent) in your child to get the handle.\n\nBut I would prefer that you just add the clock code to the existing\ndriver.\n\nRegards,\nBjorn\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RX+/qlL+\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMvBv2KHPz9t3J\n\tfor ;\n\tThu, 26 Oct 2017 15:28:23 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750892AbdJZE2R (ORCPT\n\t);\n\tThu, 26 Oct 2017 00:28:17 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:49075 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750938AbdJZE2Q (ORCPT\n\t); Thu, 26 Oct 2017 00:28:16 -0400","by mail-pf0-f194.google.com with SMTP id b79so1603422pfk.5\n\tfor ;\n\tWed, 25 Oct 2017 21:28:15 -0700 (PDT)","from tuxbook (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79])\n\tby smtp.gmail.com with ESMTPSA id\n\tl5sm8106829pfi.165.2017.10.25.21.28.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 25 Oct 2017 21:28:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=9eB6fZ46tDWenEYUe6DIwRuQlTmQBCwduEV7iY7CuNQ=;\n\tb=RX+/qlL+ny2DF+6k8qbDd0q2IQszhgluYObTAE8N7Ep9YqkxraLtiEYXKLIpKfOXbR\n\teiIlV6SD7rvIQgjvYnGoiVxZ3kEKi/hnTOdZk2BCuo32DCpdzic36H5NK7FhpCkUlQ0t\n\t71WdG6tfwnQTlFiUIJk53FI7tUcx9ZoBTj498=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=9eB6fZ46tDWenEYUe6DIwRuQlTmQBCwduEV7iY7CuNQ=;\n\tb=dawFWwCkvLtod+n/FgnOIV+rwSNe+IJxCmphs8gMGk5jLP9PhhoSjyPls0fEfh873G\n\tTGjCOyLo6CROvWcK17ZzgYt2ZJ1roCdzsEC1hYO2KcP6vKJT3CoAYva3BFOT20B9/Mb6\n\tw5knD2wsi2UngGDA25Uv9DFAVJRYvdBPw0C3/W5KxWKoYM+9IntL+rRp5Zl+E/sMDNHL\n\t2W3fFErhNp8Q96i6aTLYdKsq/RWVcWTSt8qZA3EEJnxSnb9e8QDdv8pea+GG2Gk2elS8\n\tKRsHsuGljI83rT1le+bRxN3tvjLC97UlDGUwKsTuRKoLjTtrDM69u6dcVEVhQAwQNM1X\n\tJ27Q==","X-Gm-Message-State":"AMCzsaV93GeZZBv1/o9s/m758xEOdGHfrpm5BLvra46aIBFIl/n7/d55\n\t5O65cLjvdO64SEyWaIO8y/Ommw==","X-Google-Smtp-Source":"ABhQp+TvCEG14KiaEXhs/j2l2bDlKACBzxW9WxPHsveLUH6pA8q963Uq4qlclStBHaNX/+WF9gFirw==","X-Received":"by 10.84.136.135 with SMTP id 7mr3477816pll.392.1508992095246;\n\tWed, 25 Oct 2017 21:28:15 -0700 (PDT)","Date":"Wed, 25 Oct 2017 21:28:11 -0700","From":"Bjorn Andersson ","To":"Georgi Djakov ","Cc":"sboyd@codeaurora.org, jassisinghbrar@gmail.com, robh+dt@kernel.org,\n\tmturquette@baylibre.com, linux-clk@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","Message-ID":"<20171026042811.GL1575@tuxbook>","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>\n\t<20170921164940.20343-4-georgi.djakov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921164940.20343-4-georgi.djakov@linaro.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794020,"web_url":"http://patchwork.ozlabs.org/comment/1794020/","msgid":"<20171026043919.GM1575@tuxbook>","list_archive_url":null,"date":"2017-10-26T04:39:19","subject":"Re: [PATCH v9 7/7] clk: qcom: Add APCS clock controller support","submitter":{"id":68398,"url":"http://patchwork.ozlabs.org/api/people/68398/","name":"Bjorn Andersson","email":"bjorn.andersson@linaro.org"},"content":"On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:\n\n> Add a driver for the APCS clock controller. It is part of the APCS\n> hardware block, which among other things implements also a combined\n> mux and half integer divider functionality. It can choose between a\n> fixed-rate clock or the dedicated APCS (A53) PLL. The source and the\n> divider can be set both at the same time.\n> \n> This is required for enabling CPU frequency scaling on MSM8916-based\n> platforms.\n\nAs stated in the binding patch I think you should describe the \"two\"\nparts in one node and probably add this code to the existing driver,\nrather than spawning a new device.\n\n[..]\n> diff --git a/drivers/clk/qcom/apcs-msm8916.c b/drivers/clk/qcom/apcs-msm8916.c\n[..]\n> +#include \"clk-regmap.h\"\n> +#include \"clk-regmap-mux-div.h\"\n\nThese two include files might cause some issues, but I would prefer that\nyou bake this code into the existing apcs driver.\n\n[..]\n> +static int __init qcom_apcs_msm8916_clk_init(void)\n> +{\n> +\treturn platform_driver_register(&qcom_apcs_msm8916_clk_driver);\n> +}\n> +core_initcall(qcom_apcs_msm8916_clk_init);\n\nNB. The a53 clock is a builtin_platform_driver(), i.e. device_initcall()\nthe clock will never be available at core_initcall(), so the\ndevm_clk_get() should always hit a probe defer. Use\nmodule_platform_driver() instead.\n\n> +\n> +static void __exit qcom_apcs_msm8916_clk_exit(void)\n> +{\n> +\tplatform_driver_unregister(&qcom_apcs_msm8916_clk_driver);\n> +}\n> +module_exit(qcom_apcs_msm8916_clk_exit);\n\nRegards,\nBjorn\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"PjoJQAiZ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMvRw4fB8z9t32\n\tfor ;\n\tThu, 26 Oct 2017 15:39:40 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751232AbdJZEjZ (ORCPT\n\t);\n\tThu, 26 Oct 2017 00:39:25 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:53260 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751164AbdJZEjY (ORCPT\n\t); Thu, 26 Oct 2017 00:39:24 -0400","by mail-pg0-f68.google.com with SMTP id s2so1732464pge.10\n\tfor ;\n\tWed, 25 Oct 2017 21:39:24 -0700 (PDT)","from tuxbook (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79])\n\tby smtp.gmail.com with ESMTPSA id\n\tz8sm7847578pfl.135.2017.10.25.21.39.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 25 Oct 2017 21:39:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Qn+UsgTy3OsgnFYuF96mCz5D90eg5nYSNk/OYNWc9ic=;\n\tb=PjoJQAiZHgXuisSl34iPpQ+jUsQ92cQY1ijfjagVJM0Ddbbw+h1OlRVf1bzjGi4XTZ\n\t9s2ELEbVzYNQo7g3w0OLHtLHXEyB6lfPRPggrL05SRefjndiWx9LfHGktOthKXaLkuqd\n\t7xdkQyji0GcYGEvnsXo/8OaD0oZWmjbKKK/+0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Qn+UsgTy3OsgnFYuF96mCz5D90eg5nYSNk/OYNWc9ic=;\n\tb=Zm1tJ29NoaAOHhQmiqMyj7j0UujFfwS/n3UOvvrx2+/N1ECYPNHBDbmeQWcgf3gM1J\n\tQfmr7fxyGgfIFUYEMs3kMdKcE5vhfwFv6ULcriO9+8AsFUSihUJkQwUWNrrhgBcVPEv7\n\tLTc1rf32NE19M1g2XsLnY+8J+dFB/fxHrcp0kbBNmlQThYLDDeVheYu+9EpAbDARYt9k\n\tY+RGDLvN/DHQG59KtCyeTDb+0q1/5jkb2ARBQE7+oSy9wptbNKeuBJfy7sh5VjrK4SYC\n\tHK8FD8+R9lJos6vraf47/A98HglaCaWDUVJD1R0qE7LaAND5NTrvZ2Rm8scuuj/zEqVy\n\tLZ0g==","X-Gm-Message-State":"AMCzsaUiCaChM95Xr3PFr34D8S8nSisIVzXp7gqPjKSOqz6PBRP98DyM\n\t56AJ21JZ80djKlZI4SmB36m4/g==","X-Google-Smtp-Source":"ABhQp+SsJAZSAqMeY7IGTewuN6U3CkF5IEYPOipImF55qMTr/DClU8zyABsQbx1VYcusnJw2csPN6g==","X-Received":"by 10.99.128.199 with SMTP id j190mr3880692pgd.145.1508992763523;\n\tWed, 25 Oct 2017 21:39:23 -0700 (PDT)","Date":"Wed, 25 Oct 2017 21:39:19 -0700","From":"Bjorn Andersson ","To":"Georgi Djakov ","Cc":"sboyd@codeaurora.org, jassisinghbrar@gmail.com, robh+dt@kernel.org,\n\tmturquette@baylibre.com, linux-clk@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH v9 7/7] clk: qcom: Add APCS clock controller support","Message-ID":"<20171026043919.GM1575@tuxbook>","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>\n\t<20170921164940.20343-8-georgi.djakov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921164940.20343-8-georgi.djakov@linaro.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794021,"web_url":"http://patchwork.ozlabs.org/comment/1794021/","msgid":"<20171026044109.GN1575@tuxbook>","list_archive_url":null,"date":"2017-10-26T04:41:09","subject":"Re: [PATCH v9 1/7] mailbox: qcom: Convert APCS IPC driver to use\n\tregmap","submitter":{"id":68398,"url":"http://patchwork.ozlabs.org/api/people/68398/","name":"Bjorn Andersson","email":"bjorn.andersson@linaro.org"},"content":"On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:\n\n> This hardware block provides more functionalities that just IPC. Convert\n> it to regmap to allow other child platform devices to use the same regmap.\n> \n\nAcked-by: Bjorn Andersson \n\nRegards,\nBjorn\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"gXqTvPjF\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yMvTl6JWQz9t3J\n\tfor ;\n\tThu, 26 Oct 2017 15:41:15 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751397AbdJZElO (ORCPT\n\t);\n\tThu, 26 Oct 2017 00:41:14 -0400","from mail-pf0-f182.google.com ([209.85.192.182]:56804 \"EHLO\n\tmail-pf0-f182.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751229AbdJZElN (ORCPT\n\t); Thu, 26 Oct 2017 00:41:13 -0400","by mail-pf0-f182.google.com with SMTP id b85so1612918pfj.13\n\tfor ;\n\tWed, 25 Oct 2017 21:41:13 -0700 (PDT)","from tuxbook (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79])\n\tby smtp.gmail.com with ESMTPSA id\n\tf15sm5105136pgu.1.2017.10.25.21.41.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 25 Oct 2017 21:41:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=1sQlp16FGOuGIXVorN8p4408HClr2UcBFb1se+6JQV4=;\n\tb=gXqTvPjFxBPLbP8REcH9gYqZDTKY+sFbJHCJ5z5qRJGKBJwWQ1j3cHQj/nrxX98Tyz\n\tgZcCkbXD2aB/0JXdn+MXgB58GI7hbydKgyGOL8+mEBXL4PHrL6bgr0ncue8d+1qNA7m1\n\t/374jg6V2vsaZVnGVO8stIOmjneXj31LY1jek=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=1sQlp16FGOuGIXVorN8p4408HClr2UcBFb1se+6JQV4=;\n\tb=LpVCMk/ahmLtLfxJCf4QNTlgtVm+U2HxpTGWWl/VV14eZvqPaVa2ANs35vRcFvOVvl\n\tD6PyGtoAFb7Hbrxz0iF/4Ic/FV2y6YD0g+T7n78PszGAbEDafwXO6Zdl/FhxQmcRT+Zk\n\tAhoCkn4ibaaYVMf5kNE8RpkFy1lGtAgNQaaiSSDprMqM1cgsPPy7rnYaIQID3pc2qlR8\n\tTc8vzJ/ukv9SrOk/pnhGIvVATBfNcd2sQj+hvCx+hdwTWzAp4cqS1564zGBMhC+CEslf\n\tAM2ufZo0v81g/rOOGuweOPGSQLiS9yviY5JM9hQwPm/OtSGmf1Y3n1IAs6b/jvebfetE\n\tj4Jw==","X-Gm-Message-State":"AMCzsaXy4GwqKGODAXe1jkssBxBzxdNaxd+syQHkAJYy+hm9x53mK3Rq\n\t6x7OEfXAgvsBIy+LWD8JVR/WDQ==","X-Google-Smtp-Source":"ABhQp+Q8gMjUzwdmgUO3HataelHtWWw2N0yW2LrLYrvTSwZYz8lD97Jy9ViHlwebkWP1kwp7/Nabrw==","X-Received":"by 10.101.92.196 with SMTP id b4mr3910944pgt.280.1508992872836; \n\tWed, 25 Oct 2017 21:41:12 -0700 (PDT)","Date":"Wed, 25 Oct 2017 21:41:09 -0700","From":"Bjorn Andersson ","To":"Georgi Djakov ","Cc":"sboyd@codeaurora.org, jassisinghbrar@gmail.com, robh+dt@kernel.org,\n\tmturquette@baylibre.com, linux-clk@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH v9 1/7] mailbox: qcom: Convert APCS IPC driver to use\n\tregmap","Message-ID":"<20171026044109.GN1575@tuxbook>","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>\n\t<20170921164940.20343-2-georgi.djakov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921164940.20343-2-georgi.djakov@linaro.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794897,"web_url":"http://patchwork.ozlabs.org/comment/1794897/","msgid":"<5bad4c4b-362b-ba9f-3072-1cced7a004dd@linaro.org>","list_archive_url":null,"date":"2017-10-27T14:20:58","subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","submitter":{"id":70295,"url":"http://patchwork.ozlabs.org/api/people/70295/","name":"Georgi Djakov","email":"georgi.djakov@linaro.org"},"content":"Hi Bjorn,\n\nThanks for reviewing!\n\nOn 10/26/2017 07:28 AM, Bjorn Andersson wrote:\n> On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:\n> \n>> Move the structure shared by the APCS IPC device and its subdevices\n>> into a separate header file.\n>>\n> \n> As you're creating the apcs regmap with devm_regmap_init_mmio() you can\n> just call dev_get_regmap(dev->parent) in your child to get the handle.\n\nOk, thanks!\n\n> \n> But I would prefer that you just add the clock code to the existing\n> driver.\n\nThis will require an ack from Stephen, and i got the impression that he\nprefers a separate clk driver [1].\n\nStephen, are you ok with registering the clocks from the apcs mailbox\ndriver?\n\n[1] https://lkml.org/lkml/2017/6/26/750\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"c0MBh/qh\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNmJL2b7yz9t2Q\n\tfor ;\n\tSat, 28 Oct 2017 01:21:06 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751345AbdJ0OVE (ORCPT\n\t);\n\tFri, 27 Oct 2017 10:21:04 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:52009 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751270AbdJ0OVC (ORCPT\n\t); Fri, 27 Oct 2017 10:21:02 -0400","by mail-wm0-f66.google.com with SMTP id b9so4162092wmh.0\n\tfor ;\n\tFri, 27 Oct 2017 07:21:02 -0700 (PDT)","from [10.44.66.8] ([212.45.67.2])\n\tby smtp.googlemail.com with ESMTPSA id\n\tz1sm5312400edz.97.2017.10.27.07.20.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 27 Oct 2017 07:21:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=C//LHdQieteWu4b54aer+Pywz/8zoVg79U1AvkWrKpY=;\n\tb=c0MBh/qhuUi8Wa2+BrIRsRov8BNbR6ohexGlnBYzYXHYCS0Dapz3myVacvfHK7DX4f\n\tHoNBs4cS4ejyK0cQrYb5YP8o3vnMI3JnDeHc47qat9HJTCdFnUu3BNmD48TUTQB6vC7s\n\tL7eZYMvNiimFTcUiLgJpdiQYwvp950nrUlxPM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=C//LHdQieteWu4b54aer+Pywz/8zoVg79U1AvkWrKpY=;\n\tb=IKdsf1VU+9v/R0WRHLaVRA9S5JYKaUnr9HbjLP0iXoF89pZ7LZHEy5qAjSYjWXArIx\n\tUgDR9c6RqMaQ1Yo1j5Vwrwb5h39bdkadtqaWpb2GQCXxmIDbapXNbAIo+wjtHLv8QRpC\n\toip+0KxSV9YOvj3H61Qk3X+VbdljEmorWrjZ+s1rm0jnwVKjEJ/O+2VjypaRPfKQud57\n\t/mFRGm4oHKSf1v2zT7M5l/OmOSz0xlN7S2DrRHbFKbp1K5h9fKFcme28wrrNHIxnetNU\n\tcBDQVDhnnHFPNF3EQcBHYfSFTSK7jKb5RHUiL9erNgTQ5w32GzNIi7G5C81XCVnC/+3Q\n\tBR6w==","X-Gm-Message-State":"AMCzsaWOhTd4z5An13iJrreDM0fto96q4sDAH550cR8R2+rr6Uw0OTHU\n\t3hdM9lYZKZre2dyoOKh69tzC3CIOcM0=","X-Google-Smtp-Source":"ABhQp+Ry1pB8szy30IZhBl43k1vSjbXigQKaDznVu37jpkPpCQq5XirMUKDuskyIw1M/Fk6RASGdTA==","X-Received":"by 10.80.231.4 with SMTP id a4mr823577edn.268.1509114061492;\n\tFri, 27 Oct 2017 07:21:01 -0700 (PDT)","Subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","To":"Bjorn Andersson , sboyd@codeaurora.org","Cc":"jassisinghbrar@gmail.com, robh+dt@kernel.org,\n\tmturquette@baylibre.com, linux-clk@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>\n\t<20170921164940.20343-4-georgi.djakov@linaro.org>\n\t<20171026042811.GL1575@tuxbook>","From":"Georgi Djakov ","Message-ID":"<5bad4c4b-362b-ba9f-3072-1cced7a004dd@linaro.org>","Date":"Fri, 27 Oct 2017 17:20:58 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20171026042811.GL1575@tuxbook>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1804048,"web_url":"http://patchwork.ozlabs.org/comment/1804048/","msgid":"<20171114021255.GY11955@codeaurora.org>","list_archive_url":null,"date":"2017-11-14T02:12:55","subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","submitter":{"id":6071,"url":"http://patchwork.ozlabs.org/api/people/6071/","name":"Stephen Boyd","email":"sboyd@codeaurora.org"},"content":"On 10/27, Georgi Djakov wrote:\n> Hi Bjorn,\n> \n> Thanks for reviewing!\n> \n> On 10/26/2017 07:28 AM, Bjorn Andersson wrote:\n> > On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:\n> > \n> >> Move the structure shared by the APCS IPC device and its subdevices\n> >> into a separate header file.\n> >>\n> > \n> > As you're creating the apcs regmap with devm_regmap_init_mmio() you can\n> > just call dev_get_regmap(dev->parent) in your child to get the handle.\n> \n> Ok, thanks!\n> \n> > \n> > But I would prefer that you just add the clock code to the existing\n> > driver.\n> \n> This will require an ack from Stephen, and i got the impression that he\n> prefers a separate clk driver [1].\n> \n> Stephen, are you ok with registering the clocks from the apcs mailbox\n> driver?\n> \n> [1] https://lkml.org/lkml/2017/6/26/750\n\nThe parent regmap \"trick\" was the plan. Is something wrong with\nthat?\n\nNot having random clk drivers scattered throughout the tree is\nsort of nice because it makes for an easier time finding things\nthat are similar. Maybe that's an abuse of the driver model\nthough? Just to get things into some same directory. I'm fine\neither way.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"NXhToNr6\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=codeaurora.org header.i=@codeaurora.org header.b=\"GI1blPov\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none) header.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=sboyd@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ybWHx3tyjz9s7c\n\tfor ;\n\tTue, 14 Nov 2017 13:13:01 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751376AbdKNCM7 (ORCPT\n\t);\n\tMon, 13 Nov 2017 21:12:59 -0500","from smtp.codeaurora.org ([198.145.29.96]:60032 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750806AbdKNCM6 (ORCPT\n\t); Mon, 13 Nov 2017 21:12:58 -0500","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 9F6CA607E2; Tue, 14 Nov 2017 02:12:57 +0000 (UTC)","from localhost (i-global254.qualcomm.com [199.106.103.254])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: sboyd@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 3608760714;\n\tTue, 14 Nov 2017 02:12:56 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1510625577;\n\tbh=mnxlOsYoa0WIxhlLUDAEhz73pfrWqJHRXUqxct/gEvU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NXhToNr6CEN0TFMK82tMOoV2I+y9ITJQW4nyhvH4xzS8Is88xYrJdE60UuknKDaha\n\txPsL5wXeWwaZY+mNsthobiLEMyfmoKgbtVD64q6Ct93CTrJWyIVHDlsIL11uJOQ77Y\n\tDo/RxJqzDDrCsixLSEHTpRHOvrHzwZqMgR7TKRac=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1510625576;\n\tbh=mnxlOsYoa0WIxhlLUDAEhz73pfrWqJHRXUqxct/gEvU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GI1blPovLS42tLHR/2lvgYKkugIe7uxwZVVcHWpIdtHCXk5XRwpyjQaaJYfyVTtxW\n\tqNnlVL66machwNEpmJSn2hVlJ7PUXGTWpx+YIBr8qLz/MdfduWVD4B7C6YhuEbZkuy\n\t/c3mQNn9/QRXmgJllIoJTnZpYkuBIflAQoTOU7XQ="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3608760714","Date":"Mon, 13 Nov 2017 18:12:55 -0800","From":"Stephen Boyd ","To":"Georgi Djakov ","Cc":"Bjorn Andersson ,\n\tjassisinghbrar@gmail.com, robh+dt@kernel.org,\n\tmturquette@baylibre.com, linux-clk@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","Message-ID":"<20171114021255.GY11955@codeaurora.org>","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>\n\t<20170921164940.20343-4-georgi.djakov@linaro.org>\n\t<20171026042811.GL1575@tuxbook>\n\t<5bad4c4b-362b-ba9f-3072-1cced7a004dd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<5bad4c4b-362b-ba9f-3072-1cced7a004dd@linaro.org>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1804075,"web_url":"http://patchwork.ozlabs.org/comment/1804075/","msgid":"<20171114044702.GF28761@minitux>","list_archive_url":null,"date":"2017-11-14T04:47:02","subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","submitter":{"id":68398,"url":"http://patchwork.ozlabs.org/api/people/68398/","name":"Bjorn Andersson","email":"bjorn.andersson@linaro.org"},"content":"On Mon 13 Nov 18:12 PST 2017, Stephen Boyd wrote:\n\n> On 10/27, Georgi Djakov wrote:\n> > Hi Bjorn,\n> > \n> > Thanks for reviewing!\n> > \n> > On 10/26/2017 07:28 AM, Bjorn Andersson wrote:\n> > > On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:\n> > > \n> > >> Move the structure shared by the APCS IPC device and its subdevices\n> > >> into a separate header file.\n> > >>\n> > > \n> > > As you're creating the apcs regmap with devm_regmap_init_mmio() you can\n> > > just call dev_get_regmap(dev->parent) in your child to get the handle.\n> > \n> > Ok, thanks!\n> > \n> > > \n> > > But I would prefer that you just add the clock code to the existing\n> > > driver.\n> > \n> > This will require an ack from Stephen, and i got the impression that he\n> > prefers a separate clk driver [1].\n> > \n> > Stephen, are you ok with registering the clocks from the apcs mailbox\n> > driver?\n> > \n> > [1] https://lkml.org/lkml/2017/6/26/750\n> \n> The parent regmap \"trick\" was the plan. Is something wrong with\n> that?\n> \n\nNot at all, but then this patch (moving apcs context to a shared header\nfile) shouldn't be needed, or am I missing something?\n\n> Not having random clk drivers scattered throughout the tree is\n> sort of nice because it makes for an easier time finding things\n> that are similar. Maybe that's an abuse of the driver model\n> though? Just to get things into some same directory. I'm fine\n> either way.\n> \n\nKeeping the clock driver in the clock subsystem does make sense. I see\nnow that there is a include of a local header file as well, so that\nwould just be messy to keep split.\n\nI'm fine with the extra driver instance, it's the DT that I don't think\nshould describe the fact that we want to keep the clock-part in the\nclock subsystem.\n\nDo you see any problems spawning the clock driver programmatically and\nthen calling of_clk_add_hw_provider() on the parent's of_node?\n\nRegards,\nBjorn\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"CZuUvRai\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ybZlD0Xlcz9s0g\n\tfor ;\n\tTue, 14 Nov 2017 15:48:24 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754006AbdKNEsW (ORCPT\n\t);\n\tMon, 13 Nov 2017 23:48:22 -0500","from mail-pf0-f173.google.com ([209.85.192.173]:45797 \"EHLO\n\tmail-pf0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753670AbdKNErG (ORCPT\n\t); Mon, 13 Nov 2017 23:47:06 -0500","by mail-pf0-f173.google.com with SMTP id d28so13544817pfe.2\n\tfor ;\n\tMon, 13 Nov 2017 20:47:06 -0800 (PST)","from minitux (ip68-111-217-79.sd.sd.cox.net. [68.111.217.79])\n\tby smtp.gmail.com with ESMTPSA id\n\tm11sm1198143pfh.35.2017.11.13.20.47.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 13 Nov 2017 20:47:05 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=BKQUkIAV71y0I+0L4NjQg37V5lndORfsgCBLtxDepes=;\n\tb=CZuUvRail6u6OBvLsqytS4Rn+xIueLKW+nWd0dkPOPLIxQwZ4VHr8+GK0+5DdDOVv5\n\tKXQhkz/5xaYEfx7xEmLo1+r+OmUWmlWqaM0P2OlLGhkFyOqKfBK1cB9Kh4+yXTs/9wxI\n\tbaiv7bEEy45vJCgS8NibZl7B0opdEQLRfk2OE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=BKQUkIAV71y0I+0L4NjQg37V5lndORfsgCBLtxDepes=;\n\tb=RpKxxwgubvr5cC7mQzKDax97/JIRG/XIrlfrJ59AQcGoeHhOdnhbd+f5BUeKAtF/Np\n\tLhanDz+J5epvRZVe6rRTQeefEtbs8C7JZeT+DA4WvNT0OrsDFy4EeouuMLXjzVCgBDEb\n\t+xY0JtDOz5beORlYsFPTI5JsWNg82PwvqBoPZiXR+yzIDBdIfX5Uit7eod6LKJb09E4G\n\tFENPf8s/PaMRmGJFLKljrWjxIHs0RAUHKgwHiYBS1K1VyprGUbg0NiGSOm66a5yp7Ncm\n\tWCHesXurTM65+7nTbG3puhH29L1kKssJVkB04RBjDC8vP60pIighsK0XmnvmllFDFgDH\n\th1Ig==","X-Gm-Message-State":"AJaThX78gmIItQ3O3bYnXUsoqbLrOceghJ4TJp/1tts5tcHx9S8d2VwE\n\tymMCaQ1mTnU7zbmVGLL4vev2ow==","X-Google-Smtp-Source":"AGs4zMYEO0ZmmO1GvB0ed6NDTPCQbKZoQtOesLEJBoxC1+sw0vIwqGZkQ8MbUH3UU+RIrDih6gehIw==","X-Received":"by 10.84.198.35 with SMTP id o32mr11124681pld.214.1510634825989; \n\tMon, 13 Nov 2017 20:47:05 -0800 (PST)","Date":"Mon, 13 Nov 2017 20:47:02 -0800","From":"Bjorn Andersson ","To":"Stephen Boyd ","Cc":"Georgi Djakov , jassisinghbrar@gmail.com,\n\trobh+dt@kernel.org, mturquette@baylibre.com,\n\tlinux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org","Subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","Message-ID":"<20171114044702.GF28761@minitux>","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>\n\t<20170921164940.20343-4-georgi.djakov@linaro.org>\n\t<20171026042811.GL1575@tuxbook>\n\t<5bad4c4b-362b-ba9f-3072-1cced7a004dd@linaro.org>\n\t<20171114021255.GY11955@codeaurora.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171114021255.GY11955@codeaurora.org>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1804568,"web_url":"http://patchwork.ozlabs.org/comment/1804568/","msgid":"<20171114181212.GC11955@codeaurora.org>","list_archive_url":null,"date":"2017-11-14T18:12:12","subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","submitter":{"id":6071,"url":"http://patchwork.ozlabs.org/api/people/6071/","name":"Stephen Boyd","email":"sboyd@codeaurora.org"},"content":"On 11/13, Bjorn Andersson wrote:\n> On Mon 13 Nov 18:12 PST 2017, Stephen Boyd wrote:\n> \n> > On 10/27, Georgi Djakov wrote:\n> > > Hi Bjorn,\n> > > \n> > > Thanks for reviewing!\n> > > \n> > > On 10/26/2017 07:28 AM, Bjorn Andersson wrote:\n> > > > On Thu 21 Sep 09:49 PDT 2017, Georgi Djakov wrote:\n> > > > \n> > > >> Move the structure shared by the APCS IPC device and its subdevices\n> > > >> into a separate header file.\n> > > >>\n> > > > \n> > > > As you're creating the apcs regmap with devm_regmap_init_mmio() you can\n> > > > just call dev_get_regmap(dev->parent) in your child to get the handle.\n> > > \n> > > Ok, thanks!\n> > > \n> > > > \n> > > > But I would prefer that you just add the clock code to the existing\n> > > > driver.\n> > > \n> > > This will require an ack from Stephen, and i got the impression that he\n> > > prefers a separate clk driver [1].\n> > > \n> > > Stephen, are you ok with registering the clocks from the apcs mailbox\n> > > driver?\n> > > \n> > > [1] https://lkml.org/lkml/2017/6/26/750\n> > \n> > The parent regmap \"trick\" was the plan. Is something wrong with\n> > that?\n> > \n> \n> Not at all, but then this patch (moving apcs context to a shared header\n> file) shouldn't be needed, or am I missing something?\n\nAgreed.\n\n> \n> > Not having random clk drivers scattered throughout the tree is\n> > sort of nice because it makes for an easier time finding things\n> > that are similar. Maybe that's an abuse of the driver model\n> > though? Just to get things into some same directory. I'm fine\n> > either way.\n> > \n> \n> Keeping the clock driver in the clock subsystem does make sense. I see\n> now that there is a include of a local header file as well, so that\n> would just be messy to keep split.\n> \n> I'm fine with the extra driver instance, it's the DT that I don't think\n> should describe the fact that we want to keep the clock-part in the\n> clock subsystem.\n> \n> Do you see any problems spawning the clock driver programmatically and\n> then calling of_clk_add_hw_provider() on the parent's of_node?\n\nNope. We shouldn't need to modify DT to make this work.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"EzRTPMc0\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n\theader.d=codeaurora.org header.i=@codeaurora.org header.b=\"EzRTPMc0\"; \n\tdkim-atps=neutral","pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none) header.from=codeaurora.org","pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=sboyd@codeaurora.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3ybwZr0B2yz9sMN\n\tfor ;\n\tWed, 15 Nov 2017 05:12:19 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754850AbdKNSMQ (ORCPT\n\t);\n\tTue, 14 Nov 2017 13:12:16 -0500","from smtp.codeaurora.org ([198.145.29.96]:36752 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753931AbdKNSMO (ORCPT\n\t); Tue, 14 Nov 2017 13:12:14 -0500","by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid E706B600C9; Tue, 14 Nov 2017 18:12:13 +0000 (UTC)","from localhost (i-global254.qualcomm.com [199.106.103.254])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: sboyd@smtp.codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 3721A600C9;\n\tTue, 14 Nov 2017 18:12:13 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1510683133;\n\tbh=Mnun40bWmh8bvQOFxvOqihErC9afUHOGJGvjA+K81i0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EzRTPMc0SmfSqTR+d6pHczkZmBl8hqi4J7GXBM5U8eVe+floOf9HXBSRJ0Wo5f79Z\n\tHOir/8KEyMlqoy5HQHFTJdDVpkcB+TDfF8K8jxv3DDBPwp6rNa9dU+gn65FOX8uEGe\n\t/5O2yUT+bnSUzPK3d7qkdyRx+o/K5O399dOdWwIA=","v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1510683133;\n\tbh=Mnun40bWmh8bvQOFxvOqihErC9afUHOGJGvjA+K81i0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EzRTPMc0SmfSqTR+d6pHczkZmBl8hqi4J7GXBM5U8eVe+floOf9HXBSRJ0Wo5f79Z\n\tHOir/8KEyMlqoy5HQHFTJdDVpkcB+TDfF8K8jxv3DDBPwp6rNa9dU+gn65FOX8uEGe\n\t/5O2yUT+bnSUzPK3d7qkdyRx+o/K5O399dOdWwIA="],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org","X-Spam-Level":"","X-Spam-Status":"No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0","DMARC-Filter":"OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3721A600C9","Date":"Tue, 14 Nov 2017 10:12:12 -0800","From":"Stephen Boyd ","To":"Bjorn Andersson ","Cc":"Georgi Djakov , jassisinghbrar@gmail.com,\n\trobh+dt@kernel.org, mturquette@baylibre.com,\n\tlinux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org","Subject":"Re: [PATCH v9 3/7] mailbox: qcom: Move the apcs struct into a\n\tseparate header","Message-ID":"<20171114181212.GC11955@codeaurora.org>","References":"<20170921164940.20343-1-georgi.djakov@linaro.org>\n\t<20170921164940.20343-4-georgi.djakov@linaro.org>\n\t<20171026042811.GL1575@tuxbook>\n\t<5bad4c4b-362b-ba9f-3072-1cced7a004dd@linaro.org>\n\t<20171114021255.GY11955@codeaurora.org>\n\t<20171114044702.GF28761@minitux>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20171114044702.GF28761@minitux>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]