[{"id":1773043,"web_url":"http://patchwork.ozlabs.org/comment/1773043/","msgid":"<20170921181503.2d4w7fklptt4cktv@pengutronix.de>","list_archive_url":null,"date":"2017-09-21T18:15:03","subject":"Re: [PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA\n\tstarts","submitter":{"id":1476,"url":"http://patchwork.ozlabs.org/api/people/1476/","name":"Uwe Kleine-König","email":"u.kleine-koenig@pengutronix.de"},"content":"On Thu, Sep 21, 2017 at 05:18:13PM +0100, Martyn Welch wrote:\n> From: Romain Perier \n> \n> The variable dma_is_rxing is currently set to 1 in imx_disable_rx_int().\n> This is problematic as:\n> \n> - whilst imx_disable_rx_int() is currently always called before\n> start_rx_dma() this dependency isn't obvious.\n> - start_rx_dma() does error checking and might exit without\n> enabling DMA. Currently this will result in dma_is_rxing suggesting\n> that DMA is being used for recieving.\n> \n> To avoid these issues, move the setting of dma_is_rxing to\n> start_rx_dma() when appropriate.\n> \n> Signed-off-by: Romain Perier \n> Signed-off-by: Martyn Welch \nReviewed-by: Uwe Kleine-König \n\nThanks\nUwe","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"YF/BOv3f\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xylCh0WJMz9t4P\n\tfor ;\n\tFri, 22 Sep 2017 04:15:42 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv60d-0004gS-I1; Thu, 21 Sep 2017 18:15:35 +0000","from metis.ext.pengutronix.de\n\t([2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv60Z-00042s-G1 for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 18:15:33 +0000","from [2001:67c:670:100:5054:ff:fe2a:3aa]\n\t(helo=pty.hi.pengutronix.de)\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dv60A-0003m1-BT; Thu, 21 Sep 2017 20:15:06 +0200","from ukl by pty.hi.pengutronix.de with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dv607-0002Kg-HF; Thu, 21 Sep 2017 20:15:03 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=uWydleCdmoQOHoqWhHUamLo+14FUPufZFZBl1BtpCcg=;\n\tb=YF/BOv3frfljh7\n\tBOUvqs365mQzoCD62AO8v7m9vk6Kw7LAZW+P5PYzF0C4tNYgLoXOHfnjMSNremyhNzqUbYd37Z9Qf\n\t+EqLTfDKX5ypvs4+8/aUeBK41YDlKgRKecog/JhZ5EFr6hllaulmbsnYGU95QnezRcdiVcSPQyVuI\n\tFqbLh797WytTABMzuqO81T+VSZIAvpw3yoHgPZA+O+N7jonQ/tdC3nwqK1Pbxc5F+5pU3/In1XN2q\n\teHSI8903G6dxWryDMxJn0fK+fVv4qoVJ+l7mlzM62OfzdNZyNMls4H9Ti4ZGLZT6pufglvsy4gKxz\n\t8hLKz/OCy2ul1ltvNXuA==;","Date":"Thu, 21 Sep 2017 20:15:03 +0200","From":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ","To":"Martyn Welch ","Subject":"Re: [PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA\n\tstarts","Message-ID":"<20170921181503.2d4w7fklptt4cktv@pengutronix.de>","References":"<1506010697-22114-1-git-send-email-martyn.welch@collabora.co.uk>\n\t<1506010697-22114-3-git-send-email-martyn.welch@collabora.co.uk>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1506010697-22114-3-git-send-email-martyn.welch@collabora.co.uk>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-SA-Exim-Connect-IP":"2001:67c:670:100:5054:ff:fe2a:3aa","X-SA-Exim-Mail-From":"ukl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"linux-arm-kernel@lists.infradead.org","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_111531_741573_FF474874 ","X-CRM114-Status":"GOOD ( 11.25 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Greg Kroah-Hartman ,\n\tlinux-kernel@vger.kernel.org, Fabio Estevam , \n\tlinux-serial@vger.kernel.org, Nandor Han ,\n\tRomain Perier ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773045,"web_url":"http://patchwork.ozlabs.org/comment/1773045/","msgid":"<20170921182017.t7c75tyy66q7q3ns@pengutronix.de>","list_archive_url":null,"date":"2017-09-21T18:20:17","subject":"Re: [PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from\n\timx_disable_dma","submitter":{"id":1476,"url":"http://patchwork.ozlabs.org/api/people/1476/","name":"Uwe Kleine-König","email":"u.kleine-koenig@pengutronix.de"},"content":"On Thu, Sep 21, 2017 at 05:18:12PM +0100, Martyn Welch wrote:\n> From: Nandor Han \n> \n> The CTSC and CTS bits affect operation of the CTS/RTS hardware flow\n> control signal (depending on whether the device is in DCE or DTE mode) and\n> are not related to DMA. When in RS-232 mode, the driver is using the\n> automatic CTSC control based on a rxFIFO fill level unless the state of\n> the CTS signal is explictly set via an ioctl call.\n> \n> Previous improvements to the imx serial driver have resulted on\n> imx_disable_dma() only being called on shutdown, by which point the\n> serial core has already correctly deasserted CTS.\n> \n> Testing shows that without this handling in imx_disable_dma() the CTS\n> signal state is set correctly when the device is open and TIOCM_RTS is\n> set/cleared via the TIOCMGET ioctl. The CTS signal is also correctly\n> deasserted when the device file is closed.\n\nWith that block kept CTS set once more to inactive. So the block doesn't\nhurt and is \"only\" superflous, right?\n\n> When in RS-485 mode, the driver uses the CTS signal very differently and\n> appears to control it via calls to imx_port_rts_active() and\n> imx_port_rts_inactive().\n> \n> This configuration of the CTSC and CTS bits are therefore not needed.\n> \n> Signed-off-by: Nandor Han \n> Signed-off-by: Romain Perier \n> Signed-off-by: Martyn Welch \n> ---\n> drivers/tty/serial/imx.c | 5 -----\n> 1 file changed, 5 deletions(-)\n> \n> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c\n> index fe368a4..d90dae3 100644\n> --- a/drivers/tty/serial/imx.c\n> +++ b/drivers/tty/serial/imx.c\n> @@ -1225,11 +1225,6 @@ static void imx_disable_dma(struct imx_port *sport)\n> \ttemp &= ~(UCR1_RDMAEN | UCR1_TDMAEN | UCR1_ATDMAEN);\n> \twritel(temp, sport->port.membase + UCR1);\n> \n> -\t/* clear UCR2 */\n> -\ttemp = readl(sport->port.membase + UCR2);\n> -\ttemp &= ~(UCR2_CTSC | UCR2_CTS | UCR2_ATEN);\n> -\twritel(temp, sport->port.membase + UCR2);\n\nThe commit log doesn't mention ATEN, I guess that one just doesn't\nmatter any more at this stage? Would be nice to point out though.\n\nBest regards\nUwe","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"m/B7DHuT\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xylKX3FmTz9t4c\n\tfor ;\n\tFri, 22 Sep 2017 04:20:48 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv65d-0006aA-3H; Thu, 21 Sep 2017 18:20:45 +0000","from metis.ext.pengutronix.de\n\t([2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv65Z-0006Wy-2x for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 18:20:43 +0000","from [2001:67c:670:100:5054:ff:fe2a:3aa]\n\t(helo=pty.hi.pengutronix.de)\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dv65C-0004Yj-PX; Thu, 21 Sep 2017 20:20:18 +0200","from ukl by pty.hi.pengutronix.de with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dv65B-0002xw-KE; Thu, 21 Sep 2017 20:20:17 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=I3Gwdy82nhWxXBaZ08O0y4pd0l1MDQhS1yY0RKsNCgI=;\n\tb=m/B7DHuT1zRyLR\n\tlp7C0x1iW1BqibV+jgBn3hvfRi+mfzuZ7rUagYVfmG7U2vlettAFanFZNfnyCDnoOFD1C7Lt8ug4m\n\t42ip55m4jHuvYToXK6F8wZLV8pASaGhFQpXVDq0xFhWWIewSoS2BUnbmn9EiCO7mm2N2iniZrE2Oi\n\tGUWv9/ISJ5gyaJ7E+CvjYGHBSPih/U4vFWnov+zz4/0ne9o3E7VNEfUt/lK6IxWsJoFclG5xOdfrj\n\tF2zJUlQKbrWsSrrYZx47fQ3TAs6TXkMA93kabI9KJTWCVFOLm5G+3ABVedWC8AhBRKllw0fxPUxBn\n\tuTUXG7NYem8dXSunu2nQ==;","Date":"Thu, 21 Sep 2017 20:20:17 +0200","From":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ","To":"Martyn Welch ","Subject":"Re: [PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from\n\timx_disable_dma","Message-ID":"<20170921182017.t7c75tyy66q7q3ns@pengutronix.de>","References":"<1506010697-22114-1-git-send-email-martyn.welch@collabora.co.uk>\n\t<1506010697-22114-2-git-send-email-martyn.welch@collabora.co.uk>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1506010697-22114-2-git-send-email-martyn.welch@collabora.co.uk>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-SA-Exim-Connect-IP":"2001:67c:670:100:5054:ff:fe2a:3aa","X-SA-Exim-Mail-From":"ukl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"linux-arm-kernel@lists.infradead.org","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_112041_320947_34ECA8EF ","X-CRM114-Status":"GOOD ( 19.62 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Greg Kroah-Hartman ,\n\tlinux-kernel@vger.kernel.org, Fabio Estevam , \n\tlinux-serial@vger.kernel.org, Nandor Han ,\n\tRomain Perier ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773047,"web_url":"http://patchwork.ozlabs.org/comment/1773047/","msgid":"<20170921182556.n7qael3fyorvkfki@pengutronix.de>","list_archive_url":null,"date":"2017-09-21T18:25:56","subject":"Re: [PATCH v3 4/6] serial: imx: unmap sg buffers when DMA channel is\n\treleased","submitter":{"id":1476,"url":"http://patchwork.ozlabs.org/api/people/1476/","name":"Uwe Kleine-König","email":"u.kleine-koenig@pengutronix.de"},"content":"On Thu, Sep 21, 2017 at 05:18:15PM +0100, Martyn Welch wrote:\n> From: Nandor Han \n> \n> This commits unmaps sg buffers when the DMA channel is released. It also\n> sets to zero `dma_is_rxing` and `dma_is_txing` to state that the\n> corresponding channels cannot transmit/receive data, as these are\n> disabled.\n\nThat's a fix for a race, right? The functions being fixed were\nintroduced just in the patch before and I guess the race was there\nalready before. It is best if you could resort your series to have fixes\nfirst. This way they can easily be applied during the rc phase while the\nrest waits for the merge window.\n\nBest regards\nUwe","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"IZIxmoeX\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xylS94hcfz9sP1\n\tfor ;\n\tFri, 22 Sep 2017 04:26:33 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv6BC-0008UE-8K; Thu, 21 Sep 2017 18:26:30 +0000","from metis.ext.pengutronix.de\n\t([2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv6B2-0008Sc-VQ for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 18:26:28 +0000","from [2001:67c:670:100:5054:ff:fe2a:3aa]\n\t(helo=pty.hi.pengutronix.de)\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dv6Ag-0005IA-9O; Thu, 21 Sep 2017 20:25:58 +0200","from ukl by pty.hi.pengutronix.de with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dv6Ae-00039z-TE; Thu, 21 Sep 2017 20:25:56 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=UrfKhk1RR7peX7RoGTb2e1GXCUfvqB8Wzca7ZlTuCoo=;\n\tb=IZIxmoeXh2SUHm\n\tkFraATCE+qiBopyfXNG7OumdfbkjiQtZ9xA2gWLYdZrzG3BsQb+pm2AJW5yTVe8hYJNboTFCEBXdY\n\th+H9VUSSEysNC1W/Kr7soFNfDYTYL/e3kbTioiEb9GrrxGgw+Z/pBm338LWc/8OTS0TH4ou7eHWWp\n\tb5nHvvZWsR4SDs6VCsdMQzgFDJsFras8HVaH6ILY/j/1Mh8dbFP7Egh2JF4IronRasGRF/A7wWCbx\n\tkbElLG3bBhcWe+Kl+AyEZhFSctTz0GFz6/ViKtcqmUbZwbMc5YZ/bjfSpWmwUND+qokv9uNR7RTdG\n\tFhNTOylAU0XdrbR01tcA==;","Date":"Thu, 21 Sep 2017 20:25:56 +0200","From":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ","To":"Martyn Welch ","Subject":"Re: [PATCH v3 4/6] serial: imx: unmap sg buffers when DMA channel is\n\treleased","Message-ID":"<20170921182556.n7qael3fyorvkfki@pengutronix.de>","References":"<1506010697-22114-1-git-send-email-martyn.welch@collabora.co.uk>\n\t<1506010697-22114-5-git-send-email-martyn.welch@collabora.co.uk>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1506010697-22114-5-git-send-email-martyn.welch@collabora.co.uk>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-SA-Exim-Connect-IP":"2001:67c:670:100:5054:ff:fe2a:3aa","X-SA-Exim-Mail-From":"ukl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"linux-arm-kernel@lists.infradead.org","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_112626_757990_8D803B50 ","X-CRM114-Status":"GOOD ( 10.79 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Greg Kroah-Hartman ,\n\tlinux-kernel@vger.kernel.org, Fabio Estevam , \n\tlinux-serial@vger.kernel.org, Nandor Han ,\n\tRomain Perier ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773051,"web_url":"http://patchwork.ozlabs.org/comment/1773051/","msgid":"<20170921182817.wejxqp5e733systb@pengutronix.de>","list_archive_url":null,"date":"2017-09-21T18:28:17","subject":"Re: [PATCH v3 5/6] serial: imx: update the stop rx,tx procedures","submitter":{"id":1476,"url":"http://patchwork.ozlabs.org/api/people/1476/","name":"Uwe Kleine-König","email":"u.kleine-koenig@pengutronix.de"},"content":"On Thu, Sep 21, 2017 at 05:18:16PM +0100, Martyn Welch wrote:\n> From: Nandor Han \n> \n> According to \"Documentation/serial/driver\" both procedures should stop\n> receiving or sending data. Based on this the procedures should stop the\n> activity regardless if DMA is enabled or not.\n> \n> This commit updates both imx_stop_{rx|tx} procedures to stop the\n> activity and disable the interrupts related to that.\n> \n> Signed-off-by: Nandor Han \n> Signed-off-by: Romain Perier \n> Signed-off-by: Martyn Welch \n> ---\n> drivers/tty/serial/imx.c | 36 +++++++++++++++++-------------------\n> 1 file changed, 17 insertions(+), 19 deletions(-)\n> \n> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c\n> index ed02783..256b128 100644\n> --- a/drivers/tty/serial/imx.c\n> +++ b/drivers/tty/serial/imx.c\n> @@ -388,15 +388,14 @@ static void imx_stop_tx(struct uart_port *port)\n> \tstruct imx_port *sport = (struct imx_port *)port;\n> \tunsigned long temp;\n> \n> -\t/*\n> -\t * We are maybe in the SMP context, so if the DMA TX thread is running\n> -\t * on other cpu, we have to wait for it to finish.\n> -\t */\n\ndid you understand this comment you're removing here? I admit I don't\nbut unless it is non-sensical you're doing something wrong.\n\nBest regards\nUwe","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"bVz2xj+x\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xylVm4KNnz9sP1\n\tfor ;\n\tFri, 22 Sep 2017 04:28:48 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv6DN-0000WI-A2; Thu, 21 Sep 2017 18:28:45 +0000","from metis.ext.pengutronix.de\n\t([2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv6DI-0000TL-Tk for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 18:28:42 +0000","from [2001:67c:670:100:5054:ff:fe2a:3aa]\n\t(helo=pty.hi.pengutronix.de)\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dv6Cw-0005fT-He; Thu, 21 Sep 2017 20:28:18 +0200","from ukl by pty.hi.pengutronix.de with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dv6Cv-0003Au-NG; Thu, 21 Sep 2017 20:28:17 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=7wCfbSAMY1SeZCVIJY5aT3nx9/A1vAaU3RBXyTXspOs=;\n\tb=bVz2xj+xPNPMs3\n\teLvTYZ+LIikZe4/MuLT4ReJdSSo4vn5VxkPtOLjuXSj6APZ7s5eLBgts8kNIN/jehmQUqj5A8blUK\n\tUHZhTpPtLVUH/KEPilmWYGWJMN/UdDyu5n1H7jMKRm0rl1Y0hMt6Ln1BPVGHc9TnjkJiQg+R3bgkj\n\tEy4GF4SGYUMG3X0LpAQEKaiw0mV5htcNK3m+TkMwzNZB7Rvg5+/qUr1amv9FOoGxR6ht8PnGm2NJn\n\tZfVfAwr4FcIj7XfSWJNp3UjgOuGIm3Vt8VuVWCa8G21RuzpoYmxFmCDivbnzk0k4uBH3wltByMZP/\n\tQ4CIJ3TOwpRE3MgKiXnQ==;","Date":"Thu, 21 Sep 2017 20:28:17 +0200","From":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ","To":"Martyn Welch ","Subject":"Re: [PATCH v3 5/6] serial: imx: update the stop rx,tx procedures","Message-ID":"<20170921182817.wejxqp5e733systb@pengutronix.de>","References":"<1506010697-22114-1-git-send-email-martyn.welch@collabora.co.uk>\n\t<1506010697-22114-6-git-send-email-martyn.welch@collabora.co.uk>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1506010697-22114-6-git-send-email-martyn.welch@collabora.co.uk>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-SA-Exim-Connect-IP":"2001:67c:670:100:5054:ff:fe2a:3aa","X-SA-Exim-Mail-From":"ukl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"linux-arm-kernel@lists.infradead.org","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_112841_160775_820F4822 ","X-CRM114-Status":"GOOD ( 15.38 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Greg Kroah-Hartman ,\n\tlinux-kernel@vger.kernel.org, Fabio Estevam , \n\tlinux-serial@vger.kernel.org, Nandor Han ,\n\tRomain Perier ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773074,"web_url":"http://patchwork.ozlabs.org/comment/1773074/","msgid":"<20170921191257.GJ6739@hermes.home>","list_archive_url":null,"date":"2017-09-21T19:12:57","subject":"Re: [PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from\n\timx_disable_dma","submitter":{"id":67546,"url":"http://patchwork.ozlabs.org/api/people/67546/","name":"Martyn Welch","email":"martyn.welch@collabora.co.uk"},"content":"On Thu, Sep 21, 2017 at 08:20:17PM +0200, Uwe Kleine-König wrote:\n> On Thu, Sep 21, 2017 at 05:18:12PM +0100, Martyn Welch wrote:\n> > From: Nandor Han \n> > \n> > The CTSC and CTS bits affect operation of the CTS/RTS hardware flow\n> > control signal (depending on whether the device is in DCE or DTE mode) and\n> > are not related to DMA. When in RS-232 mode, the driver is using the\n> > automatic CTSC control based on a rxFIFO fill level unless the state of\n> > the CTS signal is explictly set via an ioctl call.\n> > \n> > Previous improvements to the imx serial driver have resulted on\n> > imx_disable_dma() only being called on shutdown, by which point the\n> > serial core has already correctly deasserted CTS.\n> > \n> > Testing shows that without this handling in imx_disable_dma() the CTS\n> > signal state is set correctly when the device is open and TIOCM_RTS is\n> > set/cleared via the TIOCMGET ioctl. The CTS signal is also correctly\n> > deasserted when the device file is closed.\n> \n> With that block kept CTS set once more to inactive. So the block doesn't\n> hurt and is \"only\" superflous, right?\n> \n\nThat's my understanding, yes.\n\n> > When in RS-485 mode, the driver uses the CTS signal very differently and\n> > appears to control it via calls to imx_port_rts_active() and\n> > imx_port_rts_inactive().\n> > \n> > This configuration of the CTSC and CTS bits are therefore not needed.\n> > \n> > Signed-off-by: Nandor Han \n> > Signed-off-by: Romain Perier \n> > Signed-off-by: Martyn Welch \n> > ---\n> > drivers/tty/serial/imx.c | 5 -----\n> > 1 file changed, 5 deletions(-)\n> > \n> > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c\n> > index fe368a4..d90dae3 100644\n> > --- a/drivers/tty/serial/imx.c\n> > +++ b/drivers/tty/serial/imx.c\n> > @@ -1225,11 +1225,6 @@ static void imx_disable_dma(struct imx_port *sport)\n> > \ttemp &= ~(UCR1_RDMAEN | UCR1_TDMAEN | UCR1_ATDMAEN);\n> > \twritel(temp, sport->port.membase + UCR1);\n> > \n> > -\t/* clear UCR2 */\n> > -\ttemp = readl(sport->port.membase + UCR2);\n> > -\ttemp &= ~(UCR2_CTSC | UCR2_CTS | UCR2_ATEN);\n> > -\twritel(temp, sport->port.membase + UCR2);\n> \n> The commit log doesn't mention ATEN, I guess that one just doesn't\n> matter any more at this stage? Would be nice to point out though.\n> \n\nHmm, going to need to look at this again...\n\nPatch 5 adds clearing ATEN into imx_stop_rx(), which is sensible given\nthat it's the aging timer on the rxFIFO, but I don't think we should be\nremoving that from here before it's in imx_stop_rx().\n\n> Best regards\n> Uwe\n> \n> -- \n> Pengutronix e.K. | Uwe Kleine-König |\n> Industrial Linux Solutions | http://www.pengutronix.de/ |","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"uEcXJo2V\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xymVN0m2Lz9t2l\n\tfor ;\n\tFri, 22 Sep 2017 05:13:32 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv6ue-0002LR-CH; Thu, 21 Sep 2017 19:13:28 +0000","from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv6uZ-0002Hs-Qn for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 19:13:26 +0000","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: martyn) with ESMTPSA id 7F4A12607F8","from martyn by hermes with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dv6u9-0007fv-Ep; Thu, 21 Sep 2017 20:12:57 +0100"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=MIultjJ+R49qrReh9Iz8syGBUz6gmRjI/WcuTYfoSB8=;\n\tb=uEcXJo2VWSYoyk\n\tm9OZnq88IZ/Bp1sAaVVQER2gJW8vh7v81cFdo1LeDjMEaoYBVaJD76r1Idx9EEVtCB3NI5w3xXXgJ\n\t+XpuaWOR70d0A3uU1abJ8mWS37ljcTtDnG2uCs7MnfnIfCjp3wTASDczKeG7SUrsuJ3qQdVwuxdqr\n\tTcOSy/B6uGNiOfKfa14bXjiZobmq5cM2My3tzi9gszOWKqKqiPHw2Y50lmbfdOTrPGfGP1akEsPWL\n\teWVnm29XsT0zUsxqlMWfZl0VuJzfOqTz7xzW9muuWcv+BBRMIfaOAm/+0To/U7cPWuhKkSuBXnoru\n\tZyZbvRZjR4sKGc6MLCoA==;","Date":"Thu, 21 Sep 2017 20:12:57 +0100","From":"Martyn Welch ","To":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ","Subject":"Re: [PATCH v3 1/6] serial: imx: remove CTSC and CTS handling from\n\timx_disable_dma","Message-ID":"<20170921191257.GJ6739@hermes.home>","References":"<1506010697-22114-1-git-send-email-martyn.welch@collabora.co.uk>\n\t<1506010697-22114-2-git-send-email-martyn.welch@collabora.co.uk>\n\t<20170921182017.t7c75tyy66q7q3ns@pengutronix.de>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170921182017.t7c75tyy66q7q3ns@pengutronix.de>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_121324_287998_7B6564B1 ","X-CRM114-Status":"GOOD ( 23.02 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Greg Kroah-Hartman ,\n\tlinux-kernel@vger.kernel.org, Fabio Estevam , \n\tlinux-serial@vger.kernel.org, Nandor Han ,\n\tRomain Perier ,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]