[{"id":1772805,"web_url":"http://patchwork.ozlabs.org/comment/1772805/","msgid":"<20170921133535.GI13703@lemon.lan>","list_archive_url":null,"date":"2017-09-21T13:35:35","subject":"Re: [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Thu, 09/21 16:17, Manos Pitsidianakis wrote:\n> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new \n> bdrv_co_drain_end callback to match bdrv_drained_begin/end and \n> drained_begin/end of BdrvChild. This is needed because the throttle driver \n> (block/throttle.c) needs a way to mark the end of the drain in order to toggle \n> io_limits_disabled correctly.\n\nIs this a bug fix? I.e. do we need to Cc qemu-stable@?\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyd1B1DFzz9t43\n\tfor ;\n\tThu, 21 Sep 2017 23:36:14 +1000 (AEST)","from localhost ([::1]:53752 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dv1eG-0005j8-C8\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 09:36:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60950)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dv1dv-0005hP-7m\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:35:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dv1du-0005HK-B8\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:35:51 -0400","from mx1.redhat.com ([209.132.183.28]:57688)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dv1dn-0005Cn-AT; Thu, 21 Sep 2017 09:35:43 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4798C85540;\n\tThu, 21 Sep 2017 13:35:42 +0000 (UTC)","from localhost (ovpn-12-27.pek2.redhat.com [10.72.12.27])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 799936266B;\n\tThu, 21 Sep 2017 13:35:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4798C85540","Date":"Thu, 21 Sep 2017 21:35:35 +0800","From":"Fam Zheng ","To":"Manos Pitsidianakis ","Message-ID":"<20170921133535.GI13703@lemon.lan>","References":"<20170921131707.17364-1-el13635@mail.ntua.gr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921131707.17364-1-el13635@mail.ntua.gr>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 21 Sep 2017 13:35:42 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-block ,\n\tqemu-devel ,\n\tStefan Hajnoczi , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772814,"web_url":"http://patchwork.ozlabs.org/comment/1772814/","msgid":"<20170921134211.ilym353a3pmeilc4@postretch>","list_archive_url":null,"date":"2017-09-21T13:42:11","subject":"Re: [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","submitter":{"id":71571,"url":"http://patchwork.ozlabs.org/api/people/71571/","name":"Manos Pitsidianakis","email":"el13635@mail.ntua.gr"},"content":"On Thu, Sep 21, 2017 at 09:35:35PM +0800, Fam Zheng wrote:\n>On Thu, 09/21 16:17, Manos Pitsidianakis wrote:\n>> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new\n>> bdrv_co_drain_end callback to match bdrv_drained_begin/end and\n>> drained_begin/end of BdrvChild. This is needed because the throttle driver\n>> (block/throttle.c) needs a way to mark the end of the drain in order to toggle\n>> io_limits_disabled correctly.\n>\n>Is this a bug fix? I.e. do we need to Cc qemu-stable@?\n>\n>Fam\n\nNo that's not needed, throttle is not in 2.10. The bug in this case is \nthat the drain would wait for the throttled requests to be completed as \nthey were scheduled by the I/O throttling instead of restarting the \nqueue and scheduling them right away.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xydLm4795z9ryr\n\tfor ;\n\tThu, 21 Sep 2017 23:51:28 +1000 (AEST)","from localhost ([::1]:53847 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dv1t0-0000P2-Q0\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 09:51:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34779)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dv1kI-0002Ub-2R\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:42:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dv1kG-000192-UT\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:42:26 -0400","from smtp1.ntua.gr ([2001:648:2000:de::183]:40548)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dv1kC-0000zO-9u; Thu, 21 Sep 2017 09:42:20 -0400","from mail.ntua.gr (carp0.noc.ntua.gr [147.102.222.60])\n\t(authenticated bits=0)\n\tby smtp1.ntua.gr (8.15.2/8.15.2) with ESMTPSA id v8LDgB9T099474\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Thu, 21 Sep 2017 16:42:11 +0300 (EEST)\n\t(envelope-from el13635@mail.ntua.gr)"],"X-Authentication-Warning":"smtp1.ntua.gr: Host carp0.noc.ntua.gr\n\t[147.102.222.60] claimed to be mail.ntua.gr","Date":"Thu, 21 Sep 2017 16:42:11 +0300","From":"Manos Pitsidianakis ","To":"Fam Zheng ","Message-ID":"<20170921134211.ilym353a3pmeilc4@postretch>","Mail-Followup-To":"Manos Pitsidianakis ,\n\tFam Zheng , qemu-devel ,\n\tKevin Wolf ,\n\tStefan Hajnoczi ,\n\tqemu-block , Max Reitz ","References":"<20170921131707.17364-1-el13635@mail.ntua.gr>\n\t<20170921133535.GI13703@lemon.lan>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"6qmngimrenc2lk6v\"","Content-Disposition":"inline","In-Reply-To":"<20170921133535.GI13703@lemon.lan>","User-Agent":"NeoMutt/20170609-57-1e93be (1.8.3)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:648:2000:de::183","Subject":"Re: [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end\n\tBlockDriver callbacks","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , qemu-block ,\n\tqemu-devel ,\n\tStefan Hajnoczi , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]