[{"id":1783996,"web_url":"http://patchwork.ozlabs.org/comment/1783996/","msgid":"","list_archive_url":null,"date":"2017-10-10T18:00:41","subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","submitter":{"id":19886,"url":"http://patchwork.ozlabs.org/api/people/19886/","name":"Matthias Brugger","email":"matthias.bgg@gmail.com"},"content":"On 09/21/2017 10:26 AM, sean.wang@mediatek.com wrote:\n> From: Sean Wang \n> \n> pwrap initialization is highly associated with the base SoC, so\n> update here for allowing pwrap_init without slave program which would be\n> used to those PMICs without extra encryption on bus such as MT6380.\n> \n> Signed-off-by: Chenglin Xu \n> Signed-off-by: Chen Zhong \n> Signed-off-by: Sean Wang \n> ---\n> drivers/soc/mediatek/mtk-pmic-wrap.c | 91 +++++++++++++++++++++---------------\n> 1 file changed, 54 insertions(+), 37 deletions(-)\n> \n> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c\n> index 27d7ccc..9c6d855 100644\n> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c\n> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c\n> @@ -531,6 +531,7 @@ struct pmic_wrapper_type {\n> \tu32 spi_w;\n> \tu32 wdt_src;\n> \tint has_bridge:1;\n> +\tint slv_program:1;\n> \tint (*init_reg_clock)(struct pmic_wrapper *wrp);\n> \tint (*init_soc_specific)(struct pmic_wrapper *wrp);\n> };\n> @@ -999,9 +1000,12 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n> \t}\n> \n> \t/* Reset SPI slave */\n> -\tret = pwrap_reset_spislave(wrp);\n> -\tif (ret)\n> -\t\treturn ret;\n> +\n> +\tif (wrp->master->slv_program) {\n> +\t\tret = pwrap_reset_spislave(wrp);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> \n> \tpwrap_writel(wrp, 1, PWRAP_WRAP_EN);\n> \n> @@ -1013,45 +1017,52 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\t/* Setup serial input delay */\n> -\tret = pwrap_init_sidly(wrp);\n> -\tif (ret)\n> -\t\treturn ret;\n> +\tif (wrp->master->slv_program) {\n\nThis if branch is really long and complex enough to put it into function apart.\n\nThanks,\nMatthias\n\nPD please take into account the comments I made on v3 of the series.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"mR/xq6ay\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AuPN2s55\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBQ0L5Mnhz9t5R\n\tfor ;\n\tWed, 11 Oct 2017 05:01:20 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1yqB-0003Hu-0I; Tue, 10 Oct 2017 18:01:15 +0000","from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1yq3-0003BA-OA; Tue, 10 Oct 2017 18:01:10 +0000","by mail-pf0-x244.google.com with SMTP id b85so17012883pfj.1;\n\tTue, 10 Oct 2017 11:00:47 -0700 (PDT)","from ziggy.stardust (123.154.133.37.dynamic.jazztel.es.\n\t[37.133.154.123]) by smtp.gmail.com with ESMTPSA id\n\tr79sm19813350pfa.179.2017.10.10.11.00.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 10 Oct 2017 11:00:46 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=nRyBf7wDSjErJBAIQaNWBj/jaf9y5904r65tpEfZSCA=;\n\tb=mR/xq6ayBZovgyW3Duzm34apJ\n\tYX0k2n0nUABENPFRSIC+dhHJYgmHHX3XUZRgH6XGUN99uK4y4TZD5Sk7adb/O7XlPRuPRpG3M3csf\n\tDNOJAcmBXG6uANmT26TBRUIHw8wniA7ctxoRTJxn4q/VHAGdtj7RrIQpFBDTBgmNMNCZRx8Dhr3b8\n\tpBHg0TSTYQI6Oh9dAIzbH0iMAYuGqWDBNUxNJOvF1N0vd6EHiNUg2xc4yGv3eG7/lALhcEUoBCC+9\n\typPppd0GAPIaE0Oh3+Y8ntfUbvWLLQqOrTML1faC2OwPdZUc0NySSnIVocIN7KT23VEyAowYZ6kqk\n\tqFAADVeaQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=IEBnzyiFKZbIX8Udmdd2tqNnzhOZiTNehqONBY3ocIg=;\n\tb=AuPN2s55Wjxga1kGDV5mZq3qvgZDjR5w5IXlXZBuUVTTdakBRWUCt2a5/LygVFFYS2\n\tOJ4402GgDDK7qDIQqyai/ZqTBY+68+DfdM9alidIqjmZCeW3f4HnSUl/St2qElzpbleB\n\tHM4G40Hjd/fppDLWotF5ZjvUKkgBbDxmOGGF2TnZHxw3GrPCYVT+19jmNE7DwvT1PibI\n\tRXAm22aKaGvcr/5PaZO5BUD4Pzhsd3Ta6cKWF8msAyEEnXiyOULbaosXs/OwZYknpE9+\n\tPPDG0yy++ymIWqie95NgUZlhVkxepdeI0FCiXvdKjtK09gR9ePet75snq1G+L3XxDjqe\n\tXGnQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=IEBnzyiFKZbIX8Udmdd2tqNnzhOZiTNehqONBY3ocIg=;\n\tb=I+aJgoKCouTMScqcNSMaLsczhE8fRUm9bHlgPnIxdv1Y/z96Ik30uB72L7OUYAynBs\n\tm3pW2Ik9w+cmxNF7nYcOpSXZa65ZR9Pdyp7JLZY/edLNhqlvs/IiwuKah56JnyS+AxnD\n\t5zdOuBRh2AlWD99X8Ztgc7Rn4J5Qk21MMyQxwNPKT0oaiUhQsa37sQZ5AMZs4g/Rywvz\n\t5mrcyD4y7VQ2nlNgOTxAFVF5GLpJ9hVaKHyolw/j4Bx+Hj5Il373seS2ypKK06Kcqvvm\n\tHneUEAEMDlwvBqWVVcyE0zpTi6B28JCA42luwFctiVfCHBYdYzuY79cxnzIYZuREq+Hc\n\tXTlA==","X-Gm-Message-State":"AMCzsaXgY6dDyjNtEz0pXykLoNMp9uIQ7ybACNOKxjBigHgIXuS5O6ic\n\tr9TDnJqWLXjYY3bmfUYwdQXu83gm","X-Google-Smtp-Source":"AOwi7QA0HkRORjpwiHB4OqC9U2ExUpxXl8Esvrl2VTSgQxCqg5O6CK03UJJqhV6UAP1ZvQ637gLCiA==","X-Received":"by 10.101.81.197 with SMTP id i5mr13187697pgq.374.1507658446921; \n\tTue, 10 Oct 2017 11:00:46 -0700 (PDT)","Subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","To":"sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, linux-mediatek@lists.infradead.org","References":"\n\t<604078485ca9ab04cea5bc531425d6035b27bc88.1505980364.git.sean.wang@mediatek.com>","From":"Matthias Brugger ","Message-ID":"","Date":"Tue, 10 Oct 2017 20:00:41 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<604078485ca9ab04cea5bc531425d6035b27bc88.1505980364.git.sean.wang@mediatek.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171010_110107_954438_B6C34F39 ","X-CRM114-Status":"GOOD ( 17.67 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (matthias.bgg[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"chenglin.xu@mediatek.com, chen.zhong@mediatek.com,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1786153,"web_url":"http://patchwork.ozlabs.org/comment/1786153/","msgid":"<1507887704.21840.32.camel@mtkswgap22>","list_archive_url":null,"date":"2017-10-13T09:41:44","subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","submitter":{"id":69660,"url":"http://patchwork.ozlabs.org/api/people/69660/","name":"Sean Wang","email":"sean.wang@mediatek.com"},"content":"On Tue, 2017-10-10 at 20:00 +0200, Matthias Brugger wrote:\n> \n> On 09/21/2017 10:26 AM, sean.wang@mediatek.com wrote:\n> > From: Sean Wang \n> > \n> > pwrap initialization is highly associated with the base SoC, so\n> > update here for allowing pwrap_init without slave program which would be\n> > used to those PMICs without extra encryption on bus such as MT6380.\n> > \n> > Signed-off-by: Chenglin Xu \n> > Signed-off-by: Chen Zhong \n> > Signed-off-by: Sean Wang \n> > ---\n> > drivers/soc/mediatek/mtk-pmic-wrap.c | 91 +++++++++++++++++++++---------------\n> > 1 file changed, 54 insertions(+), 37 deletions(-)\n> > \n> > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c\n> > index 27d7ccc..9c6d855 100644\n> > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c\n> > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c\n> > @@ -531,6 +531,7 @@ struct pmic_wrapper_type {\n> > \tu32 spi_w;\n> > \tu32 wdt_src;\n> > \tint has_bridge:1;\n> > +\tint slv_program:1;\n> > \tint (*init_reg_clock)(struct pmic_wrapper *wrp);\n> > \tint (*init_soc_specific)(struct pmic_wrapper *wrp);\n> > };\n> > @@ -999,9 +1000,12 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n> > \t}\n> > \n> > \t/* Reset SPI slave */\n> > -\tret = pwrap_reset_spislave(wrp);\n> > -\tif (ret)\n> > -\t\treturn ret;\n> > +\n> > +\tif (wrp->master->slv_program) {\n> > +\t\tret = pwrap_reset_spislave(wrp);\n> > +\t\tif (ret)\n> > +\t\t\treturn ret;\n> > +\t}\n> > \n> > \tpwrap_writel(wrp, 1, PWRAP_WRAP_EN);\n> > \n> > @@ -1013,45 +1017,52 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n> > \tif (ret)\n> > \t\treturn ret;\n> > \n> > -\t/* Setup serial input delay */\n> > -\tret = pwrap_init_sidly(wrp);\n> > -\tif (ret)\n> > -\t\treturn ret;\n> > +\tif (wrp->master->slv_program) {\n> \n> This if branch is really long and complex enough to put it into function apart.\n> \n> Thanks,\n> Matthias\n> \n> PD please take into account the comments I made on v3 of the series.\n> \n\nI'll try to breakdown the long logic into the short one and use a flag\nindicating the slave capability decides whether the functions is\nrequired being enabled for the slave instead of slv_program which is\nless meaningful. In this way, pmic_init will be more extensible when\nmore different SoCs and target slaves with various flavors into the\ndriver. And also take into accounts those suggestions you made in v3 in\nthe next version.\n\n\tSean","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"ZtxB10Ul\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yD2vx21C0z9t1G\n\tfor ;\n\tFri, 13 Oct 2017 20:48:13 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2wZd-0006C6-0E; Fri, 13 Oct 2017 09:48:09 +0000","from [218.249.47.110] (helo=mailgw01.mediatek.com)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2wZK-0005sa-8C; Fri, 13 Oct 2017 09:47:53 +0000","from mtkcas34.mediatek.inc [(172.27.4.250)] by\n\tmailgw01.mediatek.com (envelope-from )\n\t(mailgw01.mediatek.com ESMTP with TLS)\n\twith ESMTP id 1045029300; Fri, 13 Oct 2017 17:41:46 +0800","from mtkcas07.mediatek.inc (172.21.101.84) by\n\tMTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Fri, 13 Oct 2017 17:41:44 +0800","from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Fri, 13 Oct 2017 17:41:44 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=jy6Z+kHvbhrlO6k/vwW3Ma8WMFMeIGZsGTqCePR64Fo=;\n\tb=ZtxB10UlOBww9s\n\tUxOE3d20qmYkSX16xDG2+q0ZRx1fh2hmBxIDUsFo2fsN1CUSmt3h6KCv0Q28F89ai7xgudvRnX9LJ\n\t6qXmzzE7Rzxs2asCx8IM3KNLXAWXYFgAv597REafrCpo+BDJX736RZ7ftraqI9MHF7OPZy/pe1POI\n\twiEqbkVGV3kcHCfd11ihRDXXzrA/yWRTcy27U/SSjvwGZm3wPGGOLoO5cnpBDCgNqZSzrj/WbuHUr\n\t5A34mPQVSD38lExJYcyzFu0XkhpxAvWGlJh0Frh5MaB1IIqxUi6oK2aooX1kQBAhSSi4GbH7UbO+k\n\tWfje/YVSkn8Yc/hlDbwQ==;","X-UUID":"c0e4b9e8688042c7a0b5f4db39b832dc-20171013","Message-ID":"<1507887704.21840.32.camel@mtkswgap22>","Subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","From":"Sean Wang ","To":"Matthias Brugger ","Date":"Fri, 13 Oct 2017 17:41:44 +0800","In-Reply-To":"","References":"\n\t<604078485ca9ab04cea5bc531425d6035b27bc88.1505980364.git.sean.wang@mediatek.com>\n\t","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171013_024750_835562_E23F1A83 ","X-CRM114-Status":"GOOD ( 17.90 )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.1 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org,\n\tchenglin.xu@mediatek.com, \n\tlinux-kernel@vger.kernel.org, robh+dt@kernel.org,\n\tlinux-mediatek@lists.infradead.org, chen.zhong@mediatek.com,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1786311,"web_url":"http://patchwork.ozlabs.org/comment/1786311/","msgid":"","list_archive_url":null,"date":"2017-10-13T14:07:57","subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","submitter":{"id":19886,"url":"http://patchwork.ozlabs.org/api/people/19886/","name":"Matthias Brugger","email":"matthias.bgg@gmail.com"},"content":"On 10/13/2017 11:41 AM, Sean Wang wrote:\n> On Tue, 2017-10-10 at 20:00 +0200, Matthias Brugger wrote:\n>>\n>> On 09/21/2017 10:26 AM, sean.wang@mediatek.com wrote:\n>>> From: Sean Wang \n>>>\n>>> pwrap initialization is highly associated with the base SoC, so\n>>> update here for allowing pwrap_init without slave program which would be\n>>> used to those PMICs without extra encryption on bus such as MT6380.\n>>>\n>>> Signed-off-by: Chenglin Xu \n>>> Signed-off-by: Chen Zhong \n>>> Signed-off-by: Sean Wang \n>>> ---\n>>> drivers/soc/mediatek/mtk-pmic-wrap.c | 91 +++++++++++++++++++++---------------\n>>> 1 file changed, 54 insertions(+), 37 deletions(-)\n>>>\n>>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c\n>>> index 27d7ccc..9c6d855 100644\n>>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c\n>>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c\n>>> @@ -531,6 +531,7 @@ struct pmic_wrapper_type {\n>>> \tu32 spi_w;\n>>> \tu32 wdt_src;\n>>> \tint has_bridge:1;\n>>> +\tint slv_program:1;\n>>> \tint (*init_reg_clock)(struct pmic_wrapper *wrp);\n>>> \tint (*init_soc_specific)(struct pmic_wrapper *wrp);\n>>> };\n>>> @@ -999,9 +1000,12 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n>>> \t}\n>>> \n>>> \t/* Reset SPI slave */\n>>> -\tret = pwrap_reset_spislave(wrp);\n>>> -\tif (ret)\n>>> -\t\treturn ret;\n>>> +\n>>> +\tif (wrp->master->slv_program) {\n>>> +\t\tret = pwrap_reset_spislave(wrp);\n>>> +\t\tif (ret)\n>>> +\t\t\treturn ret;\n>>> +\t}\n>>> \n>>> \tpwrap_writel(wrp, 1, PWRAP_WRAP_EN);\n>>> \n>>> @@ -1013,45 +1017,52 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n>>> \tif (ret)\n>>> \t\treturn ret;\n>>> \n>>> -\t/* Setup serial input delay */\n>>> -\tret = pwrap_init_sidly(wrp);\n>>> -\tif (ret)\n>>> -\t\treturn ret;\n>>> +\tif (wrp->master->slv_program) {\n>>\n>> This if branch is really long and complex enough to put it into function apart.\n>>\n>> Thanks,\n>> Matthias\n>>\n>> PD please take into account the comments I made on v3 of the series.\n>>\n> \n> I'll try to breakdown the long logic into the short one and use a flag\n> indicating the slave capability decides whether the functions is\n> required being enabled for the slave instead of slv_program which is\n> less meaningful. In this way, pmic_init will be more extensible when\n> more different SoCs and target slaves with various flavors into the\n> driver. And also take into accounts those suggestions you made in v3 in\n> the next version.\n> \n> \tSean\n> \n\nI totally agree, but I wanted to underline that right now the if branch under\n\"if (wrp->master->slv_program)\" is around 30 lines, so I think it would be a \ngood candidate to put it into it's own function. For example: \npwrap_init_encryption()\nAs from what I understand from the commit log, slv_program in the end enables \nencryption of the communication, right?\n\nRegards,\nMatthias","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"gJBkM8Vw\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Kd2kKgih\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yD8hD2lglz9sP1\n\tfor ;\n\tSat, 14 Oct 2017 01:08:28 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e30dV-0000Ei-6I; Fri, 13 Oct 2017 14:08:25 +0000","from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e30dR-0008Up-J9; Fri, 13 Oct 2017 14:08:24 +0000","by mail-pf0-x244.google.com with SMTP id t188so7878819pfd.10;\n\tFri, 13 Oct 2017 07:08:01 -0700 (PDT)","from ziggy.stardust (123.154.133.37.dynamic.jazztel.es.\n\t[37.133.154.123]) by smtp.gmail.com with ESMTPSA id\n\ts86sm2897291pfi.74.2017.10.13.07.07.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 13 Oct 2017 07:08:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=Cdjt85SzxHd1lGToWucEiOJLjFnWIPcIRKUpIFEBrtg=;\n\tb=gJBkM8VwLoXxiI5VLxG0+2MQN\n\t2mYgLKh2DvWz2qweSzAIpHI5bP0hipyUHPADgRDNFEK0NYmX3M8K5cM2oycnRlEl98NTOJv0h3DOK\n\t6w+1pqacSYjwAn/wDPVywFKzcJno+SsWtAJNMNJ5hn7FxlzZ+ukAUt/LUmz2rVVLcYHJY2pQomOjs\n\tJ0kdlv/W7uCqr53d6VGbWdprkeyMuddNXNWcQfbfQoI7RNjy+pxRVnHPAsHC+36zZNBapNzCfWpdn\n\tosRc1dM+g4PVb0OTnEUWpR9N7Cdar2PDONgD9pXvPrfbn/sLjceHs6X3uZOGEGRZJTlfRnBuxh9O7\n\tEO5UQhhPQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=qIh/LPVJjPPDWBc8jeL8bxMMtlz2entQ+PC6qPPlr+o=;\n\tb=Kd2kKgihgo/UDr/p3cQGJB2HRmezPQ30UWc8L1fm8vJyH3pOgl1WZoKlENRG/zTlo4\n\tZxSmG3KlhbEh/eEUUXrqHcYuEg6GqVKYy/G2Ky1YlvymHs/Qg/u80kdyoDv/ODl5XxPn\n\tsnAyNCLANv6jbgq6T6B8IKDZrVbDnfIrXTgRrbopRhHdZpLijlc179SBiKw19M2X/5jm\n\td24ajavU44/7RnxVlADAe9xDAax5y3V9VYrdbSbGqcGSALB/sRGsg0znoSK77xSB5uE0\n\ti3OBjX9gj8+qaWRumfQJ9AiytYLf/HyPKIw5Yf9FPHRTvDqQg+bwJBR9J53eow+3xylO\n\tCe9w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=qIh/LPVJjPPDWBc8jeL8bxMMtlz2entQ+PC6qPPlr+o=;\n\tb=aRh5sqyJdF2tJMZZjldt8w/iNe/WOZkHFmvJ1LYmU1eoPOLvIS1EfLF9Ogdq7lGWrW\n\t/J4TCtEPohL6qc/Qzf90sIwVE6rb4YSUv2GnPvYLJb7LPWJBvGsh6Mek6k029poI0JTF\n\t2LARZMa20gkNpPAlPSVX2eLYl9+HzSORookLDggJ3UjxlX1PgRc/n6zupzxAUOoP2lsE\n\tZKgivmSJc1Qo5Hq9N8mGKVzWmDn0hC29+a8Yswvkx6OUUI4QGMMLhKy+WPsm6Op9ceWh\n\tgDN6HqJoeUiT93jWNN5krthwi2+nzwMX7KVCiGWS6tJ/3OuR8RMsv2Ccy006kZQEqErg\n\tCeWg==","X-Gm-Message-State":"AMCzsaVJXZYW5hxVyGNP4MLvnkVtTm8oj8w3HLzuWfdr/RCU507F7/X8\n\tHiszBgR7T9d8GT+LRVkADNvm1+y7","X-Google-Smtp-Source":"AOwi7QAq6a/dfJKcKV1jXNw8gQCm7CoEdAgqwMmIUd3hlRTHqEqSlbKaxHI57IlKbAaXF4ELO0unUg==","X-Received":"by 10.98.160.90 with SMTP id r87mr1524909pfe.324.1507903681052; \n\tFri, 13 Oct 2017 07:08:01 -0700 (PDT)","Subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","To":"Sean Wang ","References":"\n\t<604078485ca9ab04cea5bc531425d6035b27bc88.1505980364.git.sean.wang@mediatek.com>\n\t\n\t<1507887704.21840.32.camel@mtkswgap22>","From":"Matthias Brugger ","Message-ID":"","Date":"Fri, 13 Oct 2017 16:07:57 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<1507887704.21840.32.camel@mtkswgap22>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171013_070821_697148_86327F7E ","X-CRM114-Status":"GOOD ( 21.86 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (matthias.bgg[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org,\n\tchenglin.xu@mediatek.com, \n\tlinux-kernel@vger.kernel.org, robh+dt@kernel.org,\n\tlinux-mediatek@lists.infradead.org, chen.zhong@mediatek.com,\n\tlinux-arm-kernel@lists.infradead.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1787150,"web_url":"http://patchwork.ozlabs.org/comment/1787150/","msgid":"<1508134939.21840.39.camel@mtkswgap22>","list_archive_url":null,"date":"2017-10-16T06:22:19","subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","submitter":{"id":69660,"url":"http://patchwork.ozlabs.org/api/people/69660/","name":"Sean Wang","email":"sean.wang@mediatek.com"},"content":"On Fri, 2017-10-13 at 16:07 +0200, Matthias Brugger wrote:\n> \n> On 10/13/2017 11:41 AM, Sean Wang wrote:\n> > On Tue, 2017-10-10 at 20:00 +0200, Matthias Brugger wrote:\n> >>\n> >> On 09/21/2017 10:26 AM, sean.wang@mediatek.com wrote:\n> >>> From: Sean Wang \n> >>>\n> >>> pwrap initialization is highly associated with the base SoC, so\n> >>> update here for allowing pwrap_init without slave program which would be\n> >>> used to those PMICs without extra encryption on bus such as MT6380.\n> >>>\n> >>> Signed-off-by: Chenglin Xu \n> >>> Signed-off-by: Chen Zhong \n> >>> Signed-off-by: Sean Wang \n> >>> ---\n> >>> drivers/soc/mediatek/mtk-pmic-wrap.c | 91 +++++++++++++++++++++---------------\n> >>> 1 file changed, 54 insertions(+), 37 deletions(-)\n> >>>\n> >>> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c\n> >>> index 27d7ccc..9c6d855 100644\n> >>> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c\n> >>> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c\n> >>> @@ -531,6 +531,7 @@ struct pmic_wrapper_type {\n> >>> \tu32 spi_w;\n> >>> \tu32 wdt_src;\n> >>> \tint has_bridge:1;\n> >>> +\tint slv_program:1;\n> >>> \tint (*init_reg_clock)(struct pmic_wrapper *wrp);\n> >>> \tint (*init_soc_specific)(struct pmic_wrapper *wrp);\n> >>> };\n> >>> @@ -999,9 +1000,12 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n> >>> \t}\n> >>> \n> >>> \t/* Reset SPI slave */\n> >>> -\tret = pwrap_reset_spislave(wrp);\n> >>> -\tif (ret)\n> >>> -\t\treturn ret;\n> >>> +\n> >>> +\tif (wrp->master->slv_program) {\n> >>> +\t\tret = pwrap_reset_spislave(wrp);\n> >>> +\t\tif (ret)\n> >>> +\t\t\treturn ret;\n> >>> +\t}\n> >>> \n> >>> \tpwrap_writel(wrp, 1, PWRAP_WRAP_EN);\n> >>> \n> >>> @@ -1013,45 +1017,52 @@ static int pwrap_init(struct pmic_wrapper *wrp)\n> >>> \tif (ret)\n> >>> \t\treturn ret;\n> >>> \n> >>> -\t/* Setup serial input delay */\n> >>> -\tret = pwrap_init_sidly(wrp);\n> >>> -\tif (ret)\n> >>> -\t\treturn ret;\n> >>> +\tif (wrp->master->slv_program) {\n> >>\n> >> This if branch is really long and complex enough to put it into function apart.\n> >>\n> >> Thanks,\n> >> Matthias\n> >>\n> >> PD please take into account the comments I made on v3 of the series.\n> >>\n> > \n> > I'll try to breakdown the long logic into the short one and use a flag\n> > indicating the slave capability decides whether the functions is\n> > required being enabled for the slave instead of slv_program which is\n> > less meaningful. In this way, pmic_init will be more extensible when\n> > more different SoCs and target slaves with various flavors into the\n> > driver. And also take into accounts those suggestions you made in v3 in\n> > the next version.\n> > \n> > \tSean\n> > \n> \n> I totally agree, but I wanted to underline that right now the if branch under\n> \"if (wrp->master->slv_program)\" is around 30 lines, so I think it would be a \n> good candidate to put it into it's own function. For example: \n> pwrap_init_encryption()\n\nunderstood. I'll try to turn the code block into a function.\n\n> As from what I understand from the commit log, slv_program in the end enables \n> encryption of the communication, right?\n> \n\nyes. slv_program in the end will enable the security feature over the\nbus such as the encryption and the signature for the data integrity when\nthe pwrap slave can support it.\n\n\n> Regards,\n> Matthias","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"ppFYSIrr\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yFpCr3t9hz9sP1\n\tfor ;\n\tMon, 16 Oct 2017 17:23:04 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e3yni-0003tW-Jm; Mon, 16 Oct 2017 06:22:58 +0000","from [218.249.47.111] (helo=mailgw02.mediatek.com)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e3ync-0003qm-EQ; Mon, 16 Oct 2017 06:22:55 +0000","from mtkcas32.mediatek.inc [(172.27.4.250)] by\n\tmailgw02.mediatek.com (envelope-from )\n\t(mailgw01.mediatek.com ESMTP with TLS)\n\twith ESMTP id 388197727; Mon, 16 Oct 2017 14:22:21 +0800","from mtkcas09.mediatek.inc (172.21.101.178) by\n\tMTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Mon, 16 Oct 2017 14:22:20 +0800","from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Mon, 16 Oct 2017 14:22:19 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=PVFRKfNOXo6QiLSm0BIs05IbXgUlOLqWdq1at0C/Avs=;\n\tb=ppFYSIrrDRNV+c\n\t23TK955VXdKCC4dGZvIv0fpOZ4HEyTwxUqpTaLcOe3AJ7+wwc+zFg5ZKAjreiTeUQjnBVKZ0fesMp\n\tXHWTt/bumlBE3ghMpukPuGq0ecoz/FLhA4TagBM2tYPYd6cyoa9uY9sBvarqoWhvOkaCjJdlCOjyT\n\tuN5zF3SgLOBL0QZflSvHlxT67kME2gF2H/LoK+JGATiPhYGt2XZaztI88tg0dkNk4LOyQijVZP6vB\n\tULxab7JnX+2IquroP6NarC9P7Z9GQNUarhHJWAZ8LfPIw/OJI4gjtBSpYfOv3Wmu7lFD3yzYmymjE\n\tdWWL6te5dI8ENsxfOqCw==;","X-UUID":"3c4aa987d79e4abdb1efb955fbbec4f5-20171016","Message-ID":"<1508134939.21840.39.camel@mtkswgap22>","Subject":"Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without\n\tslave programming","From":"Sean Wang ","To":"Matthias Brugger ","Date":"Mon, 16 Oct 2017 14:22:19 +0800","In-Reply-To":"","References":"\n\t<604078485ca9ab04cea5bc531425d6035b27bc88.1505980364.git.sean.wang@mediatek.com>\n\t\n\t<1507887704.21840.32.camel@mtkswgap22>\n\t","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171015_232252_881621_70F2F69E ","X-CRM114-Status":"GOOD ( 25.86 )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.1 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org,\n\tchenglin.xu@mediatek.com, \n\tlinux-kernel@vger.kernel.org, robh+dt@kernel.org,\n\tlinux-mediatek@lists.infradead.org, chen.zhong@mediatek.com,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]