[{"id":1772747,"web_url":"http://patchwork.ozlabs.org/comment/1772747/","msgid":"","list_archive_url":null,"date":"2017-09-21T12:05:13","subject":"Re: [Qemu-devel] [PATCH v2 0/4] chardev: support non-default\n\tgcontext","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Thu, Sep 21, 2017 at 8:35 AM, Peter Xu wrote:\n> The old chardev may not fully support non-default GMainContext. One\n> direct clue is that when we call io_add_watch_poll() sometimes we are\n> still passing in the NULL context pointer.\n>\n> IIUC we are fine during setup since the context will be passed\n> correctly during setup via chr_update_read_handler(). However it\n> won't survive if chardev reconnected due to some reason.\n>\n> This series tries to solve above problem by caching the gcontext\n> pointer in Chardev itself.\n>\n> This will be required for the monitor OOB (out-of-band) support, since\n> in that series monitor backends may be run in non-default contexts.\n>\n> Please review. Thanks.\n>\n> Peter Xu (4):\n> chardev: new qemu_chr_be_update_read_handlers()\n> chardev: add Chardev.gcontext field\n> chardev: use per-dev context for io_add_watch_poll\n> chardev: remove context in chr_update_read_handler\n>\n> chardev/char-fd.c | 5 ++---\n> chardev/char-fe.c | 7 ++-----\n> chardev/char-pty.c | 5 ++---\n> chardev/char-socket.c | 7 +++----\n> chardev/char-udp.c | 5 ++---\n> chardev/char.c | 11 +++++++++++\n> include/chardev/char.h | 13 ++++++++++++-\n> 7 files changed, 34 insertions(+), 19 deletions(-)\n\nIt's only for the read handler, perhaps the gcontext field should be\nnamed \"read_context\" or adding a comment to explain this is only used\nfor that.\n\nOtherwise, looks good:\nReviewed-by: Marc-André Lureau ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sMErSsMk\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyb146Cxqz9t42\n\tfor ;\n\tThu, 21 Sep 2017 22:06:00 +1000 (AEST)","from localhost ([::1]:53369 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dv0Ew-0000lo-VT\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 08:05:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38427)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dv0EG-0000gC-KH\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:05:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dv0EF-0007Yu-KZ\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:05:16 -0400","from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:34765)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dv0EF-0007Yq-GF\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:05:15 -0400","by mail-qk0-x243.google.com with SMTP id d70so3476023qkc.1\n\tfor ; Thu, 21 Sep 2017 05:05:15 -0700 (PDT)","by 10.12.139.78 with HTTP; Thu, 21 Sep 2017 05:05:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=9V5+nNw4AYuljuP2bDY2prZ/tToVGAoU+sFntOmkDvM=;\n\tb=sMErSsMk24wG4VHumYAO5OxZcdo5vfodSJNKWfNRIbLw0yYHk8aUSnOiRfPrxc2BFe\n\t5PSZ+bPipTupttkH6dHhG6hptJ1wVgJMcYymhZBn20F0xOdqwu+jBEdFBB5QNVebzr80\n\tNyyz/sQHIgCjU7k3YbTYPOqFiLJebJ4Z5ln+1cUFBMSk3vgXrR7GreQz3/3LE7ySPt+9\n\tGdldKE8OXUdTtf6+cF+V8W4yYXtukjVhhRCMr2Sbze+HFFQl9KH6dn5cqR2DUoqjy9cA\n\tG4PF4JRhePTowm1pIklZ9/+86FBehVUC8tVGnb4giZyEqm0UOCsFi+7TRkrJLzaES6Fl\n\t0yoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=9V5+nNw4AYuljuP2bDY2prZ/tToVGAoU+sFntOmkDvM=;\n\tb=X+udqPEuJqnFpNsZyIm9vf7cjuF7RGU8IaTci/Csyx7+IYpGrkjV5w3j6sM/1pExWs\n\tG/OZFTpmQ1fyIa/wVQExkhoLecNbr3uREVCG6vJQO3Q5JoI2ljJ31Ho1EtK6Vu0xVQbw\n\t+bK5cUuHNPv43KXRxWCauADTVolo8Evd9DqJ10ap79GuneI1XYR/xqU4aI6hHoEcgOdT\n\teGyT6Cp6iEczuNnzxJ9oQREQch6AGSqRxcNVn9Z60Fhh+v2zCz8PYX2nl7GsySHNK7uj\n\tJ7lXOyD9DQt/Jb0EGsZYV19a853ornIyBdUMRo4Aa7qphP+KAZcNiSsAs4Zk8mSsqT5E\n\teqzg==","X-Gm-Message-State":"AHPjjUgRnhuwZTrbq5MTR+4noMq9Zi6HyAVukHKltbikkIFjjBQlAUAk\n\twt3rvIT1tEltxVyS5uAni2yMMW8gakafBQuohr0=","X-Google-Smtp-Source":"AOwi7QB3nWAbOtygJn6YkCTvAs1n1mgzT9uO+/4TX+k53B8S9xgPUo4hbFX9ly3U2QsJe9jKNz+dm2fdtGwJtnQ501k=","X-Received":"by 10.55.27.145 with SMTP id m17mr2472280qkh.243.1505995514888; \n\tThu, 21 Sep 2017 05:05:14 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505975754-21555-1-git-send-email-peterx@redhat.com>","References":"<1505975754-21555-1-git-send-email-peterx@redhat.com>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 21 Sep 2017 14:05:13 +0200","Message-ID":"","To":"Peter Xu ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::243","Subject":"Re: [Qemu-devel] [PATCH v2 0/4] chardev: support non-default\n\tgcontext","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , QEMU ,\n\t\"Dr . David Alan Gilbert\" ,\n\tJuan Quintela ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]