[{"id":1772506,"web_url":"http://patchwork.ozlabs.org/comment/1772506/","msgid":"","list_archive_url":null,"date":"2017-09-21T07:50:14","subject":"Re: [PATCH 2/2] uio: add default compatible string to\n\tuio_pdrv_genirq","submitter":{"id":4675,"url":"http://patchwork.ozlabs.org/api/people/4675/","name":"Andy Shevchenko","email":"andy.shevchenko@gmail.com"},"content":"On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham\n wrote:\n\n\n> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);\n> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);\n\n0 -> 0000 looks like bogus checkpatch warning.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DMy9XRLZ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyTL152jHz9t3F\n\tfor ;\n\tThu, 21 Sep 2017 17:50:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751837AbdIUHuQ (ORCPT\n\t);\n\tThu, 21 Sep 2017 03:50:16 -0400","from mail-qt0-f174.google.com ([209.85.216.174]:54090 \"EHLO\n\tmail-qt0-f174.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751588AbdIUHuP (ORCPT\n\t); Thu, 21 Sep 2017 03:50:15 -0400","by mail-qt0-f174.google.com with SMTP id 47so5107003qts.10;\n\tThu, 21 Sep 2017 00:50:15 -0700 (PDT)","by 10.12.134.221 with HTTP; Thu, 21 Sep 2017 00:50:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=jNEzaUtXgofO1kT2bF+YNO3f/pBphfCtrXzdJCLE/qE=;\n\tb=DMy9XRLZOZULVyHBFsS58GxZ11S1hkwasg2ajnXJw2p1YfdnFLT8r6kEHlDRWuJLH2\n\tg9P4M32Z8z45PeXP6hnDMGue28GiH3LZ5atRAdpJP2J2lJSS0L3VqOAas4LVcIMbC0MC\n\tv+nX9ncp/+bdq+DiXhW/90egE3c08iLmkDhI9tx5QmPh3HcQjJi2h6vnB7toJCAcQzmn\n\tHTKi1HGnpX5nJZHNQsvFBDp3Od0SGvymV//YRpvjo6U9Z1ViivRboPoRgRUllEPfEhmU\n\tu53bBJixISwi6dBLujugB1olVhh3sLuPkBdklJ31QRSqKcyklqmdIdd8Cj5WjOLdn8Rg\n\tzmVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=jNEzaUtXgofO1kT2bF+YNO3f/pBphfCtrXzdJCLE/qE=;\n\tb=tilAa18YM7O2zUvinoqeJf66mSH7ychZc+FdfYagShXM/i97Ne+HWYH5xVfjU/E9+N\n\tyibFtnNx9DlL1duTi+BRoWAIOpCtlNq9w8dNBMplrdtkzJHY0/4Q6MmhKX6MYRBwxcsZ\n\tqaYxb44oDIi6C0AtFLrvl8l+57FfCnnlT8g4hxEnTs4zkqQM1QID4NlhikT4TXRPFTyI\n\tNLFqQQUwgQeTLObFdz31Y+FkaMGfk4fHRFiyHRlIpMFZz8QRV+0t7u/m4MO8JS/chQpd\n\toIDlRfN+l0z3qxeDhYtXyGpYW11aN0DWAGCGuKcwM8L5HZmfFdv9FWUDOa20s/zrw65q\n\tlkWQ==","X-Gm-Message-State":"AHPjjUiFBrOHtkYeGXUjFlVv1FI32JzTJBtoGablnR0HtUHVu0bsept3\n\tn/xXkw4sMAg04+v9yoz42Uy0EiH4H0uJsmU9gSfZag==","X-Google-Smtp-Source":"AOwi7QCDuCJbnLjjR8UQTl6OGFvyCVzWWwpYIJGOymnibOFUdZmmJ8nWQHteKyLlG+JQwmZR/lej3KtJ6EJQZuWU2PQ=","X-Received":"by 10.200.54.163 with SMTP id a32mr1844239qtc.190.1505980214773; \n\tThu, 21 Sep 2017 00:50:14 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170921005326.30490-3-chris.packham@alliedtelesis.co.nz>","References":"<20170921005326.30490-1-chris.packham@alliedtelesis.co.nz>\n\t<20170921005326.30490-3-chris.packham@alliedtelesis.co.nz>","From":"Andy Shevchenko ","Date":"Thu, 21 Sep 2017 10:50:14 +0300","Message-ID":"","Subject":"Re: [PATCH 2/2] uio: add default compatible string to\n\tuio_pdrv_genirq","To":"Chris Packham ","Cc":"Rob Herring , Mark Rutland ,\n\tGreg Kroah-Hartman ,\n\tdevicetree ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772945,"web_url":"http://patchwork.ozlabs.org/comment/1772945/","msgid":"<30b8acb9d0d945a0b20991430a3275f1@svr-chch-ex1.atlnz.lc>","list_archive_url":null,"date":"2017-09-21T15:44:04","subject":"Re: [PATCH 2/2] uio: add default compatible string to\n\tuio_pdrv_genirq","submitter":{"id":27499,"url":"http://patchwork.ozlabs.org/api/people/27499/","name":"Chris Packham","email":"chris.packham@alliedtelesis.co.nz"},"content":"On 21/09/17 19:50, Andy Shevchenko wrote:\n> On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham\n> wrote:\n> \n> \n>> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);\n>> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);\n> \n> 0 -> 0000 looks like bogus checkpatch warning.\n> \n\nYes. I changed it to satisfy checkpatch. I initially wasn't going to but \nthen I noticed plenty of 0000 attached to module_params. I'll switch it \nback in v2.\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=alliedtelesis.co.nz\n\theader.i=@alliedtelesis.co.nz\n\theader.b=\"aLz0IvYs\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xygrp2TBhz9t4B\n\tfor ;\n\tFri, 22 Sep 2017 01:44:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751598AbdIUPoI (ORCPT\n\t);\n\tThu, 21 Sep 2017 11:44:08 -0400","from gate2.alliedtelesis.co.nz ([202.36.163.20]:41727 \"EHLO\n\tgate2.alliedtelesis.co.nz\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1751602AbdIUPoI (ORCPT\n\t); Thu, 21 Sep 2017 11:44:08 -0400","from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (Client did not present a certificate)\n\tby gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id B21D58365F;\n\tFri, 22 Sep 2017 03:44:05 +1200 (NZST)","from svr-chch-ex1.atlnz.lc (Not Verified[10.32.16.77]) by\n\tmmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121)\n\tid ; Fri, 22 Sep 2017 03:44:05 +1200","from svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) by\n\tsvr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) with Microsoft SMTP\n\tServer (TLS) id 15.0.1156.6; Fri, 22 Sep 2017 03:44:05 +1200","from svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8]) by\n\tsvr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8%12]) with mapi id\n\t15.00.1156.000; Fri, 22 Sep 2017 03:44:05 +1200"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; \n\ts=mail; t=1506008645;\n\tbh=zfY+d/ueEXI1E0WYCIgCfwfbYBZeMVGk1o+UwQBug2A=;\n\th=From:To:CC:Subject:Date:References;\n\tb=aLz0IvYsXex+5t4PvF4jD5Q4tdeomGSfu17XU+vv3tDJzfUaUnq2+oCVeA07Gi7J2\n\tC/qPbN2Cy5c9M+S3WY4xY7tNfqP8Y9AFLbdKWyEuIU6KZxrs+9mPe5/muDlZOKsR+v\n\tP/ODS1OvIxSrZJZoHc2N8EWK7w9bZ75aZa9NVCjg=","From":"Chris Packham ","To":"Andy Shevchenko ","CC":"Rob Herring , Mark Rutland ,\n\tGreg Kroah-Hartman ,\n\tdevicetree ,\n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [PATCH 2/2] uio: add default compatible string to\n\tuio_pdrv_genirq","Thread-Topic":"[PATCH 2/2] uio: add default compatible string to\n\tuio_pdrv_genirq","Thread-Index":"AQHTMnQKMlM1JToGikKNUHhLqbrQbg==","Date":"Thu, 21 Sep 2017 15:44:04 +0000","Message-ID":"<30b8acb9d0d945a0b20991430a3275f1@svr-chch-ex1.atlnz.lc>","References":"<20170921005326.30490-1-chris.packham@alliedtelesis.co.nz>\n\t<20170921005326.30490-3-chris.packham@alliedtelesis.co.nz>\n\t","Accept-Language":"en-NZ, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[10.32.1.10]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]