[{"id":1782354,"web_url":"http://patchwork.ozlabs.org/comment/1782354/","msgid":"<20171008222029.GA29979@toto>","list_archive_url":null,"date":"2017-10-08T22:20:29","subject":"Re: [Qemu-devel] [PATCH v3 0/8]  Add the ZynqMP PMU and IPI","submitter":{"id":24734,"url":"http://patchwork.ozlabs.org/api/people/24734/","name":"Edgar E. Iglesias","email":"edgar.iglesias@xilinx.com"},"content":"On Wed, Sep 20, 2017 at 03:01:31PM -0700, Alistair Francis wrote:\n> \n> This series adds the ZynqMP Power Management Unit (PMU) machine with basic\n> functionality.\n> \n> The machine only has the\n>  - CPU\n>  - Memory\n>  - Interrupt controller\n>  - IPI device\n> \n> connected, but that is enough to run some of the ROM and firmware\n> code on the machine\n> \n> The series also adds the IPI device and connects it to the ZynqMP ARM\n> side and the ZynqMP PMU. These IPI devices don't connect between the ARM\n> and MicroBlaze instances though.\n> \n> v3:\n>  - Add the interrupt controller\n>  - Replace some of the error_fatals with errp\n>  - Fix the PMU CPU name\n\nHi Alistair,\n\n\nSorry for the super long delay...\n\nI think this mostly looks good but I was wondering if we really need\nto have a board specific (zcu102) PMU?\n\nBest regards,\nEdgar\n\n\n\n> \n> \n> \n> Alistair Francis (8):\n>   xlnx-zynqmp-pmu: Initial commit of the ZynqMP PMU\n>   xlnx-zynqmp-pmu: Add the CPU and memory\n>   aarch64-softmmu.mak: Use an ARM specific config\n>   xlnx-pmu-iomod-intc: Add the PMU Interrupt controller\n>   xlnx-zynqmp-pmu: Connect the PMU interrupt controller\n>   xlnx-zynqmp-ipi: Initial version of the Xilinx IPI device\n>   xlnx-zynqmp-pmu: Connect the IPI device to the PMU\n>   xlnx-zynqmp: Connect the IPI device to the ZynqMP SoC\n> \n>  default-configs/aarch64-softmmu.mak    |   1 +\n>  default-configs/microblaze-softmmu.mak |   1 +\n>  hw/arm/Makefile.objs                   |   2 +-\n>  hw/arm/xlnx-zynqmp.c                   |  14 +\n>  hw/display/Makefile.objs               |   2 +-\n>  hw/dma/Makefile.objs                   |   2 +-\n>  hw/intc/Makefile.objs                  |   2 +\n>  hw/intc/xlnx-pmu-iomod-intc.c          | 554 +++++++++++++++++++++++++++++++++\n>  hw/intc/xlnx-zynqmp-ipi.c              | 377 ++++++++++++++++++++++\n>  hw/microblaze/Makefile.objs            |   1 +\n>  hw/microblaze/xlnx-zynqmp-pmu.c        | 200 ++++++++++++\n>  include/hw/arm/xlnx-zynqmp.h           |   2 +\n>  include/hw/intc/xlnx-pmu-iomod-intc.h  |  58 ++++\n>  include/hw/intc/xlnx-zynqmp-ipi.h      |  57 ++++\n>  14 files changed, 1270 insertions(+), 3 deletions(-)\n>  create mode 100644 hw/intc/xlnx-pmu-iomod-intc.c\n>  create mode 100644 hw/intc/xlnx-zynqmp-ipi.c\n>  create mode 100644 hw/microblaze/xlnx-zynqmp-pmu.c\n>  create mode 100644 include/hw/intc/xlnx-pmu-iomod-intc.h\n>  create mode 100644 include/hw/intc/xlnx-zynqmp-ipi.h\n> \n> -- \n> 2.11.0\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=xilinx.onmicrosoft.com\n\theader.i=@xilinx.onmicrosoft.com header.b=\"wUqCEf+1\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9HsN6sJPz9t3F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon,  9 Oct 2017 09:21:27 +1100 (AEDT)","from localhost ([::1]:55287 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e1Jwp-0006Ie-IM\n\tfor incoming@patchwork.ozlabs.org; Sun, 08 Oct 2017 18:21:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49442)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <edgar@xilinx.com>) id 1e1JwK-0006Gy-HZ\n\tfor qemu-devel@nongnu.org; Sun, 08 Oct 2017 18:20:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <edgar@xilinx.com>) id 1e1JwJ-00052y-JL\n\tfor qemu-devel@nongnu.org; Sun, 08 Oct 2017 18:20:52 -0400","from mail-co1nam03on0063.outbound.protection.outlook.com\n\t([104.47.40.63]:35729\n\thelo=NAM03-CO1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <edgar@xilinx.com>)\n\tid 1e1JwD-0004u2-5X; Sun, 08 Oct 2017 18:20:45 -0400","from CY4PR02CA0013.namprd02.prod.outlook.com (10.169.188.23) by\n\tMWHPR02MB3280.namprd02.prod.outlook.com (10.164.187.140) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Sun, 8 Oct 2017 22:20:41 +0000","from CY1NAM02FT050.eop-nam02.prod.protection.outlook.com\n\t(2a01:111:f400:7e45::203) by CY4PR02CA0013.outlook.office365.com\n\t(2603:10b6:903:18::23) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via\n\tFrontend Transport; Sun, 8 Oct 2017 22:20:40 +0000","from xsj-pvapsmtpgw01 (149.199.60.83) by\n\tCY1NAM02FT050.mail.protection.outlook.com (10.152.75.65) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10\n\tvia Frontend Transport; Sun, 8 Oct 2017 22:20:40 +0000","from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01)\n\tby xsj-pvapsmtpgw01 with esmtp (Exim 4.63)\n\t(envelope-from <edgar@xilinx.com>)\n\tid 1e1Jw7-0001BV-Bw; Sun, 08 Oct 2017 15:20:39 -0700","from [127.0.0.1] (helo=localhost)\n\tby xsj-pvapsmtp01 with smtp (Exim 4.63)\n\t(envelope-from <edgar@xilinx.com>)\n\tid 1e1Jw7-0002yY-8r; Sun, 08 Oct 2017 15:20:39 -0700","from xsj-pvapsmtp01 (mailman.xilinx.com [149.199.38.66])\n\tby xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id\n\tv98MKYTu007713; Sun, 8 Oct 2017 15:20:34 -0700","from [172.19.118.73] (helo=localhost)\n\tby xsj-pvapsmtp01 with esmtp (Exim 4.63)\n\t(envelope-from <edgar@xilinx.com>)\n\tid 1e1Jw0-0002xo-M0; Sun, 08 Oct 2017 15:20:33 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=xilinx.onmicrosoft.com; s=selector1-xilinx-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=FBl7E0meWmkmuNkxQOUagi86+WZ9iskTQOya/7oMhPs=;\n\tb=wUqCEf+1GHH7QNTR8RDPBZM2F5o1cuvQmtZ/1XZgD217t8u3Tg/syaJMjvvuKp7ZVxZxBYQ02sM6r3bA0+z02+MXQ6+xdea0ZhjsG3LkxWx/oqz0pEWd97Ms4Xet35yNKvZQrMdMk/HwrwRFivw+cb95slmsG4l7nFeeQGu1aXE=","Received-SPF":"Pass (protection.outlook.com: domain of xilinx.com designates\n\t149.199.60.83 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=149.199.60.83; helo=xsj-pvapsmtpgw01;","Date":"Mon, 9 Oct 2017 05:20:29 +0700","From":"\"Edgar E. Iglesias\" <edgar.iglesias@xilinx.com>","To":"Alistair Francis <alistair.francis@xilinx.com>","Message-ID":"<20171008222029.GA29979@toto>","References":"<cover.1505929556.git.alistair.francis@xilinx.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"<cover.1505929556.git.alistair.francis@xilinx.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-RCIS-Action":"ALLOW","X-TM-AS-Product-Ver":"IMSS-7.1.0.1224-8.1.0.1062-23378.005","X-TM-AS-User-Approved-Sender":"Yes;Yes","X-EOPAttributedMessage":"0","X-MS-Office365-Filtering-HT":"Tenant","X-Forefront-Antispam-Report":"CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(7916004)(346002)(376002)(2980300002)(438002)(189002)(24454002)(199003)(2906002)(305945005)(316002)(46406003)(50466002)(6666003)(1076002)(106466001)(23726003)(356003)(8676002)(6862004)(6246003)(81156014)(39060400002)(106002)(8936002)(97756001)(4326008)(77096006)(83506001)(6636002)(229853002)(478600001)(9686003)(50986999)(58126008)(5660300001)(2950100002)(54906003)(81166006)(57986006)(189998001)(9786002)(33716001)(76176999)(54356999)(16586007)(63266004)(33656002)(76506005)(47776003)(36386004)(18370500001)(107986001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR02MB3280; H:xsj-pvapsmtpgw01;\n\tFPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; MX:1; A:1; LANG:en;","X-Microsoft-Exchange-Diagnostics":["1; CY1NAM02FT050;\n\t1:qv/y5Ggnx6p0HQ3V54uBh2sYbHaqCp8v3sEFM4LnhxuaLvxMPwE04wkN+zpnXjAvjicxiAIcauUtGupOPyv4d3FtUArrANYv88Bw/NR69VlxDSdmBHtigksjjQ2jeKg9","1; MWHPR02MB3280;\n\t3:vRr5UPF9DT70VQqdraLbJAyyjn5Y4dsPmbm0wuO1psYJmH1QbJtKjFz4m7DtBF5xhA3LbsRSe1ISUU/FPMVucVYAJg0N4TH/AvDGD0O/ubS2rJFxp7wYJOmp4FevN4z7ebRBHk6/1yCA9pYpNAvpDkspOV2v6n+ESlOkC8Lav0kuE9y/LceagTekL7SLrNd83gUCt6nVe4LkOjBG9Ky/c2ZJrvNWO8PHqxacs26a1eigqhp/l35/ZhVxbUXwB2CIJ9HEK6cmRBjInWeJtjWPqdBlxcYbWmByiSXoQ9EIUCVAuxWYrq5wc7DXBa2z2ksl2aN5Prm7i1LGUm5iazB/fQ0frGAcSjHlb198Z24rtaY=;\n\t25:E++swlF63uugDTur/LzreTb0wXxez/FXcbS97NjnnZgYS6OWIJduht6+Tpp8TT6Z3nRaOvPg88arY22sI5armV07vTajJd+XebYdcWSUlzELNpdLlVOsxu9om5dE7TnLzfbwxlL4SRrl7hJdfQ6kyntT3vsIlLZsTCh4MAhkx3kULR/GFNV6CupSmSkRXPSeuAfo1JDyC2EObTH08OapARTsTlnpHy5IlsICUpyzP35HknaCJ3zvwK1LhGqYfRc+YcTdU24fRodCoui7o4/xQ3+2DtmG48fANNtnwCcwsz2uees8b+O09Y3n/UKvvtPdNbG77xt7biOeRehrJ78+5g==","1; MWHPR02MB3280;\n\t31:Dn9fMqONuD208hRuDCQ2ml7Lf+x0J9id0rzvqvySs71TTGvowcnCCmmL7O1u+XIWPgRPL0FwHKhMdw7m9117lhVFuHN3MwYfC7n7j+r/7qCixI/fUoyxezrG+d1XgFYk6qCz0pimCtslIKoeZxmGIUASgoGdSojP81qDKA4dfIJpIkoCLqHHRt6w8BEcWiydYsQa4P6uA83hMn/iMrr/+z28/eXB3Tlr2AOoT1T+WcU=;\n\t20:qP/fxkb94v2DLPWKVPjZeKz3crg+yBXBJZ2P7Z7BEkFFu5Leae3bzZkV40MD0y1uvd6x34Cuf2fxPtCIYD54zQa/Rwe8b+Jvl9QNhhb/G+znWblmZdfFUUH6g0TxVPQ0UuIaQNKRgVa0q9fe5SiWvtrSimUxJassRbmvksgYI5o69kV8YviiDpUKBynI2igHnSdv1Ap5FLT6YyE4o8J8ilfeG4wvLaugH1lC83g803JcHfdHgooKzL6Z+pMzL2k3gawBH2e8GAIilKomecps4C9sP5YFHWMb2cR1PUZsXh75x9JWip5UzFiTXKuJPbvHFkert80vZTEVwurjTRl2hTGnKLxjSLviwB62j7Qg7qybuOXrtBu8XhuUA5cXAYxJZ8rgi6B7l6RzhZ4c9Oe9d1DComctqM3wueqLu7XDj5uYwcQ3HIbozjO5wJR1rynm330+FYZWz193CF8xXI+YcoqqiwnbPZMJt7g5hdC5jB5mVpS6L4sTb1gH2bfMAv/Z","1; MWHPR02MB3280;\n\t4:vfB3NJKJ1J/+QtAwT2O76P6qD4QAwr+73wDJa1mTS9dUlJ6ezCeOxQ6b7Ysq0iTfv60c7sfpH/0Q367JaHyvTtN0qPC3PbcT6tiSdHdr4gP23pvWAmWxhIHCkzZ2F3HzNK14tOJDCjFtlpHiz1sesmJ+5fWuJYq/xwoVThnD3rV7jYeei3NnV8qekGrE5rGM1c7aGdNfeUE1/3uzUlVS0/1VxkAwMVhZZcJpPtj4NTrdimRwg7OCwNJZzjzmaFdlZUly//Lr7vyD58C8M5zdpgnoEXYSI2lF4d5p4OSEQpg+DwDW3IqKbPUjsZqVnRkFns73t4JW3kOf6qh34J72Kg==","=?us-ascii?Q?1; MWHPR02MB3280;\n\t23:EEZsIJUWGm0423K5dZWqzRlylkC+5oItUKzEm8fXI?=\n\tBvFKVDJlOsWVgZebMCCxTsf+1+3Bd+6PiItgxgo/yqKB3+1OBIicMPx+u7kf9TGM/yLyMYwLHL4zK7MY/s5Hsd+NPCMllyLxoYvjZT6vYbrGaLjNWDtNPqUE0SHfH7ZJGGLI6fz4ua3SL41L0yIyieAiFGsXlQh66bkHvU95syDhX6ulHJ0mE1ZK7hMea78jnJmKSUokxC64ttldYKmSLihGmllg5WiYUEzLEiGuB/HihLXMewukuwEkoKPqu14141XMv4ix4g+j3DAk3BO8PngCfzyG50vsrET4jSPGWJ1PYlLzB08YhTv7y8DzTalCMhJEQL+6gFQI6QB+TwxdNJCYrV7YEwxCV9GsOhKyMHodRLl8ifO1dnByRWlnhAQf2ljThW096G3pnuVcLxEvSGXV9zVq9ZhoBa53eo6eiGRKUB7Y0fH5JFJtiJBg0DiibjJDU/dcXmjlPtr3fzXJMGEuS7MQD5KkBefeR6Ye8yn09RKCX/eKnZtk8cQkBHRcbMIateKPP7eXVoDf7vDXIiutyxbd2gy7IIOiRAKb5zAA/zJexFmSgG5AWUA2BqJh8CzQONb1urqk3pza/xhhJdk8dV0e9b5C/wldwljXBfuaMJNC9O0hGvaQskYsAsAv+PyoyjCq7h/5qMmeEW7BW5q86EziI5zZLhxE+EHDJvgyzS8pGfxnJp7QSYBDHGbWP54d+dbKPo/mIIc4LWTbSw+Q1nnbtYJ+YtUV4410Ut8nTGvq+5y4p5qrhKryb66mZFodd6/q9kRqqnNcVI8IyoIYx6IL260Sege/JhqAkpBbypuCB6rs+QmeMLpm7aEf/0q+V5Uk7ebMdK06C5GKlqKje+akRofiVsd3Kddi92Cajv6wFp+A5wgvmScXm/oWZk29/O/CWBB+5fGrZEEnEa4Z5wMrWgp2VIT7wlTT08KQhZAna2MTrYGoh6TKydhZjy71fRqEAA7Vw+Dg7MvnOd56UStLSd0e6bhkfL+kL7A5WHpdOxb00B9KI+bmtbq2xDT41Il3ZlRvrIvC0dshBNQQVJxFK/IcmLV5z6pCW+9H/9NX2RKAGAWUFwn2H8ce9gKHy7VOra/a7YHIVB71mxHj/DJk+xvTv9/g7Wvzv87P/glqV5Ps7EORW3FHnG/PGS1VjjA0GPAnCH+LAj+tmDzjILeIBgFy2Cdkmp6dByhnUEcfnECZVcyfWNSaMu9vHM=","1; MWHPR02MB3280;\n\t6:hbkeCtm6HFQGVXF8o4sLW7xJ+URVybtDt200iuUZ65mBEuNcwHmnrgBoFrUW+De5Xi7RQVAPi5vXtmflWcCNovIlYZmUSwGUJzCKNqIBhEsAsI06wFAWgMINH6cLH5xtzyq6iDquML5k2dy+Tk6A3zGO3AOjkABor145Cd2qM3adXykJ+99Qy70XOVH2eLWlNQbtXcsRoG/Y8u/1yrwLZUEfH0nCPPeI8jv51d9d/1UanjqZLf9JUF0G8PDStjIKouKAhvgPk8ANuGI03jGWL5B/dregVkqzxD4GXFgUaGtzSt6ceM5eqang/SHq43jkhtsFK4L42/6sMmREk+eivQ==;\n\t5:zSUco1JIZscTNa5DBADrx9Z7YfXIey2tNd3jOUo6J/W6KdShx+Z+ct2danky9zPLMXCoHhFKm0EnWZnnYnMbvMI40jCSIyjgISjXDfkr7jnsPV+OATNusDy3ry4I8ltM/L0SV9TTHiLWg/J0ut1dLQ==;\n\t24:DAjccJdy3YZbJGxVV3L5dHBbE3KxRbC6Jl/wVPuRD+DTWaLG3lAw7DsbAx/fvBibK/edeZWDNzxieDqBnGZGK8yFfZRWym9jQmkEfeJWYGY=;\n\t7:wbt+V5gegMk9BA6AcXvjcpg3XkIY6OBoMgDdiNSeRy7fGVsFH6nmU8WOJmyev0CM/brNck31dJ89EoXO1GPyG2s+LZW8Nng3YBzvwJrG8xyV0StaZg6uEOyAm2XLBQdyhw1gx23AGIP0rbtHvOxJwZqJfF+MtXRQUwyc1MbZtqSW2zb9vzZnIarnLQnHetffelvGsLob8rLVnBE+fQxW3oBe2wRuBg7xTusrpPwGMkM="],"X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"64b57f14-da84-4aa8-1926-08d50e9acf1a","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:MWHPR02MB3280; ","X-MS-TrafficTypeDiagnostic":"MWHPR02MB3280:","X-Exchange-Antispam-Report-Test":"UriScan:(788757137089)(21532816269658);","X-Microsoft-Antispam-PRVS":"<MWHPR02MB3280C798D7E56B23A0352C49C2770@MWHPR02MB3280.namprd02.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR02MB3280; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR02MB3280; ","X-Forefront-PRVS":"0454444834","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"xilinx.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 Oct 2017 22:20:40.2170\n\t(UTC)","X-MS-Exchange-CrossTenant-Id":"657af505-d5df-48d0-8300-c31994686c5c","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"TenantId=657af505-d5df-48d0-8300-c31994686c5c; \n\tIp=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01]","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR02MB3280","X-detected-operating-system":"by eggs.gnu.org: Windows 7 or 8 [fuzzy]","X-Received-From":"104.47.40.63","Subject":"Re: [Qemu-devel] [PATCH v3 0/8]  Add the ZynqMP PMU and IPI","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"edgar.iglesias@gmail.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org,\n\talistair23@gmail.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1783322,"web_url":"http://patchwork.ozlabs.org/comment/1783322/","msgid":"<CAKmqyKMEbQ3JbqMxeeOTBV92ixRVDfw1wFi57xNKGyF82DSC_Q@mail.gmail.com>","list_archive_url":null,"date":"2017-10-10T00:12:39","subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Sun, Oct 8, 2017 at 3:20 PM, Edgar E. Iglesias\n<edgar.iglesias@xilinx.com> wrote:\n> On Wed, Sep 20, 2017 at 03:01:31PM -0700, Alistair Francis wrote:\n>>\n>> This series adds the ZynqMP Power Management Unit (PMU) machine with basic\n>> functionality.\n>>\n>> The machine only has the\n>>  - CPU\n>>  - Memory\n>>  - Interrupt controller\n>>  - IPI device\n>>\n>> connected, but that is enough to run some of the ROM and firmware\n>> code on the machine\n>>\n>> The series also adds the IPI device and connects it to the ZynqMP ARM\n>> side and the ZynqMP PMU. These IPI devices don't connect between the ARM\n>> and MicroBlaze instances though.\n>>\n>> v3:\n>>  - Add the interrupt controller\n>>  - Replace some of the error_fatals with errp\n>>  - Fix the PMU CPU name\n>\n> Hi Alistair,\n>\n>\n> Sorry for the super long delay...\n>\n> I think this mostly looks good but I was wondering if we really need\n> to have a board specific (zcu102) PMU?\n\nIt doesn't have to be board specific. What I wanted though was an SoC\nand a machine so that maybe one day we could add the PMU SoC to the\nARM ZCU102 machine. After that it was hard to think of a name to\ndifferentiate the SoC and the machine. Do you have a recommendation on\nnames?\n\nThanks,\nAlistair\n\n>\n> Best regards,\n> Edgar\n>\n>\n>\n>>\n>>\n>>\n>> Alistair Francis (8):\n>>   xlnx-zynqmp-pmu: Initial commit of the ZynqMP PMU\n>>   xlnx-zynqmp-pmu: Add the CPU and memory\n>>   aarch64-softmmu.mak: Use an ARM specific config\n>>   xlnx-pmu-iomod-intc: Add the PMU Interrupt controller\n>>   xlnx-zynqmp-pmu: Connect the PMU interrupt controller\n>>   xlnx-zynqmp-ipi: Initial version of the Xilinx IPI device\n>>   xlnx-zynqmp-pmu: Connect the IPI device to the PMU\n>>   xlnx-zynqmp: Connect the IPI device to the ZynqMP SoC\n>>\n>>  default-configs/aarch64-softmmu.mak    |   1 +\n>>  default-configs/microblaze-softmmu.mak |   1 +\n>>  hw/arm/Makefile.objs                   |   2 +-\n>>  hw/arm/xlnx-zynqmp.c                   |  14 +\n>>  hw/display/Makefile.objs               |   2 +-\n>>  hw/dma/Makefile.objs                   |   2 +-\n>>  hw/intc/Makefile.objs                  |   2 +\n>>  hw/intc/xlnx-pmu-iomod-intc.c          | 554 +++++++++++++++++++++++++++++++++\n>>  hw/intc/xlnx-zynqmp-ipi.c              | 377 ++++++++++++++++++++++\n>>  hw/microblaze/Makefile.objs            |   1 +\n>>  hw/microblaze/xlnx-zynqmp-pmu.c        | 200 ++++++++++++\n>>  include/hw/arm/xlnx-zynqmp.h           |   2 +\n>>  include/hw/intc/xlnx-pmu-iomod-intc.h  |  58 ++++\n>>  include/hw/intc/xlnx-zynqmp-ipi.h      |  57 ++++\n>>  14 files changed, 1270 insertions(+), 3 deletions(-)\n>>  create mode 100644 hw/intc/xlnx-pmu-iomod-intc.c\n>>  create mode 100644 hw/intc/xlnx-zynqmp-ipi.c\n>>  create mode 100644 hw/microblaze/xlnx-zynqmp-pmu.c\n>>  create mode 100644 include/hw/intc/xlnx-pmu-iomod-intc.h\n>>  create mode 100644 include/hw/intc/xlnx-zynqmp-ipi.h\n>>\n>> --\n>> 2.11.0\n>>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HpAGq2Ng\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9yJP6lKpz9t5Q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 10 Oct 2017 11:13:40 +1100 (AEDT)","from localhost ([::1]:60389 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e1iB0-0005FN-5w\n\tfor incoming@patchwork.ozlabs.org; Mon, 09 Oct 2017 20:13:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44342)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <alistair23@gmail.com>) id 1e1iAa-0005FF-JH\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 20:13:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <alistair23@gmail.com>) id 1e1iAZ-0004dc-HO\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 20:13:12 -0400","from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:38687)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <alistair23@gmail.com>)\n\tid 1e1iAZ-0004dK-9j; Mon, 09 Oct 2017 20:13:11 -0400","by mail-wm0-x241.google.com with SMTP id q124so23007337wmb.5;\n\tMon, 09 Oct 2017 17:13:11 -0700 (PDT)","by 10.28.157.2 with HTTP; Mon, 9 Oct 2017 17:12:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=ml+jAqVGKNty0fO+LdRW1QPlKHacJMh9BEMhM2KlPH0=;\n\tb=HpAGq2NgrNHSt4tUxCyDIaZFYwyeisXnriN62j7O+ct+eSHiZLjG1Kr1hyJDG4h7fa\n\tisXmmq+XLpaE5EF2YKhtb6/S5O9mv1LRyT9UJYL+bZH0Q4G/hfwCrBIpO31yEGnlH/XC\n\tDW5AzdDdKso0EKcRdNutNxvnVssVqzrgJwGTGq43SK1S32IhqaNXmDcsCGR37/0b9kfJ\n\teoFZQ7s4+GnsUIAvl9O3AbL9FbC+tx3DEP7lObkKk0RsVFn9igKmTPWJ/Iu/9wGoEQq6\n\tABrJr0MBfm0YO37A61xZ2y69YXXgcSKisme9UTf7fUy9oITjAiLbVzagF/p0dmdzteL8\n\tNmeA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=ml+jAqVGKNty0fO+LdRW1QPlKHacJMh9BEMhM2KlPH0=;\n\tb=CFX9sayIf0/C1qZfyDAdr2qdYq6d/vJuUmDdm71U6+hp2VCY8yeUYsziGOFUI7asR5\n\tgi9SRixVUaJayElkESIqszler6G18PXgXXOiZMdmatmGufe2IwH4KDbsWaeuQU/c3zZf\n\toFOCjaMyeSS4tAdfbHaVsZSRc2z2MoKt0lnrV7F2eg5vOglQC19LQPiLK7M+UnofWrHT\n\tzsBgXUvNurhy9C6x6I4dTGWz01agn6w6JWfL/S0kVEBhR6WGPdSBhJjKUddRuQW5U+HP\n\tGavxoBcEmG6SrgGQ1V7+3L+AKrinVvHnI96Zqwd0kaOLOnmFVOQpObncgiUsue09dDg5\n\txIUw==","X-Gm-Message-State":"AMCzsaUYfe4iJMSF3fgY+Ls72v31rlEPLoycH9scCXGtBzPMRgC1vvaD\n\tyKzs0+x5omfUJExb9sc+3ZtkjhPyp9qtfbdfEr8=","X-Google-Smtp-Source":"AOwi7QB4hxszUtMsKQuYctBgAQj4bDfDw2yt730I47hl0gGWRpcil5xOiiJq5153bOUcvyYIiHuLzZI56IsY9x4cevo=","X-Received":"by 10.223.144.71 with SMTP id h65mr10928853wrh.41.1507594390274; \n\tMon, 09 Oct 2017 17:13:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171008222029.GA29979@toto>","References":"<cover.1505929556.git.alistair.francis@xilinx.com>\n\t<20171008222029.GA29979@toto>","From":"Alistair Francis <alistair.francis@xilinx.com>","Date":"Mon, 9 Oct 2017 17:12:39 -0700","X-Google-Sender-Auth":"9veDuLk-bwZS8iSLzpZdoE6yOQI","Message-ID":"<CAKmqyKMEbQ3JbqMxeeOTBV92ixRVDfw1wFi57xNKGyF82DSC_Q@mail.gmail.com>","To":"\"Edgar E. Iglesias\" <edgar.iglesias@xilinx.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::241","Subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Edgar Iglesias <edgar.iglesias@gmail.com>, qemu-arm <qemu-arm@nongnu.org>,\n\t\"qemu-devel@nongnu.org Developers\" <qemu-devel@nongnu.org>,\n\tAlistair Francis <alistair.francis@xilinx.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1783807,"web_url":"http://patchwork.ozlabs.org/comment/1783807/","msgid":"<20171010144834.GC5553@toto>","list_archive_url":null,"date":"2017-10-10T14:48:34","subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","submitter":{"id":2296,"url":"http://patchwork.ozlabs.org/api/people/2296/","name":"Edgar E. Iglesias","email":"edgar.iglesias@gmail.com"},"content":"On Mon, Oct 09, 2017 at 05:12:39PM -0700, Alistair Francis wrote:\n> On Sun, Oct 8, 2017 at 3:20 PM, Edgar E. Iglesias\n> <edgar.iglesias@xilinx.com> wrote:\n> > On Wed, Sep 20, 2017 at 03:01:31PM -0700, Alistair Francis wrote:\n> >>\n> >> This series adds the ZynqMP Power Management Unit (PMU) machine with basic\n> >> functionality.\n> >>\n> >> The machine only has the\n> >>  - CPU\n> >>  - Memory\n> >>  - Interrupt controller\n> >>  - IPI device\n> >>\n> >> connected, but that is enough to run some of the ROM and firmware\n> >> code on the machine\n> >>\n> >> The series also adds the IPI device and connects it to the ZynqMP ARM\n> >> side and the ZynqMP PMU. These IPI devices don't connect between the ARM\n> >> and MicroBlaze instances though.\n> >>\n> >> v3:\n> >>  - Add the interrupt controller\n> >>  - Replace some of the error_fatals with errp\n> >>  - Fix the PMU CPU name\n> >\n> > Hi Alistair,\n> >\n> >\n> > Sorry for the super long delay...\n> >\n> > I think this mostly looks good but I was wondering if we really need\n> > to have a board specific (zcu102) PMU?\n> \n> It doesn't have to be board specific. What I wanted though was an SoC\n> and a machine so that maybe one day we could add the PMU SoC to the\n> ARM ZCU102 machine. After that it was hard to think of a name to\n> differentiate the SoC and the machine. Do you have a recommendation on\n> names?\n\n\nHi Alistair,\n\nYes, I agree with your approach but I got a little confused by the names.\n\nI think all the stuff that is inside the PMU subsystem architecture-wise\nshould have generic PMU names (no ZCU102). I.e the ROM, the RAM, the IOModule,\ninterrupt controller etc.\n\nThe IPI block can be outside of the PMU module and be instantiated by the\nboard or perhaps better if we could reuse some of the ZynqMP modules\ninstantiated by the ZCU102 machine to get a CPU-less PS for the PMU\nto interact with. Or something along those lines.\nHow does that sound?\n\nBest regards,\nEdgar","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TLK+TAwS\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBKpw0MZCz9tYB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 11 Oct 2017 01:52:56 +1100 (AEDT)","from localhost ([::1]:35471 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e1vtu-0004Ie-76\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 10:52:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57554)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <edgar.iglesias@gmail.com>) id 1e1vpq-0001jy-LA\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 10:48:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <edgar.iglesias@gmail.com>) id 1e1vpn-0005ud-Ey\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 10:48:42 -0400","from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:55244)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <edgar.iglesias@gmail.com>)\n\tid 1e1vpn-0005tK-6v; Tue, 10 Oct 2017 10:48:39 -0400","by mail-lf0-x234.google.com with SMTP id d10so29013013lfg.11;\n\tTue, 10 Oct 2017 07:48:37 -0700 (PDT)","from gmail.com (81-231-233-234-no56.tbcn.telia.com.\n\t[81.231.233.234]) by smtp.gmail.com with ESMTPSA id\n\tz204sm1815883lff.33.2017.10.10.07.48.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 10 Oct 2017 07:48:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=x31vu5InvpTLGEogDKkBiQgb1p0lC+p9QyNVzQvvKuo=;\n\tb=TLK+TAwS0nCpgfpbfgv4vr6Vn0gleOq0JSx5jsLPXzBoMcKp1lB5X9iNQvrQBUUWgI\n\tfq1NFVVpYlrhJXuO/sVGnVB+IZo8LZx6PX7wX/aEHTLzxIeoz8f94GcdkZgf8QEmy8fW\n\tIoXkT+IOwXb9hSqs9Fkl9AGQzjJUdq7uaumTT2yiJII5uAvnwEtRKpp8I31J7yL7GMhu\n\tH9YrELuEau3WSHvtz6DywwJOnbggnx9J+YzMZ+cS6CGaIj40TAFCQCDhqWjHdUxn/yTw\n\tLBXQWlgSFbeAjHIx8gZ1qN41GcgvAo6RF2COLKVYHtQsUtdot9asgx6pA47TESgLBQ3j\n\tLudA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=x31vu5InvpTLGEogDKkBiQgb1p0lC+p9QyNVzQvvKuo=;\n\tb=nkUir0N3cgSSiWc7Gspd5bc8DSzwHiFwCFFRippVEm6iPV6WDeeyv2dt2kfsHk8O4f\n\tFO3/3xme9ykQbMA3QDvAHVhx93Z+McDB6NBKGALrpFQv9FBYgU8QND5xRwQ36einjohK\n\tuYJPYZ9Gxsj9xRY9CLvgMI8t+HKtvnRIdlSj2sb3VTf8YYMSJ1DQL+UZxv1YzbUasUwB\n\tL0fzdBbRrYoeEMHLor8Wm7yJhJ+fTqPscmzMS/MJzPOrNz4Cbmt4BkFK/gUXO1SheLmc\n\t9wfB00SWK5YsZUwMZemhsNtRWLk6fXPCfR8KYEHR7O/NZ4QbuhMBlcPM72Zpw1Ehc/jp\n\tZhTA==","X-Gm-Message-State":"AMCzsaVTWWkNqPtaP3oXXhVrRb+cM7W2fb5xdUcYl0+NDAOeVzY9wccH\n\t9licsrOAmGb3kEd0RirUn74=","X-Google-Smtp-Source":"AOwi7QCbjo1uNGmJkzJ+Zq0O8TlOHNQg0FdRZzG4rnDbqUB6SR/tHmL/APnt8kxYoJfy38FBySgtwg==","X-Received":"by 10.25.222.202 with SMTP id i71mr5533029lfl.177.1507646916302; \n\tTue, 10 Oct 2017 07:48:36 -0700 (PDT)","Date":"Tue, 10 Oct 2017 16:48:34 +0200","From":"\"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>","To":"Alistair Francis <alistair.francis@xilinx.com>","Message-ID":"<20171010144834.GC5553@toto>","References":"<cover.1505929556.git.alistair.francis@xilinx.com>\n\t<20171008222029.GA29979@toto>\n\t<CAKmqyKMEbQ3JbqMxeeOTBV92ixRVDfw1wFi57xNKGyF82DSC_Q@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<CAKmqyKMEbQ3JbqMxeeOTBV92ixRVDfw1wFi57xNKGyF82DSC_Q@mail.gmail.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:4010:c07::234","Subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"\"Edgar E. Iglesias\" <edgar.iglesias@xilinx.com>,\n\tqemu-arm <qemu-arm@nongnu.org>,\n\t\"qemu-devel@nongnu.org Developers\" <qemu-devel@nongnu.org>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1783993,"web_url":"http://patchwork.ozlabs.org/comment/1783993/","msgid":"<CAKmqyKMTqZA+t77XV3s2aicsbHHbF8h96w=dmWO9VHJkE0Uw8w@mail.gmail.com>","list_archive_url":null,"date":"2017-10-10T17:59:08","subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Tue, Oct 10, 2017 at 7:48 AM, Edgar E. Iglesias\n<edgar.iglesias@gmail.com> wrote:\n> On Mon, Oct 09, 2017 at 05:12:39PM -0700, Alistair Francis wrote:\n>> On Sun, Oct 8, 2017 at 3:20 PM, Edgar E. Iglesias\n>> <edgar.iglesias@xilinx.com> wrote:\n>> > On Wed, Sep 20, 2017 at 03:01:31PM -0700, Alistair Francis wrote:\n>> >>\n>> >> This series adds the ZynqMP Power Management Unit (PMU) machine with basic\n>> >> functionality.\n>> >>\n>> >> The machine only has the\n>> >>  - CPU\n>> >>  - Memory\n>> >>  - Interrupt controller\n>> >>  - IPI device\n>> >>\n>> >> connected, but that is enough to run some of the ROM and firmware\n>> >> code on the machine\n>> >>\n>> >> The series also adds the IPI device and connects it to the ZynqMP ARM\n>> >> side and the ZynqMP PMU. These IPI devices don't connect between the ARM\n>> >> and MicroBlaze instances though.\n>> >>\n>> >> v3:\n>> >>  - Add the interrupt controller\n>> >>  - Replace some of the error_fatals with errp\n>> >>  - Fix the PMU CPU name\n>> >\n>> > Hi Alistair,\n>> >\n>> >\n>> > Sorry for the super long delay...\n>> >\n>> > I think this mostly looks good but I was wondering if we really need\n>> > to have a board specific (zcu102) PMU?\n>>\n>> It doesn't have to be board specific. What I wanted though was an SoC\n>> and a machine so that maybe one day we could add the PMU SoC to the\n>> ARM ZCU102 machine. After that it was hard to think of a name to\n>> differentiate the SoC and the machine. Do you have a recommendation on\n>> names?\n>\n>\n> Hi Alistair,\n>\n> Yes, I agree with your approach but I got a little confused by the names.\n>\n> I think all the stuff that is inside the PMU subsystem architecture-wise\n> should have generic PMU names (no ZCU102). I.e the ROM, the RAM, the IOModule,\n> interrupt controller etc.\n\nOk I can rename them to the ZynqMP PMU (the machine/board) and the\nZynqMP PMU SoC. Does that work?\n\n>\n> The IPI block can be outside of the PMU module and be instantiated by the\n> board or perhaps better if we could reuse some of the ZynqMP modules\n> instantiated by the ZCU102 machine to get a CPU-less PS for the PMU\n> to interact with. Or something along those lines.\n> How does that sound?>\n\nI'm a little unclear what you mean here.\n\nThanks,\nAlistair\n\n> Best regards,\n> Edgar\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DOtBl+Z5\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBPz12Y40z9t5R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 11 Oct 2017 05:00:09 +1100 (AEDT)","from localhost ([::1]:36474 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e1yp3-0001OM-Kq\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 14:00:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33971)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <alistair23@gmail.com>) id 1e1yoj-0001Mm-J6\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 13:59:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <alistair23@gmail.com>) id 1e1yoi-0003Zu-At\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 13:59:45 -0400","from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:53025)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <alistair23@gmail.com>)\n\tid 1e1yoe-0003Xw-4Q; Tue, 10 Oct 2017 13:59:40 -0400","by mail-wm0-x230.google.com with SMTP id k4so7663146wmc.1;\n\tTue, 10 Oct 2017 10:59:39 -0700 (PDT)","by 10.28.157.2 with HTTP; Tue, 10 Oct 2017 10:59:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Vp66oPe2PtbiViiAHpBhBw+p3Ge6eAfcuj/KI9gfoM8=;\n\tb=DOtBl+Z5BiXfhpUl8ns+bs0hAsn8Nq1c4bwtj9LolknBTmm3cf15xUegYryUa64FRg\n\tQRYgN7eRy83Rds4iPzFUWAWyS4aLt+TG9lUoFVQZVKWUfoRYXDoq0wbl8jAU4+HyfHLr\n\tbChOxP2bw6cocTM4bEuBWLWn85k46cOoO+n4bDLBEgaqg0dP+q6TPi1Vz4yTtXUV+mjP\n\tgLy4TaUezypU7q4Fhgl3fmL1YWFk8R2+eWLOXg6h0YhN3QG4YXcwpbQTNJagaDPpLza1\n\tmTwfN5SVKPiwOGgWVIuniJ1pVDaS68j73K3Hwqjwb3Qr9/61WwHdPCkNM8ZWF6Iefx02\n\tUM5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Vp66oPe2PtbiViiAHpBhBw+p3Ge6eAfcuj/KI9gfoM8=;\n\tb=LTJ9NWhaacBx/ftBl6XHjFxArfQJT3AxeiZEDj+NieiYJxa6gbMnzavsZ6uT63cAU3\n\tU1cfgedNNwHTq8ZNov/pmPfA3knEpNKFKdPSMEkpjH7mAgmv9cpavN+YEqo421ngfEyY\n\tQx4rDJ+6zpeIr4ZDhIX2NYI3veQ7zQ1u/055j8V2vdf7+TgrH8Tpxn+aqYUF4uvZqf0h\n\tdqYNcMTHO8b0uZ29zHRyjZqgGOcXnHn4srTbWnNx09NpptIhptusI94HVLy1h9dQ4/ie\n\tR5LtPWH7mywvnR3FBh+LF4eudK1EbBK7+ORG8QzDt/j5h6m6UzxzJYTUwCL+d5Jos7/Z\n\tJ1UA==","X-Gm-Message-State":"AMCzsaXd1XOY8hqOxuK71Xw1wn5BP5w4GYwAj4MU7pqOBtk/nWFe3NkD\n\t5TGxUlGp47ouEEgGD0FK6vGMhwhb5bRRhYf1kcHm+g==","X-Google-Smtp-Source":"AOwi7QC8zCbp/FbYCaO41rP3qGjjZQrx+Mad8z14S8ycdICFR+fcIIIO6d9Ye6Uc/lDVcAatLXF+8teq3Saa8Sy4jYg=","X-Received":"by 10.223.131.65 with SMTP id 59mr12358488wrd.66.1507658378693; \n\tTue, 10 Oct 2017 10:59:38 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20171010144834.GC5553@toto>","References":"<cover.1505929556.git.alistair.francis@xilinx.com>\n\t<20171008222029.GA29979@toto>\n\t<CAKmqyKMEbQ3JbqMxeeOTBV92ixRVDfw1wFi57xNKGyF82DSC_Q@mail.gmail.com>\n\t<20171010144834.GC5553@toto>","From":"Alistair Francis <alistair.francis@xilinx.com>","Date":"Tue, 10 Oct 2017 10:59:08 -0700","X-Google-Sender-Auth":"V6KWOSzZDMgnBedl_Lnx3E16spU","Message-ID":"<CAKmqyKMTqZA+t77XV3s2aicsbHHbF8h96w=dmWO9VHJkE0Uw8w@mail.gmail.com>","To":"\"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::230","Subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"\"Edgar E. Iglesias\" <edgar.iglesias@xilinx.com>,\n\tqemu-arm <qemu-arm@nongnu.org>,\n\t\"qemu-devel@nongnu.org Developers\" <qemu-devel@nongnu.org>,\n\tAlistair Francis <alistair.francis@xilinx.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1785758,"web_url":"http://patchwork.ozlabs.org/comment/1785758/","msgid":"<CAJy5ezogexkDJzFp-YyvHqFPhJWrKhEZstwaBsN4njTB9qC=mw@mail.gmail.com>","list_archive_url":null,"date":"2017-10-12T18:58:43","subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","submitter":{"id":2296,"url":"http://patchwork.ozlabs.org/api/people/2296/","name":"Edgar E. Iglesias","email":"edgar.iglesias@gmail.com"},"content":"On Oct 10, 2017 7:59 PM, \"Alistair Francis\" <alistair.francis@xilinx.com>\nwrote:\n\nOn Tue, Oct 10, 2017 at 7:48 AM, Edgar E. Iglesias\n<edgar.iglesias@gmail.com> wrote:\n> On Mon, Oct 09, 2017 at 05:12:39PM -0700, Alistair Francis wrote:\n>> On Sun, Oct 8, 2017 at 3:20 PM, Edgar E. Iglesias\n>> <edgar.iglesias@xilinx.com> wrote:\n>> > On Wed, Sep 20, 2017 at 03:01:31PM -0700, Alistair Francis wrote:\n>> >>\n>> >> This series adds the ZynqMP Power Management Unit (PMU) machine with\nbasic\n>> >> functionality.\n>> >>\n>> >> The machine only has the\n>> >>  - CPU\n>> >>  - Memory\n>> >>  - Interrupt controller\n>> >>  - IPI device\n>> >>\n>> >> connected, but that is enough to run some of the ROM and firmware\n>> >> code on the machine\n>> >>\n>> >> The series also adds the IPI device and connects it to the ZynqMP ARM\n>> >> side and the ZynqMP PMU. These IPI devices don't connect between the\nARM\n>> >> and MicroBlaze instances though.\n>> >>\n>> >> v3:\n>> >>  - Add the interrupt controller\n>> >>  - Replace some of the error_fatals with errp\n>> >>  - Fix the PMU CPU name\n>> >\n>> > Hi Alistair,\n>> >\n>> >\n>> > Sorry for the super long delay...\n>> >\n>> > I think this mostly looks good but I was wondering if we really need\n>> > to have a board specific (zcu102) PMU?\n>>\n>> It doesn't have to be board specific. What I wanted though was an SoC\n>> and a machine so that maybe one day we could add the PMU SoC to the\n>> ARM ZCU102 machine. After that it was hard to think of a name to\n>> differentiate the SoC and the machine. Do you have a recommendation on\n>> names?\n>\n>\n> Hi Alistair,\n>\n> Yes, I agree with your approach but I got a little confused by the names.\n>\n> I think all the stuff that is inside the PMU subsystem architecture-wise\n> should have generic PMU names (no ZCU102). I.e the ROM, the RAM, the\nIOModule,\n> interrupt controller etc.\n\nOk I can rename them to the ZynqMP PMU (the machine/board) and the\nZynqMP PMU SoC. Does that work?\n\n>\n> The IPI block can be outside of the PMU module and be instantiated by the\n> board or perhaps better if we could reuse some of the ZynqMP modules\n> instantiated by the ZCU102 machine to get a CPU-less PS for the PMU\n> to interact with. Or something along those lines.\n> How does that sound?>\n\nI'm a little unclear what you mean here.\n\nThanks,\nAlistair\n\n> Best regards,\n> Edgar\n>\n\n\nHi Alistair,\n\nTo clarify, if you create a pmu object, try to only put stuff in that\nobject that belong to the pmu subsystem. The IPI block for example doesn't,\nit belongs outside of the pmu object allthough you will want to instate an\nipi instance in the pmu machine.\n\nHope that helps\nEdgar\n\nSent from my phone","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kStlLvuJ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCgBF2F4Hz9sNw\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 Oct 2017 05:59:17 +1100 (AEDT)","from localhost ([::1]:46816 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1e2ihP-0002Va-GJ\n\tfor incoming@patchwork.ozlabs.org; Thu, 12 Oct 2017 14:59:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42285)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <edgar.iglesias@gmail.com>) id 1e2ih2-0002T4-AN\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 14:58:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <edgar.iglesias@gmail.com>) id 1e2ih0-0004ti-Sl\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 14:58:52 -0400","from mail-lf0-x235.google.com ([2a00:1450:4010:c07::235]:46301)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <edgar.iglesias@gmail.com>)\n\tid 1e2igx-0004oY-IA; Thu, 12 Oct 2017 14:58:47 -0400","by mail-lf0-x235.google.com with SMTP id g70so7014065lfl.3;\n\tThu, 12 Oct 2017 11:58:46 -0700 (PDT)","by 10.25.83.220 with HTTP; Thu, 12 Oct 2017 11:58:43 -0700 (PDT)","by 10.25.83.220 with HTTP; Thu, 12 Oct 2017 11:58:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=TNwqP7nIFAcqgFlz9/1AhpgrLmK255/8eqJXxtxreas=;\n\tb=kStlLvuJS8aFU01Y9V6myfyavB/P1PDFzsmwyUjuReuTXTKLqYk17cmOxZnY0lre59\n\tZGv/z+UVnTlvUyGW0RhjAVPXcfpjNSADOWmn4L/uYpXwxLMZRIEzaolgwWKf+s/Hpn5z\n\tnD1PtlZJy3gv2yu4sif0TDsfi+cX1DipU2HKXwvUovMPUgkjtO+fR5hedunvN3X0SGO/\n\tevayN8AMJOJPtS2NzwtY1+RqWRVPKxfcGzo/wbekfvjGN+HRzdIKYN3AaaLwm1Fc2FA6\n\tark4THIxpKm/lSJ+LJw1QyXjMPSjNVXdq5m8yjzuCmj7jKWSXhsaehSLebpmd6+0eag9\n\t+NYw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=TNwqP7nIFAcqgFlz9/1AhpgrLmK255/8eqJXxtxreas=;\n\tb=bA4IPOv/XdugqYNGzBnYcxP7YJqSfF33PhFfD69fvI+B4Re7NZy4arDYHJ7spRyWmd\n\t9e9MU4BYFqcPyUMvjaZ5D/UunHPAhFQE7SXAQFYugPn4a6T3XV1ED6u1adWTfgzKV5FP\n\tvPresQZMZPYI/XSnAwUo0zrGAWMGqH1OuzwarANC5STlckcUPbksNvQ7nKFVJDGwCweo\n\tECaTUBhLwLarVWrl1e4sqlwNKW2Yeo53vLKFJsg/Dpvw7iEgHV+GctP0cB4o0RvDoJVl\n\tAaJymymU7kSKWu4lbMMbSwizkcIpUIf8pM0Ds8L2GRtxs79SEHsNkuhLPtqhFrH0eOEg\n\tkXEA==","X-Gm-Message-State":"AMCzsaWMkx+mfdB1JOiLjregqA87Pdt6Igl1MQPSfxCRCjF5R4/cgAtg\n\t5BIxtGB1d2pTe9T86aiTZxDDc4TIL4n9Py9lOlg=","X-Google-Smtp-Source":"ABhQp+TeYptZBPySUKIG4DFBT8qa+ND8wR1js+BH9zLuT1darBPgOMpMRXNTmGbnvO88S0neskT4DgAPnf7JxHjL9Vc=","X-Received":"by 10.25.221.196 with SMTP id w65mr949216lfi.89.1507834724615;\n\tThu, 12 Oct 2017 11:58:44 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAKmqyKMTqZA+t77XV3s2aicsbHHbF8h96w=dmWO9VHJkE0Uw8w@mail.gmail.com>","References":"<cover.1505929556.git.alistair.francis@xilinx.com>\n\t<20171008222029.GA29979@toto>\n\t<CAKmqyKMEbQ3JbqMxeeOTBV92ixRVDfw1wFi57xNKGyF82DSC_Q@mail.gmail.com>\n\t<20171010144834.GC5553@toto>\n\t<CAKmqyKMTqZA+t77XV3s2aicsbHHbF8h96w=dmWO9VHJkE0Uw8w@mail.gmail.com>","From":"\"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>","Date":"Thu, 12 Oct 2017 20:58:43 +0200","Message-ID":"<CAJy5ezogexkDJzFp-YyvHqFPhJWrKhEZstwaBsN4njTB9qC=mw@mail.gmail.com>","To":"Alistair Francis <alistair.francis@xilinx.com>","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:4010:c07::235","Content-Type":"text/plain; charset=\"UTF-8\"","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-arm <qemu-arm@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]