[{"id":1783339,"web_url":"http://patchwork.ozlabs.org/comment/1783339/","msgid":"","list_archive_url":null,"date":"2017-10-10T00:49:54","subject":"Re: [PATCH v2 0/3] Altera ASMI Parallel II IP Core","submitter":{"id":70992,"url":"http://patchwork.ozlabs.org/api/people/70992/","name":"Matthew Gerlach","email":"matthew.gerlach@linux.intel.com"},"content":"Hi Everyone,\n\nThanks to Rob Herring for Acking the device tree bindings part of the \npatch. Does anyone have any feedback for the rest of the patch set?\n\nThanks,\n\nMatthew Gerlach\n\nOn Wed, 20 Sep 2017, matthew.gerlach@linux.intel.com wrote:\n\n> From: Matthew Gerlach \n>\n> This patch set adds a spi-nor flash driver for the Altera ASMI Parallel II\n> IP Core. This driver was created based on feedback from Marek Vasut,\n> Cyrill Pitchen, and Michal Suchanek regarding Version 2 of the Altera\n> Quadspi Controller: https://lkml.org/lkml/2017/6/26/518\n>\n> The overall problem with Version 2 of the Altera Quadspi Controller and\n> its driver was the fact that there was much duplication of code and logic\n> with the spi-nor framework. This new combination of fpga hardware and\n> software \"gets out of the way\" of the spi-nor framework. The result is a\n> much simpler driver with the spi-nor framework performing the bulk of the work.\n>\n> Patch 1 contains the device tree bindings for the driver for\n> the Altera ASMI-Parallel II IP Core.\n>\n> Patch 2 contains the driver code for the Altera ASMI-Parallel II IP Core.\n> This driver supports being configured via a device tree or with platform\n> data. In the later case, the memory for the registers has been remapped.\n>\n> Patch 3 contains a work around for some non-standard behavior of EPCQ flash.\n>\n> Matthew Gerlach (3):\n> dt-bindings: mtd: Altera ASMI Parallel II IP Core\n> mtd: spi-nor: Altera ASMI Parallel II IP Core\n> mtd: spi-nor: add flag for reading dummy cycles from nv cfg reg\n>\n> .../devicetree/bindings/mtd/altera-asmip2.txt | 15 +\n> MAINTAINERS | 7 +\n> drivers/mtd/spi-nor/Kconfig | 6 +\n> drivers/mtd/spi-nor/Makefile | 1 +\n> drivers/mtd/spi-nor/altera-asmip2.c | 478 +++++++++++++++++++++\n> include/linux/mtd/altera-asmip2.h | 27 ++\n> 6 files changed, 534 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/mtd/altera-asmip2.txt\n> create mode 100644 drivers/mtd/spi-nor/altera-asmip2.c\n> create mode 100644 include/linux/mtd/altera-asmip2.h\n>\n> -- \n> 2.7.4\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-fpga\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ltc5JthO\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9z6z0Fphz9t3B\n\tfor ;\n\tTue, 10 Oct 2017 11:50:35 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1ikZ-0006i7-OB; Tue, 10 Oct 2017 00:50:23 +0000","from mga11.intel.com ([192.55.52.93])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1ikV-0005Qb-RW\n\tfor linux-mtd@lists.infradead.org; Tue, 10 Oct 2017 00:50:21 +0000","from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Oct 2017 17:49:57 -0700","from kcanfiel-mobl1.amr.corp.intel.com (HELO [10.0.2.15])\n\t([10.254.75.6])\n\tby fmsmga002.fm.intel.com with ESMTP; 09 Oct 2017 17:49:55 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To:\n\tSubject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=iUr6ukh+cXDUredyhoM3nrXscLuTrho4MKkiwetD+fw=;\n\tb=ltc5JthOJLSxxFG6gNcYqjfYf\n\t3O5IvJ5eiC8+Qen8Yb7oeC22XN9VXDSy/PhoQzURNM7/Wb+OMQarbR9NnAFslZJ9ycrlx0wKbPALi\n\t4j/p2OqPrtxbWaUgjB0Umz4dDIUpB8Fk5EplM/2tOqc2bWyIQ2eESkG3w8xPy+uaHD6juZQirTIvI\n\t8P5KW87r8TFhoj3DDvtpjclQi3ypcC4z6KYEQQsJFePCdQ8gUgmpC1HVQz1X9LGnu1PC91FwQVuKc\n\tmUZ/OgfyZ0fIgI64rcOqIDgknrH3w5F3kvvv0G9Mt9YyWItMWpSZHtszMJo+boupsAGp86IWJPwyb\n\tm+mdqDSsA==;","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,502,1500966000\"; d=\"scan'208\";\n\ta=\"1228962911\"","Date":"Mon, 9 Oct 2017 17:49:54 -0700 (PDT)","From":"matthew.gerlach@linux.intel.com","X-X-Sender":"mgerlach@mgerlach-VirtualBox","To":"vndao@altera.com, dwmw2@infradead.org, computersforpeace@gmail.com, \n\tboris.brezillon@free-electrons.com, marek.vasut@gmail.com,\n\trichard@nod.at, \n\tcyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com, \n\tlinux-mtd@lists.infradead.org, devicetree@vger.kernel.org, \n\tlinux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, \n\tdavem@davemloft.net, mchehab@kernel.org, linux-fpga@vger.kernel.org, \n\ttien.hock.loh@intel.com, hean.loong.ong@intel.com","Subject":"Re: [PATCH v2 0/3] Altera ASMI Parallel II IP Core","In-Reply-To":"<1505932139-2905-1-git-send-email-matthew.gerlach@linux.intel.com>","Message-ID":"","References":"<1505932139-2905-1-git-send-email-matthew.gerlach@linux.intel.com>","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171009_175019_954910_BB64C1AA ","X-CRM114-Status":"GOOD ( 19.06 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [192.55.52.93 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]