[{"id":1772529,"web_url":"http://patchwork.ozlabs.org/comment/1772529/","msgid":"<20170921102318.1d7784f1.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-21T08:23:18","subject":"Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 20 Sep 2017 17:30:13 +0200\nDavid Hildenbrand wrote:\n\n> Some leftover from \"target/s390x: tcg improvments + MSA functions\".\n> \n> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide\n> the query subfunction (to query available subfunctions), no actual\n> de/encryption yet. Good enough to unlock the STFL bits.\n> \n> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will\n> send them out soon. I use the following cpu model to test with an upstream\n> kernel compiled for z10:\n> \n> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\\\n> eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\\\n> exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ...\n> \n> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa\n\nI used the following cpu model:\n\n-cpu qemu,eimm=on,ldisp=on,stckf=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on\n\nand got\n\nqemu-system-s390x: warning: 'msa5-base' requires 'kimd-sha-512'.\nqemu-system-s390x: warning: 'msa5-base' requires 'klmd-sha-512'.\n\n(It works anyway.)\n\nHowever,\n\n-cpu qemu,eimm=on,ldisp=on,stckf=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on,kimd-sha-512=on\n\ngives\n\nqemu-system-s390x: can't apply global qemu-s390-cpu.kimd-sha-512=on: Feature 'kimd-sha-512' is not available for CPU model 'z900', it was introduced with later models.\n\nwhich is a bit confusing.\n\nSo I'm wondering whether providing msa5-base without the providing the\nalgorithms above is sane - or whether it is just enough to satisfy some\nkernels.\n\n[Double-checking the various dependencies looks impossible without\naccess to IBM doc, anyway - I just hope you got it right back then :)]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyV4m757nz9t3C\n\tfor ;\n\tThu, 21 Sep 2017 18:23:52 +1000 (AEST)","from localhost ([::1]:52337 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duwlz-0007vH-3o\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 04:23:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42718)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duwld-0007uu-GH\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:23:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duwla-0002MR-A7\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:23:29 -0400","from mx1.redhat.com ([209.132.183.28]:47178)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duwla-0002Lv-4l\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 04:23:26 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A95D5C07F9A8;\n\tThu, 21 Sep 2017 08:23:24 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0CFBD171A5;\n\tThu, 21 Sep 2017 08:23:20 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A95D5C07F9A8","Date":"Thu, 21 Sep 2017 10:23:18 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170921102318.1d7784f1.cohuck@redhat.com>","In-Reply-To":"<20170920153016.3858-1-david@redhat.com>","References":"<20170920153016.3858-1-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 21 Sep 2017 08:23:25 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Aurelien Jarno ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772781,"web_url":"http://patchwork.ozlabs.org/comment/1772781/","msgid":"","list_archive_url":null,"date":"2017-09-21T12:38:32","subject":"Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 21.09.2017 10:23, Cornelia Huck wrote:\n> On Wed, 20 Sep 2017 17:30:13 +0200\n> David Hildenbrand wrote:\n> \n>> Some leftover from \"target/s390x: tcg improvments + MSA functions\".\n>>\n>> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide\n>> the query subfunction (to query available subfunctions), no actual\n>> de/encryption yet. Good enough to unlock the STFL bits.\n>>\n>> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will\n>> send them out soon. I use the following cpu model to test with an upstream\n>> kernel compiled for z10:\n>>\n>> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\\\n>> eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\\\n>> exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ...\n>>\n>> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa\n> \n> I used the following cpu model:\n> \n> -cpu qemu,eimm=on,ldisp=on,stckf=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on\n> \n> and got\n> \n> qemu-system-s390x: warning: 'msa5-base' requires 'kimd-sha-512'.\n> qemu-system-s390x: warning: 'msa5-base' requires 'klmd-sha-512'.\n> \n\nYes, I am aware of that and it is on my todo list. Shouldn't matter for\nnow as it is completely optional and not enabled as default.\n\n> (It works anyway.)\n> \n> However,\n> \n> -cpu qemu,eimm=on,ldisp=on,stckf=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on,kimd-sha-512=on\n> \n> gives\n> \n> qemu-system-s390x: can't apply global qemu-s390-cpu.kimd-sha-512=on: Feature 'kimd-sha-512' is not available for CPU model 'z900', it was introduced with later models.\n> \n> which is a bit confusing.\n\nDue to the way we hack up the qemu cpu model, allowing to set features\nthat are theoretically not possible (just to have some way of enabling\nthem before we can change the qemu model to something never).\n\n> \n> So I'm wondering whether providing msa5-base without the providing the\n> algorithms above is sane - or whether it is just enough to satisfy some\n> kernels.\n> \n> [Double-checking the various dependencies looks impossible without\n> access to IBM doc, anyway - I just hope you got it right back then :)]\n> \n\nWe can take care of that later (if at all relevant).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyblH1xG3z9sP1\n\tfor ;\n\tThu, 21 Sep 2017 22:39:01 +1000 (AEST)","from localhost ([::1]:53484 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dv0ks-0008WQ-ST\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 08:38:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46310)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dv0kZ-0008W0-JQ\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:38:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dv0kW-0004rL-8Q\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:38:39 -0400","from mx1.redhat.com ([209.132.183.28]:59206)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dv0kW-0004qU-2r\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 08:38:36 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EE7062F9446;\n\tThu, 21 Sep 2017 12:38:34 +0000 (UTC)","from [10.36.116.56] (ovpn-116-56.ams2.redhat.com [10.36.116.56])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 716835D97C;\n\tThu, 21 Sep 2017 12:38:33 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com EE7062F9446","To":"Cornelia Huck ","References":"<20170920153016.3858-1-david@redhat.com>\n\t<20170921102318.1d7784f1.cohuck@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Thu, 21 Sep 2017 14:38:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170921102318.1d7784f1.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 21 Sep 2017 12:38:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Aurelien Jarno ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773507,"web_url":"http://patchwork.ozlabs.org/comment/1773507/","msgid":"<20170922133416.34c1cd65.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-22T11:34:16","subject":"Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 20 Sep 2017 17:30:13 +0200\nDavid Hildenbrand wrote:\n\n> Some leftover from \"target/s390x: tcg improvments + MSA functions\".\n> \n> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide\n> the query subfunction (to query available subfunctions), no actual\n> de/encryption yet. Good enough to unlock the STFL bits.\n> \n> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will\n> send them out soon. I use the following cpu model to test with an upstream\n> kernel compiled for z10:\n> \n> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\\\n> eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\\\n> exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ...\n> \n> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa\n> \n> v2 -> v3:\n> - \"s390x/tcg: add basic MSA features\"\n> -- drop one check (fc >= 128) that can due to masking never happen\n> \n> v1 -> v2:\n> - \"s390x/tcg: implement spm (SET PROGRAM MASK)\"\n> -- use tcg_gen_extrl_i64_i32 + tcg_gen_extract_i32\n> - \"s390x/tcg: move wrap_address() to internal.h\"\n> -- internal.h instead of cpu.h\n> - \"s390x/tcg: add basic MSA features\"\n> -- minor style fixes\n> \n> \n> David Hildenbrand (3):\n> s390x/tcg: implement spm (SET PROGRAM MASK)\n> s390x/tcg: move wrap_address() to internal.h\n> s390x/tcg: add basic MSA features\n> \n> target/s390x/Makefile.objs | 2 +-\n> target/s390x/cpu.h | 2 ++\n> target/s390x/cpu_models.c | 4 +++\n> target/s390x/crypto_helper.c | 65 ++++++++++++++++++++++++++++++++++++++++++\n> target/s390x/helper.h | 1 +\n> target/s390x/insn-data.def | 15 ++++++++++\n> target/s390x/internal.h | 14 +++++++++\n> target/s390x/mem_helper.c | 14 ---------\n> target/s390x/translate.c | 67 ++++++++++++++++++++++++++++++++++++++++++++\n> 9 files changed, 169 insertions(+), 15 deletions(-)\n> create mode 100644 target/s390x/crypto_helper.c\n> \n\nThanks, applied.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzBHN228qz9sNw\n\tfor ;\n\tFri, 22 Sep 2017 21:35:28 +1000 (AEST)","from localhost ([::1]:58115 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvMEw-0003lR-E0\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 07:35:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40496)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvMDy-0003M5-7j\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:34:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvMDv-0003on-3r\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:34:26 -0400","from mx1.redhat.com ([209.132.183.28]:35868)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dvMDu-0003oW-US\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:34:23 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E843F20271;\n\tFri, 22 Sep 2017 11:34:21 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8BD095D9CB;\n\tFri, 22 Sep 2017 11:34:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E843F20271","Date":"Fri, 22 Sep 2017 13:34:16 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170922133416.34c1cd65.cohuck@redhat.com>","In-Reply-To":"<20170920153016.3858-1-david@redhat.com>","References":"<20170920153016.3858-1-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tFri, 22 Sep 2017 11:34:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Aurelien Jarno ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]