[{"id":1773348,"web_url":"http://patchwork.ozlabs.org/comment/1773348/","msgid":"<86vakbnofy.fsf@arm.com>","list_archive_url":null,"date":"2017-09-22T08:10:41","subject":"Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf","submitter":{"id":7353,"url":"http://patchwork.ozlabs.org/api/people/7353/","name":"Marc Zyngier","email":"marc.zyngier@arm.com"},"content":"On Wed, Sep 20 2017 at 1:38:18 pm BST, Arvind Yadav wrote:\n> kasprintf() can fail here and we must check its return value.\n\nOr not. The use of these strings is purely cosmetic (they are only used\nto display various debug information), and printk is perfectly able to\nhandle a NULL string.\n\nRefusing to probe an essential piece of HW because a debug feature\nfailed seems at best counter-productive.\n\nThanks,\n\n\tM.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"k1VV2XCI\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz5lk3v4yz9s8J\n\tfor ;\n\tFri, 22 Sep 2017 18:11:14 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvJ3G-0002ha-NX; Fri, 22 Sep 2017 08:11:10 +0000","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]\n\thelo=foss.arm.com)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvJ3D-0002c4-43 for linux-arm-kernel@lists.infradead.org;\n\tFri, 22 Sep 2017 08:11:08 +0000","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BE41515A2;\n\tFri, 22 Sep 2017 01:10:45 -0700 (PDT)","from zomby-woof (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tC5EA13F58C; Fri, 22 Sep 2017 01:10:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References\n\t:In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=3KFxOFs69aHgGirq1RCyjZ8v+g44Kuj+Lv1f/Pi9fwA=;\n\tb=k1VV2XCIsb0QEB\n\te8INe/I/ARqdCPaoL7fRtnDfgbJTI2CWd5wekKeFKnweZlvi1HmuOKxekAwli/aExiLFi+T2ytBNM\n\tWVmKHgLrM8pivw9q2aBUFZXZL0/2LBu7HE3R5YCmEynr0Ts5nUewpgoyDI6/p6uvzg3Qvow1kdosd\n\tXpT3rcYA9oEIAes3wJWMipDQMab54lhRczWvRDfcJ8SataO5xgw7JQshTOq7O+aI/bv+aiLn0Uzx/\n\t83z0uimBiWy6KQir4j3hljFIJnCiuj9fKVo97/Fqx8dFBY+CDnMpoWZ7fSlgU3+hppYlxmfAgJG14\n\txRuSVlPR1BY2GoHn+xjw==;","From":"Marc Zyngier ","To":"Arvind Yadav ","Subject":"Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf","In-Reply-To":"<1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com>\n\t(Arvind Yadav's message of \"Wed, 20 Sep 2017 13:38:18 +0530\")","Organization":"ARM Ltd","References":"<1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)","Date":"Fri, 22 Sep 2017 09:10:41 +0100","Message-ID":"<86vakbnofy.fsf@arm.com>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_011107_183572_963C09CA ","X-CRM114-Status":"UNSURE ( 5.08 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [217.140.101.70 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jason@lakedaemon.net, linux-kernel@vger.kernel.org, vz@mleia.com,\n\tslemieux.tyco@gmail.com, tglx@linutronix.de,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773379,"web_url":"http://patchwork.ozlabs.org/comment/1773379/","msgid":"","list_archive_url":null,"date":"2017-09-22T08:57:06","subject":"Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf","submitter":{"id":69434,"url":"http://patchwork.ozlabs.org/api/people/69434/","name":"Arvind Yadav","email":"arvind.yadav.cs@gmail.com"},"content":"Hi Marc,\n\nOn Friday 22 September 2017 01:40 PM, Marc Zyngier wrote:\n> On Wed, Sep 20 2017 at 1:38:18 pm BST, Arvind Yadav wrote:\n>> kasprintf() can fail here and we must check its return value.\n> Or not. The use of these strings is purely cosmetic (they are only used\n> to display various debug information), and printk is perfectly able to\n> handle a NULL string.\n>\n> Refusing to probe an essential piece of HW because a debug feature\n> failed seems at best counter-productive.\nYes, Your are right. Sorry for noise. :)\n> Thanks,\n>\n> \tM.\n~arvind","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"dhgkgiOx\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"U70QsqiH\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz6pQ3TKYz9sPm\n\tfor ;\n\tFri, 22 Sep 2017 18:58:34 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvJn3-0002ln-Ci; Fri, 22 Sep 2017 08:58:29 +0000","from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvJmx-0002e2-Bm for linux-arm-kernel@lists.infradead.org;\n\tFri, 22 Sep 2017 08:58:25 +0000","by mail-pf0-x244.google.com with SMTP id i23so220741pfi.2\n\tfor ;\n\tFri, 22 Sep 2017 01:58:02 -0700 (PDT)","from [10.17.129.40] ([223.31.70.102])\n\tby smtp.gmail.com with ESMTPSA id 4sm7613488pfs.1.2017.09.22.01.57.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 01:58:01 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=+M8EFbSaV7FN1MHYIX9ZBbEgRR+QlXY3jp6ncnMvA68=;\n\tb=dhgkgiOxv5mRecWEzJ6Q6dqrS\n\tiTXXf5UY2hRz4PxSuc8B1Yr3DAR+RgIros3DV31n3NBqzBUx1Cpyg1aiZ6xRhWYIHn3CS4jiMLgYZ\n\tPIrDFOv1+5873yfy5Er/EXZKXtOfh1vgLGBBjrxle9B/iSX53cZVRD4SHHYHdOhlpgKIM9Uxvt2y+\n\tZPedunKjxM0u2zFpGgXYPW5ACJMz3qCxqbdzyPnFCs1zT7njxZdw928BkFeeen8D+lgpdWOSMLCBY\n\tI4qRY+/Dvr7P70izeyJIbanVE3D2WG6pTKLjdQakRm5qhOcb6021Ppvw4J4K516T/V2Ln/sIBZLDB\n\t7uOG0dWxw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=sRsMncIJXKLD+SpIiZc7sBEHdDiuthHg4qsXvJKtl8s=;\n\tb=U70QsqiH1r0roX6y+pV8AuEYD1GDfeZEefSgEakBEIymblz+iFN2FJwuTEaTc1usW0\n\tnGBXZjtReZ+Wa5OU038WlLcKsMjBi0o3sFQPzOzSmXPIJyZPU2wkkjiVNY0z8JYWofw5\n\tqNqyZ0n3puJRVFC3r93dTYy91t/d/OR2Jl3ecEr4ERQCFsqBK0IgMrt+TRP7igwQCCyh\n\tathAOoEZI16Leh8ltjFVTaPHMEoNaqpsbU/xO2nlwhIEUXfvcpM12u7Npj39iFWi8y54\n\tqVyT0CMf/41Jgg+wWyPeTR5LhtQKI367uoJ3PgXfpL3RuGq+WyQVUvmLVdQ8k8Q8qWqv\n\tx+Rg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=sRsMncIJXKLD+SpIiZc7sBEHdDiuthHg4qsXvJKtl8s=;\n\tb=otDZlfpLmaQ/SjiR32i8JADnxpPeIDRVskVmv7ScGA+/b9EkY7JF5LVXPvMhLD0M6c\n\tJZA30EUSN97TjuKav0WSRHKksMeIbspOvOqkoszrDMg4v8DtxM8OZ7HAw1eBk6StwECb\n\tTeL06f4Fz1bZD1/eZuG82e2S1+NtrY7165keKkST8qdbFnrWSKs8Q4RU/P2Z+GonDqrb\n\tmbuMa1ro9PDvSEc+d/nHhT2NjK3mWOY5paXkOLj93fAiTsammCqipAobu+B6BfUdpERQ\n\tC+nmVwmrh+YR54BR3duWEw3+EeGWwE8WtkDMyvU6wqEFJ8PYlmR5GKDietw25cYaQ1aZ\n\t/Idw==","X-Gm-Message-State":"AHPjjUgrc4D4MdfAgVDaMAWo0l4KGE+HQ4UXodc1PFm6X+UJm84HbkFj\n\tMVQbs5xy7t4ranXY1UNt4itAu+Bq","X-Google-Smtp-Source":"AOwi7QCSh75qcWufOkOFJaRCAhZ6lw4jhDimSi1cg3AB/joypYM3+SJjVRgPlrczFrz/u63mk5JSWg==","X-Received":"by 10.84.252.144 with SMTP id y16mr8545099pll.113.1506070682115; \n\tFri, 22 Sep 2017 01:58:02 -0700 (PDT)","Subject":"Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf","To":"Marc Zyngier ","References":"<1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com>\n\t<86vakbnofy.fsf@arm.com>","From":"Arvind Yadav ","Message-ID":"","Date":"Fri, 22 Sep 2017 14:27:06 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.5.1","MIME-Version":"1.0","In-Reply-To":"<86vakbnofy.fsf@arm.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_015823_642363_BB77D73A ","X-CRM114-Status":"UNSURE ( 9.92 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (arvind.yadav.cs[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jason@lakedaemon.net, linux-kernel@vger.kernel.org, vz@mleia.com,\n\tslemieux.tyco@gmail.com, tglx@linutronix.de,\n\tlinux-arm-kernel@lists.infradead.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]