[{"id":1772391,"web_url":"http://patchwork.ozlabs.org/comment/1772391/","msgid":"","list_archive_url":null,"date":"2017-09-21T03:24:52","subject":"Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf","submitter":{"id":62738,"url":"http://patchwork.ozlabs.org/api/people/62738/","name":"Gregory Fong","email":"gregory.0xf0@gmail.com"},"content":"On Wed, Sep 20, 2017 at 12:13 AM, Arvind Yadav\n wrote:\n> devm_kasprintf() can fail here and we must check its return value.\n>\n> Signed-off-by: Arvind Yadav \n> ---\n> drivers/gpio/gpio-brcmstb.c | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c\n> index dd0308c..1227d6e 100644\n> --- a/drivers/gpio/gpio-brcmstb.c\n> +++ b/drivers/gpio/gpio-brcmstb.c\n> @@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)\n> gc->of_node = np;\n> gc->owner = THIS_MODULE;\n> gc->label = devm_kasprintf(dev, GFP_KERNEL, \"%pOF\", dev->of_node);\n> + if (!gc->label)\n> + goto fail;\n\nPlease also set err to -ENOMEM.\n\n> +\n> gc->base = gpio_base;\n> gc->of_gpio_n_cells = 2;\n> gc->of_xlate = brcmstb_gpio_of_xlate;\n> --\n> 1.9.1\n>\n\nThanks,\nGregory","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"QcZgYiGF\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jDKF3Eel\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyMT821vDz9sBZ\n\tfor ;\n\tThu, 21 Sep 2017 13:26:01 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dus7b-0006xN-5x; Thu, 21 Sep 2017 03:25:51 +0000","from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dus7W-0006qX-Qe for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 03:25:48 +0000","by mail-wr0-x243.google.com with SMTP id k20so2410360wre.1\n\tfor ;\n\tWed, 20 Sep 2017 20:25:24 -0700 (PDT)","by 10.28.175.197 with HTTP; Wed, 20 Sep 2017 20:24:52 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=KP2Hx2y4EoK4w9sZPBO1+kd/YxWzeeq8JVxltRerDaU=;\n\tb=QcZgYiGFU+G/MY\n\tDBdbs6zO3l+vrDC2FTorx1pMGrvteKVsFIN+5Kop/KK/A/rY2toh6U5o3Tdi3/rOyoHyRml2o6i5T\n\tRiZBs7CR7opJgHEDNZ3KhR9johKc+7cKC+INQ0k9f/Fxpw6Y1EsUFA2jvVamxW+1okSnOTo/2qK7O\n\tgmT0A2oFTA6jaTSDJ0VGR3PRmK1qmCzBnBbHE9VzPOqNdJCi5od69FuKeXEo+yoMLbsF80cUubKsy\n\t495FuHDq/dxzERO/xO/6xqdd1XvhmEW+g5/J3AAarSyRuE1KckY+Pmq6PCmdpBvyfk+pmbqnJ/Jri\n\tyP0j2O94rVh6qIIEcc2w==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4YkvEeEobi6Nf41Yr9GzUzMxFBMK/I6xU/F2qInjR2A=;\n\tb=jDKF3EelzmFBUf60F+oH7LZM+xgn41gdROLe1onoUekQpe8ZYp8gxX4wLm3afdG62j\n\tIqTLS4gHeQRm88pMGUcYwcLu0YlgxWc4plBb/Eg/6rTfi7h4Qw7nRe9T6cHb2JUIbHnR\n\thKLolVCUEvix08afi/DzUZmZgsWcfoQytRVao0th0mQrNqLj7o38Y1TVcOW6DsL1BLwF\n\thrXXnr9lCeelya7z12l85VWTqhLwjw8s159kaCXv1n84axPnz6gboVjA7EXZNFszRThD\n\teSpOPdh6Edrr6bp01Wn2S8HYkQrVYGK1r3PFoEaktTrdqAPZGNz/Gl61V0/NqPdhsCdy\n\tP38g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4YkvEeEobi6Nf41Yr9GzUzMxFBMK/I6xU/F2qInjR2A=;\n\tb=pMgtMQy/IkPCU58P4gqCxf2FJXIZonOD0kLjL1RikBmp8j38gM0xpVclxfY7IoZO+q\n\tSLJA6+YPicdrdPf0YcJWnhWvs3UdfFEZCsf7fWmS716TESiIQ18crMyw/uvdzNugQ057\n\tRgbP9cGkxcXstA8wZ7XVRQCI9svpzyGTuleJnuidcGcgxjGF5FZdqCWMdBrc5WL5ael8\n\tSnBGxUhMIeS5KyRN9/kcmnZRPWwmXCSS+ZxvHS1ePevU0HpoZ9vVhzYE2cC6Yj0k9oBk\n\tuqAlA1YXpFt/e+FpKvhZhHgs3Rg3RaJnfTwce9uMMWvgl6ShB/UEOwkoeAMWxQmlSDS/\n\t1ycQ==","X-Gm-Message-State":"AHPjjUjUq9q6EpjlLlfQS9LaaFP1jCF8TXJN7JeGeGw77K1qDwUoLb5B\n\tJX+QwhM0HZTcKKnGEHMduFNcJRm6qgALLR7M0P4=","X-Google-Smtp-Source":"AOwi7QAewEPpcsm778csWz6qA6GqKJ9fBhJgz1JqUWz/bF6hCWmrWHCqTM2sK8kYv0r9W4jRbIkDRvuZdiU2SAMLYF8=","X-Received":"by 10.223.165.29 with SMTP id i29mr499525wrb.163.1505964323111; \n\tWed, 20 Sep 2017 20:25:23 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com>","References":"<1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com>\n\t<1505891589-6632-2-git-send-email-arvind.yadav.cs@gmail.com>","From":"Gregory Fong ","Date":"Wed, 20 Sep 2017 20:24:52 -0700","Message-ID":"","Subject":"Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf","To":"Arvind Yadav ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_202547_156658_A8803615 ","X-CRM114-Status":"GOOD ( 10.33 )","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (gregory.0xf0[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (gregory.0xf0[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Florian Fainelli ,\n\tLinus Walleij ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tlinux-gpio@vger.kernel.org,\n\tbcm-kernel-feedback-list ,\n\tBrian Norris ,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1772759,"web_url":"http://patchwork.ozlabs.org/comment/1772759/","msgid":"","list_archive_url":null,"date":"2017-09-21T12:14:38","subject":"Re: [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Wed, Sep 20, 2017 at 9:13 AM, Arvind Yadav wrote:\n\n> devm_kasprintf() can fail here and we must check its return value.\n>\n> Signed-off-by: Arvind Yadav \n\nPatch applied.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"UV1g8LzS\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"F0fPfFUJ\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xybCZ4v5Zz9t43\n\tfor ;\n\tThu, 21 Sep 2017 22:15:06 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv0Nj-00074s-Kx; Thu, 21 Sep 2017 12:15:03 +0000","from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv0Nf-0006yX-Nd for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 12:15:01 +0000","by mail-io0-x22b.google.com with SMTP id l15so10303757iol.8\n\tfor ;\n\tThu, 21 Sep 2017 05:14:39 -0700 (PDT)","by 10.79.164.78 with HTTP; Thu, 21 Sep 2017 05:14:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=204r0ltj4KBZj/PGEbfZnkh2WWfU5VCJADiE9ygdjCU=;\n\tb=UV1g8LzS9gKJIj\n\t9oH8fMsYi+/4QpM53t5Ku157MpCFZTpwXApmKShF4/MhoStKGhM78MbkSWDqOq7sRIxe4uIwjzfG2\n\tscpjJP4XOg2Ts4gjDUSEwus+YGlXkGeR+z0EQDyZxelqrpcZC0xX8COj5fZbZFMQMy2vkzeI9E6XI\n\twfBE1hR+ISmhwDc4ghOq6D84yXLc5/QWw2kZMiZJP1oPTl6W3bai15hCRH5HTFu0HBvJ7bTGrV/nx\n\t5rd9Zm7Xqb2w6BgQ4Z4ZaUMlCclEELhtUr8IltVr2BvWZho/H6QPj79vnOxLrpc2OUN3pwGv0FuAL\n\tPmIt6t9uZRzCWQL/gZxw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=SAsOXdIASC1TCLEuq5OuJURhETDQ7iwJUNo+N8Zdrk8=;\n\tb=F0fPfFUJhu20hN4dTlUiPNYmGgvrbEUDG130j1PBeKC9QPGZidlbInt/tSr14eDSHs\n\tJv/LhdXJj2cqbBo/tWc67Q+hviPAobLx/jG20Hd+ppdcPALn9lqWq2a+EGprYmQL+rzD\n\tSHZ7rHGm9s5QGiOFLwXpfQuR2fb5964YluMqU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=SAsOXdIASC1TCLEuq5OuJURhETDQ7iwJUNo+N8Zdrk8=;\n\tb=FzET80Qu/pPlVdivkAklOYPvQGMl0NC+oYWHBVMCsrP5Brz+/OOHrePCx2jy+8vY0C\n\t3TNtmdyQir9FJICsCdzxMWHQpMJ4ClSzxb9HIfxMhyyWTybQLtCWyRANp95oU8NiTc2g\n\t27ITYoKNN7B1KTAk8aPrMhmX75AY0WKKYi7uCGMZotxjFTLHsM8xvINxS2XLLyNFJMIj\n\tduGUjkMPCbzLuLCFS5E2GK51fs3R9PKa+7KIyLmMiUnQ9nHeR/BLvtcQC47qYhRetUIA\n\t+46Jx4s9tE3QVf0nPRmN53CnilELAj+aEH42X5no9whWZ2yExr3m4lYtl01gD0cPscbM\n\tSI0w==","X-Gm-Message-State":"AHPjjUjL+boa+Gd7FLiWZFbFJu5IYRuCM4O7wTNdjcAW+4RJixGTXzUX\n\tdAqpe5TM21MvDGjlpIxzZrlmnBTpt6TKmizd8u7r3g==","X-Google-Smtp-Source":"AOwi7QB6NKipJFVQ/CLEYX9YWqL88s4//TvKv1gMNjzZIbIR8DUn99sfAzOVgA+hs7aS2SbBey95oYnG4njWx9i+9Ec=","X-Received":"by 10.107.156.15 with SMTP id f15mr2208096ioe.226.1505996078842; \n\tThu, 21 Sep 2017 05:14:38 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com>","References":"<1505891589-6632-1-git-send-email-arvind.yadav.cs@gmail.com>\n\t<1505891589-6632-3-git-send-email-arvind.yadav.cs@gmail.com>","From":"Linus Walleij ","Date":"Thu, 21 Sep 2017 14:14:38 +0200","Message-ID":"","Subject":"Re: [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf","To":"Arvind Yadav ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_051459_894706_D0A28EDC ","X-CRM114-Status":"UNSURE ( 7.68 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:4001:c06:0:0:0:22b listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Florian Fainelli ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\tbcm-kernel-feedback-list ,\n\tGregory Fong ,\n\tBrian Norris ,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]