[{"id":1781718,"web_url":"http://patchwork.ozlabs.org/comment/1781718/","msgid":"","list_archive_url":null,"date":"2017-10-06T15:13:59","subject":"Re: [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc\n\tmachine","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 20 September 2017 at 08:01, Cédric Le Goater wrote:\n> Hello,\n>\n> This series adds a new Aspeed machine to emulate the BMC of a\n> Witherspoon system. It also extends the other Aspeed machines with I2C\n> devices and adds a simple model for the pca9552 LED blinker present on\n> the witherspoon board.\n>\n> Thanks,\n>\n> C.\n>\n> Changes since v1:\n>\n> - introduced smbus_eeprom_init_one()\n>\n> Cédric Le Goater (6):\n> aspeed: add support for the witherspoon-bmc board\n> aspeed: add an I2C RTC device to all machines\n> smbus: add a smbus_eeprom_init_one() routine\n> aspeed: Add EEPROM I2C devices\n> misc: add pca9552 LED blinker model\n> aspeed: add the pc9552 chips to the witherspoon machine\n\nHi -- I've made a couple of review comments and nothing else\nleapt out as obviously wrong, but I'm hoping that somebody more\nfamiliar with the aspeed devices will do review...\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"f2civAyO\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7tVv1pxRz9t4R\n\tfor ;\n\tSat, 7 Oct 2017 02:15:35 +1100 (AEDT)","from localhost ([::1]:45459 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e0ULd-00036P-9n\n\tfor incoming@patchwork.ozlabs.org; Fri, 06 Oct 2017 11:15:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38684)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e0UKU-0002SG-2T\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:14:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e0UKT-0006za-8j\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:14:22 -0400","from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:45121)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1e0UKT-0006yN-2B\n\tfor qemu-devel@nongnu.org; Fri, 06 Oct 2017 11:14:21 -0400","by mail-wm0-x22c.google.com with SMTP id q124so8251533wmb.0\n\tfor ; Fri, 06 Oct 2017 08:14:21 -0700 (PDT)","by 10.223.128.207 with HTTP; Fri, 6 Oct 2017 08:13:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=QNOPe2B7IUQItxU5UtV36Cq19+TuouDWT/GncXywSqY=;\n\tb=f2civAyOD5INLeMuWo3Axk2LFf2B84H0hW+z3wsEBi9Ri1uV9tnEmNEYB+6Rx9X/2W\n\tfpMbEJ02Q+cGu+nLX5qwR/j0R6Rhtw3ckqLMebaxm8/Vl0JzrEcaWPi/spAfruiuvgDd\n\tMiPLHWrij8xldUKVVF9U+qeW/DhfH5UZ8Jw4w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=QNOPe2B7IUQItxU5UtV36Cq19+TuouDWT/GncXywSqY=;\n\tb=PMtuquBvasBV5rstnyUYYq1gjiPl5Vkrk9BA+4sa7MlQNKFMCIH0sAVpuonHciVaRH\n\toAqtDSn5kE7x+MfRDwq5L09XckJ+yic1XQycmn7F2DRVUtG/WcAhCmExFUQTt96IlPiX\n\tFE94BI0h/OHiuRN2fjX/L5zWDTqXAFSSJO+mWstI57KljMSw/FQTb7eQTJGIMKue2QbN\n\tELdZFoO2XowSuRIp7De3mGNtkqaJN+i4MHWs/j472QrqN5pwTO216JWCPhwl0gQTNQxc\n\t2GrodnabpndRVZSDfuO23fL4QR7FBGOsUBRTNPxXDzucao+K5W+fPg2sXFthOznZNxkZ\n\tCfhg==","X-Gm-Message-State":"AMCzsaUn60K3jgWBk4OHuy1flobI0VEZD9X4/0sRJIO5/8r9Ty4U8fFW\n\tvaKmAWV5G+m8OJWzCgiBJ4LTcHjW3/gUKMt3mprS/A==","X-Google-Smtp-Source":"AOwi7QB3sj4fGG7tu47V9EBOuBe7ZSis7cWHi4SEqpaQnsQ5RbeHh2L8PSlV0fvubWpdbesF8bs02u86+JQjWijAnfI=","X-Received":"by 10.28.54.89 with SMTP id d86mr2004423wma.101.1507302860094;\n\tFri, 06 Oct 2017 08:14:20 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170920070135.31379-1-clg@kaod.org>","References":"<20170920070135.31379-1-clg@kaod.org>","From":"Peter Maydell ","Date":"Fri, 6 Oct 2017 16:13:59 +0100","Message-ID":"","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22c","Subject":"Re: [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc\n\tmachine","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1782152,"web_url":"http://patchwork.ozlabs.org/comment/1782152/","msgid":"<7fb02e55-68dc-8509-7c2b-d049eca19d9e@kaod.org>","list_archive_url":null,"date":"2017-10-07T16:44:28","subject":"Re: [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc\n\tmachine","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 10/06/2017 05:13 PM, Peter Maydell wrote:\n> On 20 September 2017 at 08:01, Cédric Le Goater wrote:\n>> Hello,\n>>\n>> This series adds a new Aspeed machine to emulate the BMC of a\n>> Witherspoon system. It also extends the other Aspeed machines with I2C\n>> devices and adds a simple model for the pca9552 LED blinker present on\n>> the witherspoon board.\n>>\n>> Thanks,\n>>\n>> C.\n>>\n>> Changes since v1:\n>>\n>> - introduced smbus_eeprom_init_one()\n>>\n>> Cédric Le Goater (6):\n>> aspeed: add support for the witherspoon-bmc board\n>> aspeed: add an I2C RTC device to all machines\n>> smbus: add a smbus_eeprom_init_one() routine\n>> aspeed: Add EEPROM I2C devices\n>> misc: add pca9552 LED blinker model\n>> aspeed: add the pc9552 chips to the witherspoon machine\n> \n> Hi -- I've made a couple of review comments and nothing else\n> leapt out as obviously wrong, but I'm hoping that somebody more\n> familiar with the aspeed devices will do review...\n\nJoel, \n\nNow that we have updated the DTs, could you please take a look \nto make sure that the I2C busses in the models have devices \nwhich makes sense with the real boards.\n\nThanks,\n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8XRy67zzz9t6W\n\tfor ;\n\tSun, 8 Oct 2017 03:45:18 +1100 (AEDT)","from localhost ([::1]:50416 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e0sE0-0008JV-Se\n\tfor incoming@patchwork.ozlabs.org; Sat, 07 Oct 2017 12:45:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42192)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e0sDO-0008IM-Fy\n\tfor qemu-devel@nongnu.org; Sat, 07 Oct 2017 12:44:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e0sDL-0005a8-Cr\n\tfor qemu-devel@nongnu.org; Sat, 07 Oct 2017 12:44:38 -0400","from 10.mo177.mail-out.ovh.net ([46.105.73.133]:32980)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e0sDL-0005Zi-6U\n\tfor qemu-devel@nongnu.org; Sat, 07 Oct 2017 12:44:35 -0400","from player779.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo177.mail-out.ovh.net (Postfix) with ESMTP id D314F7CD93\n\tfor ; Sat, 7 Oct 2017 18:44:33 +0200 (CEST)","from zorba.kaod.org (i15-les03-th2-31-37-69-229.sfr.lns.abo.bbox.fr\n\t[31.37.69.229]) (Authenticated sender: postmaster@kaod.org)\n\tby player779.ha.ovh.net (Postfix) with ESMTPSA id 573B77C0082;\n\tSat, 7 Oct 2017 18:44:28 +0200 (CEST)"],"To":"Peter Maydell ","References":"<20170920070135.31379-1-clg@kaod.org>\n\t","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<7fb02e55-68dc-8509-7c2b-d049eca19d9e@kaod.org>","Date":"Sat, 7 Oct 2017 18:44:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"320037050905562052","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrleehgddutdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.73.133","Subject":"Re: [Qemu-devel] [PATCH v2 0/6] aspeed: add a witherspoon-bmc\n\tmachine","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Andrew Jeffery , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?b?w6k=?= , qemu-arm ,\n\tQEMU Developers , \tJoel Stanley ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]