[{"id":1771463,"web_url":"http://patchwork.ozlabs.org/comment/1771463/","msgid":"<20170919.163253.740450667943070639.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T23:32:53","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Dumazet <edumazet@google.com>\nDate: Tue, 19 Sep 2017 16:27:02 -0700\n\n> When rate of netns creation/deletion is high enough,\n> we observe softlockups in cleanup_net() caused by huge list\n> of netns and way too many rcu_barrier() calls.\n> \n> This patch series does some optimizations in kobject,\n> and add batching to tunnels so that netns dismantles are\n> less costly.\n ...\n\nSeries applied, thanks Eric.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxfLd34Rmz9sPr\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 09:32:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751367AbdISXcz (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 19 Sep 2017 19:32:55 -0400","from shards.monkeyblade.net ([184.105.139.130]:51110 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751309AbdISXcy (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 19 Sep 2017 19:32:54 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 16979102CDABA;\n\tTue, 19 Sep 2017 16:32:54 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 16:32:53 -0700 (PDT)","Message-Id":"<20170919.163253.740450667943070639.davem@davemloft.net>","To":"edumazet@google.com","Cc":"netdev@vger.kernel.org, ebiederm@xmission.com, eric.dumazet@gmail.com","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<20170919232709.14690-1-edumazet@google.com>","References":"<20170919232709.14690-1-edumazet@google.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 16:32:54 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775383,"web_url":"http://patchwork.ozlabs.org/comment/1775383/","msgid":"<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>","list_archive_url":null,"date":"2017-09-26T11:21:08","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 20/09/2017 2:27 AM, Eric Dumazet wrote:\n> When rate of netns creation/deletion is high enough,\n> we observe softlockups in cleanup_net() caused by huge list\n> of netns and way too many rcu_barrier() calls.\n> \n> This patch series does some optimizations in kobject,\n> and add batching to tunnels so that netns dismantles are\n> less costly.\n> \n> IPv6 addrlabels also get a per netns list, and tcp_metrics\n> also benefit from batch flushing.\n> \n> This gives me one order of magnitude gain.\n> (~50 ms -> ~5 ms for one netns create/delete pair)\n> \n...\n> \n> Eric Dumazet (7):\n>    kobject: add kobject_uevent_net_broadcast()\n>    kobject: copy env blob in one go\n>    kobject: factorize skb setup in kobject_uevent_net_broadcast()\n>    ipv6: addrlabel: per netns list\n>    tcp: batch tcp_net_metrics_exit\n>    ipv6: speedup ipv6 tunnels dismantle\n>    ipv4: speedup ipv6 tunnels dismantle\n> \n>   include/net/ip_tunnels.h |  3 +-\n>   include/net/netns/ipv6.h |  5 +++\n>   lib/kobject_uevent.c     | 94 ++++++++++++++++++++++++++----------------------\n>   net/ipv4/ip_gre.c        | 22 +++++-------\n>   net/ipv4/ip_tunnel.c     | 12 +++++--\n>   net/ipv4/ip_vti.c        |  7 ++--\n>   net/ipv4/ipip.c          |  7 ++--\n>   net/ipv4/tcp_metrics.c   | 14 +++++---\n>   net/ipv6/addrlabel.c     | 81 ++++++++++++++++-------------------------\n>   net/ipv6/ip6_gre.c       |  8 +++--\n>   net/ipv6/ip6_tunnel.c    | 20 ++++++-----\n>   net/ipv6/ip6_vti.c       | 23 +++++++-----\n>   net/ipv6/sit.c           |  9 +++--\n>   13 files changed, 157 insertions(+), 148 deletions(-)\n> \n\nHi Eric,\n\nWe see a regression introduced in this series, specifically in the \npatches touching lib/kobject_uevent.c.\nWe tried to figure out what is wrong there, but couldn't point it out.\n\nBug is that mlx4 driver restart fails, because mlx4_core is still in use.\nAccording to module dependencies, both mlx4_en and mlx4_ib should have \nbeen unloaded at this point\nPlease see log below.\n\nThis looks to be some kind of a race, as the repro is not deterministic.\nProbably the en/ib modules are now mistakenly reloaded.\n\nAny idea what could this be?\n\nRegards,\nTariq\n\n\n[root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\nUnloading HCA driver:                                      [  OK  ]\n[root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd start\nLoading HCA driver and Access Layer:                       [  OK  ]\n[root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\nUnloading mlx4_core                                        [FAILED]\nrmmod: ERROR: Module mlx4_core is in use","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"qpjZjjV3\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1dnC70hRz9tXP\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 26 Sep 2017 21:21:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1030344AbdIZLVS (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 07:21:18 -0400","from mail-db5eur01on0067.outbound.protection.outlook.com\n\t([104.47.2.67]:22422\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1030323AbdIZLVP (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 07:21:15 -0400","from [10.8.2.253] (193.47.165.251) by\n\tAM4PR05MB1794.eurprd05.prod.outlook.com (2a01:111:e400:7a74::13) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tTue, 26 Sep 2017 11:21:12 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=wVNFPPRCLNKSiUCGmwTXpjUyNyEvomVgdgUGRozlFXM=;\n\tb=qpjZjjV3PmOqNRi0p9NE+KhywqDfGS14OhxUFv96vmUTGX6Yvu0tI21twqbXASfQdgHGY4CHySTVbyRaR8mo/xMpFO1wyZUGJCAKBctoZOK3JvKikzrQgr+0Kk4QUNFs2ZaSDYhdpNnpE96lXAb3x+CGzMxS/jokyNolGpeYq0c=","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Eric Dumazet <edumazet@google.com>,\n\t\"David S . Miller\" <davem@davemloft.net>","Cc":"netdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","References":"<20170919232709.14690-1-edumazet@google.com>","From":"Tariq Toukan <tariqt@mellanox.com>","Message-ID":"<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>","Date":"Tue, 26 Sep 2017 14:21:08 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919232709.14690-1-edumazet@google.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"AM5PR0602CA0014.eurprd06.prod.outlook.com\n\t(2603:10a6:203:a3::24) To AM4PR05MB1794.eurprd05.prod.outlook.com\n\t(2a01:111:e400:7a74::13)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"eccf7956-5a12-42db-83df-08d504d0b22b","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:AM4PR05MB1794; ","X-Microsoft-Exchange-Diagnostics":["1; AM4PR05MB1794;\n\t3:ti0/C7M6ZCtformZSGwuKBI5wGLTlMrAhbMrAuCnoHKz2+AArhA7inAkXPEPxZv2bXjTYuCa6TQjzghpyxxA3yagrdgDrob/V0EOvl44WhVkFqUdgt5nLgl+wJ6N8kP3Y79l4vTELBhQCeFnn/9GIj25CmVCLeoE4KjeQQpLPWP7qPnJBvITToJ4+1UZo1BTflJMaWw6auNEiU3uXz58sOE1bZ5P66erxm+AW6Ig+XefIq6fUgo6ZgJ7zlzTrz4W;\n\t25:vMy+zNI4sQAZBcMh3GI/6XqMPo3KZ6RaWkBbDp929jHLcSmHfHigmZdYj9Izu0zskvAYzKnIUvyqGmHxsyuYtVwFsqHwMNXp/X2YK1TKwbe9ous7HVDwC1Sd71M/h87ISs4tn1F7l0744xLzifvXFaxzODcT3RxpbHi7Za7JuWkJU+5VtNaT3GJPtpnxQ/Y5QPc8D2z4XBU5TrUzfTckj9n2Ku8FTP919uagUUyhrzEyrAAk3Jnig2/Z7nOKXaJQwQPGJ0TG2I8+HVVtuwztQdR3JUyWzHNkjfRrMpE//uxQVfl+frtqQuygd9gfCxOcvxe7Tz1mJAjH39RilFUEXQ==;\n\t31:sAcmNV87SVoXQ4tVFva01BKVJDdaIQKhDIqEQSchLuMbrju8ZaalbPw2U7RLy7DhTcYYjB4hyTxO/HCCx4/hyehIh2l5nL3KrX+yfgj1L1lWD6wt98ceT4tSJ3NjDZ6/dUXGtY7NYZcrAtNISrCSc2ZkzrTxdAXNkmSA8AF0LuW+iT8lsmAA3KHgDlPPwKtoq6VVi5UAKKPgyNNzmGgRwtyeYpc3NfuXJ664IBfJ35c=","1; AM4PR05MB1794;\n\t20:sZrw4go0eONIMv5R9rDpPnfP2qM9fU6F3bq8hbhyIZzz+ZTNjVnENZoy1g50tUN4HvSlHPzSs35lN5/LlHTM7/+dj/a9kGB1lE9vQh6Nddbm0ekD6UpG2aidKxA2gZOtO6229zjzUeXPESycAv1mH37xaiPxgglOr0BpIbGbnDYpkywwIbyIe0ivW3ojpy5ZMwU/gmTJVSIAm47eIu3qZTuwZfgCSwdbwVaglOa7ch5dtq/sF9/oPNd/QDpjgZub5KtZAo/rLAvEEMNMXt5idlcASgWvSVd7Yh65spliLq5e7gHCsR9P13SfWIYOgs1s1oT8UVTC+fIEm9JksZFfPRrCMT+5Sp3L8FTMOK1UTjPeihbOzoxaAOIRAuSM4ISGg/qiyUXp/Odzpx7ErFrdHqlXu9Au2Adaq1eYI/x2XE50IFAVMvUDx5rhZcjUXZ9gZoht7at4HsFVo9dOzbHEBoMBsgkfaJFi++KZhKuz+ohYUaSW3Dpx1Pz9o6I2yL1B;\n\t4:cufapHrEnFx/geH9SCics7u8uYa5DWFJsl+UXUOENMRu0XA5Yg9CvTMWDNc2AsCXuzKbqy65BtyAj7e3RNhv7uDOFzeScOmvPhfvqubvXE46WuiZlo1ZboZsra0LR0NrNS347V17628TYhwMJnqLouxMddFb3qL/x7HNeWab8/ngCCeBcPGroaH1NS2Mm3cbfGznEh8T42bM7goB1hggck8q/+hphttQu1UHxL4KlewESsuvFl5nXOSx7VywMadGL0Wfoo46xeRFtUNjkXpP+NBY8G/Zk+PRwyvt+Bk5f9g=","=?utf-8?q?1=3BAM4PR05MB1794=3B23=3Ab1Z8?=\n\t=?utf-8?q?otraU3fVtuEG8vSUH9BSki8qboDDArFZJ6BN645cRWwwrShBDvgOq41W?=\n\t=?utf-8?q?MtXRbvkxeo/7v0vYFx0K4Ilba8qh++pB77J/B93OEzfVcgjHwHGyEhjV?=\n\t=?utf-8?q?nOnHx2OkXTNERAkVYuKcvjojWrgq6oAPuhg+1GeB3jS0uRh7K+55KLVU?=\n\t=?utf-8?q?9ZGq9NO/34Li1NTRr/JnW/rJlTBW2KQxxNSS7sm2tyx7Tf4EWZbZqv3v?=\n\t=?utf-8?q?vQ/LTfqSB6e8L9jNqKh0x1v2pptxt+RDlIjcSLnCocusoIcJ8Bv1wyBj?=\n\t=?utf-8?q?/aq7oST1WIYxmXnLdVRGwS9C2ek74xbQS2icGTXpCxRdWdaKUu/Untk0?=\n\t=?utf-8?q?VrgMaT/XtOWRPx8Om4ey9fD/ZEaQ8Kow3ULDA1KA2KjRzwfryXs6qRxa?=\n\t=?utf-8?q?XHjkzK9DW16D4oC5pTXnIWhmyePLy2B0Pljtd0Ke1iKqJrhnpydAE25F?=\n\t=?utf-8?q?klXupNg/wG5vcr7kDKOpAyNKGpQnBObyj8o8kwQvFmje6rB69UUbJwjJ?=\n\t=?utf-8?q?+4bm2by2NXCidpndRkB28gZlYdc5kraXJTLhfoDDIvFonxhpKd10BmaI?=\n\t=?utf-8?q?MTLucE3+muaVVjGZ0d5xFwFdef9U5VEesGyMGEnyI6TW7zkg2cv8WGDa?=\n\t=?utf-8?q?sLcqbAQEwgOEUTNmVadrlfdNt8qcozfwgFLPi0cXyiMnrUX25j6p1JLk?=\n\t=?utf-8?q?YXIfUynABGPUS/9t/xOGTZODBsayshkvnSOCFPC/MxYIH3BRoyM2EvTa?=\n\t=?utf-8?q?OjDLqY/LmSJsghpY2Vl4cB8q9+7wXWF4EGGs3E6FHCg6de1SwTGrbkzS?=\n\t=?utf-8?q?Inuxp1/PVZ5+3uGZylrLATb+2Vt1xGv//k1FlHkNFUe68HAsftcebI3y?=\n\t=?utf-8?q?r4WixXRqlZ5jd+PP/Hm5+k3Jfs3/r8PRmSAu0zLrlOvUwbPpaSEKPCtk?=\n\t=?utf-8?q?j3Yf81LTwxdknPl97Z9BCNjxMyA/NBWFpPPc473/J7oCc89x+KFNauy1?=\n\t=?utf-8?q?wQLMQg3h9XJgS2zdnGSvOtdUpm+p5YCLOc1uy6lKfjKPDLbmnNXgJzPI?=\n\t=?utf-8?q?iCw530R9yCxEvPM9piaNa2aJ8/9QVhh/7BE9cCglrxp2FnLSzsw+ogVG?=\n\t=?utf-8?q?Uh+RgGmQ40tna1aFlLnp5LL6HXumEhhNHvuyDxD205Jcj6koEfU5Tor7?=\n\t=?utf-8?q?qJmqHCPYA1zRDlyspKpFiM5D7KcxXTZ177cY5tc5G0DSExpd4qSVlFzl?=\n\t=?utf-8?q?LHKnfdHo5RYP0ksyVsxQllrlj/MwcsfuhUgpzZYLZ14/E4B6lFxYzAyU?=\n\t=?utf-8?q?i71qsY8lEZhEvfUzDlQO5t52THTScH+b9ySec4wNOdiX6M6wvzaNdRd4?=\n\t=?utf-8?q?Q3FPVaGILfUFnxAutqjUpenJblSB/BPfuQWxlaRoDLc1ORDsdWN0d3Qj?=\n\t=?utf-8?q?tzCNq0ytMtUwXW7sxha5eVpR3arNTZw+eaLn10Jy+qbdsaUM5U6nu5Jd?=\n\t=?utf-8?q?Qwp0QowJHFeA1AdVCnJ5pZMkQMT5BgXX0utJQoTGC0xgazA=3D?=","1; AM4PR05MB1794;\n\t6:1cMnAITL9IldTZkT3GrZHBSp5NTS7aDpVm2MW+UDgtmvbmxRhZ7EdRura/ks+DDMtCg1ux6dafakBT773z/qTc0JC1UtefD/nsqboimBNZbNJrgWk2QIqMW+RKW7zTdjdsoSqoF+lVrKO/8lGO5hR5AoIoSt2p+5VX+jdKgmwKwMmnM96KOKrt4Qgq6P5MNHldPNQ36Q45uiHkhlF94HHLBzXPwI5UTFnCBRj6Dlf/CgRdj0dtNW3P05sr0uH8Ejjy0YI48m/nJHft/cA9NpsQoXcdQszGcBP9HGkGP0hvUXr1N0tTJWQkm76rFiYiB89fSRtYa3cJHlR2/x8ZBFng==;\n\t5:mGe0j9gSAfbQXtf2EmyqQh2AKZJllgVJIZPMXWbjbjREZPyy/ACww5BIj1fv+Q+Zva9uXDAVXM/7rTA2Gj9xTPW/JxQLWTw3lKmnnD7LfGRS7WJ/Y6mzvtHDfk+WYtffw9eC/bechA/LGAC3TkxGxQ==;\n\t24:6fRd0x8ltksB8j+cdkxDEB14j1Cz/nWO1LaRxH2RKaFhsHDEzK5kOQuixoLDjeHTJm7TIgm8aN/J/jmeL+AUp1Mb9oDc1/f1FEeXqXxrgBI=;\n\t7:m9fBH0wbftKCG0jLpKvcV/Uzgk//yaj7h16G4esHtXn8Nb7Dh3epE4KlpC7X3u/mJw0MSYV94jxeels91Wlp2yZSu1QngRwCtP/e1p3n92nGo5c+AbkWahde42JbRUjJYAZ4BVeiE3Vh192ppP5lyCgIcvpRnwsqe+OVKPb1Fy2o6vlxblovsBHNTZmmmETsYblw0DNc/0v+0JBJqEjDQ08kG8Fo/nXRKGI3XHCZ7dg="],"X-MS-TrafficTypeDiagnostic":"AM4PR05MB1794:","X-Exchange-Antispam-Report-Test":"UriScan:(190756311086443);","X-Microsoft-Antispam-PRVS":"<AM4PR05MB17943EEB4458BAFA09B1A770AE7B0@AM4PR05MB1794.eurprd05.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM4PR05MB1794; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM4PR05MB1794; ","X-Forefront-PRVS":"0442E569BC","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(6049001)(346002)(376002)(39860400002)(199003)(24454002)(189002)(377454003)(7736002)(65826007)(5660300001)(8676002)(107886003)(50466002)(230700001)(105586002)(2906002)(106356001)(3846002)(6116002)(81166006)(53546010)(8936002)(110136005)(54906003)(316002)(16526017)(31696002)(64126003)(16576012)(58126008)(97736004)(81156014)(54356999)(76176999)(101416001)(66066001)(68736007)(2950100002)(65806001)(65956001)(6486002)(77096006)(478600001)(53936002)(33646002)(31686004)(86362001)(4326008)(305945005)(6666003)(50986999)(25786009)(83506001)(189998001)(23676002)(6246003)(229853002)(36756003)(39060400002)(47776003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1794; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"26 Sep 2017 11:21:12.4197\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM4PR05MB1794","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775442,"web_url":"http://patchwork.ozlabs.org/comment/1775442/","msgid":"<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T12:51:16","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/people/13357/","name":"Eric Dumazet","email":"edumazet@google.com"},"content":"On Tue, Sep 26, 2017 at 4:21 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>\n>\n> Hi Eric,\n>\n> We see a regression introduced in this series, specifically in the patches\n> touching lib/kobject_uevent.c.\n> We tried to figure out what is wrong there, but couldn't point it out.\n>\n> Bug is that mlx4 driver restart fails, because mlx4_core is still in use.\n> According to module dependencies, both mlx4_en and mlx4_ib should have been\n> unloaded at this point\n> Please see log below.\n>\n> This looks to be some kind of a race, as the repro is not deterministic.\n> Probably the en/ib modules are now mistakenly reloaded.\n>\n> Any idea what could this be?\n>\n> Regards,\n> Tariq\n>\n>\n> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n> Unloading HCA driver:                                      [  OK  ]\n> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd start\n> Loading HCA driver and Access Layer:                       [  OK  ]\n> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n> Unloading mlx4_core                                        [FAILED]\n> rmmod: ERROR: Module mlx4_core is in use\n\nI have absolutely no idea. Please bisect.\n\nAre you really using netns in the first place ?","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Uyde3dKd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1gn5478Wz9tXn\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 26 Sep 2017 22:51:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S968823AbdIZMvT (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 08:51:19 -0400","from mail-yw0-f181.google.com ([209.85.161.181]:55059 \"EHLO\n\tmail-yw0-f181.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S966144AbdIZMvS (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 26 Sep 2017 08:51:18 -0400","by mail-yw0-f181.google.com with SMTP id w9so6965036ywi.11\n\tfor <netdev@vger.kernel.org>; Tue, 26 Sep 2017 05:51:17 -0700 (PDT)","by 10.37.219.131 with HTTP; Tue, 26 Sep 2017 05:51:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Tbe2Rag6+BxyO1j0Mi5CDN1p4eMQA+JeImbki6vlZa4=;\n\tb=Uyde3dKdJXxPqavUGNgNoE1lW1gdJoBzb9LCPb7WnP5nmw+7ouK+JN/CquOI32IGwv\n\tfVA38+ie5z3Qp3vq38Wmq8tPkx5Jjyw+QM877LZaE85trh/s+OmiWjMwlc6dkTF0xbzw\n\tT8FCDOZ5JgtmRNdrdfTc6JS1LofxFNfzBKIuFs98zcf8cXKF/c/tJTVCug9rPTXoYjWQ\n\tGsZvmJPZhE5ECn4eX50zEbbteGJ7ukjncWAggv7BT5FipBePKxP5qFXk4jRTTZMYCz9O\n\tZayekk5tZhmZkfDDDedTzDPtz/YNjX/hmyhesmpRDyovU3vTD/hYe9sGuITpy9y9VdrF\n\thVkQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Tbe2Rag6+BxyO1j0Mi5CDN1p4eMQA+JeImbki6vlZa4=;\n\tb=GGgth3EBOcO3LB5VbxISbjrMb7p7rkyw4eJDw0bShKVpWgnL/A454hoQaDo+t9mSte\n\tKGRKEGJCvlL/UvtAid1e7PT3jGT0sLY4ZF1MaTvr/4r6MOXI+Bs54783Bd3CkZKgpwf4\n\tli0JuI+NVOhXJIo3iSI+OrxDrlhWsgzjtIcc619SZLJILKN0EY0XBQAklN4aOjMFTJHe\n\tjeVD1vn5PCmAlCazNpqqmSVxFYh+gh7NuZon/eYWCD7y+OyuekwwFd8UB5Y52fs717MX\n\tGtvNPEX7V+5qzIw71AzvBqqpW4A4rApkN0QpcPlvUoRgqtr4qz+kcVLQ7/1vUoio/ixF\n\ts+bg==","X-Gm-Message-State":"AHPjjUgr8aRVFkSelMduEeoGEsmI9PkVzheterAaE6um8FMsTCT21il4\n\tucdiGNVdqpfEWdCHb5R1j9olNRrOb61up3XHNfkwKA==","X-Google-Smtp-Source":"AOwi7QBixTUL2FByf48mN5PdwRYbOlYr91C+IMPqfQE+q9YfCXkewirxv1YPYSElfLDT9+Sfr/NzarI4sZPY7Z7lroM=","X-Received":"by 10.129.165.66 with SMTP id c63mr6487246ywh.143.1506430277247; \n\tTue, 26 Sep 2017 05:51:17 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>","From":"Eric Dumazet <edumazet@google.com>","Date":"Tue, 26 Sep 2017 05:51:16 -0700","Message-ID":"<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Tariq Toukan <tariqt@mellanox.com>","Cc":"\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775612,"web_url":"http://patchwork.ozlabs.org/comment/1775612/","msgid":"<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>","list_archive_url":null,"date":"2017-09-26T15:04:24","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 26/09/2017 3:51 PM, Eric Dumazet wrote:\n> On Tue, Sep 26, 2017 at 4:21 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>>\n>> Hi Eric,\n>>\n>> We see a regression introduced in this series, specifically in the patches\n>> touching lib/kobject_uevent.c.\n>> We tried to figure out what is wrong there, but couldn't point it out.\n>>\n>> Bug is that mlx4 driver restart fails, because mlx4_core is still in use.\n>> According to module dependencies, both mlx4_en and mlx4_ib should have been\n>> unloaded at this point\n>> Please see log below.\n>>\n>> This looks to be some kind of a race, as the repro is not deterministic.\n>> Probably the en/ib modules are now mistakenly reloaded.\n>>\n>> Any idea what could this be?\n>>\n>> Regards,\n>> Tariq\n>>\n>>\n>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>> Unloading HCA driver:                                      [  OK  ]\n>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd start\n>> Loading HCA driver and Access Layer:                       [  OK  ]\n>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>> Unloading mlx4_core                                        [FAILED]\n>> rmmod: ERROR: Module mlx4_core is in use\n> I have absolutely no idea. Please bisect.\nWe previously saw a similar issue, that was reported in mailing list.\nDmitry Torokhov suggested the following fix:\nhttps://lkml.org/lkml/2017/9/12/523\n\nAnd indeed, it solved the issue.\n\nWe kept the suggested patch in our internal branch, and rebased.\nIssue appeared again once your series was accepted.\n\nBy bisecting, we see that the issue re-appears in this patch:\n4a336a23d619 kobject: copy env blob in one go\n\n>\n> Are you really using netns in the first place ?\nNo. But seems like it still affects the modules load/unload.\n\nRegards,\nTariq","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"QnouJ+H/\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1kky2rVZz9sP1\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 01:04:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S968799AbdIZPEk (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 11:04:40 -0400","from mail-db5eur01on0055.outbound.protection.outlook.com\n\t([104.47.2.55]:13131\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S967121AbdIZPEh (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 11:04:37 -0400","from [10.8.2.253] (193.47.165.251) by\n\tHE1PR05MB1802.eurprd05.prod.outlook.com (2a01:111:e400:7a28::16) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tTue, 26 Sep 2017 15:04:29 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=3IkTVkHPyOzGBFc+tmdUVWbu9yqEIQ/qhHfT6CyGaWE=;\n\tb=QnouJ+H/ttUPvh9gPJue4yoWJPkCILyhACLWGCombU+6fWG9PFVhkDkP80fthbWe3I57RM0bJDP9nZr4vdVjjF2Gyuq6G8J5sdjwcoDes6PSKBjSxcA7XfsB1yTmZPnOvaOFE4q1RkT7yDSyYHGjowEOGeMwHtLtArLNt2fmIaE=","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Eric Dumazet <edumazet@google.com>,\n\tDmitry Torokhov <dmitry.torokhov@gmail.com>","Cc":"\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>","From":"Tariq Toukan <tariqt@mellanox.com>","Message-ID":"<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>","Date":"Tue, 26 Sep 2017 18:04:24 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"DB6PR07CA0139.eurprd07.prod.outlook.com\n\t(2603:10a6:6:16::32) To HE1PR05MB1802.eurprd05.prod.outlook.com\n\t(2a01:111:e400:7a28::16)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"60f73392-a9cd-4dbc-f4d4-08d504efe501","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:HE1PR05MB1802; ","X-Microsoft-Exchange-Diagnostics":["1; HE1PR05MB1802;\n\t3:d/6wXeiWmcY4d7OWoTb94e/++0ybLrLj4rZ2hshiDFv5fFFsxeg5C4xbMwuWmp/W2hEppPHDMvIarTcttWDveWaL7sJFLaPSaLjLoRFJK1EXu0OIL8Q8GUdmlWu2FWuNJUK4GQSuZYXfChYdyX8gLefTadghBhh/3/tKc+BnGUd8TG/60MbiMuaGhQPw7GmGUorjoGV85Ir6+zUYDxbfR652BymUdrSOflk4vgsfUtqDH2fwOoYYjrPnIX4Qt1Ft;\n\t25:FWdTlfb1Fa6lk3rTUBJD+QO2s0BL1kM7Io3GnLHi3erRagtyeyAMIctvcXXLTcz+r6kcOaoQ+NuU/dVExvKK/97wm5kdkbIoYUtK/wJUkzmEECz/Mm37KZqVioukHBdR/zBFKookX0d+/ezSt6J24NmkI0LCXNYiOTBSdGTQipxXU/6UpAWhC4gboGCF8NXRbgOv6WfeKFCHi2Kk2wGTEGudfg6s886no6cv3X0xNv78lzPIaGLBzd65SRn75IJJl5iM4WaergXxfhQx0l2fxGfVnKyJ6JDoxD/DgC0LTqY+UL4IgD15uUWE8uMz2Bg0Ctp1Z33undvjnHOQNI3oUg==;\n\t31:Iken9nF3DW7lPpqOHZLB0mSYYeo6lS71vlb4meh6/SwIorigw1juYwi2a9g167ZHSRxgJywtzmx7QTPT/lX/Pevq8mOnt2Nb9yxYNk7MWGqxhQeL/Xb78d8A/ejg1Ds5Zl6PNPanbHtx2pHTezgZPjyUOKHQRVpDgUPImDLel9zRC9fFl8URAllKfvjBs91WvVaXEdysuoFiGglh3j4tvUU5E7ebglbzlDv7mruwp0A=","1; HE1PR05MB1802;\n\t20:tGiL0LiD7HY/sgCOitVUn+Car0OwaGcNN0B+BWPSYjgoRSfjwDnjW4QoiJjUbGiB/RDvItL54uOamXXqujtb6TMS1w6H77uGHZ3duEOBBKHy5iqWlePRawwEY/QtJqA7H+C8Itqtxp5Az6gfNh96hgtGF827MK/5gshx8peI4V/zBX8MEXHNLHsA8mWThZffdRmsDSu/SVVk14R9iIyiA9quwCAqeMO3Im5LmL5AJlc06gdQmhGsEIF3inJtzeEMhb4eSa+KduKJFsVqHf0l+YgKP7uq1/6nXu4RGaHafSbbHkIu/7BydkfvvKfO+kVYW3nqfLetOYU4Xg6mnuGV+ItIzdYKdMOAcA5PE4GsdhdvGzJxIfgywMzmKWFk0k5Lbr7K+65ZviwUTe8qW4en4EtdC2WlZTtlOyelbAtWiMcfhgvQXXpLmtVuW9ZQFZOqAlxbGpA8/MY0v+DOmC4AVrPhMSiEwoGYIjA6qXBb3hBZD5xdnJLqyu/yLUnJFqer;\n\t4:WGFWqDCeiqGIXXo58vmR+VmQm7JyclQDsFXPtZPsP4hwf+h59hrrbfX5pA1A5Y9JkUTfB17L56yd0q6Lc/+1gYjEC+pwWdciTtqIDyGBZRYJCtZdMdoaqP3ZZ4TQ/W718T9017jkPq2ULffGZVTrWN4bnbPtSO+m7TXnj6+35E3WxAJkPbEIQwMDjSR7vACK77Y2kPCPQ71LHFS6a+dBPq+z8hUiB+1ANbK/dwb8chkRe2nqdslQH7t/tBVVz0mA","=?utf-8?q?1=3BHE1PR05MB1802=3B23=3AwrWx?=\n\t=?utf-8?q?PtggkodrRWiS+KGy9CybW+sx3lNzEOC8soYzdeWCud0/i5/CzQN7q/7j?=\n\t=?utf-8?q?pqFLRlL3wmKomD4ZOo0X5IN43/zR3lcmURkM/8KUVXC+3wM5MdX7Ohug?=\n\t=?utf-8?q?a7+R7ciB8riChmbpegAanyqevqqdFE9v9Ql2i3eNOcg+EWGkrFDng24I?=\n\t=?utf-8?q?CMzdtxYDPLdN3CPtsKZTI12cgXlL+EKSQsymgNmfwkyeplKtFX6E8+lD?=\n\t=?utf-8?q?CGO2US0RrI7tI9c2OytqTBvxSXLVyo/KL0t5eh2fvXYN2K3yN9ZtfSeH?=\n\t=?utf-8?q?KhpgSXwlu0jTYQfCw+bcaQu6FxJsOpJ7XGLfJpipvnwHYYrlTfS0Cp72?=\n\t=?utf-8?q?QOUixqnz9y6xBcO73pUUejwZwxOKjlyuf5C9G4Mjilykxohp0ksRFn5l?=\n\t=?utf-8?q?hXrNY8bB4wBr3teC16EuhSHryVEmxL4aJn/9MV/lhnu4tG8msYtfnOKI?=\n\t=?utf-8?q?9nSpvqRlFRDmbxp3KSjcmlMGOjzKR90t1+8VCkPTTTTBnXqEhBlrCxL1?=\n\t=?utf-8?q?DaarLbEJHKxdiNk1T8W+rXkZIzILWV9BfetfPjR1blAQX2+2Rz7jHy91?=\n\t=?utf-8?q?xBEhREO7baysJVXuZ+GqrqzlD5Dth9AHkFbYgZtY5ZfYPZNLQzPN5L3y?=\n\t=?utf-8?q?B5fm27EnzmZ2nRGk7oFLt804A2hIK8aR7VWpCEagEmNc8E0X66k56yGZ?=\n\t=?utf-8?q?hB6IWSmwan46SLO2+G4dG10wRDSVQQCiyHWAxevTzz3KEWTH5Du+NWF6?=\n\t=?utf-8?q?f32bDT5a1lrq1g8orpMJU6FNu6b7b1rFyC3gx2o/UWTGXDMJZzWkj0JP?=\n\t=?utf-8?q?znJ+l1BTRF1YerViY+JVacy7CNU71wRziAHSpkt9hG5Ya4O+EOWtcQGM?=\n\t=?utf-8?q?kWpnEUVamymbaEEkV1KChaooWp2Oa6xy6nt7eTgMY4AtlWACcBfjBg8y?=\n\t=?utf-8?q?pEleNmKUhonCTs8Hmdxg9XhVqD0UOXV6crH9SuDwA8YlaV6eoHbf8Q02?=\n\t=?utf-8?q?bGFOVWSkCWfsZGgWNiHOUHdco6PCu3AQcUDmwrOf72K5/WjY8hW0aciz?=\n\t=?utf-8?q?D69kF+COw9ZDLJurINiIvvb+cllz4R4aZl20B2Tdz/IG1xVT7eVJ/VHd?=\n\t=?utf-8?q?74UPykBHnnugLrXm4see3cim0XY7uSN/yZs2ZVlK5/mmpdkL2j4hTwnz?=\n\t=?utf-8?q?FX6efZ2ft3GEXN7j1jMQVgMsgITfp3KEEq9vSd/4XSAXI8r5NBjSZve8?=\n\t=?utf-8?q?u66qYVh9DqUgTYcwmecd8SxzMpGc7s2Y0c+Z75TXfkcr9hJo62mgimAx?=\n\t=?utf-8?q?y3dhTGMnKlKmArjzqvO1Sy2aroIEqjN0Ieos2MN3cEBOx4mUUc/JjE7x?=\n\t=?utf-8?q?HPrXBKH/sEmh7is863adENBXmATH2SogpkiF5lc5bqzeKa3EDPAJffys?=\n\t=?utf-8?q?93zEXvsq9ResT2kXuXmNGBENU/z6pCkn8gzFbmxwoGAoMR/TEtVuRheo?=\n\t=?utf-8?q?eqCIZxlxhiAe0PZqLsX2uwNc9KLwz+QmkYWr/nXOo+Q4Fjs=3D?=","1; HE1PR05MB1802;\n\t6:Rs4qPJ8NqOqANFuzaVgAlY0ZLBpG4kjtMfHrIUxxiIVV13bu3MVAdq2Gs/ZtfbuGg9nhrhRCL83sjrono9sLdqVX6XveXxOPKV0tbNDBoPvqxYvXOdkpe7hROj0q1JGnvjUtCpFJRG3S01FV27PGJZ1K0smLSxGjbWqiVuWZEMBFX3QgJEJiKt0vkHEoEsFR7dqnUNcqS9qmf+uyDzhqKcWE7hbvriJMU7BKeNBAs182j5SNL6wAP4alf6+rV69niH0y0hJnTEdP8ALUiY58I/I6+PLImMfwvkkhhCjXlc5BtnjUzWZVKP99tNddi8rk1qSNa5yTh8wXfoQgynhpsQ==;\n\t5:1a2A/tV7wEfvKdQpfiVDKG8gaeULv7xnKAMV6zsb+4ictRK/8lyN57SnmMZK0MLmtKtBLzN5O/ia8TOx1xK05qk8QI/rJLMKsJg45jA6IM5a4u6fxP5yCqeRG7IQoJaNaZzoKXwl5nL+XzUOgVthlA==;\n\t24:HkupNiKk+3Uq0dw1hOf9Xe8Lb68OWVXsHJacyAI5BXnjxN0B2yagLbZnNBWIz8+agCn8EBdgn96MKipVRZ8cj2wgK+EMiWVuEiJ4mZFdu/w=;\n\t7:bFpSswS/Utqk2wbmAmtNMnKUDv77Lv/+Hwh4Le9ivLO2rcFtYVZi4ldHAuyIPrwhXgy/vW9fr79gwzOXt6tllsAQ80nPziSPofCbVUn93zEQ+LLZZizLfw3gU6XK2+E1Ji5Iy5LFjfF323PG6MC10KmTa0Sti5WNlioCtYKk9hdQmn+GaZjuhNLYTmzfhA/8DNq0QgxsfgYfyuQ+DcWb9II9D8LtHxfkXQfQvdZ/u7k="],"X-MS-TrafficTypeDiagnostic":"HE1PR05MB1802:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<HE1PR05MB18025076BF82AC0A1ED9505CAE7B0@HE1PR05MB1802.eurprd05.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR05MB1802; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR05MB1802; ","X-Forefront-PRVS":"0442E569BC","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(6049001)(376002)(346002)(24454002)(377454003)(189002)(199003)(65956001)(8676002)(6486002)(77096006)(81156014)(31686004)(4326008)(229853002)(31696002)(101416001)(3846002)(86362001)(76176999)(6116002)(50466002)(54356999)(5660300001)(23676002)(50986999)(47776003)(64126003)(230700001)(65826007)(6246003)(107886003)(33646002)(189998001)(105586002)(36756003)(53546010)(65806001)(66066001)(2950100002)(25786009)(39060400002)(53936002)(8936002)(68736007)(6306002)(97736004)(16576012)(478600001)(58126008)(81166006)(110136005)(966005)(316002)(7736002)(305945005)(2906002)(83506001)(6666003)(54906003)(106356001)(16526017);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1802; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"26 Sep 2017 15:04:29.8597\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"HE1PR05MB1802","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775622,"web_url":"http://patchwork.ozlabs.org/comment/1775622/","msgid":"<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T15:13:21","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/people/13357/","name":"Eric Dumazet","email":"edumazet@google.com"},"content":"On Tue, Sep 26, 2017 at 8:04 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>\n>\n> On 26/09/2017 3:51 PM, Eric Dumazet wrote:\n>>\n>> On Tue, Sep 26, 2017 at 4:21 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>>>\n>>>\n>>> Hi Eric,\n>>>\n>>> We see a regression introduced in this series, specifically in the\n>>> patches\n>>> touching lib/kobject_uevent.c.\n>>> We tried to figure out what is wrong there, but couldn't point it out.\n>>>\n>>> Bug is that mlx4 driver restart fails, because mlx4_core is still in use.\n>>> According to module dependencies, both mlx4_en and mlx4_ib should have\n>>> been\n>>> unloaded at this point\n>>> Please see log below.\n>>>\n>>> This looks to be some kind of a race, as the repro is not deterministic.\n>>> Probably the en/ib modules are now mistakenly reloaded.\n>>>\n>>> Any idea what could this be?\n>>>\n>>> Regards,\n>>> Tariq\n>>>\n>>>\n>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>>> Unloading HCA driver:                                      [  OK  ]\n>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd start\n>>> Loading HCA driver and Access Layer:                       [  OK  ]\n>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>>> Unloading mlx4_core                                        [FAILED]\n>>> rmmod: ERROR: Module mlx4_core is in use\n>>\n>> I have absolutely no idea. Please bisect.\n>\n> We previously saw a similar issue, that was reported in mailing list.\n> Dmitry Torokhov suggested the following fix:\n> https://lkml.org/lkml/2017/9/12/523\n>\n> And indeed, it solved the issue.\n>\n> We kept the suggested patch in our internal branch, and rebased.\n> Issue appeared again once your series was accepted.\n>\n> By bisecting, we see that the issue re-appears in this patch:\n> 4a336a23d619 kobject: copy env blob in one go\n>\n>>\n>> Are you really using netns in the first place ?\n>\n> No. But seems like it still affects the modules load/unload.\n>\n> Regards,\n> Tariq\n\nAh this makes sense now.\n\nDmitry Torokhov hack breaks the assumption I used in my patch.\n\nSince it is not upstream yet, I believe that it will need more work\nbefore being in a proper state.\n\nThanks.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"HajioR0N\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1kx33d3Vz9t3x\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 01:13:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S969700AbdIZPN0 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 11:13:26 -0400","from mail-yw0-f175.google.com ([209.85.161.175]:44000 \"EHLO\n\tmail-yw0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S969699AbdIZPNW (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 26 Sep 2017 11:13:22 -0400","by mail-yw0-f175.google.com with SMTP id s62so7294500ywg.0\n\tfor <netdev@vger.kernel.org>; Tue, 26 Sep 2017 08:13:22 -0700 (PDT)","by 10.37.219.131 with HTTP; Tue, 26 Sep 2017 08:13:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=dAZLzU208aNyZNIWaJFf66hBRZifNicaHLVd7HftqRU=;\n\tb=HajioR0NSwAS38EirbMPbGa214Sk6cEV4O8cB+rAuvPBZpzqDzSsQ7AOsvEmllg6J5\n\tVNQPcyo3TU5zHCzB9FuEsWesFh16pIAo1l9C9ZUV2dL8QyoGye0PF1U5GM+3ZuLe8MeM\n\tiLtTsVr7+k3g5BLSQT/mXlYFmFvqNSPLNQHjS6TvB7KLwft1egEltOUugRyBpufg7udl\n\ta1BYKNAbnv7PFY4qM8ODOmPGqofE8ZGJ6KwasiqSb6rmbxb2GYxrHNC6HG6ShHD3AMxT\n\tVAxI0Sr1Wa1zg/duxEjAfVd+VZ12Gj+wd78Y7gBa2L24lsDo1yCYDPYaEr6Bc1g3irsK\n\tC5wQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=dAZLzU208aNyZNIWaJFf66hBRZifNicaHLVd7HftqRU=;\n\tb=Ot8Wbzl8v2U9jTWr5hFkq6aZ8Elx/CLCCsn8If4xBIj8fnogejvdu8H4uIgAGZ7Li7\n\tg2s4rCChvFX4q5liyTmcozh591GuHMgOZmttqtm5og/MMEXS+uXkhDcZfeLF5mIv4Un2\n\tvxshT3vYUEane+AUrK7A8zr4av87WGtF1y4KWodZCQFpQD4ZvqBXuUS1T8oJ4enO0bHL\n\tp2wm9Cd/qXsNz7tpdWen8BH+Yyj2E8IGs8llFzoyW6nf+0NEKd8KWUbqU5kYJ0Y6TPVm\n\tR2hqpVeYo6eWVk+PUYVyfPGfBOkzhqJsUZdT1nv7887l8WDxD1o5mMUhPayy7sSXSfEF\n\tKvwQ==","X-Gm-Message-State":"AHPjjUjWR+m/grhXFCP8KYs2XsLoDVJn4npEwfhL7I+ahvNfseRC+M1a\n\t/SQGWGIZWUQkS0t0rI9HPN+l9BwbalwL61lYBTd1draEtvw=","X-Google-Smtp-Source":"AOwi7QBeJ+pREC16hSTnpD7goOvmrGMKMfsxhZq4iP3tIaL7wa37U1AW3Bgd8/IFDcVO8LFkHfMDFqcLz3H4jmhAvow=","X-Received":"by 10.37.16.193 with SMTP id 184mr6533169ybq.178.1506438801872; \n\tTue, 26 Sep 2017 08:13:21 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>","From":"Eric Dumazet <edumazet@google.com>","Date":"Tue, 26 Sep 2017 08:13:21 -0700","Message-ID":"<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Tariq Toukan <tariqt@mellanox.com>","Cc":"Dmitry Torokhov <dmitry.torokhov@gmail.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775631,"web_url":"http://patchwork.ozlabs.org/comment/1775631/","msgid":"<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>","list_archive_url":null,"date":"2017-09-26T15:22:39","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"On September 26, 2017 8:13:21 AM PDT, Eric Dumazet <edumazet@google.com> wrote:\n>On Tue, Sep 26, 2017 at 8:04 AM, Tariq Toukan <tariqt@mellanox.com>\n>wrote:\n>>\n>>\n>> On 26/09/2017 3:51 PM, Eric Dumazet wrote:\n>>>\n>>> On Tue, Sep 26, 2017 at 4:21 AM, Tariq Toukan <tariqt@mellanox.com>\n>wrote:\n>>>>\n>>>>\n>>>> Hi Eric,\n>>>>\n>>>> We see a regression introduced in this series, specifically in the\n>>>> patches\n>>>> touching lib/kobject_uevent.c.\n>>>> We tried to figure out what is wrong there, but couldn't point it\n>out.\n>>>>\n>>>> Bug is that mlx4 driver restart fails, because mlx4_core is still\n>in use.\n>>>> According to module dependencies, both mlx4_en and mlx4_ib should\n>have\n>>>> been\n>>>> unloaded at this point\n>>>> Please see log below.\n>>>>\n>>>> This looks to be some kind of a race, as the repro is not\n>deterministic.\n>>>> Probably the en/ib modules are now mistakenly reloaded.\n>>>>\n>>>> Any idea what could this be?\n>>>>\n>>>> Regards,\n>>>> Tariq\n>>>>\n>>>>\n>>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>>>> Unloading HCA driver:                                      [  OK  ]\n>>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd start\n>>>> Loading HCA driver and Access Layer:                       [  OK  ]\n>>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>>>> Unloading mlx4_core                                        [FAILED]\n>>>> rmmod: ERROR: Module mlx4_core is in use\n>>>\n>>> I have absolutely no idea. Please bisect.\n>>\n>> We previously saw a similar issue, that was reported in mailing list.\n>> Dmitry Torokhov suggested the following fix:\n>> https://lkml.org/lkml/2017/9/12/523\n>>\n>> And indeed, it solved the issue.\n>>\n>> We kept the suggested patch in our internal branch, and rebased.\n>> Issue appeared again once your series was accepted.\n>>\n>> By bisecting, we see that the issue re-appears in this patch:\n>> 4a336a23d619 kobject: copy env blob in one go\n>>\n>>>\n>>> Are you really using netns in the first place ?\n>>\n>> No. But seems like it still affects the modules load/unload.\n>>\n>> Regards,\n>> Tariq\n>\n>Ah this makes sense now.\n>\n>Dmitry Torokhov hack breaks the assumption I used in my patch.\n>\n>Since it is not upstream yet, I believe that it will need more work\n>before being in a proper state.\n\nIt is in Greg's tree where all kobject patches should go through as far as I know.\n\n\nThanks.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DvfXNBBb\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1l7s62PJz9t3x\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 01:22:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S969770AbdIZPWs (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 11:22:48 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:36578 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S964826AbdIZPWq (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 26 Sep 2017 11:22:46 -0400","by mail-pg0-f65.google.com with SMTP id d8so6948568pgt.3\n\tfor <netdev@vger.kernel.org>; Tue, 26 Sep 2017 08:22:46 -0700 (PDT)","from ?IPv6:2607:fb90:a511:8414:280d:47d9:c19:fc9?\n\t([2607:fb90:a511:8414:280d:47d9:c19:fc9])\n\tby smtp.gmail.com with ESMTPSA id\n\tv70sm4985303pfa.173.2017.09.26.08.22.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 08:22:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:subject:to:cc:from:message-id;\n\tbh=hf0lmdjh24DevuVDtYjQaL8x7jvYFR2Dxvf7ZGh4jcg=;\n\tb=DvfXNBBbGJtUmVDmlCTLoQewM3jspcgI4U5PX0TbovczCB/ADr1BB8+kzka2rDww8/\n\txXguSpZWiYgTdp/cnmNfdLQNzpHefsjcrc/6dsj+o8t60XWdxKz9T6djlHkKgJ4qE4Qa\n\tiisiJraap56RBUaf7CuIa+pq5tFU53wvH1wsFhhgBixCdSBB/bVcoATCWVb4Jw+j8JdT\n\tCT3QMql9xS8yWI4D5lQ/NmggMYnFVPLs70i88EBrCm+W/zZj0jHmqAQRAjC9HjgN1MMN\n\txqApsPlnxypYzI1UPiVHPjB+qpGXoitLwxvfnjiXfzjJilekRI2OiyHPxtn1pG4eebIG\n\tYLYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:user-agent:in-reply-to:references\n\t:mime-version:content-transfer-encoding:subject:to:cc:from\n\t:message-id;\n\tbh=hf0lmdjh24DevuVDtYjQaL8x7jvYFR2Dxvf7ZGh4jcg=;\n\tb=GDmpJ1FYWB6zW1/XxPGJ7Vxk9VBEFG2Rs48s507Lw0djbYUtu+KS9wS863jGk239/h\n\tGViKVzfsFiRzhG4mmhOMjRGHjbdnHN2f+5PpIdyQeNzf5ckU9IZN7WTHJJbXhgo3axEu\n\tDJ1L9Uu6Y+/keB3kKEYzR2hWiiVuyaH9iJMWp8Y17KhydtMAGVq0WlNQJsXjkEO83ppX\n\tXjd1SqvCucMkj+tIBEDwv7eSWOqitgiw0R7jcuuCXpHL+sA1E+qf862T0rb1PzpNVll9\n\teBMGKrd0Xe32PpW5NEBy/qlIVaLJKnztTUJsFM+vQAZrC1WAvSxzqCj7jdLBKX7kufjb\n\tqoxQ==","X-Gm-Message-State":"AHPjjUj8fHRm92YEWPENjfrS5t+2K4fOtPHyafQ2it7nPT6mAcZcQMe/\n\tCtSyY9WxxW95rj1LUljBpKA=","X-Google-Smtp-Source":"AOwi7QBXNH2D32ofhsLvCrS0Y7A43Hm7pekb4FejkNvyO4FVPm3tOAR0YJKVM9uER3aCKJCy8Yp0lQ==","X-Received":"by 10.99.36.66 with SMTP id k63mr11604167pgk.223.1506439365777; \n\tTue, 26 Sep 2017 08:22:45 -0700 (PDT)","Date":"Tue, 26 Sep 2017 08:22:39 -0700","User-Agent":"K-9 Mail for Android","In-Reply-To":"<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Eric Dumazet <edumazet@google.com>, Tariq Toukan <tariqt@mellanox.com>","CC":"\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","From":"Dmitry Torokhov <dmitry.torokhov@gmail.com>","Message-ID":"<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775636,"web_url":"http://patchwork.ozlabs.org/comment/1775636/","msgid":"<bebe7824-1cd8-11d1-a8c7-1e2affadc687@mellanox.com>","list_archive_url":null,"date":"2017-09-26T15:26:41","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 26/09/2017 6:13 PM, Eric Dumazet wrote:\n> On Tue, Sep 26, 2017 at 8:04 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>>\n>> On 26/09/2017 3:51 PM, Eric Dumazet wrote:\n>>> On Tue, Sep 26, 2017 at 4:21 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>>>>\n>>>> Hi Eric,\n>>>>\n>>>> We see a regression introduced in this series, specifically in the\n>>>> patches\n>>>> touching lib/kobject_uevent.c.\n>>>> We tried to figure out what is wrong there, but couldn't point it out.\n>>>>\n>>>> Bug is that mlx4 driver restart fails, because mlx4_core is still in use.\n>>>> According to module dependencies, both mlx4_en and mlx4_ib should have\n>>>> been\n>>>> unloaded at this point\n>>>> Please see log below.\n>>>>\n>>>> This looks to be some kind of a race, as the repro is not deterministic.\n>>>> Probably the en/ib modules are now mistakenly reloaded.\n>>>>\n>>>> Any idea what could this be?\n>>>>\n>>>> Regards,\n>>>> Tariq\n>>>>\n>>>>\n>>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>>>> Unloading HCA driver:                                      [  OK  ]\n>>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd start\n>>>> Loading HCA driver and Access Layer:                       [  OK  ]\n>>>> [root@reg-l-vrt-41016-009 ~]# /etc/init.d/openibd stop\n>>>> Unloading mlx4_core                                        [FAILED]\n>>>> rmmod: ERROR: Module mlx4_core is in use\n>>> I have absolutely no idea. Please bisect.\n>> We previously saw a similar issue, that was reported in mailing list.\n>> Dmitry Torokhov suggested the following fix:\n>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%2Flkml%2F2017%2F9%2F12%2F523&data=02%7C01%7Ctariqt%40mellanox.com%7C4a275c766aeb4224376e08d504f12193%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636420356043309380&sdata=GGeDFkX277R%2BKShsUPsePoAD6p5yaO2v0CteABtCrcY%3D&reserved=0\n>>\n>> And indeed, it solved the issue.\n>>\n>> We kept the suggested patch in our internal branch, and rebased.\n>> Issue appeared again once your series was accepted.\n>>\n>> By bisecting, we see that the issue re-appears in this patch:\n>> 4a336a23d619 kobject: copy env blob in one go\n>>\n>>> Are you really using netns in the first place ?\n>> No. But seems like it still affects the modules load/unload.\n>>\n>> Regards,\n>> Tariq\n> Ah this makes sense now.\n>\n> Dmitry Torokhov hack breaks the assumption I used in my patch.\n>\n> Since it is not upstream yet, I believe that it will need more work\n> before being in a proper state.\n>\n> Thanks.\nI see. Thanks for the clarification.\nI guess we'll keep only one patch for now, until issues are resolved.\n\nRegards.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"M2sCRktz\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1lDc01ssz9sBd\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 01:26:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1031351AbdIZP0x (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 11:26:53 -0400","from mail-eopbgr20089.outbound.protection.outlook.com\n\t([40.107.2.89]:39397\n\t\"EHLO EUR02-VE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S934460AbdIZP0v (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 11:26:51 -0400","from [10.8.2.253] (193.47.165.251) by\n\tDB5PR05MB1799.eurprd05.prod.outlook.com (2a01:111:e400:5bc5::13) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tTue, 26 Sep 2017 15:26:46 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=ZE9JIcoiFY4SMwBqLI8zNaemA1zAPyhW/3djMS8dc7A=;\n\tb=M2sCRktz3M4i1Mxl4asrQfRbeETNSuxqqJvM+DEtdU8KOo14+g4VE6TGXr8a+4MUE5hj31sFlnlY3KczCqi1mmpiaQ74jYzcEboW2SncGQNA7kbXRmc5TStHv6MXe86I0N4UtQOGTVO9b66Y1MBTfr2znyGhOv/me5MEz9lN2S8=","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Eric Dumazet <edumazet@google.com>","Cc":"Dmitry Torokhov <dmitry.torokhov@gmail.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>","From":"Tariq Toukan <tariqt@mellanox.com>","Message-ID":"<bebe7824-1cd8-11d1-a8c7-1e2affadc687@mellanox.com>","Date":"Tue, 26 Sep 2017 18:26:41 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"HE1PR0402CA0026.eurprd04.prod.outlook.com\n\t(2603:10a6:7:7c::15) To DB5PR05MB1799.eurprd05.prod.outlook.com\n\t(2a01:111:e400:5bc5::13)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"5319e378-5595-48c7-b38e-08d504f300c4","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:DB5PR05MB1799; ","X-Microsoft-Exchange-Diagnostics":["1; DB5PR05MB1799;\n\t3:7cItFnAqqm1bti+60hsI67nVW7e7B9ehHCcdd85LN/RZB9tjSJc1ulLrwUppN4c851OCi5gBwKggupjjBN5gt35moZ8NAjyS/amVVeyGEMW9VXTLyk61uP6SubucJRsVQOZQyyx6BvImqyZoeK61Jl7SJywa5nfvuNoq5WT6137CGQVyz5B/BF7O0E2y8eet+OObKxp1Bneo6qkSm5r3+PrE2M+K2UHoi5ya17B88kMpQNhjFCxGeXLIzCYqxrgB;\n\t25:AkFAv8IxylVCdcUgzP0k5LC4o1BUFV5GuriG7KPiawB9eEDMIyDDVsNuwWrcYS2vZHMVnU3UDBsjmbGiW4c1rwxMLtsmQvdEfUUCC6+0L3P/XDN7yIhkYrkBwgpPjWBFLjFpP8cu+E3H6m8E3a18c6N/BxokO6FUVz7/hShiSGOqP9l4cMI7kqnD192RVAOyAwaJj9Il2Jz709pcC4mDzSl8hX5F86GHEd3Wfg9Bd1cLjr3zOWXpttUNx+2trMbdpfPziNeUS8QCdITQF/l72GxY+WPbm3dTW/t2+Ce0sgMu4xt88kqFRn2SkKd2R9qwd9rzEVS/dL46pXm1PSbuiw==;\n\t31:V6TxU9iK97cn4kbPfdlJXXjEyixaqWyVZNpXIXJcNyW1Jv/77WPhtuja1mj4QsR+NmT8j1wrSNQz/8mBenPaApWGgxxivjZNllOvzMz9aAD/UDkTj/GlfK3lrPcI20YjCKFat1sV4mP6OHkBINqRrQVpo5EhZqPBbGFAOXXCshXIZSizFogChrDkL9rD2Lw6TDIHcWYztC8bzEAsmPuRHLcJO3xscXM1AV53RI2NOE4=","1; DB5PR05MB1799;\n\t20:JM3xh8cxteUxepafLkPoryrZXHMOpURyTTuP9An6pS5oH556QCQKyU9jbUBxlAqTmacKq4VXuQ96cjbqN2BmYiph819Bazz2EP6U7V6PmprKEutKUKhT8DAP2htr1nHEumXJergns2orGfwbow0ZdE89z20AgH4oMDDf04UFloJDOWLPFGYeOyJm8s7D58OZTYGvnIMTpVb5Bu/rFzmVOfmUpLgaefMRQn+BihG3OTv5FOnwSUJTp4DpV/ewhUP9Jied/ylgu5uul6HYSdd7L/EMQN877fKULHpi6yYc2/W+hURZwVBftUmEAeohzruy99ybD/zAR+yQGfRaEVUEDNKqh1wWK5UFCvu8KUVecmr2bsUdlos4fIi80Gzig8PQUauK85aqJ4CZUYi6BYQns4KY1KPwtA4zshA6qJdw0nbvlxGsoM+cwyX9q2PdALaj2ps/2LtXZTvKFCQtKnZefdtFZfPs0tldxphBJqTfYc6AkUtSE3Z2cdc+0w9JBjVb;\n\t4:JIsGuxSCitLFLBOrBmyhj5V6OOPbB1a1q2fZfOvl5jI6qePxKojFg0z9qr2bTxZ0K3HvakcvKi7kbqyPrGhWHoOrpPD5RZ99D1WgS+ZfO7OO3EkpFHkERL6q0xqX92Q5ZkgAmQ23oPCRNuEIeJXIomCKl8uGVzeCO7zll1w9PZMh4mb29PfQFiIZFrdVHXSk/IiNQEPqkeFBujflgKYKemdjgXIupVOcCY2PqZJwlqWjUvJyi4PZt9Od8dBcDaubANAgMRYNhXGB3BS+MpdxSoUxg7U6msyiV0Yz2qzdozWEZE5NqBFlsgCdz8S2Y1j+/96n7f3FA+B11WWBNMENBA==","=?utf-8?q?1=3BDB5PR05MB1799=3B23=3AY7MR?=\n\t=?utf-8?q?o23grTQvf8ifivxIDxWATkxfss8qAoYJAbB/Ocb4mHNXmA1onQrjVLPG?=\n\t=?utf-8?q?33w8iA9WesIcX5amknXLP7hkZx0fNoyq6+cWN84/A1P2y2O5GGhfXxCg?=\n\t=?utf-8?q?tKrHnBQPahy7iKpZDozS07Bcp3hDqMX806PYR7N5fq2bRpysrln4yaqp?=\n\t=?utf-8?q?oiIQPO0qGTsW3pDO0NBwzK0ogn0svBoR3HqF4CBE+VRqjB0XcF13HZEO?=\n\t=?utf-8?q?+TWj+SpllSzRnLrKthGB0O2ZzgXRSIZlcbv5vVBjv85hx+FY5J5T6TEz?=\n\t=?utf-8?q?Ih/cEnHRSrbW/wJxQiZCKiLFCJfz9NmZi5yhXK+IrPhffcp4PkT3XC9W?=\n\t=?utf-8?q?yl1nrqyd7GeIg72hLvdJXiX+G0wV7cZLV6Q0//wocVps5Ym+8xeerirk?=\n\t=?utf-8?q?nxWyTBPmQXws0s517bjZlc79qbYn5NtDMjODLQDnlmHtu12VWmB/fiaH?=\n\t=?utf-8?q?CMnIy4QZduIA7SgzD4ZMTo4JsvhLKTLq0fIaKDua5sFrSk292+9/BWTD?=\n\t=?utf-8?q?8lDO5j2m4kmdALzVUZnoxzcsZuD/9N1nAaqs+bcdllpDFrptPZ30kGvM?=\n\t=?utf-8?q?0meo+SagpLbBkiS+f0763hFYOeSHXlcbi9IPo7A9XcEXSUSLN/4TyIe9?=\n\t=?utf-8?q?oS4gSpYr0afB1aLskpJnY+X62wGqDbnyAdmVKi35Py2sZchY5FfhqbSE?=\n\t=?utf-8?q?X9w3Zk4I97/GZE/xzmib3qREYN85g6kZX5xYcjSSJkUYFAeEQ3N29rBI?=\n\t=?utf-8?q?F2hFxG41U/aT2s6lCLmjjLrvI+/Jpv3pX8dJXVdF1TgQzKtKYY10Hhl5?=\n\t=?utf-8?q?TTaSgE62Z1a8OCWjDLhHv/rUIc+ZhnSsvyP5DqUcR5AyRW9237HLRYMw?=\n\t=?utf-8?q?cmPTNVrI0Fob8ipftJm5aOpohrBm3Cef60+9ggQMwkiLP/Qc8cRAVU7Y?=\n\t=?utf-8?q?squJXdrc+V6mddzRc6zW1iwB05qp85ey/gTun5oVCtZseWE2LwKh576U?=\n\t=?utf-8?q?kXf5iuDPZQhaUu10ruKhh4WHKaTd8+abiN9FK2ZAw/P+Ij2MfDbaRHJo?=\n\t=?utf-8?q?vzi0cTv0tET0+n1XbP1U965FxLq/c0t/UV97LQYh3VlD77u6wZLRg2wC?=\n\t=?utf-8?q?y2ufilvVpBVF/I8YAqofWsadB1mQWivF2pn+foiGvTRzbHHwbyWAI8H3?=\n\t=?utf-8?q?+e7XO63XbbMcl+QYzRDeI3VZM0XIzq2VVbEgFRqNF4IRXKyuIS1Cxkko?=\n\t=?utf-8?q?XUMWo8OHUO1XcUYL/VtyUykBNm4TRJCURNgP732UOdyAJOUwl9rfeSo/?=\n\t=?utf-8?q?Hn2RYcfJtueueNMD164JsoL483dMNq3D5N5qpeFgI0ULjDITsZzDEzXU?=\n\t=?utf-8?q?RqW+7sYqs/YmfzscdQEAy0wiyZaE5YqqbJUu09uT5jvPnW3EeZWXQBIo?=\n\t=?utf-8?q?7rBxIxj3LmvxuL6xKdR6qrqYfe0fktxzy/vjFWQHKrb0QUsdFO4WqcAt?=\n\t=?utf-8?q?WT5PRWPQtbt1N1jv9qBIlVkyNoNrHHwdo8rtVIThvSTaCLOquEEfcHpa?=\n\t=?utf-8?q?pEDARs2TGgXWr8NqMjcjD9SETjN4eq2t60RzUvGbuPFbGqWBqtzgzcIx?=\n\t=?utf-8?q?FQx55ShoDINoUGFHztS2FjIjjYVYzNnVj0+oRTrCaO2U9zzORoBC1RAy?=\n\t=?utf-8?q?nYdQTmU=3D?=","1; DB5PR05MB1799;\n\t6:udVnUPBDQ/cgUYqp7GjZfCg5B3Zk3166aTXC3aUzoaer05XSBy0f91vBdKvfXOiiK5FDfh3TdwBQn0EXsAUDg4+NJB0UJLAI3NcKdZRL7Guaa9RfvvYfTuk2R59BrkRCOxFRlR7anDr3VMY615TG6BYxEKkJ6KJ8qBga41m956dcJu7bNzJZjgTRJ22LgkXuAdny7nb6Ry8k3Eb+6N327kwIhv3qe6+LG33jUvzSOunULWnejlrnKHOjyZUgWyN8OxPHah4CsndsGe3KvN/Z4UkvyVG8egakp8TedDV6Zdx5gaoWM2zzr1dyvGj9TyrixVkDtSBYbUl4d/rnaOuQeg==;\n\t5:Jz/SCNl/77sKEMywkT7w7IPNP4Ut9BCg548W5vEhq3bqaHELLgAgIvk9oFNRKDxpyPUVUxp95ibeMqyyQ0xMlU8+ylwW1aqJ5ZigpraIVt/4GDPR+NVy0l76kwLvs2hiSIxx/y2kB2zK2a3xpp6ZRw==;\n\t24:ouJ/tlu9BJWExUUgYM63vGrZ2tpExvnfSugQV6AfUzKMOmgUki9eAVv85x0m8Tor3bhj3xKlPiTq4PLv9iOB72qNsVoB5VtmeC1wFm/K72U=;\n\t7:Gtsg3bbUT3hVWhr65rnKOuTUWt0+LRN2o6XiYcL3jE7PRLYU/7GVJ+YtJxFqhTAuLYXgWHRjTkVytIGpsEOL5XPoZxphdF2CccWEQC9w1ZeUJCnbPJV8ZcjPtFbSI12AnfWWfevId9l+RR5CPCJ+SFrzWNmxfZaRJjalUhLIdftA5zp/3wN/dfUrJ7r4kPBgJ1RR14y4gGEluiccueWp+2qOijpLB6We2N/b0cBOOPQ="],"X-MS-TrafficTypeDiagnostic":"DB5PR05MB1799:","X-Exchange-Antispam-Report-Test":"UriScan:(189930954265078)(45079756050767);","X-Microsoft-Antispam-PRVS":"<DB5PR05MB1799F1C0E23E57BCC31B3369AE7B0@DB5PR05MB1799.eurprd05.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB5PR05MB1799; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB5PR05MB1799; ","X-Forefront-PRVS":"0442E569BC","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(6049001)(376002)(346002)(39860400002)(199003)(377454003)(51914003)(24454002)(189002)(230700001)(66066001)(65806001)(2950100002)(81156014)(54356999)(50986999)(76176999)(47776003)(6916009)(106356001)(65956001)(6666003)(65826007)(81166006)(105586002)(5660300001)(6306002)(101416001)(39060400002)(93886005)(2906002)(54906003)(8676002)(6116002)(4326008)(23676002)(966005)(33646002)(6486002)(83506001)(77096006)(7736002)(305945005)(50466002)(68736007)(16526017)(575784001)(31696002)(25786009)(64126003)(16576012)(3846002)(316002)(31686004)(45080400002)(36756003)(53936002)(229853002)(86362001)(58126008)(8936002)(478600001)(97736004)(6246003)(53546010)(189998001)(107886003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1799; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"26 Sep 2017 15:26:46.2685\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB5PR05MB1799","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775640,"web_url":"http://patchwork.ozlabs.org/comment/1775640/","msgid":"<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T15:30:03","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/people/13357/","name":"Eric Dumazet","email":"edumazet@google.com"},"content":"On Tue, Sep 26, 2017 at 8:22 AM, Dmitry Torokhov\n<dmitry.torokhov@gmail.com> wrote:\n\n> It is in Greg's tree where all kobject patches should go through as far as I know.\n\nYes, I will fix this, adding a second memmove()","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Sb4c7CES\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1lJJ1BD9z9t3F\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 01:30:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S936599AbdIZPaG (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 11:30:06 -0400","from mail-yw0-f178.google.com ([209.85.161.178]:53345 \"EHLO\n\tmail-yw0-f178.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S934460AbdIZPaF (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 26 Sep 2017 11:30:05 -0400","by mail-yw0-f178.google.com with SMTP id x131so7326408ywa.10\n\tfor <netdev@vger.kernel.org>; Tue, 26 Sep 2017 08:30:05 -0700 (PDT)","by 10.37.219.131 with HTTP; Tue, 26 Sep 2017 08:30:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=A+8PPrtqvfARBd4eJBIxM2kaLlSEMraaOtoWWGCBP0Q=;\n\tb=Sb4c7CESj9YJDZ57psj9yPZfIWah/UrEe2E0kZFaZmSrTh2uqk6rNF9TvHu+ho3S9C\n\tT6zWiNNggGbIoe6WHWVD7ebGV7HjLHrqCZG0n40QkTZkuisrKdoveKblO1xnt/gNlTJJ\n\tyifpiLAMDor9cL3WL+yz2ykdoWUDjkPCV/gCciL5IxiPqofiah5EtpJEgf1plXddv0c4\n\titG7JwZ+9aZj0v1Tm07Jg0dwF1HLwfqAUIQT6q76WWXMJvbd+tuB/BOcrFDKaGoQ2cub\n\tzeO9txklCZcKSAqrdEh4CsRzwDQRhgi5el9ZKkZ/hlJsY+qwAX+bQr7/QABt+eNtdYci\n\tpARQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=A+8PPrtqvfARBd4eJBIxM2kaLlSEMraaOtoWWGCBP0Q=;\n\tb=GLSa9Qo8AH/b8yQRfmKFNoO8fEKvqbRCQEMVHSmSHo814KIi9S8OAFCO7xJCjE35I3\n\tA+hC7D6iZyVtS0B7sNrJLgdELU/o8AWSsehbKBCngzw5kShU1/VUPMMKogujY2zqaLTN\n\tBnuara8waqHB9AKHloL17GsDX3M0BLapcOfX8oYOZnyX80P1FMw5EGrX1RUdDRQFEL6D\n\tltBnIz143bflEL5kUtVwlou7VI9tPpjL9KNBf8gXSnI6rbLZnnygp69uWm/ya/dYc+k0\n\tXkDLafPcsW27371VPiRP53CNM1OsndEOFu8n8hPvT29VwmvPZGIEErc/0smNB0CZWShx\n\t7g2A==","X-Gm-Message-State":"AHPjjUgx5KcbqxwLfl+HtO5idEMqdLuhKJ0L5jbawjkp2IXs3Dfyn8Rw\n\txf3OoM6/mx2Db5O5hBqu18rkJG1+bBvnBiMirU4ruNM8","X-Google-Smtp-Source":"AOwi7QBOYeJEwwpgaVlQqnXW/1jGMzHkPVNjJF088EvFpFZ8bxwiFtbeLZYqFdFqNLRXDJvMh/deFUQfuBOmaRWmamo=","X-Received":"by 10.37.91.69 with SMTP id p66mr6576094ybb.423.1506439804424;\n\tTue, 26 Sep 2017 08:30:04 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>\n\t<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>","From":"Eric Dumazet <edumazet@google.com>","Date":"Tue, 26 Sep 2017 08:30:03 -0700","Message-ID":"<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Dmitry Torokhov <dmitry.torokhov@gmail.com>","Cc":"Tariq Toukan <tariqt@mellanox.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1790456,"web_url":"http://patchwork.ozlabs.org/comment/1790456/","msgid":"<be222d71-0b61-9256-6d39-cbb9d762cd22@mellanox.com>","list_archive_url":null,"date":"2017-10-19T11:48:37","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 26/09/2017 6:30 PM, Eric Dumazet wrote:\n> On Tue, Sep 26, 2017 at 8:22 AM, Dmitry Torokhov\n> <dmitry.torokhov@gmail.com> wrote:\n> \n>> It is in Greg's tree where all kobject patches should go through as far as I know.\n> \n> Yes, I will fix this, adding a second memmove()\n> \nHi Eric,\n\nI just wanted to check if this is solved already, as I don't want to \nkeep an unnecessary revert patch in our internal branches.\nAccording to my check bug still exists.\n\nThanks,\nTariq","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"t9NWFtmX\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yHnJr0bTNz9t2Z\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 19 Oct 2017 22:49:15 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752742AbdJSLtN (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 19 Oct 2017 07:49:13 -0400","from mail-ve1eur01on0071.outbound.protection.outlook.com\n\t([104.47.1.71]:35616\n\t\"EHLO EUR01-VE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751680AbdJSLtL (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 19 Oct 2017 07:49:11 -0400","from [10.8.2.253] (193.47.165.251) by\n\tDB5PR05MB1799.eurprd05.prod.outlook.com (2a01:111:e400:5bc5::13) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7;\n\tThu, 19 Oct 2017 11:49:06 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=aPH5avddp8p2xnFJrGF/9rCnuWtmOlI8RpmjSpoDTgE=;\n\tb=t9NWFtmXc3yYrtR4LsZf+7NTSOj/y6vSV07+NgfLV/AkJoMftIkeZyzqR8N7f2pYiVdpbqir3iujWOmqqvtW7+TN/VW6S6COH+b42YZ7mnif6lFCXhO/49MUVuE38JsGmYb91vqKNukfGKebGH8Oa5Ih+7MMkOHb17vVvszrxxU=","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Eric Dumazet <edumazet@google.com>,\n\tDmitry Torokhov <dmitry.torokhov@gmail.com>","Cc":"Tariq Toukan <tariqt@mellanox.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>\n\t<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>\n\t<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>","From":"Tariq Toukan <tariqt@mellanox.com>","Message-ID":"<be222d71-0b61-9256-6d39-cbb9d762cd22@mellanox.com>","Date":"Thu, 19 Oct 2017 14:48:37 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"AM5PR0102CA0017.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:206::30) To DB5PR05MB1799.eurprd05.prod.outlook.com\n\t(2a01:111:e400:5bc5::13)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"8dc65096-7eba-4b00-e880-08d516e7681f","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:DB5PR05MB1799; ","X-Microsoft-Exchange-Diagnostics":["1; DB5PR05MB1799;\n\t3:3a7jIXw+OCde2T/jhBX5VdBoMrfJN8OXHHeYZTiD8Z4EXV9djK+b0KnlpCDXhwqj9qO4XVtU9cYv6SrkbtxQw4NMA/F44NUwdgeM/xwVcb41obLGoPZ0cV2vzK4PghZKBmP0A2dsIVGKOZuwnGNrbvFIgPV0wvfV0k0XSAIWVQFIu24z8dalUPNVB9FPlEEthnI/zJcLNJR4p0RgOY4qItLIz/VHj3Yu4bMiPeWQqwdzkrMDodaSKZcDpfmAMzEy;\n\t25:ODBQn3yp5qiLXz5aNucph/8Fcf1ZVvi87mvJhmGBdZi77a8i8iIusKMqkezBR3rT5ln1gNkvX/7QV18S1c0ImwED31Ys0K0J8avW3UQ1k1J9uVnXEqqs8ln39xP1+jS1Eo5KmvFd8TBYDYY56MRl3IL2P8LKxkTtOayPks0PZVQaADdBnb+lBoLKLhjdMA/zA9SGP3837ROL5YZDPPm6ktv35Yn3/EQFaeO30CHmyJ9v4B0T4kZSqzyNHwvYvzVuPMk1BNnT3pJiRn/Lm/iWFlGC+YOg9Gr6IwZz1JFcPzCMCNJEfAJaf3JD2nUnUBdaIf8v6HLdKLkUAe7uUFQOF2S/aPx3rzYJ+oR8bHm3EcE=;\n\t31:zZC5AIyWbdvkVngBpMOgoawkbkdt20yH49d4u/4Go4PFzwgvYncQaAJ0v3tcy/RoARaOzto1SVg22yExaV2TMnxnf3sSg2O2xLn8aOKRvo6hC6OZcBtgxDIBjRJqku6CxN8poHRWqmSy4vQ9fqjmbqgs2Kh3ijghFBLc/rjYrf0SbaCr5imQOrmg2/9XAOvTzcypcG2dcaYNXftIvl9NoNudPkv2NbtYfPOWI2wrryk=","1; DB5PR05MB1799;\n\t20:ZaIr3K9CemMzjFPAvFslkESC6bFw90B9NHBRcUxzglxNc82f+F968LN901F/FbsQdU7utu6RU7TCh/ZcUG7qKZASbrLwEX1GJTFdPfNEK2jAyS9xdu6OfxvZxyKMazQQ+cHnatgNw8aO8QmaPkl5UINlD02sEHPq3wXkaauYZuRmQ4lIEwqSs8Neyw7OyzokWRmzfPjx9bfm+7duhU2GQey0Ol9Vn/4wlBUZJwShIeN1lSAcX4rnZpbtthdm3jvyc4O1mCI+MCN8UrCTY64tN8M5dmutF09A54eun1M4ITBeSToiFCg3gRqZ4mNtbJ1Z/uVs5kGuTvTwGWAjhj6W+de4k//sG0L9/EcQeF9+5QANBDNkBbHd6bqB1Rh1OIoZzhF8V3xaztz9f83QqhUfNfRZ17HZ0YLefx/+TptE3zrt0Vtb4+ZsyhypZydQjjh6P/8nTEuVkmAZQDjjy6IfVw+t9BFKJoxZUDu9rziKdX2dIJ3m7F5evTGlEBGDTHJy;\n\t4:0EcO09qqaAi9OCph9Ok/bW8iliVOtYBgSG9o2nUGU1+7C+Fiu/imMU22xfzjBHaaJCy8bwhzrz0sM+claaUukey02X3ateRpItA93ZAveKkIBBjSTCdoO7sauaku0y2IOIR1E4I+14bnFzuZGUZELzVlwClwlJajwfc8Zw2EnjS3qOwbviBt0LlU/dJCjlLNx0hqvjCkDZqjwbUvq+cGmG9F4A9GV7FT9KsnOEyLejMicsP6sVQD6z66Wu3zdLtu","=?utf-8?q?1=3BDB5PR05MB1799=3B23=3AZmON?=\n\t=?utf-8?q?ryfB/PAUqIk6GLbdQNmGjgubIu26ZaiDUe0NyMIUSCUY+SXFQJAm0ni/?=\n\t=?utf-8?q?XV5zU++NMVK55/rHFH+OllvpSfadhPrZCVG2op+8Bp2bOmS5M7vL4YDx?=\n\t=?utf-8?q?mrI2aEFG8mNC8bMNrjqIiqHiUv75TKvtBUSZjyRBT/nTqhLKDZrpCQeK?=\n\t=?utf-8?q?Ra1jLAbGs2eXH2W9M4g6wP0gS176LMdlcs57BUikok6myvNIvI4s5XXk?=\n\t=?utf-8?q?HK4xMgMl5Q3Ylh77wsh6eimAhkI42dKXoC4Ae9V5nGMJXVa9dL+0nEz8?=\n\t=?utf-8?q?SXbkWv/FU4t60nGf7E1ZkDgvGee1I4qkH/WfqVBAEI5/ZUo9iQ5G9htJ?=\n\t=?utf-8?q?xlv5yAp0vlRNrHB3L8QgY7dQ25OXh9GoXk3GCwzc6q7IVjo2GXhqa9Ab?=\n\t=?utf-8?q?ZB9/m5LT5I2Su2pSt6umxBV/HYVViBbBEnT+x3soyopatAJlfRaa+3fx?=\n\t=?utf-8?q?Tu9Ehq5QtD+GeGERQb72HVi3vCfeaBPWUBW7chgmv7hpeU5vNF17Xvqq?=\n\t=?utf-8?q?qUPnjj0uGwPZCKeV/d5Ao+fIlvK1UhgAkUj/pzueUbgVzrM+onigjJC/?=\n\t=?utf-8?q?jpY+mIlryiTmLl47rAIkekZKCDErPl5+TO9APlK1T+Gu9dmouqQGYBK7?=\n\t=?utf-8?q?kRXz3nrZ09lLnT0ZqfJme/lgCD1X+dcK5cHz3cU3XLxCMRmy63WJbI3s?=\n\t=?utf-8?q?X9lWITPOqMI7evPfX0z3KnmfE6jdyOj5yC4wo07c1fvfoawInB1FTsHO?=\n\t=?utf-8?q?Bf/lI8pakEkbyR1SbNcCNdTUAWdXixH7JYkJ8gxqxTxl+4jb/cN7lt9A?=\n\t=?utf-8?q?I6dxb9yHkJbDkZITcwk1EXfe59u94dV0HwyvP/RvaY0ijT4YROTk7NSH?=\n\t=?utf-8?q?IkERnwSVJtj2OUiGvDqLPK42ErA9LjMQCkdxJF9RcIB7ehf2tFZCeFiG?=\n\t=?utf-8?q?tSspUdUAFjiBFoeCpv2cMEmD8k7aPSJfwBQSDHQ4cvMQx55FJ/WkAfnn?=\n\t=?utf-8?q?xrCEVlSK01te3aY9CSpijBl99vz5b3IRFMrUOK1sEzDoZQPq6jA5AMIv?=\n\t=?utf-8?q?Dm0C61VdgwEhRk16rsM133SLLRXbaGA/IJfhN/vWNMfgo9jmj54jFFiG?=\n\t=?utf-8?q?IcCotdtuGrpcRLoGvK4UMgEXyypzxTMMhQ7rOEh5QENRNZtTXdYy2eI6?=\n\t=?utf-8?q?BLqTBjegYvDWBNX0c1CX9DRJsEug/INWiMqqex536wOfV61Rq+SCBuqd?=\n\t=?utf-8?q?7aUaHMvwh6gXmrreMpYNDa2rNeauUPSzyjiXAkq+vK6ioFv5/vYCpBmM?=\n\t=?utf-8?q?4YE9fP9f2ebdLqR7UbBVd+FyOLMtQYUtjgflGmhQBpG8vnt/74hJA0dZ?=\n\t=?utf-8?q?fkHY6fe7Iyq3Fw9KX4MkdmgxYbztdh8gWVbuee0VH5xaw2vRTeh8GmnY?=\n\t=?utf-8?q?Bsjgwq+E8R9B1TwEA1Z6kw5UNKU6u9z5SH2kV4piD7uFlLI3jQ8YZifF?=\n\t=?utf-8?q?EixpEm8WBPqpAd0cbNtqm4JyEFjPitvCP1DCX5HOANVqLzIVxcLDinfQ?=\n\t=?utf-8?q?+Zpa4iCggX5VXljypqeAo462F+EZg5yjzA=3D=3D?=","1; DB5PR05MB1799;\n\t6:CB0FxZF6OCCn6xg6i9ew5UwIZ4tRgaDm1xZ5VS9CkRkujRkf0THaawmUWP7VzhP4HYdO0KiykMs7MqtHN5BgA+Q7GH46EmBM0DZBDWBIbk4rtXztty/L2xN7fL5oLkvu/6+bKAL7gGfEL7g+0M62SSqskm4ZjrOLu39tcTtqLK60cScRrv689qRblHiJiCulk5BZlK9pH3bPsVGT6mBEv+GEc165TdLbk6i/CFJKjKcd647EcTjlQOjOm/gcUnMb7lLbL1TnPbbaTxCnFW7hjn5sbXCpqKwnDxnsGNgndeloVnjWBBw4cSHI0L5PyO0kO5ZcNpOLg9dyUVvtS6lTgA==;\n\t5:7o3fcidmToIM+DDPQJnjDhte6ZICU/jQgdMsWmY8LzWUXMKvsFjvvyTnzKGykGrVHFEk+058zycsF0msT6qse6NeTR1bE3PWFGPk3nij0Q87SLqaRFMgnDt3EvE3ldbE+nUdnKg/G6k5cZcxkMwl/Q==;\n\t24:CctbvjeV83gzYkB990SYoFWc1DAYn40mE7GWgFuYHwdU1Ncw9szMIMNxY758lq1J+JiVaZvQTLqhzEoKbFM5bcFo4XBdSgo11rizZrtqvis=;\n\t7:95FvBqJl1IIMPqERWWp+tNMvzDyyO6TqFLXwh+Hb+3foyrcplIrw0Nk9p0GNxjMAI9SV7AZ3chn4jhj5yncKskvlW/9DbdEo47gCVPeHunRkKwnKoPxL2oUcNz1z5wrDlPU7pfN/zkSHuTrs5Lg4l6Tcqycp3TZ0/SdPCNCk3xjYqT7wK9VGe+ke1btKi4BXr2ScNLFTrOM1xgTzauWC/bhPqsYFrRSUkdK08LwC7lQ="],"X-MS-TrafficTypeDiagnostic":"DB5PR05MB1799:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"<DB5PR05MB179906C780EDF5FB443F4D8EAE420@DB5PR05MB1799.eurprd05.prod.outlook.com>","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB5PR05MB1799; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB5PR05MB1799; ","X-Forefront-PRVS":"0465429B7F","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6049001)(6009001)(39860400002)(346002)(376002)(199003)(377454003)(51694002)(24454002)(189002)(106356001)(6246003)(65956001)(81166006)(3846002)(23676002)(230700001)(53546010)(105586002)(8936002)(65806001)(6116002)(47776003)(107886003)(54906003)(83506001)(7736002)(2906002)(39060400002)(4326008)(50986999)(64126003)(54356999)(478600001)(110136005)(81156014)(316002)(16526018)(53936002)(50466002)(16576012)(58126008)(76176999)(93886005)(5660300001)(8676002)(101416001)(65826007)(66066001)(2950100002)(33646002)(6666003)(189998001)(97736004)(77096006)(31696002)(86362001)(36756003)(229853002)(31686004)(305945005)(68736007)(25786009)(6486002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1799; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"19 Oct 2017 11:49:06.9845\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"a652971c-7d2e-4d9b-a6a4-d149256f461b","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB5PR05MB1799","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1790603,"web_url":"http://patchwork.ozlabs.org/comment/1790603/","msgid":"<CANn89iKiKvzz6_R+T4kO8ztXFC7ke299+vOsGr92q2NfGBwFjw@mail.gmail.com>","list_archive_url":null,"date":"2017-10-19T14:11:03","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":13357,"url":"http://patchwork.ozlabs.org/api/people/13357/","name":"Eric Dumazet","email":"edumazet@google.com"},"content":"On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>\n> Hi Eric,\n>\n> I just wanted to check if this is solved already, as I don't want to keep an\n> unnecessary revert patch in our internal branches.\n> According to my check bug still exists.\n>\nI will handle this today, thanks for the reminder.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Xyiw5ISQ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yHrSW5s0vz9t3R\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 20 Oct 2017 01:11:07 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754425AbdJSOLG (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 19 Oct 2017 10:11:06 -0400","from mail-yw0-f173.google.com ([209.85.161.173]:43447 \"EHLO\n\tmail-yw0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754235AbdJSOLE (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 19 Oct 2017 10:11:04 -0400","by mail-yw0-f173.google.com with SMTP id y75so3595436ywg.0\n\tfor <netdev@vger.kernel.org>; Thu, 19 Oct 2017 07:11:04 -0700 (PDT)","by 10.37.80.194 with HTTP; Thu, 19 Oct 2017 07:11:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=S4HM8bl9zG8ORvctxwamuODk7YXT7EijPGlAzR+2cqU=;\n\tb=Xyiw5ISQTF07kgRpg6KgLHRzRJxfVnfVPW/6MQ/2X9tHr0PttIZZabkVMg1Y2VtEg2\n\tAMW0rdZ4Am1aZmFl4ZnLKTToFgWnJtyRHcAK79e8/Kz8WPV1hJuOOn/0toVVp1f3kvpG\n\tVZayIPvyb9caIkjCqGKe5JJXfrYImTsQmr0sxlPQNscEaihQ/jOglTG0VVaHBt9g+ttN\n\tpdCyojp6UBk//tBOfMRRZ4Z1qRJFP/ulEX5SWbuHJQyMD+VBSSaL83owHooq+lSN5JVc\n\tngucQ7rKD6rhhIpTrmxSsjf27KC9DmAevuURoNKknT1j6+ZGiGDWUKwuYhYEaXMovgso\n\tWAbQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=S4HM8bl9zG8ORvctxwamuODk7YXT7EijPGlAzR+2cqU=;\n\tb=XbBzo4uKRexzUuVlQcCXqAO/MnZRU0Ag9z+7Nh5DuMuFIMBlZcQ9VsOwmBbGjptcde\n\tcwWholnIcmtJtRSn+WfF5+6MHXq5+6PYzy8QD2vnpqWC4tNJR837/7nWXtiQu9xwVebG\n\ty+K+6KJqNGFr9a+IHK/Y1gaV/HAjUx6BGCo1T4cI1kZYXSO57lySx//micz4MByAhWu3\n\txEr2mH2pgzq5xOzqdO8Dg1+GoXRDhmdbdiqmbY5RN8IKhU1Fhp/GRL3ZVX09215kjr1Z\n\tx5hsLKsTd3xUyzP4bXgEWhUIGZuDkCxSh9+4w0Bg+0pxNzyraq4FwOOAc7JjmlyZSzMQ\n\t+xxQ==","X-Gm-Message-State":"AMCzsaW4oqiH4/5552RdN+/SwI63xaYBlw65k9iwI0BPdVuOopJEKVRu\n\t1wG7tf1nN5aVoMMbOTmPrE4TbpSfftaZFmA22ucf7Qc+","X-Google-Smtp-Source":"ABhQp+T6414dZd9k2seupsGY2MMjlgum+scRfhU6Tx3JnZJWvDWVjXebTg07Nzd2Um5COIuRhoiHKEifz1sXXRpT3y0=","X-Received":"by 10.129.74.86 with SMTP id x83mr1145196ywa.434.1508422264018; \n\tThu, 19 Oct 2017 07:11:04 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<be222d71-0b61-9256-6d39-cbb9d762cd22@mellanox.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>\n\t<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>\n\t<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>\n\t<be222d71-0b61-9256-6d39-cbb9d762cd22@mellanox.com>","From":"Eric Dumazet <edumazet@google.com>","Date":"Thu, 19 Oct 2017 07:11:03 -0700","Message-ID":"<CANn89iKiKvzz6_R+T4kO8ztXFC7ke299+vOsGr92q2NfGBwFjw@mail.gmail.com>","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Tariq Toukan <tariqt@mellanox.com>","Cc":"Dmitry Torokhov <dmitry.torokhov@gmail.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1821873,"web_url":"http://patchwork.ozlabs.org/comment/1821873/","msgid":"<CAKdAkRTpnxxW0h5smyUDQKm4f94D6-i7G5UK_NnGj_i-cwj35Q@mail.gmail.com>","list_archive_url":null,"date":"2017-12-13T21:43:21","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"Hi Eric,\n\nOn Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet <edumazet@google.com> wrote:\n>\n> On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n> >\n> > Hi Eric,\n> >\n> > I just wanted to check if this is solved already, as I don't want to keep an\n> > unnecessary revert patch in our internal branches.\n> > According to my check bug still exists.\n> >\n> I will handle this today, thanks for the reminder.\n\nDid you have a chance to do this? It looks like the original change\nlanded on mainline and causes modules to be autoloaded on KOBJ_UNBIND\nagain.\n\nThanks!","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"F1GFcKGB\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yxqv40G16z9s4q\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 14 Dec 2017 08:43:28 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753823AbdLMVnZ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 13 Dec 2017 16:43:25 -0500","from mail-ua0-f196.google.com ([209.85.217.196]:40102 \"EHLO\n\tmail-ua0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753463AbdLMVnX (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 13 Dec 2017 16:43:23 -0500","by mail-ua0-f196.google.com with SMTP id i92so2598894uad.7\n\tfor <netdev@vger.kernel.org>; Wed, 13 Dec 2017 13:43:22 -0800 (PST)","by 10.176.28.10 with HTTP; Wed, 13 Dec 2017 13:43:21 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4TMYYRyMnzj+efw2LepTTx30mKKrwAmOgJ3btp0FPkk=;\n\tb=F1GFcKGBGqxZYDo15pGNtRv7yMRiUbk/rcP9SfGOnMfSwNfSzWLXIXYdVZHgDlMYs8\n\tzLCx2L8vp5n8p7lnidh9hhiR5YVWLFuyqz9KUGy87j9N+PEnWVZnR9IRqOKw1GnGKcxn\n\tXl/JRQouGFi5o/X1lRECFGs0OwPN7ebAfzsSMUOQdc8ifMuZrFHYPcDvcyG4mOaINmGI\n\ti370fFDohMznLGo1W+BzKh6XVh/W/DleMygAEo35qKiFnGHTp3kV5Xy71J43F5+0HESF\n\tiTjxLrke9axlslwFDhgNzD+xKdLRcsTU0/tYgvKfU5PvhTbVVrm4Fx+Lte+sJNwDqv7d\n\tYcHA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4TMYYRyMnzj+efw2LepTTx30mKKrwAmOgJ3btp0FPkk=;\n\tb=uhARl/XpQpzWmCwew5mTHQCkMEaSTJkiAP3ykYJmCemWWXWe3gNCVMrv0MV5C5pAQl\n\tmbExR5P5pJWQVB/3bnnvqzigBy+Yt+VYhj6NVugV5S2i1l/jxzG8vNl5zK1IQl5r/gFE\n\tg04v8/Lk7tsz1nsZFZM6ppHGug0BQEuH5tiURCPvb8K3E/dIoSKLjEHa42TqDngBevvA\n\tKGOnoZ6SyXhLdZJThLZfOnBjQmaatZ766yrgCpn/+kyNExkj8Lyu2bCYZAhkuX8G6ntx\n\tkrI1jMoQ7RozvFxaQjJu+P55oEur5Rsc8RDfQJG0wkjU+ni09FGV1GFL1cOwQNTamvNh\n\txCUQ==","X-Gm-Message-State":"AKGB3mLSSuNHKU5ZH9V7GcWUt6uDN10EfKLRvIPtfZyuozL1kVigOYPd\n\tQqj5y6N44lpGM+fVQBM72UNfjCT0HQWpqCik91Q=","X-Google-Smtp-Source":"ACJfBotHyrSJ6QijNr8Gk8wSkHBTOYVAuyKXybS/SjwhDorbt/X+2Kp+wWcknrOXANxJvWLfv72Q73hT6Qvn1VC7kmE=","X-Received":"by 10.176.73.105 with SMTP id a38mr2994334uad.150.1513201401913; \n\tWed, 13 Dec 2017 13:43:21 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<CANn89iKiKvzz6_R+T4kO8ztXFC7ke299+vOsGr92q2NfGBwFjw@mail.gmail.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>\n\t<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>\n\t<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>\n\t<be222d71-0b61-9256-6d39-cbb9d762cd22@mellanox.com>\n\t<CANn89iKiKvzz6_R+T4kO8ztXFC7ke299+vOsGr92q2NfGBwFjw@mail.gmail.com>","From":"Dmitry Torokhov <dmitry.torokhov@gmail.com>","Date":"Wed, 13 Dec 2017 13:43:21 -0800","Message-ID":"<CAKdAkRTpnxxW0h5smyUDQKm4f94D6-i7G5UK_NnGj_i-cwj35Q@mail.gmail.com>","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Eric Dumazet <edumazet@google.com>","Cc":"Tariq Toukan <tariqt@mellanox.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>, Majd Dibbiny <majd@mellanox.com>,\n\tYonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1821880,"web_url":"http://patchwork.ozlabs.org/comment/1821880/","msgid":"<1513201949.25033.68.camel@gmail.com>","list_archive_url":null,"date":"2017-12-13T21:52:29","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Wed, 2017-12-13 at 13:43 -0800, Dmitry Torokhov wrote:\n> Hi Eric,\n> \n> On Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet <edumazet@google.com> wrote:\n> > \n> > On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n> > > \n> > > Hi Eric,\n> > > \n> > > I just wanted to check if this is solved already, as I don't want to keep an\n> > > unnecessary revert patch in our internal branches.\n> > > According to my check bug still exists.\n> > > \n> > \n> > I will handle this today, thanks for the reminder.\n> \n> Did you have a chance to do this? It looks like the original change\n> landed on mainline and causes modules to be autoloaded on KOBJ_UNBIND\n> again.\n> \n> Thanks!\n\nI sent the following to Tariq, and he tested it successfully.\n\nI will submit this formally.\n\ndiff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c\nindex c3e84edc47c965d40199b652ba78876cdaa9c70c..0795482b15d5a8f1b65b570a071aa1419cb923d8 100644\n--- a/lib/kobject_uevent.c\n+++ b/lib/kobject_uevent.c\n@@ -346,19 +346,25 @@ static int kobject_uevent_net_broadcast(struct kobject *kobj,\n static void zap_modalias_env(struct kobj_uevent_env *env)\n {\n \tstatic const char modalias_prefix[] = \"MODALIAS=\";\n+\tsize_t offset = 0, len;\n \tint i;\n \n \tfor (i = 0; i < env->envp_idx;) {\n+\t\tlen = strlen(env->envp[i]) + 1;\n \t\tif (strncmp(env->envp[i], modalias_prefix,\n \t\t\t    sizeof(modalias_prefix) - 1)) {\n \t\t\ti++;\n+\t\t\toffset += len;\n \t\t\tcontinue;\n \t\t}\n \n-\t\tif (i != env->envp_idx - 1)\n+\t\tenv->buflen -= len;\n+\t\tif (i != env->envp_idx - 1) {\n+\t\t\tmemmove(env->envp[i], env->envp[i + 1],\n+\t\t\t\tenv->buflen - offset);\n \t\t\tmemmove(&env->envp[i], &env->envp[i + 1],\n \t\t\t\tsizeof(env->envp[i]) * env->envp_idx - 1);\n-\n+\t\t}\n \t\tenv->envp_idx--;\n \t}\n }","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"S6u/yNqJ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yxr5d6gzcz9s7B\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 14 Dec 2017 08:52:37 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753977AbdLMVwg (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 13 Dec 2017 16:52:36 -0500","from mail-pf0-f193.google.com ([209.85.192.193]:46494 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753737AbdLMVwc (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 13 Dec 2017 16:52:32 -0500","by mail-pf0-f193.google.com with SMTP id c204so2081759pfc.13\n\tfor <netdev@vger.kernel.org>; Wed, 13 Dec 2017 13:52:32 -0800 (PST)","from edumazet-glaptop3.lan (c-67-180-167-114.hsd1.ca.comcast.net.\n\t[67.180.167.114]) by smtp.googlemail.com with ESMTPSA id\n\tp13sm4452587pgn.32.2017.12.13.13.52.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Dec 2017 13:52:30 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=NSB3EQORi7QK84U+Yix0TlTAeAsqsEoglijlbnMox+4=;\n\tb=S6u/yNqJqKeyR8sCcK2kIlHpDImq+gfqXGnokkPLPMMFpbzePE6v4FOJxlIt8TnhA6\n\ttc1GEE0rdXfcgEMyf8BNscaD/CT6+uTyqIi4jCYJVZKctY8UMD2Wmpq/nhw/BoNAT0/q\n\t2UNCa3SIeTcpwk5jMZyunNeyzwSAUqyntzGjTwC3OaVk9Cw01uHBynNr9ZuJDLP2YmAl\n\t5TWQ0FCBf4ev2pKVXW8VJlagFT3EfJZGXQW/UHpjavPqloqNIVP4Lj8uNX+PnPJ9Ky9r\n\tfgeQmIgB9f5+UeLhKTEtxXQ5NIs+VrR41bofh7BjjnOQpgL2jKSXB/E4OCNypEMIcgOQ\n\tIzsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=NSB3EQORi7QK84U+Yix0TlTAeAsqsEoglijlbnMox+4=;\n\tb=b6BltFrNbTvNqkWfWBOBflAenhmbECwoYS7by889OcJU2xS2J74C3Sgyo65W+dfADh\n\togYynSIRU8QKkaaFg3jzDvr3eJYGzSxALMiTvDcxJzryDjLfmSllzJJcAeGD0CeLAHMS\n\tt7BspQEYP62OB1JteWYokh2wTKcTobjbzBg+WjPKHErnbHgbpIerZp8USiyKiUJ/axTC\n\txSTaz2jbEJWYZBtzExBeQe8fG+8/e6tLNkPF4aFw/0mfOpVIMGy8ss9cJULaDtLMQeqY\n\tvh67yMNtt+MoccSy6OFDOm5HzDDdnRzGGqSKs6M5IX+JdyzD7igO0x1Qic9Xj3wj4PQE\n\tg0iw==","X-Gm-Message-State":"AKGB3mLU1FoRCtC7ylXmO3CWVKPEtwqi8FlHyQXPHoxZcVueRO96sxgC\n\trFoGkCcLsdaB8u+7oOBCoYU=","X-Google-Smtp-Source":"ACJfBouMbMq4GwaCO+8yxfyUCr+FNPWy7q5EwUr9GPXfJyCgJZscBsM+sF0dqarwu3oueBKEmRHpug==","X-Received":"by 10.84.228.200 with SMTP id y8mr7161945pli.202.1513201951665; \n\tWed, 13 Dec 2017 13:52:31 -0800 (PST)","Message-ID":"<1513201949.25033.68.camel@gmail.com>","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","From":"Eric Dumazet <eric.dumazet@gmail.com>","To":"Dmitry Torokhov <dmitry.torokhov@gmail.com>,\n\tEric Dumazet <edumazet@google.com>","Cc":"Tariq Toukan <tariqt@mellanox.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tMajd Dibbiny <majd@mellanox.com>, Yonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","Date":"Wed, 13 Dec 2017 13:52:29 -0800","In-Reply-To":"<CAKdAkRTpnxxW0h5smyUDQKm4f94D6-i7G5UK_NnGj_i-cwj35Q@mail.gmail.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>\n\t<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>\n\t<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>\n\t<be222d71-0b61-9256-6d39-cbb9d762cd22@mellanox.com>\n\t<CANn89iKiKvzz6_R+T4kO8ztXFC7ke299+vOsGr92q2NfGBwFjw@mail.gmail.com>\n\t<CAKdAkRTpnxxW0h5smyUDQKm4f94D6-i7G5UK_NnGj_i-cwj35Q@mail.gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.22.6-1+deb9u1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1821886,"web_url":"http://patchwork.ozlabs.org/comment/1821886/","msgid":"<CAKdAkRSgqXA_nkiit80dDA_o1UVt6WzRd0u6POG2WCCpm=pfqw@mail.gmail.com>","list_archive_url":null,"date":"2017-12-13T22:24:49","subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"On Wed, Dec 13, 2017 at 1:52 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:\n> On Wed, 2017-12-13 at 13:43 -0800, Dmitry Torokhov wrote:\n>> Hi Eric,\n>>\n>> On Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet <edumazet@google.com> wrote:\n>> >\n>> > On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan <tariqt@mellanox.com> wrote:\n>> > >\n>> > > Hi Eric,\n>> > >\n>> > > I just wanted to check if this is solved already, as I don't want to keep an\n>> > > unnecessary revert patch in our internal branches.\n>> > > According to my check bug still exists.\n>> > >\n>> >\n>> > I will handle this today, thanks for the reminder.\n>>\n>> Did you have a chance to do this? It looks like the original change\n>> landed on mainline and causes modules to be autoloaded on KOBJ_UNBIND\n>> again.\n>>\n>> Thanks!\n>\n> I sent the following to Tariq, and he tested it successfully.\n>\n> I will submit this formally.\n>\n> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c\n> index c3e84edc47c965d40199b652ba78876cdaa9c70c..0795482b15d5a8f1b65b570a071aa1419cb923d8 100644\n> --- a/lib/kobject_uevent.c\n> +++ b/lib/kobject_uevent.c\n> @@ -346,19 +346,25 @@ static int kobject_uevent_net_broadcast(struct kobject *kobj,\n>  static void zap_modalias_env(struct kobj_uevent_env *env)\n>  {\n>         static const char modalias_prefix[] = \"MODALIAS=\";\n> +       size_t offset = 0, len;\n>         int i;\n>\n>         for (i = 0; i < env->envp_idx;) {\n> +               len = strlen(env->envp[i]) + 1;\n>                 if (strncmp(env->envp[i], modalias_prefix,\n>                             sizeof(modalias_prefix) - 1)) {\n>                         i++;\n> +                       offset += len;\n>                         continue;\n>                 }\n>\n> -               if (i != env->envp_idx - 1)\n> +               env->buflen -= len;\n> +               if (i != env->envp_idx - 1) {\n> +                       memmove(env->envp[i], env->envp[i + 1],\n> +                               env->buflen - offset);\n>                         memmove(&env->envp[i], &env->envp[i + 1],\n>                                 sizeof(env->envp[i]) * env->envp_idx - 1);\n> -\n> +               }\n>                 env->envp_idx--;\n>         }\n>  }\n>\n\nAs I mentioned in the other thread, that works for netlink, but breaks\nif you actually using env->envp pointers, as they also need to be\nadjusted. I have a patch that fixes it properly.\n\nThanks!","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"LNzKir7J\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yxrpt6NbFz9sCZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 14 Dec 2017 09:24:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751952AbdLMWYw (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 13 Dec 2017 17:24:52 -0500","from mail-vk0-f67.google.com ([209.85.213.67]:43863 \"EHLO\n\tmail-vk0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751088AbdLMWYv (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 13 Dec 2017 17:24:51 -0500","by mail-vk0-f67.google.com with SMTP id u84so2407543vke.10\n\tfor <netdev@vger.kernel.org>; Wed, 13 Dec 2017 14:24:50 -0800 (PST)","by 10.176.28.10 with HTTP; Wed, 13 Dec 2017 14:24:49 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=5b9wwuQi3a4OLi8d354yV/NZdgw4Z2MFWDW9aIWYccI=;\n\tb=LNzKir7JYYFvH+LGvqJTGawdB/AlqcI11aT6DQLgYZuAR0lG9023r7phwtlZnwZ8aj\n\tTacclrk2cwP31RftRn/TehMUBecAd2tHxKBWypN1mznRh38aRUxvsPpfloqROFeAnMsf\n\t6OEs157ZwqW9VucL1afAgLQ4k5bzwpgLKwoPPxAZEASn/1bGMEhVsqubGty34eS5J2QQ\n\tZgV1MUvrWw+CyoG7VSUE5kE6U46smxfX5aJ8VqgTfI9aFKPit3Hv1Del4s1B+Rk5sY9+\n\t6y35RizS5l3LansPbkc32p/IDLOhbKWv2Do37w3MhC6vWdQnCyS2Q+VmKz+9GUEOIIZv\n\tgO/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=5b9wwuQi3a4OLi8d354yV/NZdgw4Z2MFWDW9aIWYccI=;\n\tb=shpeuzp8eAaqOa/o9vgP6Br2/Q5MTun8dFuC5R4Qg9mjPfrImfq9oao/LUt8CydJll\n\t2fQQzqrqzFKfgZM1/lg8yJosg1laT52j1RzPLEJV+QUF3UZwjIbtmiV0YCoiioj5PAuw\n\t6HjERG/Q8CU7U1KeVGSg5YC2MzHqFp9o6tJuZbQf1L4p/Ff37SVcvgTvmubzHZTlC5PZ\n\t8UVYCxqu7MFzUh4PxCwQFDINK61/5YEYmCB7c+/6BKg79nBNA3MuakJIPDgDANdKrquJ\n\t/IKEAiMIN+o/rK/19OJ96MUogCZguoYN29NqaUwE+mfdFH400QuarkkX459Jz/5FPlr1\n\t2NBA==","X-Gm-Message-State":"AKGB3mJu4uj5gMhBrdo5W+3E+KGc5TG3c9hmxUbegIcE+ujOE3DErW4B\n\teZKq0cjyr0Xr9kC/etDKeNvYG6DUcw+aJeExtcBkzA==","X-Google-Smtp-Source":"ACJfBosbna1yx7qEAvJc23AZ4wWwv+5+OwIjA+x8rDs3GmOpYvWu1SplF/fpJQfiva0AnWdvP+m6WDtBPVo9K91XDfI=","X-Received":"by 10.31.138.2 with SMTP id m2mr90622vkd.60.1513203890010;\n\tWed, 13 Dec 2017 14:24:50 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<1513201949.25033.68.camel@gmail.com>","References":"<20170919232709.14690-1-edumazet@google.com>\n\t<8edb310a-562d-bff1-0482-64314833e722@mellanox.com>\n\t<CANn89i+LE6He_E3VHwUTpLAVW+uUGo+FPs_zg1bs4P3CVcCL6Q@mail.gmail.com>\n\t<266d30e7-5164-48e8-b802-56bb93558823@mellanox.com>\n\t<CANn89iJ4io_gX-V8A4hE04cH=czGZYs8WGBOpaiBpWMMHOgVVw@mail.gmail.com>\n\t<33E69A03-6594-423A-86E6-02029046BE7D@gmail.com>\n\t<CANn89iKq86_FRaL7Y3Ekhf_JD8NY2s8PWibGN+WdmJL1TsPXJA@mail.gmail.com>\n\t<be222d71-0b61-9256-6d39-cbb9d762cd22@mellanox.com>\n\t<CANn89iKiKvzz6_R+T4kO8ztXFC7ke299+vOsGr92q2NfGBwFjw@mail.gmail.com>\n\t<CAKdAkRTpnxxW0h5smyUDQKm4f94D6-i7G5UK_NnGj_i-cwj35Q@mail.gmail.com>\n\t<1513201949.25033.68.camel@gmail.com>","From":"Dmitry Torokhov <dmitry.torokhov@gmail.com>","Date":"Wed, 13 Dec 2017 14:24:49 -0800","Message-ID":"<CAKdAkRSgqXA_nkiit80dDA_o1UVt6WzRd0u6POG2WCCpm=pfqw@mail.gmail.com>","Subject":"Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time","To":"Eric Dumazet <eric.dumazet@gmail.com>","Cc":"Eric Dumazet <edumazet@google.com>, Tariq Toukan <tariqt@mellanox.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>,\n\t\"Eric W . Biederman\" <ebiederm@xmission.com>,\n\tMajd Dibbiny <majd@mellanox.com>, Yonatan Cohen <yonatanc@mellanox.com>,\n\tEran Ben Elisha <eranbe@mellanox.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]