[{"id":1772664,"web_url":"http://patchwork.ozlabs.org/comment/1772664/","msgid":"<9d892f99-d48d-b034-8f50-2719ef07d0b1@ti.com>","list_archive_url":null,"date":"2017-09-21T10:36:49","subject":"Re: [PATCH v2 0/4] phy: rockchip-typec: Set \"flip\" properly; some\n\tcleanups; fix swing","submitter":{"id":14965,"url":"http://patchwork.ozlabs.org/api/people/14965/","name":"Kishon Vijay Abraham I","email":"kishon@ti.com"},"content":"Hi Douglas,\n\nOn Wednesday 20 September 2017 01:26 AM, Douglas Anderson wrote:\n> When connecting to certain DP monitors it was observed that only one\n> of the two orientations of the type C to DP cable would work.\n> Debugging showed that the problem was that we needed to set the type C\n> \"flip\" state earlier. Once we did this, problems went away.\n> \n> While trying to dig into this problem and some others, I found that\n> the proper documentation for the Type C PHY was available to me. This\n> allowed me to cleanup the magic numbers in the funtion that I was\n> touching and also fix a few minor issues that (luckily) haven't caused\n> any problems yet.\n> \n> I also found that aux channel communications were flaky on some\n> adapters until I adjusted the voltage swing.\n\n>From the commit log, looks like only the 1st and 4th patch are fixes. Only\nthose can go in -rc cycle. But I can't apply the 4th patch without the 2nd and\n3rd patch.\n\nCan you resend the series such that 2nd and 3rd patch apply on top of 1st and\n4th patch?\n\nThanks\nKishon","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"adi0Tu9Z\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"o4MfpIpC\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyY3P2trQz9s0Z\n\tfor ;\n\tThu, 21 Sep 2017 20:37:53 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duyrd-0001I9-Vx; Thu, 21 Sep 2017 10:37:50 +0000","from fllnx209.ext.ti.com ([198.47.19.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duyrZ-0001DK-4C; Thu, 21 Sep 2017 10:37:46 +0000","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8LAawn5000474; \n\tThu, 21 Sep 2017 05:36:58 -0500","from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LAarPP015024;\n\tThu, 21 Sep 2017 05:36:53 -0500","from DFLE104.ent.ti.com (10.64.6.25) by DFLE102.ent.ti.com\n\t(10.64.6.23) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tThu, 21 Sep 2017 05:36:53 -0500","from dlep33.itg.ti.com (157.170.170.75) by DFLE104.ent.ti.com\n\t(10.64.6.25) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Thu, 21 Sep 2017 05:36:53 -0500","from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8LAanHb022804;\n\tThu, 21 Sep 2017 05:36:50 -0500"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=DKy83pq57O5hNcR1Rbn67twXBZEdxsD6ly4aTmgzcyg=;\n\tb=adi0Tu9ZTe9GsQ\n\tsdSUM1E6fBsvZOUnH2VRoluKc1lFf6fCdSYwGKAg/wDluXSwYV5qv5Sge8s25zriIuXQd89OB7hEh\n\tNdJJ/NfTroGCQDb0lVPU53eUJiQoTfaVEOgv+k/6p7UfrA9tD7AuNyZE4KbWBoH9fNRkYuAxJARq4\n\tSqNvWoxuaJ3YS/Ro20CrfdLDgWCbrFZacV5ia1ExdeTd8AeSUUJ1oGEE6mBQv8Jr7dHm2eXdSXSpD\n\tX6J79ShgNqmLPdMUXxUW76/GMpY/hswTUxi/vg0T08VCXGdNLTEKqtGrJVIyDl9ZM7pjKnanugI2+\n\tFTeTNWw7BkEKixeSsxOQ==;","v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1505990218;\n\tbh=U8AGqghUiJUg5yBscUXqJI5t2KoAFQJgVlZ2ndkfNTs=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=o4MfpIpCwyFSe8cTgvKJA4iuWo2NPrDJA6HkdTgxDKNZBRyk9VfEm61vuC4z6xPA6\n\tDMiT9j4dLRAWgE6LetkGeDiP//JvGy/CDodZys0fIZ7MfQcSH54S9HB4PS/Nsie280\n\tD/tgHzBBQeSgGqcX0ZdDcls4JS0Ow5RcmhiQMlBU="],"Subject":"Re: [PATCH v2 0/4] phy: rockchip-typec: Set \"flip\" properly; some\n\tcleanups; fix swing","To":"Douglas Anderson , ,\n\t","References":"<20170919195630.18747-1-dianders@chromium.org>","From":"Kishon Vijay Abraham I ","Message-ID":"<9d892f99-d48d-b034-8f50-2719ef07d0b1@ti.com>","Date":"Thu, 21 Sep 2017 16:06:49 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170919195630.18747-1-dianders@chromium.org>","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_033745_330360_23E990E3 ","X-CRM114-Status":"UNSURE ( 9.99 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.47.19.16 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"shawnn@chromium.org, linux-kernel@vger.kernel.org, dnschneid@chromium.org,\n\tlinux-rockchip@lists.infradead.org, groeck@chromium.org,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773769,"web_url":"http://patchwork.ozlabs.org/comment/1773769/","msgid":"","list_archive_url":null,"date":"2017-09-22T16:45:11","subject":"Re: [PATCH v2 0/4] phy: rockchip-typec: Set \"flip\" properly; some\n\tcleanups; fix swing","submitter":{"id":9763,"url":"http://patchwork.ozlabs.org/api/people/9763/","name":"Doug Anderson","email":"dianders@chromium.org"},"content":"Kishon,\n\nOn Thu, Sep 21, 2017 at 3:36 AM, Kishon Vijay Abraham I wrote:\n> Hi Douglas,\n>\n> On Wednesday 20 September 2017 01:26 AM, Douglas Anderson wrote:\n>> When connecting to certain DP monitors it was observed that only one\n>> of the two orientations of the type C to DP cable would work.\n>> Debugging showed that the problem was that we needed to set the type C\n>> \"flip\" state earlier. Once we did this, problems went away.\n>>\n>> While trying to dig into this problem and some others, I found that\n>> the proper documentation for the Type C PHY was available to me. This\n>> allowed me to cleanup the magic numbers in the funtion that I was\n>> touching and also fix a few minor issues that (luckily) haven't caused\n>> any problems yet.\n>>\n>> I also found that aux channel communications were flaky on some\n>> adapters until I adjusted the voltage swing.\n>\n> From the commit log, looks like only the 1st and 4th patch are fixes. Only\n> those can go in -rc cycle. But I can't apply the 4th patch without the 2nd and\n> 3rd patch.\n>\n> Can you resend the series such that 2nd and 3rd patch apply on top of 1st and\n> 4th patch?\n\nGood point. Done. You should have just received v3 of the series. :)\n\n-Doug","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"KcRILarI\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"NYC4lKpr\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"hWJ4GzN2\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzKPJ5Phjz9sP1\n\tfor ;\n\tSat, 23 Sep 2017 02:56:04 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvRF8-0003ed-UE; Fri, 22 Sep 2017 16:55:58 +0000","from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvR55-0005R7-FS for linux-arm-kernel@lists.infradead.org;\n\tFri, 22 Sep 2017 16:45:45 +0000","by mail-wr0-x236.google.com with SMTP id w12so1354636wrc.7\n\tfor ;\n\tFri, 22 Sep 2017 09:45:14 -0700 (PDT)","by 10.28.27.194 with HTTP; Fri, 22 Sep 2017 09:45:11 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=nCCzVFie9jI2NWHsMRKLRnZEEMdsNmas/05vQypIWDc=;\n\tb=KcRILarIbpCxWc\n\ty59LDxOIbDg0yYofUENUwxhB+rSIWkNrJ2ROgCEmk/Wqh7pf0CPSJVtAehpTBwGYkx6I1YZqx7UDb\n\tIL0IM4ZF1jgB916w+uzo5LuFT8we7CeMpAAVF2dWoEVQIDLwPx+RKVMsoFps3UoIZzzpxhgAYSLLp\n\tmame5toSwg3m7F811PBaBDtfsZJVW+CfYPmhWat5w8rHtvX+G71SB5ahbqEuoLt2dU2z1uejydIHp\n\tgRfFAzgXxiJGsxIAA1LCxy9QcoS3DN9COLA/sUdb17dz1HrwcYwX6U1HsdkjzqOm1dpoMxfUrl50P\n\tAZLDB89I8WdM6DhLCDdw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=jPMO6KcRbhAFv+ybRY+XzNxs7vo3Cw/seWGEnXQVOlc=;\n\tb=NYC4lKprKFT1RBZaP4MOmu8pvgaAmTh+VLdIMgA/wW1Yvmt48jIGd+5W9VUG36Qo9+\n\tGC3CDy6aIjCj5Ywcbsdr+YFRJrksTyn3Y39IoaJiDUb88WB+IA02tdIWl1oekLFkM/dO\n\tMZe0IonHjeUhYQTKHUCDmIYRu1blqwwMRu1vK0A7rOa3jy/EOHw0Tgl+kCGzt16YtiYb\n\tF5JdOIvsk2/rhOhtIj0WP5HAQ2exBTj1G8Tu4DkIRTFJ83upDC67Glh2XZvSxNBKSnBZ\n\txe40u70wJoSy8FSOrNG4opYAPGqutOCq4UddHHslhTfJrA82EYL/X71f+xYyAWLb1OoR\n\th+GA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=jPMO6KcRbhAFv+ybRY+XzNxs7vo3Cw/seWGEnXQVOlc=;\n\tb=hWJ4GzN2Tl/5sGMjSagXH5+tPr5IW6c+Tii36TeL+9fKOoWqGvYzznU4MoS3KEgOTI\n\t6nvoB//vcDrCatqAyWNf0mEsC18YN97Ibp5LlPBMeNGCpn08NeV6VWemN9K3ziOqV4UR\n\tUIORHJWYBOYF8sV3f7i5VnOb7GUfd00C1PnSk="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=jPMO6KcRbhAFv+ybRY+XzNxs7vo3Cw/seWGEnXQVOlc=;\n\tb=pbDxGjM/nNx5AVTaND8JAXEmOaxIchrtmMrlwFoEyRO2STD3XGvgZq32+XX74VnwCy\n\tTUnHxFvSuVWRqF29d7EZAvMqA0gpCSt3MRcxq5clKs7cKzPELDNHhHzOdlnWpCqWYDW+\n\tJs0GT+nqbShXSw9yP4iuy5rv2qVQ80t/0zfIdoeSxrZkMCcSJkFwI6ZagnJmWS3op7rz\n\thpbl1757cqO9yW0jtn/7XYZNI3D7z9x0c9+JvuL+EEdIPvu5Dcvp0O5lsY1ZmqAIFz5q\n\tlBBtuiFe/WcxWeZSjwOGMtVTOVrkJmYfEjS4+WoPyCAUZyHfPrCkQhSCshV2B7pb+Vo7\n\toS5Q==","X-Gm-Message-State":"AHPjjUiQvRL8TSf9++7dzTsz0cdhylTEVWDLEMjGRhwJRmTKu5vlkW6i\n\t2TDG0M6Qph2lYjXNUIn9mhDY4hozylxxeTPJiEQkCQ==","X-Google-Smtp-Source":"AOwi7QDPm9cBbEIb9n3DVwEJURjMqYakG0i+448+mPdEcFSYTYbd0ZuNeuSr/+ouBJWaXFgZwwnbcr5GDaGgIOuPg6I=","X-Received":"by 10.223.163.71 with SMTP id d7mr5596417wrb.161.1506098712592; \n\tFri, 22 Sep 2017 09:45:12 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<9d892f99-d48d-b034-8f50-2719ef07d0b1@ti.com>","References":"<20170919195630.18747-1-dianders@chromium.org>\n\t<9d892f99-d48d-b034-8f50-2719ef07d0b1@ti.com>","From":"Doug Anderson ","Date":"Fri, 22 Sep 2017 09:45:11 -0700","X-Google-Sender-Auth":"J7Fx8mdZQghLGvPlShjKLVEdek4","Message-ID":"","Subject":"Re: [PATCH v2 0/4] phy: rockchip-typec: Set \"flip\" properly; some\n\tcleanups; fix swing","To":"Kishon Vijay Abraham I ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_094536_288794_865A185A ","X-CRM114-Status":"GOOD ( 15.36 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:236 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Shawn Nematbakhsh , =?utf-8?q?Heiko_St=C3=BCbner?=\n\t, \"open list:ARM/Rockchip SoC...\"\n\t, \"linux-kernel@vger.kernel.org\"\n\t, \n\tDavid Schneider ,\n\tGuenter Roeck , Chris ,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]