[{"id":1771421,"web_url":"http://patchwork.ozlabs.org/comment/1771421/","msgid":"<2FF7DE2C-FDFD-4D4B-9C0E-0A7D71DF1AB4@vmware.com>","list_archive_url":null,"date":"2017-09-19T21:38:41","subject":"Re: [ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"Hi Bhanu\n\nYou have many instances where you want to use DP_PACKET_BATCH_FOR_EACH\nYou have another series partially about this:\nhttps://patchwork.ozlabs.org/patch/813007/\n\nAlso, this series mixes in other changes like creating new variables for clarity, I guess,\nand removing unneeded variables. which anyways has different motivation but part of the same patch.\n\nDo you think it makes sense to group the DP_PACKET_BATCH_FOR_EACH changes in \none patch and splice out the other changes as other patches in the same series by same theme ?\n\nThanks \nDarrell\n\nOn 9/19/17, 12:39 PM, \"ovs-dev-bounces@openvswitch.org on behalf of Bhanuprakash Bodireddy\" wrote:\n\n DP_PACKET_BATCH_FOR_EACH macro was introduced early this year as part\n of enhancing packet batch APIs. Commit '72c84bc2' implemented this macro\n and replaced most of the calling sites with macros and simplified the logic.\n \n However there are still many APIs that needs to be fixed.\n This patch series is a simple and straightforward set of changes\n aimed at using DP_PACKET_BATCH_FOR_EACH macro at all appropriate places.\n Also minor code cleanup is done to improve readability of the code.\n \n No functionality changes and no performance impact with this series.\n \n Bhanuprakash Bodireddy (10):\n netdev-linux: Clean up netdev_linux_sock_batch_send().\n netdev-linux: Use DP_PACKET_BATCH_FOR_EACH in\n netdev_linux_tap_batch_send.\n netdev-dpdk: Cleanup dpdk_do_tx_copy.\n netdev-dpdk: Minor cleanup of netdev_dpdk_send__.\n netdev-dpdk: Use DP_PACKET_BATCH_FOR_EACH in netdev_dpdk_ring_send\n netdev-bsd: Use DP_PACKET_BATCH_FOR_EACH in netdev_bsd_send.\n odp-execute: Use const qualifer for batch size.\n dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in dp_netdev_run_meter.\n dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in fast_path_processing.\n dpif-netdev: Remove 'cnt' in dp_netdev_input__().\n \n lib/dpif-netdev.c | 33 +++++++++++++++------------------\n lib/netdev-bsd.c | 7 ++++---\n lib/netdev-dpdk.c | 40 +++++++++++++++++++---------------------\n lib/netdev-linux.c | 17 +++++++++--------\n lib/odp-execute.c | 3 ++-\n 5 files changed, 49 insertions(+), 51 deletions(-)\n \n -- \n 2.4.11\n _______________________________________________\n dev mailing list\n dev@openvswitch.org\n https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=XiubftJP8lYJL_SPaytZ9IvK97Hxqfr-TwV3fcbd2Qw&s=NzGP8ioHmW7p2aaJepNTw7ayyFxEmuPXEnYpmoN7yOU&e=","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Ast+13KM\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxbpy1Z9Wz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 07:38:49 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id D064DB4C;\n\tTue, 19 Sep 2017 21:38:45 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id BDCCA98C\n\tfor ; Tue, 19 Sep 2017 21:38:44 +0000 (UTC)","from NAM01-BN3-obe.outbound.protection.outlook.com\n\t(mail-bn3nam01on0088.outbound.protection.outlook.com [104.47.33.88])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CDBD3204\n\tfor ; Tue, 19 Sep 2017 21:38:43 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3039.namprd05.prod.outlook.com (10.168.246.145) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Tue, 19 Sep 2017 21:38:41 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Tue, 19 Sep 2017 21:38:41 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=cWkiao7udxjhgrd+/tPPzxJpVHxfdalsJ2fdc4Qp5qk=;\n\tb=Ast+13KMKNa5fCxA1GFfTuVmP11dgEqAU5Bp2B2+uUC0YbRLAeEYTjVtgoF8nfIBdLN7Utj45h442DoJhyC0NYsQqk3gavv09W1rxMN0gRg9A+jm5WZAFasmmF+B6UYXZfstI5bxmhJ8Mfe3+pXzDuuRVghYcGr3g3kiG8ysTC0=","From":"Darrell Ball ","To":"Bhanuprakash Bodireddy ,\n\t\"dev@openvswitch.org\" ","Thread-Topic":"[ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.","Thread-Index":"AQHTMX7z28clXUD4m0aLpLR2Njp+GqK8vFIA","Date":"Tue, 19 Sep 2017 21:38:41 +0000","Message-ID":"<2FF7DE2C-FDFD-4D4B-9C0E-0A7D71DF1AB4@vmware.com>","References":"<1505849344-52387-1-git-send-email-bhanuprakash.bodireddy@intel.com>","In-Reply-To":"<1505849344-52387-1-git-send-email-bhanuprakash.bodireddy@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"Ast+13KM\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3039;\n\t20:hlOEZGtwXeOYM9z/PhgXhpIdKMNOP5KiABNp1APGQsO0LR+oD0+y9dFfnQmPTJbQVgPoie1RHhkwbKuyKQMOxwW5WHLr8XRnKkr2p1uZoZHFcqH5W9qrPYYDexWWzcsXnJ5ACsU7od0tM5WOHoeiRs4laEZNNikWgF47UYQ/iXY=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"e46bd5ea-8b42-4026-eed1-08d4ffa6cbc8","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR05MB3039; ","x-ms-traffictypediagnostic":"MWHPR05MB3039:","x-exchange-antispam-report-test":"UriScan:(10436049006162)(216315784871565)(228905959029699); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3039; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3039; ","x-forefront-prvs":"04359FAD81","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(199003)(24454002)(377454003)(189002)(3280700002)(6436002)(83506001)(81156014)(82746002)(2501003)(6506006)(33656002)(3660700001)(105586002)(97736004)(102836003)(76176999)(81166006)(8676002)(478600001)(6116002)(54356999)(966005)(50986999)(3846002)(101416001)(110136005)(86362001)(5660300001)(2906002)(68736007)(66066001)(189998001)(53546010)(229853002)(25786009)(2900100001)(36756003)(14454004)(305945005)(6486002)(53936002)(77096006)(8936002)(6246003)(7736002)(316002)(6306002)(6512007)(58126008)(83716003)(99286003)(2950100002)(106356001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3039;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<2D9245C57CBC3A4EBD3076D290FEE55D@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"19 Sep 2017 21:38:41.2492\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3039","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1771848,"web_url":"http://patchwork.ozlabs.org/comment/1771848/","msgid":"<7EE4206A5F421D4FBA0A4623185DE2BD37510AC4@IRSMSX104.ger.corp.intel.com>","list_archive_url":null,"date":"2017-09-20T13:31:46","subject":"Re: [ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"content":"Hi Darrell,\n\n>You have many instances where you want to use\n>DP_PACKET_BATCH_FOR_EACH You have another series partially about this:\n>https://patchwork.ozlabs.org/patch/813007/\n>\n>Also, this series mixes in other changes like creating new variables for clarity, I\n>guess, and removing unneeded variables. which anyways has different\n>motivation but part of the same patch.\n>\n>Do you think it makes sense to group the DP_PACKET_BATCH_FOR_EACH\n>changes in one patch and splice out the other changes as other patches in the\n>same series by same theme ?\n\nThat makes sense and I sent out a v2 by merging the 2 patches of my previous series. \nThis time the patches are grouped and I added the details in the cover letter under version info.\n\nCover letter: https://mail.openvswitch.org/pipermail/ovs-dev/2017-September/338990.html\nhttps://patchwork.ozlabs.org/patch/816191/\n\n- Bhanuprakash.\n\n>\n>Thanks\n>Darrell\n>\n>On 9/19/17, 12:39 PM, \"ovs-dev-bounces@openvswitch.org on behalf of\n>Bhanuprakash Bodireddy\" bhanuprakash.bodireddy@intel.com> wrote:\n>\n> DP_PACKET_BATCH_FOR_EACH macro was introduced early this year as\n>part\n> of enhancing packet batch APIs. Commit '72c84bc2' implemented this macro\n> and replaced most of the calling sites with macros and simplified the logic.\n>\n> However there are still many APIs that needs to be fixed.\n> This patch series is a simple and straightforward set of changes\n> aimed at using DP_PACKET_BATCH_FOR_EACH macro at all appropriate\n>places.\n> Also minor code cleanup is done to improve readability of the code.\n>\n> No functionality changes and no performance impact with this series.\n>\n> Bhanuprakash Bodireddy (10):\n> netdev-linux: Clean up netdev_linux_sock_batch_send().\n> netdev-linux: Use DP_PACKET_BATCH_FOR_EACH in\n> netdev_linux_tap_batch_send.\n> netdev-dpdk: Cleanup dpdk_do_tx_copy.\n> netdev-dpdk: Minor cleanup of netdev_dpdk_send__.\n> netdev-dpdk: Use DP_PACKET_BATCH_FOR_EACH in\n>netdev_dpdk_ring_send\n> netdev-bsd: Use DP_PACKET_BATCH_FOR_EACH in netdev_bsd_send.\n> odp-execute: Use const qualifer for batch size.\n> dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in\n>dp_netdev_run_meter.\n> dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in fast_path_processing.\n> dpif-netdev: Remove 'cnt' in dp_netdev_input__().\n>\n> lib/dpif-netdev.c | 33 +++++++++++++++------------------\n> lib/netdev-bsd.c | 7 ++++---\n> lib/netdev-dpdk.c | 40 +++++++++++++++++++---------------------\n> lib/netdev-linux.c | 17 +++++++++--------\n> lib/odp-execute.c | 3 ++-\n> 5 files changed, 49 insertions(+), 51 deletions(-)\n>\n> --\n> 2.4.11\n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://urldefense.proofpoint.com/v2/url?u=https-\n>3A__mail.openvswitch.org_mailman_listinfo_ovs-\n>2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-\n>uZnsw&m=XiubftJP8lYJL_SPaytZ9IvK97Hxqfr-\n>TwV3fcbd2Qw&s=NzGP8ioHmW7p2aaJepNTw7ayyFxEmuPXEnYpmoN7yOU&\n>e=\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy0zT5n3Bz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 23:32:37 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 8F70EB8B;\n\tWed, 20 Sep 2017 13:31:54 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 37F8CB8B\n\tfor ; Wed, 20 Sep 2017 13:31:53 +0000 (UTC)","from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id A6A1F421\n\tfor ; Wed, 20 Sep 2017 13:31:52 +0000 (UTC)","from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Sep 2017 06:31:48 -0700","from irsmsx105.ger.corp.intel.com ([163.33.3.28])\n\tby fmsmga005.fm.intel.com with ESMTP; 20 Sep 2017 06:31:47 -0700","from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by\n\tirsmsx105.ger.corp.intel.com ([169.254.7.75]) with mapi id\n\t14.03.0319.002; Wed, 20 Sep 2017 14:31:47 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,421,1500966000\"; d=\"scan'208\";a=\"153520169\"","From":"\"Bodireddy, Bhanuprakash\" ","To":"Darrell Ball , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.","Thread-Index":"AQHTMX7zcjHsfeNncU+nAZIaSHAuyaK8q5CAgAEZfAA=","Date":"Wed, 20 Sep 2017 13:31:46 +0000","Message-ID":"<7EE4206A5F421D4FBA0A4623185DE2BD37510AC4@IRSMSX104.ger.corp.intel.com>","References":"<1505849344-52387-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<2FF7DE2C-FDFD-4D4B-9C0E-0A7D71DF1AB4@vmware.com>","In-Reply-To":"<2FF7DE2C-FDFD-4D4B-9C0E-0A7D71DF1AB4@vmware.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.181]","MIME-Version":"1.0","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]