[{"id":1778327,"web_url":"http://patchwork.ozlabs.org/comment/1778327/","msgid":"<2b614c1d-f1e2-ec38-092d-2c489b90bd55@denx.de>","list_archive_url":null,"date":"2017-10-02T13:29:11","subject":"Re: [U-Boot] [PATCH 0/6] i.MX6Q: Add SPL_OF_CONTROL support","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"Hi Jagan,\n\nOn 19/09/2017 20:37, Jagan Teki wrote:\n> From: Jagan Teki \n> \n> This series add OF_CONTROL support for SPL on Engicam i.MX6QDL\n> boards, along with proper code optimzation changes.\n> \n> \n> Jagan Teki (6):\n> i.MX6: engicam: Fix MAINTAINERS/README\n> imx6ul: geam6ul/isiot: Fix to MMC devices\n> i.MX6: engicam: Move set_fdt_file to common\n> i.MX6Q: icorem6: Move spl load fit to common/spl\n> i.MX6Q: icore: Add SPL_OF_CONTROL support\n> i.MX6Q: icore: Add imx6q board for icore/icore_rqs\n> \n> arch/arm/dts/imx6qdl-icore-rqs.dtsi | 2 +\n> arch/arm/dts/imx6qdl-icore.dtsi | 2 +\n> arch/arm/dts/imx6qdl.dtsi | 5 +\n> arch/arm/mach-imx/mx6/Kconfig | 24 +--\n> board/engicam/common/board.c | 24 +++\n> board/engicam/common/board.h | 1 -\n> board/engicam/common/spl.c | 16 ++\n> board/engicam/geam6ul/MAINTAINERS | 2 +-\n> board/engicam/geam6ul/geam6ul.c | 6 -\n> board/engicam/icorem6/README | 33 ----\n> board/engicam/icorem6_rqs/Kconfig | 12 --\n> board/engicam/icorem6_rqs/MAINTAINERS | 9 --\n> board/engicam/icorem6_rqs/Makefile | 6 -\n> board/engicam/icorem6_rqs/icorem6_rqs.c | 171 ---------------------\n> board/engicam/{icorem6 => imx6q}/Kconfig | 2 +-\n> board/engicam/{icorem6 => imx6q}/MAINTAINERS | 10 +-\n> board/engicam/{icorem6 => imx6q}/Makefile | 2 +-\n> board/engicam/{icorem6_rqs => imx6q}/README | 12 +-\n> board/engicam/{icorem6/icorem6.c => imx6q/imx6q.c} | 108 +++----------\n> board/engicam/isiotmx6ul/MAINTAINERS | 2 +-\n> board/engicam/isiotmx6ul/isiotmx6ul.c | 11 --\n> configs/imx6qdl_icore_mmc_defconfig | 1 +\n> configs/imx6qdl_icore_rqs_defconfig | 3 +-\n> configs/imx6ul_geam_mmc_defconfig | 1 -\n> configs/imx6ul_isiot_emmc_defconfig | 1 -\n> configs/imx6ul_isiot_mmc_defconfig | 1 -\n> include/configs/imx6-engicam.h | 22 +--\n> 27 files changed, 112 insertions(+), 377 deletions(-)\n> delete mode 100644 board/engicam/icorem6/README\n> delete mode 100644 board/engicam/icorem6_rqs/Kconfig\n> delete mode 100644 board/engicam/icorem6_rqs/MAINTAINERS\n> delete mode 100644 board/engicam/icorem6_rqs/Makefile\n> delete mode 100644 board/engicam/icorem6_rqs/icorem6_rqs.c\n> rename board/engicam/{icorem6 => imx6q}/Kconfig (87%)\n> rename board/engicam/{icorem6 => imx6q}/MAINTAINERS (51%)\n> rename board/engicam/{icorem6 => imx6q}/Makefile (80%)\n> rename board/engicam/{icorem6_rqs => imx6q}/README (68%)\n> rename board/engicam/{icorem6/icorem6.c => imx6q/imx6q.c} (73%)\n> \n\nI cannot build your boards when I apply the patchset\n(CONFIG_SYS_FSL_ESDHC_ADDR is away now):\n\n\nBuilding current source for 8 boards (8 threads, 1 job per thread)\n arm: + imx6ul_isiot_emmc\n+drivers/mmc/fsl_esdhc.c: In function 'fsl_esdhc_mmc_init':\n+drivers/mmc/fsl_esdhc.c:934:20: error: 'CONFIG_SYS_FSL_ESDHC_ADDR'\nundeclared (first use in this function)\n+ cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;\n+ ^\n+drivers/mmc/fsl_esdhc.c:934:20: note: each undeclared identifier is\nreported only once for each function it appears in\n+make[4]: *** [spl/drivers/mmc/fsl_esdhc.o] Error 1\n+make[3]: *** [spl/drivers/mmc] Error 2\n+make[2]: *** [spl/drivers] Error 2\n+make[1]: *** [spl/u-boot-spl] Error 2\n+make: *** [sub-make] Error 2\n arm: + imx6ul_geam_mmc\n+drivers/mmc/fsl_esdhc.c: In function 'fsl_esdhc_mmc_init':\n+drivers/mmc/fsl_esdhc.c:934:20: error: 'CONFIG_SYS_FSL_ESDHC_ADDR'\nundeclared (first use in this function)\n+ cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;\n+ ^\n+drivers/mmc/fsl_esdhc.c:934:20: note: each undeclared identifier is\nreported only once for each function it appears in\n+make[4]: *** [spl/drivers/mmc/fsl_esdhc.o] Error 1\n+make[3]: *** [spl/drivers/mmc] Error 2\n+make[2]: *** [spl/drivers] Error 2\n+make[1]: *** [spl/u-boot-spl] Error 2\n+make: *** [sub-make] Error 2\n arm: + imx6ul_isiot_mmc\n+drivers/mmc/fsl_esdhc.c: In function 'fsl_esdhc_mmc_init':\n+drivers/mmc/fsl_esdhc.c:934:20: error: 'CONFIG_SYS_FSL_ESDHC_ADDR'\nundeclared (first use in this function)\n+ cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;\n\nCould you take a look, please ?\n\nThanks,\nStefano","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5NLG5TlXz9t50\n\tfor ;\n\tTue, 3 Oct 2017 00:29:26 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 46C37C21E50; Mon, 2 Oct 2017 13:29:22 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 09059C21C41;\n\tMon, 2 Oct 2017 13:29:19 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D7A57C21C41; Mon, 2 Oct 2017 13:29:16 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 7AD57C21C29\n\tfor ; Mon, 2 Oct 2017 13:29:16 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y5NL40rTGz1qsVq;\n\tMon, 2 Oct 2017 15:29:16 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y5NL36nFTz1qr4S;\n\tMon, 2 Oct 2017 15:29:15 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id j_mfI46MQ_U5; Mon, 2 Oct 2017 15:29:14 +0200 (CEST)","from babic.homelinux.org (host-88-217-136-221.customer.m-online.net\n\t[88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tMon, 2 Oct 2017 15:29:14 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 6886D45405F9;\n\tMon, 2 Oct 2017 15:29:14 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id DjaL-altV1Ku; Mon, 2 Oct 2017 15:29:11 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id AAE5245405AB;\n\tMon, 2 Oct 2017 15:29:11 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"To":"Jagan Teki , Stefano Babic ","References":"<1505846281-19020-1-git-send-email-jteki@openedev.com>","From":"Stefano Babic ","Message-ID":"<2b614c1d-f1e2-ec38-092d-2c489b90bd55@denx.de>","Date":"Mon, 2 Oct 2017 15:29:11 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505846281-19020-1-git-send-email-jteki@openedev.com>","Content-Language":"de-DE","Cc":"Fabio Estevam , u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH 0/6] i.MX6Q: Add SPL_OF_CONTROL support","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]