[{"id":1771347,"web_url":"http://patchwork.ozlabs.org/comment/1771347/","msgid":"<80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com>","list_archive_url":null,"date":"2017-09-19T20:04:56","subject":"Re: [PATCH net-next 0/4] net: dsa: move master ethtool code","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/19/2017 08:56 AM, Vivien Didelot wrote:\n> The DSA core overrides the master device's ethtool_ops structure so that\n> it can inject statistics and such of its dedicated switch CPU port.\n> \n> This ethtool code is currently called on unnecessary conditions or\n> before the master interface and its switch CPU port get wired up.\n> This patchset fixes this.\n> \n> Similarly to slave.c where the DSA slave net_device is the entry point\n> of the dsa_slave_* functions, this patchset also isolates the master's\n> ethtool code in a new master.c file, where the DSA master net_device is\n> the entry point of the dsa_master_* functions.\n> \n> This is a first step towards better control of the master device and\n> support for multiple CPU ports.\n\nTested-by: Florian Fainelli \n\n* ethtool -S eth0 -> switch port CPU stats are still correctly overlayed\n* ethtool -s gphy wol g -> both switch port and CPU port correctly\nenable WoL\n* ethtool -i eth0 -> driver still reports correct information\n\nThanks!\n\n> \n> Vivien Didelot (4):\n> net: dsa: remove copy of master ethtool_ops\n> net: dsa: setup master ethtool unconditionally\n> net: dsa: setup master ethtool after dsa_ptr\n> net: dsa: move master ethtool code\n> \n> include/net/dsa.h | 1 -\n> net/dsa/Makefile | 2 +-\n> net/dsa/dsa.c | 28 -------------\n> net/dsa/dsa2.c | 18 ++++----\n> net/dsa/dsa_priv.h | 7 ++--\n> net/dsa/legacy.c | 10 ++---\n> net/dsa/master.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++++++++\n> net/dsa/slave.c | 80 -----------------------------------\n> 8 files changed, 136 insertions(+), 130 deletions(-)\n> create mode 100644 net/dsa/master.c\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"rCSj91wv\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxYl33w4vz9sNV\n\tfor ;\n\tWed, 20 Sep 2017 06:05:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751640AbdISUFG (ORCPT );\n\tTue, 19 Sep 2017 16:05:06 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:38036 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751341AbdISUFC (ORCPT\n\t); Tue, 19 Sep 2017 16:05:02 -0400","by mail-wm0-f65.google.com with SMTP id x17so596508wmd.5;\n\tTue, 19 Sep 2017 13:05:01 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tz108sm131200wrc.49.2017.09.19.13.04.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 13:04:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=fu5P4Gl7Aywa6axry6f/jFm4c7fFpTeEYJFoKGf0+Ng=;\n\tb=rCSj91wvf0a+Rgl4NAi51kTAPkFP3+Lj7SrKEfbqFOr60Ky8KdBY4TmT4dHZG8BFgT\n\tM3yxa4wvevMYcUK67vGil7qbiM5gg5OzJY/J5OlQzs7LmdC1CqZcAEQz/rDz1k/6ZrXH\n\tLQYvsq7mz6hMeC8OuPT9vkf9Cxq8KUUp4Ha+CypWoalhkJkg4UWvN5W7KvP/8DtU8Y54\n\tId1SOQOEIcnM2tU2Uz2u5dvpJrWO08xNdaVE911kHNNHfVupBVqjf0l9p9ivqYLNa5UJ\n\trjfr5NgmuGkd5nHLqm/r/CbGsGXnqSGhcmRLojjnUj3gjUsLrReAbSEknMh3w1qoHH01\n\tSR8Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=fu5P4Gl7Aywa6axry6f/jFm4c7fFpTeEYJFoKGf0+Ng=;\n\tb=AYwNFrkEpDCoephQ2e+Z9619K4snHAJE/zuJGNv/yr01TDSHYvXV7fNIf3UvxBomGi\n\tPtl+Krz/uDvcNrcSSNsYnpCQEJZRc2zVuRKObbNCruPKMqGc8f8eilMQDsKAON+X066A\n\t7/HRtM+9h5mdRae5Hb6NpeDGUbpJjQ/Tk6cgZ3ICiuu8lYN06nPzZt0d94oyPbi9BKEt\n\tUekCOCXo4GMkJwdMEH/GAmOAciPQ6ydM0ifZ+qCS92lcYbQGpGU2Cod6bTAPBvl+LnGF\n\tYIh7toI6tJNn7dnyN32mNU8Gv1Gxdn4rZ9vYlXIVRDkCvXhABTdWPgtzYS6wXlP34NAS\n\t2eoQ==","X-Gm-Message-State":"AHPjjUiJV58OCsRZhRV20Im7y6IBXBCxx9Dhsan5xeczTrFkizsYV5N1\n\tXuO4dvsO1gWiWg6j/TvgmjT6tmoD","X-Google-Smtp-Source":"AOwi7QDoYxf4PBCKjP+GDnGZ6iGzgQIJQRCZ5IrxSjDrfWOh1jrFzU5o9nTi0qtmPUZXYK8V1DIgdQ==","X-Received":"by 10.28.26.15 with SMTP id a15mr2184355wma.16.1505851501014;\n\tTue, 19 Sep 2017 13:05:01 -0700 (PDT)","Subject":"Re: [PATCH net-next 0/4] net: dsa: move master ethtool code","To":"Vivien Didelot ,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" , Andrew Lunn ","References":"<20170919155700.14474-1-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli ","Message-ID":"<80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com>","Date":"Tue, 19 Sep 2017 13:04:56 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170919155700.14474-1-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771448,"web_url":"http://patchwork.ozlabs.org/comment/1771448/","msgid":"<20170919.160438.114096071481057977.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T23:04:38","subject":"Re: [PATCH net-next 0/4] net: dsa: move master ethtool code","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Florian Fainelli \nDate: Tue, 19 Sep 2017 13:04:56 -0700\n\n> On 09/19/2017 08:56 AM, Vivien Didelot wrote:\n>> The DSA core overrides the master device's ethtool_ops structure so that\n>> it can inject statistics and such of its dedicated switch CPU port.\n>> \n>> This ethtool code is currently called on unnecessary conditions or\n>> before the master interface and its switch CPU port get wired up.\n>> This patchset fixes this.\n>> \n>> Similarly to slave.c where the DSA slave net_device is the entry point\n>> of the dsa_slave_* functions, this patchset also isolates the master's\n>> ethtool code in a new master.c file, where the DSA master net_device is\n>> the entry point of the dsa_master_* functions.\n>> \n>> This is a first step towards better control of the master device and\n>> support for multiple CPU ports.\n> \n> Tested-by: Florian Fainelli \n> \n> * ethtool -S eth0 -> switch port CPU stats are still correctly overlayed\n> * ethtool -s gphy wol g -> both switch port and CPU port correctly\n> enable WoL\n> * ethtool -i eth0 -> driver still reports correct information\n\nSeries applied, thanks everyone.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxdkF08G4z9sNw\n\tfor ;\n\tWed, 20 Sep 2017 09:04:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751636AbdISXEk (ORCPT );\n\tTue, 19 Sep 2017 19:04:40 -0400","from shards.monkeyblade.net ([184.105.139.130]:49968 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751575AbdISXEj (ORCPT\n\t); Tue, 19 Sep 2017 19:04:39 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id CADD8102CD0E5;\n\tTue, 19 Sep 2017 16:04:38 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 16:04:38 -0700 (PDT)","Message-Id":"<20170919.160438.114096071481057977.davem@davemloft.net>","To":"f.fainelli@gmail.com","Cc":"vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, andrew@lunn.ch","Subject":"Re: [PATCH net-next 0/4] net: dsa: move master ethtool code","From":"David Miller ","In-Reply-To":"<80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com>","References":"<20170919155700.14474-1-vivien.didelot@savoirfairelinux.com>\n\t<80b8afa0-e269-c0b7-da4a-dcb604a239ca@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 16:04:39 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]