[{"id":1772004,"web_url":"http://patchwork.ozlabs.org/comment/1772004/","msgid":"<20170920171458.0f6d88a3.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-20T15:14:58","subject":"Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 19 Sep 2017 16:26:51 +0200\nDavid Hildenbrand wrote:\n\n> Some leftover from \"target/s390x: tcg improvments + MSA functions\".\n> \n> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide\n> the query subfunction (to query available subfunctions), no actual\n> de/encryption yet. Good enough to unlock the STFL bits.\n> \n> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will\n> send them out soon. I use the following cpu model to test with an upstream\n> kernel compiled for z10:\n> \n> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\\\n> eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\\\n> exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ...\n> \n> Based on: https://github.com/cohuck/qemu.git s390-next\n> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa\n\nDo I understand correctly that you'll send a v3 with changes to patch 3?\n\nIf yes, I'll just wait and pick that.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy3z51JRwz9s7c\n\tfor ;\n\tThu, 21 Sep 2017 01:47:29 +1000 (AEST)","from localhost ([::1]:49065 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duhDi-00050W-DI\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 11:47:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38732)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dugkE-00057d-SF\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:17:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dugil-0000VX-AE\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:16:58 -0400","from mx1.redhat.com ([209.132.183.28]:56638)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dugil-0000V1-3w\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:15:27 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 046E12CE911;\n\tWed, 20 Sep 2017 15:15:26 +0000 (UTC)","from gondolin (ovpn-117-98.ams2.redhat.com [10.36.117.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DF91B5D991;\n\tWed, 20 Sep 2017 15:15:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 046E12CE911","Date":"Wed, 20 Sep 2017 17:14:58 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170920171458.0f6d88a3.cohuck@redhat.com>","In-Reply-To":"<20170919142654.16369-1-david@redhat.com>","References":"<20170919142654.16369-1-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 20 Sep 2017 15:15:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Aurelien Jarno ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772009,"web_url":"http://patchwork.ozlabs.org/comment/1772009/","msgid":"","list_archive_url":null,"date":"2017-09-20T15:17:33","subject":"Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 20.09.2017 17:14, Cornelia Huck wrote:\n> On Tue, 19 Sep 2017 16:26:51 +0200\n> David Hildenbrand wrote:\n> \n>> Some leftover from \"target/s390x: tcg improvments + MSA functions\".\n>>\n>> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide\n>> the query subfunction (to query available subfunctions), no actual\n>> de/encryption yet. Good enough to unlock the STFL bits.\n>>\n>> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will\n>> send them out soon. I use the following cpu model to test with an upstream\n>> kernel compiled for z10:\n>>\n>> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\\\n>> eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\\\n>> exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ...\n>>\n>> Based on: https://github.com/cohuck/qemu.git s390-next\n>> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa\n> \n> Do I understand correctly that you'll send a v3 with changes to patch 3?\n> \n> If yes, I'll just wait and pick that.\n> \n\nIt is really just dropping one superfluous check in patch nr 3.\n\nSo you can either fix that up or I can resend, whatever you prefer.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy45q5TY4z9s7c\n\tfor ;\n\tThu, 21 Sep 2017 01:53:19 +1000 (AEST)","from localhost ([::1]:49109 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duhJN-0001D0-PD\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 11:53:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40235)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dugl9-0006Bq-Ay\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:18:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dugkr-0002A8-8b\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:17:55 -0400","from mx1.redhat.com ([209.132.183.28]:39814)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dugkq-00028q-Rs\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:17:37 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C3D138123E;\n\tWed, 20 Sep 2017 15:17:35 +0000 (UTC)","from [10.36.116.124] (ovpn-116-124.ams2.redhat.com [10.36.116.124])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4676C60472;\n\tWed, 20 Sep 2017 15:17:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C3D138123E","To":"Cornelia Huck ","References":"<20170919142654.16369-1-david@redhat.com>\n\t<20170920171458.0f6d88a3.cohuck@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Wed, 20 Sep 2017 17:17:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170920171458.0f6d88a3.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 20 Sep 2017 15:17:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Aurelien Jarno ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772014,"web_url":"http://patchwork.ozlabs.org/comment/1772014/","msgid":"<20170920172413.68b4c14f.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-20T15:24:13","subject":"Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 20 Sep 2017 17:17:33 +0200\nDavid Hildenbrand wrote:\n\n> On 20.09.2017 17:14, Cornelia Huck wrote:\n> > On Tue, 19 Sep 2017 16:26:51 +0200\n> > David Hildenbrand wrote:\n> > \n> >> Some leftover from \"target/s390x: tcg improvments + MSA functions\".\n> >>\n> >> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide\n> >> the query subfunction (to query available subfunctions), no actual\n> >> de/encryption yet. Good enough to unlock the STFL bits.\n> >>\n> >> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will\n> >> send them out soon. I use the following cpu model to test with an upstream\n> >> kernel compiled for z10:\n> >>\n> >> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\\\n> >> eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\\\n> >> exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ...\n> >>\n> >> Based on: https://github.com/cohuck/qemu.git s390-next\n> >> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa \n> > \n> > Do I understand correctly that you'll send a v3 with changes to patch 3?\n> > \n> > If yes, I'll just wait and pick that.\n> > \n> \n> It is really just dropping one superfluous check in patch nr 3.\n> \n> So you can either fix that up or I can resend, whatever you prefer.\n> \n\nPlease just resend before I start mucking around in patches again.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy48t2Wmsz9sPt\n\tfor ;\n\tThu, 21 Sep 2017 01:55:57 +1000 (AEST)","from localhost ([::1]:49142 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duhLv-0003LP-0h\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 11:55:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49028)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dugrR-0002vK-SC\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:24:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dugrN-0000Bh-7e\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:24:25 -0400","from mx1.redhat.com ([209.132.183.28]:52722)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dugrM-0000Ab-Ul\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:24:21 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C2B95C0587C1;\n\tWed, 20 Sep 2017 15:24:19 +0000 (UTC)","from gondolin (ovpn-117-98.ams2.redhat.com [10.36.117.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 395EB6060A;\n\tWed, 20 Sep 2017 15:24:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C2B95C0587C1","Date":"Wed, 20 Sep 2017 17:24:13 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170920172413.68b4c14f.cohuck@redhat.com>","In-Reply-To":"","References":"<20170919142654.16369-1-david@redhat.com>\n\t<20170920171458.0f6d88a3.cohuck@redhat.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 20 Sep 2017 15:24:19 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Richard Henderson ,\n\tqemu-devel@nongnu.org, Aurelien Jarno ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]