[{"id":1770920,"web_url":"http://patchwork.ozlabs.org/comment/1770920/","msgid":"<AA41F043-D490-4880-ABA8-099A8B0187D9@theobroma-systems.com>","list_archive_url":null,"date":"2017-09-19T12:12:10","subject":"Re: [U-Boot] [U-Boot,v2,00/14] Add rockchip SARADC support","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"David,\n\n> On 19 Sep 2017, at 12:53, David Wu <david.wu@rock-chips.com> wrote:\n> \n> The SARADC is used for adc keys and charging detect at uboot\n> loader. Except for the rk3036 and rk3228 Socs, the others\n> support the SARADC IP.\n\nI am hoping to apply this series later this week (and include in a PR for\non next Monday), but some of these patches still have an empty commit\nmessage.\n\nCould you fix the empty commit messages and send a v3?\nAlso: it would be very helpful, if you sent these out using patman and\nused the ‘Series-changes’ tag, so I know what changed in each version.\n\nSee tools/patman/README for info...\n\nThanks,\nPhilipp.\n\n> David Wu (14):\n>  adc: Add driver for Rockchip SARADC\n>  configs: rockchip: Enable the ROCKCHIP_SARADC config\n>  clk: rockchip: Add rv1108 SARADC clock support\n>  clk: rockchip: Add SARADC clock support for rk3288\n>  clk: rockchip: Add rk3328 SARADC clock support\n>  clk: rockchip: Add rk3368 SARADC clock support\n>  clk: rockchip: Add rk3399 SARADC clock support\n>  arm: dts: rv1108: Add Saradc node at dtsi level\n>  arm: dts: Enable SARADC for rv1108-evb\n>  arm: dts: Enable SARADC for rk3288-popmetal\n>  arm: dts: Enable SARADC for rk3328-evb\n>  arm: dts: Enable SARADC for rk3368-px5-evb\n>  arm: dts: Enable SARADC for rk3368-sheep\n>  arm: dts: Enable SARADC for rk3399-evb\n> \n> arch/arm/dts/rk3288-popmetal.dtsi               |   4 +\n> arch/arm/dts/rk3328-evb.dts                     |   4 +\n> arch/arm/dts/rk3368-px5-evb.dts                 |   4 +\n> arch/arm/dts/rk3368-sheep.dts                   |   4 +\n> arch/arm/dts/rk3399-evb.dts                     |   4 +\n> arch/arm/dts/rv1108-evb.dts                     |   4 +\n> arch/arm/dts/rv1108.dtsi                        |  11 ++\n> arch/arm/include/asm/arch-rockchip/cru_rk3368.h |   5 +\n> arch/arm/include/asm/arch-rockchip/cru_rv1108.h |   5 +\n> configs/chromebit_mickey_defconfig              |   2 +\n> configs/chromebook_jerry_defconfig              |   2 +\n> configs/chromebook_minnie_defconfig             |   2 +\n> configs/evb-px5_defconfig                       |   2 +\n> configs/evb-rk3288_defconfig                    |   2 +\n> configs/evb-rk3328_defconfig                    |   2 +\n> configs/evb-rk3399_defconfig                    |   2 +\n> configs/evb-rv1108_defconfig                    |   2 +\n> configs/fennec-rk3288_defconfig                 |   2 +\n> configs/firefly-rk3288_defconfig                |   2 +\n> configs/firefly-rk3399_defconfig                |   2 +\n> configs/geekbox_defconfig                       |   2 +\n> configs/lion-rk3368_defconfig                   |   2 +\n> configs/miqi-rk3288_defconfig                   |   2 +\n> configs/phycore-rk3288_defconfig                |   2 +\n> configs/popmetal-rk3288_defconfig               |   2 +\n> configs/puma-rk3399_defconfig                   |   2 +\n> configs/rock2_defconfig                         |   2 +\n> configs/rock_defconfig                          |   2 +\n> configs/sheep-rk3368_defconfig                  |   2 +\n> configs/tinker-rk3288_defconfig                 |   2 +\n> drivers/adc/Kconfig                             |   9 ++\n> drivers/adc/Makefile                            |   1 +\n> drivers/adc/rockchip-saradc.c                   | 183 ++++++++++++++++++++++++\n> drivers/clk/rockchip/clk_rk3288.c               |  41 ++++++\n> drivers/clk/rockchip/clk_rk3328.c               |  35 ++++-\n> drivers/clk/rockchip/clk_rk3368.c               |  32 +++++\n> drivers/clk/rockchip/clk_rk3399.c               |  36 ++++-\n> drivers/clk/rockchip/clk_rv1108.c               |  33 ++++-\n> include/dt-bindings/clock/rv1108-cru.h          |   2 +\n> 39 files changed, 456 insertions(+), 3 deletions(-)\n> create mode 100644 drivers/adc/rockchip-saradc.c\n> \n> -- \n> 2.7.4\n> \n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMF84DdJz9s4q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 22:12:11 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 03613C21F6A; Tue, 19 Sep 2017 12:12:01 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A461CC21EFE;\n\tTue, 19 Sep 2017 12:11:58 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8D09DC21EFE; Tue, 19 Sep 2017 12:11:57 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 53B56C21DA1\n\tfor <u-boot@lists.denx.de>; Tue, 19 Sep 2017 12:11:57 +0000 (UTC)","from [86.59.122.178] (port=57869 helo=[10.4.9.36])\n\tby mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from <philipp.tomsich@theobroma-systems.com>)\n\tid 1duHNR-00049D-56; Tue, 19 Sep 2017 14:11:45 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"*","X-Spam-Status":"No, score=1.0 required=5.0 tests=HK_NAME_DR autolearn=no\n\tautolearn_force=no version=3.4.0","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"\"Dr. Philipp Tomsich\" <philipp.tomsich@theobroma-systems.com>","In-Reply-To":"<1505818405-49082-1-git-send-email-david.wu@rock-chips.com>","Date":"Tue, 19 Sep 2017 14:12:10 +0200","Message-Id":"<AA41F043-D490-4880-ABA8-099A8B0187D9@theobroma-systems.com>","References":"<1505818405-49082-1-git-send-email-david.wu@rock-chips.com>","To":"David Wu <david.wu@rock-chips.com>","X-Mailer":"Apple Mail (2.3273)","Cc":"huangtao@rock-chips.com, Elaine Zhang <zhangqing@rock-chips.com>,\n\tu-boot@lists.denx.de, Andy Yan <andy.yan@rock-chips.com>,\n\tchenjh@rock-chips.com","Subject":"Re: [U-Boot] [U-Boot,v2,00/14] Add rockchip SARADC support","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]