[{"id":1770947,"web_url":"http://patchwork.ozlabs.org/comment/1770947/","msgid":"<531bcb91-c5ef-278b-ab6f-a2b8f246a26a@c-s.fr>","date":"2017-09-19T12:21:33","subject":"Re: [PATCH v1 0/3] powerpc: memcmp() optimization","submitter":{"id":5234,"url":"http://patchwork.ozlabs.org/api/people/5234/","name":"Christophe Leroy","email":"christophe.leroy@c-s.fr"},"content":"Hi\n\nCould you in the email/patch subject and in the commit texts write \npowerpc/64 instead of powerpc as it doesn't apply to powerpc/32\n\nChristophe\n\nLe 19/09/2017 à 12:03, wei.guo.simon@gmail.com a écrit :\n> From: Simon Guo \n> \n> There is some room to optimize memcmp() in powerpc for following 2 cases:\n> (1) Even src/dst addresses are not aligned with 8 bytes at the beginning,\n> memcmp() can align them and go with .Llong comparision mode without\n> fallback to .Lshort comparision mode do compare buffer byte by byte.\n> (2) VMX instructions can be used to speed up for large size comparision.\n> \n> This patch set also updates selftest case to make it compiled.\n> \n> \n> Simon Guo (3):\n> powerpc: Align bytes before fall back to .Lshort in powerpc memcmp\n> powerpc: enhance memcmp() with VMX instruction for long bytes\n> comparision\n> powerpc:selftest update memcmp selftest according to kernel change\n> \n> arch/powerpc/include/asm/asm-prototypes.h | 2 +-\n> arch/powerpc/lib/copypage_power7.S | 2 +-\n> arch/powerpc/lib/memcmp_64.S | 165 ++++++++++++++++++++-\n> arch/powerpc/lib/memcpy_power7.S | 2 +-\n> arch/powerpc/lib/vmx-helper.c | 2 +-\n> .../selftests/powerpc/copyloops/asm/ppc_asm.h | 2 +-\n> .../selftests/powerpc/stringloops/asm/ppc_asm.h | 31 ++++\n> 7 files changed, 197 insertions(+), 9 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxMVZ5ffCz9s7c\n\tfor ;\n\tTue, 19 Sep 2017 22:23:50 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxMVZ1kGlzDr2L\n\tfor ;\n\tTue, 19 Sep 2017 22:23:50 +1000 (AEST)","from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxMSB1wcBzDqkc\n\tfor ;\n\tTue, 19 Sep 2017 22:21:46 +1000 (AEST)","from localhost (mailhub1-int [192.168.12.234])\n\tby localhost (Postfix) with ESMTP id 3xxMRn0GJqz9ttBw;\n\tTue, 19 Sep 2017 14:21:25 +0200 (CEST)","from pegase1.c-s.fr ([192.168.12.234])\n\tby localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 8meqq440L_Xe; Tue, 19 Sep 2017 14:21:24 +0200 (CEST)","from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192])\n\tby pegase1.c-s.fr (Postfix) with ESMTP id 3xxMRm6mKMz9ttBL;\n\tTue, 19 Sep 2017 14:21:24 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n\tby messagerie.si.c-s.fr (Postfix) with ESMTP id 3B1758B81F;\n\tTue, 19 Sep 2017 14:21:33 +0200 (CEST)","from messagerie.si.c-s.fr ([127.0.0.1])\n\tby localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new,\n\tport 10023)\n\twith ESMTP id okWk_VWjq37L; Tue, 19 Sep 2017 14:21:33 +0200 (CEST)","from PO15451 (po15451.idsi0.si.c-s.fr [172.25.231.1])\n\tby messagerie.si.c-s.fr (Postfix) with ESMTP id 155FC8B810;\n\tTue, 19 Sep 2017 14:21:33 +0200 (CEST)"],"Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=c-s.fr\n\t(client-ip=93.17.236.30; helo=pegase1.c-s.fr;\n\tenvelope-from=christophe.leroy@c-s.fr; receiver=)","X-Virus-Scanned":["Debian amavisd-new at c-s.fr","amavisd-new at c-s.fr"],"Subject":"Re: [PATCH v1 0/3] powerpc: memcmp() optimization","To":"wei.guo.simon@gmail.com, linuxppc-dev@lists.ozlabs.org","References":"<1505815439-18720-1-git-send-email-wei.guo.simon@gmail.com>","From":"Christophe LEROY ","Message-ID":"<531bcb91-c5ef-278b-ab6f-a2b8f246a26a@c-s.fr>","Date":"Tue, 19 Sep 2017 14:21:33 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505815439-18720-1-git-send-email-wei.guo.simon@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"fr","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Naveen N. Rao\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771720,"web_url":"http://patchwork.ozlabs.org/comment/1771720/","msgid":"<20170920095747.GB3387@simonLocalRHEL7.x64>","date":"2017-09-20T09:57:47","subject":"Re: [PATCH v1 0/3] powerpc: memcmp() optimization","submitter":{"id":68632,"url":"http://patchwork.ozlabs.org/api/people/68632/","name":"Simon Guo","email":"wei.guo.simon@gmail.com"},"content":"Hi Chris,\nOn Tue, Sep 19, 2017 at 02:21:33PM +0200, Christophe LEROY wrote:\n> Hi\n> \n> Could you in the email/patch subject and in the commit texts write\n> powerpc/64 instead of powerpc as it doesn't apply to powerpc/32\n> \n> Christophe\n> \nSure. I will update in v2.\n\nBR,\n- Simon","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxwFz45cXz9s03\n\tfor ;\n\tWed, 20 Sep 2017 19:59:51 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxwFz2wlvzDqY3\n\tfor ;\n\tWed, 20 Sep 2017 19:59:51 +1000 (AEST)","from mail-pg0-x241.google.com (mail-pg0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c05::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxwCk5D1rzDqZ0\n\tfor ;\n\tWed, 20 Sep 2017 19:57:54 +1000 (AEST)","by mail-pg0-x241.google.com with SMTP id u18so1382209pgo.1\n\tfor ;\n\tWed, 20 Sep 2017 02:57:54 -0700 (PDT)","from localhost ([112.73.6.48]) by smtp.gmail.com with ESMTPSA id\n\th82sm8670114pfd.148.2017.09.20.02.57.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 02:57:51 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IrJHLySh\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IrJHLySh\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::241; helo=mail-pg0-x241.google.com;\n\tenvelope-from=wei.guo.simon@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IrJHLySh\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=/I5htfSOkdCvXxErWoROE2O9xocbhtC6SbrKyfU7FsI=;\n\tb=IrJHLySh94ExweWHQRAgo++G7QJ0mDII2KnFX+X1zBzUFwaU7+U7Z8U/Lk6AXVZQ4a\n\tKbhNRZ4eMYf6F4//PNYczsrHzGe77RN1Wf/UL+nmXe1icAZ46eZ43kRiBpTU7O9z/4r0\n\tuTe+eNPKXhv+2HTAKXZBefu55/UytUQajM6JlAoJLSe840iTvMlzbEuFomr+Mouuu72Z\n\tvdPlaPiB6rMRYAVwtf8ojAttOx6WkpIRiCMkME/BwXjpD+glhAyVdmu360ZRfy5ULdap\n\tP3gKM8i5oZwZObDkVB9xkIq4AJayM04G4EAJvCUKuXUgktYKmYVSxjfyRFvOdVNL1Aud\n\tmamw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=/I5htfSOkdCvXxErWoROE2O9xocbhtC6SbrKyfU7FsI=;\n\tb=DbTVl/A6zW6iKtYOTo183THscjPKiXym6OFoTCDtid1aJKvRWOX2At1UGlkM7aLoBf\n\tu9IAzXPS2H+zDwuu41ETwTNPXyHCDSlnX7jaQaZRsmDmd4o2qOgF2NVSv8C8T72TaHxp\n\t+o5ykz138xB758skSIpWSTZYelR/oxb3uSLbjXLPelfzY+JNZy8P5d3Q9Og93LV6ZVEv\n\tg02fcsFg6qDTrulbBeAyun2s/dZDkvsKtTWt18tavdTeEEJZQVY2V5D++f9KaPW7Zi4q\n\tXGYvVUDPS2Z7hdM8wwSyz2O2tXiHdfeBVSJMrv3V+VAkzohuqPkvVOUwIBmuPOqC3Otf\n\t+Q4g==","X-Gm-Message-State":"AHPjjUjWtVz4cQ/+WbvFtO0iEyKnGnQPKxwtgF3f25e0UA9EmSosmByh\n\tF2onMsm583HyxH+vuZkzhjc=","X-Google-Smtp-Source":"AOwi7QBHrrjnXsUsUzv4gqSG2Rq63q5GEOn1qMnuAXH2AGZ7LqUs7Db4l1/+vyUOzItun4FSu0vdkQ==","X-Received":"by 10.159.194.193 with SMTP id u1mr1510521plz.93.1505901472016; \n\tWed, 20 Sep 2017 02:57:52 -0700 (PDT)","Date":"Wed, 20 Sep 2017 17:57:47 +0800","From":"Simon Guo ","To":"Christophe LEROY ","Subject":"Re: [PATCH v1 0/3] powerpc: memcmp() optimization","Message-ID":"<20170920095747.GB3387@simonLocalRHEL7.x64>","References":"<1505815439-18720-1-git-send-email-wei.guo.simon@gmail.com>\n\t<531bcb91-c5ef-278b-ab6f-a2b8f246a26a@c-s.fr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<531bcb91-c5ef-278b-ab6f-a2b8f246a26a@c-s.fr>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Naveen N. Rao\" ,\n\tlinuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]