[{"id":1771155,"web_url":"http://patchwork.ozlabs.org/comment/1771155/","msgid":"<1505834813.16414.5.camel@mtksdaap41>","list_archive_url":null,"date":"2017-09-19T15:26:53","subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","submitter":{"id":65928,"url":"http://patchwork.ozlabs.org/api/people/65928/","name":"CK Hu (胡俊光)","email":"ck.hu@mediatek.com"},"content":"Hi, Ryder:\n\nSome comment inline.\n\nOn Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote:\n> This patch adds the device nodes for the display function block.\n> Also, we add some missing pin macros in mt7623-pinfunc.h.\n> \n> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>\n> CC: Linus Walleij <linus.walleij@linaro.org>\n> Acked-by: Linus Walleij <linus.walleij@linaro.org>\n> ---\n>  arch/arm/boot/dts/mt7623.dtsi                 | 210 ++++++++++++++++++++++++++\n>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts |  41 ++++-\n>  include/dt-bindings/pinctrl/mt7623-pinfunc.h  |  12 ++\n>  3 files changed, 261 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi\n> index 9ec3767..e11e5e7 100644\n> --- a/arch/arm/boot/dts/mt7623.dtsi\n> +++ b/arch/arm/boot/dts/mt7623.dtsi\n> @@ -20,6 +20,7 @@\n>  #include <dt-bindings/power/mt2701-power.h>\n>  #include <dt-bindings/gpio/gpio.h>\n>  #include <dt-bindings/phy/phy.h>\n> +#include <dt-bindings/memory/mt2701-larb-port.h>\n>  #include <dt-bindings/reset/mt2701-resets.h>\n>  #include <dt-bindings/thermal/thermal.h>\n>  #include \"skeleton64.dtsi\"\n> @@ -28,6 +29,11 @@\n>  \tcompatible = \"mediatek,mt7623\";\n>  \tinterrupt-parent = <&sysirq>;\n>  \n> +\taliases {\n> +\t\trdma0 = &rdma0;\n> +\t\trdma1 = &rdma1;\n\nFor display, are these two aliases enough?\n\n> +\t};\n> +\n>  \tcpu_opp_table: opp_table {\n>  \t\tcompatible = \"operating-points-v2\";\n>  \t\topp-shared;\n> @@ -273,6 +279,17 @@\n>  \t\t\t     <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;\n>  \t};\n>  \n> +\tsmi_common: smi@1000c000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-common\",\n> +\t\t\t     \"mediatek,mt2701-smi-common\";\n> +\t\treg = <0 0x1000c000 0 0x1000>;\n> +\t\tclocks = <&infracfg CLK_INFRA_SMI>,\n> +\t\t\t <&mmsys CLK_MM_SMI_COMMON>,\n> +\t\t\t <&infracfg CLK_INFRA_SMI>;\n> +\t\tclock-names = \"apb\", \"smi\", \"async\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> +\t};\n> +\n>  \tpwrap: pwrap@1000d000 {\n>  \t\tcompatible = \"mediatek,mt7623-pwrap\",\n>  \t\t\t     \"mediatek,mt2701-pwrap\";\n> @@ -286,6 +303,17 @@\n>  \t\tclock-names = \"spi\", \"wrap\";\n>  \t};\n>  \n> +\tmipi_tx0: mipi-dphy@10010000 {\n> +\t\tcompatible = \"mediatek,mt7623-mipi-tx\",\n> +\t\t\t     \"mediatek,mt2701-mipi-tx\";\n> +\t\treg = <0 0x10010000 0 0x90>;\n> +\t\tclocks = <&clk26m>;\n> +\t\tclock-output-names = \"mipi_tx0_pll\";\n> +\t\t#clock-cells = <0>;\n> +\t\t#phy-cells = <0>;\n> +\t\tstatus = \"disabled\";\n> +\t};\n> +\n>  \tcir: cir@10013000 {\n>  \t\tcompatible = \"mediatek,mt7623-cir\";\n>  \t\treg = <0 0x10013000 0 0x1000>;\n> @@ -304,6 +332,17 @@\n>  \t\treg = <0 0x10200100 0 0x1c>;\n>  \t};\n>  \n> +\tiommu: mmsys_iommu@10205000 {\n> +\t\tcompatible = \"mediatek,mt7623-m4u\",\n> +\t\t\t     \"mediatek,mt2701-m4u\";\n> +\t\treg = <0 0x10205000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&infracfg CLK_INFRA_M4U>;\n> +\t\tclock-names = \"bclk\";\n> +\t\tmediatek,larbs = <&larb0 &larb1 &larb2>;\n> +\t\t#iommu-cells = <1>;\n> +\t};\n> +\n>  \tefuse: efuse@10206000 {\n>  \t\tcompatible = \"mediatek,mt7623-efuse\",\n>  \t\t\t     \"mediatek,mt8173-efuse\";\n> @@ -661,6 +700,169 @@\n>  \t\tstatus = \"disabled\";\n>  \t};\n>  \n> +\tmmsys: syscon@14000000 {\n> +\t\tcompatible = \"mediatek,mt7623-mmsys\",\n> +\t\t\t     \"mediatek,mt2701-mmsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x14000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n> +\n> +\tdisplay_components: dispsys@14000000 {\n> +\t\tcompatible = \"mediatek,mt7623-mmsys\",\n> +\t\t\t     \"mediatek,mt2701-mmsys\";\n> +\t\treg = <0 0x14000000 0 0x1000>;\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> +\t};\n> +\n> +\tovl@14007000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-ovl\",\n> +\t\t\t     \"mediatek,mt2701-disp-ovl\";\n> +\t\treg = <0 0x14007000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_OVL>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_OVL_0>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\trdma0: rdma@14008000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-rdma\",\n> +\t\t\t     \"mediatek,mt2701-disp-rdma\";\n> +\t\treg = <0 0x14008000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_RDMA>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_RDMA>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\twdma@14009000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-wdma\",\n> +\t\t\t     \"mediatek,mt2701-disp-wdma\";\n\nThere is neither \"mediatek,mt7623-disp-wdma\" nor\n\"mediatek,mt2701-disp-wdma\" in driver, do you really need this device\nnode?\n\n> +\t\treg = <0 0x14009000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_WDMA>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_WDMA>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\tbls: bls@1400a000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-pwm\",\n> +\t\t\t     \"mediatek,mt2701-disp-pwm\";\n> +\t\treg = <0 0x1400a000 0 0x1000>;\n> +\t\t#pwm-cells = <2>;\n> +\t\tclocks = <&mmsys CLK_MM_MDP_BLS_26M>,\n> +\t\t\t <&mmsys CLK_MM_DISP_BLS>;\n> +\t\tclock-names = \"main\", \"mm\";\n> +\t\tstatus = \"disabled\";\n> +\t};\n> +\n> +\tcolor@1400b000 {\n\ncolor: color@1400b000 {\n\n> +\t\tcompatible = \"mediatek,mt7623-disp-color\",\n> +\t\t\t     \"mediatek,mt2701-disp-color\";\n> +\t\treg = <0 0x1400b000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_COLOR>;\n> +\t};\n> +\n> +\tdsi: dsi@1400c000 {\n> +\t\tcompatible = \"mediatek,mt7623-dsi\",\n> +\t\t\t     \"mediatek,mt2701-dsi\";\n> +\t\treg = <0 0x1400c000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DSI_ENGINE>,\n> +\t\t\t <&mmsys CLK_MM_DSI_DIG>,\n> +\t\t\t <&mipi_tx0>;\n> +\t\tclock-names = \"engine\", \"digital\", \"hs\";\n> +\t\tphys = <&mipi_tx0>;\n> +\t\tphy-names = \"dphy\";\n> +\t\tstatus = \"disabled\";\n> +\t};\n> +\n> +\tmutex: mutex@1400e000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-mutex\",\n> +\t\t\t     \"mediatek,mt2701-disp-mutex\";\n> +\t\treg = <0 0x1400e000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_MUTEX_32K>;\n> +\t};\n> +\n> +\tlarb0: larb@14010000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> +\t\treg = <0 0x14010000 0 0x1000>;\n> +\t\tmediatek,smi = <&smi_common>;\n> +\t\tmediatek,larb-id = <0>;\n> +\t\tclocks = <&mmsys CLK_MM_SMI_LARB0>,\n> +\t\t\t <&mmsys CLK_MM_SMI_LARB0>;\n> +\t\tclock-names = \"apb\", \"smi\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> +\t};\n> +\n> +\trdma1: rdma@14012000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-rdma\",\n> +\t\t\t     \"mediatek,mt2701-disp-rdma\";\n> +\t\treg = <0 0x14012000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_RDMA1>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_RDMA1>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\timgsys: syscon@15000000 {\n> +\t\tcompatible = \"mediatek,mt7623-imgsys\",\n> +\t\t\t     \"mediatek,mt2701-imgsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x15000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n> +\n> +\tlarb2: larb@15001000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> +\t\treg = <0 0x15001000 0 0x1000>;\n> +\t\tmediatek,smi = <&smi_common>;\n> +\t\tmediatek,larb-id = <2>;\n> +\t\tclocks = <&imgsys CLK_IMG_SMI_COMM>,\n> +\t\t\t <&imgsys CLK_IMG_SMI_COMM>;\n> +\t\tclock-names = \"apb\", \"smi\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ISP>;\n> +\t};\n> +\n> +\tjpegdec: jpegdec@15004000 {\n> +\t\tcompatible = \"mediatek,mt7623-jpgdec\",\n> +\t\t\t     \"mediatek,mt2701-jpgdec\";\n> +\t\treg = <0 0x15004000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks =  <&imgsys CLK_IMG_JPGDEC_SMI>,\n> +\t\t\t  <&imgsys CLK_IMG_JPGDEC>;\n> +\t\tclock-names = \"jpgdec-smi\",\n> +\t\t\t      \"jpgdec\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ISP>;\n> +\t\tmediatek,larb = <&larb2>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_JPGDEC_WDMA>,\n> +\t\t\t <&iommu MT2701_M4U_PORT_JPGDEC_BSDMA>;\n> +\t};\n> +\n> +\tvdecsys: syscon@16000000 {\n> +\t\tcompatible = \"mediatek,mt7623-vdecsys\",\n> +\t\t\t     \"mediatek,mt2701-vdecsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x16000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n> +\n> +\tlarb1: larb@16010000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> +\t\treg = <0 0x16010000 0 0x1000>;\n> +\t\tmediatek,smi = <&smi_common>;\n> +\t\tmediatek,larb-id = <1>;\n> +\t\tclocks = <&vdecsys CLK_VDEC_CKGEN>,\n> +\t\t\t <&vdecsys CLK_VDEC_LARB>;\n> +\t\tclock-names = \"apb\", \"smi\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_VDEC>;\n> +\t};\n> +\n>  \thifsys: syscon@1a000000 {\n>  \t\tcompatible = \"mediatek,mt7623-hifsys\",\n>  \t\t\t     \"mediatek,mt2701-hifsys\",\n> @@ -799,4 +1001,12 @@\n>  \t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;\n>  \t\tstatus = \"disabled\";\n>  \t};\n> +\n> +\tbdpsys: syscon@1c000000 {\n> +\t\tcompatible = \"mediatek,mt7623-bdpsys\",\n> +\t\t\t     \"mediatek,mt2701-bdpsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x1c000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n>  };\n> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> index 688a863..267a05a 100644\n> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> @@ -17,6 +17,17 @@\n>  \t\tserial2 = &uart2;\n>  \t};\n>  \n> +\tbacklight_lcd: backlight_lcd {\n> +\t\tcompatible = \"pwm-backlight\";\n> +\t\tpwms = <&bls 0 100000>;\n> +\t\tbrightness-levels = <\n> +\t\t\t  0  16  32  48  64  80  96 112\n> +\t\t\t128 144 160 176 192 208 224 240\n> +\t\t\t255\n> +\t\t>;\n> +\t\tdefault-brightness-level = <9>;\n> +\t};\n> +\n>  \tchosen {\n>  \t\tstdout-path = \"serial2:115200n8\";\n>  \t};\n> @@ -86,6 +97,12 @@\n>  \t};\n>  };\n>  \n> +&bls {\n> +\tstatus = \"okay\";\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&bls_pins_a>;\n> +};\n> +\n>  &cir {\n>  \tpinctrl-names = \"default\";\n>  \tpinctrl-0 = <&cir_pins_a>;\n> @@ -210,6 +227,12 @@\n>  };\n>  \n>  &pio {\n> +\tbls_pins_a: bls@0 {\n> +\t\tpins_cmd_dat {\n> +\t\t\tpinmux = <MT7623_PIN_203_PWM0_FUNC_DISP_PWM>;\n> +\t\t};\n> +\t};\n> +\n>  \tcir_pins_a:cir@0 {\n>  \t\tpins_cir {\n>  \t\t\tpinmux = <MT7623_PIN_46_IR_FUNC_IR>;\n> @@ -273,6 +296,21 @@\n>  \t\t};\n>  \t};\n>  \n> +\tmipi_dsi_pin: mipi_dsi_pin {\n> +\t\tpins_cmd_dat {\n> +\t\t\tpinmux = <MT7623_PIN_100_MIPI_TDP0_FUNC_TDP0>,\n> +\t\t\t\t <MT7623_PIN_99_MIPI_TDN0_FUNC_TDN0>,\n> +\t\t\t\t <MT7623_PIN_98_MIPI_TDP1_FUNC_TDP1>,\n> +\t\t\t\t <MT7623_PIN_97_MIPI_TDN1_FUNC_TDN1>,\n> +\t\t\t\t <MT7623_PIN_96_MIPI_TCP_FUNC_TCP>,\n> +\t\t\t\t <MT7623_PIN_95_MIPI_TCN_FUNC_TCN>,\n> +\t\t\t\t <MT7623_PIN_94_MIPI_TDP2_FUNC_TDP2>,\n> +\t\t\t\t <MT7623_PIN_93_MIPI_TDN2_FUNC_TDN2>,\n> +\t\t\t\t <MT7623_PIN_92_MIPI_TDP3_FUNC_TDP3>,\n> +\t\t\t\t <MT7623_PIN_91_MIPI_TDN3_FUNC_TDN3>;\n> +\t\t};\n> +\t};\n> +\n>  \tmmc0_pins_default: mmc0default {\n>  \t\tpins_cmd_dat {\n>  \t\t\tpinmux = <MT7623_PIN_111_MSDC0_DAT7_FUNC_MSDC0_DAT7>,\n> @@ -378,8 +416,7 @@\n>  \n>  \tpwm_pins_a: pwm@0 {\n>  \t\tpins_pwm {\n> -\t\t\tpinmux = <MT7623_PIN_203_PWM0_FUNC_PWM0>,\n> -\t\t\t\t <MT7623_PIN_204_PWM1_FUNC_PWM1>,\n> +\t\t\tpinmux = <MT7623_PIN_204_PWM1_FUNC_PWM1>,\n>  \t\t\t\t <MT7623_PIN_205_PWM2_FUNC_PWM2>,\n>  \t\t\t\t <MT7623_PIN_206_PWM3_FUNC_PWM3>,\n>  \t\t\t\t <MT7623_PIN_207_PWM4_FUNC_PWM4>;\n> diff --git a/include/dt-bindings/pinctrl/mt7623-pinfunc.h b/include/dt-bindings/pinctrl/mt7623-pinfunc.h\n> index 436a87b..72bed67 100644\n> --- a/include/dt-bindings/pinctrl/mt7623-pinfunc.h\n> +++ b/include/dt-bindings/pinctrl/mt7623-pinfunc.h\n> @@ -272,6 +272,18 @@\n>  #define MT7623_PIN_84_DSI_TE_FUNC_GPIO84 (MTK_PIN_NO(84) | 0)\n>  #define MT7623_PIN_84_DSI_TE_FUNC_DSI_TE (MTK_PIN_NO(84) | 1)\n>  \n> +#define MT7623_PIN_91_MIPI_TDN3_FUNC_GPIO91 (MTK_PIN_NO(91) | 0)\n> +#define MT7623_PIN_91_MIPI_TDN3_FUNC_TDN3 (MTK_PIN_NO(91) | 1)\n> +\n> +#define MT7623_PIN_92_MIPI_TDP3_FUNC_GPIO92 (MTK_PIN_NO(92) | 0)\n> +#define MT7623_PIN_92_MIPI_TDP3_FUNC_TDP3 (MTK_PIN_NO(92) | 1)\n> +\n> +#define MT7623_PIN_93_MIPI_TDN2_FUNC_GPIO93 (MTK_PIN_NO(93) | 0)\n> +#define MT7623_PIN_93_MIPI_TDN2_FUNC_TDN2 (MTK_PIN_NO(93) | 1)\n> +\n> +#define MT7623_PIN_94_MIPI_TDP2_FUNC_GPIO94 (MTK_PIN_NO(94) | 0)\n> +#define MT7623_PIN_94_MIPI_TDP2_FUNC_TDP2 (MTK_PIN_NO(94) | 1)\n> +\n>  #define MT7623_PIN_95_MIPI_TCN_FUNC_GPIO95 (MTK_PIN_NO(95) | 0)\n>  #define MT7623_PIN_95_MIPI_TCN_FUNC_TCN (MTK_PIN_NO(95) | 1)\n>  \n\nRegards,\nCK","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"W32q2dX/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxRZh60Z7z9s7g\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 01:27:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duKQy-0000HN-Ht; Tue, 19 Sep 2017 15:27:36 +0000","from [210.61.82.184] (helo=mailgw02.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duKQp-000068-GH; Tue, 19 Sep 2017 15:27:32 +0000","from mtkcas06.mediatek.inc [(172.21.101.30)] by\n\tmailgw02.mediatek.com (envelope-from <ck.hu@mediatek.com>)\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 1561352790; Tue, 19 Sep 2017 23:27:00 +0800","from mtkcas08.mediatek.inc (172.21.101.126) by\n\tmtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Tue, 19 Sep 2017 23:26:38 +0800","from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Tue, 19 Sep 2017 23:26:24 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=TNJkPhQ0uNs9uc/JW+3zHQPCa8nMUX/ezrB7ELpCzfY=;\n\tb=W32q2dX/JzOToP\n\tb2Dcr8KK1vdcFfM73tVPvXruGuG5vWaZBboXitmgaCzbW7mzrCDHzCF4bFJrNj+2IVYaFYp1i/1Hy\n\t6ovqcVABfqxF3+nbIf3mT13BUcX/589lpG8qgRbzj0JgiFmuPjLlgIuWNDBUEbMlPkbYNyKBi7+Ux\n\tNbiS98WYC2DNNv6cBeqyeCE8h0e6jPBHpmYX37/WQMxZ9ZJWX/Vst1PRyuD6w6dJHrkdM9TV1Buex\n\tXPWQR6JX4ycpWycDIsVoyombCOREOt3XqbdS9ue3pUK1DgQrKLNjID4lmZbV21+L0LIIjAfjAHvbW\n\tEMCTnJruY5hVydSiIoNQ==;","X-UUID":"1718e193ec304fbfa69ef4fa4587abab-20170919","Message-ID":"<1505834813.16414.5.camel@mtksdaap41>","Subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","From":"CK Hu <ck.hu@mediatek.com>","To":"Ryder Lee <ryder.lee@mediatek.com>","Date":"Tue, 19 Sep 2017 23:26:53 +0800","In-Reply-To":"<0eb19ae1a4717d316cdaec44f6c20bfa8aa24ddc.1505801355.git.ryder.lee@mediatek.com>","References":"<cover.1505801355.git.ryder.lee@mediatek.com>\n\t<0eb19ae1a4717d316cdaec44f6c20bfa8aa24ddc.1505801355.git.ryder.lee@mediatek.com>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_082727_896683_5C57FE30 ","X-CRM114-Status":"GOOD (  15.79  )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.1 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,\n\tlinux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771486,"web_url":"http://patchwork.ozlabs.org/comment/1771486/","msgid":"<1505869897.27600.6.camel@mtksdaap41>","list_archive_url":null,"date":"2017-09-20T01:11:37","subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","submitter":{"id":65928,"url":"http://patchwork.ozlabs.org/api/people/65928/","name":"CK Hu (胡俊光)","email":"ck.hu@mediatek.com"},"content":"Hi, Ryder:\n\nMode comment inline.\n\nOn Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote:\n> This patch adds the device nodes for the display function block.\n> Also, we add some missing pin macros in mt7623-pinfunc.h.\n> \n> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>\n> CC: Linus Walleij <linus.walleij@linaro.org>\n> Acked-by: Linus Walleij <linus.walleij@linaro.org>\n> ---\n>  arch/arm/boot/dts/mt7623.dtsi                 | 210 ++++++++++++++++++++++++++\n>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts |  41 ++++-\n>  include/dt-bindings/pinctrl/mt7623-pinfunc.h  |  12 ++\n>  3 files changed, 261 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi\n> index 9ec3767..e11e5e7 100644\n> --- a/arch/arm/boot/dts/mt7623.dtsi\n> +++ b/arch/arm/boot/dts/mt7623.dtsi\n> @@ -20,6 +20,7 @@\n>  #include <dt-bindings/power/mt2701-power.h>\n>  #include <dt-bindings/gpio/gpio.h>\n>  #include <dt-bindings/phy/phy.h>\n> +#include <dt-bindings/memory/mt2701-larb-port.h>\n>  #include <dt-bindings/reset/mt2701-resets.h>\n>  #include <dt-bindings/thermal/thermal.h>\n>  #include \"skeleton64.dtsi\"\n> @@ -28,6 +29,11 @@\n>  \tcompatible = \"mediatek,mt7623\";\n>  \tinterrupt-parent = <&sysirq>;\n>  \n> +\taliases {\n> +\t\trdma0 = &rdma0;\n> +\t\trdma1 = &rdma1;\n> +\t};\n> +\n>  \tcpu_opp_table: opp_table {\n>  \t\tcompatible = \"operating-points-v2\";\n>  \t\topp-shared;\n> @@ -273,6 +279,17 @@\n>  \t\t\t     <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;\n>  \t};\n>  \n> +\tsmi_common: smi@1000c000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-common\",\n> +\t\t\t     \"mediatek,mt2701-smi-common\";\n> +\t\treg = <0 0x1000c000 0 0x1000>;\n> +\t\tclocks = <&infracfg CLK_INFRA_SMI>,\n> +\t\t\t <&mmsys CLK_MM_SMI_COMMON>,\n> +\t\t\t <&infracfg CLK_INFRA_SMI>;\n> +\t\tclock-names = \"apb\", \"smi\", \"async\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> +\t};\n> +\n>  \tpwrap: pwrap@1000d000 {\n>  \t\tcompatible = \"mediatek,mt7623-pwrap\",\n>  \t\t\t     \"mediatek,mt2701-pwrap\";\n> @@ -286,6 +303,17 @@\n>  \t\tclock-names = \"spi\", \"wrap\";\n>  \t};\n>  \n> +\tmipi_tx0: mipi-dphy@10010000 {\n> +\t\tcompatible = \"mediatek,mt7623-mipi-tx\",\n> +\t\t\t     \"mediatek,mt2701-mipi-tx\";\n> +\t\treg = <0 0x10010000 0 0x90>;\n> +\t\tclocks = <&clk26m>;\n> +\t\tclock-output-names = \"mipi_tx0_pll\";\n> +\t\t#clock-cells = <0>;\n> +\t\t#phy-cells = <0>;\n> +\t\tstatus = \"disabled\";\n> +\t};\n> +\n>  \tcir: cir@10013000 {\n>  \t\tcompatible = \"mediatek,mt7623-cir\";\n>  \t\treg = <0 0x10013000 0 0x1000>;\n> @@ -304,6 +332,17 @@\n>  \t\treg = <0 0x10200100 0 0x1c>;\n>  \t};\n>  \n> +\tiommu: mmsys_iommu@10205000 {\n> +\t\tcompatible = \"mediatek,mt7623-m4u\",\n> +\t\t\t     \"mediatek,mt2701-m4u\";\n> +\t\treg = <0 0x10205000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&infracfg CLK_INFRA_M4U>;\n> +\t\tclock-names = \"bclk\";\n> +\t\tmediatek,larbs = <&larb0 &larb1 &larb2>;\n> +\t\t#iommu-cells = <1>;\n> +\t};\n> +\n>  \tefuse: efuse@10206000 {\n>  \t\tcompatible = \"mediatek,mt7623-efuse\",\n>  \t\t\t     \"mediatek,mt8173-efuse\";\n> @@ -661,6 +700,169 @@\n>  \t\tstatus = \"disabled\";\n>  \t};\n>  \n> +\tmmsys: syscon@14000000 {\n> +\t\tcompatible = \"mediatek,mt7623-mmsys\",\n> +\t\t\t     \"mediatek,mt2701-mmsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x14000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n> +\n> +\tdisplay_components: dispsys@14000000 {\n> +\t\tcompatible = \"mediatek,mt7623-mmsys\",\n> +\t\t\t     \"mediatek,mt2701-mmsys\";\n> +\t\treg = <0 0x14000000 0 0x1000>;\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> +\t};\n> +\n> +\tovl@14007000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-ovl\",\n> +\t\t\t     \"mediatek,mt2701-disp-ovl\";\n> +\t\treg = <0 0x14007000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_OVL>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_OVL_0>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\trdma0: rdma@14008000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-rdma\",\n> +\t\t\t     \"mediatek,mt2701-disp-rdma\";\n> +\t\treg = <0 0x14008000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_RDMA>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_RDMA>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\twdma@14009000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-wdma\",\n> +\t\t\t     \"mediatek,mt2701-disp-wdma\";\n> +\t\treg = <0 0x14009000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_WDMA>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_WDMA>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\tbls: bls@1400a000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-pwm\",\n> +\t\t\t     \"mediatek,mt2701-disp-pwm\";\n> +\t\treg = <0 0x1400a000 0 0x1000>;\n> +\t\t#pwm-cells = <2>;\n> +\t\tclocks = <&mmsys CLK_MM_MDP_BLS_26M>,\n> +\t\t\t <&mmsys CLK_MM_DISP_BLS>;\n> +\t\tclock-names = \"main\", \"mm\";\n> +\t\tstatus = \"disabled\";\n> +\t};\n> +\n> +\tcolor@1400b000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-color\",\n> +\t\t\t     \"mediatek,mt2701-disp-color\";\n> +\t\treg = <0 0x1400b000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_COLOR>;\n> +\t};\n> +\n> +\tdsi: dsi@1400c000 {\n> +\t\tcompatible = \"mediatek,mt7623-dsi\",\n> +\t\t\t     \"mediatek,mt2701-dsi\";\n> +\t\treg = <0 0x1400c000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DSI_ENGINE>,\n> +\t\t\t <&mmsys CLK_MM_DSI_DIG>,\n> +\t\t\t <&mipi_tx0>;\n> +\t\tclock-names = \"engine\", \"digital\", \"hs\";\n> +\t\tphys = <&mipi_tx0>;\n> +\t\tphy-names = \"dphy\";\n> +\t\tstatus = \"disabled\";\n> +\t};\n> +\n> +\tmutex: mutex@1400e000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-mutex\",\n> +\t\t\t     \"mediatek,mt2701-disp-mutex\";\n> +\t\treg = <0 0x1400e000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_MUTEX_32K>;\n> +\t};\n> +\n> +\tlarb0: larb@14010000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> +\t\treg = <0 0x14010000 0 0x1000>;\n> +\t\tmediatek,smi = <&smi_common>;\n> +\t\tmediatek,larb-id = <0>;\n> +\t\tclocks = <&mmsys CLK_MM_SMI_LARB0>,\n> +\t\t\t <&mmsys CLK_MM_SMI_LARB0>;\n> +\t\tclock-names = \"apb\", \"smi\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> +\t};\n> +\n> +\trdma1: rdma@14012000 {\n> +\t\tcompatible = \"mediatek,mt7623-disp-rdma\",\n> +\t\t\t     \"mediatek,mt2701-disp-rdma\";\n> +\t\treg = <0 0x14012000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks = <&mmsys CLK_MM_DISP_RDMA1>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_RDMA1>;\n> +\t\tmediatek,larb = <&larb0>;\n> +\t};\n> +\n> +\timgsys: syscon@15000000 {\n> +\t\tcompatible = \"mediatek,mt7623-imgsys\",\n> +\t\t\t     \"mediatek,mt2701-imgsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x15000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n> +\n> +\tlarb2: larb@15001000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> +\t\treg = <0 0x15001000 0 0x1000>;\n> +\t\tmediatek,smi = <&smi_common>;\n> +\t\tmediatek,larb-id = <2>;\n> +\t\tclocks = <&imgsys CLK_IMG_SMI_COMM>,\n> +\t\t\t <&imgsys CLK_IMG_SMI_COMM>;\n> +\t\tclock-names = \"apb\", \"smi\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ISP>;\n> +\t};\n> +\n> +\tjpegdec: jpegdec@15004000 {\n> +\t\tcompatible = \"mediatek,mt7623-jpgdec\",\n> +\t\t\t     \"mediatek,mt2701-jpgdec\";\n> +\t\treg = <0 0x15004000 0 0x1000>;\n> +\t\tinterrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_LOW>;\n> +\t\tclocks =  <&imgsys CLK_IMG_JPGDEC_SMI>,\n> +\t\t\t  <&imgsys CLK_IMG_JPGDEC>;\n> +\t\tclock-names = \"jpgdec-smi\",\n> +\t\t\t      \"jpgdec\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ISP>;\n> +\t\tmediatek,larb = <&larb2>;\n> +\t\tiommus = <&iommu MT2701_M4U_PORT_JPGDEC_WDMA>,\n> +\t\t\t <&iommu MT2701_M4U_PORT_JPGDEC_BSDMA>;\n> +\t};\n\njpegdec and some other device node is not related to display. I think\nyou should move them to another patch.\n\n> +\n> +\tvdecsys: syscon@16000000 {\n> +\t\tcompatible = \"mediatek,mt7623-vdecsys\",\n> +\t\t\t     \"mediatek,mt2701-vdecsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x16000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n> +\n> +\tlarb1: larb@16010000 {\n> +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> +\t\treg = <0 0x16010000 0 0x1000>;\n> +\t\tmediatek,smi = <&smi_common>;\n> +\t\tmediatek,larb-id = <1>;\n> +\t\tclocks = <&vdecsys CLK_VDEC_CKGEN>,\n> +\t\t\t <&vdecsys CLK_VDEC_LARB>;\n> +\t\tclock-names = \"apb\", \"smi\";\n> +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_VDEC>;\n> +\t};\n> +\n>  \thifsys: syscon@1a000000 {\n>  \t\tcompatible = \"mediatek,mt7623-hifsys\",\n>  \t\t\t     \"mediatek,mt2701-hifsys\",\n> @@ -799,4 +1001,12 @@\n>  \t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;\n>  \t\tstatus = \"disabled\";\n>  \t};\n> +\n> +\tbdpsys: syscon@1c000000 {\n> +\t\tcompatible = \"mediatek,mt7623-bdpsys\",\n> +\t\t\t     \"mediatek,mt2701-bdpsys\",\n> +\t\t\t     \"syscon\";\n> +\t\treg = <0 0x1c000000 0 0x1000>;\n> +\t\t#clock-cells = <1>;\n> +\t};\n>  };\n> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> index 688a863..267a05a 100644\n> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> @@ -17,6 +17,17 @@\n>  \t\tserial2 = &uart2;\n>  \t};\n>  \n> +\tbacklight_lcd: backlight_lcd {\n> +\t\tcompatible = \"pwm-backlight\";\n> +\t\tpwms = <&bls 0 100000>;\n> +\t\tbrightness-levels = <\n> +\t\t\t  0  16  32  48  64  80  96 112\n> +\t\t\t128 144 160 176 192 208 224 240\n> +\t\t\t255\n> +\t\t>;\n> +\t\tdefault-brightness-level = <9>;\n> +\t};\n> +\n\nI think this patch only for mt7623 common dtsi modification. This part\nis just for bananapi-bpi-r2, so move non-common part to another patch.\n\n>  \tchosen {\n>  \t\tstdout-path = \"serial2:115200n8\";\n>  \t};\n> @@ -86,6 +97,12 @@\n>  \t};\n>  };\n>  \n> +&bls {\n> +\tstatus = \"okay\";\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&bls_pins_a>;\n> +};\n> +\n>  &cir {\n>  \tpinctrl-names = \"default\";\n>  \tpinctrl-0 = <&cir_pins_a>;\n> @@ -210,6 +227,12 @@\n>  };\n>  \n>  &pio {\n> +\tbls_pins_a: bls@0 {\n> +\t\tpins_cmd_dat {\n> +\t\t\tpinmux = <MT7623_PIN_203_PWM0_FUNC_DISP_PWM>;\n> +\t\t};\n> +\t};\n> +\n>  \tcir_pins_a:cir@0 {\n>  \t\tpins_cir {\n>  \t\t\tpinmux = <MT7623_PIN_46_IR_FUNC_IR>;\n> @@ -273,6 +296,21 @@\n>  \t\t};\n>  \t};\n>  \n> +\tmipi_dsi_pin: mipi_dsi_pin {\n> +\t\tpins_cmd_dat {\n> +\t\t\tpinmux = <MT7623_PIN_100_MIPI_TDP0_FUNC_TDP0>,\n> +\t\t\t\t <MT7623_PIN_99_MIPI_TDN0_FUNC_TDN0>,\n> +\t\t\t\t <MT7623_PIN_98_MIPI_TDP1_FUNC_TDP1>,\n> +\t\t\t\t <MT7623_PIN_97_MIPI_TDN1_FUNC_TDN1>,\n> +\t\t\t\t <MT7623_PIN_96_MIPI_TCP_FUNC_TCP>,\n> +\t\t\t\t <MT7623_PIN_95_MIPI_TCN_FUNC_TCN>,\n> +\t\t\t\t <MT7623_PIN_94_MIPI_TDP2_FUNC_TDP2>,\n> +\t\t\t\t <MT7623_PIN_93_MIPI_TDN2_FUNC_TDN2>,\n> +\t\t\t\t <MT7623_PIN_92_MIPI_TDP3_FUNC_TDP3>,\n> +\t\t\t\t <MT7623_PIN_91_MIPI_TDN3_FUNC_TDN3>;\n> +\t\t};\n> +\t};\n> +\n>  \tmmc0_pins_default: mmc0default {\n>  \t\tpins_cmd_dat {\n>  \t\t\tpinmux = <MT7623_PIN_111_MSDC0_DAT7_FUNC_MSDC0_DAT7>,\n> @@ -378,8 +416,7 @@\n>  \n>  \tpwm_pins_a: pwm@0 {\n>  \t\tpins_pwm {\n> -\t\t\tpinmux = <MT7623_PIN_203_PWM0_FUNC_PWM0>,\n> -\t\t\t\t <MT7623_PIN_204_PWM1_FUNC_PWM1>,\n> +\t\t\tpinmux = <MT7623_PIN_204_PWM1_FUNC_PWM1>,\n>  \t\t\t\t <MT7623_PIN_205_PWM2_FUNC_PWM2>,\n>  \t\t\t\t <MT7623_PIN_206_PWM3_FUNC_PWM3>,\n>  \t\t\t\t <MT7623_PIN_207_PWM4_FUNC_PWM4>;\n> diff --git a/include/dt-bindings/pinctrl/mt7623-pinfunc.h b/include/dt-bindings/pinctrl/mt7623-pinfunc.h\n> index 436a87b..72bed67 100644\n> --- a/include/dt-bindings/pinctrl/mt7623-pinfunc.h\n> +++ b/include/dt-bindings/pinctrl/mt7623-pinfunc.h\n> @@ -272,6 +272,18 @@\n>  #define MT7623_PIN_84_DSI_TE_FUNC_GPIO84 (MTK_PIN_NO(84) | 0)\n>  #define MT7623_PIN_84_DSI_TE_FUNC_DSI_TE (MTK_PIN_NO(84) | 1)\n>  \n> +#define MT7623_PIN_91_MIPI_TDN3_FUNC_GPIO91 (MTK_PIN_NO(91) | 0)\n> +#define MT7623_PIN_91_MIPI_TDN3_FUNC_TDN3 (MTK_PIN_NO(91) | 1)\n> +\n> +#define MT7623_PIN_92_MIPI_TDP3_FUNC_GPIO92 (MTK_PIN_NO(92) | 0)\n> +#define MT7623_PIN_92_MIPI_TDP3_FUNC_TDP3 (MTK_PIN_NO(92) | 1)\n> +\n> +#define MT7623_PIN_93_MIPI_TDN2_FUNC_GPIO93 (MTK_PIN_NO(93) | 0)\n> +#define MT7623_PIN_93_MIPI_TDN2_FUNC_TDN2 (MTK_PIN_NO(93) | 1)\n> +\n> +#define MT7623_PIN_94_MIPI_TDP2_FUNC_GPIO94 (MTK_PIN_NO(94) | 0)\n> +#define MT7623_PIN_94_MIPI_TDP2_FUNC_TDP2 (MTK_PIN_NO(94) | 1)\n> +\n>  #define MT7623_PIN_95_MIPI_TCN_FUNC_GPIO95 (MTK_PIN_NO(95) | 0)\n>  #define MT7623_PIN_95_MIPI_TCN_FUNC_TCN (MTK_PIN_NO(95) | 1)\n>  \n\nRegards,\nCK","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"hjSwzIwJ\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxhYF1hwZz9sNw\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 11:12:17 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duTYg-0002Bt-G4; Wed, 20 Sep 2017 01:12:10 +0000","from [210.61.82.183] (helo=mailgw01.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duTYa-000240-JJ; Wed, 20 Sep 2017 01:12:07 +0000","from mtkcas09.mediatek.inc [(172.21.101.178)] by\n\tmailgw01.mediatek.com (envelope-from <ck.hu@mediatek.com>)\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 582240607; Wed, 20 Sep 2017 09:11:36 +0800","from mtkcas09.mediatek.inc (172.21.101.178) by\n\tmtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Wed, 20 Sep 2017 09:11:21 +0800","from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Wed, 20 Sep 2017 09:11:53 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=wQpq8XsCS0ZqHLG5wx6C+a9gyaQ13oWrktRYztDw5bg=;\n\tb=hjSwzIwJ7hpoNo\n\tWjD1Cs9Dm/UXxUpDkaSva7p1zPtj8eL8eG8Wy7GRRXFrZvR+H08Ls09UK5D9pwuzNEhQI/g4AJJtj\n\twflVYyXo9RSekCQbOPiPmcQbNGqwe6j+Y4AGqCOESmKLJx0oNaMhq0m8qhQwpDEfJ9PlUvWCB7S4j\n\tJzezMebWBqZy1bYTB0JrTYcvqlKyl/t+522KunMHuQ/3JJsQFZOa3fandmErzzRF3gB+ZCzIYzxXB\n\tgt+v0XWzTjW/wkklmHvMGolnL7LyiQNJtC8m7a/Hx0Qmmz23HrrSQ9aPUCHJJ7on8rnFSXPNJWAGk\n\ttqXbD5nmPWdxlfcxxugg==;","X-UUID":"3ed18ea5b8994da59edca09b88069032-20170920","Message-ID":"<1505869897.27600.6.camel@mtksdaap41>","Subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","From":"CK Hu <ck.hu@mediatek.com>","To":"Ryder Lee <ryder.lee@mediatek.com>","Date":"Wed, 20 Sep 2017 09:11:37 +0800","In-Reply-To":"<0eb19ae1a4717d316cdaec44f6c20bfa8aa24ddc.1505801355.git.ryder.lee@mediatek.com>","References":"<cover.1505801355.git.ryder.lee@mediatek.com>\n\t<0eb19ae1a4717d316cdaec44f6c20bfa8aa24ddc.1505801355.git.ryder.lee@mediatek.com>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_181204_993429_8229D2D9 ","X-CRM114-Status":"GOOD (  15.69  )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.1 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,\n\tlinux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1772629,"web_url":"http://patchwork.ozlabs.org/comment/1772629/","msgid":"<1505987424.3084.8.camel@mtkswgap22>","list_archive_url":null,"date":"2017-09-21T09:50:24","subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","submitter":{"id":70514,"url":"http://patchwork.ozlabs.org/api/people/70514/","name":"Ryder Lee","email":"ryder.lee@mediatek.com"},"content":"On Tue, 2017-09-19 at 23:26 +0800, CK Hu wrote:\n> Hi, Ryder:\n> \n> Some comment inline.\n> \n> On Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote:\n> > This patch adds the device nodes for the display function block.\n> > Also, we add some missing pin macros in mt7623-pinfunc.h.\n> > \n> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>\n> > CC: Linus Walleij <linus.walleij@linaro.org>\n> > Acked-by: Linus Walleij <linus.walleij@linaro.org>\n> > ---\n> >  arch/arm/boot/dts/mt7623.dtsi                 | 210 ++++++++++++++++++++++++++\n> >  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts |  41 ++++-\n> >  include/dt-bindings/pinctrl/mt7623-pinfunc.h  |  12 ++\n> >  3 files changed, 261 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi\n> > index 9ec3767..e11e5e7 100644\n> > --- a/arch/arm/boot/dts/mt7623.dtsi\n> > +++ b/arch/arm/boot/dts/mt7623.dtsi\n> > @@ -20,6 +20,7 @@\n> >  #include <dt-bindings/power/mt2701-power.h>\n> >  #include <dt-bindings/gpio/gpio.h>\n> >  #include <dt-bindings/phy/phy.h>\n> > +#include <dt-bindings/memory/mt2701-larb-port.h>\n> >  #include <dt-bindings/reset/mt2701-resets.h>\n> >  #include <dt-bindings/thermal/thermal.h>\n> >  #include \"skeleton64.dtsi\"\n> > @@ -28,6 +29,11 @@\n> >  \tcompatible = \"mediatek,mt7623\";\n> >  \tinterrupt-parent = <&sysirq>;\n> >  \n> > +\taliases {\n> > +\t\trdma0 = &rdma0;\n> > +\t\trdma1 = &rdma1;\n> \n> For display, are these two aliases enough?\n\nYes, this part is the same as mt2701.\n\nhttps://patchwork.kernel.org/patch/9803813/\n\n> > +\t};\n> > +\n\n...\n> > +\twdma@14009000 {\n> > +\t\tcompatible = \"mediatek,mt7623-disp-wdma\",\n> > +\t\t\t     \"mediatek,mt2701-disp-wdma\";\n> \n> There is neither \"mediatek,mt7623-disp-wdma\" nor\n> \"mediatek,mt2701-disp-wdma\" in driver, do you really need this device\n> node?\n\nOkay, I will remove it.\n\n> > +\t\treg = <0 0x14009000 0 0x1000>;\n> > +\t\tinterrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_LOW>;\n> > +\t\tclocks = <&mmsys CLK_MM_DISP_WDMA>;\n> > +\t\tiommus = <&iommu MT2701_M4U_PORT_DISP_WDMA>;\n> > +\t\tmediatek,larb = <&larb0>;\n> > +\t};\n> > +\n> > +\tbls: bls@1400a000 {\n> > +\t\tcompatible = \"mediatek,mt7623-disp-pwm\",\n> > +\t\t\t     \"mediatek,mt2701-disp-pwm\";\n> > +\t\treg = <0 0x1400a000 0 0x1000>;\n> > +\t\t#pwm-cells = <2>;\n> > +\t\tclocks = <&mmsys CLK_MM_MDP_BLS_26M>,\n> > +\t\t\t <&mmsys CLK_MM_DISP_BLS>;\n> > +\t\tclock-names = \"main\", \"mm\";\n> > +\t\tstatus = \"disabled\";\n> > +\t};\n> > +\n> > +\tcolor@1400b000 {\n> \n> color: color@1400b000 {\n\nOkay.\n> > +\t\tcompatible = \"mediatek,mt7623-disp-color\",\n> > +\t\t\t     \"mediatek,mt2701-disp-color\";\n> > +\t\treg = <0 0x1400b000 0 0x1000>;\n> > +\t\tinterrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_LOW>;\n> > +\t\tclocks = <&mmsys CLK_MM_DISP_COLOR>;\n> > +\t};\n> > +","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"EI0xHBkm\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyX1Q3j5Zz9t4Z\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 19:51:06 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duy8N-0003bW-3H; Thu, 21 Sep 2017 09:51:03 +0000","from [210.61.82.184] (helo=mailgw02.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duy8H-0003TF-3F; Thu, 21 Sep 2017 09:50:59 +0000","from mtkcas09.mediatek.inc [(172.21.101.178)] by\n\tmailgw02.mediatek.com (envelope-from <ryder.lee@mediatek.com>)\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 988510608; Thu, 21 Sep 2017 17:50:26 +0800","from mtkcas07.mediatek.inc (172.21.101.84) by\n\tmtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Thu, 21 Sep 2017 17:50:12 +0800","from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Thu, 21 Sep 2017 17:49:46 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=xasGti+3VtreTzCokgTPHODofCSjp5eenz+N+ZQPy/Q=;\n\tb=EI0xHBkmNYqumh\n\t2/3eEwlxAAwpD79yIkwbBYYB/jrvpzwYvlB9EXbFb+SqOUCG8wJc478sMswTNmYHqXwG2kSu04eGM\n\tkKqA9jBpwUFGLQs8TiDc9+mygL3KK+fjlE15ns8OU2M2e6FQL2gGRr1hPlWdzQfHQ26WwcWYoCtoY\n\tpaLfB8RDPFLegyGyHOeV8a0L4pfe5r6G3TQqO3a23orS9GGePYRx9tRNsoT1cRBVXdxIu5pNyZuHl\n\tixXKb0GQUbF0Q3MszJsbRc9SxQGpxBJ2D87Iley4OIJXTVD3Kt7QU8LqdewUuhO1OnT95DWDCznq6\n\tkBA+M65piHd0kW3E6B+A==;","X-UUID":"130ece11292f4b1a9c72a96f557de6bb-20170921","Message-ID":"<1505987424.3084.8.camel@mtkswgap22>","Subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","From":"Ryder Lee <ryder.lee@mediatek.com>","To":"CK Hu <ck.hu@mediatek.com>","Date":"Thu, 21 Sep 2017 17:50:24 +0800","In-Reply-To":"<1505834813.16414.5.camel@mtksdaap41>","References":"<cover.1505801355.git.ryder.lee@mediatek.com>\n\t<0eb19ae1a4717d316cdaec44f6c20bfa8aa24ddc.1505801355.git.ryder.lee@mediatek.com>\n\t<1505834813.16414.5.camel@mtksdaap41>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_025057_399475_5FCFA6E0 ","X-CRM114-Status":"GOOD (  17.72  )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.1 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,\n\tlinux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1772631,"web_url":"http://patchwork.ozlabs.org/comment/1772631/","msgid":"<1505987616.3084.12.camel@mtkswgap22>","list_archive_url":null,"date":"2017-09-21T09:53:36","subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","submitter":{"id":70514,"url":"http://patchwork.ozlabs.org/api/people/70514/","name":"Ryder Lee","email":"ryder.lee@mediatek.com"},"content":"On Wed, 2017-09-20 at 09:11 +0800, CK Hu wrote:\n> Hi, Ryder:\n> \n> Mode comment inline.\n> \n> On Tue, 2017-09-19 at 14:27 +0800, Ryder Lee wrote:\n>  \n> > +\tsmi_common: smi@1000c000 {\n> > +\t\tcompatible = \"mediatek,mt7623-smi-common\",\n> > +\t\t\t     \"mediatek,mt2701-smi-common\";\n> > +\t\treg = <0 0x1000c000 0 0x1000>;\n> > +\t\tclocks = <&infracfg CLK_INFRA_SMI>,\n> > +\t\t\t <&mmsys CLK_MM_SMI_COMMON>,\n> > +\t\t\t <&infracfg CLK_INFRA_SMI>;\n> > +\t\tclock-names = \"apb\", \"smi\", \"async\";\n> > +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> > +\t};\n> > +\n\n> > +\tiommu: mmsys_iommu@10205000 {\n> > +\t\tcompatible = \"mediatek,mt7623-m4u\",\n> > +\t\t\t     \"mediatek,mt2701-m4u\";\n> > +\t\treg = <0 0x10205000 0 0x1000>;\n> > +\t\tinterrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_LOW>;\n> > +\t\tclocks = <&infracfg CLK_INFRA_M4U>;\n> > +\t\tclock-names = \"bclk\";\n> > +\t\tmediatek,larbs = <&larb0 &larb1 &larb2>;\n> > +\t\t#iommu-cells = <1>;\n> > +\t};\n> > +\n> > +\tmmsys: syscon@14000000 {\n> > +\t\tcompatible = \"mediatek,mt7623-mmsys\",\n> > +\t\t\t     \"mediatek,mt2701-mmsys\",\n> > +\t\t\t     \"syscon\";\n> > +\t\treg = <0 0x14000000 0 0x1000>;\n> > +\t\t#clock-cells = <1>;\n> > +\t};\n> > +\n\n> > +\tlarb0: larb@14010000 {\n> > +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> > +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> > +\t\treg = <0 0x14010000 0 0x1000>;\n> > +\t\tmediatek,smi = <&smi_common>;\n> > +\t\tmediatek,larb-id = <0>;\n> > +\t\tclocks = <&mmsys CLK_MM_SMI_LARB0>,\n> > +\t\t\t <&mmsys CLK_MM_SMI_LARB0>;\n> > +\t\tclock-names = \"apb\", \"smi\";\n> > +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_DISP>;\n> > +\t};\n\n> > +\timgsys: syscon@15000000 {\n> > +\t\tcompatible = \"mediatek,mt7623-imgsys\",\n> > +\t\t\t     \"mediatek,mt2701-imgsys\",\n> > +\t\t\t     \"syscon\";\n> > +\t\treg = <0 0x15000000 0 0x1000>;\n> > +\t\t#clock-cells = <1>;\n> > +\t};\n> > +\n> > +\tlarb2: larb@15001000 {\n> > +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> > +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> > +\t\treg = <0 0x15001000 0 0x1000>;\n> > +\t\tmediatek,smi = <&smi_common>;\n> > +\t\tmediatek,larb-id = <2>;\n> > +\t\tclocks = <&imgsys CLK_IMG_SMI_COMM>,\n> > +\t\t\t <&imgsys CLK_IMG_SMI_COMM>;\n> > +\t\tclock-names = \"apb\", \"smi\";\n> > +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ISP>;\n> > +\t};\n> > +\n> > +\tjpegdec: jpegdec@15004000 {\n> > +\t\tcompatible = \"mediatek,mt7623-jpgdec\",\n> > +\t\t\t     \"mediatek,mt2701-jpgdec\";\n> > +\t\treg = <0 0x15004000 0 0x1000>;\n> > +\t\tinterrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_LOW>;\n> > +\t\tclocks =  <&imgsys CLK_IMG_JPGDEC_SMI>,\n> > +\t\t\t  <&imgsys CLK_IMG_JPGDEC>;\n> > +\t\tclock-names = \"jpgdec-smi\",\n> > +\t\t\t      \"jpgdec\";\n> > +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ISP>;\n> > +\t\tmediatek,larb = <&larb2>;\n> > +\t\tiommus = <&iommu MT2701_M4U_PORT_JPGDEC_WDMA>,\n> > +\t\t\t <&iommu MT2701_M4U_PORT_JPGDEC_BSDMA>;\n> > +\t};\n> \n> jpegdec and some other device node is not related to display. I think\n> you should move them to another patch.\n\nYes, you're right.\n> > +\n> > +\tvdecsys: syscon@16000000 {\n> > +\t\tcompatible = \"mediatek,mt7623-vdecsys\",\n> > +\t\t\t     \"mediatek,mt2701-vdecsys\",\n> > +\t\t\t     \"syscon\";\n> > +\t\treg = <0 0x16000000 0 0x1000>;\n> > +\t\t#clock-cells = <1>;\n> > +\t};\n> > +\n> > +\tlarb1: larb@16010000 {\n> > +\t\tcompatible = \"mediatek,mt7623-smi-larb\",\n> > +\t\t\t     \"mediatek,mt2701-smi-larb\";\n> > +\t\treg = <0 0x16010000 0 0x1000>;\n> > +\t\tmediatek,smi = <&smi_common>;\n> > +\t\tmediatek,larb-id = <1>;\n> > +\t\tclocks = <&vdecsys CLK_VDEC_CKGEN>,\n> > +\t\t\t <&vdecsys CLK_VDEC_LARB>;\n> > +\t\tclock-names = \"apb\", \"smi\";\n> > +\t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_VDEC>;\n> > +\t};\n> > +\n> >  \thifsys: syscon@1a000000 {\n> >  \t\tcompatible = \"mediatek,mt7623-hifsys\",\n> >  \t\t\t     \"mediatek,mt2701-hifsys\",\n> > @@ -799,4 +1001,12 @@\n> >  \t\tpower-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;\n> >  \t\tstatus = \"disabled\";\n> >  \t};\n> > +\n> > +\tbdpsys: syscon@1c000000 {\n> > +\t\tcompatible = \"mediatek,mt7623-bdpsys\",\n> > +\t\t\t     \"mediatek,mt2701-bdpsys\",\n> > +\t\t\t     \"syscon\";\n> > +\t\treg = <0 0x1c000000 0 0x1000>;\n> > +\t\t#clock-cells = <1>;\n> > +\t};\n> >  };\n\nI will move these nodes to different patches.\n\n> > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> > index 688a863..267a05a 100644\n> > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts\n> > @@ -17,6 +17,17 @@\n> >  \t\tserial2 = &uart2;\n> >  \t};\n> >  \n> > +\tbacklight_lcd: backlight_lcd {\n> > +\t\tcompatible = \"pwm-backlight\";\n> > +\t\tpwms = <&bls 0 100000>;\n> > +\t\tbrightness-levels = <\n> > +\t\t\t  0  16  32  48  64  80  96 112\n> > +\t\t\t128 144 160 176 192 208 224 240\n> > +\t\t\t255\n> > +\t\t>;\n> > +\t\tdefault-brightness-level = <9>;\n> > +\t};\n> > +\n> \n> I think this patch only for mt7623 common dtsi modification. This part\n> is just for bananapi-bpi-r2, so move non-common part to another patch.\n> \nOkay.","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"NMCtDNim\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyX545DZcz9t49\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 19:54:16 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duyBP-0004Zq-0f; Thu, 21 Sep 2017 09:54:11 +0000","from [210.61.82.184] (helo=mailgw02.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duyBF-0004RO-8n; Thu, 21 Sep 2017 09:54:08 +0000","from mtkcas08.mediatek.inc [(172.21.101.126)] by\n\tmailgw02.mediatek.com (envelope-from <ryder.lee@mediatek.com>)\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 902349530; Thu, 21 Sep 2017 17:53:37 +0800","from mtkcas08.mediatek.inc (172.21.101.126) by\n\tmtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server\n\t(TLS) id 15.0.1210.3; Thu, 21 Sep 2017 17:53:31 +0800","from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc\n\t(172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via\n\tFrontend Transport; Thu, 21 Sep 2017 17:53:00 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=4MBmwjwW/xZ6Z7+0Y3phbkCpvEASF5cjoK9s1CXGylc=;\n\tb=NMCtDNimqvDl6l\n\tw9RS23aX/WITrVIx1eDONUEWCcu+huLaElxPQe4SQY2cUjYr8vckFvpkDlfrknz4W3oJsP08bTA4n\n\t/xjXUNGBi7BuHrndssPG4GC8Gs0EDeMmusrkNdyLCG0VGTcOT8BXYWbfHPUNgupGuCOkm9VVtYhnx\n\tVbGuR9VZAeZBi+AwrzyqkufKv7c7xX+za2KgsfGJ76nycOK/Dj+KXa5zu6aiCoFESdl0Izd20CJsH\n\teXLDf8BqqH+CPZH5o6ZDNRTFpFf16LRnbYnhTMlJbZSguLmDM10ylZ4OyTHaUsxCht9jSqa90BMKg\n\t346Clt+Ulf59fhTJC3SQ==;","X-UUID":"6aaef63fb749440cac961445928bdfdd-20170921","Message-ID":"<1505987616.3084.12.camel@mtkswgap22>","Subject":"Re: [PATCH v1 3/4] arm: dts: mt7623: add display related nodes","From":"Ryder Lee <ryder.lee@mediatek.com>","To":"CK Hu <ck.hu@mediatek.com>","Date":"Thu, 21 Sep 2017 17:53:36 +0800","In-Reply-To":"<1505869897.27600.6.camel@mtksdaap41>","References":"<cover.1505801355.git.ryder.lee@mediatek.com>\n\t<0eb19ae1a4717d316cdaec44f6c20bfa8aa24ddc.1505801355.git.ryder.lee@mediatek.com>\n\t<1505869897.27600.6.camel@mtksdaap41>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_025401_648368_95E2193A ","X-CRM114-Status":"GOOD (  14.76  )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.1 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"devicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>,\n\tlinux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]