[{"id":1770636,"web_url":"http://patchwork.ozlabs.org/comment/1770636/","msgid":"<20170919035900.GI5788@mtr-leonro.local>","list_archive_url":null,"date":"2017-09-19T03:59:00","subject":"Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08\n\tSoC","submitter":{"id":68852,"url":"http://patchwork.ozlabs.org/api/people/68852/","name":"Leon Romanovsky","email":"leon@kernel.org"},"content":"On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote:\n> This patch set presents some bug fixes for the HNS3 Ethernet driver, identified\n> during internal testing & stabilization efforts.\n>\n> This patch series is meant for Linux 4.14 kernel.\n>\n> Lipeng (6):\n> net: hns3: get phy addr from NCL_config\n> net: hns3: fix the command used to unmap ring from vector\n> net: hns3: Fix ring and vector map command\n> net: hns3: fix a bug of set mac address\n> net: hns3: set default vlan id to PF\n> net: hns3: Fixes the premature exit of loop when matching clients\n>\n> Salil Mehta (1):\n> net: hns3: fixes the ether address copy with more appropriate API\n\n1. The fixes patches should have Fixes line and not all of them have\n(I didn't look all patches).\n2. Please decide on one style: fixes vs. Fixes, fix vs. Fix in the titles\n3. Subject should be descriptive and usable, I don't know if it applies\nto the \"fix a bug of set mac address\" patch.\n\nThanks\n\n>\n> drivers/net/ethernet/hisilicon/hns3/hnae3.c | 43 +++++-----------------\n> .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 +++-\n> .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 20 ++++++++--\n> .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 7 ++--\n> 4 files changed, 35 insertions(+), 43 deletions(-)\n>\n> --\n> 2.11.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=leon@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx8JV75F7z9ryQ\n\tfor ;\n\tTue, 19 Sep 2017 13:59:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751372AbdISD7F (ORCPT );\n\tMon, 18 Sep 2017 23:59:05 -0400","from mail.kernel.org ([198.145.29.99]:60436 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751210AbdISD7E (ORCPT );\n\tMon, 18 Sep 2017 23:59:04 -0400","from localhost (unknown [213.57.247.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 0FD5E2168C;\n\tTue, 19 Sep 2017 03:59:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 0FD5E2168C","Date":"Tue, 19 Sep 2017 06:59:00 +0300","From":"Leon Romanovsky ","To":"Salil Mehta ","Cc":"davem@davemloft.net, yisen.zhuang@huawei.com, lipeng321@huawei.com,\n\tmehta.salil.lnk@gmail.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinuxarm@huawei.com","Subject":"Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for Hip08\n\tSoC","Message-ID":"<20170919035900.GI5788@mtr-leonro.local>","References":"<20170919010628.175732-1-salil.mehta@huawei.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"7SAgGoIHugoKhRwh\"","Content-Disposition":"inline","In-Reply-To":"<20170919010628.175732-1-salil.mehta@huawei.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771066,"web_url":"http://patchwork.ozlabs.org/comment/1771066/","msgid":"","list_archive_url":null,"date":"2017-09-19T14:12:49","subject":"RE: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for\n\tHip08 SoC","submitter":{"id":67454,"url":"http://patchwork.ozlabs.org/api/people/67454/","name":"Salil Mehta","email":"salil.mehta@huawei.com"},"content":"Hi Leon,\n\n> -----Original Message-----\n> From: Leon Romanovsky [mailto:leon@kernel.org]\n> Sent: Tuesday, September 19, 2017 4:59 AM\n> To: Salil Mehta\n> Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y);\n> mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux-\n> kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm\n> Subject: Re: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for\n> Hip08 SoC\n> \n> On Tue, Sep 19, 2017 at 02:06:21AM +0100, Salil Mehta wrote:\n> > This patch set presents some bug fixes for the HNS3 Ethernet driver,\n> identified\n> > during internal testing & stabilization efforts.\n> >\n> > This patch series is meant for Linux 4.14 kernel.\n> >\n> > Lipeng (6):\n> > net: hns3: get phy addr from NCL_config\n> > net: hns3: fix the command used to unmap ring from vector\n> > net: hns3: Fix ring and vector map command\n> > net: hns3: fix a bug of set mac address\n> > net: hns3: set default vlan id to PF\n> > net: hns3: Fixes the premature exit of loop when matching clients\n> >\n> > Salil Mehta (1):\n> > net: hns3: fixes the ether address copy with more appropriate API\n> \n> 1. The fixes patches should have Fixes line and not all of them have\n> (I didn't look all patches).\n> 2. Please decide on one style: fixes vs. Fixes, fix vs. Fix in the\n> titles\n> 3. Subject should be descriptive and usable, I don't know if it applies\n> to the \"fix a bug of set mac address\" patch.\nYes, missed these. Will fix them. Thanks!\n\nSalil\n> \n> Thanks\n> \n> >\n> > drivers/net/ethernet/hisilicon/hns3/hnae3.c | 43 +++++-------\n> ----------\n> > .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 8 +++-\n> > .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 20 ++++++++--\n> > .../net/ethernet/hisilicon/hns3/hns3pf/hns3_enet.c | 7 ++--\n> > 4 files changed, 35 insertions(+), 43 deletions(-)\n> >\n> > --\n> > 2.11.0\n> >\n> >","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxPwr4yd5z9s7c\n\tfor ;\n\tWed, 20 Sep 2017 00:13:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751583AbdISONE convert rfc822-to-8bit (ORCPT\n\t);\n\tTue, 19 Sep 2017 10:13:04 -0400","from lhrrgout.huawei.com ([194.213.3.17]:35677 \"EHLO\n\tlhrrgout.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751284AbdISOND (ORCPT\n\t); Tue, 19 Sep 2017 10:13:03 -0400","from 172.18.7.190 (EHLO lhreml708-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DVU45498; Tue, 19 Sep 2017 14:13:00 +0000 (GMT)","from FRAEML704-CAH.china.huawei.com (10.206.14.35) by\n\tlhreml708-cah.china.huawei.com (10.201.108.49) with Microsoft SMTP\n\tServer (TLS) id 14.3.301.0; Tue, 19 Sep 2017 15:12:59 +0100","from FRAEML521-MBX.china.huawei.com ([169.254.1.161]) by\n\tFRAEML704-CAH.china.huawei.com ([10.206.14.35]) with mapi id\n\t14.03.0301.000; Tue, 19 Sep 2017 16:12:49 +0200"],"From":"Salil Mehta ","To":"Leon Romanovsky ","CC":"\"davem@davemloft.net\" ,\n\t\"Zhuangyuzeng (Yisen)\" ,\n\t\"lipeng (Y)\" ,\n\t\"mehta.salil.lnk@gmail.com\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"linux-rdma@vger.kernel.org\" ,\n\tLinuxarm ","Subject":"RE: [PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for\n\tHip08 SoC","Thread-Topic":"[PATCH net 0/7] Bug fixes for the HNS3 Ethernet Driver for\n\tHip08 SoC","Thread-Index":"AQHTMOOjVvz6itsNQUOzTYsI3uoCiaK7c/EAgADMgNA=","Date":"Tue, 19 Sep 2017 14:12:49 +0000","Message-ID":"","References":"<20170919010628.175732-1-salil.mehta@huawei.com>\n\t<20170919035900.GI5788@mtr-leonro.local>","In-Reply-To":"<20170919035900.GI5788@mtr-leonro.local>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.203.181.154]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020202.59C125EC.0224, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, \n\tip=169.254.1.161, so=2013-06-18 04:22:30,\n\tdmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"77a09da0e44a48a681cdc9efde3a519e","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]