[{"id":1771262,"web_url":"http://patchwork.ozlabs.org/comment/1771262/","msgid":"","list_archive_url":null,"date":"2017-09-19T18:05:35","subject":"Re: [PATCH v4 0/3] Add support for BCM7271 style interrupt\n\tcontroller","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/18/2017 05:59 PM, Doug Berger wrote:\n> This patch set extends the functionality of the irq-brcmstb-l2 interrupt\n> controller driver to cover a hardware variant first introduced in the\n> BCM7271 SoC. The main difference between this variant and the block\n> found in earlier brcmstb SoCs is that this variant only supports level\n> sensitive interrupts and therefore does not latch the interrupt state\n> based on edges. Since there is no longer a need to ack interrupts with\n> a register write to clear the latch the register map has been changed.\n> \n> Therefore the change to add support for the new hardware block is to\n> abstract the register accesses to accommodate different maps and to\n> identify the block with a new device-tree compatible string.\n> \n> I also took the opportunity to make some small efficiency enhancements\n> to the driver. One of these was to make use of the slightly more\n> efficient irq_mask_ack method. However, I discovered that the defined\n> irq_gc_mask_disable_reg_and_ack() generic irq function was insufficient\n> for my needs. Previous submissions offered candidate solutions to\n> address my needs within the generic irqchip library, but since those\n> submissions appear to have stalled I am submitting this version that\n> includes the function in the driver to prevent controversy and allow\n> the new functionality to be included. \n\nFor this entire series:\n\nReviewed-by: Florian Fainelli \n\nThanks Doug.\n\n> \n> Changes in v4:\n> \n> - The first three commits were removed from the patch set to remove any\n> dependencies on changing the generic irqchip or irqchip-tango imple-\n> mentations. If there is a will to make those changes in the future\n> they can be applied at that time, but they needn't hold up the accept-\n> ance of this patch set.\n> \n> Changes in v3:\n> \n> - I did not submit a v3 patch set, but Marc Gonzalez included a PATCH v3\n> in a response to the v2 patch so I am skipping ahead to v4 to avoid\n> confusion.\n> \n> Changes in v2:\n> \n> - removed unused permutations of irq_mask_ack methods\n> - added Reviewed-by and Acked-by responses from first submission\n> \n> Doug Berger (3):\n> irqchip: brcmstb-l2: Remove some processing from the handler\n> irqchip: brcmstb-l2: Abstract register accesses\n> irqchip: brcmstb-l2: Add support for the BCM7271 L2 controller\n> \n> .../bindings/interrupt-controller/brcm,l2-intc.txt | 3 +-\n> drivers/irqchip/irq-brcmstb-l2.c | 171 +++++++++++++++------\n> 2 files changed, 126 insertions(+), 48 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"SGJUvdI1\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qfvTwiiN\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxW5c09Ddz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 04:06:12 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duMuO-0005U2-5W; Tue, 19 Sep 2017 18:06:08 +0000","from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duMuK-0005PK-6n for linux-arm-kernel@lists.infradead.org;\n\tTue, 19 Sep 2017 18:06:06 +0000","by mail-qt0-x244.google.com with SMTP id t46so254168qtj.3\n\tfor ;\n\tTue, 19 Sep 2017 11:05:42 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu17sm7398122qtc.15.2017.09.19.11.05.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 11:05:40 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=UgZefjEdaEBjUWck+Q0t0OUlSftB2DxGsNYu5CEsVzc=;\n\tb=SGJUvdI1bpcxKd\n\tSiDZ4ArHYJgkctu/PprJIY49ZGFVv5dgFvifnU4xYKksaDF7GaAG9Vu4i6I3eaeUrkUbJ3Br4+To7\n\tCKgUq3Vuqk7Njc4BIUlI9TnOy43EZ9p4RlOqkXFwpvM800HCusLcURQsjZS5iATcpZWyh0vnt5KD+\n\tfeBhjWBCXzAVwF5BlmY8EKdC2iOa2wrZK2kBeHkGjtADg9+vn+4vvAqh7GY6Pdt+0UBQc1j5hntIe\n\tj7PaIwY4pLsebNHK8wsINiaWNMulfQFQ7zPUE2dxRtcleaMV15szMwWs7ma1gYbFAjDQVJtB5Tl+x\n\tznKvS0EP6aA1JQf5Y9AQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=UeUirkkL9biszv//tMsmWqmcEbbAyFJelgl79oSDdjc=;\n\tb=qfvTwiiNRG+dyzTqF8aDhX5sHOX0ZxRKu80mIrfKPViajhS5BspkV5ZhiO4nr2R1uo\n\tyI1PhLeMNH0QARMpkRsgKKvDjYXGSbGOMbh+fNqSiY6IuoweR7gS+/LdzAbtzMZa5EZF\n\tBPJD6YL1vh7caBxqDyKxnFJdyRQgRmewr0lNs4HAz6ubyveqmRK33YS9sCX3mlYuKO53\n\t5KrsBzS6C/QYujh3pInVx7tyEQ8cGK/qhnYbYjpbjtNTMcsZeaRpOIUaVZadxPih2Wvg\n\tI9PuoKtmvyKP2S54apDNCC/0I0wNlH8CC875139/S9+2jsM4LjkTmW6xpb36j7tIdVOT\n\tgyTg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=UeUirkkL9biszv//tMsmWqmcEbbAyFJelgl79oSDdjc=;\n\tb=DD1Os2CrS6mu4WHMXDw3ttdwSwtXawQToVJpu9+8EUAhSNTlUb5fV23Q/jDhmcfS23\n\tsv440rMwb90mYh8SuyIXen+4z8BZSGd/WW4pwrmVWYMKzshZDsg6ctrb7MjiG05T4OkL\n\tEDUmw4YOpBWuEpAPyeJrb6z/AhLLEpbyC08hT7kQHbgq/Cdlp6s62JoK/qASvpkh0Wj1\n\tqfZLHxK+2TITplqlEvJCK5pDKtr9zVOgAXf5qFbP1oJbkWfR9x5wNA65qLso7H5oBXlo\n\tG/vWVuRiHhimGbq+1CCLNvvWZYd6rVBlGukqMR9dra9IQctTX7E/p8OY2Xxa1F3rpBiL\n\tYlIA==","X-Gm-Message-State":"AHPjjUhkFRuPOFLS+IOLEEET5CK1v58rhTQ4GL11xZHNTSN/aWbxewt3\n\tDV7smLbqmDgtM70JKdTw4HcIAhQD","X-Google-Smtp-Source":"AOwi7QC4txgQYSMLtWlMTjSgY/RWNRpR12Y+QWOkKOsLcj+JDUc+FNjYVJe9i8HOm0la9yDPvApsXg==","X-Received":"by 10.200.25.78 with SMTP id g14mr3358913qtk.48.1505844341260;\n\tTue, 19 Sep 2017 11:05:41 -0700 (PDT)","Subject":"Re: [PATCH v4 0/3] Add support for BCM7271 style interrupt\n\tcontroller","To":"Doug Berger , Thomas Gleixner ","References":"<20170919010000.32072-1-opendmb@gmail.com>","From":"Florian Fainelli ","Message-ID":"","Date":"Tue, 19 Sep 2017 11:05:35 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170919010000.32072-1-opendmb@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_110604_365035_BC8182DB ","X-CRM114-Status":"GOOD ( 24.57 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400d:c0d:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (f.fainelli[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mark Rutland , Sebastian Frias , \n\tMans Rullgard , Jason Cooper ,\n\tlinux-mips@linux-mips.org, Mason ,\n\tMarc Zyngier ,\n\tBoris Brezillon ,\n\tBartosz Golaszewski ,\n\tKevin Cernekee , \n\tlinux-kernel@vger.kernel.org, devicetree@vger.kernel.org,\n\tRob Herring , bcm-kernel-feedback-list@broadcom.com, \n\tGregory Fong ,\n\tBrian Norris ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tMarc Gonzalez ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]