[{"id":1771261,"web_url":"http://patchwork.ozlabs.org/comment/1771261/","msgid":"","list_archive_url":null,"date":"2017-09-19T18:05:35","subject":"Re: [PATCH v4 0/3] Add support for BCM7271 style interrupt\n\tcontroller","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/18/2017 05:59 PM, Doug Berger wrote:\n> This patch set extends the functionality of the irq-brcmstb-l2 interrupt\n> controller driver to cover a hardware variant first introduced in the\n> BCM7271 SoC. The main difference between this variant and the block\n> found in earlier brcmstb SoCs is that this variant only supports level\n> sensitive interrupts and therefore does not latch the interrupt state\n> based on edges. Since there is no longer a need to ack interrupts with\n> a register write to clear the latch the register map has been changed.\n> \n> Therefore the change to add support for the new hardware block is to\n> abstract the register accesses to accommodate different maps and to\n> identify the block with a new device-tree compatible string.\n> \n> I also took the opportunity to make some small efficiency enhancements\n> to the driver. One of these was to make use of the slightly more\n> efficient irq_mask_ack method. However, I discovered that the defined\n> irq_gc_mask_disable_reg_and_ack() generic irq function was insufficient\n> for my needs. Previous submissions offered candidate solutions to\n> address my needs within the generic irqchip library, but since those\n> submissions appear to have stalled I am submitting this version that\n> includes the function in the driver to prevent controversy and allow\n> the new functionality to be included. \n\nFor this entire series:\n\nReviewed-by: Florian Fainelli \n\nThanks Doug.\n\n> \n> Changes in v4:\n> \n> - The first three commits were removed from the patch set to remove any\n> dependencies on changing the generic irqchip or irqchip-tango imple-\n> mentations. If there is a will to make those changes in the future\n> they can be applied at that time, but they needn't hold up the accept-\n> ance of this patch set.\n> \n> Changes in v3:\n> \n> - I did not submit a v3 patch set, but Marc Gonzalez included a PATCH v3\n> in a response to the v2 patch so I am skipping ahead to v4 to avoid\n> confusion.\n> \n> Changes in v2:\n> \n> - removed unused permutations of irq_mask_ack methods\n> - added Reviewed-by and Acked-by responses from first submission\n> \n> Doug Berger (3):\n> irqchip: brcmstb-l2: Remove some processing from the handler\n> irqchip: brcmstb-l2: Abstract register accesses\n> irqchip: brcmstb-l2: Add support for the BCM7271 L2 controller\n> \n> .../bindings/interrupt-controller/brcm,l2-intc.txt | 3 +-\n> drivers/irqchip/irq-brcmstb-l2.c | 171 +++++++++++++++------\n> 2 files changed, 126 insertions(+), 48 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qfvTwiiN\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxW5451qkz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 04:05:44 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750872AbdISSFn (ORCPT\n\t);\n\tTue, 19 Sep 2017 14:05:43 -0400","from mail-qt0-f194.google.com ([209.85.216.194]:38547 \"EHLO\n\tmail-qt0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750733AbdISSFm (ORCPT\n\t); Tue, 19 Sep 2017 14:05:42 -0400","by mail-qt0-f194.google.com with SMTP id f24so248693qte.5;\n\tTue, 19 Sep 2017 11:05:41 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu17sm7398122qtc.15.2017.09.19.11.05.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 11:05:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=UeUirkkL9biszv//tMsmWqmcEbbAyFJelgl79oSDdjc=;\n\tb=qfvTwiiNRG+dyzTqF8aDhX5sHOX0ZxRKu80mIrfKPViajhS5BspkV5ZhiO4nr2R1uo\n\tyI1PhLeMNH0QARMpkRsgKKvDjYXGSbGOMbh+fNqSiY6IuoweR7gS+/LdzAbtzMZa5EZF\n\tBPJD6YL1vh7caBxqDyKxnFJdyRQgRmewr0lNs4HAz6ubyveqmRK33YS9sCX3mlYuKO53\n\t5KrsBzS6C/QYujh3pInVx7tyEQ8cGK/qhnYbYjpbjtNTMcsZeaRpOIUaVZadxPih2Wvg\n\tI9PuoKtmvyKP2S54apDNCC/0I0wNlH8CC875139/S9+2jsM4LjkTmW6xpb36j7tIdVOT\n\tgyTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=UeUirkkL9biszv//tMsmWqmcEbbAyFJelgl79oSDdjc=;\n\tb=O+FDEvCIF/5tJcgMM3C3tT53dCN734ICIPan6ACNiJY6qWHe+B0TrbF6yC8hoZNWCd\n\titOUHxrkARIjdWu8WEB5I/wZeZfHU8j+aaOFx8z2sfUGxmmBQ64k6LHfiaMCjwRXu0he\n\tSiirBr48x/W2nk5k/DE6iU8lVA+PURfEca51ID4YSZ0OywXt/QqAGeEcgbWQIdqBOOQD\n\tVVU8uUBt/JJ9jthNL5CiVM7OQg9+DZc+neEdqHnaqHJDdODojzhSPwwSeQVEYPZy3DL3\n\tkDSUlsBgcAn/DKtiUaQQLOdQGOdqsEV0kccsktyqIZuBAAJRohm32KhhbLvAwIJeslIT\n\tRE1w==","X-Gm-Message-State":"AHPjjUilk0yZgRao/l5lzZNVVlbMs1HZ6zblP8UzLFpX/MCf1mA3Q/0h\n\taNg92g+KAgS4Mnp+MmW+Ro8=","X-Google-Smtp-Source":"AOwi7QC4txgQYSMLtWlMTjSgY/RWNRpR12Y+QWOkKOsLcj+JDUc+FNjYVJe9i8HOm0la9yDPvApsXg==","X-Received":"by 10.200.25.78 with SMTP id g14mr3358913qtk.48.1505844341260;\n\tTue, 19 Sep 2017 11:05:41 -0700 (PDT)","Subject":"Re: [PATCH v4 0/3] Add support for BCM7271 style interrupt\n\tcontroller","To":"Doug Berger , Thomas Gleixner ","Cc":"Jason Cooper , Marc Zyngier ,\n\tRob Herring , Mark Rutland ,\n\tKevin Cernekee ,\n\tBrian Norris ,\n\tGregory Fong ,\n\tbcm-kernel-feedback-list@broadcom.com,\n\tMarc Gonzalez ,\n\tMans Rullgard , Mason ,\n\tBartosz Golaszewski , Sebastian Frias , \n\tBoris Brezillon ,\n\tlinux-kernel@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-mips@linux-mips.org, linux-arm-kernel@lists.infradead.org","References":"<20170919010000.32072-1-opendmb@gmail.com>","From":"Florian Fainelli ","Message-ID":"","Date":"Tue, 19 Sep 2017 11:05:35 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170919010000.32072-1-opendmb@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]