[{"id":1770522,"web_url":"http://patchwork.ozlabs.org/comment/1770522/","msgid":"<24876029-5ebb-075e-3f02-50cf0856474f@gmail.com>","list_archive_url":null,"date":"2017-09-18T21:46:48","subject":"Re: [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/18/2017 02:41 PM, Florian Fainelli wrote:\n> Hi all,\n> \n> This patch series is a first pass set of clean-ups to reduce the number of LOCs\n> between b53 and bcm_sf2 and sharing as many functions as possible.\n> \n> There is a number of additional cleanups queued up locally that require more\n> thorough testing.\n\nDavid, I just spotted a missing EXPORT_SYMBOL() in patch 8 that was not\nflagged since I had temporarily disabled modular build, I will resubmit\nthis shortly after checking the other patches too. Thanks!\n\n> \n> Thanks!\n> \n> Florian Fainelli (12):\n> net: dsa: b53: Remove is_cpu_port()\n> net: dsa: b53: Make b53_enable_cpu_port() take a port argument\n> net: dsa: b53: Defer port enabling to calling port_enable\n> net: dsa: bcm_sf2: Defer port enabling to calling port_enable\n> net: dsa: b53: Use a macro to define I/O operations\n> net: dsa: b53: Move Broadcom header setup to b53\n> net: dsa: b53: Define EEE register page\n> net: dsa: b53: Move EEE functions to b53\n> net: dsa: b53: Wire-up EEE\n> net: dsa: b53: Export b53_imp_vlan_setup()\n> net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFP\n> net: dsa: bcm_sf2: Utilize b53_{enable,disable}_port\n> \n> drivers/net/dsa/b53/b53_common.c | 150 ++++++++++++++++++++++++++++++++----\n> drivers/net/dsa/b53/b53_priv.h | 145 ++++++++---------------------------\n> drivers/net/dsa/b53/b53_regs.h | 48 ++++++++++++\n> drivers/net/dsa/bcm_sf2.c | 161 +++------------------------------------\n> drivers/net/dsa/bcm_sf2.h | 2 -\n> drivers/net/dsa/bcm_sf2_cfp.c | 6 +-\n> drivers/net/dsa/bcm_sf2_regs.h | 11 ---\n> 7 files changed, 227 insertions(+), 296 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PzPIkuKs\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx02p1VbJz9s7G\n\tfor ;\n\tTue, 19 Sep 2017 07:46:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751302AbdIRVq4 (ORCPT );\n\tMon, 18 Sep 2017 17:46:56 -0400","from mail-wr0-f196.google.com ([209.85.128.196]:36086 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750990AbdIRVqz (ORCPT\n\t); Mon, 18 Sep 2017 17:46:55 -0400","by mail-wr0-f196.google.com with SMTP id g50so1141636wra.3\n\tfor ; Mon, 18 Sep 2017 14:46:54 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tb89sm9814360wrd.42.2017.09.18.14.46.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 14:46:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=0gkxx9XIOpPyYFnCPf3cUWvsturHxOrflzcirOgC99o=;\n\tb=PzPIkuKsRHmbdvgwSlrjBnngzgzcCWJJAfPq2qN6PQ9WBG0GRSZ+CLVpm1gcscVnbz\n\t/ExQqVasqQBprFtmeF0D44gDDEQLC9F4IxDFO1GYyqYwFBh8TaekLexEYPegS0xn4tMr\n\tZaKQkwTJFVJUGlXvieeVFU993uEdb2E/Ya3BUJ0OfOTY/N7siDVPj5s1x7Ho1wQ/F1rO\n\tBDtsXbsX+GX5/jUF4c1H8V1SbVG+AMQ5QeHcQdX31PG7DjnYHhwZCXF2hKL5FsVUxF5h\n\t3rX3ClKehgw6XwmPwKvfcVOEyqn30MjcGcbZfQ5/H0FA1WMLufmz34aXSamiRhtBnohf\n\tJJLQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=0gkxx9XIOpPyYFnCPf3cUWvsturHxOrflzcirOgC99o=;\n\tb=DCgMeCPUVmifalhN5M9KjwwHxj8aj3nY0w1ztquo6r4M2KeDiCHnY+MNrK9NYt3STH\n\tT5nlRex+Tbb3JfY+gDv1bO93/hWvbmiabWzFfwdvjZ3D5k8bgxzo+p/GcHe+1xHgnzx+\n\tzmA8hIVkfg5MM83nFq5jieH/lOX4n6gy9+VIqCot08kdxOiH/k1sc0aW19JZ2clYLTE6\n\tJmOH8YK4KxVBuH9i24PMt5uejkbhJwEGkn7nonAP/lGoOI/eBlvKlTJpZhpwMasx6feA\n\tPYkMS2zoa5/rh9AIMOQzb914jUQOFlkit1qaANmc7ln7zypgFyUx+eltz0QK9qPlP2uP\n\tsZyA==","X-Gm-Message-State":"AHPjjUhp8D5zdijS7tvFKGnX0J1b5PTZps9+lHqBELyPWZAzoWa/tslJ\n\t6wp9FCEix1wu/A==","X-Google-Smtp-Source":"ADKCNb45q13u3e3czSAcG6MLrRVUO7M+rzxxf/9FjFhWxONKyGp06+kgOOjUr22XlzEJemwZh9Kbxg==","X-Received":"by 10.223.134.236 with SMTP id 41mr27571715wry.81.1505771213818; \n\tMon, 18 Sep 2017 14:46:53 -0700 (PDT)","Subject":"Re: [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups","To":"netdev@vger.kernel.org, davem@davemloft.net","Cc":"andrew@lunn.ch, vivien.didelot@savoirfairelinux.com","References":"<20170918214128.27896-1-f.fainelli@gmail.com>","From":"Florian Fainelli ","Message-ID":"<24876029-5ebb-075e-3f02-50cf0856474f@gmail.com>","Date":"Mon, 18 Sep 2017 14:46:48 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170918214128.27896-1-f.fainelli@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770575,"web_url":"http://patchwork.ozlabs.org/comment/1770575/","msgid":"<20170918.162421.393653763418019686.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-18T23:24:21","subject":"Re: [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Florian Fainelli \nDate: Mon, 18 Sep 2017 14:46:48 -0700\n\n> On 09/18/2017 02:41 PM, Florian Fainelli wrote:\n>> Hi all,\n>> \n>> This patch series is a first pass set of clean-ups to reduce the number of LOCs\n>> between b53 and bcm_sf2 and sharing as many functions as possible.\n>> \n>> There is a number of additional cleanups queued up locally that require more\n>> thorough testing.\n> \n> David, I just spotted a missing EXPORT_SYMBOL() in patch 8 that was not\n> flagged since I had temporarily disabled modular build, I will resubmit\n> this shortly after checking the other patches too. Thanks!\n\nOk.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx2CJ3vgTz9s2G\n\tfor ;\n\tTue, 19 Sep 2017 09:24:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751302AbdIRXY0 (ORCPT );\n\tMon, 18 Sep 2017 19:24:26 -0400","from shards.monkeyblade.net ([184.105.139.130]:58216 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750982AbdIRXYZ (ORCPT\n\t); Mon, 18 Sep 2017 19:24:25 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id DB3891027B817;\n\tMon, 18 Sep 2017 16:24:24 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 16:24:21 -0700 (PDT)","Message-Id":"<20170918.162421.393653763418019686.davem@davemloft.net>","To":"f.fainelli@gmail.com","Cc":"netdev@vger.kernel.org, andrew@lunn.ch,\n\tvivien.didelot@savoirfairelinux.com","Subject":"Re: [PATCH net-next 00/12] net: dsa: b53/bcm_sf2 cleanups","From":"David Miller ","In-Reply-To":"<24876029-5ebb-075e-3f02-50cf0856474f@gmail.com>","References":"<20170918214128.27896-1-f.fainelli@gmail.com>\n\t<24876029-5ebb-075e-3f02-50cf0856474f@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 16:24:25 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]