[{"id":1771384,"web_url":"http://patchwork.ozlabs.org/comment/1771384/","msgid":"<20170919.135530.717500199880384307.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T20:55:30","subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Craig Gallek \nDate: Mon, 18 Sep 2017 15:30:54 -0400\n\n> This was previously left as a TODO. Add the implementation and\n> extend the test to cover it.\n\nSeries applied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxZs23Tnjz9ryv\n\tfor ;\n\tWed, 20 Sep 2017 06:55:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751679AbdISUzc (ORCPT );\n\tTue, 19 Sep 2017 16:55:32 -0400","from shards.monkeyblade.net ([184.105.139.130]:44788 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751544AbdISUzb (ORCPT\n\t); Tue, 19 Sep 2017 16:55:31 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id BFBE0102C8290;\n\tTue, 19 Sep 2017 13:55:30 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 13:55:30 -0700 (PDT)","Message-Id":"<20170919.135530.717500199880384307.davem@davemloft.net>","To":"kraigatgoog@gmail.com","Cc":"daniel@zonque.org, ast@fb.com, daniel@iogearbox.net,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","From":"David Miller ","In-Reply-To":"<20170918193057.37644-1-kraigatgoog@gmail.com>","References":"<20170918193057.37644-1-kraigatgoog@gmail.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 13:55:31 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771401,"web_url":"http://patchwork.ozlabs.org/comment/1771401/","msgid":"<94373907-6cf5-22af-54e6-7625f31447e0@zonque.org>","list_archive_url":null,"date":"2017-09-19T21:13:27","subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","submitter":{"id":64053,"url":"http://patchwork.ozlabs.org/api/people/64053/","name":"Daniel Mack","email":"daniel@zonque.org"},"content":"On 09/19/2017 10:55 PM, David Miller wrote:\n> From: Craig Gallek \n> Date: Mon, 18 Sep 2017 15:30:54 -0400\n> \n>> This was previously left as a TODO. Add the implementation and\n>> extend the test to cover it.\n> \n> Series applied, thanks.\n> \n\nHmm, I think these patches need some more discussion regarding the IM\nnodes handling, see the reply I sent an hour ago. Could you wait for\nthat before pushing your tree?\n\n\nThanks,\nDaniel","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxbFm5v9Rz9s4s\n\tfor ;\n\tWed, 20 Sep 2017 07:13:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751480AbdISVN3 (ORCPT );\n\tTue, 19 Sep 2017 17:13:29 -0400","from mail.bugwerft.de ([46.23.86.59]:51546 \"EHLO mail.bugwerft.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751341AbdISVN3 (ORCPT );\n\tTue, 19 Sep 2017 17:13:29 -0400","from [192.168.178.170] (pD95EF90D.dip0.t-ipconnect.de\n\t[217.94.249.13])\n\tby mail.bugwerft.de (Postfix) with ESMTPSA id E9F5828001A;\n\tTue, 19 Sep 2017 21:10:59 +0000 (UTC)"],"Subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","To":"David Miller , kraigatgoog@gmail.com","Cc":"ast@fb.com, daniel@iogearbox.net, netdev@vger.kernel.org","References":"<20170918193057.37644-1-kraigatgoog@gmail.com>\n\t<20170919.135530.717500199880384307.davem@davemloft.net>","From":"Daniel Mack ","Message-ID":"<94373907-6cf5-22af-54e6-7625f31447e0@zonque.org>","Date":"Tue, 19 Sep 2017 23:13:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919.135530.717500199880384307.davem@davemloft.net>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771402,"web_url":"http://patchwork.ozlabs.org/comment/1771402/","msgid":"","list_archive_url":null,"date":"2017-09-19T21:16:13","subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","submitter":{"id":67365,"url":"http://patchwork.ozlabs.org/api/people/67365/","name":"Craig Gallek","email":"kraigatgoog@gmail.com"},"content":"On Tue, Sep 19, 2017 at 5:13 PM, Daniel Mack wrote:\n> On 09/19/2017 10:55 PM, David Miller wrote:\n>> From: Craig Gallek \n>> Date: Mon, 18 Sep 2017 15:30:54 -0400\n>>\n>>> This was previously left as a TODO. Add the implementation and\n>>> extend the test to cover it.\n>>\n>> Series applied, thanks.\n>>\n>\n> Hmm, I think these patches need some more discussion regarding the IM\n> nodes handling, see the reply I sent an hour ago. Could you wait for\n> that before pushing your tree?\n\nI can follow up with a patch to implement your suggestion. It's\nreally just an efficiency improvement, though, so I think it's ok to\nhandle independently. (Sorry, I haven't had a chance to play with the\nimplementation details yet).\n\nCraig","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"pE+RAJkO\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxbJz4RxCz9s7B\n\tfor ;\n\tWed, 20 Sep 2017 07:16:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751396AbdISVQR (ORCPT );\n\tTue, 19 Sep 2017 17:16:17 -0400","from mail-qk0-f181.google.com ([209.85.220.181]:51277 \"EHLO\n\tmail-qk0-f181.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751341AbdISVQQ (ORCPT\n\t); Tue, 19 Sep 2017 17:16:16 -0400","by mail-qk0-f181.google.com with SMTP id c69so944029qke.8\n\tfor ; Tue, 19 Sep 2017 14:16:15 -0700 (PDT)","from mail-qt0-f180.google.com (mail-qt0-f180.google.com.\n\t[209.85.216.180]) by smtp.gmail.com with ESMTPSA id\n\tr11sm190526qkh.80.2017.09.19.14.16.14 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 14:16:14 -0700 (PDT)","by mail-qt0-f180.google.com with SMTP id l25so980340qtf.13\n\tfor ; Tue, 19 Sep 2017 14:16:14 -0700 (PDT)","by 10.12.142.78 with HTTP; Tue, 19 Sep 2017 14:16:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=XKc2Yo+wD6pjgwxlIII81BYbkt+qRPm6Eta0GHOzK24=;\n\tb=pE+RAJkOnpeqk3B/nve7rYvsKg4MmvDOIpXCROvPrtB4AbKPiG5qrkwZ1TW5vmiQHX\n\toAtg14p2oXZAof4z5RNhJNs/Z6uDSI1zu8l5vmrsSgf9Sf9L4BM0G4AYEWzmIRCDv+Yv\n\tq6T5DTOc+65RQsLSKwCT25aSr+saxZwAn3hfpY7+9CcmK+cKTVaK/mAnFWwHJxYkWnmh\n\tKMssbub7HmDIAh58oH+4a9VcMB19V4+HzBwU2fOsAr8UULTgTHGwwdtRWxnPoiLg/Rc0\n\tzoECmX0lg36md4hgluV0JBMUkpq/rARyycNdD8sPaZNNdqloGRxil94totLAMIR5aXLA\n\tkwjQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=XKc2Yo+wD6pjgwxlIII81BYbkt+qRPm6Eta0GHOzK24=;\n\tb=YJBAKhv70CnyubBTMjBs+efUQKitgH15eRf/1C+Vh2bi82n0jBaFpZTRlT3o09lKOl\n\tZ/h7BhSJ1odJtktsMwW3/LUjZxYOI1K3nIr1+Jvm3wKxE+wIiql24m3WxkiPSp8F7G8F\n\tHebqwS3lsY/iPBefZDAzlNk8M4+4vRHmvBxGREV8e6zxe9Ga4vSaYgbvid0JS/Yhlnno\n\tkY3ap201XPMulT/a8KS6/mbs/IrTbOXRVYA9/YUnocfWskkRriNN5baJhjS3G2h0kOwW\n\th96XIf5sh6A1nYg4P0oObEQnZ7Ua0nFgldhk5g24mZQ1jgm2FluNOQ5h8Ci2wQlP8SSQ\n\tvKkg==","X-Gm-Message-State":"AHPjjUgas0VJlA5p7+0Y78/fs3Y6uH9KsgA5MwX3j9Nq0/4pvYVuXKlj\n\txnxWuhY6/6UEDjvivGnh9HGr4wXz","X-Received":["by 10.55.122.194 with SMTP id v185mr4053038qkc.21.1505855775205; \n\tTue, 19 Sep 2017 14:16:15 -0700 (PDT)","by 10.200.63.154 with SMTP id d26mr4359208qtk.212.1505855774554; \n\tTue, 19 Sep 2017 14:16:14 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QCCyk4r7IuBaq6UsC0KeQlsj/i8F1itS1IUc/oKVj+rMJ8ovSK+6i79jNLXn+CL+Xo+ontrk4lnKWzvsuZZnO8=","MIME-Version":"1.0","In-Reply-To":"<94373907-6cf5-22af-54e6-7625f31447e0@zonque.org>","References":"<20170918193057.37644-1-kraigatgoog@gmail.com>\n\t<20170919.135530.717500199880384307.davem@davemloft.net>\n\t<94373907-6cf5-22af-54e6-7625f31447e0@zonque.org>","From":"Craig Gallek ","Date":"Tue, 19 Sep 2017 17:16:13 -0400","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","To":"Daniel Mack ","Cc":"David Miller , Alexei Starovoitov ,\n\tDaniel Borkmann , netdev ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771412,"web_url":"http://patchwork.ozlabs.org/comment/1771412/","msgid":"<20170919.142935.72220924483937276.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T21:29:35","subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Craig Gallek \nDate: Tue, 19 Sep 2017 17:16:13 -0400\n\n> On Tue, Sep 19, 2017 at 5:13 PM, Daniel Mack wrote:\n>> On 09/19/2017 10:55 PM, David Miller wrote:\n>>> From: Craig Gallek \n>>> Date: Mon, 18 Sep 2017 15:30:54 -0400\n>>>\n>>>> This was previously left as a TODO. Add the implementation and\n>>>> extend the test to cover it.\n>>>\n>>> Series applied, thanks.\n>>>\n>>\n>> Hmm, I think these patches need some more discussion regarding the IM\n>> nodes handling, see the reply I sent an hour ago. Could you wait for\n>> that before pushing your tree?\n> \n> I can follow up with a patch to implement your suggestion. It's\n> really just an efficiency improvement, though, so I think it's ok to\n> handle independently. (Sorry, I haven't had a chance to play with the\n> implementation details yet).\n\nSorry, I thought the core implementation had been agreed upon and the\nseries was OK. All that was asked for were simplifications and/or\noptimization which could be done via follow-up patches.\n\nIt's already pushed out to my tree, so I would need to do a real\nrevert.\n\nI hope that won't be necessary.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxbcN31cGz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 07:29:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751431AbdISV3h (ORCPT );\n\tTue, 19 Sep 2017 17:29:37 -0400","from shards.monkeyblade.net ([184.105.139.130]:46112 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751309AbdISV3h (ORCPT\n\t); Tue, 19 Sep 2017 17:29:37 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 52367102C9720;\n\tTue, 19 Sep 2017 14:29:36 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 14:29:35 -0700 (PDT)","Message-Id":"<20170919.142935.72220924483937276.davem@davemloft.net>","To":"kraigatgoog@gmail.com","Cc":"daniel@zonque.org, ast@fb.com, daniel@iogearbox.net,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","From":"David Miller ","In-Reply-To":"","References":"<20170919.135530.717500199880384307.davem@davemloft.net>\n\t<94373907-6cf5-22af-54e6-7625f31447e0@zonque.org>\n\t","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 14:29:36 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771415,"web_url":"http://patchwork.ozlabs.org/comment/1771415/","msgid":"<2c5c42f5-4625-da6d-1d04-904ae6f8fb20@zonque.org>","list_archive_url":null,"date":"2017-09-19T21:31:33","subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","submitter":{"id":64053,"url":"http://patchwork.ozlabs.org/api/people/64053/","name":"Daniel Mack","email":"daniel@zonque.org"},"content":"On 09/19/2017 11:29 PM, David Miller wrote:\n> From: Craig Gallek \n> Date: Tue, 19 Sep 2017 17:16:13 -0400\n> \n>> On Tue, Sep 19, 2017 at 5:13 PM, Daniel Mack wrote:\n>>> On 09/19/2017 10:55 PM, David Miller wrote:\n>>>> From: Craig Gallek \n>>>> Date: Mon, 18 Sep 2017 15:30:54 -0400\n>>>>\n>>>>> This was previously left as a TODO. Add the implementation and\n>>>>> extend the test to cover it.\n>>>>\n>>>> Series applied, thanks.\n>>>>\n>>>\n>>> Hmm, I think these patches need some more discussion regarding the IM\n>>> nodes handling, see the reply I sent an hour ago. Could you wait for\n>>> that before pushing your tree?\n>>\n>> I can follow up with a patch to implement your suggestion. It's\n>> really just an efficiency improvement, though, so I think it's ok to\n>> handle independently. (Sorry, I haven't had a chance to play with the\n>> implementation details yet).\n> \n> Sorry, I thought the core implementation had been agreed upon and the\n> series was OK. All that was asked for were simplifications and/or\n> optimization which could be done via follow-up patches.\n> \n> It's already pushed out to my tree, so I would need to do a real\n> revert.\n> \n> I hope that won't be necessary.\n> \n\nNah, it's okay I guess. I trust Craig to send follow-up patches. After\nall, efficiency is what this whole exercise is all about, so I think it\nshould be done correctly :)\n\n\n\nThanks,\nDaniel","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxbff0dP4z9rvt\n\tfor ;\n\tWed, 20 Sep 2017 07:31:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751480AbdISVbg (ORCPT );\n\tTue, 19 Sep 2017 17:31:36 -0400","from mail.bugwerft.de ([46.23.86.59]:51618 \"EHLO mail.bugwerft.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751309AbdISVbf (ORCPT );\n\tTue, 19 Sep 2017 17:31:35 -0400","from [192.168.178.170] (pD95EF90D.dip0.t-ipconnect.de\n\t[217.94.249.13])\n\tby mail.bugwerft.de (Postfix) with ESMTPSA id 6456F28001A;\n\tTue, 19 Sep 2017 21:29:06 +0000 (UTC)"],"Subject":"Re: [PATCH net-next 0/3] Implement delete for BPF LPM trie","To":"David Miller , kraigatgoog@gmail.com","Cc":"ast@fb.com, daniel@iogearbox.net, netdev@vger.kernel.org","References":"<20170919.135530.717500199880384307.davem@davemloft.net>\n\t<94373907-6cf5-22af-54e6-7625f31447e0@zonque.org>\n\t\n\t<20170919.142935.72220924483937276.davem@davemloft.net>","From":"Daniel Mack ","Message-ID":"<2c5c42f5-4625-da6d-1d04-904ae6f8fb20@zonque.org>","Date":"Tue, 19 Sep 2017 23:31:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919.142935.72220924483937276.davem@davemloft.net>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]