[{"id":1771445,"web_url":"http://patchwork.ozlabs.org/comment/1771445/","msgid":"<20170919.160244.1149642515939268316.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T23:02:44","subject":"Re: [PATCH net-next 0/7] net: speedup netns create/delete time","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Dumazet \nDate: Mon, 18 Sep 2017 12:07:26 -0700\n\n> When rate of netns creation/deletion is high enough,\n> we observe softlockups in cleanup_net() caused by huge list\n> of netns and way too many rcu_barrier() calls.\n> \n> This patch series does some optimizations in kobject,\n> and add batching to tunnels so that netns dismantles are\n> less costly.\n> \n> IPv6 addrlabels also get a per netns list, and tcp_metrics\n> also benefit from batch flushing.\n> \n> This gives me one order of magnitude gain.\n> (~50 ms -> ~5 ms for one netns create/delete pair)\n\nI like it.\n\nPlease address the feedback about using skb_put_data() and\nresubmit.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxdgq6mF0z9sNw\n\tfor ;\n\tWed, 20 Sep 2017 09:02:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751732AbdISXCp (ORCPT );\n\tTue, 19 Sep 2017 19:02:45 -0400","from shards.monkeyblade.net ([184.105.139.130]:49936 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751575AbdISXCo (ORCPT\n\t); Tue, 19 Sep 2017 19:02:44 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 58E90102CC9DA;\n\tTue, 19 Sep 2017 16:02:44 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 16:02:44 -0700 (PDT)","Message-Id":"<20170919.160244.1149642515939268316.davem@davemloft.net>","To":"edumazet@google.com","Cc":"netdev@vger.kernel.org, ebiederm@xmission.com, eric.dumazet@gmail.com","Subject":"Re: [PATCH net-next 0/7] net: speedup netns create/delete time","From":"David Miller ","In-Reply-To":"<20170918190733.26272-1-edumazet@google.com>","References":"<20170918190733.26272-1-edumazet@google.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 16:02:44 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771456,"web_url":"http://patchwork.ozlabs.org/comment/1771456/","msgid":"<1505863213.29839.79.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-19T23:20:13","subject":"Re: [PATCH net-next 0/7] net: speedup netns create/delete time","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Tue, 2017-09-19 at 16:02 -0700, David Miller wrote:\n> From: Eric Dumazet \n> Date: Mon, 18 Sep 2017 12:07:26 -0700\n> \n> > When rate of netns creation/deletion is high enough,\n> > we observe softlockups in cleanup_net() caused by huge list\n> > of netns and way too many rcu_barrier() calls.\n> > \n> > This patch series does some optimizations in kobject,\n> > and add batching to tunnels so that netns dismantles are\n> > less costly.\n> > \n> > IPv6 addrlabels also get a per netns list, and tcp_metrics\n> > also benefit from batch flushing.\n> > \n> > This gives me one order of magnitude gain.\n> > (~50 ms -> ~5 ms for one netns create/delete pair)\n> \n> I like it.\n> \n> Please address the feedback about using skb_put_data() and\n> resubmit.\n\nSure, will also remove a spurious // comment I accidentally left in\npatch 7/7.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vDmRSaci\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxf422NkXz9s9Y\n\tfor ;\n\tWed, 20 Sep 2017 09:20:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751832AbdISXUQ (ORCPT );\n\tTue, 19 Sep 2017 19:20:16 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:38093 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751619AbdISXUP (ORCPT\n\t); Tue, 19 Sep 2017 19:20:15 -0400","by mail-pg0-f66.google.com with SMTP id m30so609933pgn.5\n\tfor ; Tue, 19 Sep 2017 16:20:15 -0700 (PDT)","from ?IPv6:2620:15c:2c1:100:b4a0:c01:eb5b:1cfe?\n\t([2620:15c:2c1:100:b4a0:c01:eb5b:1cfe])\n\tby smtp.googlemail.com with ESMTPSA id\n\tg66sm5258796pfj.161.2017.09.19.16.20.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 16:20:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=DKAxHVxPYd//txw+MPfeX0+q5dfOwqWNA7ijMMqgBNo=;\n\tb=vDmRSaciygJDmXlGWWtuxPa++p/WUSp200ZDVcJp7DhA2CHl+YwxYsTp3KH/yHPfTo\n\ta+sl/yVVvgV/7uBqL2knFOBZHKFIb/oPUiTVtpNgRIZ+sk3KODTtKrY4IGmZVZyrNCYg\n\taP8GbfYCRSjcbxBs0QpukuOh9Q8I6cnhbsnQwdzVRmGR/xVzWaavm64UtWGsEOAyGXXk\n\tOYNloThab7Q+etAnjdx4ArWFpc09PqLOcXsOWhkMQE6aHR0lh8ZJ5/upJc36geYYBCbB\n\tclneTaSa97kT3HHGguG9rJtNn3WwWBiUxT8AqHrbgLCgd3yLJyVKlox8xczZ8VOSMN7T\n\tRzwg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=DKAxHVxPYd//txw+MPfeX0+q5dfOwqWNA7ijMMqgBNo=;\n\tb=AZ9yBR27A1ytMtgziyDRi8/+q60IVmzDAmRj5A2uZyFUn7wcOXXIv8ShwKVrKehkkf\n\tzGNqWXUJg+e9dNb8jY7+NX8QQcldlGmKFQjAOgEW7nkPlP/qRRlrYycR7qm9LvQvICSh\n\t1Hk/2C0CfKhU2bYjL1ujmL+Apn5SmlyF0g5ie1ezmjh/4QRuth+2uAk1cb4C2/wdGNRU\n\tu1IZLUrGfuaP1AhXGtTMiYqlt5j/6rs75uWa9qArAgBnf4RF5KR6O8K0vpAinLQ/yjqt\n\tqrjafqcBuMIEz1RxS2/C3hJmOaF9XIaSlvE8vPOpPVZY4TzwfIMD6TWBZvah/Au9oDR4\n\t5dgw==","X-Gm-Message-State":"AHPjjUjRrYB3b6RyYX6o9dY/pxr3JXPI/aDQBEyr4W31hgXLzrpDgGz9\n\ta716n1LCjegssMI56nc4Lkc=","X-Google-Smtp-Source":"AOwi7QDpa0xbbKaD9m23kE7DQO4lu3OIGd/117n0XsLQtLuHG+VSCqo17NYrKkDRnHTgYGiQ3pV+Yw==","X-Received":"by 10.98.200.153 with SMTP id i25mr231190pfk.248.1505863214863; \n\tTue, 19 Sep 2017 16:20:14 -0700 (PDT)","Message-ID":"<1505863213.29839.79.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH net-next 0/7] net: speedup netns create/delete time","From":"Eric Dumazet ","To":"David Miller ","Cc":"edumazet@google.com, netdev@vger.kernel.org, ebiederm@xmission.com","Date":"Tue, 19 Sep 2017 16:20:13 -0700","In-Reply-To":"<20170919.160244.1149642515939268316.davem@davemloft.net>","References":"<20170918190733.26272-1-edumazet@google.com>\n\t<20170919.160244.1149642515939268316.davem@davemloft.net>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]