[{"id":1771005,"web_url":"http://patchwork.ozlabs.org/comment/1771005/","msgid":"<20170919124608.GE3789@localhost.localdomain>","list_archive_url":null,"date":"2017-09-19T12:46:08","subject":"Re: [Qemu-devel] [PATCH v8 00/20] make dirty-bitmap byte-based","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 18.09.2017 um 20:57 hat Eric Blake geschrieben:\n> There are patches floating around to add NBD_CMD_BLOCK_STATUS,\n> but NBD wants to report status on byte granularity (even if the\n> reporting will probably be naturally aligned to sectors or even\n> much higher levels). I've therefore started the task of\n> converting our block status code to report at a byte granularity\n> rather than sectors.\n> \n> Now that 2.11 is open, I'm rebasing/reposting the remaining patches.\n> \n> The overall conversion currently looks like:\n> part 1: bdrv_is_allocated (merged in 2.10, commit 51b0a488)\n> part 2: dirty-bitmap (this series, v7 was here [1])\n> part 3: bdrv_get_block_status (v4 is posted [2] and is mostly reviewed)\n> part 4: .bdrv_co_block_status (v3 is posted [3], but needs review)\n\nI agree with Fam's comment on patch 5 and had a question on patch 18.\n\nEverything else is\nReviewed-by: Kevin Wolf ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxNxR328Fz9sBZ\n\tfor ;\n\tTue, 19 Sep 2017 23:28:43 +1000 (AEST)","from localhost ([::1]:42875 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duIZt-0002Ac-DA\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 09:28:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42590)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duHut-0000xK-Ar\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:46:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duHus-00087f-JB\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 08:46:19 -0400","from mx1.redhat.com ([209.132.183.28]:45222)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duHuo-00084H-1k; Tue, 19 Sep 2017 08:46:14 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1079F81138;\n\tTue, 19 Sep 2017 12:46:13 +0000 (UTC)","from localhost.localdomain (ovpn-116-117.ams2.redhat.com\n\t[10.36.116.117])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 85B23610B0;\n\tTue, 19 Sep 2017 12:46:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1079F81138","Date":"Tue, 19 Sep 2017 14:46:08 +0200","From":"Kevin Wolf ","To":"Eric Blake ","Message-ID":"<20170919124608.GE3789@localhost.localdomain>","References":"<20170918185819.5984-1-eblake@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918185819.5984-1-eblake@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 19 Sep 2017 12:46:13 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 00/20] make dirty-bitmap byte-based","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"vsementsov@virtuozzo.com, jsnow@redhat.com, qemu-devel@nongnu.org,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771101,"web_url":"http://patchwork.ozlabs.org/comment/1771101/","msgid":"<20170919144229.GA18491@lemon>","list_archive_url":null,"date":"2017-09-19T14:42:29","subject":"Re: [Qemu-devel] [PATCH v8 00/20] make dirty-bitmap byte-based","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Mon, 09/18 13:57, Eric Blake wrote:\n> There are patches floating around to add NBD_CMD_BLOCK_STATUS,\n> but NBD wants to report status on byte granularity (even if the\n> reporting will probably be naturally aligned to sectors or even\n> much higher levels). I've therefore started the task of\n> converting our block status code to report at a byte granularity\n> rather than sectors.\n> \n> Now that 2.11 is open, I'm rebasing/reposting the remaining patches.\n> \n> The overall conversion currently looks like:\n> part 1: bdrv_is_allocated (merged in 2.10, commit 51b0a488)\n> part 2: dirty-bitmap (this series, v7 was here [1])\n> part 3: bdrv_get_block_status (v4 is posted [2] and is mostly reviewed)\n> part 4: .bdrv_co_block_status (v3 is posted [3], but needs review)\n\nPatches 1-4, 6-20:\n\nReviewed-by: Fam Zheng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxQf64RjNz9s82\n\tfor ;\n\tWed, 20 Sep 2017 00:45:34 +1000 (AEST)","from localhost ([::1]:43316 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duJmG-00026j-PP\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 10:45:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34595)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duJje-0000QG-FB\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:42:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duJja-0006It-OM\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:42:50 -0400","from mx1.redhat.com ([209.132.183.28]:40162)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duJjS-00068h-8T; Tue, 19 Sep 2017 10:42:38 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 49A8925BAC;\n\tTue, 19 Sep 2017 14:42:37 +0000 (UTC)","from localhost (ovpn-12-46.pek2.redhat.com [10.72.12.46])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1129560F89;\n\tTue, 19 Sep 2017 14:42:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 49A8925BAC","Date":"Tue, 19 Sep 2017 22:42:29 +0800","From":"Fam Zheng ","To":"Eric Blake ","Message-ID":"<20170919144229.GA18491@lemon>","References":"<20170918185819.5984-1-eblake@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918185819.5984-1-eblake@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 19 Sep 2017 14:42:37 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 00/20] make dirty-bitmap byte-based","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com,\n\tqemu-devel@nongnu.org, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]