[{"id":1770364,"web_url":"http://patchwork.ozlabs.org/comment/1770364/","msgid":"<5df48cbb-2726-3e99-84e7-eb6c6fc0dbb2@redhat.com>","list_archive_url":null,"date":"2017-09-18T17:44:32","subject":"Re: [PATCH 0/3] fix reuseaddr regression","submitter":{"id":3411,"url":"http://patchwork.ozlabs.org/api/people/3411/","name":"Cole Robinson","email":"crobinso@redhat.com"},"content":"On 09/18/2017 12:28 PM, josef@toxicpanda.com wrote:\n> I introduced a regression when reworking the fastreuse port stuff that allows\n> bind conflicts to occur once a reuseaddr socket successfully opens on an\n> existing tb.  The root cause is I reversed an if statement which caused us to\n> set the tb as if there were no owners on the socket if there were, which\n> obviously is not correct.\n> \n> Dave I have follow up patches that will add a selftest for this case and I ran\n> the other reuseport related tests as well.  These need to go in pretty quickly\n> as it breaks kvm, I've marked them for stable.  Sorry for the regression,\n> \n\nTo clarify, it doesn't really break KVM specifically, but it breaks a\nport collision detection idiom that libvirt depends on to successfully\nlaunch qemu/xen/... VMs in certain cases.\n\nThanks,\nCole","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=crobinso@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwtgZ3YC3z9s7c\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 19 Sep 2017 03:44:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756231AbdIRRof (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 18 Sep 2017 13:44:35 -0400","from mx1.redhat.com ([209.132.183.28]:43650 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1755355AbdIRRod (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 18 Sep 2017 13:44:33 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8E80F81DF5;\n\tMon, 18 Sep 2017 17:44:33 +0000 (UTC)","from [10.3.116.180] (ovpn-116-180.phx2.redhat.com [10.3.116.180])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DC68F60466;\n\tMon, 18 Sep 2017 17:44:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8E80F81DF5","Subject":"Re: [PATCH 0/3] fix reuseaddr regression","To":"josef@toxicpanda.com, davem@davemloft.net, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, labbott@redhat.com, kernel-team@fb.com","References":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","From":"Cole Robinson <crobinso@redhat.com>","Message-ID":"<5df48cbb-2726-3e99-84e7-eb6c6fc0dbb2@redhat.com>","Date":"Mon, 18 Sep 2017 13:44:32 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","Content-Type":"text/plain; charset=us-ascii","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 18 Sep 2017 17:44:33 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771378,"web_url":"http://patchwork.ozlabs.org/comment/1771378/","msgid":"<20170919.135056.44228457394918392.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T20:50:56","subject":"Re: [PATCH 0/3] fix reuseaddr regression","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: josef@toxicpanda.com\nDate: Mon, 18 Sep 2017 12:28:54 -0400\n\n> I introduced a regression when reworking the fastreuse port stuff that allows\n> bind conflicts to occur once a reuseaddr socket successfully opens on an\n> existing tb.  The root cause is I reversed an if statement which caused us to\n> set the tb as if there were no owners on the socket if there were, which\n> obviously is not correct.\n> \n> Dave I have follow up patches that will add a selftest for this case and I ran\n> the other reuseport related tests as well.  These need to go in pretty quickly\n> as it breaks kvm, I've marked them for stable.  Sorry for the regression,\n\nFirst, please fix your \"From: \" field so that it actually has your full\nname rather than just your email address.  This matter when I apply\nyour patches.\n\nSecond, remove the stable CC:.  For networking changes, you simply ask\nme to queue the changes up for -stable.\n\nThanks.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxZlm2fY3z9sBW\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 20 Sep 2017 06:51:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751997AbdISUu6 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 19 Sep 2017 16:50:58 -0400","from shards.monkeyblade.net ([184.105.139.130]:44600 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751547AbdISUu5 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 19 Sep 2017 16:50:57 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9B222102C827C;\n\tTue, 19 Sep 2017 13:50:56 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 13:50:56 -0700 (PDT)","Message-Id":"<20170919.135056.44228457394918392.davem@davemloft.net>","To":"josef@toxicpanda.com","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tcrobinso@redhat.com, labbott@redhat.com, kernel-team@fb.com","Subject":"Re: [PATCH 0/3] fix reuseaddr regression","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","References":"<1505752137-15522-1-git-send-email-jbacik@fb.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 13:50:56 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1773944,"web_url":"http://patchwork.ozlabs.org/comment/1773944/","msgid":"<20170923002844.slrxaq46zikl3zdn@destiny>","list_archive_url":null,"date":"2017-09-23T00:28:45","subject":"Re: [PATCH 0/3] fix reuseaddr regression","submitter":{"id":72383,"url":"http://patchwork.ozlabs.org/api/people/72383/","name":"Josef Bacik","email":"josef@toxicpanda.com"},"content":"On Tue, Sep 19, 2017 at 01:50:56PM -0700, David Miller wrote:\n> From: josef@toxicpanda.com\n> Date: Mon, 18 Sep 2017 12:28:54 -0400\n> \n> > I introduced a regression when reworking the fastreuse port stuff that allows\n> > bind conflicts to occur once a reuseaddr socket successfully opens on an\n> > existing tb.  The root cause is I reversed an if statement which caused us to\n> > set the tb as if there were no owners on the socket if there were, which\n> > obviously is not correct.\n> > \n> > Dave I have follow up patches that will add a selftest for this case and I ran\n> > the other reuseport related tests as well.  These need to go in pretty quickly\n> > as it breaks kvm, I've marked them for stable.  Sorry for the regression,\n> \n> First, please fix your \"From: \" field so that it actually has your full\n> name rather than just your email address.  This matter when I apply\n> your patches.\n> \n> Second, remove the stable CC:.  For networking changes, you simply ask\n> me to queue the changes up for -stable.\n> \n\nSorry Dave, I've fixed my git email settings and I droped the stable cc and sent\na new round.  Didn't see this until just now, my bad.\n\nJosef","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=toxicpanda-com.20150623.gappssmtp.com\n\theader.i=@toxicpanda-com.20150623.gappssmtp.com\n\theader.b=\"YKALs00M\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzWRw2Tnxz9sNw\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 23 Sep 2017 10:29:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752159AbdIWA2t (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 22 Sep 2017 20:28:49 -0400","from mail-qk0-f179.google.com ([209.85.220.179]:53984 \"EHLO\n\tmail-qk0-f179.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751845AbdIWA2r (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 22 Sep 2017 20:28:47 -0400","by mail-qk0-f179.google.com with SMTP id t184so2511645qke.10\n\tfor <netdev@vger.kernel.org>; Fri, 22 Sep 2017 17:28:47 -0700 (PDT)","from localhost ([2606:a000:4381:1201:225:22ff:feb3:e51a])\n\tby smtp.gmail.com with ESMTPSA id\n\tt90sm845435qkl.77.2017.09.22.17.28.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 17:28:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=toxicpanda-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=3SzA6kW145kxxnt06XYt7IS0V5Whxm3PgPegX6wad5I=;\n\tb=YKALs00MhUNK80EM8Thm3shzW170XKI3a9s5PjpzanTa8s47vOpVSRiML7F5SGA0Oy\n\t/sllyIpYG9nuMHUXbrIQGdJhrQQm62vVeKYdPyB9fOL7D83UXdGNxyRwgIh+XqgSE9eZ\n\ttBXKtWW7bqr77AjlF/npebDWvoBqbFq2SmHcH1wVkPJ/tvkYp/bNk4OJVKMwx6N9YUgF\n\tlNYP2xuE851VCJygRnfjlqhLw2SxtK4s7Nftn2/0xCxppXe2AiUvFKubGMvXvpAMOkRR\n\tYE5SW7u8CQ9xq+9HK6InaxCZjULlWl78SYpfTMb2f+EmW11+Q5E/RbHl6528x7zXsduR\n\t5vOA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=3SzA6kW145kxxnt06XYt7IS0V5Whxm3PgPegX6wad5I=;\n\tb=nH8A6MM0Nc81l+9EFg/EQx3IJt0ypur3evniN8YRMXol2j5bxmF49WV+AfX5bK3+lh\n\tnpMg5Ko2ct2L3znLhhb7PV8j4W4XsVr8sLGFOB9TPLB+DK8jEb+VvQfzKyujtMcLPajm\n\tcwbW/brIUSEmnn1TZS7a8FQnhKroWvRaISUs5FAC9XFPG2X8ONs3Cg2Zls5CR9RPtn89\n\t5MGN7p8rmZjuT2Jcz3YUVxaML3t9qxvzLdG46RFNZpw3cAq5tTLe3DAF74XAImimyzmk\n\tUK8vWBk5BgE1Jjh5mb6POiXonzJ7/3hrMEr2t/6w2iTtQ6mR9RjzeUfoFWnGD3IAMtm1\n\tAmHg==","X-Gm-Message-State":"AHPjjUhxj8lrqKTBsqksJc7SZyF8WJ2l1tWsIdCnuP0jLZ8zI5Ii4ZQD\n\tKU2CsZYppz6K1dxETH0Yq0a6OA==","X-Google-Smtp-Source":"AOwi7QALPDOvoJ1oMoW8Dzy7lssqNxPmxLJQLIj9XHSfL/j3AP7sEZBqCyEG2ibFCHZvgtR4izw27Q==","X-Received":"by 10.55.91.199 with SMTP id p190mr1227575qkb.106.1506126526726; \n\tFri, 22 Sep 2017 17:28:46 -0700 (PDT)","Date":"Fri, 22 Sep 2017 20:28:45 -0400","From":"Josef Bacik <josef@toxicpanda.com>","To":"David Miller <davem@davemloft.net>","Cc":"josef@toxicpanda.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, crobinso@redhat.com,\n\tlabbott@redhat.com, kernel-team@fb.com","Subject":"Re: [PATCH 0/3] fix reuseaddr regression","Message-ID":"<20170923002844.slrxaq46zikl3zdn@destiny>","References":"<1505752137-15522-1-git-send-email-jbacik@fb.com>\n\t<20170919.135056.44228457394918392.davem@davemloft.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919.135056.44228457394918392.davem@davemloft.net>","User-Agent":"NeoMutt/20170714 (1.8.3)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]