[{"id":1770361,"web_url":"http://patchwork.ozlabs.org/comment/1770361/","msgid":"<5c6f8432-84ec-e06a-22fe-9ddc24998adf@de.ibm.com>","list_archive_url":null,"date":"2017-09-18T17:31:53","subject":"Re: [Qemu-devel] [PATCH v1 00/27] s390x: SMP for TCG (+ cleanups)","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"David,\n\ncan you outline how much you tested KVM after these changes? I assume we should\nreview/test the whole series properly?\n\nOn 09/18/2017 05:59 PM, David Hildenbrand wrote:\n> This series contains:\n> - properly implement local external interrupts for TCG\n> - factor out KVM SIGP handling code into common code\n> - implement missing SIGP orders for TCG handled by the kernel for KVM\n> (including STOP and RESTART interrupts)\n> - make TCG use the new SIGP code - experimental SMP support for s390x TCG\n> - refactor STFL(E) implementation for TCG\n> - bunch of cleanups\n> \n> Basically all SIGP instructions are fully supported.\n> \n> Thanks to Aurelien Jarno for the initital prototype and showcasing that\n> supporting experimental SMP code can be implemented quite easily.\n> \n> TCG SMP on s390x - what works?\n> - \"-smp X,maxcpus=X\" with both, single and multi threaded TCG\n> - \"-smp ... -device qemu-s390-cpu,id=cpuX,core-id=X\"\n> - system_powerdown, system_reset, shutdown, reboot, NMI\n> - online/offline of CPUs from inside the guest\n> \n> TCG SMP on s390x - what does not work?\n> - Floating interrupts all target CPU 0. Don't offline it.\n> - CPU hotplug after the machine/main loop has been fully setup\n> -- the new CPU comes up, answers and sends emergency signals, but suddenly\n> the VM gets stuck. This is strange, as ordinary online/offline works\n> just fine.\n> -- can be triggered by \"cpu-add 1\" + \"system_reset\". The system will hang\n> when trying to online CPUs. (note: in Linux code they are fully up and\n> running and already executed code)\n> -- also if hotplugging with \"-S\", before anything has run. This is strange,\n> as \"-device qemu-s390-cpu\" works just fine.\n> -- does not seem to be related to CPU setup/reset code, I checked that\n> -- seems to be related to some TCG internals (as broken for single and\n> multi threaded TCG).\n> -- common code seems to be somehow broken, not sure if this is even\n> expected to work (e.g. for single threaded TCG, hotplugged CPUs will\n> never get set \"cpu->created = true\". But doesn't seem to be related to\n> this)\n> \n> \n> Based on: https://github.com/cohuck/qemu.git s390-next\n> Available on: git@github.com:davidhildenbrand/qemu.git s390x-queue\n> \n> \n> David Hildenbrand (27):\n> s390x: raise CPU hotplug irq after really hotplugged\n> s390x/cpumodel: fix max STFL(E) bit number\n> target/s390x: get rid of next_core_id\n> s390x: introduce and use S390_MAX_CPUS\n> s390/tcg: turn INTERRUPT_EXT into a mask\n> s390x/tcg: injection of emergency signals and extarnal calls\n> s390x/tcg: STOPPED cpus can never wake up\n> s390x/tcg: a CPU cannot switch state due to an interrupt\n> target/s390x: factor out handling of WAIT PSW into handle_wait()\n> s390x/kvm: pass ipb directly into handle_sigp()\n> s390x/kvm: generalize SIGP stop and restart interrupt injection\n> s390x/kvm: factor out storing of CPU status\n> target/s390x: proper cpu->be convertion in s390_store_status()\n> s390x/kvm: factor out storing of adtl CPU status\n> s390x/kvm: drop two debug prints\n> s390x/kvm: factor out SIGP code into sigp.c\n> s390x/kvm: factor out actual handling of STOP interrupts\n> s390x/tcg: implement SIGP SENSE RUNNING STATUS\n> s390x/tcg: implement SIGP SENSE\n> s390x/tcg: implement SIGP EXTERNAL CALL\n> s390x/tcg: implement SIGP EMERGENCY SIGNAL\n> s390x/tcg: implement SIGP CONDITIONAL EMERGENCY SIGNAL\n> s390x/tcg: implement STOP and RESET interrupts for TCG\n> s390x/tcg: flush the tlb on SIGP SET PREFIX\n> s390x/tcg: switch to new SIGP handling code\n> s390x/tcg: unlock NMI\n> s390x/tcg: refactor stfl(e) to use s390_get_feat_block()\n> \n> hw/s390x/s390-virtio-ccw.c | 17 +-\n> target/s390x/Makefile.objs | 1 +\n> target/s390x/cpu-qom.h | 2 -\n> target/s390x/cpu.c | 40 ++--\n> target/s390x/cpu.h | 36 +++-\n> target/s390x/cpu_features.c | 2 +-\n> target/s390x/cpu_models.c | 2 +\n> target/s390x/excp_helper.c | 98 ++++++---\n> target/s390x/helper.c | 115 ++++++++--\n> target/s390x/helper.h | 4 +-\n> target/s390x/internal.h | 15 ++\n> target/s390x/interrupt.c | 70 +++++-\n> target/s390x/kvm-stub.c | 13 +-\n> target/s390x/kvm.c | 470 +++--------------------------------------\n> target/s390x/kvm_s390x.h | 3 +-\n> target/s390x/misc_helper.c | 114 ++++------\n> target/s390x/sigp.c | 504 ++++++++++++++++++++++++++++++++++++++++++++\n> target/s390x/trace-events | 4 +-\n> target/s390x/translate.c | 6 +-\n> 19 files changed, 896 insertions(+), 620 deletions(-)\n> create mode 100644 target/s390x/sigp.c\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwtPD6z9sz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 03:32:31 +1000 (AEST)","from localhost ([::1]:38015 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtzuF-0007Up-NE\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 13:32:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43888)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtzts-0007UG-Tl\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:32:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtztp-0006M0-Qr\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:32:04 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34107)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtztp-0006LY-Ik\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:32:01 -0400","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8IHTgY6057524\n\tfor ; Mon, 18 Sep 2017 13:32:00 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d2gsjxsqh-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 18 Sep 2017 13:31:59 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 18 Sep 2017 18:31:57 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 18 Sep 2017 18:31:54 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8IHVsAE17629432; Mon, 18 Sep 2017 17:31:54 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CDB9B11C050;\n\tMon, 18 Sep 2017 18:27:58 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 6542B11C04A;\n\tMon, 18 Sep 2017 18:27:58 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.145.180.234])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tMon, 18 Sep 2017 18:27:58 +0100 (BST)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>","From":"Christian Borntraeger ","Date":"Mon, 18 Sep 2017 19:31:53 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-1-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17091817-0008-0000-0000-00000497D67F","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091817-0009-0000-0000-00001E290417","Message-Id":"<5c6f8432-84ec-e06a-22fe-9ddc24998adf@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-18_07:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709180246","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v1 00/27] s390x: SMP for TCG (+ cleanups)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , Igor Mammedov , \n\t=?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770401,"web_url":"http://patchwork.ozlabs.org/comment/1770401/","msgid":"<0947e406-e38d-a8ad-9ff5-bdca998fa3f9@redhat.com>","list_archive_url":null,"date":"2017-09-18T18:28:09","subject":"Re: [Qemu-devel] [PATCH v1 00/27] s390x: SMP for TCG (+ cleanups)","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 18.09.2017 19:31, Christian Borntraeger wrote:\n> David,\n> \n> can you outline how much you tested KVM after these changes? I assume we should\n> review/test the whole series properly?\n\nRelated to my tests:\n\nI did the usual shutdown/reboot/system_reset/online-offline test with\nKVM. I remember also playing with CPU hotplug again. However, no\nkvm-unit-tests so far (also not in my pipeline).\n\n\nRelated to the patches:\n\nI tried to modify as little KVM code as possible. Most stuff really is\njust moving code around. But still, subtle errors can happen.\n\nE.g. for all new SIGP instructions, I keep existing behavior for KVM by\nchecking for tcg/kvm directly at the start at the handlers. So most\ns390x/tcg patches should have no influence.\n\nSo reviewing all s390x/kvm patches and !tcg patches would be great. I\nwill certainly not complain if some IBM folks would also review the TCG\npatches ;)\n\nSpecial care should need:\n- \"target/s390x: proper cpu->be convertion in s390_store_status()\"\n-- to make sure I haven't done any stupid mistakes while converting\n (just realized s/convertion/conversion/ :) )\n- \"s390x/kvm: factor out SIGP code into sigp.c\"\n-- to make sure the new kvm_s390_handle_sigp() and handle_sigp() do the\n same thing as handle_sigp() did before.\n\n\"s390x/tcg: STOPPED cpus can never wake up\" and\n\"s390x/tcg: implement STOP and RESET interrupts for TCG\" modify a\nfunction called also for kvm (s390_cpu_has_work()). It is expected to\nreturn always \"false\" for kvm. This behavior should still be that way.\n\nThanks!\n\n> \n> On 09/18/2017 05:59 PM, David Hildenbrand wrote:\n>> This series contains:\n>> - properly implement local external interrupts for TCG\n>> - factor out KVM SIGP handling code into common code\n>> - implement missing SIGP orders for TCG handled by the kernel for KVM\n>> (including STOP and RESTART interrupts)\n>> - make TCG use the new SIGP code - experimental SMP support for s390x TCG\n>> - refactor STFL(E) implementation for TCG\n>> - bunch of cleanups\n>>\n>> Basically all SIGP instructions are fully supported.\n>>\n>> Thanks to Aurelien Jarno for the initital prototype and showcasing that\n>> supporting experimental SMP code can be implemented quite easily.\n>>\n>> TCG SMP on s390x - what works?\n>> - \"-smp X,maxcpus=X\" with both, single and multi threaded TCG\n>> - \"-smp ... -device qemu-s390-cpu,id=cpuX,core-id=X\"\n>> - system_powerdown, system_reset, shutdown, reboot, NMI\n>> - online/offline of CPUs from inside the guest\n>>\n>> TCG SMP on s390x - what does not work?\n>> - Floating interrupts all target CPU 0. Don't offline it.\n>> - CPU hotplug after the machine/main loop has been fully setup\n>> -- the new CPU comes up, answers and sends emergency signals, but suddenly\n>> the VM gets stuck. This is strange, as ordinary online/offline works\n>> just fine.\n>> -- can be triggered by \"cpu-add 1\" + \"system_reset\". The system will hang\n>> when trying to online CPUs. (note: in Linux code they are fully up and\n>> running and already executed code)\n>> -- also if hotplugging with \"-S\", before anything has run. This is strange,\n>> as \"-device qemu-s390-cpu\" works just fine.\n>> -- does not seem to be related to CPU setup/reset code, I checked that\n>> -- seems to be related to some TCG internals (as broken for single and\n>> multi threaded TCG).\n>> -- common code seems to be somehow broken, not sure if this is even\n>> expected to work (e.g. for single threaded TCG, hotplugged CPUs will\n>> never get set \"cpu->created = true\". But doesn't seem to be related to\n>> this)\n>>\n>>\n>> Based on: https://github.com/cohuck/qemu.git s390-next\n>> Available on: git@github.com:davidhildenbrand/qemu.git s390x-queue\n>>\n>>\n>> David Hildenbrand (27):\n>> s390x: raise CPU hotplug irq after really hotplugged\n>> s390x/cpumodel: fix max STFL(E) bit number\n>> target/s390x: get rid of next_core_id\n>> s390x: introduce and use S390_MAX_CPUS\n>> s390/tcg: turn INTERRUPT_EXT into a mask\n>> s390x/tcg: injection of emergency signals and extarnal calls\n>> s390x/tcg: STOPPED cpus can never wake up\n>> s390x/tcg: a CPU cannot switch state due to an interrupt\n>> target/s390x: factor out handling of WAIT PSW into handle_wait()\n>> s390x/kvm: pass ipb directly into handle_sigp()\n>> s390x/kvm: generalize SIGP stop and restart interrupt injection\n>> s390x/kvm: factor out storing of CPU status\n>> target/s390x: proper cpu->be convertion in s390_store_status()\n>> s390x/kvm: factor out storing of adtl CPU status\n>> s390x/kvm: drop two debug prints\n>> s390x/kvm: factor out SIGP code into sigp.c\n>> s390x/kvm: factor out actual handling of STOP interrupts\n>> s390x/tcg: implement SIGP SENSE RUNNING STATUS\n>> s390x/tcg: implement SIGP SENSE\n>> s390x/tcg: implement SIGP EXTERNAL CALL\n>> s390x/tcg: implement SIGP EMERGENCY SIGNAL\n>> s390x/tcg: implement SIGP CONDITIONAL EMERGENCY SIGNAL\n>> s390x/tcg: implement STOP and RESET interrupts for TCG\n>> s390x/tcg: flush the tlb on SIGP SET PREFIX\n>> s390x/tcg: switch to new SIGP handling code\n>> s390x/tcg: unlock NMI\n>> s390x/tcg: refactor stfl(e) to use s390_get_feat_block()\n>>\n>> hw/s390x/s390-virtio-ccw.c | 17 +-\n>> target/s390x/Makefile.objs | 1 +\n>> target/s390x/cpu-qom.h | 2 -\n>> target/s390x/cpu.c | 40 ++--\n>> target/s390x/cpu.h | 36 +++-\n>> target/s390x/cpu_features.c | 2 +-\n>> target/s390x/cpu_models.c | 2 +\n>> target/s390x/excp_helper.c | 98 ++++++---\n>> target/s390x/helper.c | 115 ++++++++--\n>> target/s390x/helper.h | 4 +-\n>> target/s390x/internal.h | 15 ++\n>> target/s390x/interrupt.c | 70 +++++-\n>> target/s390x/kvm-stub.c | 13 +-\n>> target/s390x/kvm.c | 470 +++--------------------------------------\n>> target/s390x/kvm_s390x.h | 3 +-\n>> target/s390x/misc_helper.c | 114 ++++------\n>> target/s390x/sigp.c | 504 ++++++++++++++++++++++++++++++++++++++++++++\n>> target/s390x/trace-events | 4 +-\n>> target/s390x/translate.c | 6 +-\n>> 19 files changed, 896 insertions(+), 620 deletions(-)\n>> create mode 100644 target/s390x/sigp.c\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwvf624Y6z9s7m\n\tfor ;\n\tTue, 19 Sep 2017 04:28:43 +1000 (AEST)","from localhost ([::1]:38270 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du0me-0001wP-S1\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 14:28:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34467)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du0mH-0001vb-N7\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:28:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du0mE-0007Gb-Hv\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:28:17 -0400","from mx1.redhat.com ([209.132.183.28]:52326)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1du0mE-0007GG-9b\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:28:14 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 19678129871;\n\tMon, 18 Sep 2017 18:28:13 +0000 (UTC)","from [10.36.116.100] (ovpn-116-100.ams2.redhat.com [10.36.116.100])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AFA895D6A6;\n\tMon, 18 Sep 2017 18:28:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 19678129871","To":"Christian Borntraeger , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<5c6f8432-84ec-e06a-22fe-9ddc24998adf@de.ibm.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<0947e406-e38d-a8ad-9ff5-bdca998fa3f9@redhat.com>","Date":"Mon, 18 Sep 2017 20:28:09 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<5c6f8432-84ec-e06a-22fe-9ddc24998adf@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 18 Sep 2017 18:28:13 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 00/27] s390x: SMP for TCG (+ cleanups)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , Igor Mammedov , \n\t=?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772793,"web_url":"http://patchwork.ozlabs.org/comment/1772793/","msgid":"<2ee2a862-d52a-486d-bb99-f7dfc5579e4e@redhat.com>","list_archive_url":null,"date":"2017-09-21T13:07:51","subject":"Re: [Qemu-devel] [PATCH v1 00/27] s390x: SMP for TCG (+ cleanups)","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"> David Hildenbrand (27):\n> s390x: raise CPU hotplug irq after really hotplugged\n> s390x/cpumodel: fix max STFL(E) bit number\n> target/s390x: get rid of next_core_id\n> s390x: introduce and use S390_MAX_CPUS\n\nIt probably makes sense to apply 1-3/4 before the SMP support.\n\nIgor, can you take a look at Patch nr. 3?\n\n> s390/tcg: turn INTERRUPT_EXT into a mask\n> s390x/tcg: injection of emergency signals and extarnal calls\n> s390x/tcg: STOPPED cpus can never wake up\n> s390x/tcg: a CPU cannot switch state due to an interrupt\n> target/s390x: factor out handling of WAIT PSW into handle_wait()\n> s390x/kvm: pass ipb directly into handle_sigp()\n> s390x/kvm: generalize SIGP stop and restart interrupt injection\n> s390x/kvm: factor out storing of CPU status\n> target/s390x: proper cpu->be convertion in s390_store_status()\n> s390x/kvm: factor out storing of adtl CPU status\n> s390x/kvm: drop two debug prints\n> s390x/kvm: factor out SIGP code into sigp.c\n> s390x/kvm: factor out actual handling of STOP interrupts\n> s390x/tcg: implement SIGP SENSE RUNNING STATUS\n> s390x/tcg: implement SIGP SENSE\n> s390x/tcg: implement SIGP EXTERNAL CALL\n> s390x/tcg: implement SIGP EMERGENCY SIGNAL\n> s390x/tcg: implement SIGP CONDITIONAL EMERGENCY SIGNAL\n> s390x/tcg: implement STOP and RESET interrupts for TCG\n> s390x/tcg: flush the tlb on SIGP SET PREFIX\n> s390x/tcg: switch to new SIGP handling code\n> s390x/tcg: unlock NMI\n> s390x/tcg: refactor stfl(e) to use s390_get_feat_block()","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xycPD525hz9sNc\n\tfor ;\n\tThu, 21 Sep 2017 23:08:31 +1000 (AEST)","from localhost ([::1]:53625 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dv1DQ-0002iG-Lj\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 09:08:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53440)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dv1D0-0002hv-3U\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:08:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dv1Cu-0005uS-6s\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:08:02 -0400","from mx1.redhat.com ([209.132.183.28]:54960)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dv1Ct-0005tH-UP\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:07:56 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6D8C3C00DBBD;\n\tThu, 21 Sep 2017 13:07:54 +0000 (UTC)","from [10.36.116.56] (ovpn-116-56.ams2.redhat.com [10.36.116.56])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 33F475C542;\n\tThu, 21 Sep 2017 13:07:52 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6D8C3C00DBBD","To":"qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<2ee2a862-d52a-486d-bb99-f7dfc5579e4e@redhat.com>","Date":"Thu, 21 Sep 2017 15:07:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-1-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 21 Sep 2017 13:07:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 00/27] s390x: SMP for TCG (+ cleanups)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , borntraeger@de.ibm.com, Igor Mammedov\n\t, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, \tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]