[{"id":1770589,"web_url":"http://patchwork.ozlabs.org/comment/1770589/","msgid":"<7f98890b-ee32-d539-0823-06544849457a@redhat.com>","list_archive_url":null,"date":"2017-09-18T23:59:48","subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/18/2017 10:05 AM, Mao Zhongyi wrote:\n> This series mainly implements the conversions of ide, floppy and nvme\n> device to realize. Add some error handling messages and remove the local\n> variable local_err, use errp to propagate the error directly. Also\n> fix the unusual function name.\n> \n> v3:\n> -patch1: update the test output in 051 [John Snow] \n> -patch2: update the test putput in 172 [John Snow]\n> \n> v2:\n> -use bool as the return type instead of int. [Markus Armbruster & Stefan Hajnoczi]\n> \n> Cc: John Snow \n> Cc: Kevin Wolf \n> Cc: Max Reitz \n> Cc: Keith Busch \n> Cc: Stefan Hajnoczi \n> Cc: \"Michael S. Tsirkin\" \n> Cc: Paolo Bonzini \n> Cc: Gerd Hoffmann \n> Cc: Markus Armbruster \n> \n> Mao Zhongyi (6):\n> hw/ide: Convert DeviceClass init to realize\n> hw/block/fdc: Convert to realize\n> hw/block/nvme: Convert to realize\n> hw/block: Fix the return type\n> hw/block: Use errp directly rather than local_err\n> dev-storage: Fix the unusual function name\n> \n> hw/block/block.c | 15 ++++---\n> hw/block/dataplane/virtio-blk.c | 12 +++---\n> hw/block/dataplane/virtio-blk.h | 2 +-\n> hw/block/fdc.c | 48 +++++++++------------\n> hw/block/nvme.c | 24 +++++------\n> hw/block/virtio-blk.c | 17 +++-----\n> hw/ide/core.c | 7 +--\n> hw/ide/qdev.c | 94 +++++++++++++++++++----------------------\n> hw/scsi/scsi-disk.c | 13 ++----\n> hw/usb/dev-storage.c | 29 ++++++-------\n> include/hw/block/block.h | 4 +-\n> include/hw/ide/internal.h | 5 ++-\n> tests/qemu-iotests/051.pc.out | 10 +----\n> tests/qemu-iotests/172.out | 8 ----\n> 14 files changed, 127 insertions(+), 161 deletions(-)\n> \n\nHi Mao Zhongyi:\n\nI've staged patches one and two here for my IDE pull request.\n\nI think patches 3-6 here would belong to Kevin.\n\nThanks,\nJohn","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx30z4D3Sz9ryv\n\tfor ;\n\tTue, 19 Sep 2017 10:00:34 +1000 (AEST)","from localhost ([::1]:39362 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du5xn-0002or-BX\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 20:00:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34430)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du5xK-0002mp-Jr\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 20:00:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du5xF-0007GY-VV\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 20:00:02 -0400","from mx1.redhat.com ([209.132.183.28]:47386)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1du5xF-0007Dr-Nt\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 19:59:57 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4822D7E431;\n\tMon, 18 Sep 2017 23:59:56 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 49B2A600C2;\n\tMon, 18 Sep 2017 23:59:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4822D7E431","To":"Mao Zhongyi , qemu-devel@nongnu.org","References":"","From":"John Snow ","Message-ID":"<7f98890b-ee32-d539-0823-06544849457a@redhat.com>","Date":"Mon, 18 Sep 2017 19:59:48 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 18 Sep 2017 23:59:56 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , \"Michael S. Tsirkin\" ,\n\tMarkus Armbruster , Max Reitz , \n\tKeith Busch , Gerd Hoffmann ,\n\tStefan Hajnoczi ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770602,"web_url":"http://patchwork.ozlabs.org/comment/1770602/","msgid":"","list_archive_url":null,"date":"2017-09-19T01:25:23","subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","submitter":{"id":71231,"url":"http://patchwork.ozlabs.org/api/people/71231/","name":"Mao Zhongyi","email":"maozy.fnst@cn.fujitsu.com"},"content":"On 09/19/2017 07:59 AM, John Snow wrote:\n>\n>\n> On 09/18/2017 10:05 AM, Mao Zhongyi wrote:\n>> This series mainly implements the conversions of ide, floppy and nvme\n>> device to realize. Add some error handling messages and remove the local\n>> variable local_err, use errp to propagate the error directly. Also\n>> fix the unusual function name.\n>>\n>> v3:\n>> -patch1: update the test output in 051 [John Snow]\n>> -patch2: update the test putput in 172 [John Snow]\n>>\n>> v2:\n>> -use bool as the return type instead of int. [Markus Armbruster & Stefan Hajnoczi]\n>>\n>> Cc: John Snow \n>> Cc: Kevin Wolf \n>> Cc: Max Reitz \n>> Cc: Keith Busch \n>> Cc: Stefan Hajnoczi \n>> Cc: \"Michael S. Tsirkin\" \n>> Cc: Paolo Bonzini \n>> Cc: Gerd Hoffmann \n>> Cc: Markus Armbruster \n>>\n>> Mao Zhongyi (6):\n>> hw/ide: Convert DeviceClass init to realize\n>> hw/block/fdc: Convert to realize\n>> hw/block/nvme: Convert to realize\n>> hw/block: Fix the return type\n>> hw/block: Use errp directly rather than local_err\n>> dev-storage: Fix the unusual function name\n>>\n>> hw/block/block.c | 15 ++++---\n>> hw/block/dataplane/virtio-blk.c | 12 +++---\n>> hw/block/dataplane/virtio-blk.h | 2 +-\n>> hw/block/fdc.c | 48 +++++++++------------\n>> hw/block/nvme.c | 24 +++++------\n>> hw/block/virtio-blk.c | 17 +++-----\n>> hw/ide/core.c | 7 +--\n>> hw/ide/qdev.c | 94 +++++++++++++++++++----------------------\n>> hw/scsi/scsi-disk.c | 13 ++----\n>> hw/usb/dev-storage.c | 29 ++++++-------\n>> include/hw/block/block.h | 4 +-\n>> include/hw/ide/internal.h | 5 ++-\n>> tests/qemu-iotests/051.pc.out | 10 +----\n>> tests/qemu-iotests/172.out | 8 ----\n>> 14 files changed, 127 insertions(+), 161 deletions(-)\n>>\n>\n> Hi Mao Zhongyi:\n>\n> I've staged patches one and two here for my IDE pull request.\n>\n> I think patches 3-6 here would belong to Kevin.\n>\n> Thanks,\n> John\n>\n\nHi, John\n\nOK, I see.\n\nThanks for the quick review. :)\n--\nMao","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx4yN2cdKz9s3w\n\tfor ;\n\tTue, 19 Sep 2017 11:28:25 +1000 (AEST)","from localhost ([::1]:39593 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du7Kn-000289-8i\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 21:28:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53650)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du7KQ-000280-3u\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 21:27:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du7KL-0000Gv-Ax\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 21:27:58 -0400","from mail.cn.fujitsu.com ([183.91.158.132]:60750\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du7KK-0000GM-VI\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 21:27:53 -0400","from localhost (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 19 Sep 2017 09:27:50 +0800","from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85])\n\tby cn.fujitsu.com (Postfix) with ESMTP id B0E5347ACDAD;\n\tTue, 19 Sep 2017 09:27:50 +0800 (CST)","from [10.167.225.76] (10.167.225.76) by\n\tG08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.361.1; Tue, 19 Sep 2017 09:27:49 +0800"],"X-IronPort-AV":"E=Sophos;i=\"5.42,415,1500912000\"; d=\"scan'208\";a=\"26865450\"","To":"John Snow , ","References":"\n\t<7f98890b-ee32-d539-0823-06544849457a@redhat.com>","From":"Mao Zhongyi ","Message-ID":"","Date":"Tue, 19 Sep 2017 09:25:23 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<7f98890b-ee32-d539-0823-06544849457a@redhat.com>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.167.225.76]","X-yoursite-MailScanner-ID":"B0E5347ACDAD.AE435","X-yoursite-MailScanner":"Found to be clean","X-yoursite-MailScanner-From":"maozy.fnst@cn.fujitsu.com","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"183.91.158.132","Subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , \"Michael S. Tsirkin\" ,\n\tMarkus Armbruster , Max Reitz , \n\tKeith Busch , Gerd Hoffmann ,\n\tStefan Hajnoczi ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1785103,"web_url":"http://patchwork.ozlabs.org/comment/1785103/","msgid":"<3ac513ac-9b54-19ae-4d19-7b895881bd92@cn.fujitsu.com>","list_archive_url":null,"date":"2017-10-12T02:40:53","subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","submitter":{"id":71231,"url":"http://patchwork.ozlabs.org/api/people/71231/","name":"Mao Zhongyi","email":"maozy.fnst@cn.fujitsu.com"},"content":"Hi,\n\nLong time no news. Ping...\n\nThanks,\nMao\n\n\n\nOn 09/19/2017 09:25 AM, Mao Zhongyi wrote:\n>\n>\n> On 09/19/2017 07:59 AM, John Snow wrote:\n>>\n>>\n>> On 09/18/2017 10:05 AM, Mao Zhongyi wrote:\n>>> This series mainly implements the conversions of ide, floppy and nvme\n>>> device to realize. Add some error handling messages and remove the local\n>>> variable local_err, use errp to propagate the error directly. Also\n>>> fix the unusual function name.\n>>>\n>>> v3:\n>>> -patch1: update the test output in 051 [John Snow]\n>>> -patch2: update the test putput in 172 [John Snow]\n>>>\n>>> v2:\n>>> -use bool as the return type instead of int. [Markus Armbruster & Stefan Hajnoczi]\n>>>\n>>> Cc: John Snow \n>>> Cc: Kevin Wolf \n>>> Cc: Max Reitz \n>>> Cc: Keith Busch \n>>> Cc: Stefan Hajnoczi \n>>> Cc: \"Michael S. Tsirkin\" \n>>> Cc: Paolo Bonzini \n>>> Cc: Gerd Hoffmann \n>>> Cc: Markus Armbruster \n>>>\n>>> Mao Zhongyi (6):\n>>> hw/ide: Convert DeviceClass init to realize\n>>> hw/block/fdc: Convert to realize\n>>> hw/block/nvme: Convert to realize\n>>> hw/block: Fix the return type\n>>> hw/block: Use errp directly rather than local_err\n>>> dev-storage: Fix the unusual function name\n>>>\n>>> hw/block/block.c | 15 ++++---\n>>> hw/block/dataplane/virtio-blk.c | 12 +++---\n>>> hw/block/dataplane/virtio-blk.h | 2 +-\n>>> hw/block/fdc.c | 48 +++++++++------------\n>>> hw/block/nvme.c | 24 +++++------\n>>> hw/block/virtio-blk.c | 17 +++-----\n>>> hw/ide/core.c | 7 +--\n>>> hw/ide/qdev.c | 94 +++++++++++++++++++----------------------\n>>> hw/scsi/scsi-disk.c | 13 ++----\n>>> hw/usb/dev-storage.c | 29 ++++++-------\n>>> include/hw/block/block.h | 4 +-\n>>> include/hw/ide/internal.h | 5 ++-\n>>> tests/qemu-iotests/051.pc.out | 10 +----\n>>> tests/qemu-iotests/172.out | 8 ----\n>>> 14 files changed, 127 insertions(+), 161 deletions(-)\n>>>\n>>\n>> Hi Mao Zhongyi:\n>>\n>> I've staged patches one and two here for my IDE pull request.\n>>\n>> I think patches 3-6 here would belong to Kevin.\n>>\n>> Thanks,\n>> John\n>>\n>\n> Hi, John\n>\n> OK, I see.\n>\n> Thanks for the quick review. :)\n> --\n> Mao\n>\n>\n>\n>\n>\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCFYk5Mv1z9s3w\n\tfor ;\n\tThu, 12 Oct 2017 13:44:40 +1100 (AEDT)","from localhost ([::1]:43408 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2TUB-0004K8-T8\n\tfor incoming@patchwork.ozlabs.org; Wed, 11 Oct 2017 22:44:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36126)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e2TTp-0004K1-BJ\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 22:44:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e2TTl-0005nH-Dd\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 22:44:13 -0400","from mail.cn.fujitsu.com ([183.91.158.132]:12164\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e2TTl-0005kO-0a\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 22:44:09 -0400","from localhost (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 12 Oct 2017 10:43:59 +0800","from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83])\n\tby cn.fujitsu.com (Postfix) with ESMTP id 1ADE447F13B0;\n\tThu, 12 Oct 2017 10:43:58 +0800 (CST)","from localhost.localdomain (10.167.226.123) by\n\tG08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.361.1; Thu, 12 Oct 2017 10:43:57 +0800"],"X-IronPort-AV":"E=Sophos;i=\"5.43,364,1503331200\"; d=\"scan'208\";a=\"28908906\"","To":"John Snow , ","References":"\n\t<7f98890b-ee32-d539-0823-06544849457a@redhat.com>\n\t","From":"Mao Zhongyi ","Message-ID":"<3ac513ac-9b54-19ae-4d19-7b895881bd92@cn.fujitsu.com>","Date":"Thu, 12 Oct 2017 10:40:53 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.167.226.123]","X-yoursite-MailScanner-ID":"1ADE447F13B0.AC0B1","X-yoursite-MailScanner":"Found to be clean","X-yoursite-MailScanner-From":"maozy.fnst@cn.fujitsu.com","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"183.91.158.132","Subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , \"Michael S. Tsirkin\" ,\n\tMarkus Armbruster , Max Reitz , \n\tKeith Busch , Gerd Hoffmann ,\n\tStefan Hajnoczi ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1802797,"web_url":"http://patchwork.ozlabs.org/comment/1802797/","msgid":"<20171110142506.GE5466@localhost.localdomain>","list_archive_url":null,"date":"2017-11-10T14:25:06","subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 19.09.2017 um 01:59 hat John Snow geschrieben:\n> On 09/18/2017 10:05 AM, Mao Zhongyi wrote:\n> > This series mainly implements the conversions of ide, floppy and nvme\n> > device to realize. Add some error handling messages and remove the local\n> > variable local_err, use errp to propagate the error directly. Also\n> > fix the unusual function name.\n> \n> I've staged patches one and two here for my IDE pull request.\n> \n> I think patches 3-6 here would belong to Kevin.\n\nSorry, I completely missed this.\n\nThanks, applied patch 3 (nvme) to the block-next branch. I did not take\npatches 4 and 5 because patch 5 doesn't apply cleanly any more, and\nhonestly I think the result is uglier than before.\n\nPatch 6 is for Gerd.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yYMlV327Zz9sPs\n\tfor ;\n\tSat, 11 Nov 2017 01:25:58 +1100 (AEDT)","from localhost ([::1]:42031 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eDAFo-0005t3-HR\n\tfor incoming@patchwork.ozlabs.org; Fri, 10 Nov 2017 09:25:56 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:36799)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eDAFI-0005qI-8S\n\tfor qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:25:28 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eDAFD-0006f1-Qi\n\tfor qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:25:24 -0500","from mx1.redhat.com ([209.132.183.28]:34390)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eDAFD-0006dH-CQ\n\tfor qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:25:19 -0500","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 890C07D0F1;\n\tFri, 10 Nov 2017 14:25:18 +0000 (UTC)","from localhost.localdomain (ovpn-116-223.ams2.redhat.com\n\t[10.36.116.223])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0527C60175;\n\tFri, 10 Nov 2017 14:25:07 +0000 (UTC)"],"Date":"Fri, 10 Nov 2017 15:25:06 +0100","From":"Kevin Wolf ","To":"John Snow ","Message-ID":"<20171110142506.GE5466@localhost.localdomain>","References":"\n\t<7f98890b-ee32-d539-0823-06544849457a@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<7f98890b-ee32-d539-0823-06544849457a@redhat.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 10 Nov 2017 14:25:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Mao Zhongyi ,\n\t\"Michael S. Tsirkin\" , qemu-devel@nongnu.org,\n\tMarkus Armbruster , Max Reitz , \n\tKeith Busch , Gerd Hoffmann ,\n\tStefan Hajnoczi ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1808459,"web_url":"http://patchwork.ozlabs.org/comment/1808459/","msgid":"<653ca7ec-0d6f-b688-2e5a-2e5ead55b2fc@cn.fujitsu.com>","list_archive_url":null,"date":"2017-11-22T02:09:22","subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","submitter":{"id":71231,"url":"http://patchwork.ozlabs.org/api/people/71231/","name":"Mao Zhongyi","email":"maozy.fnst@cn.fujitsu.com"},"content":"Hi, Kevin\n\nOn 11/10/2017 10:25 PM, Kevin Wolf wrote:\n> Am 19.09.2017 um 01:59 hat John Snow geschrieben:\n>> On 09/18/2017 10:05 AM, Mao Zhongyi wrote:\n>>> This series mainly implements the conversions of ide, floppy and nvme\n>>> device to realize. Add some error handling messages and remove the local\n>>> variable local_err, use errp to propagate the error directly. Also\n>>> fix the unusual function name.\n>>\n>> I've staged patches one and two here for my IDE pull request.\n>>\n>> I think patches 3-6 here would belong to Kevin.\n>\n> Sorry, I completely missed this.\n\nThat's all right.\n\n> Thanks, applied patch 3 (nvme) to the block-next branch. I did not take\n> patches 4 and 5 because patch 5 doesn't apply cleanly any more, and\n> honestly I think the result is uglier than before.\n\nI will rebase the patches right away.\n\nThanks,\nMao\n\n> Patch 6 is for Gerd.\n> Kevin\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yhQxY3DcCz9s8J\n\tfor ;\n\tWed, 22 Nov 2017 13:14:08 +1100 (AEDT)","from localhost ([::1]:37433 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eHKY9-0003zr-Fj\n\tfor incoming@patchwork.ozlabs.org; Tue, 21 Nov 2017 21:14:05 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:50468)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eHKXm-0003zb-TV\n\tfor qemu-devel@nongnu.org; Tue, 21 Nov 2017 21:13:43 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eHKXh-0001Sr-Vp\n\tfor qemu-devel@nongnu.org; Tue, 21 Nov 2017 21:13:42 -0500","from mail.cn.fujitsu.com ([183.91.158.132]:34493\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eHKXh-0001Qk-Gm\n\tfor qemu-devel@nongnu.org; Tue, 21 Nov 2017 21:13:37 -0500","from bogon (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 22 Nov 2017 10:13:27 +0800","from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83])\n\tby cn.fujitsu.com (Postfix) with ESMTP id 4A5FD482D01B;\n\tWed, 22 Nov 2017 10:13:24 +0800 (CST)","from localhost.localdomain (10.167.226.123) by\n\tG08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.361.1; Wed, 22 Nov 2017 10:13:23 +0800"],"X-IronPort-AV":"E=Sophos;i=\"5.43,368,1503331200\"; d=\"scan'208\";a=\"30357732\"","To":"Kevin Wolf , John Snow ","References":"\n\t<7f98890b-ee32-d539-0823-06544849457a@redhat.com>\n\t<20171110142506.GE5466@localhost.localdomain>","From":"Mao Zhongyi ","Message-ID":"<653ca7ec-0d6f-b688-2e5a-2e5ead55b2fc@cn.fujitsu.com>","Date":"Wed, 22 Nov 2017 10:09:22 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20171110142506.GE5466@localhost.localdomain>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.167.226.123]","X-yoursite-MailScanner-ID":"4A5FD482D01B.A99BF","X-yoursite-MailScanner":"Found to be clean","X-yoursite-MailScanner-From":"maozy.fnst@cn.fujitsu.com","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"183.91.158.132","Subject":"Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve\n\terror handling","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Michael S. Tsirkin\" , qemu-devel@nongnu.org,\n\tMarkus Armbruster , Max Reitz , \n\tKeith Busch , Gerd Hoffmann ,\n\tStefan Hajnoczi ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]