[{"id":1769914,"web_url":"http://patchwork.ozlabs.org/comment/1769914/","msgid":"<20170918073529.wssxfbgfwgd2jzpl@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-18T07:35:30","subject":"Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"Hi Wenyou,\n\nThanks for the update.\n\nThe driver exposes controls that are accessible through the sub-device node\neven if the device hasn't been powered on.\n\nMany ISP and bridge drivers will also power the sensor down once the last\nuser of the user space device nodes disappears. You could keep the device\npowered at all times or change the behaviour so that controls can be\naccessed when the power is off.\n\nThe best option would be to convert the driver to use runtime PM. An\nexample of this can be found in drivers/media/i2c/ov13858.c .\n\nOn Mon, Sep 18, 2017 at 02:45:14PM +0800, Wenyou Yang wrote:\n> Add the s_power operation which is responsible for manipulating the\n> power dowm mode through the PWDN pin and the reset operation through\n> the RESET pin.\n> \n> Signed-off-by: Wenyou Yang \n> ---\n> \n> Changes in v4: None\n> Changes in v3: None\n> Changes in v2:\n> - Add the patch to support the get_fmt ops.\n> - Remove the redundant invoking ov7670_init_gpio().\n> \n> drivers/media/i2c/ov7670.c | 32 +++++++++++++++++++++++++++-----\n> 1 file changed, 27 insertions(+), 5 deletions(-)\n> \n> diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c\n> index 456f48057605..304abc769a67 100644\n> --- a/drivers/media/i2c/ov7670.c\n> +++ b/drivers/media/i2c/ov7670.c\n> @@ -1542,6 +1542,22 @@ static int ov7670_s_register(struct v4l2_subdev *sd, const struct v4l2_dbg_regis\n> }\n> #endif\n> \n> +static int ov7670_s_power(struct v4l2_subdev *sd, int on)\n> +{\n> +\tstruct ov7670_info *info = to_state(sd);\n> +\n> +\tif (info->pwdn_gpio)\n> +\t\tgpiod_direction_output(info->pwdn_gpio, !on);\n> +\tif (on && info->resetb_gpio) {\n> +\t\tgpiod_set_value(info->resetb_gpio, 1);\n> +\t\tusleep_range(500, 1000);\n> +\t\tgpiod_set_value(info->resetb_gpio, 0);\n> +\t\tusleep_range(3000, 5000);\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> static void ov7670_get_default_format(struct v4l2_subdev *sd,\n> \t\t\t\t struct v4l2_mbus_framefmt *format)\n> {\n> @@ -1575,6 +1591,7 @@ static const struct v4l2_subdev_core_ops ov7670_core_ops = {\n> \t.g_register = ov7670_g_register,\n> \t.s_register = ov7670_s_register,\n> #endif\n> +\t.s_power = ov7670_s_power,\n> };\n> \n> static const struct v4l2_subdev_video_ops ov7670_video_ops = {\n> @@ -1692,23 +1709,25 @@ static int ov7670_probe(struct i2c_client *client,\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tret = ov7670_init_gpio(client, info);\n> -\tif (ret)\n> -\t\tgoto clk_disable;\n> -\n> \tinfo->clock_speed = clk_get_rate(info->clk) / 1000000;\n> \tif (info->clock_speed < 10 || info->clock_speed > 48) {\n> \t\tret = -EINVAL;\n> \t\tgoto clk_disable;\n> \t}\n> \n> +\tret = ov7670_init_gpio(client, info);\n> +\tif (ret)\n> +\t\tgoto clk_disable;\n> +\n> +\tov7670_s_power(sd, 1);\n> +\n> \t/* Make sure it's an ov7670 */\n> \tret = ov7670_detect(sd);\n> \tif (ret) {\n> \t\tv4l_dbg(1, debug, client,\n> \t\t\t\"chip found @ 0x%x (%s) is not an ov7670 chip.\\n\",\n> \t\t\tclient->addr << 1, client->adapter->name);\n> -\t\tgoto clk_disable;\n> +\t\tgoto power_off;\n> \t}\n> \tv4l_info(client, \"chip found @ 0x%02x (%s)\\n\",\n> \t\t\tclient->addr << 1, client->adapter->name);\n> @@ -1787,6 +1806,8 @@ static int ov7670_probe(struct i2c_client *client,\n> #endif\n> hdl_free:\n> \tv4l2_ctrl_handler_free(&info->hdl);\n> +power_off:\n> +\tov7670_s_power(sd, 0);\n> clk_disable:\n> \tclk_disable_unprepare(info->clk);\n> \treturn ret;\n> @@ -1804,6 +1825,7 @@ static int ov7670_remove(struct i2c_client *client)\n> #if defined(CONFIG_MEDIA_CONTROLLER)\n> \tmedia_entity_cleanup(&info->sd.entity);\n> #endif\n> +\tov7670_s_power(sd, 0);\n> \treturn 0;\n> }\n> \n> -- \n> 2.13.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"u9lqQnaF\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwd9F3LGyz9ryQ\n\tfor ;\n\tMon, 18 Sep 2017 17:36:17 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqbF-0001EX-SN; Mon, 18 Sep 2017 07:36:13 +0000","from hillosipuli.retiisi.org.uk ([2001:1bc8:1a6:d3d5::81:2])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqb2-0000uz-Ln for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 07:36:10 +0000","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 06D4F600EA;\n\tMon, 18 Sep 2017 10:35:31 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dtqaY-0004on-By; Mon, 18 Sep 2017 10:35:30 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=qmnQEEb7LirqW8n1cChrdorkrPKJZBOYCUOdEOjm3oE=;\n\tb=u9lqQnaFVbxRtw\n\t3kDpbaGISv5EGrWdv1GX8gsbgDccaC00A5aanv0g+iNa2/1StOxJBOaKaGvU5f5+2OjtICmFgV2SN\n\tYVSdQmkU37dbxfZ2GkeBXfezjfb+tcrjkpQ9Q+Rhu9Z35XsQQav07MY59sDJjZCiq89Oh5s9GFbBq\n\tB8KbKNgAafWe1Z7jrHD4R4XerhtBUCoNF2c6t/ZVQXvDEPmCquGpNM0cWD5R2NmFa6IZ3dq9TRCkb\n\t8PfXCDPGFuRRaU5mqBzCg8hZ1tZ1bJ8bJ0AF/rFpQzUnx6X7qsfGyh0sOtpGu3FGg5daWbB0pMSip\n\tA4ssaBWofteFNFcntpTw==;","Date":"Mon, 18 Sep 2017 10:35:30 +0300","From":"Sakari Ailus ","To":"Wenyou Yang ","Subject":"Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation","Message-ID":"<20170918073529.wssxfbgfwgd2jzpl@valkosipuli.retiisi.org.uk>","References":"<20170918064514.6841-1-wenyou.yang@microchip.com>\n\t<20170918064514.6841-4-wenyou.yang@microchip.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170918064514.6841-4-wenyou.yang@microchip.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_003601_409391_BC3AC881 ","X-CRM114-Status":"GOOD ( 20.30 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jonathan Corbet , linux-kernel@vger.kernel.org,\n\tMauro Carvalho Chehab ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tLinux Media Mailing List ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769918,"web_url":"http://patchwork.ozlabs.org/comment/1769918/","msgid":"<20170918073628.nwjdyfdk7hvsetfb@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-18T07:36:28","subject":"Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"Hi Wenyou,\n\nOn Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote:\n> @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd,\n> \t\tret = ov7670_try_fmt_internal(sd, &format->format, NULL, NULL);\n> \t\tif (ret)\n> \t\t\treturn ret;\n> -\t\tcfg->try_fmt = format->format;\n> +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API\n> +\t\tstruct v4l2_mbus_framefmt *mbus_fmt;\n\nThis will emit a compiler warning at least.\n\n> +\n> +\t\tmbus_fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);\n> +\t\t*mbus_fmt = format->format;\n> \t\treturn 0;\n> +#else\n> +\t\treturn -ENOTTY;\n> +#endif\n> \t}\n> \n> \tret = ov7670_try_fmt_internal(sd, &format->format, &ovfmt, &wsize);","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"BD6hZ1gK\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwdCT6gzRz9ryQ\n\tfor ;\n\tMon, 18 Sep 2017 17:38:13 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqd8-0002Re-J3; Mon, 18 Sep 2017 07:38:10 +0000","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]\n\thelo=hillosipuli.retiisi.org.uk)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqbs-0001Rs-BI for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 07:37:27 +0000","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 3C331600EA;\n\tMon, 18 Sep 2017 10:36:29 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dtqbU-0004ou-Ib; Mon, 18 Sep 2017 10:36:28 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=LP1i/O0KlKqLO4vkMZQcovxDtWFdGP+EH0SGSPz1ln4=;\n\tb=BD6hZ1gKA/nVJp\n\ts/NIXeGCRxwROVUwBvSgmr3/ZRqghvwzgXGAmq08jIxEsmBt5jssrY2rMheYlNQPlWFojI1uPVS8M\n\t+XQuts8UZ8lcu0fordGpGevX0m0/rApp0o0pJI7EaSifgEEtJD3e0AbhHxnDNlkenbLIMPSCJGBd8\n\th9jDtHYYEUwWpB0V5+4pVgyeuAxfag4eSrcEKNnMO7UUiZhXDmbuxaXoB/XXh3eLCFa2qCFremefz\n\tVVh4CLjXpYyVUES3+X0DJM5DZfPZDdX8myKLs0DJ60wEykGvVofrcgWTRLRV3eA7jRGntTCMqjlbW\n\twT2uNAzpRIO70JCqav3g==;","Date":"Mon, 18 Sep 2017 10:36:28 +0300","From":"Sakari Ailus ","To":"Wenyou Yang ","Subject":"Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback","Message-ID":"<20170918073628.nwjdyfdk7hvsetfb@valkosipuli.retiisi.org.uk>","References":"<20170918064514.6841-1-wenyou.yang@microchip.com>\n\t<20170918064514.6841-3-wenyou.yang@microchip.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170918064514.6841-3-wenyou.yang@microchip.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_003653_538303_C9C6B758 ","X-CRM114-Status":"UNSURE ( 9.99 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [83.145.211.213 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jonathan Corbet , linux-kernel@vger.kernel.org,\n\tMauro Carvalho Chehab ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tLinux Media Mailing List ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1770003,"web_url":"http://patchwork.ozlabs.org/comment/1770003/","msgid":"<2f2a0259-1176-74b7-d9f7-a5cf7392ebdf@Microchip.com>","list_archive_url":null,"date":"2017-09-18T09:25:28","subject":"Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback","submitter":{"id":69532,"url":"http://patchwork.ozlabs.org/api/people/69532/","name":"Wenyou Yang","email":"Wenyou.Yang@microchip.com"},"content":"Hi Sakari,\n\n\nOn 2017/9/18 15:36, Sakari Ailus wrote:\n> Hi Wenyou,\n>\n> On Mon, Sep 18, 2017 at 02:45:13PM +0800, Wenyou Yang wrote:\n>> @@ -998,8 +1002,15 @@ static int ov7670_set_fmt(struct v4l2_subdev *sd,\n>> \t\tret = ov7670_try_fmt_internal(sd, &format->format, NULL, NULL);\n>> \t\tif (ret)\n>> \t\t\treturn ret;\n>> -\t\tcfg->try_fmt = format->format;\n>> +#ifdef CONFIG_VIDEO_V4L2_SUBDEV_API\n>> +\t\tstruct v4l2_mbus_framefmt *mbus_fmt;\n> This will emit a compiler warning at least.\nThank you for your review.\nWill be fixed in next version.\n>\n>> +\n>> +\t\tmbus_fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);\n>> +\t\t*mbus_fmt = format->format;\n>> \t\treturn 0;\n>> +#else\n>> +\t\treturn -ENOTTY;\n>> +#endif\n>> \t}\n>> \n>> \tret = ov7670_try_fmt_internal(sd, &format->format, &ovfmt, &wsize);\n\nBest Regards,\nWenyou Yang","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"u76OdKk5\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgbw6tBHz9s72\n\tfor ;\n\tMon, 18 Sep 2017 19:26:04 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtsJV-0002nf-Ei; Mon, 18 Sep 2017 09:26:01 +0000","from esa3.microchip.iphmx.com ([68.232.153.233])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtsJQ-0002QG-S4 for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 09:25:59 +0000","from exsmtp02.microchip.com (HELO email.microchip.com)\n\t([198.175.253.38])\n\tby esa3.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t18 Sep 2017 02:25:34 -0700","from [10.160.137.68] (10.10.76.4) by chn-sv-exch02.mchp-main.com\n\t(10.10.76.38) with Microsoft SMTP Server id 14.3.352.0;\n\tMon, 18 Sep 2017 02:25:33 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=p2dcUXejhU7EKc1f9fuYKTyPjwBf3NlATMaDQ6DqkXk=;\n\tb=u76OdKk5EMzxEbX9l0QLG4CSH\n\tuOScjwdQsaGj8YylX/6MVSQPYUuG9/OaYmdIghiB8zogxEqGp5fKg/9xVbK7FRRof6PlDoHh6aiHF\n\ty8k/tBoKGLVmV3KbCrixdVSyZwotqaHf7ez5Iv3CMH/3RewjY2VXO1VL3YLX4c1hlHeWgWw2ovTx6\n\tr2z90HoXalnSNt7/E+do3SHtc+UDstpHT4qNLAAByMpmBKcV98CZgRudxrvJzPSeMIsmEsBm04hKC\n\tZDRPNVVhkWuez1v8p6066wbU66OhifOUaCJwcVOxX9rA3ylJ/gLtEx7ud+5M3ul0FLLssoENLTlTu\n\t4slL9d+Cw==;","X-IronPort-AV":"E=Sophos;i=\"5.42,412,1500966000\"; d=\"scan'208\";a=\"7127118\"","Subject":"Re: [PATCH v4 2/3] media: ov7670: Add the get_fmt callback","To":"Sakari Ailus ","References":"<20170918064514.6841-1-wenyou.yang@microchip.com>\n\t<20170918064514.6841-3-wenyou.yang@microchip.com>\n\t<20170918073628.nwjdyfdk7hvsetfb@valkosipuli.retiisi.org.uk>","From":"\"Yang, Wenyou\" ","Message-ID":"<2f2a0259-1176-74b7-d9f7-a5cf7392ebdf@Microchip.com>","Date":"Mon, 18 Sep 2017 17:25:28 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918073628.nwjdyfdk7hvsetfb@valkosipuli.retiisi.org.uk>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_022556_931479_08E533DB ","X-CRM114-Status":"UNSURE ( 8.60 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.153.233 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jonathan Corbet , linux-kernel@vger.kernel.org,\n\tMauro Carvalho Chehab ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tLinux Media Mailing List ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1770008,"web_url":"http://patchwork.ozlabs.org/comment/1770008/","msgid":"","list_archive_url":null,"date":"2017-09-18T09:26:16","subject":"Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation","submitter":{"id":69532,"url":"http://patchwork.ozlabs.org/api/people/69532/","name":"Wenyou Yang","email":"Wenyou.Yang@microchip.com"},"content":"Hi Sakari,\n\n\nOn 2017/9/18 15:35, Sakari Ailus wrote:\n> Hi Wenyou,\n>\n> Thanks for the update.\n>\n> The driver exposes controls that are accessible through the sub-device node\n> even if the device hasn't been powered on.\n>\n> Many ISP and bridge drivers will also power the sensor down once the last\n> user of the user space device nodes disappears. You could keep the device\n> powered at all times or change the behaviour so that controls can be\n> accessed when the power is off.\n>\n> The best option would be to convert the driver to use runtime PM.\nYes, I agree with you.\nI also noticed there are a lot of things needed to improve except for \nit, such as the platform data via device tree.\nI would like do it in another patch set. I will continue to work on it.\n> An example of this can be found in drivers/media/i2c/ov13858.c .\nA good example, thank you for your providing.\n>\n> On Mon, Sep 18, 2017 at 02:45:14PM +0800, Wenyou Yang wrote:\n>> Add the s_power operation which is responsible for manipulating the\n>> power dowm mode through the PWDN pin and the reset operation through\n>> the RESET pin.\n>>\n>> Signed-off-by: Wenyou Yang \n>> ---\n>>\n>> Changes in v4: None\n>> Changes in v3: None\n>> Changes in v2:\n>> - Add the patch to support the get_fmt ops.\n>> - Remove the redundant invoking ov7670_init_gpio().\n>>\n>> drivers/media/i2c/ov7670.c | 32 +++++++++++++++++++++++++++-----\n>> 1 file changed, 27 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c\n>> index 456f48057605..304abc769a67 100644\n>> --- a/drivers/media/i2c/ov7670.c\n>> +++ b/drivers/media/i2c/ov7670.c\n>> @@ -1542,6 +1542,22 @@ static int ov7670_s_register(struct v4l2_subdev *sd, const struct v4l2_dbg_regis\n>> }\n>> #endif\n>> \n>> +static int ov7670_s_power(struct v4l2_subdev *sd, int on)\n>> +{\n>> +\tstruct ov7670_info *info = to_state(sd);\n>> +\n>> +\tif (info->pwdn_gpio)\n>> +\t\tgpiod_direction_output(info->pwdn_gpio, !on);\n>> +\tif (on && info->resetb_gpio) {\n>> +\t\tgpiod_set_value(info->resetb_gpio, 1);\n>> +\t\tusleep_range(500, 1000);\n>> +\t\tgpiod_set_value(info->resetb_gpio, 0);\n>> +\t\tusleep_range(3000, 5000);\n>> +\t}\n>> +\n>> +\treturn 0;\n>> +}\n>> +\n>> static void ov7670_get_default_format(struct v4l2_subdev *sd,\n>> \t\t\t\t struct v4l2_mbus_framefmt *format)\n>> {\n>> @@ -1575,6 +1591,7 @@ static const struct v4l2_subdev_core_ops ov7670_core_ops = {\n>> \t.g_register = ov7670_g_register,\n>> \t.s_register = ov7670_s_register,\n>> #endif\n>> +\t.s_power = ov7670_s_power,\n>> };\n>> \n>> static const struct v4l2_subdev_video_ops ov7670_video_ops = {\n>> @@ -1692,23 +1709,25 @@ static int ov7670_probe(struct i2c_client *client,\n>> \tif (ret)\n>> \t\treturn ret;\n>> \n>> -\tret = ov7670_init_gpio(client, info);\n>> -\tif (ret)\n>> -\t\tgoto clk_disable;\n>> -\n>> \tinfo->clock_speed = clk_get_rate(info->clk) / 1000000;\n>> \tif (info->clock_speed < 10 || info->clock_speed > 48) {\n>> \t\tret = -EINVAL;\n>> \t\tgoto clk_disable;\n>> \t}\n>> \n>> +\tret = ov7670_init_gpio(client, info);\n>> +\tif (ret)\n>> +\t\tgoto clk_disable;\n>> +\n>> +\tov7670_s_power(sd, 1);\n>> +\n>> \t/* Make sure it's an ov7670 */\n>> \tret = ov7670_detect(sd);\n>> \tif (ret) {\n>> \t\tv4l_dbg(1, debug, client,\n>> \t\t\t\"chip found @ 0x%x (%s) is not an ov7670 chip.\\n\",\n>> \t\t\tclient->addr << 1, client->adapter->name);\n>> -\t\tgoto clk_disable;\n>> +\t\tgoto power_off;\n>> \t}\n>> \tv4l_info(client, \"chip found @ 0x%02x (%s)\\n\",\n>> \t\t\tclient->addr << 1, client->adapter->name);\n>> @@ -1787,6 +1806,8 @@ static int ov7670_probe(struct i2c_client *client,\n>> #endif\n>> hdl_free:\n>> \tv4l2_ctrl_handler_free(&info->hdl);\n>> +power_off:\n>> +\tov7670_s_power(sd, 0);\n>> clk_disable:\n>> \tclk_disable_unprepare(info->clk);\n>> \treturn ret;\n>> @@ -1804,6 +1825,7 @@ static int ov7670_remove(struct i2c_client *client)\n>> #if defined(CONFIG_MEDIA_CONTROLLER)\n>> \tmedia_entity_cleanup(&info->sd.entity);\n>> #endif\n>> +\tov7670_s_power(sd, 0);\n>> \treturn 0;\n>> }\n>> \n>> -- \n>> 2.13.0\n>>\n\nBest Regards,\nWenyou Yang","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"coNDfpx+\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"le9aWQC9\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgdj515yz9s7g\n\tfor ;\n\tMon, 18 Sep 2017 19:27:37 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtsKz-00049j-Kx; Mon, 18 Sep 2017 09:27:33 +0000","from casper.infradead.org ([85.118.1.10])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtsKL-0003nv-98 for linux-arm-kernel@bombadil.infradead.org;\n\tMon, 18 Sep 2017 09:26:53 +0000","from esa4.microchip.iphmx.com ([68.232.154.123])\n\tby casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtsKF-0008D3-FT for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 09:26:50 +0000","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa4.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t18 Sep 2017 02:26:22 -0700","from [10.160.137.68] (10.10.76.4) by chn-sv-exch05.mchp-main.com\n\t(10.10.76.106) with Microsoft SMTP Server id 14.3.352.0;\n\tMon, 18 Sep 2017 02:26:21 -0700"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=jUzIniIHdd9ReN8laADedY92qvTk0U2ot33XfBsvo34=;\n\tb=coNDfpx+YA1Yhg+GLllOYyslv\n\tzbYVBPuXe0v1yE3cclFU8KyMt+LxWDUPeSzExp+nAr7fGWRG16g6ziolJtBfAlJ5xRb49PZE6M2u+\n\taA9IAh5X361IjNxF7Uqp0V2Jy7BJCTN2q8o6fZiivWgtmcarsPZ3Qp6Dlji/2h/6YdV/US9Hq01TC\n\tQvEyBv/kdYJ3CaKdWNKg7XL4pgdsRhJ626JrC6oRhmr4wEq9ryFAFpT9b4/1m8QveUINL9lh1Vd6C\n\tR/Ls8X8o/jQcMGprROkfrOcWWDSJG5LsDp4WC1p+kWGtsduKitc5hqaork6jUd1PkuuZN7lclu47j\n\t940xAQymA==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=casper.20170209;\n\th=Content-Transfer-Encoding:Content-Type:\n\tIn-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender\n\t:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:\n\tList-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=c8aqGdtMWZczp30MP/bfGctJpcdRVSUNNUBrT2mx+eo=;\n\tb=le9aWQC97z8MYabNNsqrGiW9GL\n\tCMwidQfCz9DTlvxgVBmIJf20PEQLQEH7cVPE2rrhDKLHHp93XPvaGdMVrSSglCK0CUlv0XeVHJCOn\n\tc6pAAE8B/lH+paNbP8bA3azhH5zpqpnpRqHDkJ2N7RQl78Atz26TVjEemy1sOFj8F2z6oRvnw2OMd\n\tEthHnbyFMf/xJR5m/f0IzT3ZpnlwJfcGn27ZEdK53uihdqAq8qUls4Sw6ibnEf1aDd8+EtDGxHmli\n\tEuYfkd/o09JHd9rnj6E0+3itjBPH8ZfHtn0r7DYqWlh9lOdmnQXJe2mDlcWkdDEd/Nqy1HpK8v3Dk\n\tjpj3CrfQ==;"],"X-IronPort-AV":"E=Sophos;i=\"5.42,412,1500966000\"; d=\"scan'208\";a=\"6896181\"","Subject":"Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation","To":"Sakari Ailus ","References":"<20170918064514.6841-1-wenyou.yang@microchip.com>\n\t<20170918064514.6841-4-wenyou.yang@microchip.com>\n\t<20170918073529.wssxfbgfwgd2jzpl@valkosipuli.retiisi.org.uk>","From":"\"Yang, Wenyou\" ","Message-ID":"","Date":"Mon, 18 Sep 2017 17:26:16 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918073529.wssxfbgfwgd2jzpl@valkosipuli.retiisi.org.uk>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_102647_973813_CB49024E ","X-CRM114-Status":"GOOD ( 28.52 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on casper.infradead.org summary:\n\tContent analysis details: (-2.6 points, 5.0 required)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.154.123 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jonathan Corbet , linux-kernel@vger.kernel.org,\n\tMauro Carvalho Chehab ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tLinux Media Mailing List ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1770158,"web_url":"http://patchwork.ozlabs.org/comment/1770158/","msgid":"<20170918132649.njqvbs3zq6b5iuej@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-18T13:26:49","subject":"Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"Hi Wenyou,\n\nOn Mon, Sep 18, 2017 at 05:26:16PM +0800, Yang, Wenyou wrote:\n> Hi Sakari,\n> \n> \n> On 2017/9/18 15:35, Sakari Ailus wrote:\n> > Hi Wenyou,\n> > \n> > Thanks for the update.\n> > \n> > The driver exposes controls that are accessible through the sub-device node\n> > even if the device hasn't been powered on.\n> > \n> > Many ISP and bridge drivers will also power the sensor down once the last\n> > user of the user space device nodes disappears. You could keep the device\n> > powered at all times or change the behaviour so that controls can be\n> > accessed when the power is off.\n> > \n> > The best option would be to convert the driver to use runtime PM.\n> Yes, I agree with you.\n> I also noticed there are a lot of things needed to improve except for it,\n> such as the platform data via device tree.\n> I would like do it in another patch set. I will continue to work on it.\n\nAdding runtime PM support later on sound good to me.\n\n> > An example of this can be found in drivers/media/i2c/ov13858.c .\n> A good example, thank you for your providing.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"adc/CYWp\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwmyH6XcFz9s3w\n\tfor ;\n\tMon, 18 Sep 2017 23:27:19 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtw4y-00032f-Fb; Mon, 18 Sep 2017 13:27:16 +0000","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]\n\thelo=hillosipuli.retiisi.org.uk)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtw4u-0002yh-AN for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 13:27:14 +0000","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 737ED60103;\n\tMon, 18 Sep 2017 16:26:50 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dtw4X-0004wq-Ue; Mon, 18 Sep 2017 16:26:50 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=n+4ijwfX29IST9A1g4Zo43F3y84IOA7PeNUzX280BTo=;\n\tb=adc/CYWp/bwNRd\n\tJXO1aCrlffyjuUT63N/cDDujGS8YqPj7Y/2Opm4qC/KHSqEb2Gg9Z/cjJNqPpq3n8m9wYGw1coGBh\n\t6dWOH3fQZTxOWGWjb5o/S5qtF8a2exm0ThPfaBVm3S9OgNXHQ4aNssu9cRxXrIdbfIjXwLIVF4NUh\n\ttvhjJBuBQWhQA8AlZa6TL7iAJnMhU0C59DuxQfcD58I/KTdDq2TUx8V+nn6MugwAfzQEl+JZdy2JR\n\t+WMRWsOr85UvYqltfUSxJn5nG2WzX4YRC795sBuu1rHnpzNFCAtEt53trreu3d8+iD3kMWB1b8bMO\n\tvCn1wUPMsybncLhIAjdg==;","Date":"Mon, 18 Sep 2017 16:26:49 +0300","From":"Sakari Ailus ","To":"\"Yang, Wenyou\" ","Subject":"Re: [PATCH v4 3/3] media: ov7670: Add the s_power operation","Message-ID":"<20170918132649.njqvbs3zq6b5iuej@valkosipuli.retiisi.org.uk>","References":"<20170918064514.6841-1-wenyou.yang@microchip.com>\n\t<20170918064514.6841-4-wenyou.yang@microchip.com>\n\t<20170918073529.wssxfbgfwgd2jzpl@valkosipuli.retiisi.org.uk>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_062712_573332_F4783B49 ","X-CRM114-Status":"GOOD ( 16.56 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [83.145.211.213 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Jonathan Corbet , linux-kernel@vger.kernel.org,\n\tMauro Carvalho Chehab ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tLinux Media Mailing List ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]