[{"id":1769843,"web_url":"http://patchwork.ozlabs.org/comment/1769843/","msgid":"<150570414426.36.7011523692059086347@69b6ddf88678>","list_archive_url":null,"date":"2017-09-18T03:09:04","subject":"Re: [Qemu-devel] [PATCH v8 00/13] tests: Add VM based build tests\n\t(for non-x86_64 and/or non-Linux)","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nSubject: [Qemu-devel] [PATCH v8 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)\nMessage-id: 20170918024402.3265-1-famz@redhat.com\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nSwitched to a new branch 'test'\neada89cb49 docker: Use archive-source.py\nedb516101b tests: Add README for vm tests\n29ab56eed6 MAINTAINERS: Add tests/vm entry\n91bbe52a91 Makefile: Add rules to run vm tests\n850be050ce tests: Add OpenBSD image\n793d0cde6b tests: Add NetBSD image\n4fcfdb2879 tests: Add FreeBSD image\n0186cba9b3 tests: Add ubuntu.i386 image\n2cc2c41291 tests: Add vm test lib\nc6a859d5de tests: Add a test key pair\nffc8ca2de4 scripts: Add archive-source.sh\n0df34534b9 qemu.py: Add \"wait()\" method\n7ed9b96668 gitignore: Ignore vm test images\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/13: gitignore: Ignore vm test images...\nChecking PATCH 2/13: qemu.py: Add \"wait()\" method...\nChecking PATCH 3/13: scripts: Add archive-source.sh...\nChecking PATCH 4/13: tests: Add a test key pair...\nChecking PATCH 5/13: tests: Add vm test lib...\nWARNING: line over 80 characters\n#71: FILE: tests/vm/basevm.py:46:\n+ self._tmpdir = tempfile.mkdtemp(prefix=\"vm-test-\", suffix=\".tmp\", dir=\".\")\n\nWARNING: line over 80 characters\n#162: FILE: tests/vm/basevm.py:137:\n+ logging.debug(\"Creating archive %s for src_dir dir: %s\", tarfile, src_dir)\n\nWARNING: line over 80 characters\n#167: FILE: tests/vm/basevm.py:142:\n+ \"file=%s,if=none,id=%s,cache=writeback,format=raw\" % \\\n\nWARNING: line over 80 characters\n#170: FILE: tests/vm/basevm.py:145:\n+ \"virtio-blk,drive=%s,serial=%s,bootindex=1\" % (name, name)]\n\nERROR: line over 90 characters\n#225: FILE: tests/vm/basevm.py:200:\n+ VM test utility. Exit codes: 0 = success, 1 = command line error, 2 = environment initialization failed, 3 = test command failed\"\"\")\n\nWARNING: line over 80 characters\n#232: FILE: tests/vm/basevm.py:207:\n+ parser.add_option(\"--jobs\", type=int, default=multiprocessing.cpu_count() / 2,\n\ntotal: 1 errors, 5 warnings, 256 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 6/13: tests: Add ubuntu.i386 image...\nChecking PATCH 7/13: tests: Add FreeBSD image...\nChecking PATCH 8/13: tests: Add NetBSD image...\nChecking PATCH 9/13: tests: Add OpenBSD image...\nChecking PATCH 10/13: Makefile: Add rules to run vm tests...\nChecking PATCH 11/13: MAINTAINERS: Add tests/vm entry...\nChecking PATCH 12/13: tests: Add README for vm tests...\nChecking PATCH 13/13: docker: Use archive-source.py...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwWFy13G9z9s4q\n\tfor ;\n\tMon, 18 Sep 2017 13:09:54 +1000 (AEST)","from localhost ([::1]:34430 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtmRU-0001Ba-KE\n\tfor incoming@patchwork.ozlabs.org; Sun, 17 Sep 2017 23:09:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40874)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtmR4-0001BL-Fj\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 23:09:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtmR0-0002eV-D2\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 23:09:26 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21356)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtmR0-0002da-5h\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 23:09:22 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1505704144988411.3716052640211;\n\tSun, 17 Sep 2017 20:09:04 -0700 (PDT)"],"Resent-Date":"Sun, 17 Sep 2017 23:09:26 -0400","Resent-Message-Id":"","In-Reply-To":"<20170918024402.3265-1-famz@redhat.com>","Message-ID":"<150570414426.36.7011523692059086347@69b6ddf88678>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"famz@redhat.com","Date":"Sun, 17 Sep 2017 20:09:04 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v8 00/13] tests: Add VM based build tests\n\t(for non-x86_64 and/or non-Linux)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org, famz@redhat.com, f4bug@amsat.org,\n\tqemu-devel@nongnu.org, kamil@netbsd.org, stefanha@redhat.com,\n\tcrosa@redhat.com, pbonzini@redhat.com, alex.bennee@linaro.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]