[{"id":1769823,"web_url":"http://patchwork.ozlabs.org/comment/1769823/","msgid":"<150569180005.36.9005014267144366755@69b6ddf88678>","list_archive_url":null,"date":"2017-09-17T23:43:20","subject":"Re: [Qemu-devel] [PATCH v3 0/6] QOMify MIPS cpu","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nSubject: [Qemu-devel] [PATCH v3 0/6] QOMify MIPS cpu\nMessage-id: 20170917232010.14183-1-f4bug@amsat.org\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nSwitched to a new branch 'test'\ne822fe0c5d mips: replace cpu_mips_init() with cpu_generic_init()\n496f38ac4a mips: MIPSCPU model subclasses\ne8855206ec mips: call cpu_mips_realize_env() from mips_cpu_realizefn()\ne9ec165d39 mips: split cpu_mips_realize_env() out of cpu_mips_init()\n2923193832 mips: introduce internal.h and cleanup cpu.h\n146f4059ea mips: move hw/mips/cputimer.c to target/mips/\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/6: mips: move hw/mips/cputimer.c to target/mips/...\nChecking PATCH 2/6: mips: introduce internal.h and cleanup cpu.h...\nERROR: space prohibited after that '&' (ctx:WxW)\n#728: FILE: target/mips/internal.h:230:\n+ if ((env->CP0_VPControl >> CP0VPCtl_DIS) & 1) {\n ^\n\nERROR: space prohibited after that '&' (ctx:WxW)\n#736: FILE: target/mips/internal.h:238:\n+ ((other_cpu->env.CP0_VPControl >> CP0VPCtl_DIS) & 1)) {\n ^\n\nERROR: space prohibited after that '&' (ctx:WxW)\n#756: FILE: target/mips/internal.h:258:\n+ env->hflags |= (env->CP0_Status >> CP0St_KSU) & MIPS_HFLAG_KSU;\n ^\n\ntotal: 3 errors, 0 warnings, 842 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 3/6: mips: split cpu_mips_realize_env() out of cpu_mips_init()...\nChecking PATCH 4/6: mips: call cpu_mips_realize_env() from mips_cpu_realizefn()...\nChecking PATCH 5/6: mips: MIPSCPU model subclasses...\nChecking PATCH 6/6: mips: replace cpu_mips_init() with cpu_generic_init()...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwQjG2hwSz9s7c\n\tfor ;\n\tMon, 18 Sep 2017 09:44:49 +1000 (AEST)","from localhost ([::1]:34019 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtjEz-0003Dm-0H\n\tfor incoming@patchwork.ozlabs.org; Sun, 17 Sep 2017 19:44:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51335)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtjEV-000371-M1\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:44:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtjEQ-00063P-Rf\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:44:15 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21390)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtjEQ-00061a-Kg\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 19:44:10 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1505691800845794.9785175781994;\n\tSun, 17 Sep 2017 16:43:20 -0700 (PDT)"],"Resent-Date":"Sun, 17 Sep 2017 19:44:15 -0400","Resent-Message-Id":"","In-Reply-To":"<20170917232010.14183-1-f4bug@amsat.org>","Message-ID":"<150569180005.36.9005014267144366755@69b6ddf88678>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"f4bug@amsat.org","Date":"Sun, 17 Sep 2017 16:43:20 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v3 0/6] QOMify MIPS cpu","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"thuth@redhat.com, james.hogan@imgtec.com, famz@redhat.com,\n\tehabkost@redhat.com, f4bug@amsat.org, qemu-devel@nongnu.org,\n\tmarcel@redhat.com, hpoussin@reactos.org, yongbok.kim@imgtec.com,\n\timammedo@redhat.com, aurelien@aurel32.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]