[{"id":1772248,"web_url":"http://patchwork.ozlabs.org/comment/1772248/","msgid":"<20170920211413.GA36148@dtor-ws>","list_archive_url":null,"date":"2017-09-20T21:14:13","subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"On Wed, Sep 20, 2017 at 03:53:01PM -0500, Rob Herring wrote:\n> On Sun, Sep 17, 2017 at 04:00:49PM +0800, Chen Zhong wrote:\n> > This patch adds the device tree binding documentation for the MediaTek\n> > pmic keys found on PMIC MT6397/MT6323.\n> > \n> > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>\n> > ---\n> >  .../devicetree/bindings/input/mtk-pmic-keys.txt    |   41 ++++++++++++++++++++\n> >  1 file changed, 41 insertions(+)\n> >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > new file mode 100644\n> > index 0000000..fd48ff7\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > @@ -0,0 +1,41 @@\n> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> > +\n> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> > +and homekey. The key functions are defined as the subnode of the function\n> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> > +of Muti-Function Device (MFD)\n> > +\n> > +For MT6397/MT6323 MFD bindings see:\n> > +Documentation/devicetree/bindings/mfd/mt6397.txt\n> > +\n> > +Required properties:\n> > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> > +- linux,keycodes: Specifies the numeric keycode values to\n> > +\tbe used for reporting keys presses. The array can\n> > +\tcontain up to 2 entries.\n> > +\n> > +Optional Properties:\n> > +- mediatek,wakeup-keys: Specifies each key can be used as a wakeup source\n> > +\tor not. This can be customized depends on board design.\n> \n> I think this should be a common property if we're going to put into DT. \n> Something like \"wakeup-scancodes\" to be clear the values are the raw \n> scancodes. Alternatively, we could list Linux keycodes instead with \n> something like \"linux,wakeup-keycodes\".\n\nShould we go the gpio-keys way and describe keys as sub-nodes, possibly\nusing address as index?\n\n\t\tmt6397keys: mt6397keys {\n\t\t\t...\n\n\t\t\tpower@0 {\n\t\t\t\tlinux,code = <116>;\n\t\t\t\twakeup-source;\n\t\t\t};\n\n\t\t\thome@1 {\n\t\t\t\tlinux,code = <...>;\n\t\t\t};\n\t\t};\n\nThanks.","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"WR3NoAik\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"B1WgD9yW\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyCDh54hlz9s8J\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 07:14:44 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dumKO-0003zh-Ug; Wed, 20 Sep 2017 21:14:40 +0000","from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dumKM-0003wq-0u; Wed, 20 Sep 2017 21:14:39 +0000","by mail-pf0-x241.google.com with SMTP id a7so1642513pfj.5;\n\tWed, 20 Sep 2017 14:14:17 -0700 (PDT)","from dtor-ws ([2620:0:1000:1611:9cd6:fc06:bad5:847])\n\tby smtp.gmail.com with ESMTPSA id\n\tp85sm9920997pfj.47.2017.09.20.14.14.15\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tWed, 20 Sep 2017 14:14:16 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ZOuokDmbEa6JAui/PmbY+WtzkEZ8dvZ00KEBVNpS1UI=;\n\tb=WR3NoAikGZ6aM3\n\tkDnOokyQ74uufSvowRETkGA7AEI9g5NIlsR3dnr/uh9jDDy4QT1uogAzTKJeriOZV//ZVJvmD2q4r\n\tOeF6t/TMO6lCeoEJcSRta1Uv02Yj9mSTCvS0Jmztk3ytyqoqtGZ31uRUjAku+/azi20HPaqmImMPA\n\tr+ytzqtXl+gLp58jzWIsWARZ6Nq2dtB0/nQGR/3jFWaZD37OECVcQ5sKWizG7p/KfbJsmotgNRr66\n\teCQng0glFOaTOayCmGOhaIrp1OotvQb7w8dXV02+HqkIdd0wgjVRvAMiBEFXyRFtXvPCqFg+ypgcQ\n\tQVQsK0inuOUmayCSQylA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=7plhGDW4S9Ri0Gsa+TgknLsDNPeO5iboDzjAeH7OTPs=;\n\tb=B1WgD9yWaNjdYpM6pPnvffWMpecEQmKt4CndkGunAojgiEr1B0SfRY92leesgN2BP5\n\tIAPGJP5vMkbYrTSEg3NOEdh8Ipn5NgRtJHlRKrQLxXQ8SRozUB0oT3LZ8mI1BsJR+yW6\n\tc1dQSO1P6QwjkJkWrIpZvLfRL4yJwhjI6TMg4LU7RPWenaoMC8uuvkr3mxrdeKdttNgW\n\t805Q+6IUuOammBmwziy58gMw6g30KySSYpw4dSbkd0JsSfiX9SRqhhTakht0O8ii5pcl\n\t9V8mswGTgtfjN8RDp4Vo3WsUZF4ugc3vVrAca/LDV1N6VqZO6rRu0a+cZ4D5qn0YRFPK\n\tLEgw=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=7plhGDW4S9Ri0Gsa+TgknLsDNPeO5iboDzjAeH7OTPs=;\n\tb=dVN2PFiPmruClcLuGl+M1ePRSRt3ttEqAqBdeBiBSUhZIox7OkQWIgSQXSsdG7SRQB\n\tt3gMUHM67ZCejIKam3ewFJEv8uXjSqxDzmGPHc4VHbahEttg5q0cKfZWbktZaV2jn0T4\n\tQXEVVhKXskFLmZmq5e8g6NEGEoHYzUnGct09pptgOPgswC+D7DNL8I36/DCitqJ508st\n\tplcBtzeRwt5WXieVOoViOMGf8dE/mQsnwMzWi3Z3bNKgXWB84ZM96TktcUmSke7yxkuO\n\tnc8xB9EDhZnhpJNqzZzpmELWxlTDkxJwJ6OfrNkNCWsdIISszlcztaGx5ciWfM21baR8\n\tlXSw==","X-Gm-Message-State":"AHPjjUguEGurng/d+vlm1cZVhI0X7EiGyh9/RMNJGv/ge44XT49s4HN2\n\tDJIvBSyjKTdpQFLfW56RHo0=","X-Google-Smtp-Source":"AOwi7QDi7AiBmErqwVsjKjR0F1VgtUvuZ3MYqI9h7ldhDOki/wvI7fwlZ8NwyeGAQD2WDhOid3cp8g==","X-Received":"by 10.98.102.149 with SMTP id s21mr3421739pfj.294.1505942056717; \n\tWed, 20 Sep 2017 14:14:16 -0700 (PDT)","Date":"Wed, 20 Sep 2017 14:14:13 -0700","From":"Dmitry Torokhov <dmitry.torokhov@gmail.com>","To":"Rob Herring <robh@kernel.org>","Subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","Message-ID":"<20170920211413.GA36148@dtor-ws>","References":"<1505635252-27716-1-git-send-email-chen.zhong@mediatek.com>\n\t<1505635252-27716-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_141438_114176_2582A7EA ","X-CRM114-Status":"GOOD (  18.75  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:241 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (dmitry.torokhov[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>, devicetree@vger.kernel.org, \n\tChen Zhong <chen.zhong@mediatek.com>,\n\tLinus Walleij <linus.walleij@linaro.org>, \n\tJaechul Lee <jcsing.lee@samsung.com>, linux-kernel@vger.kernel.org,\n\tAndi Shyti <andi.shyti@samsung.com>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tKrzysztof Kozlowski <krzk@kernel.org>, linux-input@vger.kernel.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-mediatek@lists.infradead.org, \n\tEddie Huang <eddie.huang@mediatek.com>,\n\tLee Jones <lee.jones@linaro.org>, \n\tlinux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1772278,"web_url":"http://patchwork.ozlabs.org/comment/1772278/","msgid":"<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-20T20:53:01","subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sun, Sep 17, 2017 at 04:00:49PM +0800, Chen Zhong wrote:\n> This patch adds the device tree binding documentation for the MediaTek\n> pmic keys found on PMIC MT6397/MT6323.\n> \n> Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>\n> ---\n>  .../devicetree/bindings/input/mtk-pmic-keys.txt    |   41 ++++++++++++++++++++\n>  1 file changed, 41 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> \n> diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> new file mode 100644\n> index 0000000..fd48ff7\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> @@ -0,0 +1,41 @@\n> +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> +\n> +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> +and homekey. The key functions are defined as the subnode of the function\n> +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> +of Muti-Function Device (MFD)\n> +\n> +For MT6397/MT6323 MFD bindings see:\n> +Documentation/devicetree/bindings/mfd/mt6397.txt\n> +\n> +Required properties:\n> +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> +- linux,keycodes: Specifies the numeric keycode values to\n> +\tbe used for reporting keys presses. The array can\n> +\tcontain up to 2 entries.\n> +\n> +Optional Properties:\n> +- mediatek,wakeup-keys: Specifies each key can be used as a wakeup source\n> +\tor not. This can be customized depends on board design.\n\nI think this should be a common property if we're going to put into DT. \nSomething like \"wakeup-scancodes\" to be clear the values are the raw \nscancodes. Alternatively, we could list Linux keycodes instead with \nsomething like \"linux,wakeup-keycodes\".\n\n> +- wakeup-source: PMIC keys can be used as wakeup sources.\n\nJust \"See ../power/wakeup-source.txt\" for the description.\n\n> +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n> +\tpwrkey only, 2 for pwrkey/homekey together, others for disabled.\n> +- debounce-interval: Long press key shutdown debouncing interval time\n> +\tin seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n\nThis property units should be in milliseconds. However, this doesn't \nsound like debounce filtering time if 5-14 seconds. That sounds like \nforced power off time (i.e. for a hung device). This also should be \ncommon. I imagine we already have some drivers with similar properties.\n\nRob","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"A56EsE0u\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"baquTU9M\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyD1m0sjFz9s7c\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 07:50:20 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dumsp-00047F-Cs; Wed, 20 Sep 2017 21:50:15 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dumrq-0002cI-Kk; Wed, 20 Sep 2017 21:49:14 +0000","from mail-pf0-f194.google.com ([209.85.192.194])\n\tby merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dulzq-0007MJ-Bs; Wed, 20 Sep 2017 20:53:28 +0000","by mail-pf0-f194.google.com with SMTP id e69so1624649pfg.4;\n\tWed, 20 Sep 2017 13:53:04 -0700 (PDT)","from localhost ([2620:0:1000:fd28:e83d:5428:912b:b325])\n\tby smtp.gmail.com with ESMTPSA id\n\ti87sm8919948pfi.184.2017.09.20.13.53.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 13:53:02 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=OcnLmvzX/J2B4hJKiytNFP0CKiqMepif1NP5gfd4hfE=;\n\tb=A56EsE0ugxB/w0\n\tQAHtGxXVhT3Ije2pFzxa8MfkhuW8wQL5xiqBYX2KtXPy5M+Yo0yhZgboCIHbtbflDXcg0dSlG1tZR\n\tUZSjZuQdsZgG2eey2YNkR2Dqi9rNpAAyYLtuNah/S5pY9lPNCSq4PndaQX0aW0/W96u6v+S+F6GlM\n\t6gKxxnsdVZxrScTpms5rvBJpWsYiYCTvNH3oqEwoONLlEaHU7miCx45MsotSfAjb9VZGwP7GIKJ8s\n\tmrmv/KGp1qq0h6koD+oLu2IMA8rmbecfm0YMAcbO5xG7FZBJnbbpP7Zzz4COdoZpZatiUG+SMFdmh\n\tPbf27b3TOuL5A4Ri8IqA==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209;\n\th=In-Reply-To:Content-Type:MIME-Version:\n\tReferences:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=p7rzwOwz+PPIcNUy2nd32crkSVDz+lLk9lRY5wQag+s=;\n\tb=baquTU9M0Yj9SoB/WmUQpgUQH\n\tKEL6nC6jB5TOuAqLTeK26wRCEqD82L+Dd8TNE9SXBSlkfdRqzjLPIACUrOfrLAz13KxCw5CXrGFWd\n\t8fHbqF5Ihy9bceFemkLSFWLqAElvzc4K/u9eCy5C7Z44V+l5bIXNfWdCUMt2Af4PFx/0qmjhvDLj5\n\tRshyb1+EdxmJ8/R+OJCM59k69GNUHLa0mel4aAQnSCF8ch54kEXY4hsjicp50mzvK7/QZOfFUp9l2\n\txKlyRizaaC0HTWGfB/U76Gft8WL4UYiEH9DP8KKkwobdrs1/qff/sGVxgXB0XA0KxNy1f9b5a9SKb\n\t+fKOx1X/A==;"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=p7rzwOwz+PPIcNUy2nd32crkSVDz+lLk9lRY5wQag+s=;\n\tb=F4kydUvhJ7n4laK79xGBmqVuOMMDuEmal6i7iynu9Gqww4Bxb+86p/ZUoV/aNLvJqI\n\tlDflp/LBsoBg2Wr+hgRxzVjsXNCuPTf4JXSEfV9kC9n7OEpfxT3GJbHRW3smTizjRtwX\n\tQbOjY6Wcv1Ct/r1255Z0LtJj56wkRMksCpFSM6ISIakzA7gp+0sYwnWtvFRrIhsTsatz\n\tgC+u2hZD4IOT28+N6aNGdLqbkzL01nRiTDuEvMCNR82skLAOtW9XkRwxTzXrNYjCcst0\n\tnIrMdd3ZPWtAMD/fnnQO6epzA6x4ZCu1YIPVl+ssntSPQbP1rLaLmfGJ25EgDt4REeQF\n\taUHg==","X-Gm-Message-State":"AHPjjUhrDEyLQgIdVLOzWmu7e2+DIn6nu+fDOtLn6PVM6gFqKMphX8zC\n\t4hW/dVJ9G36zajYyjejNqg==","X-Google-Smtp-Source":"AOwi7QA1LCd1aDDBo93LxknMyC4rD3BPxLhxFrIanYqLHX4lVgBGlRICmyT0CQD+rpMobWZg+sqapg==","X-Received":"by 10.98.53.196 with SMTP id c187mr3497152pfa.38.1505940783280; \n\tWed, 20 Sep 2017 13:53:03 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:53:01 -0500","From":"Rob Herring <robh@kernel.org>","To":"Chen Zhong <chen.zhong@mediatek.com>","Subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","Message-ID":"<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>","References":"<1505635252-27716-1-git-send-email-chen.zhong@mediatek.com>\n\t<1505635252-27716-3-git-send-email-chen.zhong@mediatek.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1505635252-27716-3-git-send-email-chen.zhong@mediatek.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-3.8 (---)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details:   (-3.8 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.5 RCVD_IN_SORBS_SPAM     RBL: SORBS: sender is a spam source\n\t[209.85.192.194 listed in dnsbl.sorbs.net]\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [209.85.192.194 listed in list.dnswl.org]\n\t-2.8 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)\n\t[209.85.192.194 listed in wl.mailspike.net]\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (robherring2[at]gmail.com)\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (robherring2[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tJaechul Lee <jcsing.lee@samsung.com>, \n\tdevicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, \n\tDmitry Torokhov <dmitry.torokhov@gmail.com>,\n\tlinux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tKrzysztof Kozlowski <krzk@kernel.org>, linux-input@vger.kernel.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-mediatek@lists.infradead.org, \n\tEddie Huang <eddie.huang@mediatek.com>,\n\tLee Jones <lee.jones@linaro.org>, \n\tlinux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773989,"web_url":"http://patchwork.ozlabs.org/comment/1773989/","msgid":"<1506148695.19409.10.camel@mhfsdcap03>","list_archive_url":null,"date":"2017-09-23T06:38:15","subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":72090,"url":"http://patchwork.ozlabs.org/api/people/72090/","name":"Chen Zhong","email":"chen.zhong@mediatek.com"},"content":"On Wed, 2017-09-20 at 15:53 -0500, Rob Herring wrote:\n> On Sun, Sep 17, 2017 at 04:00:49PM +0800, Chen Zhong wrote:\n> > This patch adds the device tree binding documentation for the MediaTek\n> > pmic keys found on PMIC MT6397/MT6323.\n> > \n> > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>\n> > ---\n> >  .../devicetree/bindings/input/mtk-pmic-keys.txt    |   41 ++++++++++++++++++++\n> >  1 file changed, 41 insertions(+)\n> >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > new file mode 100644\n> > index 0000000..fd48ff7\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > @@ -0,0 +1,41 @@\n> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> > +\n> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> > +and homekey. The key functions are defined as the subnode of the function\n> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> > +of Muti-Function Device (MFD)\n> > +\n> > +For MT6397/MT6323 MFD bindings see:\n> > +Documentation/devicetree/bindings/mfd/mt6397.txt\n> > +\n> > +Required properties:\n> > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> > +- linux,keycodes: Specifies the numeric keycode values to\n> > +\tbe used for reporting keys presses. The array can\n> > +\tcontain up to 2 entries.\n> > +\n> > +Optional Properties:\n> > +- mediatek,wakeup-keys: Specifies each key can be used as a wakeup source\n> > +\tor not. This can be customized depends on board design.\n> \n> I think this should be a common property if we're going to put into DT. \n> Something like \"wakeup-scancodes\" to be clear the values are the raw \n> scancodes. Alternatively, we could list Linux keycodes instead with \n> something like \"linux,wakeup-keycodes\".\n> \n> > +- wakeup-source: PMIC keys can be used as wakeup sources.\n> \n> Just \"See ../power/wakeup-source.txt\" for the description.\n> \n> > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n> > +\tpwrkey only, 2 for pwrkey/homekey together, others for disabled.\n> > +- debounce-interval: Long press key shutdown debouncing interval time\n> > +\tin seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n> \n> This property units should be in milliseconds. However, this doesn't \n> sound like debounce filtering time if 5-14 seconds. That sounds like \n> forced power off time (i.e. for a hung device). This also should be \n> common. I imagine we already have some drivers with similar properties.\n\nHi Rob,\n\nI searched in kernel documents and found a similar usage in\n\"ti,palmas-pwrbutton.txt\"\n\"- ti,palmas-long-press-seconds: Duration in seconds which the power\n  button should be kept pressed for Palmas to power off automatically.\"\n\nCould I just wrote it like this?\nmediatek,long-press-seconds = <0>;\n\nAnd for the wakeup source part, how about Dmitry's suggestion? \nThe whole device node would be:\n\nmt6397keys: mt6397keys {\n\tcompatible = \"mediatek,mt6397-keys\";\n\tmediatek,long-press-mode = <1>;\n\tmediatek,long-press-seconds = <0>;\n\t\n\tpower@0 {\n\t\tlinux,code = <116>;\n\t\twakeup-source;\n\t};\n\n\thome@0 {\n\t\tlinux,code = <114>;\n\t};\n};\n\nThank you.\n\n> \n> Rob","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"LX/g7FTP\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzgfz5v6Cz9tX5\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 16:39:03 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dve5Z-0006sq-Nr; Sat, 23 Sep 2017 06:38:58 +0000","from [210.61.82.184] (helo=mailgw02.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dve5S-0006mT-Br; Sat, 23 Sep 2017 06:38:52 +0000","from mtkexhb01.mediatek.inc [(172.21.101.102)] by\n\tmailgw02.mediatek.com (envelope-from <chen.zhong@mediatek.com>)\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 346689485; Sat, 23 Sep 2017 14:38:17 +0800","from MTKCAS32.mediatek.inc (172.27.4.184) by\n\tmtkmbs08n1.mediatek.inc\n\t(172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1210.3;\n\tSat, 23 Sep 2017 14:37:40 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc\n\t(172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend\n\tTransport; Sat, 23 Sep 2017 14:38:05 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=yV7kWqxmWnztUSlT54YFF2kEK67Ge3Ndfz7YjbC67hc=;\n\tb=LX/g7FTPSH0t1U\n\tfRFcbq7qnYvBIpv2YvrkVy+/S1NoSRcEtXCNy2ln0PSR8B3B/zHWB2O1I3Az6Iw8jrM+B/1nflfSF\n\tX7m/oFp2oBSkbSXAui3PePiznXWx7vqBHbbR0KAm34EVZHsFbwMcUEJK1oMOWk8X6xpUWZOIPUVZb\n\t6r3Fll2UrR4gzpVzbzUW+uDqDG7hE/zLjgDtnlx5D/SHnlLmS29ZDdP5idPmBwdmUvMis1xjB/iR0\n\trJnWOa7vANW55BMCYTLwZVpf717khfwkl9cttS5Iqf4bzU94pOZAbMqB0kgXWZAGPpIE84wirisAA\n\tT0kxbEIwZGepRrD6ixVA==;","X-UUID":"c462223de84c448895455dc5bab6b1ee-20170923","Message-ID":"<1506148695.19409.10.camel@mhfsdcap03>","Subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","From":"Chen Zhong <chen.zhong@mediatek.com>","To":"Rob Herring <robh@kernel.org>","Date":"Sat, 23 Sep 2017 14:38:15 +0800","In-Reply-To":"<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>","References":"<1505635252-27716-1-git-send-email-chen.zhong@mediatek.com>\n\t<1505635252-27716-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_233850_744472_209CDED0 ","X-CRM114-Status":"GOOD (  21.58  )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.1 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tJaechul Lee <jcsing.lee@samsung.com>, \n\tdevicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, \n\tDmitry Torokhov <dmitry.torokhov@gmail.com>,\n\tlinux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tKrzysztof Kozlowski <krzk@kernel.org>, linux-input@vger.kernel.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-mediatek@lists.infradead.org, \n\tEddie Huang <eddie.huang@mediatek.com>,\n\tLee Jones <lee.jones@linaro.org>, \n\tlinux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773993,"web_url":"http://patchwork.ozlabs.org/comment/1773993/","msgid":"<1506149223.19409.11.camel@mhfsdcap03>","list_archive_url":null,"date":"2017-09-23T06:47:03","subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":72090,"url":"http://patchwork.ozlabs.org/api/people/72090/","name":"Chen Zhong","email":"chen.zhong@mediatek.com"},"content":"Sorry for the typo.\n\nOn Sat, 2017-09-23 at 14:38 +0800, Chen Zhong wrote:\n> On Wed, 2017-09-20 at 15:53 -0500, Rob Herring wrote:\n> > On Sun, Sep 17, 2017 at 04:00:49PM +0800, Chen Zhong wrote:\n> > > This patch adds the device tree binding documentation for the MediaTek\n> > > pmic keys found on PMIC MT6397/MT6323.\n> > > \n> > > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>\n> > > ---\n> > >  .../devicetree/bindings/input/mtk-pmic-keys.txt    |   41 ++++++++++++++++++++\n> > >  1 file changed, 41 insertions(+)\n> > >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > > \n> > > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > > new file mode 100644\n> > > index 0000000..fd48ff7\n> > > --- /dev/null\n> > > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> > > @@ -0,0 +1,41 @@\n> > > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> > > +\n> > > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> > > +and homekey. The key functions are defined as the subnode of the function\n> > > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> > > +of Muti-Function Device (MFD)\n> > > +\n> > > +For MT6397/MT6323 MFD bindings see:\n> > > +Documentation/devicetree/bindings/mfd/mt6397.txt\n> > > +\n> > > +Required properties:\n> > > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> > > +- linux,keycodes: Specifies the numeric keycode values to\n> > > +\tbe used for reporting keys presses. The array can\n> > > +\tcontain up to 2 entries.\n> > > +\n> > > +Optional Properties:\n> > > +- mediatek,wakeup-keys: Specifies each key can be used as a wakeup source\n> > > +\tor not. This can be customized depends on board design.\n> > \n> > I think this should be a common property if we're going to put into DT. \n> > Something like \"wakeup-scancodes\" to be clear the values are the raw \n> > scancodes. Alternatively, we could list Linux keycodes instead with \n> > something like \"linux,wakeup-keycodes\".\n> > \n> > > +- wakeup-source: PMIC keys can be used as wakeup sources.\n> > \n> > Just \"See ../power/wakeup-source.txt\" for the description.\n> > \n> > > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n> > > +\tpwrkey only, 2 for pwrkey/homekey together, others for disabled.\n> > > +- debounce-interval: Long press key shutdown debouncing interval time\n> > > +\tin seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n> > \n> > This property units should be in milliseconds. However, this doesn't \n> > sound like debounce filtering time if 5-14 seconds. That sounds like \n> > forced power off time (i.e. for a hung device). This also should be \n> > common. I imagine we already have some drivers with similar properties.\n> \n> Hi Rob,\n> \n> I searched in kernel documents and found a similar usage in\n> \"ti,palmas-pwrbutton.txt\"\n> \"- ti,palmas-long-press-seconds: Duration in seconds which the power\n>   button should be kept pressed for Palmas to power off automatically.\"\n> \n> Could I just wrote it like this?\n> mediatek,long-press-seconds = <0>;\n> \n> And for the wakeup source part, how about Dmitry's suggestion? \n> The whole device node would be:\n> \n> mt6397keys: mt6397keys {\n> \tcompatible = \"mediatek,mt6397-keys\";\n> \tmediatek,long-press-mode = <1>;\n> \tmediatek,long-press-seconds = <0>;\n> \t\n> \tpower@0 {\n> \t\tlinux,code = <116>;\n> \t\twakeup-source;\n> \t};\n> \n> \thome@0 {\nshould be home@1 {\n> \t\tlinux,code = <114>;\n> \t};\n> };\n> \n> Thank you.\n> \n> > \n> > Rob\n>","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"XsTtfmc6\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzgrz1Ysgz9tX5\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 16:47:47 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dveDz-0002oc-VW; Sat, 23 Sep 2017 06:47:39 +0000","from [210.61.82.183] (helo=mailgw01.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dveDu-0002hX-1d; Sat, 23 Sep 2017 06:47:36 +0000","from mtkcas06.mediatek.inc [(172.21.101.30)] by\n\tmailgw01.mediatek.com (envelope-from <chen.zhong@mediatek.com>)\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 1015364596; Sat, 23 Sep 2017 14:47:04 +0800","from MTKCAS36.mediatek.inc (172.27.4.186) by\n\tmtkmbs08n1.mediatek.inc\n\t(172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1210.3;\n\tSat, 23 Sep 2017 14:46:28 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc\n\t(172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend\n\tTransport; Sat, 23 Sep 2017 14:46:12 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ByEFkJKot8njswzo83mprQNeaEr893x0clGZIJ+WDm4=;\n\tb=XsTtfmc6FxJyfA\n\taBg6W+bz11C2d5DeuZOi1iIm2SpN08hv5Y55bQAA9q9AkL2gLqpHfHXn++jNLQZ2RCeTtwL+m2ydo\n\thzdoPiV1t/ji+ruF5bqS65qt5otz82+gFTDR7DSvzDF6e3A+95NAv4rexJLmMV7C/bkDF4Qzv/mPZ\n\tpzPBi5KepC0Ml3P27xxQU7gOMSBqUEcUSU9u91AWGREs3UlfjdzKpQBXocf6h2/QyYIBhfEO226zo\n\tbPG9sgx+EYenvmdU02EdS1Bbj2LpZFexvzwAkZpG5z6fOLtgg4yzjTIUVBXPR+iXbwRuQSPZL8TVB\n\tEShz7MayjFqLiYODcQmw==;","X-UUID":"f46b35281ff74165a4ea4b20f1705736-20170923","Message-ID":"<1506149223.19409.11.camel@mhfsdcap03>","Subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","From":"Chen Zhong <chen.zhong@mediatek.com>","To":"Rob Herring <robh@kernel.org>","Date":"Sat, 23 Sep 2017 14:47:03 +0800","In-Reply-To":"<1506148695.19409.10.camel@mhfsdcap03>","References":"<1505635252-27716-1-git-send-email-chen.zhong@mediatek.com>\n\t<1505635252-27716-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>\n\t<1506148695.19409.10.camel@mhfsdcap03>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_234734_401351_1079EE8D ","X-CRM114-Status":"GOOD (  23.48  )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.1 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tJaechul Lee <jcsing.lee@samsung.com>, \n\tdevicetree@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, \n\tDmitry Torokhov <dmitry.torokhov@gmail.com>,\n\tlinux-kernel@vger.kernel.org, Andi Shyti <andi.shyti@samsung.com>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tKrzysztof Kozlowski <krzk@kernel.org>, linux-input@vger.kernel.org,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-mediatek@lists.infradead.org, \n\tEddie Huang <eddie.huang@mediatek.com>,\n\tLee Jones <lee.jones@linaro.org>, \n\tlinux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774401,"web_url":"http://patchwork.ozlabs.org/comment/1774401/","msgid":"<CAL_JsqJZtn7YLn6o9mQMPD+kuseKLbfKe+JiY=1BosqnVqi5Kw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-25T04:11:24","subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sat, Sep 23, 2017 at 1:47 AM, Chen Zhong <chen.zhong@mediatek.com> wrote:\n> Sorry for the typo.\n>\n> On Sat, 2017-09-23 at 14:38 +0800, Chen Zhong wrote:\n>> On Wed, 2017-09-20 at 15:53 -0500, Rob Herring wrote:\n>> > On Sun, Sep 17, 2017 at 04:00:49PM +0800, Chen Zhong wrote:\n>> > > This patch adds the device tree binding documentation for the MediaTek\n>> > > pmic keys found on PMIC MT6397/MT6323.\n>> > >\n>> > > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>\n>> > > ---\n>> > >  .../devicetree/bindings/input/mtk-pmic-keys.txt    |   41 ++++++++++++++++++++\n>> > >  1 file changed, 41 insertions(+)\n>> > >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n>> > >\n>> > > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n>> > > new file mode 100644\n>> > > index 0000000..fd48ff7\n>> > > --- /dev/null\n>> > > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n>> > > @@ -0,0 +1,41 @@\n>> > > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n>> > > +\n>> > > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n>> > > +and homekey. The key functions are defined as the subnode of the function\n>> > > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n>> > > +of Muti-Function Device (MFD)\n>> > > +\n>> > > +For MT6397/MT6323 MFD bindings see:\n>> > > +Documentation/devicetree/bindings/mfd/mt6397.txt\n>> > > +\n>> > > +Required properties:\n>> > > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n>> > > +- linux,keycodes: Specifies the numeric keycode values to\n>> > > + be used for reporting keys presses. The array can\n>> > > + contain up to 2 entries.\n>> > > +\n>> > > +Optional Properties:\n>> > > +- mediatek,wakeup-keys: Specifies each key can be used as a wakeup source\n>> > > + or not. This can be customized depends on board design.\n>> >\n>> > I think this should be a common property if we're going to put into DT.\n>> > Something like \"wakeup-scancodes\" to be clear the values are the raw\n>> > scancodes. Alternatively, we could list Linux keycodes instead with\n>> > something like \"linux,wakeup-keycodes\".\n>> >\n>> > > +- wakeup-source: PMIC keys can be used as wakeup sources.\n>> >\n>> > Just \"See ../power/wakeup-source.txt\" for the description.\n>> >\n>> > > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n>> > > + pwrkey only, 2 for pwrkey/homekey together, others for disabled.\n>> > > +- debounce-interval: Long press key shutdown debouncing interval time\n>> > > + in seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n>> >\n>> > This property units should be in milliseconds. However, this doesn't\n>> > sound like debounce filtering time if 5-14 seconds. That sounds like\n>> > forced power off time (i.e. for a hung device). This also should be\n>> > common. I imagine we already have some drivers with similar properties.\n>>\n>> Hi Rob,\n>>\n>> I searched in kernel documents and found a similar usage in\n>> \"ti,palmas-pwrbutton.txt\"\n>> \"- ti,palmas-long-press-seconds: Duration in seconds which the power\n>>   button should be kept pressed for Palmas to power off automatically.\"\n>>\n>> Could I just wrote it like this?\n>> mediatek,long-press-seconds = <0>;\n\nThat doesn't really tell what the long press does. How about\n\"power-off-time-sec\"? Surprisingly we don't have a common keyboard\nbinding doc, so please start one and document it there. Then just\nrefer to it.\n\n>>\n>> And for the wakeup source part, how about Dmitry's suggestion?\n\nIt's fine for me.\n\n>> The whole device node would be:\n>>\n>> mt6397keys: mt6397keys {\n>>       compatible = \"mediatek,mt6397-keys\";\n>>       mediatek,long-press-mode = <1>;\n>>       mediatek,long-press-seconds = <0>;\n>>\n>>       power@0 {\n>>               linux,code = <116>;\n\nlinux,keycodes\n\nAlso, you either need a reg property with \"0\" or drop the unit address.\n\n>>               wakeup-source;\n>>       };\n>>\n>>       home@0 {\n> should be home@1 {\n>>               linux,code = <114>;\n>>       };\n>> };\n>>\n>> Thank you.\n>>\n>> >\n>> > Rob\n>>\n>\n>","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"fRTYcPXY\"; dkim-atps=neutral","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0rJk6lTNz9t30\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tMon, 25 Sep 2017 14:12:22 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwKkg-0002Es-KQ; Mon, 25 Sep 2017 04:12:14 +0000","from mail.kernel.org ([198.145.29.99])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwKka-0001yP-Sb; Mon, 25 Sep 2017 04:12:12 +0000","from mail-qt0-f181.google.com (mail-qt0-f181.google.com\n\t[209.85.216.181])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 6492C218B7;\n\tMon, 25 Sep 2017 04:11:46 +0000 (UTC)","by mail-qt0-f181.google.com with SMTP id 47so5676669qts.10;\n\tSun, 24 Sep 2017 21:11:46 -0700 (PDT)","by 10.12.209.75 with HTTP; Sun, 24 Sep 2017 21:11:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=eTOUxe/7V7ANheYatkRZQwN04E3r6ZykjK8BDorz3mc=;\n\tb=fRTYcPXYj7PS6u\n\tuulx1LwdXrPqq+VJtk5uRh2Ps6teoyIkCo+GjrDTnY6dLelvfFi6Eu/EG6NbjpXxqjPf8aS0pSQDF\n\tnXEnHEijNqbLLiC1cooSXnyCBEtDoG7wKdrt6ZfVEzy0ToY1XXNhqDUt82Hw4Vu1HPo2FiD3Jwi+T\n\tcfWIZmW81x7YMgJi4PYMR2j9kX725WLMwZ00KlQBJlTNr5APejaFZvUY70xHZNTcOSzT5t7nPCvMX\n\t6Cj+CLGnUl05apYYi8liGWl7Y6ZLIGFbHsZM8KPbhXJEv3OgayZI4b7GyIwhrKKuXx0wHlXaEzpew\n\tqYJyo4D1sApkSQUYzcJg==;","DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 6492C218B7","X-Gm-Message-State":"AHPjjUi5GJmBuSuh24TPjGYEQI4JXaTvC7QVA5eRZ0wx8jTaPY5+ENK5\n\tP5CxsZOx1Jg8Z70mBzSx9VvDS+0xOLza1TmtYw==","X-Google-Smtp-Source":"AOwi7QBZQQ6jmzxxbOXZvnyyPWNbliVac7JAUsc1jZ25uAAlncBiJg/+X7nNF0GcFZoceXUWxHvafcf55Z/FJH1oSNA=","X-Received":"by 10.200.26.211 with SMTP id h19mr9379154qtk.341.1506312705482; \n\tSun, 24 Sep 2017 21:11:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506149223.19409.11.camel@mhfsdcap03>","References":"<1505635252-27716-1-git-send-email-chen.zhong@mediatek.com>\n\t<1505635252-27716-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>\n\t<1506148695.19409.10.camel@mhfsdcap03>\n\t<1506149223.19409.11.camel@mhfsdcap03>","From":"Rob Herring <robh@kernel.org>","Date":"Sun, 24 Sep 2017 23:11:24 -0500","X-Gmail-Original-Message-ID":"<CAL_JsqJZtn7YLn6o9mQMPD+kuseKLbfKe+JiY=1BosqnVqi5Kw@mail.gmail.com>","Message-ID":"<CAL_JsqJZtn7YLn6o9mQMPD+kuseKLbfKe+JiY=1BosqnVqi5Kw@mail.gmail.com>","Subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","To":"Chen Zhong <chen.zhong@mediatek.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_211209_094587_CD372714 ","X-CRM114-Status":"GOOD (  24.38  )","X-Spam-Score":"-6.4 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-6.4 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [198.145.29.99 listed in list.dnswl.org]\n\t0.5 RCVD_IN_SORBS_SPAM     RBL: SORBS: sender is a spam source\n\t[209.85.216.181 listed in dnsbl.sorbs.net]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tJaechul Lee <jcsing.lee@samsung.com>, \n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tLinus Walleij <linus.walleij@linaro.org>,\n\tDmitry Torokhov <dmitry.torokhov@gmail.com>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tAndi Shyti <andi.shyti@samsung.com>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tKrzysztof Kozlowski <krzk@kernel.org>,\n\t\"linux-input@vger.kernel.org\" <linux-input@vger.kernel.org>,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-mediatek@lists.infradead.org, \n\tEddie Huang <eddie.huang@mediatek.com>,\n\tLee Jones <lee.jones@linaro.org>, \"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>, linux-rtc@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774501,"web_url":"http://patchwork.ozlabs.org/comment/1774501/","msgid":"<1506327256.19409.16.camel@mhfsdcap03>","list_archive_url":null,"date":"2017-09-25T08:14:16","subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","submitter":{"id":72090,"url":"http://patchwork.ozlabs.org/api/people/72090/","name":"Chen Zhong","email":"chen.zhong@mediatek.com"},"content":"On Sun, 2017-09-24 at 23:11 -0500, Rob Herring wrote:\n> On Sat, Sep 23, 2017 at 1:47 AM, Chen Zhong <chen.zhong@mediatek.com> wrote:\n> > Sorry for the typo.\n> >\n> > On Sat, 2017-09-23 at 14:38 +0800, Chen Zhong wrote:\n> >> On Wed, 2017-09-20 at 15:53 -0500, Rob Herring wrote:\n> >> > On Sun, Sep 17, 2017 at 04:00:49PM +0800, Chen Zhong wrote:\n> >> > > This patch adds the device tree binding documentation for the MediaTek\n> >> > > pmic keys found on PMIC MT6397/MT6323.\n> >> > >\n> >> > > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>\n> >> > > ---\n> >> > >  .../devicetree/bindings/input/mtk-pmic-keys.txt    |   41 ++++++++++++++++++++\n> >> > >  1 file changed, 41 insertions(+)\n> >> > >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> >> > >\n> >> > > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> >> > > new file mode 100644\n> >> > > index 0000000..fd48ff7\n> >> > > --- /dev/null\n> >> > > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt\n> >> > > @@ -0,0 +1,41 @@\n> >> > > +MediaTek MT6397/MT6323 PMIC Keys Device Driver\n> >> > > +\n> >> > > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey\n> >> > > +and homekey. The key functions are defined as the subnode of the function\n> >> > > +node provided by MT6397/MT6323 PMIC that is being defined as one kind\n> >> > > +of Muti-Function Device (MFD)\n> >> > > +\n> >> > > +For MT6397/MT6323 MFD bindings see:\n> >> > > +Documentation/devicetree/bindings/mfd/mt6397.txt\n> >> > > +\n> >> > > +Required properties:\n> >> > > +- compatible: \"mediatek,mt6397-keys\" or \"mediatek,mt6323-keys\"\n> >> > > +- linux,keycodes: Specifies the numeric keycode values to\n> >> > > + be used for reporting keys presses. The array can\n> >> > > + contain up to 2 entries.\n> >> > > +\n> >> > > +Optional Properties:\n> >> > > +- mediatek,wakeup-keys: Specifies each key can be used as a wakeup source\n> >> > > + or not. This can be customized depends on board design.\n> >> >\n> >> > I think this should be a common property if we're going to put into DT.\n> >> > Something like \"wakeup-scancodes\" to be clear the values are the raw\n> >> > scancodes. Alternatively, we could list Linux keycodes instead with\n> >> > something like \"linux,wakeup-keycodes\".\n> >> >\n> >> > > +- wakeup-source: PMIC keys can be used as wakeup sources.\n> >> >\n> >> > Just \"See ../power/wakeup-source.txt\" for the description.\n> >> >\n> >> > > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for\n> >> > > + pwrkey only, 2 for pwrkey/homekey together, others for disabled.\n> >> > > +- debounce-interval: Long press key shutdown debouncing interval time\n> >> > > + in seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.\n> >> >\n> >> > This property units should be in milliseconds. However, this doesn't\n> >> > sound like debounce filtering time if 5-14 seconds. That sounds like\n> >> > forced power off time (i.e. for a hung device). This also should be\n> >> > common. I imagine we already have some drivers with similar properties.\n> >>\n> >> Hi Rob,\n> >>\n> >> I searched in kernel documents and found a similar usage in\n> >> \"ti,palmas-pwrbutton.txt\"\n> >> \"- ti,palmas-long-press-seconds: Duration in seconds which the power\n> >>   button should be kept pressed for Palmas to power off automatically.\"\n> >>\n> >> Could I just wrote it like this?\n> >> mediatek,long-press-seconds = <0>;\n> \n> That doesn't really tell what the long press does. How about\n> \"power-off-time-sec\"? Surprisingly we don't have a common keyboard\n> binding doc, so please start one and document it there. Then just\n> refer to it.\n> \n\nOK, I will add a common document named \"keys.txt\" and put the long press\nproperty \"power-off-time-sec\" there as a common property.\n\n> >>\n> >> And for the wakeup source part, how about Dmitry's suggestion?\n> \n> It's fine for me.\n> \n> >> The whole device node would be:\n> >>\n> >> mt6397keys: mt6397keys {\n> >>       compatible = \"mediatek,mt6397-keys\";\n> >>       mediatek,long-press-mode = <1>;\n> >>       mediatek,long-press-seconds = <0>;\n> >>\n> >>       power@0 {\n> >>               linux,code = <116>;\n> \n> linux,keycodes\n> \n> Also, you either need a reg property with \"0\" or drop the unit address.\n\nThere is no need to add reg property here, I'll drop the unit address.\n\nThank you.\n> \n> >>               wakeup-source;\n> >>       };\n> >>\n> >>       home@0 {\n> > should be home@1 {\n> >>               linux,code = <114>;\n> >>       };\n> >> };\n> >>\n> >> Thank you.\n> >>\n> >> >\n> >> > Rob\n> >>\n> >\n> >","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"eEZZA9io\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0xjQ5N74z9s7G\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tMon, 25 Sep 2017 18:15:38 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwOY9-0000lE-Ql; Mon, 25 Sep 2017 08:15:33 +0000","from [210.61.82.184] (helo=mailgw02.mediatek.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwOXl-0007Of-Rf; Mon, 25 Sep 2017 08:15:13 +0000","from mtkcas07.mediatek.inc [(172.21.101.84)] by\n\tmailgw02.mediatek.com (envelope-from <chen.zhong@mediatek.com>)\n\t(mhqrelay.mediatek.com ESMTP with TLS)\n\twith ESMTP id 557830102; Mon, 25 Sep 2017 16:14:18 +0800","from MTKCAS32.mediatek.inc (172.27.4.184) by\n\tmtkmbs08n2.mediatek.inc\n\t(172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1210.3;\n\tMon, 25 Sep 2017 16:13:48 +0800","from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc\n\t(172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend\n\tTransport; Mon, 25 Sep 2017 16:14:04 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=nXgmrEPSi4/wzFTcPEIJsgYJ5ltEllFYh98tCX7mXf4=;\n\tb=eEZZA9ioqtJ5fX\n\twwD2SOc7xJEtIP0rrivkz6VNgmyH4amQCp+114h0g7FufH4IntjQs7jBDZ6hXumyRIVy8qtu1rFKY\n\tzRjw0LLsanRX6n6Cz3JcocyuI/FGPj8e3aEm5JqabLV7dky916pn4yqV764hmCvV/sbYs2pYOi2N9\n\taeOB14UmaOfsk9Yxb6WLlk40TvSt+9InynzZSdt+w/IwWR+Cy9iVLTpOe5MkYbnRgN7K2EDIaPCy9\n\t5aofWs2isWBxp8ni2YBLqpmkGqT5uAEih9Z21y35K0og50kgeKVUqpOka80pvTV25/4Abwo+ZlZLz\n\tpo7Zad5Y85ddSGQH+3fQ==;","X-UUID":"4d3a56592afc40ba93b7276f3766322c-20170925","Message-ID":"<1506327256.19409.16.camel@mhfsdcap03>","Subject":"Re: [PATCH v4 2/5] dt-bindings: input: Add document bindings for\n\tmtk-pmic-keys","From":"Chen Zhong <chen.zhong@mediatek.com>","To":"Rob Herring <robh@kernel.org>","Date":"Mon, 25 Sep 2017 16:14:16 +0800","In-Reply-To":"<CAL_JsqJZtn7YLn6o9mQMPD+kuseKLbfKe+JiY=1BosqnVqi5Kw@mail.gmail.com>","References":"<1505635252-27716-1-git-send-email-chen.zhong@mediatek.com>\n\t<1505635252-27716-3-git-send-email-chen.zhong@mediatek.com>\n\t<20170920205301.v6gpmhll4pdpuyxv@rob-hp-laptop>\n\t<1506148695.19409.10.camel@mhfsdcap03>\n\t<1506149223.19409.11.camel@mhfsdcap03>\n\t<CAL_JsqJZtn7YLn6o9mQMPD+kuseKLbfKe+JiY=1BosqnVqi5Kw@mail.gmail.com>","X-Mailer":"Evolution 3.2.3-0ubuntu6 ","MIME-Version":"1.0","X-MTK":"N","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170925_011510_514557_B10F8805 ","X-CRM114-Status":"GOOD (  30.01  )","X-Spam-Score":"-1.1 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.1 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.8 RDNS_NONE Delivered to internal network by a host with no rDNS\n\t0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay\n\tlines","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tJaechul Lee <jcsing.lee@samsung.com>, \n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\tLinus Walleij <linus.walleij@linaro.org>,\n\tDmitry Torokhov <dmitry.torokhov@gmail.com>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tAndi Shyti <andi.shyti@samsung.com>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tKrzysztof Kozlowski <krzk@kernel.org>,\n\t\"linux-input@vger.kernel.org\" <linux-input@vger.kernel.org>,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tlinux-mediatek@lists.infradead.org, \n\tEddie Huang <eddie.huang@mediatek.com>,\n\tLee Jones <lee.jones@linaro.org>, \"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>, linux-rtc@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]